Compare commits

..

8 Commits

Author SHA1 Message Date
cloudinit-bot 3b7883c092 verify(P3): docs build CI — 4 layers green
docs-build / go test ./... (lexicon firewall + all x/* tests) (push) Has been cancelled
docs-build / mkdocs build (docs site artifact) (push) Has been cancelled
Structural: YAML schema valid; jobs go-test + docs-build; docs-build
needs go-test (G-016 OK). Behavioral: local mkdocs build succeeds (site/
produced); go test ./... green. Security: go.mod unchanged (G-006 intact);
Python deps isolated to docs-build job. Quality: .gitignore covers site/.
NFR purity: zero commit SUBJECTS starting with feat: (grep -E '^feat:'
exit 1 on subject-only check). NOTE: git log --grep matches message BODIES
too (prose mentions 'feat:'); the P4 audit gate uses subject-only check
(git log --format='%s' | grep -E '^feat:').

---ci---
project: oy
phase: 3
milestone: v0.4
status: verify
tag_base: v0.3.x
milestone_type: nfr
reqs: [REQ-032]
---/ci---
2026-08-17 23:33:36 +00:00
cloudinit-bot 1969b96d3d chore(ci): docs build CI workflow (REQ-032, D-046, D-051, G-016)
Add .gitea/workflows/docs-build.yml: on push, go-test job runs go test ./...
(lexicon firewall + all x/* tests), then docs-build job (needs: go-test per
G-016 firewall-gates-docs-build) installs mkdocs + mkdocs-material, runs
mkdocs build, uploads site/ as a CI artifact. go.mod unchanged (Python deps
isolated to the docs-build job; G-006 intact). Full Gitea Pages publishing
deferred per D-051 (no hosting target configured).

.gitignore: add site/ (mkdocs build output; never committed).

Verification: YAML parses; docs-build needs go-test; go test ./... green;
go.mod unchanged; local mkdocs build succeeds (site/ produced).

---ci---
project: oy
phase: 3
milestone: v0.4
status: execute
tag_base: v0.3.x
milestone_type: nfr
reqs: [REQ-032]
---/ci---
2026-08-17 23:33:02 +00:00
cloudinit-bot d149916288 checkpoint(p2): v0.4 phase 2 complete → v0.3.2
P2 shipped: tag v0.3.2, release id 750. REQ-031 covered. Branch
oy/phase/02 deleted. Next: P3 docs build CI.

---ci---
project: oy
phase: 2
milestone: v0.4
status: complete
tag_base: v0.3.x
milestone_type: nfr
phase_release_tag: v0.3.2
---/ci---
2026-08-17 23:32:22 +00:00
cloudinit-bot c4cbd59c11 Merge phase/02 into milestone/v0.4-refinement (P2 complete → v0.3.2)
---ci---
project: oy
phase: 2
milestone: v0.4
status: complete
tag_base: v0.3.x
milestone_type: nfr
---/ci---
2026-08-17 23:32:07 +00:00
cloudinit-bot a6d33a58b3 verify(P2): lifecycle divergence docs + regression guard — 4 layers green
Structural: go vet clean. Behavioral: TestSignalKindShapeIntentional PASS;
existing council tests PASS. Security: no locked-const change
(SignalKindCount==4 preserved). Quality: x/council/types coverage 96.4%
(improved from v0.3; new intent test adds coverage). NFR purity: zero
feat: commits in P2 (only docs + test).

---ci---
project: oy
phase: 2
milestone: v0.4
status: verify
tag_base: v0.3.x
milestone_type: nfr
reqs: [REQ-031]
---/ci---
2026-08-17 23:32:02 +00:00
cloudinit-bot 7d1468b442 docs(arch): council lifecycle divergence decisions (REQ-031, AUDIT §193)
Add ARCHITECTURE.md §"Council Voice/Council Interface — Lifecycle Type
Divergence Decisions (v0.4)": documents P1-1 (Proposal/VoteOption absent,
deferred to v0.5+ governance runtime — feat: rejected by D-001), P1-2
(SignalKind 4-vs-5: the 4-source shape is intentional per AUDIT rationale;
Freeholder is eligibility, Guild is council tier, Capital is committed-
capital per vision §9.1), P2 (bearers ValidateGenesis no-op correct per spec).

test(council): TestSignalKindShapeIntentional regression guard (REQ-031)

Add intent-assertion test locking the 4-source SignalKind shape with the
AUDIT §193 P1-2 rationale in the doc comment. A future agent changing
SignalKindCount 4→5 must update this test, surfacing the rationale. No
locked-const change, no production .go files modified (D-050).

Verification: go test ./... green; only types_test.go modified in x/**.

---ci---
project: oy
phase: 2
milestone: v0.4
status: execute
tag_base: v0.3.x
milestone_type: nfr
reqs: [REQ-031]
---/ci---
2026-08-17 23:31:55 +00:00
cloudinit-bot 92966cb9c5 checkpoint(p1): v0.4 phase 1 complete → v0.3.1
P1 shipped: tag v0.3.1, release id 749. REQ-029, REQ-030 covered.
Branch oy/phase/01 deleted. Next: P2 lifecycle divergence docs+guard.

---ci---
project: oy
phase: 1
milestone: v0.4
status: complete
tag_base: v0.3.x
milestone_type: nfr
phase_release_tag: v0.3.1
---/ci---
2026-08-17 23:31:16 +00:00
cloudinit-bot 838bd06a9d Merge phase/01 into milestone/v0.4-refinement (P1 complete → v0.3.1)
---ci---
project: oy
phase: 1
milestone: v0.4
status: complete
tag_base: v0.3.x
milestone_type: nfr
---/ci---
2026-08-17 23:30:50 +00:00
5 changed files with 148 additions and 6 deletions
+6 -5
View File
@@ -1,13 +1,14 @@
{
"phase": 0,
"phase": 2,
"stage": "complete",
"milestone": "v0.4",
"milestone_type": "nfr",
"tag_base": "v0.3.x",
"phase_role": "pre_execution",
"phase_role": "execution",
"project": "oy",
"attempts": 0,
"updated_at": "2026-08-17T23:30:00Z",
"phase_release_tag": "v0.3.0",
"release_id": 748
"updated_at": "2026-08-17T23:40:00Z",
"phase_release_tag": "v0.3.2",
"release_id": 750,
"reqs_covered": ["REQ-029", "REQ-030", "REQ-031"]
}
+33 -1
View File
@@ -227,4 +227,36 @@ v0.4 touches NO new `x/*` modules. The touched files are:
### v0.4 Interface Contracts (unchanged from v0.3)
v0.4 does not change any cross-component interface. The 6 cross-component interfaces (Standing, Forge/Fold, Mirror, Window, Fee Covenant, Voice/Council) are unchanged. REQ-031 documents a divergence in the Voice/Council interface surface (SignalKind shape) but does not change it.
v0.4 does not change any cross-component interface. The 6 cross-component interfaces (Standing, Forge/Fold, Mirror, Window, Fee Covenant, Voice/Council) are unchanged. REQ-031 documents a divergence in the Voice/Council interface surface (SignalKind shape) but does not change it.
### Council Voice/Council Interface — Lifecycle Type Divergence Decisions (v0.4, REQ-031)
This section documents the lifecycle type shape-divergences flagged by AUDIT.md §193 for the Council/Voice interface surface. v0.4 is a refinement-only NFR milestone (D-047): the D-001 filter REJECTS `feat:`-class enum additions and locked-const shape changes, so these divergences are DOCUMENTED here, not fixed in code. A regression-guard test (`TestSignalKindShapeIntentional` in `x/council/types/types_test.go`) locks the current shape so a future agent does not silently "fix" a divergence by changing a locked const.
**Divergence P1-1 (AUDIT §193): `Proposal`/`ProposalStatus`/`VoteOption` enums absent from `x/council/types`.**
- **Spec source**: P3-01-01 deliverable recommended `Proposal`, `ProposalStatus` (5 states), `VoteOption` (3 options) enums mirroring OZ Governor / `x/gov`.
- **Implemented**: `Council`, `CouncilMember`, `Voice`, `SignalKind`, `TallyResult` — no `Proposal`/`ProposalStatus`/`VoteOption` lifecycle types.
- **Must-have impact**: NONE. The v0.2 P3 must-haves (3 councils, Mission Lock, `TallyResult` x/gov shape, no veto) are all met without the Proposal lifecycle.
- **Decision (v0.4, D-050)**: ADDING `Proposal`/`ProposalStatus`/`VoteOption` is a `feat:`-class addition (new enum types). REJECTED by the D-001 refinement-only filter. **Deferred to v0.5+** when the council keeper is wired to a live governance runtime (the AUDIT's own recommendation: "add in v0.3 when wiring the council keeper to a live governance runtime"). The skeleton council keeper in v0.2 does not consume a Proposal lifecycle; adding the types without the runtime would be dead code.
- **Severity (AUDIT)**: P1 (spec drift from deliverable text, not a must-have, not blocking).
- **v0.4 action**: DOCUMENT only (this section). No code change.
**Divergence P1-2 (AUDIT §193): `SignalKind` 4 sources vs spec `VoiceSource` 5 sources.**
- **Spec source**: P3-01-01 deliverable specified `VoiceSource` with 5 sources (Stash/Standing/Vouch/Freeholder/Guild).
- **Implemented**: `SignalKind` with 4 sources: `SignalStash`, `SignalStanding`, `SignalVouch`, `SignalCapital` (`SignalKindCount = 4`, locked const).
- **Code rationale (AUDIT §193 P1-2)**: the 4-source shape is a defensible design refinement, not a defect:
- `Freeholder` is an ELIGIBILITY property (upstream in `x/standing`), not a voice signal. A Freeholder-eligible Reach is a precondition for voting, not a signal that feeds a vote's weight.
- `Guild` is a COUNCIL TIER (one of the three councils is the Guild Council), not a voice signal. Including Guild as a signal kind would conflate the council tier with the signal source.
- `Capital` is committed-capital (vision §9.1, one of the four Freeholder signals), which the spec's `VoiceSource` list omitted. Adding `Capital` corrects the spec list to match vision §9.1's four-signal definition (REQ-005: "Four Freeholder signals locked").
- **Must-have impact**: NONE. The v0.2 P3 must-haves did not enumerate `VoiceSource` coverage; the 4-signal shape matches REQ-005's "Four Freeholder signals locked" exactly.
- **Decision (v0.4, D-050)**: changing `SignalKindCount` 4→5 (to restore the spec's 5-source `VoiceSource`) is a LOCKED-CONST CHANGE. REJECTED by the D-001 refinement-only filter (changing a locked const is a behavioral change, not a refinement). The 4-source shape is the CORRECT shape per vision §9.1 and REQ-005; the spec deliverable text was wrong, not the implementation.
- **Severity (AUDIT)**: P1 (design-choice divergence, tested and self-consistent, not blocking).
- **v0.4 action**: DOCUMENT the rationale here + add `TestSignalKindShapeIntentional` (regression guard) so a future agent changing `SignalKindCount` from 4 to 5 must also update the intent-assertion test, surfacing the AUDIT rationale for review. No locked-const change.
**Divergence P2 (AUDIT §193): `x/bearers/types` `ValidateGenesis` no-op.**
- **Spec source**: P4-02-01 said "DefaultParams/GenesisState unchanged" (bearers is an EXTENSION in v0.2, not a new module; the A-212 `ValidateGenesis` upgrade was scoped to NEW modules only).
- **Implemented**: `ValidateGenesis` remains a no-op (`x/bearers/types/types.go:108` returns `nil` unconditionally).
- **Decision (v0.4)**: CORRECT per spec — no action (AUDIT explicitly notes "no action"). The A-212 upgrade applies to NEW modules (v0.2's `x/window`, `x/stand`, etc.), not to EXTENDED modules like `x/bearers`. Listed here for completeness; no code change, no test change.
+55
View File
@@ -0,0 +1,55 @@
# OpenYield docs build CI (REQ-032, D-046 forward-reference, D-051, G-016).
#
# Runs the lexicon firewall (go test ./...) AND builds the MkDocs Material docs
# site on every push. The docs-build job DEPENDS on go-test (G-016 binding:
# firewall-gates-docs-build — a lexicon violation blocks the docs build so no
# false-green docs artifact is produced from a repo with a firewall failure).
#
# Scope (chore, not feat: per D-001 refinement-only filter):
# - go-test job: setup Go 1.22, run `go test ./...` (lexicon firewall + all
# x/* tests + the v0.4 cross-const test). Zero external Go deps (G-006).
# - docs-build job: setup Python, pip install mkdocs + mkdocs-material
# (build-only Python deps, ISOLATED to this job — go.mod is NOT modified),
# run `mkdocs build` (produces site/), upload site/ as a CI artifact.
#
# Out of scope (deferred per D-051): full Gitea Pages publishing. v0.4 ships
# build + artifact only; a hosting target is not configured.
#
# Triggers: on push (all branches) so the firewall + docs build are checked
# on every change, not just on main.
name: docs-build
on:
push:
jobs:
go-test:
name: go test ./... (lexicon firewall + all x/* tests)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
- name: go test ./...
run: go test ./...
docs-build:
name: mkdocs build (docs site artifact)
runs-on: ubuntu-latest
needs: go-test # G-016: firewall-gates-docs-build (no false-green docs build)
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: install mkdocs + mkdocs-material
run: pip install mkdocs mkdocs-material
- name: mkdocs build
run: mkdocs build
- name: upload site/ artifact
uses: actions/upload-artifact@v4
with:
name: docs-site
path: site/
retention-days: 14
+2
View File
@@ -2,3 +2,5 @@
.env.secrets
.env.*
.ciagent/.env.secrets
# MkDocs build output (REQ-032 CI produces site/ as an artifact; never commit it)
site/
+52
View File
@@ -109,6 +109,58 @@ func TestSignalKindCountLockedConst(t *testing.T) {
}
}
// TestSignalKindShapeIntentional (REQ-031, AUDIT §193 P1-2) is a regression
// GUARD that documents and locks the 4-source SignalKind shape. It is NOT a
// shape change — the existing TestSignalKindCountLockedConst already locks
// the count. This test adds the INTENT documentation so a future agent who
// changes SignalKindCount from 4 to 5 (e.g., to "restore" the spec's 5-source
// VoiceSource list) must also update this test, surfacing the AUDIT rationale
// for review.
//
// AUDIT §193 P1-2 rationale (why SignalKind is 4 sources, NOT the spec's 5):
//
// The v0.2 P3-01-01 deliverable specified VoiceSource with 5 sources
// (Stash/Standing/Vouch/Freeholder/Guild). The implementation uses
// SignalKind with 4 sources (Stash/Standing/Vouch/Capital). The 4-source
// shape is a defensible design refinement:
// - Freeholder is an ELIGIBILITY property (upstream in x/standing), not
// a voice signal. A Freeholder-eligible Reach is a precondition for
// voting, not a signal that feeds a vote's weight.
// - Guild is a COUNCIL TIER (one of the three councils is the Guild
// Council), not a voice signal. Including Guild as a signal kind
// would conflate the council tier with the signal source.
// - Capital is committed-capital (vision §9.1, one of the four
// Freeholder signals per REQ-005), which the spec's VoiceSource list
// omitted. Adding Capital corrects the spec to match vision §9.1's
// four-signal definition (REQ-005: "Four Freeholder signals locked").
//
// The 4-source shape matches REQ-005 exactly. The spec deliverable text
// was wrong, not the implementation. v0.4 (D-050) DOCUMENTS this and
// locks the 4-source shape; changing it to 5 is a locked-const change
// rejected by the D-001 refinement-only filter and deferred to a future
// milestone that re-litigates REQ-005's signal definition.
//
// See .ciagent/oy/ARCHITECTURE.md §"Council Voice/Council Interface —
// Lifecycle Type Divergence Decisions (v0.4, REQ-031)" for the full rationale.
func TestSignalKindShapeIntentional(t *testing.T) {
// LOCKED: 4 sources. Changing this to 5 requires updating this test's
// intent block AND re-litigating REQ-005's four-signal definition.
const expectedSignalCount = 4
if types.SignalKindCount != expectedSignalCount {
t.Fatalf("SignalKindCount = %d, want %d (REQ-031 intent guard: the 4-source shape is intentional per AUDIT §193 P1-2; see ARCHITECTURE.md v0.4 divergence section before changing this)", types.SignalKindCount, expectedSignalCount)
}
want := []types.SignalKind{types.SignalStash, types.SignalStanding, types.SignalVouch, types.SignalCapital}
all := types.AllSignalKinds()
if len(all) != len(want) {
t.Fatalf("AllSignalKinds() len = %d, want %d", len(all), len(want))
}
for i, s := range all {
if s != want[i] {
t.Errorf("AllSignalKinds()[%d] = %q, want %q (REQ-031 intent guard: the 4-source shape {Stash, Standing, Vouch, Capital} is intentional per AUDIT §193 P1-2; Freeholder and Guild are NOT signal kinds)", i, s, want[i])
}
}
}
// TestAllSignalKindsNames asserts the 4 signal names (Stash, Standing,
// Vouch, Capital) cross-ref v0.1 x/standing FreeholderSignals (StashMaturity,
// MultiDomainStanding, CommunityEndorsement, CommittedCapital).