verify(P01): 4-layer PASS — REQ-097, REQ-098; gate C-21 cleared

---ci---
project: orca
phase: 1
milestone: v0.10
status: verify
---/ci---

.ciagent/CHECKPOINT.json

@@ -1,20 +1,24 @@
 {
-  "phase": 0,
+  "phase": 1,
-  "stage": "plan",
+  "stage": "verify",
   "milestone": "v0.10",
   "milestone_slug": "docs-cli-examples",
-  "phase_role": "pre_execution",
+  "phase_role": "execution",
   "attempts": 0,
-  "updated_at": "2026-08-05T20:00:00Z",
+  "updated_at": "2026-08-05T20:30:00Z",
   "milestone_complete": false,
   "ship": {
-    "tag": null,
+    "tag": "v0.9.0",
     "merged_to_main": false,
     "milestone_branch_deleted": false,
-    "all_phase_branches_deleted": false
+    "all_phase_branches_deleted": true
   },
   "requirements": {
     "covered": [],
     "partial": []
+  },
+  "gates": {
+    "cleared": ["C-21"],
+    "pending": ["C-20", "C-22"]
   }
 }

scripts/install.sh

@@ -9,11 +9,16 @@
 # Options:
 #   --system         Install at system level (/usr/local/bin/orca, namespace /root/.orca). Requires root.
 #   --version <tag>  Pin a specific version (e.g. v0.4.2). Default: latest release.
+#   --check           Dry-run: print the version + asset URL + install path without writing.
 #   --help, -h       Show this help.
 #
 # Behavior:
 #   - Downloads the release tarball from the public Gitea release URL.
 #   - Extracts the orca binary to the install path.
+#   - If the resolved release (latest or pinned) has no matching binary
+#     asset, walks backward through recent releases to find one that does,
+#     and prints a warning. (REQ-098 — the v0.8.x releases shipped with
+#     zero binary assets, causing install to resolve to v0.4.5.)
 #   - If an existing orca binary is found, reads its version and prints
 #     "updated from X to Y" (in-place update; preserves config/db/certs).
 #   - Idempotent: re-running with the same version reinstalls the binary.
@@ -27,6 +32,7 @@ GITEA_REPO="${GITEA_REPO:-orca}"
 
 SYSTEM=false
 VERSION=""
+CHECK=false
 INSTALL_BIN=""
 NAMESPACE_DIR=""
 
@@ -45,6 +51,7 @@ while [ $# -gt 0 ]; do
     --system)  SYSTEM=true; shift ;;
     --version) VERSION="${2:-}"; shift 2 ;;
     --version=*) VERSION="${1#*=}"; shift ;;
+    --check)   CHECK=true; shift ;;
     --help|-h) usage ;;
     *) err "unknown argument: $1 (try --help)" ;;
   esac
@@ -91,16 +98,46 @@ esac
 OS="$(uname -s | tr '[:upper:]' '[:lower:]')"
 TARBALL="orca-${VERSION}-${OS}-${ARCH}.tar.gz"
 
-# --- find asset download URL ----------------------------------------------
+# --- find asset download URL (with fallback walk — REQ-098) --------------
+#
+# The v0.8.x releases shipped with zero binary assets attached, causing
+# install to error out on the latest release. If the resolved release
+# (latest or --version) lacks the matching tarball, walk backward through
+# recent releases to find one that carries it, and print a warning.
 
-info "locating asset ${TARBALL}..."
+find_asset_url() {
-ASSET_URL="$(curl -fsSL "${GITEA_URL}/api/v1/repos/${GITEA_OWNER}/${GITEA_REPO}/releases/tags/${VERSION}" \
+  # $1 = tag. Prints the browser_download_url for the matching tarball, or empty.
-  | sed -n 's/.*"browser_download_url"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p' \
+  # The `|| true` prevents set -e + pipefail from exiting the script when
-  | grep "/${TARBALL}\$" \
+  # grep finds no match (exit 1) — an empty result is a valid outcome.
-  | head -1)"
+  local tag="$1"
+  curl -fsSL "${GITEA_URL}/api/v1/repos/${GITEA_OWNER}/${GITEA_REPO}/releases/tags/${tag}" \
+    | sed -n 's/.*"browser_download_url"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p' \
+    | grep "/${TARBALL}\$" \
+    | head -1 || true
+}
+
+info "locating asset ${TARBALL} in release ${VERSION}..."
+ASSET_URL="$(find_asset_url "$VERSION")"
 
 if [ -z "$ASSET_URL" ]; then
-  err "could not find asset ${TARBALL} in release ${VERSION}. Check that the release exists and has a linux-${ARCH} tarball."
+  info "WARNING: release ${VERSION} has no ${TARBALL} asset. Walking back through recent releases..."
+  # The /releases list endpoint returns assets inline (browser_download_url
+  # appears within each release's assets array). Extract all download URLs
+  # from the list response and find the first (newest) one matching our
+  # OS+arch tarball pattern (any version). This avoids per-release API calls.
+  ASSET_URL="$(curl -fsSL "${GITEA_URL}/api/v1/repos/${GITEA_OWNER}/${GITEA_REPO}/releases?limit=50" \
+    | grep -oE '"browser_download_url"[[:space:]]*:[[:space:]]*"[^"]*"' \
+    | sed -n 's/.*"browser_download_url"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p' \
+    | grep -E "/orca-[^/]*-${OS}-${ARCH}\.tar\.gz$" \
+    | head -1 || true)"
+  if [ -n "$ASSET_URL" ]; then
+    # Extract the version from the URL (e.g. .../download/v0.4.5/orca-...)
+    FALLBACK_VERSION="$(echo "$ASSET_URL" | sed -n 's|.*/download/\([^/]*\)/.*|\1|p')"
+    info "WARNING: latest release ${VERSION} has no binary asset; falling back to ${FALLBACK_VERSION} which has orca-${FALLBACK_VERSION}-${OS}-${ARCH}.tar.gz."
+    VERSION="$FALLBACK_VERSION"
+  else
+    err "could not find any release with a ${OS}-${ARCH} tarball in the last 50 releases. Check that a release exists with a linux-${ARCH} binary."
+  fi
 fi
 info "asset: ${ASSET_URL}"
 
@@ -111,6 +148,23 @@ if [ -x "$INSTALL_BIN" ]; then
   OLD_VERSION="$("$INSTALL_BIN" version --json 2>/dev/null | sed -n 's/.*"version"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p' | head -1 || echo "")"
 fi
 
+# --- --check dry-run (D-194) ---------------------------------------------
+# Print what would be installed without writing anything.
+
+if [ "$CHECK" = "true" ]; then
+  info "dry-run (--check): no files will be written"
+  info "  would install:  orca ${VERSION}"
+  info "  asset:          ${ASSET_URL}"
+  info "  binary path:     ${INSTALL_BIN}"
+  info "  namespace root:  ${NAMESPACE_DIR}"
+  if [ -n "$OLD_VERSION" ]; then
+    info "  current:        ${OLD_VERSION} (would update to ${VERSION})"
+  else
+    info "  current:        (not installed)"
+  fi
+  exit 0
+fi
+
 # --- download + extract ---------------------------------------------------
 
 TMPDIR="$(mktemp -d)"

scripts/release.sh

@@ -75,26 +75,26 @@ info "version: $VERSION"
 info "building..."
 
 # --- build with version injection ----------------------------------------
+# Cross-build linux-amd64 regardless of host arch (D-193). The install.sh
+# user base is amd64; the .coreci.yml release step hardcodes the amd64
+# tarball name. Building for the host arch produced the wrong tarball when
+# the release was cut from an arm64 dev machine — the root cause of the
+# v0.4.5 install incident (REQ-097).
 
 GIT_COMMIT="$(git rev-parse --short HEAD)"
 BUILD_TIME="$(date -u +%Y-%m-%dT%H:%M:%SZ)"
 LDFLAGS="-s -w -X git.cloudinit.dev/coreci/orca/internal/cli.version=$VERSION -X git.cloudinit.dev/coreci/orca/internal/cli.gitCommit=$GIT_COMMIT -X git.cloudinit.dev/coreci/orca/internal/cli.buildTime=$BUILD_TIME"
 
 mkdir -p bin
-go build -trimpath -ldflags="$LDFLAGS" -o bin/orca ./cmd/orca
+info "building orca-${VERSION}-linux-amd64 (cross-compile, CGO_ENABLED=0)..."
-info "built: bin/orca"
+CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -trimpath -ldflags="$LDFLAGS" -o bin/orca ./cmd/orca
+info "built: bin/orca (linux-amd64)"
 
 # --- tarball --------------------------------------------------------------
+# Always produce the linux-amd64 tarball name that install.sh looks for.
+# (D-193: arm64 is a separate enhancement; this milestone ships amd64 only.)
 
-OS="$(uname -s | tr '[:upper:]' '[:lower:]')"
+TARBALL="orca-${VERSION}-linux-amd64.tar.gz"
-ARCH="$(uname -m)"
-case "$ARCH" in
-  x86_64) ARCH=amd64 ;;
-  aarch64) ARCH=arm64 ;;
-  armv7l) ARCH=armv7 ;;
-esac
-
-TARBALL="orca-${VERSION}-${OS}-${ARCH}.tar.gz"
 tar -czf "$TARBALL" -C bin orca
 info "packaged: $TARBALL ($(du -h "$TARBALL" | cut -f1))"
 
@@ -135,7 +135,38 @@ tea releases create "$VERSION" \
   --note-file "$NOTES_FILE" \
   --asset "$TARBALL"
 
-info "✓ release $VERSION published"
+# --- post-create asset verification (REQ-097, gate C-21) ------------------
+# tea releases create has been observed to exit 0 without attaching the
+# asset in some versions. Verify the asset actually appears in the release
+# via the Gitea API; retry once if missing; fail loudly if still missing.
+# This is the root-cause fix for the v0.8.x releases that shipped with zero
+# binary assets.
+
+verify_asset() {
+  local tag="$1" want="$2"
+  curl -fsSL "${GITEA_URL:-https://git.cloudinit.dev}/api/v1/repos/${GITEA_OWNER:-coreci}/${GITEA_REPO:-orca}/releases/tags/${tag}" \
+    | sed -n 's/.*"name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p' \
+    | grep -qx "$want"
+}
+
+info "verifying asset ${TARBALL} attached to release ${VERSION}..."
+if verify_asset "$VERSION" "$TARBALL"; then
+  info "✓ asset verified: ${TARBALL}"
+else
+  info "asset missing after tea releases create; retrying upload..."
+  # Retry: re-add the asset via tea releases edit
+  tea release edit "$VERSION" --repo "$REPO" --asset "$TARBALL" 2>/dev/null \
+    || tea releases edit "$VERSION" --repo "$REPO" --asset "$TARBALL" 2>/dev/null \
+    || true
+  sleep 2
+  if verify_asset "$VERSION" "$TARBALL"; then
+    info "✓ asset verified on retry: ${TARBALL}"
+  else
+    err "asset ${TARBALL} NOT attached to release ${VERSION} after retry — the release exists but has no binary. Run 'tea releases edit ${VERSION} --repo $REPO --asset $TARBALL' manually. (REQ-097, C-21)"
+  fi
+fi
+
+info "✓ release $VERSION published with binary asset"
 
 # --- publish container image to gitea registry (REQ-046) ------------------
 # Skipped gracefully if docker is not on PATH (e.g. local dev without docker).

scripts/tests/install_test.bash

@@ -0,0 +1,62 @@
+#!/usr/bin/env bats
+# Tests for scripts/install.sh (REQ-098: fallback walk + --check dry-run).
+# Hermetic: tests the argument parsing, arch detection, and --check
+# output formatting without hitting the Gitea API. The network-dependent
+# fallback walk is tested via a mock curl in a separate test.
+
+load test_helper
+
+@test "install.sh --help exits 0 and shows usage" {
+	run "$SCRIPTS_DIR/install.sh" --help
+	assert_status 0 "$status"
+	assert_contains "$output" "--system"
+	assert_contains "$output" "--version"
+	assert_contains "$output" "--check"
+	assert_contains "$output" "--help"
+}
+
+@test "install.sh --check flag is parsed without error" {
+	# --check with a pinned version that exists (v0.4.5) should succeed
+	# and print the dry-run block. This is a live integration test against
+	# the public Gitea API; skip if network is unavailable.
+	skip_if_no_network
+	run "$SCRIPTS_DIR/install.sh" --check --version v0.4.5
+	assert_status 0 "$status"
+	assert_contains "$output" "dry-run (--check)"
+	assert_contains "$output" "would install:  orca v0.4.5"
+	assert_contains "$output" "no files will be written"
+}
+
+@test "install.sh --check falls back when latest release has no asset" {
+	# v0.9.0 is a pre-execution release with no binary asset. --check
+	# should walk back and find v0.4.5 (which has an asset), printing
+	# a warning. This is a live integration test; skip if no network.
+	skip_if_no_network
+	run timeout 60 "$SCRIPTS_DIR/install.sh" --check --version v0.9.0
+	assert_status 0 "$status"
+	assert_contains "$output" "WARNING"
+	assert_contains "$output" "falling back"
+	assert_contains "$output" "dry-run (--check)"
+}
+
+@test "install.sh rejects unknown arguments" {
+	run "$SCRIPTS_DIR/install.sh" --bogus-flag
+	[ "$status" -ne 0 ]
+	assert_contains "$output" "unknown argument"
+}
+
+@test "install.sh --system requires root" {
+	# Only test the root check if we're NOT root (CI may run as root).
+	if [ "$(id -u)" -eq 0 ]; then
+		skip "running as root; --system root check not testable"
+	fi
+	run "$SCRIPTS_DIR/install.sh" --system --version v0.4.5 --check
+	[ "$status" -ne 0 ]
+	assert_contains "$output" "--system requires root"
+}
+
+# Helper: skip if the Gitea instance is unreachable.
+skip_if_no_network() {
+	curl -fsSL --max-time 5 "https://git.cloudinit.dev/api/v1/repos/coreci/orca/releases/tags/v0.4.5" >/dev/null 2>&1 \
+		|| skip "Gitea API unreachable — network-dependent test skipped"
+}

scripts/tests/release_test.bash

@@ -0,0 +1,44 @@
+#!/usr/bin/env bats
+# Tests for scripts/release.sh (REQ-097: cross-build amd64, asset verification).
+# Hermetic: tests the tarball naming and cross-build logic without
+# publishing a release. The full release flow requires GITEA_TOKEN + tea
+# and is tested in CI.
+
+load test_helper
+
+@test "release.sh exists and is executable" {
+	[ -f "$SCRIPTS_DIR/release.sh" ]
+	[ -x "$SCRIPTS_DIR/release.sh" ]
+}
+
+@test "release.sh --help or usage shows required tools" {
+	# release.sh doesn't have a --help flag; the header comment is the
+	# usage. Verify the script is syntactically valid.
+	run bash -n "$SCRIPTS_DIR/release.sh"
+	assert_status 0 "$status"
+}
+
+@test "release.sh cross-builds linux-amd64 regardless of host arch" {
+	# Verify the script contains the cross-build command (D-193, REQ-097).
+	# We check the source rather than running it (which requires go + tea).
+	run grep -c "GOOS=linux GOARCH=amd64" "$SCRIPTS_DIR/release.sh"
+	[ "$status" -eq 0 ]
+	[ "$output" -ge 1 ]
+}
+
+@test "release.sh hardcodes linux-amd64 tarball name" {
+	# The tarball name must be linux-amd64 (not host-arch-dependent).
+	run grep -c "orca-\${VERSION}-linux-amd64.tar.gz" "$SCRIPTS_DIR/release.sh"
+	[ "$status" -eq 0 ]
+	[ "$output" -ge 1 ]
+}
+
+@test "release.sh has post-create asset verification (C-21)" {
+	# Verify the script contains the asset verification logic.
+	run grep -c "verifying asset" "$SCRIPTS_DIR/release.sh"
+	[ "$status" -eq 0 ]
+	[ "$output" -ge 1 ]
+	run grep -c "verify_asset" "$SCRIPTS_DIR/release.sh"
+	[ "$status" -eq 0 ]
+	[ "$output" -ge 1 ]
+}