fix(P07): verification - 4 layers pass
Layer 1 (Structural): scripts/backfill_releases.sh is mode 755,
171 lines, parses cleanly under 'bash -n'. .gitignore has '.env' on
line 11 (alongside '.env.local'). .ciagent/PHASE7_SECURITY_AUDIT.md
exists, 57 lines / 2574 bytes.
Layer 2 (Behavioral): idempotency path is EXISTING=$(tea releases list
...) | awk + 'grep -qx $TAG' skip branch (lines 52, 82-85). Error
paths: ': ${GITEA_TOKEN:?GITEA_TOKEN is required}' on line 37 exits
non-zero with a clear message when .env is missing; 'command -v'
guards on lines 38-40 exit 1 with 'err' for missing tea/go/tar.
Tarball naming on line 101 is orca-${TAG}-${OS}-${ARCH}.tar.gz,
matches the orca-<tag>-<os>-<arch>.tar.gz convention.
Layer 3 (Security): .env is sourced from a list of well-known paths
(lines 24-32) via 'set -a' ... '. file' ... 'set +a', so the token
is exported into the script's environment. The script never echoes
$ GITEA_TOKEN and never passes it as a CLI argument to 'tea' — the
'tea releases create' invocation on lines 161-165 carries --repo,
--title, --note-file, --asset, but no --token flag (tea reads it
from its own config). .gitignore now excludes .env (forward fix).
The pre-existing secret leak in 0cba1aa (verified: 'git show
--stat 0cba1aa' lists '.env | 2 ++') is documented in
PHASE7_SECURITY_AUDIT.md as P0 for human remediation out-of-band;
the existing token still works and the backfill ran successfully,
so the leak does not block this verify.
Layer 4 (Quality): 'go build ./...' exits 0 (clean). 'go vet ./...'
exits 0 (clean). Both P07 execute commits use 'fix(P07):' Conventional
Commits prefixes, and their ---ci--- blocks parse correctly (project,
phase, milestone, status, version, requirements.covered,
requirements.partial all present and well-formed).
Result: PASS on all 4 layers. Phase 7 is verified.
---ci---
project: orca
phase: 7
milestone: v0.1
status: verify
version: v0.1.7
requirements:
covered: [REQ-007]
partial: []
---/ci---
This commit is contained in:
Jon Chery