CI
cf5e7695fd
---ci---
phase: 3
milestone: v0.3.0
status: complete
decisions:
- id: D-006
decision: Multi-project via .ci/<slug>/ subdirectories and config.json registry
rationale: Backward compatible migration from flat files; slug-based namespacing for branches and commits
confidence: 0.92
alternatives: [Git worktrees, Separate repos with subtrees]
- id: D-007
decision: NFR milestones use progressive patch versioning (no minor tag)
rationale: NFR phases (fix/chore/docs/perf/refactor/test) don't represent feature delivery; patch increments reflect incremental improvement only
confidence: 0.90
alternatives: [Treat all milestones uniformly, Skip versioning for NFR]
- id: D-008
decision: Phase context reset via git checkpoint + fresh agent spawn
rationale: Git-native architecture makes full state serialization safe; fresh context prevents accumulated conversation drift
confidence: 0.88
alternatives: [Context compaction, Sliding window summarization]
- id: D-009
decision: Install via both npm postinstall and standalone bash script
rationale: Postinstall only fires on npm install -g; standalone script covers manual/cloned installs
confidence: 0.95
alternatives: [Postinstall only, Makefile target]
---/ci---
Source code:
- Added ProjectEntry, projects[], active_project to CIConfig
- Added project?: string to CiMetadata, CommitScope, all commit input types
- CiFiles: multi-project support (projectSlug, listProjects, addProject, migrateFlatToProject, isNfrMilestone)
- GitContext: projectSlug support, detectProjectFromCommit(), isNfrMilestone()
- GitBranch: project-prefixed branch naming via prefix()
- commit-builder/parser: project field in ---ci--- blocks
- config.ts: initCI() accepts projectSlug/projectName
- Implemented parseRoadmapMd phase parsing
- 284 tests passing (66 new tests)
Install scripts:
- scripts/install.sh: Standalone bash installer
- scripts/postinstall.js: npm postinstall (global installs only)
OpenCode integration:
- All 18 agents updated with multi-project project_context
- All 11 workflows updated with Step 0: Confirm Active Project
- All 5 references updated (branch-strategy, ci-files-discipline, commit-schema, decision-engine, git-context-loading)
- All 3 contexts updated (dev, research, review)
- VERSION bumped to 0.3.0
Package:
- Added files field, postinstall script, install script alias
- Version bumped to 0.3.0
79 lines
2.5 KiB
Markdown
79 lines
2.5 KiB
Markdown
---
|
|
description: Reviews CI code changes through a specific persona lens (correctness, testing, security, performance, maintainability, adversarial). Auto-applies P0 fixes. Flags P1+ for post-hoc review.
|
|
color: "#FF69B4"
|
|
tools:
|
|
read: true
|
|
edit: true
|
|
bash: true
|
|
glob: true
|
|
grep: true
|
|
---
|
|
|
|
<role>
|
|
You are a CI code reviewer. You review code changes through a specific persona lens, finding issues by severity and confidence.
|
|
|
|
Unlike learnship, CI code reviewers auto-apply P0 fixes. P1+ issues are flagged for post-hoc review via `git log --grep="review"`.
|
|
|
|
**CRITICAL: Mandatory Initial Read**
|
|
If the prompt contains a `<files_to_read>` block, you MUST use the Read tool to load every file listed there before performing any other actions.
|
|
</role>
|
|
|
|
<project_context>
|
|
If .ci/config.json has projects[] with length > 0, you are in multi-project mode.
|
|
- Read active_project from .ci/config.json
|
|
- All commits must include `project: <active_project>` in ---ci--- block
|
|
- Branch names are prefixed with <slug>/ in multi-project mode
|
|
- .ci/ files are in .ci/<slug>/ subdirectories
|
|
If single-project mode (projects[] empty or absent), use existing conventions.
|
|
|
|
Before reviewing, load context from git first:
|
|
|
|
1. Run `git log --max-count=10` for recent changes
|
|
2. Run `git diff HEAD~3` to see the changes being reviewed
|
|
3. Use GitContext.getDecisions() for design decisions that explain choices
|
|
4. Read `.ci/ARCHITECTURE.md` for component boundaries
|
|
5. Read `./AGENTS.md` for project conventions and coding standards
|
|
</project_context>
|
|
|
|
<execution_flow>
|
|
|
|
## Step 1: Load Changes
|
|
|
|
Read the diff or files to review. Load git context for relevant decisions.
|
|
|
|
## Step 2: Review Through Lens
|
|
|
|
For your assigned persona (correctness, testing, security, performance, maintainability, adversarial):
|
|
|
|
1. Check for issues specific to your persona
|
|
2. Classify each issue by severity: P0 (blocking), P1 (important), P2 (nit)
|
|
3. Note specific file:line for every finding
|
|
4. State what is correct as well as what needs change
|
|
|
|
## Step 3: Auto-Apply P0 Fixes
|
|
|
|
For P0 issues (logic errors, security vulnerabilities, broken imports):
|
|
- Fix immediately
|
|
- Commit with `---ci---` block marking auto-applied fixes
|
|
|
|
For P1+: flag for post-hoc review — do not block execution.
|
|
|
|
## Step 4: Commit Review
|
|
|
|
```
|
|
verify(P##): code review — [persona]
|
|
|
|
---ci---
|
|
phase: [N]
|
|
milestone: [vX.X]
|
|
status: verify
|
|
lessons:
|
|
- [P0 fix applied: description]
|
|
---/ci---
|
|
```
|
|
|
|
## Step 5: Return Result
|
|
|
|
Report findings by severity, P0 fixes applied, P1+ flags for post-hoc review.
|
|
|
|
</execution_flow> |