Jon Chery
f68f85c9fd
---ci---
project: acdl
phase: 20
milestone: v1.5
status: review
verdict: READY TO SHIP
p0: 1 (fixed — contract path resolution in deploy workflow)
p1: 6 (flagged post-hoc)
---/ci---
Multi-persona review of v1.5 phase 20 (docs + reusable deploy workflow).
P0 (blocking) — AUTO-FIXED:
- C1: scripts/run_platform.sh contract path resolution broken in deploy
workflow. The reusable workflow invokes run_platform.sh from the consumer
workspace root with a relative contract path (.acdl/contract.yaml), but
run_platform.sh does `cd "$ROOT"` (platform repo) early, so the relative
path resolved against the platform repo and the pipeline could never run.
Fix (commit 75c2274): capture CALLER_CWD before cd "$ROOT"; resolve
caller-supplied relative paths against CALLER_CWD; default no-arg contract
stays relative to ROOT (preserves platform-local CI). Reproduced pre-fix;
verified post-fix.
P1 (important) — FLAGGED FOR POST-HOC REVIEW (do not block ship):
- C2: ref: v1.4 in the deploy workflow platform checkout — no v1.4 tag exists
(only v1.4.0 / v1.4.1). Operator must create a floating v1.4 tag or change
the ref to v1.4.1.
- C3: modules/l2/{static-asset,microservice}/README.md still use @v1 in their
Usage examples; missed by the v1.4 bump.
- S1: static-key override is not wired. ACDL_AWS_* env vars on the OIDC step
are not read by aws-actions/configure-aws-credentials@v4 (it reads AWS_*
or its own access-key/secret-key inputs). The README/CONSUMER_GUIDE claim
a working override that doesn't function as written. Needs a conditional
step or renamed env vars + input wiring.
- S2: README overstates ABAC repo:org/repo:ref:... scoping. The workflow
constructs a numeric role name (github.repository_id); the actual claim
enforcement lives in the IAM trust policy, not in this workflow.
- T1: no deploy-workflow triggers conformance test (CI workflow has one;
deploy doesn't). Minor — reusable workflows use workflow_call, not push
triggers, but the contract's triggers field is then unenforced.
- A1: terraform/spike/terraform.tf uploaded as artifact leaks the AWS account
ID via the state-backend bucket name. Recommend excluding terraform.tf or
gating artifact upload to non-public repos.
P2 (nits) — listed for awareness: floating-tag terminology imprecision (M1),
header comment "Gitea Actions" in the GitHub copy (M2, intentional byte-
identical), pip install split (P1-perf), comment drift in pipelines/deploy.yaml
header (C4), module README internal inconsistency (C5).
Verdict: READY TO SHIP. The one P0 is fixed. The 6 P1s are post-hoc items —
the deploy workflow is a scaffold whose first real consumer run requires
operator setup (tag, IAM role, secrets) that gates go-live. The P1s should
be addressed before any consumer invokes uses: acdl/.gitea/workflows/
deploy.yml@v1.4 in earnest.
Tests: 154 pass (19 new). run_ci.sh green.
64 lines
1.7 KiB
JSON
64 lines
1.7 KiB
JSON
{
|
|
"name": "vpc",
|
|
"version": "1.0.0",
|
|
"kind": "l1",
|
|
"type": "aws:ec2:vpc",
|
|
"description": "VPC primitive (substrate-agnostic stack types aws:ec2:vpc + aws:ec2:subnet + aws:ec2:routetable; the Terraform adapter translates to aws_vpc/aws_subnet/aws_route_table).",
|
|
"inputs": {
|
|
"cidr": {
|
|
"type": "string",
|
|
"description": "VPC CIDR block, e.g. 10.0.0.0/16.",
|
|
"required": true
|
|
},
|
|
"azs": {
|
|
"type": "string",
|
|
"description": "Comma-separated availability zones, e.g. us-east-1a,us-east-1b.",
|
|
"required": true
|
|
},
|
|
"name": {
|
|
"type": "string",
|
|
"description": "Name tag for the VPC and child resources.",
|
|
"required": true
|
|
},
|
|
"region": {
|
|
"type": "string",
|
|
"description": "AWS region the VPC is created in.",
|
|
"required": true
|
|
}
|
|
},
|
|
"outputs": {
|
|
"vpc_id": {
|
|
"type": "string",
|
|
"description": "The VPC id."
|
|
},
|
|
"subnet_ids": {
|
|
"type": "string",
|
|
"description": "Comma-separated subnet ids."
|
|
}
|
|
},
|
|
"nfrs": {},
|
|
"resources": [
|
|
{
|
|
"type": "aws:ec2:vpc",
|
|
"description": "The VPC itself.",
|
|
"inputs": ["cidr", "name"],
|
|
"outputs": ["vpc_id"]
|
|
},
|
|
{
|
|
"type": "aws:ec2:subnet",
|
|
"description": "One subnet per availability zone (azs split on comma).",
|
|
"inputs": ["cidr", "az", "vpc_id", "name"],
|
|
"outputs": ["subnet_id"]
|
|
},
|
|
{
|
|
"type": "aws:ec2:routetable",
|
|
"description": "Route table bound to the VPC with an internet gateway + default route.",
|
|
"inputs": ["vpc_id"],
|
|
"outputs": []
|
|
}
|
|
],
|
|
"intra_refs": [
|
|
{"from": "aws:ec2:subnet.vpc_id", "to": "aws:ec2:vpc.vpc_id"},
|
|
{"from": "aws:ec2:routetable.vpc_id", "to": "aws:ec2:vpc.vpc_id"}
|
|
]
|
|
} |