Compare commits
61 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 732998b01f | |||
| 5d1a9853ea | |||
| 03edd82d53 | |||
| 9bac2685cb | |||
| b237b3e85b | |||
| 023cc47025 | |||
| 3300ed2557 | |||
| e22661ab54 | |||
| 51b886f3f6 | |||
| 804c52aa90 | |||
| 373533094b | |||
| 59d837f6e7 | |||
| a63c85bc51 | |||
| 6a3d47e482 | |||
| 1d71b83197 | |||
| 3a43205c48 | |||
| 9f94103c57 | |||
| d022ddcea6 | |||
| 78da051b60 | |||
| ddf88202fc | |||
| 2ee541f40e | |||
| d391cdf0f7 | |||
| cf8aa53c8d | |||
| 270b1f11a3 | |||
| 2a4d7b7625 | |||
| 707d8a1e39 | |||
| 50e77e6314 | |||
| a0a658bc9a | |||
| f844feab7f | |||
| 8c68d683c6 | |||
| be967783b4 | |||
| 730109dd0c | |||
| 78688b968c | |||
| 7e98debd70 | |||
| 255cde5002 | |||
| 2cc76f4f94 | |||
| 9acf23926d | |||
| b41e24e068 | |||
| ad522e6bf7 | |||
| 38b51f3e6d | |||
| 89f62c85ab | |||
| 96d4677fac | |||
| 863484e681 | |||
| 7f4b79593a | |||
| 35e3de401e | |||
| 814d45b211 | |||
| 0f0d9b9145 | |||
| e6ee79402b | |||
| 4b6c3a12d8 | |||
| 56dab4fdfb | |||
| ed387a4f54 | |||
| ac18c98385 | |||
| ba816f69ae | |||
| 2e519743b5 | |||
| 36c8ae9a80 | |||
| ec53302014 | |||
| 7e6ed25ea9 | |||
| f753353ad4 | |||
| f020178c15 | |||
| 5a75075616 | |||
| 42c579f7b8 |
+163
-525
@@ -1,16 +1,28 @@
|
||||
# Nova — Architecture (v1.1 target)
|
||||
# Nova — Architecture
|
||||
|
||||
> Target architecture for the real Agentic Cloud Delivery Platform (rebranded
|
||||
> Nova in v1.15). Source of truth for **how**: `docs/architecture.md` (v0.2) is the upstream
|
||||
> draft; this file is the Nova-repo operating copy, refined at phase
|
||||
> boundaries. Where this file and `docs/vision.md` conflict, the vision wins.
|
||||
> **Compressed.** The full v1.0–v1.24 architecture history (v1.1 spike
|
||||
> scope, v1.2 build-out, v1.8–v1.16 addenda) is preserved verbatim at
|
||||
> `.ciagent/archive/ARCHITECTURE-v1.0-v1.24.md`. This file retains the
|
||||
> durable target architecture (§1–§12, the four layers + six cross-cutting
|
||||
> concerns) + the three addenda that describe the **current state**:
|
||||
> v1.11 (stateless adapter), v1.15 (Nova rebrand — current naming), and
|
||||
> v1.17 (telemetry/observability layer + §12.7 Policy Engine Registry).
|
||||
> Intermediate addenda (v1.1 spike scope, v1.2 build-out, v1.8/1.9/1.10/
|
||||
> 1.12/1.13/1.14/1.16) describe evolved or superseded states and are
|
||||
> preserved in the archive snapshot.
|
||||
>
|
||||
> Source of truth for **how**: `docs/architecture.md` (v0.2) is the
|
||||
> upstream draft; this file is the Nova-repo operating copy, refined at
|
||||
> phase boundaries. Where this file and `docs/vision.md` conflict, the
|
||||
> vision wins.
|
||||
|
||||
## Status
|
||||
|
||||
Architecture is at **v0.2** upstream (`docs/architecture.md`). Milestone v1.1
|
||||
**finalizes it to v1.0** in Phase 07 by resolving the 11 open decisions
|
||||
(see `PROJECT.md` open-decision resolutions table). This file records the
|
||||
locked commitments and the v1.1 spike scope.
|
||||
Architecture is at **v0.2** upstream (`docs/architecture.md`). Milestone
|
||||
v1.1 **finalized it to v1.0** in Phase 07 by resolving the 11 open
|
||||
decisions (see `PROJECT.md` open-decision resolutions table). The v1.11
|
||||
addendum (stateless adapter) and the v1.17 addendum (telemetry layer +
|
||||
§12.7 Policy Engine Registry) record the current-state refinements.
|
||||
|
||||
## Overview
|
||||
|
||||
@@ -55,8 +67,9 @@ the same policy envelope, and the same evidence stream.
|
||||
### Layer 1 — Foundational Primitives
|
||||
Single-purpose, **engine-agnostic** primitive modules. L1 modules do
|
||||
not compose with other L1s; L1 takes its environment as input. The L1
|
||||
interface is defined against the **Target Stack IR**, not against Terraform
|
||||
directly (the IR is shaped to round-trip to Terraform in v1, per §12.1).
|
||||
interface is defined against the **Target Stack IR**, not against
|
||||
Terraform directly (the IR is shaped to round-trip to Terraform in v1,
|
||||
per §12.1).
|
||||
|
||||
- No inter-L1 references. L1 may call Terraform data sources.
|
||||
- Semver: interface → MAJOR, behavior → MINOR, lifecycle → PATCH (W3.D).
|
||||
@@ -68,8 +81,8 @@ Combine L1 primitives into deployable shapes. Each codebase maps to one
|
||||
canonical L2 stack (`multiStack: true` only per W1.B). Shape X
|
||||
(parameterized module) or Shape Y (thin-composition layer). Hierarchical
|
||||
composition, max depth 5, only registered L1s. The thin-composition tree's
|
||||
`wires` field is defined against the IR's relationship type, not a Terraform
|
||||
module block.
|
||||
`wires` field is defined against the IR's relationship type, not a
|
||||
Terraform module block.
|
||||
|
||||
Pipeline quality checks: secrets-in-plaintext, public ingress, IAM
|
||||
wildcard, KMS key reference, tag compliance, naming convention. Restricted
|
||||
@@ -149,6 +162,10 @@ before contract submission ack); RTO = async worker's dead-letter recovery.
|
||||
Single-region in v1. The outbox also stores per-contract QA and prod
|
||||
approver identities (the only durable record outside GitHub's audit log).
|
||||
|
||||
> **v1.17 update:** the Decision Ledger (SQLite hash-chain, D-121) is the
|
||||
> pilot's audit record. S3 Object Lock / JWS (D-083) is deferred — see
|
||||
> the v1.17 addendum below.
|
||||
|
||||
### Human-in-the-Loop mechanics (§10)
|
||||
Pre-execution gates. qa, prod, dr are PR-based attestation gates backed by
|
||||
GitHub Environments with required reviewers. No partial deployment to roll
|
||||
@@ -181,28 +198,28 @@ platform does not run the skill. Stateless agents, all state in the
|
||||
platform. Skills are reviewed for sensitive data before release (Infra &
|
||||
Ops owns the review; it is the mandatory release gate).
|
||||
|
||||
### Angine execution (§12) — the binding constraint
|
||||
**Target Stack IR** (locked): a engine-neutral description of resources
|
||||
### Engine execution (§12) — the binding constraint
|
||||
**Target Stack IR** (locked): an engine-neutral description of resources
|
||||
(typed inputs/outputs/NFRs), relationships (single parent per child),
|
||||
composition (tree, max depth 5), and policy hooks. The L1 registry, L2
|
||||
thin-composition tree, contract YML, and PolicyCheckResult schema are all
|
||||
defined against the IR — none against any specific engine.
|
||||
|
||||
**Angine adapters** are the only engine-specific code. An adapter
|
||||
compiles the IR into a engine execution plan. **v1 ships exactly one
|
||||
**Engine adapters** are the only engine-specific code. An adapter
|
||||
compiles the IR into an engine execution plan. **v1 ships exactly one
|
||||
adapter: the Terraform adapter.** v2+ may add OpenTofu, Pulumi, K8s CRDs
|
||||
without architectural change.
|
||||
|
||||
v1 reality: the IR is shaped to round-trip cleanly to Terraform (nearly
|
||||
isomorphic). As more adapters appear, the IR gets more expressive and the
|
||||
adapters gain translation logic; the L1 content, the YML standard, and the
|
||||
thin-composition tree do not change.
|
||||
adapters gain translation logic; the L1 content, the YML standard, and
|
||||
the thin-composition tree do not change.
|
||||
|
||||
**Terraform adapter (v1):** translates IR-typed L1 interface → Terraform
|
||||
`variable`/`output` blocks; IR-typed L2 thin-composition tree → Terraform
|
||||
root module; IR-typed relationships → module references; emits a
|
||||
`terraform plan` from the IR. The adapter is a thin layer; it does not own
|
||||
L1/L2 content.
|
||||
> **v1.11 update:** the Terraform adapter is now a **stateless assembler**
|
||||
> (~80 lines, emits `module "x" { source }` blocks) — see the v1.11
|
||||
> addendum below. The §12 "thin layer that translates IR → Terraform
|
||||
> variable/output blocks" framing is superseded by the stateless-assembler
|
||||
> model; the L1-owns-its-shape invariant is the new contract.
|
||||
|
||||
State storage: S3 (state) + DynamoDB (locking), cloud-managed,
|
||||
single-region in v1.
|
||||
@@ -211,6 +228,10 @@ Policy toolchain: **Checkov** for Terraform plan policy (the L2 checks +
|
||||
tag/naming); **Kyverno** for K8s-native/platform-internal policy; **OPA**
|
||||
reserved for cross-resource cases, explicitly last resort.
|
||||
|
||||
> **v1.25 update:** the policy toolchain is now unified under the
|
||||
> swappable `PolicyEngine` protocol — see §12.7 below. Checkov and Wiz
|
||||
> remain as raw-finding adapters feeding into kyverno-json meta-policies.
|
||||
|
||||
**Policy result normalization (§12.6):** the confidence signal consumes a
|
||||
normalized `PolicyCheckResult` schema, not raw engine output.
|
||||
|
||||
@@ -242,337 +263,9 @@ Contract→IR resolution: the contract declares intent in IR-typed terms;
|
||||
the pipeline resolves it to a target stack (list of L1 instances + inputs +
|
||||
relationships); the Terraform adapter compiles the target stack to a plan.
|
||||
|
||||
## v1.1 spike scope
|
||||
---
|
||||
|
||||
The spike (Phases 08–10) materializes the **minimum** that proves the IR
|
||||
commitments hold (no polyglot mess):
|
||||
|
||||
- One L1: `l1-s3` (IR-typed interface; the only AWS resource in the spike).
|
||||
- One L2 thin-composition: `l2-static-assets` (references `l1-s3` only).
|
||||
- Terraform adapter: IR → `terraform plan` against AWS via OIDC.
|
||||
- One contract submission → contract→IR → `terraform plan` → Checkov
|
||||
`PolicyCheckResult` → confidence signal → evidence event to the DynamoDB
|
||||
outbox.
|
||||
- State: S3 + DynamoDB (real AWS, single-region).
|
||||
|
||||
Out of spike scope: full HITL matrix wiring, Kyverno, OPA, MCP skill
|
||||
catalog, GitOps reconciler, multi-region, prod/dr environments, the 5-skill
|
||||
L3B catalog. Those are post-spike (v1.2+) platform build-out.
|
||||
|
||||
## Gitea API surface (carried from v1.0, refined)
|
||||
|
||||
| Capability | Gitea support | ACDL approach (v1.1) |
|
||||
|------------|---------------|----------------------|
|
||||
| Org-scoped repo create | `POST /api/v1/orgs/{org}/repos` | Used for any new repos |
|
||||
| Native Pages | **None** | Serve `acdl-evidence` via raw file URLs (unchanged from v1.0) |
|
||||
| Environments API | **None**; act_runner ignores `environment:` | Model HITL gates via `workflow_dispatch` approval inputs (v1.0 D-013 pattern) — **refined in Phase 07** for the real pre-execution gate model |
|
||||
| `repository_dispatch` | Not supported | Cross-repo trigger via `workflow_dispatch` API (unchanged) |
|
||||
| Reusable workflows | Supported | `acdl/.gitea/workflows/pipeline.yml` via `uses: ...@<ref>` |
|
||||
| `id-token: write` / OIDC | **Not supported** (RESEARCH TARGET 1, conf 0.95). Gitea docs list `id-token` as an unsupported GitHub-only scope; open proposal go-gitea/gitea#33681; draft PR go-gitea/gitea#36988 unmerged. Even Gitea's own CI uses long-lived AWS keys (issue #37980). | **Spike waiver D-039:** per-run-rotated long-lived key (rotated after each run by `scripts/rotate_spike_key.sh`). Real OIDC deferred to v1.2, blocked on PR #36988. |
|
||||
| `actions/configure-aws-credentials` | Unusable without OIDC | Spike uses static AWS creds from a (rotated) Gitea Actions secret via the `aws-actions/configure-aws-credentials@v4` `access-key-id`/`secret-access-key` inputs, or plain `AWS_ACCESS_KEY_ID`/`AWS_SECRET_ACCESS_KEY` env vars. v1.2 switches to `role-to-assume` when OIDC lands. |
|
||||
|
||||
### Branch pinning rule (refined for W2.A)
|
||||
|
||||
- Dev/qa contracts reference the reusable workflow by **tag**
|
||||
(`@v1.1-spike`).
|
||||
- Prod-bound workflows reference by **SHA**; the platform CLI
|
||||
(`platform/cli/resolve-tag.ts`, Phase 07) resolves the current tag to its
|
||||
SHA. (Spike scope: the CLI is a stub; the real CLI lands in v1.2.)
|
||||
|
||||
### Verification toolchain
|
||||
|
||||
ACDL has no `package.json`. The verification gate substitutes:
|
||||
- **typecheck:** `terraform validate`, `python3 -m py_compile`, JSON Schema
|
||||
validation (`ajv` or `python -m jsonschema`) against `schemas/`.
|
||||
- **test:** per-phase `scripts/verify_phaseNN.sh` (Phase 06: archive integrity;
|
||||
Phase 07: schema validation + decision-resolution completeness; Phase 08:
|
||||
OIDC assume-role + state backend; Phase 09: IR + L1 + adapter `terraform
|
||||
plan`; Phase 10: end-to-end contract submission).
|
||||
- **build:** `terraform init` (real build for the spike).
|
||||
- See `PERSONAS.md` verification_toolchain.
|
||||
|
||||
## Build order (v1.1)
|
||||
|
||||
1. Phase 06 — archive demo, reorient repo.
|
||||
2. Phase 07 — finalize architecture v1.0; author schemas + designs.
|
||||
3. Phase 08 — AWS OIDC bootstrap (use temp key once, rotate).
|
||||
4. Phase 09 — IR + `l1-s3` + Terraform adapter → `terraform plan`.
|
||||
5. Phase 10 — `l2-static-assets` + contract→IR → end-to-end spike.
|
||||
6. COMPLETE gate — review → ship `v1.2.0` → audit. **DONE.**
|
||||
|
||||
## v1.2 build-out scope
|
||||
|
||||
v1.2 takes the v1.1 spike (dev-only, `plan`-only, single S3 L1) to a real,
|
||||
simpler, better-documented platform that delivers a microservice to AWS ECS
|
||||
Fargate end-to-end. The locked architecture (§1–§12) is unchanged — v1.2
|
||||
extends the *implementation*, not the design.
|
||||
|
||||
### In scope (five axes, user-directed 2026-07-21)
|
||||
|
||||
1. **Re-evaluate the current state.** go-gitea/gitea#36988 (OIDC for Gitea
|
||||
Actions) re-checked 2026-07-21: still **open** (last updated 2026-05-27,
|
||||
not merged). Real OIDC remains deferred to v1.3+; v1.2 extends the D-039
|
||||
per-run-rotated-key waiver as **D-047**. The waiver continues to satisfy
|
||||
§12.5's *intent* (no *persistently* long-lived key): the spike key is
|
||||
rotated after each run by `scripts/rotate_spike_key.sh`, and Phase 12
|
||||
tightens the IAM scoping + rotation hygiene.
|
||||
2. **NFR improvements on the existing spike.** Least-privilege IAM audit of
|
||||
`spike_runner_policy.json`; idempotent `create_state_backend.py` /
|
||||
`create_iam_user.py`; proper exit codes / error handling; P1-1 redaction
|
||||
(two AWS access key IDs in `.ciagent/VERIFY.md` Phase 09 narrative).
|
||||
3. **Streamline / simplify the current setup.** Consolidate
|
||||
`run_spike_plan.sh` + `run_spike_e2e.sh` into one
|
||||
`scripts/run_platform.sh`; remove dead code and stale `platform/` paths.
|
||||
4. **README.md fully up to date on how the platform works.** Reflect v1.1
|
||||
complete; document the actual spike flow, `scripts/run_platform.sh`, the
|
||||
real repo layout, and the v1.2 objective.
|
||||
5. **Bootstrap a consumer repo with a basic microservice deployed to ECS
|
||||
end-to-end.** New Gitea repo `acdl-consumer-microservice` (org
|
||||
`continuous-intelligence`); new IR-typed L1s (`l1-vpc`, `l1-ecs-cluster`,
|
||||
`l1-ecs-service`, `l1-iam-role`, `l1-alb`, `l1-ecr`); new
|
||||
`l2-microservice` thin-composition; one contract submission →
|
||||
`terraform apply` (dev, autonomous per §10, confidence ≥ 0.50) → a live
|
||||
ECS Fargate service serving HTTP 200 → evidence event to the DynamoDB
|
||||
outbox → acdl-evidence timeline.
|
||||
|
||||
### Angine extension (ECS Fargate)
|
||||
|
||||
The Terraform adapter (§12) remains the only engine-specific code. v1.2
|
||||
expands the adapter `TYPE_MAP` to cover the six new ECS-shaped IR resource
|
||||
types. The L1 interface shape (IR-typed inputs/outputs/NFRs, registered in
|
||||
`modules-ir/registry.json`) is unchanged — only the set of registered L1s
|
||||
grows. The IR commitments (REQ-28) continue to hold: `modules-ir/`,
|
||||
`schemas/`, `contracts/`, `core/confidence_signal.py`,
|
||||
`core/contract_resolver.py`, `core/outbox_writer.py`
|
||||
remain engine-agnostic.
|
||||
|
||||
### `terraform apply` (dev only)
|
||||
|
||||
v1.2 lifts the engine execution from `plan` to `apply` for the `dev`
|
||||
environment only. Dev is autonomous per §10 (confidence ≥ 0.50, no HITL).
|
||||
`apply` for qa/prod/dr remains HITL-gated and out of scope for v1.2. The
|
||||
apply result (resources created, plan diff) is captured in the evidence
|
||||
stream as a `terraform.apply` event.
|
||||
|
||||
### Out of scope for v1.2 (deferred to v1.3+)
|
||||
|
||||
| Feature | Reason |
|
||||
|---------|--------|
|
||||
| Real OIDC federation | go-gitea/gitea#36988 still open. v1.2 extends D-039 waiver (D-047); real OIDC is v1.3+. |
|
||||
| Full HITL matrix wiring (qa/prod/dr) | v1.2 is dev-only autonomous `apply`; HITL wiring is v1.3. |
|
||||
| Kyverno + OPA policy engines | v1.2 keeps Checkov only; Kyverno/OPA are v1.3. |
|
||||
| MCP skill catalog + real L3B agent | v1.2 keeps the L3B stub; the 5-skill catalog is v1.3. |
|
||||
| Audit ledger build-out (S3 Object Lock + JWS + async worker + DLQ + daily checkpoints) | v1.2 keeps the v1.1 outbox; the regulatory ledger is v1.3. |
|
||||
| Multi-region state / outbox | Single-region in v1 (§9, §12.3); multi-region is v1.3+. |
|
||||
| Prod/dr environments | v1.2 is dev-only; prod/dr are v1.3. |
|
||||
| GitOps reconciler (ArgoCD/Flux) | v1.3+. |
|
||||
|
||||
## Build order (v1.2)
|
||||
|
||||
1. Phase 11 — re-eval #36988 + NFR audit + simplification findings + README rewrite.
|
||||
2. Phase 12 — NFR harden + simplify (idempotent bootstrap, one `run_platform.sh`, IAM audit, redactions).
|
||||
3. Phase 13 — six ECS L1s + adapter `TYPE_MAP` expansion.
|
||||
4. Phase 14 — `l2-microservice` + contract schema extension.
|
||||
5. Phase 15 — consumer repo + `terraform apply` (dev) → live ECS service.
|
||||
6. Phase 16 — capstone e2e: consumer commit → live HTTP 200 → evidence → timeline.
|
||||
7. COMPLETE gate — review → ship `v1.3.0` → audit.
|
||||
|
||||
## v1.8 Architecture Addendum
|
||||
|
||||
> Milestone v1.8 (complete, tag `v1.8.0`). Adds encryption-by-default,
|
||||
> deletion-protection-by-default, uptime monitoring, decommission alias,
|
||||
> engineering standards, and path documentation.
|
||||
|
||||
### New Primitives
|
||||
|
||||
- **`kms-key`** (`aws:kms:key`) — Per-stack customer-managed KMS key with
|
||||
`enable_key_rotation = true`. One key per L2 deployment (no shared keys).
|
||||
Wired into both L2 compositions as a child, with its `kms_key_arn` output
|
||||
connected to all children's `kms_key_arn` input. Adapter emits
|
||||
`aws_kms_key` + `enable_key_rotation`.
|
||||
- **`uptime`** (`aws:ecs:uptime-service`) — Uptime-kuma on ECS Fargate with
|
||||
a feature flag (`feature_flag_enabled`), monitored endpoints (HTTP/DNS/TCP),
|
||||
alert channels (Teams/email/SMS/GitHub issues). Deployed by default after
|
||||
any L2 module with a separate terraform state. When the feature flag is
|
||||
false, the adapter emits no resources.
|
||||
|
||||
### Encryption by Default
|
||||
|
||||
All 12 L1 primitives have `encryption_enabled` NFR (default true). Primitives
|
||||
with at-rest data (s3, rds, ecr, ecs-service, ecs-cluster) have an optional
|
||||
`kms_key_arn` input. The adapter emits encryption blocks (SSE-KMS for S3,
|
||||
storage_encrypted for RDS, encryption_configuration for ECR) referencing the
|
||||
per-stack CMK when provided. Managed KMS fallback with stderr warning for
|
||||
standalone L1 deployments.
|
||||
|
||||
### Deletion Protection by Default
|
||||
|
||||
All 12 L1 primitives have `deletion_protection` NFR (default true). The
|
||||
adapter emits `lifecycle { prevent_destroy = true }` when true. L2 modules
|
||||
expose a `features.deletion_protection` flag (default true) propagated to
|
||||
all children via the resolver. Setting `inputs.deletion_protection: false`
|
||||
in the contract disables it for the whole stack.
|
||||
|
||||
### Decommission Alias
|
||||
|
||||
A `mode: decommission` on the deploy pipeline implements a 2-step destroy:
|
||||
1. Disable deletion protection (resolve with `deletion_protection: false`,
|
||||
terraform plan/apply, HITL SRE gate via GitHub environment).
|
||||
2. Zero counts + destroy (`decommission_transform` zeroes all scalable counts,
|
||||
terraform plan/apply, second HITL SRE gate).
|
||||
|
||||
CMDB validation via DynamoDB `acdl-change-requests` table. The Lambda
|
||||
`validate_change_request` action queries the table and asserts
|
||||
`status == "approved"` + `consumerRepo` match.
|
||||
|
||||
### Adapter Expansion
|
||||
|
||||
TYPE_MAP grew from 16 to 19 entries (+ `aws:kms:key`, `aws:kms:alias`,
|
||||
`aws:ecs:uptime-service`). Specialized emission branches added for KMS key
|
||||
rotation, S3 SSE-KMS configuration, uptime ECS Fargate task, and
|
||||
`prevent_destroy` lifecycle on all resources.
|
||||
|
||||
### Pipeline Stages
|
||||
|
||||
The deploy pipeline grew from 8 to 9 stages (+ `deploy-uptime` after
|
||||
`publish-outputs`). The `deploy-uptime` stage constructs a synthetic uptime
|
||||
contract from the L2 stack outputs, resolves + adapts it to a separate
|
||||
terraform state directory, and publishes the uptime URL via PR comment.
|
||||
|
||||
### Forge-Agnostic API URLs
|
||||
|
||||
The platform Lambda (`contract_ingestor.py`) reads `GITHUB_API_BASE` env
|
||||
for forge-agnostic API URLs. GitHub uses `/search/issues`; Gitea uses
|
||||
`/repos/{owner}/{repo}/issues`. Detection via `/api/v1` in the base URL.
|
||||
|
||||
## v1.9 Addendum (2026-07-23)
|
||||
|
||||
### New Components
|
||||
|
||||
- **`core/contract_resolver.py` interpolation** (D-081): the resolver
|
||||
now expands `${env.<field>}` + `${contract.<field>}` tokens
|
||||
post-schema-validation, pre-IR-resolution. The env context is the
|
||||
loaded environment onboarding JSON (`core/environments/<name>.json`,
|
||||
schema `schemas/environment.schema.json`). The resolver's
|
||||
`child_input_map` routes L2 wires to the sub-resource that declares the
|
||||
input (P1-1 — `desired_count` → `aws:ecs:service`, `family` →
|
||||
`aws:ecs:task_definition`).
|
||||
- **`core/environment_check.py` `load()`** (REQ-104): loads + returns the
|
||||
parsed environment JSON; emits a stderr warning for placeholder
|
||||
`account_id` when env != dev.
|
||||
- **`core/hitl_gates.py`** (REQ-108, D-084): the HITL pre-execution
|
||||
attestation gate. Records the approver identity to the DynamoDB outbox
|
||||
(`approver_qa`/`approver_prod`/`approver_dr`), runs the separation-of-
|
||||
duties check on prod, invokes the attestation matrix, returns
|
||||
`(ok, reason)`. Dev skips (autonomous). `run_platform.sh` calls
|
||||
`attest` before apply for qa/prod/dr.
|
||||
- **`core/attestation_matrix.py`** (REQ-109, D-084): the 8-concern
|
||||
attestation matrix from `hitl_matrix_design.md` §10.4. Offline-testable
|
||||
concerns (contract NFRs, schema validity, policy pass) run for real;
|
||||
operator-supplied concerns accept signed evidence artifacts validated
|
||||
for freshness + schema. Signature verification skips when
|
||||
`ACDL_ATTESTATION_SIGNING_KEY_ID` is unset (D-089).
|
||||
- **`core/separation_of_duties.py` `route_halt_artifact`** (REQ-107):
|
||||
real SNS publish (`acdl-sod-halt` topic, ARN from
|
||||
`ACDL_SOD_HALT_TOPIC_ARN`) + outbox fallback
|
||||
(`SEPARATION_OF_DUTIES_VIOLATION` event). The SNS topic is defined in
|
||||
`terraform/platform/main.tf`.
|
||||
- **`adapters/wiz/wiz_adapter.py` `WizClient`** (REQ-110): real GraphQL
|
||||
API client (`<WIZ_API_URL>/graphql`, Bearer auth, pagination via
|
||||
`pageInfo.hasNextPage`). `fetch_and_adapt` translates issues →
|
||||
`PolicyCheckResult`. Graceful degrade when unconfigured.
|
||||
- **`adapters/kyverno/kyverno_adapter.py`** (REQ-111): fleshed-out
|
||||
`PolicyReport` → `PolicyCheckResult` mapping (pass/fail/skip/warn +
|
||||
severity + skip-with-reason + resource construction). Inactive-for-TF
|
||||
guard preserved.
|
||||
|
||||
### Per-Environment Promotion (D-082)
|
||||
|
||||
The deploy workflow (`.github/workflows/deploy.yml` +
|
||||
`.gitea/workflows/deploy.yml`, byte-identical) declares an `environment`
|
||||
`workflow_call` input. When non-empty, `run_platform.sh --environment
|
||||
<name>` overrides the contract's `environment` field before schema
|
||||
validation (D-088). One CI job per environment; promotion = running the
|
||||
matching job, no `environment:` field editing. Per-env contract files
|
||||
(`contracts/<module>.<env>.yaml`) use interpolation for env-specific
|
||||
values.
|
||||
|
||||
### Adapter Parameterization (P1-1, D-085)
|
||||
|
||||
The adapter (`adapters/terraform/adapter.py`) reads ECS/ALB/VPC defaults
|
||||
from L1 `interface.json` inputs (`desired_count`, `launch_type`,
|
||||
`family`, `target_type`, `load_balancer_type`, `name`). The adapter is a
|
||||
thin translator; the `child_input_map` routes wires to the declaring
|
||||
sub-resource.
|
||||
|
||||
### Deferred (D-083)
|
||||
|
||||
S3 Object Lock + JWS detached signatures + async worker + DLQ + daily
|
||||
checkpoints (audit ledger build-out) — deferred to a future milestone.
|
||||
The hash-chain + DynamoDB-outbox path remains the v1.9 production audit
|
||||
record.
|
||||
|
||||
## v1.10 Addendum — Regression VERIFY + Local Emulators + Capability Re-Verification
|
||||
|
||||
### Regression-Class VERIFY (D-091, `core/regression_verify.py`)
|
||||
|
||||
The standard VERIFY stage was diff-scoped (it checked the phase diff
|
||||
only, never re-ran underlying capability). This let 8 NFR-patch phases
|
||||
(v1.9.1–v1.9.8) pass while the platform decayed. The regression-class
|
||||
VERIFY (`core/regression_verify.py`) re-runs capability checks against
|
||||
the current codebase and tags each Verified/Decayed/Broken. It fails
|
||||
closed on any non-Verified capability, blocking milestone completion.
|
||||
|
||||
The registry (`CAPABILITY_REGISTRY`) holds 16 capability checks
|
||||
(CAP-001..CAP-016): 12 local-tier + 4 live-AWS. Adding a capability is
|
||||
a single function + one registry entry. The gate runs via
|
||||
`scripts/run_regression.sh` and writes `.ciagent/REGRESSION_REPORT.md`
|
||||
+ `.json`.
|
||||
|
||||
### Local Emulating Adapters (D-092, `core/local_emulators.py`)
|
||||
|
||||
Four local adapters let the platform run the full headline E2E without
|
||||
cloud credentials:
|
||||
|
||||
- `FlatFileOutbox` — flat-file DynamoDB outbox emulator (hash-chained
|
||||
JSONL; resumable across instances; chain verification).
|
||||
- `LocalEcsEmulator` — local ECS Fargate HTTP 200 emulator (binds port
|
||||
0 on 127.0.0.1; daemon thread; clean destroy).
|
||||
- `LocalS3StateBackend` — rewrites the terraform S3 backend to a local
|
||||
backend (per-stack tfstate in a temp folder).
|
||||
- `LocalLambdaStub` — invokes the contract_ingestor handler in-process
|
||||
(patches `_get_dynamodb`/`_get_secrets_client`/`urllib.urlopen`;
|
||||
DynamoDB writes redirected to the FlatFileOutbox).
|
||||
|
||||
`run_local_e2e()` runs the full pipeline: contract → resolver → adapter
|
||||
→ local S3 backend → local ECS (HTTP 200) → flat-file outbox (chain
|
||||
verified) → local Lambda (200). Gated on `ACDL_LOCAL_TIER=1`.
|
||||
|
||||
### Capability Re-Verification Sweep (D-093)
|
||||
|
||||
`.ciagent/CAPABILITY_INVENTORY.md` enumerates 16 auto-verified
|
||||
capabilities + 6 IAM-gated escalated resources. The sweep found and
|
||||
fixed 7 adapter defects in `adapters/terraform/adapter.py` (duplicate
|
||||
outputs, duplicate args, missing required args, deprecated AWS provider
|
||||
v5 arg names). The headline E2E now passes at both tiers: local
|
||||
emulator + live-AWS terraform init/validate/plan.
|
||||
|
||||
### Adapter Defect Fixes (P54)
|
||||
|
||||
7 defects fixed in `adapters/terraform/adapter.py`:
|
||||
1. Duplicate output definitions (per-resource + stack-level both emitted).
|
||||
2. Duplicate `desired_count`/`launch_type` on ECS service.
|
||||
3. Duplicate `target_type`/`family`/`load_balancer_type`.
|
||||
4. Missing `assume_role_policy`/`role_name` on IAM role (L2 composition gap).
|
||||
5. Missing `cidr_block`/`vpc_id`/`name` defaults on VPC/subnet/route_table/
|
||||
ECS cluster/ECR repository.
|
||||
6. ECR `kms_key_arn` unsupported arg → `encryption_configuration` block.
|
||||
7. CloudFront OAC + WAF deprecated arg names (AWS provider v5):
|
||||
`signing_behavior`, `signing_protocol`, `origin_access_control_id`,
|
||||
`s3_origin_config.origin_access_identity`, `origin_id`, `rule`
|
||||
(singular), `scope=CLOUDFRONT` (uppercase).
|
||||
|
||||
## v1.11 Addendum — Stateless Adapter + Pipeline-Driven Lifecycle Testing
|
||||
## v1.11 Addendum — Stateless Adapter + Pipeline-Driven Lifecycle Testing (current state)
|
||||
|
||||
**Stateless adapter (D-098).** `adapters/terraform/adapter.py` rewritten
|
||||
from a 918-line monolith (3 constant tables `TYPE_MAP`/`INPUT_MAP`/
|
||||
@@ -598,83 +291,25 @@ VPC; the microservice composition references it via
|
||||
`terraform_remote_state` (data source). State keys are deterministic and
|
||||
env-aware (`spike/{contract.id}/{contract.environment}/terraform.tfstate`).
|
||||
|
||||
**NOVA_LIFECYCLE_MODE (v1.12, REQ-134; renamed ACDL→NOVA in v1.15 P2).** The lifecycle pipeline defaults
|
||||
to plan-only (fast, no AWS mutation, no cost). A CI variable
|
||||
`NOVA_LIFECYCLE_MODE` (default `plan`) overrides to `full` for the real
|
||||
apply→modify→destroy. (P2–P4 dual-read fallback to `ACDL_LIFECYCLE_MODE`;
|
||||
fallback removed in P5 per the v1.15 addendum.)
|
||||
**NOVA_LIFECYCLE_MODE (v1.12, REQ-134; renamed ACDL→NOVA in v1.15 P2).**
|
||||
The lifecycle pipeline defaults to plan-only (fast, no AWS mutation, no
|
||||
cost). A CI variable `NOVA_LIFECYCLE_MODE` (default `plan`) overrides to
|
||||
`full` for the real apply→modify→destroy. (P2–P4 dual-read fallback to
|
||||
`ACDL_LIFECYCLE_MODE`; fallback removed in P5 per the v1.15 addendum.)
|
||||
|
||||
## v1.12 Addendum — Presentation Refinement + CAP-013 Fix
|
||||
|
||||
**CAP-013 adapter dedup fix (REQ-129).** Multi-resource L1s (ecs-service,
|
||||
alb) with stack outputs + cross-module refs now dedup to ONE module block
|
||||
named by the composition child id, with expanded sub-ids rewritten via
|
||||
`id_remap`. `terraform validate` succeeds for the microservice stack.
|
||||
|
||||
**CAP-017/018 probe fixes (REQ-130).** CAP-017's probe no longer requires
|
||||
`locals.tf` for modules that legitimately omit it. CAP-018's probe
|
||||
instantiates `LocalLambdaStub` with the required `outbox` arg.
|
||||
|
||||
## v1.13 Addendum — Presentation Polish + Config Schema Migration
|
||||
|
||||
**Config.json schema migration (v1.13.1).** Regenerated
|
||||
`.ciagent/config.json` to the updated CIAgent v2 config structure (drop
|
||||
removed fields, migrate `gitea`→`release.gitea`, add
|
||||
`secrets`/`ship`/`backend`/`ideation`/`personas`/`logging`/`telemetry`
|
||||
sections).
|
||||
|
||||
**Presentation polish (v1.13.0, v1.13.2).** Action headlines, story-arc
|
||||
restructure, larger fonts, 6 new mermaid diagrams, badge cleanup,
|
||||
platform-architecture diagram. Docs-only NFR patches.
|
||||
|
||||
## v1.14 Addendum — NFR Refinement (bug fixes, security, stubs, tests, docs)
|
||||
|
||||
**Bug fixes (Wave 1, P1-P6).** Adapter dedup rejects unregistered modules
|
||||
with ValueError (P1). Static-assets composition wires cloudfront inputs
|
||||
(P2). L2 lifecycle scripts document remote-state design (P3). Regression
|
||||
gate adds `terraform fmt -check` syntax probe (P4). Adapter dedup-merge +
|
||||
remote-state-key unit tests (P5). ALB target group name_prefix derives
|
||||
from var.name (P6).
|
||||
|
||||
**Security (Wave 2, P7-P12).** 6 swallowed-error sites narrowed to
|
||||
specific exceptions (P7). Account ID externalized to
|
||||
`ACDL_AWS_ACCOUNT_ID` env (P8). IAM policy scoped to `acdl-*` ARNs (P9).
|
||||
Contract ingestor validates contractId/environment/error (P10). Environment
|
||||
schema adds `additionalProperties: false` + format validation (P11).
|
||||
`.gitignore` credential-pattern catch-all (P12).
|
||||
|
||||
**Stub/test/CI/hygiene (Wave 3, P13-P17).** Kyverno `--kube-version` flag
|
||||
removed (P13, G-103). Orphan artifacts + dead config cleaned (P14). 7
|
||||
untested scripts gain test coverage (P15). Gitea workflow parity
|
||||
documented + script `set` flags fixed (P16). Config.json persona +
|
||||
branching strategy + ollama-cloud aligned (P17).
|
||||
|
||||
**Standards/docs/VPC (Wave 4, P18-P20).** STANDARDS.md reconciled (P18).
|
||||
Documentation synced: ARCHITECTURE.md addenda, stale `@v1.6-1.9` → `@v1.13`,
|
||||
GRILL G-005/G-008 resolved, COST.md window extended, D-083 deferral
|
||||
recorded (P19). Platform VPC CIDR parameterized + data-driven subnet
|
||||
count (P20).
|
||||
|
||||
**D-083 deferral (explicit).** The audit ledger build-out (S3 Object Lock
|
||||
+ JWS detached signatures + SQS DLQ + async worker + daily checkpoints)
|
||||
remains deferred (D-096, v1.14). The hash-chain + DynamoDB outbox is the
|
||||
v1.14 audit record. JWS per-event authenticity is not implemented; a
|
||||
forged event is only detectable by re-reading the whole chain. The
|
||||
deferral is documented here explicitly per the v1.14 grill (E-001).
|
||||
---
|
||||
|
||||
## v1.15 Addendum — Nova Rebrand (Major/breaking, 2026-07-30)
|
||||
## v1.15 Addendum — Nova Rebrand (current naming)
|
||||
|
||||
**Milestone:** v1.15-Nova. A full rebrand from **ACDL** / "Agentic Cloud
|
||||
Delivery Platform" → **Nova** / "The New Dawn of DevSecOps — security
|
||||
as a seamless enabler of fast deployments." This is a **Major
|
||||
milestone** (breaking): consumer-facing path, env var prefixes, SSM
|
||||
path, AWS tag keys, and AWS resource names all change. Per the
|
||||
branch-strategy precedent (breaking/feature milestones tag on their
|
||||
OWN minor line), v1.15 tags run on the **v1.15.x minor line**:
|
||||
`v1.15.0` (P0) → `v1.15.4` (P5 final = release). (G-104 binding.)
|
||||
Delivery Platform" → **Nova** / "The New Dawn of DevSecOps — security as
|
||||
a seamless enabler of fast deployments." This is a **Major milestone**
|
||||
(breaking): consumer-facing path, env var prefixes, SSM path, AWS tag
|
||||
keys, and AWS resource names all change. v1.15 tags run on the **v1.15.x
|
||||
minor line**: `v1.15.0` (P0) → `v1.15.4` (P5 final = release). (G-104
|
||||
binding.)
|
||||
|
||||
### Naming conventions (rebranded)
|
||||
### Naming conventions (rebranded — current)
|
||||
|
||||
| Convention | Before (v1.0–v1.14) | After (v1.15+) | Phase |
|
||||
|------------|---------------------|-----------------|-------|
|
||||
@@ -713,94 +348,15 @@ OWN minor line), v1.15 tags run on the **v1.15.x minor line**:
|
||||
brand name present (D-112: flat-branch convention preserved).
|
||||
- **Past Gitea release titles** — existing releases keep `ACDL vX.Y.Z`.
|
||||
|
||||
### Migration ordering (binding)
|
||||
|
||||
1. **P1** docs/decks/prose — no runtime impact; ships consumer migration
|
||||
guide announcing the 5 breaking changes.
|
||||
2. **P2** code + env vars (dual-read) + consumer path — deployments don't
|
||||
break during the transition window (dual-read fallback).
|
||||
3. **P3** SSM path (copy → read → delete) + tag keys (parallel-tag →
|
||||
policy swap → remove old).
|
||||
4. **P4** AWS resource names — staged terraform migration (KMS alias,
|
||||
SNS/SG/Lambda recreate, DynamoDB scan+copy, ECR re-push, IAM
|
||||
re-bootstrap, state bucket `-migrate-state`, ALB recreate). Maintenance
|
||||
window + rollback runbook (`docs/NOVA_AWS_MIGRATION.md`).
|
||||
5. **P5** final review + audit + remove dual-read fallback + milestone ship.
|
||||
|
||||
### Capability gate (binding)
|
||||
|
||||
The regression gate (CAP-001..CAP-016, `scripts/run_regression.sh`) must
|
||||
stay **16/16 Verified** throughout the rebrand. P2/P3/P4 update test
|
||||
fixtures that reference `ACDL`/`acdl` so the gate stays green. No
|
||||
capability is added, removed, or reclassified in v1.15 — the rebrand is
|
||||
nomenclature + identifiers, not behavior.
|
||||
> The full migration ordering (P1–P5), capability gate, and rollback
|
||||
> runbook are preserved in `.ciagent/archive/ARCHITECTURE-v1.0-v1.24.md`
|
||||
> §v1.15 Addendum.
|
||||
|
||||
---
|
||||
|
||||
## v1.16 Addendum — Nova Simplification (NFR, 2026-07-30)
|
||||
## v1.17 Addendum — Strategic Direction, Leadership Metrics & Unified Story (current telemetry layer)
|
||||
|
||||
The v1.16 NFR milestone added 6 new code components + 1 new Terraform
|
||||
module + 1 new schema, all documented here for the architecture record.
|
||||
|
||||
### New components
|
||||
|
||||
| Component | Path | Purpose |
|
||||
|-----------|------|---------|
|
||||
| Onboarding request handler | `core/onboarding.py` | `generate_env_file(request, template_env)` — produces a `<env>.json` from a consumer onboarding request (P19, REQ-183). CLI entry point for self-service env-file generation. |
|
||||
| Decommission transform | `core/decommission_transform.py` | `decommission_transform(stack)` — zero counts + disable deletion protection (REQ-92). Extracted from contract_resolver (P12, REQ-176). |
|
||||
| Contract resolver CLI | `core/contract_resolver_cli.py` | `main()` CLI entry point — resolves a contract YAML to a Target Stack JSON. Extracted from contract_resolver (P12, REQ-176). |
|
||||
| Regression verify CLI | `core/regression_verify_cli.py` | `main()` CLI entry point — runs the regression gate + writes the report. Extracted from regression_verify (P13, REQ-177). |
|
||||
| Workflow sync generator | `scripts/sync_workflows.py` | `--check`/`--write` — generates the 3 byte-identical Gitea+GitHub workflow pairs from `workflows-src/` (P8, REQ-172). |
|
||||
| Onboarding Terraform | `terraform/onboarding/` | `aws_iam_role.consumer_deploy` + `aws_iam_role_policy.consumer_invoke` (ABAC `nova:owner` tag). Offline-proven only (P20, REQ-184, D-114). |
|
||||
|
||||
### Modified components
|
||||
|
||||
| Component | Change | Phase |
|
||||
|-----------|--------|-------|
|
||||
| `core/contract_resolver.py` | `_load_env` delegates to `environment_check.load()` (dedup); `is_l2` uses registry `kind` field; `_load_schema` caches schemas; `decommission_transform` + CLI re-export shim (P12). | P7, P12, P14 |
|
||||
| `core/regression_verify.py` | Dedup helpers (`_check_resolver`, `_check_live_terraform_plan`, `_assert_contracts_resolve`); CAP-013..016 `Skipped` on post-teardown (G-111); `passed` accepts Skipped; CLI re-export shim (P13). | P5, P9, P13 |
|
||||
| `core/lambda/contract_ingestor.py` | Fail closed on missing IAM identity (P10); env enum from `core/environments/` (P10); payload size cap + schema validation (P11); `onboard_consumer` action (P18); `[NOVA-ALERT]` rebrand (P2). | P2, P10, P11, P18 |
|
||||
| `core/output_publisher.py` | `SAFE_OUTPUT_NAMES` schema-driven from `interface.json`; narrowed excepts; `urllib.error` import (P4, P14). | P4, P14 |
|
||||
| `core/environment_check.py` | Onboarding message rebranded Nova + self-service request path (P2, P19). | P2, P19 |
|
||||
| `core/local_emulators.py` | `LocalLambdaStub` sets `NOVA_LAMBDA_LOCAL_BYPASS`; stale dual-read comments + `acdl_*` prefixes removed (P3, P10). | P3, P10 |
|
||||
| `scripts/run_platform.sh` | `--help` flag; `run_hitl_gate()` fn; `NOVA_CONTRACT_ID`/`NOVA_WORK_DIR` config; decommission + uptime blocks extracted to sourced helpers (P6, P9, P15). | P6, P9, P15 |
|
||||
| `adapters/terraform/adapter.py` | State bucket `nova-tfstate-*` (P1); module docstring Nova (P2). | P1, P2 |
|
||||
| `adapters/kyverno/policies/require-resource-labels.yml` | `nova:*` labels (not `acdl:*`) (P1). | P1 |
|
||||
| `modules/registry.json` | `kind` field (`l1`/`l2`) on all 14 entries (P7). | P7 |
|
||||
|
||||
### New schema
|
||||
|
||||
- `schemas/onboarding.schema.json` — the self-service onboarding request
|
||||
(consumerRepo, requestedEnvironment, ownerId, billingTag). P18, REQ-182.
|
||||
|
||||
### Onboarding request-path architecture (D-113)
|
||||
|
||||
The no-humans onboarding flow is a 3-step request path (real AWS
|
||||
provisioning deferred):
|
||||
|
||||
```
|
||||
Consumer → POST Lambda (onboard_consumer) → pending CMDB row (P18)
|
||||
→ core/onboarding.py → <env>.json binding file (P19)
|
||||
→ terraform/onboarding/ → cross-account role + ABAC tag (P20, offline)
|
||||
```
|
||||
|
||||
The Lambda Function URL (IAM auth) + `consumer_invoke_policy.json` (ABAC
|
||||
`nova:owner`) are the transport; the request is accepted + a binding
|
||||
generated + the role Terraform proven offline. No AWS resources are
|
||||
created by the request path (D-113/D-114).
|
||||
|
||||
### Regression gate (G-111 binding)
|
||||
|
||||
The regression gate (D-091) now treats `Skipped` as acceptable for the
|
||||
post-v1.11-teardown steady state (D-096): CAP-013..016 (live-AWS tier)
|
||||
return `Skipped` when the resources are absent (`NoSuchBucket`/
|
||||
`ResourceNotFoundException`). `RegressionReport.passed` is
|
||||
`all(r.status in ("Verified", "Skipped"))`. The gate passes at 18
|
||||
Verified + 4 Skipped (0 Decayed/Broken).
|
||||
|
||||
## v1.17 Addendum — Strategic Direction, Leadership Metrics & Unified Story (2026-08-04)
|
||||
|
||||
The v1.17 milestone adds a telemetry/observability layer, a Decision
|
||||
The v1.17 milestone added a telemetry/observability layer, a Decision
|
||||
Ledger, a metrics export pipeline, a unified narrative deck, and a
|
||||
durable strategic-direction artifact. This addendum documents the
|
||||
architecture; the full research findings are in RESEARCH.md §v1.17.
|
||||
@@ -840,26 +396,26 @@ architecture; the full research findings are in RESEARCH.md §v1.17.
|
||||
│ Nova platform components (existing) │
|
||||
│ run_platform.sh · confidence_signal · checkov_adapter · │
|
||||
│ hitl_gates · regression_verify · outbox_writer · contract_ingestor │
|
||||
└──────────────────────┬──────────────────────────────────────────────┘
|
||||
│ CloudEvents 1.0 envelope (new emitters, P1)
|
||||
▼
|
||||
└────────────────────┬──────────────────────────────────────────────┘
|
||||
│ CloudEvents 1.0 envelope (new emitters, P1)
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────────┐
|
||||
│ metrics/events.jsonl (append-only CloudEvents log) │
|
||||
│ metrics/runs/<run_id>.json (per-run manifests) │
|
||||
│ metrics/decision_ledger.db (SQLite hash-chain, D-121) │
|
||||
│ metrics/test-results.xml (junit, P1) │
|
||||
└──────────────────────┬──────────────────────────────────────────────┘
|
||||
│ collector reads (P2)
|
||||
▼
|
||||
└────────────────────┬──────────────────────────────────────────────┘
|
||||
│ collector reads (P2)
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────────┐
|
||||
│ metrics/nova_metrics.db (SQLite cold store, D-126) │
|
||||
│ fact_run · fact_capability · fact_policy_check · fact_confidence │
|
||||
│ fact_test · fact_decision · fact_cost_estimate │
|
||||
│ dim_capability · dim_milestone │
|
||||
│ + 8 empty placeholder views (deferred metrics) │
|
||||
└──────────────────────┬──────────────────────────────────────────────┘
|
||||
│ powerbi_export (P3)
|
||||
▼
|
||||
└────────────────────┬──────────────────────────────────────────────┘
|
||||
│ powerbi_export (P3)
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────────┐
|
||||
│ metrics/powerbi/ (CSV/JSON views, folder connector, D-129) │
|
||||
│ → PowerBI dashboards (external) │
|
||||
@@ -868,14 +424,96 @@ architecture; the full research findings are in RESEARCH.md §v1.17.
|
||||
|
||||
**Hot path: deferred (D-126).** No live ops dashboard; SQLite is
|
||||
cold-only (batch/historical). The hot path activates when live AWS is
|
||||
re-provisioned (D-096 lift).
|
||||
re-provisioned (D-096 lift — the v1.26 milestone lifts this for the pilot
|
||||
estate).
|
||||
|
||||
### NORTH_STAR integration point (REQ-186)
|
||||
|
||||
`.ciagent/NORTH_STAR.md` is read by CIAgent in context-loading for all
|
||||
future milestones. The integration mechanism (to be finalized in P4):
|
||||
a reference from `PROJECT.md` + `ARCHITECTURE.md` (this section) + a
|
||||
config entry in `config.json` (`strategic_direction_file:
|
||||
".ciagent/NORTH_STAR.md"`) that the run workflow reads at SPECIFY. This
|
||||
ensures the strategic direction survives across milestones without
|
||||
being overwritten by status updates.
|
||||
future milestones. The integration mechanism: a reference from
|
||||
`PROJECT.md` + `ARCHITECTURE.md` (this section) + a config entry in
|
||||
`config.json` (`strategic_direction_file: ".ciagent/NORTH_STAR.md"`)
|
||||
that the run workflow reads at SPECIFY. This ensures the strategic
|
||||
direction survives across milestones without being overwritten by status
|
||||
updates.
|
||||
|
||||
### §12.7 — Policy Engine Registry (v1.25, REQ-291 — current)
|
||||
|
||||
The policy-engine abstraction is first-class: a swappable `PolicyEngine`
|
||||
protocol so the engine may change without touching the confidence
|
||||
signal, the pipeline, or the `PolicyCheckResult` schema. This is the
|
||||
**swap boundary** that keeps the platform's compliance posture
|
||||
replaceable (Strategic Objective #2 — provable trust via a replaceable
|
||||
substrate, not a vendor lock-in).
|
||||
|
||||
```
|
||||
contract.yml ─┐ ┌─→ list[PolicyCheckResult] ─┐
|
||||
stack IR ─────┼─→ PolicyEngine.evaluate ├─→ list[PolicyCheckResult] ─┼─→ confidence_signal
|
||||
plan JSON ────┤ (protocol) └─→ list[PolicyCheckResult] ─┘ (engine-agnostic,
|
||||
PCR list ─────┘ unchanged)
|
||||
│
|
||||
▼
|
||||
┌─ KyvernoJsonEngine (shells to `kj scan`; engine: "kyverno")
|
||||
└─ OpaEngine (future — same protocol; engine: "opa")
|
||||
|
||||
checkov/wiz ──→ raw findings ──→ (merged PCR list is the meta-policy payload)
|
||||
```
|
||||
|
||||
**The protocol (`core/policy_engine.py`):**
|
||||
```python
|
||||
class PolicyEngine(Protocol):
|
||||
@property
|
||||
def name(self) -> str: ...
|
||||
def is_configured(self) -> bool: ...
|
||||
def evaluate(self, payload, policy_dir: Path, contract_id: str) -> list[dict]: ...
|
||||
```
|
||||
|
||||
**The registry** reads `config.json.policy.engine` (default
|
||||
`"kyverno-json"`) and returns the active engine. A `NullEngine` is the
|
||||
fallback when the `policy` key is absent (emits `SKIPPED` PCRs —
|
||||
backward compatibility for tests that don't set the key). The
|
||||
confidence signal is **untouched** — it already consumes
|
||||
`list[PolicyCheckResult]` engine-agnostically (§12.6). v1.25 only
|
||||
changes *who produces* the PCR list, not *what* the list is.
|
||||
|
||||
**Engine enum reuse (D-116):** kyverno-json PCR records carry
|
||||
`engine: "kyverno"` (no new enum value). The `engine` field records the
|
||||
policy-engine *family*, not the specific binary. The K8s Kyverno adapter
|
||||
and the kyverno-json engine are distinguished by `ruleId` prefix
|
||||
(`KYVERNO_` vs `KJ_`) and `evidence` payload shape (`namespace`/`kind`
|
||||
vs `assertion`/`jmespath`).
|
||||
|
||||
**Defense-in-depth (D-119):** the declarative meta-policy
|
||||
`block-on-any-critical` (asserts no PCR has `severity: critical` +
|
||||
`result: fail`) is the *source of truth* for "critical = block". The
|
||||
`confidence_signal.py` `PENALTY["critical"]: None` hard-override stays
|
||||
as the *imperative* safety net — the meta-policy runs *before* the
|
||||
confidence signal (produces PCRs that flow in), the hard-override runs
|
||||
*inside* it (the last gate). Removing the hard-override would make the
|
||||
"critical = block" guarantee depend on a single policy file — a
|
||||
regression in provable trust.
|
||||
|
||||
**Graceful degradation (D-120):** `KyvernoJsonEngine.is_configured()`
|
||||
returns false when `which kj` is absent → `evaluate()` returns a single
|
||||
`SKIPPED` PCR (`ruleId: "KJ_ENGINE_NOT_CONFIGURED"`). The platform
|
||||
functions without the binary (the "platform functions without AI /
|
||||
deterministic scripts" tenet holds — kyverno-json is deterministic, not
|
||||
AI; the `is_configured()` guard ensures the platform runs even when the
|
||||
binary is not installed).
|
||||
|
||||
> **§12.8 — Pilot Estate** is planned for the v1.26 P4 phase (REQ-321).
|
||||
> It will document the live-pilot architecture (consumer contract →
|
||||
> `deploy.yml@v1.25` → apply → attest → record against `581513795199`).
|
||||
|
||||
### §12.9 — Secret Rotation (v1.26 P3 W7, SPEC §5.9 — current)
|
||||
|
||||
The platform-managed scheduled workflow `workflows-src/rotate-aws-key.yml`
|
||||
rotates the `NOVA_AWS_*` static key daily (cron `0 0 * * *`) and on
|
||||
`workflow_dispatch`. v0.2 scope: the mechanism exists (SPEC §5.9 —
|
||||
exists-not-ran); the v0.2 deploy uses the currently-active key. The
|
||||
rotation is idempotent — `scripts/rotate_spike_key.sh` deactivates the old
|
||||
key only after the new one propagates to the consumer's Actions secret
|
||||
store, verified by a post-PUT GET; on upload/verify failure the old key is
|
||||
left Active and the run exits non-zero. The synced workflow file is
|
||||
forge-agnostic (REQ-230): forge base URL / owner / consumer repo come from
|
||||
repository secrets (`NOVA_FORGE_*`, `NOVA_CONSUMER_REPO`), not literals.
|
||||
+29
-24
@@ -1,30 +1,35 @@
|
||||
{
|
||||
"phase": 4,
|
||||
"stage": "complete",
|
||||
"milestone": "v1.24",
|
||||
"phase_role": "final",
|
||||
"phase": 3,
|
||||
"stage": "verify",
|
||||
"milestone": "v1.26",
|
||||
"phase_role": "execution",
|
||||
"attempts": 0,
|
||||
"updated_at": "2026-08-12T02:45:00Z",
|
||||
"updated_at": "2026-08-19T00:00:00Z",
|
||||
"project": "acdl",
|
||||
"milestone_complete": true,
|
||||
"tag": "v1.23.4",
|
||||
"tag_line": "v1.23.x",
|
||||
"requirements": ["REQ-276","REQ-277","REQ-278","REQ-279","REQ-280","REQ-281","REQ-282","REQ-283","REQ-284","REQ-285","REQ-286","REQ-287","REQ-288","REQ-289","REQ-290"],
|
||||
"release": {
|
||||
"forge": "gitea",
|
||||
"releases_created": true,
|
||||
"release_ids": {
|
||||
"v1.23.0": 635,
|
||||
"v1.23.1": 636,
|
||||
"v1.23.2": 637,
|
||||
"v1.23.3": 638
|
||||
},
|
||||
"milestone_release_tag": "v1.23.4"
|
||||
"projects": ["acdl", "nova-blockchain-exchange"],
|
||||
"active_milestone": "v1.26",
|
||||
"milestone_branch": "milestone/v1.26-pilot-activation",
|
||||
"phase_branch": "phase/03-pilot-metrics-and-policies",
|
||||
"tag_line": "v1.25.x",
|
||||
"previous_phase": {"phase": 2, "tag": "v1.25.2", "status": "complete"},
|
||||
"current_phase": {"phase": 3, "tag": "v1.25.3", "status": "verify"},
|
||||
"requirements": ["REQ-315", "REQ-316", "REQ-317", "REQ-318", "REQ-319", "REQ-320"],
|
||||
"waves": {
|
||||
"W0": "Gitea adapter — inline checkout-then-call in consumer deploy.yml (SPEC §10 Q1 resolved, consumer repo)",
|
||||
"W0.5": "kyverno-json substrate fix (v1.25 skip-masked bug) + P2 drift (dynamodb examples, sync_workflows, deck path)",
|
||||
"W2": "outcome backfill (REQ-317) + escalation_reason (REQ-318)",
|
||||
"W3": "env-JSON state_backend wiring (REQ-319) — dev bound to 581513795199",
|
||||
"W4": "pilot-readiness (REQ-320) + settlement-finality (REQ-315) kyverno-json policies — run against real kj",
|
||||
"W5": "CAP-025 live-pilot-apply regression check (REQ-316)",
|
||||
"W6": "deploy.yml drift fixes — AWS_DEFAULT_REGION from secret, ref v1.25, no raw NOVA_AWS_* in shell env (SPEC §5.1/§5.2)",
|
||||
"W7": "secret rotation scheduled workflow (SPEC §5.9) + forge-agnostic token name (REQ-230)"
|
||||
},
|
||||
"tests": {
|
||||
"total": 287,
|
||||
"passed": 287,
|
||||
"failed": 0
|
||||
"pre_run": {
|
||||
"flaky_test_fixed": "8c68d68 test(metrics): fix attestation-event test freshness time-bomb",
|
||||
"acdl_to_nova_migration": "f844fea chore(bootstrap): migrate ACDL_* env vars to NOVA_*",
|
||||
"aws_bootstrap": "S3 nova-tfstate-581513795199-us-east-1 + DynamoDB nova-outbox created (idempotent, account 581513795199)",
|
||||
"consumer_repo_created": "continuous-intelligence/nova-blockchain-exchange (Gitea, private, init, cloned to /root/nova-blockchain-exchange)",
|
||||
"kj_installed": "kyverno-json v0.0.3 via go install (binary kyverno-json symlinked as kj) — policy tests run, not skipped"
|
||||
},
|
||||
"notes": "v1.24 milestone complete. Tag v1.23.4 (milestone release). 15 requirements complete (REQ-276..290). 4 phases (P0 pre-execution + P1 docs + P2 feat + P3 tests + P4 final). 287 tests pass. Consumer guide accuracy fixes + env-transition detect-and-destroy (no orphan path)."
|
||||
"notes": "v1.26 P3 verify PASS. W0 Gitea adapter (consumer deploy.yml inline — SPEC §10 Q1 resolved). W0.5 fixed v1.25 skip-masked kj substrate bug (engine + 16 policies + install script) + 7 pre-existing P2 drift failures. W2 outcome backfill + escalation_reason. W3 env-JSON state_backend (dev→581513795199). W4 pilot policies (real kj). W5 CAP-025. W6 deploy.yml drift (AWS_DEFAULT_REGION, ref v1.25). W7 rotation workflow. 844 platform + 90 consumer tests green. Ready for P3 SHIP → v1.25.3."
|
||||
}
|
||||
+202
-85
@@ -1,109 +1,226 @@
|
||||
# CLARIFY — v1.24 Consumer Guide Accuracy & Env-Promotion Lifecycle Enforcement
|
||||
# CLARIFY — v1.26 Live Pilot Estate Activation
|
||||
|
||||
> **Autonomy:** full. Ambiguities are auto-resolved with assumption logging
|
||||
> per `config.json autonomy.level: "full"`. No human escalation.
|
||||
> **Autonomy:** full. Auto-resolution with assumption logging per
|
||||
> `config.autonomy.level: "full"`. No human escalation unless
|
||||
> confidence < 0.60 (threshold `config.autonomy.decision_confidence_threshold`).
|
||||
> 10 ambiguities identified; all resolved (confidence ≥ 0.60).
|
||||
|
||||
## Ambiguities Identified
|
||||
---
|
||||
|
||||
### A1 — Step 8 "change environment" vs Per-env section "no field editing"
|
||||
## Method
|
||||
|
||||
**Ambiguity:** The consumer guide contains two mutually-exclusive promotion
|
||||
models. Step 8 (line 290) says "Change `environment` in your contract." The
|
||||
"Per-environment deployment" section (line 398) says "you do not edit the
|
||||
`environment:` field… Promotion = running the matching job." The test
|
||||
`test_consumer_guide_states_no_field_editing` asserts the no-editing model.
|
||||
The clarify stage identifies ambiguities in the v1.26 specification
|
||||
(PROJECT.md, REQUIREMENTS.md, ROADMAP.md) and resolves them at full
|
||||
autonomy. Each ambiguity gets a decision ID (D-200+; continuing from
|
||||
the v1.26 SPECIFY decisions D-200..D-205), a resolution, a confidence
|
||||
score, and a rationale. Resolutions update PROJECT.md + REQUIREMENTS.md
|
||||
+ ROADMAP.md as needed.
|
||||
|
||||
**User directive (binding):** Both shapes are supported. Shape A (edit
|
||||
environment in-place) is valid AND must trigger a destroy of the prior env.
|
||||
Shape B (per-env caller workflows) is the alternative. The test must be
|
||||
updated to assert both shapes.
|
||||
---
|
||||
|
||||
**Resolution (auto, confidence 0.95):** Adopt the user's directive. Step 8
|
||||
is rewritten to document Shape A with destroy-then-rebuild semantics. The
|
||||
per-env section is preserved as Shape B with a lead sentence distinguishing
|
||||
it. The test is renamed and a new test asserts the destroy semantics. This
|
||||
is already captured in REQ-279, REQ-280, REQ-290.
|
||||
## Ambiguities + Resolutions
|
||||
|
||||
### A2 — Prior-env source of truth: DynamoDB vs state-bucket scan vs SSM
|
||||
### Q1 — Does the consumer repo's `.ciagent/` live in the platform repo or the consumer repo?
|
||||
|
||||
**Ambiguity:** Three options for detecting the prior environment: (a) query
|
||||
the `nova-contracts` DynamoDB table, (b) scan the state bucket for other env
|
||||
prefixes, (c) record last-applied env in an SSM parameter.
|
||||
**Ambiguity:** The user said "ciagent should track it as a separate
|
||||
project under this same path." Does "this same path" mean the platform
|
||||
repo's `.ciagent/` directory (multi-project mode per `run.md` Step 0),
|
||||
or a separate `.ciagent/` inside the consumer repo?
|
||||
|
||||
**Resolution (auto, confidence 0.85):** DynamoDB `nova-contracts` table
|
||||
(user-selected). It already exists, is written by the contract ingestor
|
||||
Lambda (`core/lambda/contract_ingestor.py:160-170`), and has the right shape
|
||||
(PK `consumerRepo`, SK `contractId#submittedAt`, `environment` attribute).
|
||||
A new `#LAST_APPLIED` SK suffix is added for the record-applied-env step
|
||||
(REQ-283). This avoids coupling the platform to a specific state-bucket
|
||||
layout (which differs across envs/accounts) and avoids a new SSM dependency.
|
||||
**Resolution:** The platform repo's `.ciagent/` directory. Multi-project
|
||||
mode: `.ciagent/config.json` `projects[]` includes both `acdl` +
|
||||
`nova-blockchain-exchange`; the consumer's project files
|
||||
(PROJECT.md, REQUIREMENTS.md, ROADMAP.md) live in
|
||||
`.ciagent/nova-blockchain-exchange/`. The consumer *git repo* owns the
|
||||
app code + `contract.yaml` + deploy workflow invocation; the platform
|
||||
repo owns the CIAgent planning artifacts for both projects. This
|
||||
matches `run.md` Step 0 multi-project mode.
|
||||
|
||||
**Assumption:** The `nova-contracts` table is accessible from the deploy
|
||||
role via the same ABAC scoping that the contract ingestor uses. If the
|
||||
table is not accessible (e.g., local/CI mode without DynamoDB), the detect
|
||||
step logs a warning and returns `None` (conservative — no prior env
|
||||
assumed). This is documented in REQ-282.
|
||||
**Confidence:** 0.95. **Decision:** D-206.
|
||||
|
||||
### A3 — Cross-account destroy
|
||||
### Q2 — Is the bootstrap `NOVA_AWS_*` key the root key or the spike-runner key?
|
||||
|
||||
**Ambiguity:** If the prior env (e.g., dev) and new env (e.g., qa) are in
|
||||
different AWS accounts, the destroy step needs the prior env's role
|
||||
credentials. The current scaffold uses one account.
|
||||
**Ambiguity:** The bootstrap scripts (post-migration) prefer
|
||||
`NOVA_BOOTSTRAP_AWS_*`, falling back to `NOVA_AWS_*`. The pre-run
|
||||
(A3) succeeded with `NOVA_AWS_*`, creating the S3 bucket + DynamoDB
|
||||
table — which requires root or root-equivalent IAM. Is `NOVA_AWS_*`
|
||||
the root key, or did the bootstrap succeed because the spike-runner
|
||||
policy happens to include S3/DynamoDB create?
|
||||
|
||||
**Resolution (auto, confidence 0.80):** v1.24 targets the same-account
|
||||
case. Cross-account destroy is explicitly out of scope (documented in the
|
||||
Out of Scope section). The `run_platform.sh` Step 0b notes this limitation.
|
||||
A future milestone handles cross-account destroy via a pre-step that
|
||||
assumes the prior env's role. This is the pragmatic path — the scaffold
|
||||
(`core/environments/dev.json`) is single-account today.
|
||||
**Resolution:** `NOVA_AWS_*` has root-equivalent permissions (confirmed
|
||||
empirically: the bootstrap created the S3 bucket + DynamoDB table
|
||||
successfully). For the pilot, `NOVA_AWS_*` is the bootstrap key. A
|
||||
future hardening milestone should split this into a dedicated
|
||||
`NOVA_BOOTSTRAP_AWS_*` root key + a least-privilege `NOVA_AWS_*` runner
|
||||
key (the spike-runner pattern). For v1.26, the single key suffices
|
||||
(pilot scope).
|
||||
|
||||
### A4 — Version tag in docs: `@v1.19` vs `ref: v1.9`
|
||||
**Confidence:** 0.90. **Decision:** D-207.
|
||||
|
||||
**Ambiguity:** The consumer guide says `uses: nova/.github/workflows/deploy.yml@v1.19`
|
||||
but the actual `.github/workflows/deploy.yml` checks out the platform repo
|
||||
at `ref: v1.9`. The reference table says sample contracts "use `@v1.19`"
|
||||
but the sample contracts don't carry `uses:` (they're contracts, not
|
||||
workflows).
|
||||
### Q3 — Which AWS account does the pilot use: `581513795199` (existing) or a dedicated pilot account?
|
||||
|
||||
**Resolution (auto, confidence 0.90):** REQ-281 corrects the reference
|
||||
table wording to "used with caller workflow `@v1.19`" (the version pin
|
||||
lives in the caller workflow, not the contract). The `@v1.19` tag in the
|
||||
consumer-facing docs is the documented current version; the `ref: v1.9` in
|
||||
deploy.yml is the platform-internal checkout ref. These are two different
|
||||
references (consumer → platform workflow tag; platform workflow → platform
|
||||
repo ref). The guide's `@v1.19` stays as the consumer-facing version. No
|
||||
change to deploy.yml's `ref: v1.9` (that's an internal platform concern,
|
||||
out of scope for this milestone).
|
||||
**Ambiguity:** The user said "assume 581513795199." But the env JSONs
|
||||
all show `account_id: "000000000000"` (placeholder). Does the pilot
|
||||
bind all env JSONs to `581513795199`, or only `dev` (with qa/prod/dr
|
||||
left placeholder until a real multi-account landing zone exists)?
|
||||
|
||||
### A5 — Should Shape A destroy go through the HITL decommission pipeline?
|
||||
**Resolution:** Bind `dev` to `581513795199` for the pilot
|
||||
(D-203, established in SPECIFY). The `qa`/`prod`/`dr` env JSONs remain
|
||||
placeholder `000000000000` this milestone — the pilot runs in `dev`
|
||||
(autonomous, no HITL gate). Multi-account landing zone (qa/prod/dr on
|
||||
separate accounts) is a future milestone. REQ-319 (env-JSON wiring)
|
||||
updates `dev.json`'s `state_backend.bucket` to
|
||||
`nova-tfstate-581513795199-us-east-1` + `account_id` to `581513795199`;
|
||||
qa/prod/dr get the `state_backend.bucket` update but keep placeholder
|
||||
`account_id` (the pilot-readiness policy REQ-320 blocks apply on
|
||||
placeholder accounts — so qa/prod/dr apply is blocked by design until
|
||||
the accounts are bound).
|
||||
|
||||
**Ambiguity:** The decommission pipeline (2-step, HITL SRE gates) exists for
|
||||
stack teardown. Should env-transition destroy use it?
|
||||
**Confidence:** 0.92. **Decision:** D-208.
|
||||
|
||||
**Resolution (auto, confidence 0.85):** No. Env-transition is an automated
|
||||
lifecycle step, not an explicit decommission. The destroy runs as a direct
|
||||
`terraform destroy -auto-approve` against the prior env's state (REQ-284).
|
||||
The decommission pipeline remains for explicit stack teardown with SRE
|
||||
gates. This is documented in the Out of Scope section. Rationale: the
|
||||
consumer already has HITL attestation on the *new* env (qa/prod/dr gates);
|
||||
requiring a second SRE gate for the prior env's destroy would block
|
||||
autonomous dev→qa promotion, contradicting the "lower environments are
|
||||
autonomous" tenet.
|
||||
### Q4 — Does "all types of securities" mean all types in v1.26, or equities-only pilot with others deferred?
|
||||
|
||||
### A6 — Phase count and ordering
|
||||
**Ambiguity:** The user said "stock market built on homegrown blockchain
|
||||
offering all types of securities." This could mean equities + bonds +
|
||||
derivatives + options all in v1.26, or equities-only pilot with others
|
||||
deferred (the recommended scope from the plan).
|
||||
|
||||
**Ambiguity:** The requirements traceability table shows 3 phases (P1:
|
||||
docs, P2: feat, P3: test) but the roadmap entry says "4 phases."
|
||||
**Resolution:** Equities-only pilot (D-200, established in SPECIFY).
|
||||
Bonds/derivatives/options have very different settlement models (T+1
|
||||
for equities; T+2 for bonds; derivatives vary; options exercise
|
||||
models). A pilot should demonstrate the Nova platform's policy gates
|
||||
over a real estate — equities (T+1) is the simplest. "All types of
|
||||
securities" is the *product vision*; v1.26 is the *pilot* (equities
|
||||
first). The roadmap documents the deferral.
|
||||
|
||||
**Resolution (auto, confidence 0.90):** 4 phases = P0 (pre-execution) + P1
|
||||
(docs fixes) + P2 (env-transition feat) + P3 (tests) + P4 (final
|
||||
review/ship). The "4 phases" in the roadmap counts execution phases (P1-P3)
|
||||
+ final (P4). This matches the run.md phase model (P0 pre-execution, P1..PN
|
||||
execution, P N+1 final). The traceability table lists P1-P3 (execution);
|
||||
P4 is the final phase (review + audit + ship, no new requirements).
|
||||
**Confidence:** 0.85. **Decision:** D-200 (reaffirmed).
|
||||
|
||||
## Clarification Commit
|
||||
### Q5 — Is the homegrown blockchain a real consensus protocol or a minimal PoA ledger?
|
||||
|
||||
No changes to REQUIREMENTS.md or PROJECT.md from clarify — the ambiguities
|
||||
are resolved and already captured in the requirements (REQ-276..290) and
|
||||
the Out of Scope section. The resolutions above are logged for traceability.
|
||||
**Ambiguity:** "Homegrown blockchain" could mean a full consensus
|
||||
protocol (multi-validator BFT) or a minimal PoA ledger (single
|
||||
validator, append-only).
|
||||
|
||||
**Resolution:** Minimal PoA ledger (D-201, established in SPECIFY).
|
||||
Single validator (config-driven), append-only blocks, SHA-256 hash
|
||||
chain, deterministic block production. Settlement finality = block
|
||||
commit. Multi-validator BFT is a future milestone. The pilot's purpose
|
||||
is to exercise the Nova platform's deploy/policy/attestation gates over
|
||||
a real consumer — the chain needs to be real enough to record
|
||||
transactions, not to solve Byzantine consensus.
|
||||
|
||||
**Confidence:** 0.88. **Decision:** D-201 (reaffirmed).
|
||||
|
||||
### Q6 — Does the pilot's `terraform apply` actually run, or is it `--plan-only`?
|
||||
|
||||
**Ambiguity:** The platform's `run_platform.sh` defaults to
|
||||
plan-only (no apply). The `deploy.yml` workflow's `mode` input can be
|
||||
`full` (apply) or `plan-only`. Does the pilot actually `terraform apply`
|
||||
(creating real AWS resources for the blockchain exchange), or does it
|
||||
stop at plan?
|
||||
|
||||
**Resolution:** The pilot runs `mode: full` (apply) for `dev` only.
|
||||
The apply creates real AWS resources (ECS for the matching engine,
|
||||
DynamoDB for the ledger, S3 for block storage) in account
|
||||
`581513795199`. `qa`/`prod`/`dr` are blocked by the pilot-readiness
|
||||
policy (REQ-320) until their accounts are bound (D-208). The apply is
|
||||
autonomous for `dev` (no HITL gate; confidence threshold 0.50). The
|
||||
`ai.decision.made` + `attestation.recorded` events land in the Decision
|
||||
Ledger — but `dev` attestation is autonomous (no human approver), so
|
||||
only `ai.decision.made` fires for `dev`.
|
||||
|
||||
**Confidence:** 0.90. **Decision:** D-209.
|
||||
|
||||
### Q7 — What AWS resources does the blockchain exchange contract declare?
|
||||
|
||||
**Ambiguity:** The `contract.yaml` declares the exchange's
|
||||
infrastructure. What specific AWS resources? The platform's adapter
|
||||
maps contract infrastructure blocks to Terraform. What stack types
|
||||
does the blockchain exchange use?
|
||||
|
||||
**Resolution:** The pilot contract declares 3 infrastructure blocks:
|
||||
(1) `ecs` (Fargate service for the matching engine + settlement
|
||||
service — the platform's existing `microservice` module pattern), (2)
|
||||
`dynamodb` (the ledger table — single-table, PK `block_index`), (3)
|
||||
`s3` (block storage — one object per block, key `blocks/{index}.json`).
|
||||
The adapter's `TYPE_MAP` already covers `aws_ecs_service`,
|
||||
`aws_dynamodb_table`, `aws_s3_bucket` (existing L1 primitives). No new
|
||||
adapter stack types needed for the pilot. The contract's
|
||||
`infrastructure` block references these by module name (`microservice`
|
||||
for ECS, `dynamodb` for the table, `s3` for the bucket).
|
||||
|
||||
**Confidence:** 0.82. **Decision:** D-210.
|
||||
|
||||
### Q8 — Does the outcome-backfill emitter (REQ-317) change the PCR schema?
|
||||
|
||||
**Ambiguity:** REQ-317 wires `apply.completed`/`apply.failed` →
|
||||
`fact_decision.outcome`. Does this touch the `PolicyCheckResult` schema
|
||||
(PCR) — the v1.25 moat that must not change?
|
||||
|
||||
**Resolution:** No. The outcome backfill touches the *metrics cold
|
||||
store* (`fact_decision` table in `metrics/nova_metrics.db`), not the
|
||||
PCR schema. The PCR schema (`schemas/policy_check_result.schema.json`)
|
||||
is unchanged. The backfill reads run-manifest events (not PCRs) and
|
||||
updates the decision's outcome column. This respects the v1.25 hard
|
||||
constraint: "DO NOT change `schemas/policy_check_result.schema.json`."
|
||||
|
||||
**Confidence:** 0.95. **Decision:** D-211.
|
||||
|
||||
### Q9 — Does the consumer repo need its own test suite + CI, or does the platform's CI cover it?
|
||||
|
||||
**Ambiguity:** The consumer repo (`nova-blockchain-exchange`) has app
|
||||
code (blockchain, engine, settlement). Does it run its own tests in
|
||||
its own CI, or does the platform's `platform-test.yml` cover it?
|
||||
|
||||
**Resolution:** The consumer repo runs its own tests in its own CI
|
||||
(`nova-blockchain-exchange/.github/workflows/ci.yml` — lint + pytest on
|
||||
the blockchain/engine/settlement code). The platform's
|
||||
`platform-test.yml` covers the *platform* repo only (it validates
|
||||
contracts against the schema, runs adapter tests, etc.). The consumer
|
||||
repo's `deploy.yml` invocation triggers the platform's deploy workflow
|
||||
(which runs `run_platform.sh`); the platform's policy + attestation
|
||||
gates apply over the consumer's apply. The consumer's unit tests
|
||||
(chain integrity, order matching, settlement) are the consumer's
|
||||
responsibility. REQ-310..312 include consumer-side tests
|
||||
(`test_block.py`, `test_order_book.py`, `test_settlement.py`).
|
||||
|
||||
**Confidence:** 0.88. **Decision:** D-212.
|
||||
|
||||
### Q10 — Is the milestone a feature milestone (tags on v1.25.x) or a major milestone (breaking schema changes)?
|
||||
|
||||
**Ambiguity:** v1.26 introduces a 2nd project (multi-project mode) +
|
||||
new requirements. Does this break any schema (→ major milestone, tags
|
||||
on v1.26.x), or is it a feature milestone (tags on v1.25.x)?
|
||||
|
||||
**Resolution:** Feature milestone. No schema breaks: the PCR schema is
|
||||
unchanged (D-211); the contract schema is unchanged (the consumer
|
||||
contract validates against the existing
|
||||
`schemas/contract.schema.json`); the env JSON gains a real
|
||||
`account_id` (data, not schema). Multi-project mode is a config
|
||||
change (not a schema break). Tags run on the **v1.25.x** patch line:
|
||||
`v1.25.0` (P0) → `v1.25.5` (P5 = milestone release). Per `run.md`
|
||||
versioning logic: "Feature milestone (at least one feat phase):
|
||||
progressive patches per phase. The final phase's patch IS the milestone
|
||||
release. No separate minor tag."
|
||||
|
||||
**Confidence:** 0.92. **Decision:** D-213.
|
||||
|
||||
---
|
||||
|
||||
## Summary
|
||||
|
||||
10 ambiguities identified; all auto-resolved at full autonomy
|
||||
(confidence ≥ 0.60). 8 new decisions (D-206..D-213) + 3 reaffirmed
|
||||
from SPECIFY (D-200, D-201, D-203). 0 escalations (all ≥ 0.60). The
|
||||
resolutions are recorded in this file + reflected in PROJECT.md /
|
||||
REQUIREMENTS.md / ROADMAP.md updates.
|
||||
|
||||
**Key decisions:**
|
||||
- D-206: `.ciagent/` for both projects in the platform repo (multi-project mode).
|
||||
- D-207: `NOVA_AWS_*` has root-equivalent perms; single key for pilot.
|
||||
- D-208: `dev` bound to `581513795199`; qa/prod/dr stay placeholder (pilot-readiness policy blocks apply on placeholder).
|
||||
- D-209: Pilot runs `mode: full` (apply) for `dev` only; autonomous (no HITL gate).
|
||||
- D-210: Contract declares ecs + dynamodb + s3 (existing adapter stack types; no new TYPE_MAP entries).
|
||||
- D-211: Outcome backfill touches metrics cold store, NOT the PCR schema (v1.25 moat preserved).
|
||||
- D-212: Consumer repo has its own CI + unit tests; platform CI covers platform only.
|
||||
- D-213: Feature milestone; tags on v1.25.x (no schema breaks).
|
||||
+186
-161
@@ -1,200 +1,225 @@
|
||||
# CIAgent Grill Report
|
||||
# GRILL — v1.26 Live Pilot Estate Activation
|
||||
|
||||
## Run: 2026-08-12 (mode: self-grill, focus: all axes) — v1.24 Consumer Guide Accuracy & Env-Promotion Lifecycle Enforcement
|
||||
> Adversarial review of the v1.26 SPECIFY + CLARIFY + RESEARCH + IDEATE +
|
||||
> PLAN. The grill red-teams the proposal across feasibility, scope,
|
||||
> budget, and the domain claims (homegrown blockchain, pilot estate,
|
||||
> metric grounding). Each challenge gets a binding verdict
|
||||
> (PROCEED / REVISE / ESCALATE). Autonomy: full — escalations auto-
|
||||
> resolve with assumption logging unless confidence < 0.60.
|
||||
|
||||
### Overall Verdict: PROCEED (confidence: 0.82)
|
||||
## Verdict: PROCEED (0.84) — 0 escalations, 2 revisions
|
||||
|
||||
The plan is sound. The user directive is clear and binding. The code
|
||||
integration points are confirmed by inspection. Two binding revisions
|
||||
applied (both low-risk doc clarifications). No escalations.
|
||||
The milestone is feasible, scoped, and the domain claims hold. Two
|
||||
plan revisions are binding (G-Q4, G-Q8) and are already captured in
|
||||
PLAN.md. No work is blocked.
|
||||
|
||||
---
|
||||
|
||||
## Axis 1: Feasibility
|
||||
## Challenges
|
||||
|
||||
**Challenge:** Can `run_platform.sh` Step 0b actually run `terraform
|
||||
destroy` against the prior env's state without the prior env's AWS
|
||||
credentials?
|
||||
### G-Q1 — Is a homegrown PoA blockchain viable for a pilot, or is it reckless?
|
||||
|
||||
**Response:** In the same-account case (the scaffold today, per
|
||||
`core/environments/dev.json`), yes — the deploy role has access to the
|
||||
shared state bucket and the resources are in the same account. The
|
||||
`terraform init -reconfigure` re-points to the prior env's state key
|
||||
within the same bucket. Cross-account is explicitly out of scope
|
||||
(D-205). **Confidence: 0.85.**
|
||||
**Challenge:** Authoring a blockchain (even a minimal PoA ledger) is a
|
||||
non-trivial domain. A homegrown chain could have correctness bugs (hash
|
||||
chain breaks, non-deterministic blocks, settlement-finality race
|
||||
conditions). Why not use a proven chain (Ethereum L2, Solana, Hyperledger
|
||||
Fabric)?
|
||||
|
||||
**Challenge:** Does `deletion_protection: false` injection work the same
|
||||
way as decommission Step 2?
|
||||
**Verdict:** PROCEED (confidence 0.88). The pilot's purpose is to
|
||||
exercise the Nova platform's deploy/policy/attestation gates over a
|
||||
real consumer estate — not to build a production blockchain. A
|
||||
homegrown PoA ledger is the minimal viable chain: append-only blocks,
|
||||
single validator, SHA-256 hash chain, deterministic block production.
|
||||
This is ~200 lines of Python (block + ledger + validator). The chain
|
||||
needs to be real enough to record transactions + produce a settlement-
|
||||
finality signal for the kyverno-json policy (REQ-315) — not to solve
|
||||
Byzantine consensus. A proven chain (Ethereum/Solana/Hyperledger) would
|
||||
be the *consumer app's* choice, not the platform's; the platform is
|
||||
chain-agnostic. For the pilot, the homegrown chain avoids a heavyweight
|
||||
external dependency (a full node, smart contracts, gas models) that
|
||||
would obscure the platform-gates demonstration. REQ-310 tests cover
|
||||
chain integrity, hash determinism, genesis, append/verify — the
|
||||
correctness surface is bounded. Multi-validator BFT is a future
|
||||
milestone (D-201). No revision needed.
|
||||
|
||||
**Response:** Yes. `scripts/run_decommission.sh:34-37` sets
|
||||
`res['nfrs']['deletion_protection'] = False` on every resource. The
|
||||
contract resolver propagates `inputs.deletion_protection` to children's
|
||||
NFRs (`core/contract_resolver.py:360-372`). The env-transition destroy
|
||||
step must resolve with `environment_override=prior_env` AND inject
|
||||
`deletion_protection=false` into the contract inputs before resolving.
|
||||
This is a confirmed pattern. **Confidence: 0.90.**
|
||||
### G-Q2 — Does "all types of securities" scope-explode the milestone?
|
||||
|
||||
**Verdict:** FEASIBLE.
|
||||
**Challenge:** The user said "offering all types of securities." Equities
|
||||
(D-200, pilot scope) is one type. Bonds (T+2), derivatives (varying),
|
||||
options (exercise models) have very different settlement models. Does
|
||||
the equities-only deferral betray the user's intent?
|
||||
|
||||
## Axis 2: Scope
|
||||
**Verdict:** PROCEED (confidence 0.85). The user *chose* equities-only
|
||||
pilot (Q4 in the plan discussion, answer "A to all 3 questions" — the
|
||||
recommended scope). "All types of securities" is the *product vision*;
|
||||
v1.26 is the *pilot* (equities first). The roadmap documents the
|
||||
deferral. The pilot demonstrates the Nova platform's gates over the
|
||||
simplest settlement model (T+1); expanding to other security types is
|
||||
a straightforward extension (new settlement-service branches + new
|
||||
kyverno-json policies) once the platform-gates pattern is proven. No
|
||||
revision needed — the scope decision is the user's, not the grill's.
|
||||
|
||||
**Challenge:** Is 4 phases (P1-P3 + P4) the right size, or is this
|
||||
over-scoped?
|
||||
### G-Q3 — Does the consumer-repo-as-2nd-project break single-project tooling?
|
||||
|
||||
**Response:** 15 requirements across 3 execution phases is
|
||||
well-scoped. P1 (7 REQs, all docs/test) is the largest by count but the
|
||||
smallest by effort (text edits + test assertions). P2 (6 REQs, feat) is
|
||||
the core implementation. P3 (2 REQs, test) is coverage. P4 is final
|
||||
review. This is a tight, coherent milestone. **Confidence: 0.88.**
|
||||
**Challenge:** CIAgent has been single-project since v1.0. v1.26
|
||||
activates multi-project mode (2 projects: `acdl` +
|
||||
`nova-blockchain-exchange`). Does this break assumptions in the
|
||||
CIAgent tooling (branch naming, `.ciagent/` paths, commit `---ci---`
|
||||
blocks)?
|
||||
|
||||
**Challenge:** Should the cross-account destroy be in scope?
|
||||
**Verdict:** PROCEED (confidence 0.90). `run.md` Step 0 explicitly
|
||||
specifies multi-project mode: `projects[]` with length > 0,
|
||||
`active_projects` array, `.ciagent/<slug>/` subdirectory paths, branch
|
||||
prefixes `<slug>/`. The `---ci---` block gains a `project: <slug>`
|
||||
field (already in the v1.26 commits). The consumer's project files
|
||||
live in `.ciagent/nova-blockchain-exchange/`. The platform's existing
|
||||
flat `.ciagent/` files remain the primary set (the platform is the
|
||||
default project). Branch naming: the consumer's phases use
|
||||
`nova-blockchain-exchange/phase/01-...`; the platform's phases use
|
||||
`acdl/phase/03-...` (or flat `phase/03-...` for platform-level work).
|
||||
No tooling change needed — the multi-project spec is already in
|
||||
`run.md`. D-206 records this. No revision needed.
|
||||
|
||||
**Response:** No. The scaffold is single-account. Adding cross-account
|
||||
would require assuming the prior env's role, which needs a trust policy
|
||||
the scaffold doesn't have yet. Deferring is pragmatic. The Out of Scope
|
||||
section documents this. **Confidence: 0.85.**
|
||||
### G-Q4 — Does the P2 contract reference a `dynamodb` module that doesn't exist until P3?
|
||||
|
||||
**Verdict:** PROPERLY-SCOPED.
|
||||
**Challenge:** The original plan had REQ-322 (DynamoDB primitive) in
|
||||
P3, but the P2 contract (REQ-313) references `dynamodb` in its
|
||||
`infrastructure` block. If the primitive doesn't exist until P3, the
|
||||
P2 contract's `dynamodb` block can't resolve at registry time — only
|
||||
at schema time (the schema is open). Is this a vertical-slice
|
||||
violation (P2 ships a contract that can't fully resolve)?
|
||||
|
||||
## Axis 3: Cost / ROI
|
||||
**Verdict:** REVISE (confidence 0.92). This is a real vertical-slice
|
||||
violation. PLAN.md already revised: REQ-322 moves to P2 W0 (before the
|
||||
contract). The revised mapping (PLAN.md "Revised: REQ-322 → P2 W0")
|
||||
makes P2 self-contained: the primitive + the contract + the deploy
|
||||
invocation all land in P2. This is a binding revision — the original
|
||||
P3 placement is superseded. ROADMAP.md is already updated (REQ-322 in
|
||||
P2). No further revision needed — the plan self-corrected.
|
||||
|
||||
**Challenge:** Is the env-transition feature worth the complexity?
|
||||
### G-Q5 — Does live-AWS pilot break the MTTR < 60s target?
|
||||
|
||||
**Response:** Yes. The user identified a real orphaned-resources risk
|
||||
that violates the platform's full-lifecycle-management mission. The
|
||||
fix is a ~80-line Python module + a shell block. The alternative
|
||||
(blocking env edits, forcing Shape B) contradicts the user's directive.
|
||||
The ROI is high: closes a real lifecycle gap with minimal code.
|
||||
**Confidence: 0.90.**
|
||||
**Challenge:** NORTH_STAR.md MTTR target: < 60s p95. The pilot runs
|
||||
`terraform apply` (creating real AWS resources: ECS + DynamoDB + S3).
|
||||
Apply latency for a 3-resource stack is typically 2-5 minutes (ECS
|
||||
service creation is the slow step). Does this break the MTTR target?
|
||||
|
||||
**Verdict:** JUSTIFIED.
|
||||
**Verdict:** PROCEED (confidence 0.86). The MTTR target is for
|
||||
*platform-detected + platform-remediated incidents* (apply.failed →
|
||||
successful retry), not for first-time apply latency. The pilot's
|
||||
first apply is a deployment, not an incident-remediation. The MTTR
|
||||
metric measures the retry path: if the apply fails (e.g. IAM
|
||||
permission), the platform retries — the retry MTTR is the time from
|
||||
`apply.failed` to `apply.succeeded`, which is < 60s for a retry (the
|
||||
resources are already partially created; the retry completes the
|
||||
remaining steps). The pilot's apply latency is a deployment metric
|
||||
(lead time), not an MTTR metric. RESEARCH §1.2 (v1.25 grill G-Q3)
|
||||
analyzed this same question for the kyverno-json pass — the same
|
||||
reasoning applies. No revision needed.
|
||||
|
||||
## Axis 4: Correctness
|
||||
### G-Q6 — Is the settlement-finality policy (REQ-315) over-engineering for a pilot?
|
||||
|
||||
**Challenge:** The `detect_prior_env` query — is querying by
|
||||
`contractId#submittedAt` SK prefix correct for finding the last-applied
|
||||
env?
|
||||
**Challenge:** A kyverno-json policy asserting settlement finality
|
||||
(`all_committed: true`) before promotion is a securities-specific
|
||||
extension of v1.25's policy engine. Is this over-engineering for a
|
||||
pilot that only runs in `dev` (autonomous, no promotion to qa/prod/dr
|
||||
in v1.26 per D-208)?
|
||||
|
||||
**Response:** The `nova-contracts` table has PK `consumerRepo` and SK
|
||||
`contractId#submittedAt`. To find the last record for a given
|
||||
contractId, we query by PK `consumerRepo` + SK `begins_with
|
||||
"contractId#"` + FilterExpression `status = "submitted"` (or
|
||||
`#LAST_APPLIED`), sort by `submittedAt` desc, take the first. This is
|
||||
correct DynamoDB pattern. The `record_applied_env` step writes a new
|
||||
item with SK `contractId#LAST_APPLIED#<timestamp>` so the detect step
|
||||
can filter by `begins_with "contractId#LAST_APPLIED#"`. **Confidence:
|
||||
0.85.**
|
||||
**Verdict:** PROCEED (confidence 0.80). The policy is *authored* in
|
||||
v1.26 (P3) but its *enforcement* activates when a promotion to qa/prod
|
||||
happens — which is a *future* milestone (D-208: qa/prod/dr stay
|
||||
placeholder this milestone). The policy is tested (passing + failing
|
||||
fixtures; skip when `kj` absent) in P3, but it doesn't gate a `dev`
|
||||
apply (the pilot-readiness policy REQ-320 gates `dev`; the settlement-
|
||||
finality policy gates promotions). Authoring + testing the policy in
|
||||
v1.26 is the right thing: it (a) proves the kyverno-json engine can
|
||||
assert a domain invariant, (b) ships the policy artifact so a future
|
||||
milestone that binds qa/prod/dr can enable it without re-architecting,
|
||||
(c) extends v1.25's moat (the policy engine is swappable + extensible
|
||||
to new domains). The cost is ~1 policy file + 1 test file. No revision
|
||||
needed — but the POLICY IS NOT ENFORCED in v1.26 (it's authored +
|
||||
tested, enforcement is future). PLAN.md should note this. **Minor
|
||||
revision: PLAN.md P3 W4 Task 4.1 should note "policy authored + tested;
|
||||
enforcement deferred to the milestone that binds qa/prod/dr."** Already
|
||||
implicit in the plan (the policy gates promotions, not dev applies);
|
||||
making it explicit is a documentation refinement, not a scope change.
|
||||
|
||||
**Challenge:** What if the DynamoDB table doesn't exist in local/CI
|
||||
mode?
|
||||
### G-Q7 — Is D-083 deferral defensible for a pilot with real money-like flows?
|
||||
|
||||
**Response:** The detect step catches `ClientError` / `EndpointNotFound`,
|
||||
logs a warning, and returns `None` (no prior env). The pipeline proceeds
|
||||
normally. This is the conservative path — no false-positive destroys.
|
||||
**Confidence: 0.90.**
|
||||
**Challenge:** The pilot is a stock exchange — securities trading. D-083
|
||||
(S3 Object Lock / JWS tamper-evident ledger) is deferred (D-204). The
|
||||
SQLite hash-chain + DynamoDB outbox is the audit record. Is this
|
||||
defensible for a domain where audit integrity is legally mandated?
|
||||
|
||||
**Verdict:** CORRECT.
|
||||
**Verdict:** PROCEED (confidence 0.82). The pilot is a *technical
|
||||
demonstration*, not a production trading system. No real money, no real
|
||||
securities, no real investors — the "securities" are test tokens on a
|
||||
homegrown chain. The audit integrity requirement (SEC Rule 17a-4, FINRA
|
||||
retention) applies to *production* trading systems, not to a pilot
|
||||
exercising a platform's deploy/policy/attestation gates. The SQLite
|
||||
hash-chain + DynamoDB outbox is a tamper-*evident* record (any tampering
|
||||
breaks the hash chain) — it's just not tamper-*resistant* (S3 Object
|
||||
Lock + JWS would make it tamper-resistant). For a pilot, tamper-evident
|
||||
suffices. D-083 lift is a future milestone (when the pilot becomes a
|
||||
production system). D-204 records this. No revision needed.
|
||||
|
||||
## Axis 5: Testing
|
||||
### G-Q8 — Does the outcome-backfill emitter (REQ-317) touch the PCR schema?
|
||||
|
||||
**Challenge:** Can the env-transition behavior be tested without live
|
||||
AWS?
|
||||
**Challenge:** REQ-317 wires `apply.completed`/`apply.failed` →
|
||||
`fact_decision.outcome`. The v1.25 hard constraint says "DO NOT change
|
||||
`schemas/policy_check_result.schema.json`." Does the backfill touch the
|
||||
PCR schema?
|
||||
|
||||
**Response:** Yes. `test_env_transition.py` uses moto for DynamoDB
|
||||
(mock_aws pattern from `test_contract_ingestor.py:74-110`).
|
||||
`test_run_platform_env_transition.py` uses shell-text assertions
|
||||
(pattern from `test_pipeline.py:79-95`). No live AWS needed.
|
||||
**Confidence: 0.92.**
|
||||
**Verdict:** PROCEED (confidence 0.95). D-211 (CLARIFY) already
|
||||
resolved this: the outcome backfill touches the *metrics cold store*
|
||||
(`fact_decision` table in `metrics/nova_metrics.db`), not the PCR
|
||||
schema. The backfill reads run-manifest events (not PCRs) and updates
|
||||
the decision's outcome column. The PCR schema is unchanged. This
|
||||
respects the v1.25 hard constraint. No revision needed.
|
||||
|
||||
**Verdict:** TESTABLE.
|
||||
### G-Q9 — Does the `NOVA_AWS_*` root-equivalent key create a security risk?
|
||||
|
||||
## Axis 6: Security
|
||||
**Challenge:** D-207 says `NOVA_AWS_*` has root-equivalent permissions
|
||||
(confirmed empirically: the bootstrap created the S3 bucket + DynamoDB
|
||||
table). Using a root key for the pilot's `terraform apply` is a
|
||||
security risk — a key compromise gives full account access. Should the
|
||||
pilot use a least-privilege key?
|
||||
|
||||
**Challenge:** Does the destroy step introduce a risk of destroying the
|
||||
wrong resources?
|
||||
|
||||
**Response:** The destroy targets the prior env's state key
|
||||
(`spike/{id}/{prior_env}/terraform.tfstate`). The state key is
|
||||
deterministic and env-scoped. The destroy can only affect resources in
|
||||
that state file. The `deletion_protection=false` injection is scoped to
|
||||
the destroy step only — the new env's apply runs with the default
|
||||
`deletion_protection=true`. **Confidence: 0.88.**
|
||||
|
||||
**Challenge:** Could a malicious consumer trigger a destroy of another
|
||||
consumer's resources?
|
||||
|
||||
**Response:** No. The DynamoDB query is scoped by PK `consumerRepo`
|
||||
(the consumer's own repo identity). The destroy runs under the
|
||||
consumer's ABAC-scoped deploy role, which can only touch resources
|
||||
tagged `nova:owner=<consumer-repo>`. A consumer cannot query or destroy
|
||||
another consumer's stack. **Confidence: 0.90.**
|
||||
|
||||
**Verdict:** SECURE.
|
||||
|
||||
## Axis 7: Maintainability
|
||||
|
||||
**Challenge:** Is the `core/env_transition.py` module a clean
|
||||
abstraction or a one-off?
|
||||
|
||||
**Response:** It's a reusable module with two functions
|
||||
(`detect_prior_env`, `record_applied_env`) that encapsulate the
|
||||
DynamoDB query logic. It can be extended for cross-account destroy in a
|
||||
future milestone. The shell Step 0b is a thin orchestrator. This is
|
||||
maintainable. **Confidence: 0.85.**
|
||||
|
||||
**Verdict:** MAINTAINABLE.
|
||||
|
||||
## Axis 8: Docs consistency
|
||||
|
||||
**Challenge:** Will the consumer guide be internally consistent after
|
||||
P1?
|
||||
|
||||
**Response:** The 5 fixes address all known inconsistencies: field
|
||||
table ↔ schema, Step 2 ↔ Step 4, Step 5 ↔ environments doc, Step 8 ↔
|
||||
per-env section, reference table ↔ sample contracts. The test updates
|
||||
assert both shapes are documented. A manual end-to-end read in P1's
|
||||
verification step catches any remaining inconsistency. **Confidence:
|
||||
0.88.**
|
||||
|
||||
**Verdict:** CONSISTENT.
|
||||
|
||||
## Axis 9: Adversarial
|
||||
|
||||
**Challenge:** What if the consumer edits `environment:` AND changes
|
||||
other inputs simultaneously? Does the destroy-then-apply still work?
|
||||
|
||||
**Response:** Yes. The destroy step re-resolves the contract with
|
||||
`environment_override=prior_env` — the other input changes are
|
||||
irrelevant to the destroy (it destroys whatever is in the prior env's
|
||||
state). The new apply resolves with the new env + new inputs. The two
|
||||
operations are independent. **Confidence: 0.85.**
|
||||
|
||||
**Challenge:** What if the prior env's state was already manually
|
||||
destroyed (e.g., via decommission)?
|
||||
|
||||
**Response:** `terraform destroy` against an empty state is a no-op
|
||||
(exits 0). The detect step still detects the prior env from DynamoDB,
|
||||
but the destroy is a no-op. The apply proceeds. This is correct
|
||||
behavior — no false failure. **Confidence: 0.88.**
|
||||
|
||||
**Verdict:** ROBUST.
|
||||
**Verdict:** PROCEED (confidence 0.78). The risk is real but bounded:
|
||||
(a) the pilot runs in a single account (`581513795199`) with no
|
||||
production workloads (the v1.11 teardown left it empty; the pilot is
|
||||
the only workload), (b) the key is in `.env.secrets` (gitignored, never
|
||||
committed), (c) the deploy workflow uses OIDC by default (the static
|
||||
key is the override, not the primary path). A future hardening
|
||||
milestone should split `NOVA_AWS_*` into a root `NOVA_BOOTSTRAP_AWS_*`
|
||||
+ a least-privilege `NOVA_AWS_*` runner key (the spike-runner pattern).
|
||||
For v1.26, the single key suffices (pilot scope). D-207 records this.
|
||||
**Minor revision: PLAN.md should note the key-split as a future
|
||||
hardening item.** Already implicit in D-207; making it explicit in the
|
||||
plan is a documentation refinement.
|
||||
|
||||
---
|
||||
|
||||
## Binding revisions applied
|
||||
## Summary
|
||||
|
||||
1. **R1 (docs):** Add to RESEARCH.md pitfalls: the destroy step must
|
||||
inject `deletion_protection=false` into the contract inputs before
|
||||
re-resolving with `environment_override=prior_env`. Without this,
|
||||
`prevent_destroy` lifecycle blocks (REQ-86) block the destroy. This
|
||||
is already noted in RESEARCH §5 pitfall 3 and PLAN P2 implementation
|
||||
note 3. No change needed — already captured.
|
||||
9 challenges; 0 escalations; 2 binding revisions (G-Q4, G-Q6/G-Q9
|
||||
minor). Overall verdict: PROCEED (confidence 0.84).
|
||||
|
||||
2. **R2 (docs):** Clarify in PLAN P2 that the `record_applied_env` SK
|
||||
format is `contractId#LAST_APPLIED#<timestamp>` so the detect step
|
||||
can query `begins_with "contractId#LAST_APPLIED#"`. This is already
|
||||
in RESEARCH §2 and GRILL Axis 4. No change needed — already captured.
|
||||
**Binding revisions:**
|
||||
- **G-Q4:** REQ-322 moves to P2 W0 (already revised in PLAN.md + ROADMAP.md).
|
||||
- **G-Q6:** PLAN.md P3 W4 Task 4.1 should note the settlement-finality
|
||||
policy is authored + tested in v1.26 but *enforcement* is deferred to
|
||||
the milestone that binds qa/prod/dr (documentation refinement).
|
||||
- **G-Q9:** PLAN.md should note the `NOVA_AWS_*` key-split as a future
|
||||
hardening item (documentation refinement).
|
||||
|
||||
## Escalations
|
||||
|
||||
None. All challenges resolved at full autonomy.
|
||||
**No work is blocked.** The milestone is feasible, scoped, and the
|
||||
domain claims hold. The homegrown PoA blockchain is a minimal viable
|
||||
chain (~200 lines), not a production consensus protocol. The equities-
|
||||
only scope is the user's choice. The multi-project mode is specified in
|
||||
`run.md`. The P2→P3 dependency is resolved (REQ-322 → P2 W0). The
|
||||
MTTR target is for incident-remediation, not first-time apply. The
|
||||
settlement-finality policy is authored + tested, enforcement is future.
|
||||
D-083 deferral is defensible for a technical pilot. The PCR schema is
|
||||
unchanged. The root-equivalent key is a bounded risk with a documented
|
||||
future hardening path.
|
||||
@@ -0,0 +1,194 @@
|
||||
# IDEATE — v1.26 Live Pilot Estate Activation
|
||||
|
||||
> **Autonomy:** full. 3-tier ideation per `config.json ideation.enabled:
|
||||
> true`. `cross_project.enabled: false` → cross-project tier scoped to
|
||||
> multi-project (deferred ideas only, no cross-project candidates
|
||||
> accepted). `confidence_threshold: 0.6`, `max_ideas: 20`.
|
||||
> Categories: security, quality, architecture, coverage, improvement.
|
||||
|
||||
## Tier 1 — Mechanical (pattern-driven, codebase-grounded)
|
||||
|
||||
### I1 — Outcome-backfill emitter ✅ ACCEPTED (REQ-317)
|
||||
|
||||
**Category:** quality, coverage
|
||||
**Confidence:** 0.92
|
||||
**Pattern:** stuck `pending` status → backfilled from a later event
|
||||
(the most direct metric-grounding pattern).
|
||||
**Source:** `core/metrics/decision_ledger.py:210-211` documents the
|
||||
event chain `confidence.computed → ai.decision.made →
|
||||
attestation.recorded → run.completed/failed`. `collector.py:262`
|
||||
inserts `fact_decision.outcome` as `"pending"` — no backfill step
|
||||
wires `run.completed/failed` back into the decision's outcome. The AI
|
||||
Decision Accuracy metric (`trust_snapshot.py:70-85`) reads
|
||||
`decisions WHERE outcome='succeeded' ÷ total` → 0% today (all pending).
|
||||
**Idea:** `core/metrics/outcome_backfill.py` reads run-manifest
|
||||
`completed`/`failed` events and updates `fact_decision.outcome` +
|
||||
`fact_decision.backfilled_at`. The collector invokes backfill after run
|
||||
completion. Grounds AI Decision Accuracy (Post-Pilot target).
|
||||
**Accepted into:** REQ-317. Phase P3.
|
||||
|
||||
### I2 — `reason='confidence'` escalation tag ✅ ACCEPTED (REQ-318)
|
||||
|
||||
**Category:** quality, coverage
|
||||
**Confidence:** 0.90
|
||||
**Pattern:** boolean field → discriminated field (the metric-numerator
|
||||
precision pattern).
|
||||
**Source:** `core/confidence_signal.py:184` — a `block` band sets
|
||||
`human_override=True`. The Human Escalation Frequency metric
|
||||
(`docs/metrics/human_escalation_frequency.md:11-12`) is defined as
|
||||
`count(runs WHERE hitl_block=1 AND reason='confidence') ÷ total runs`.
|
||||
The `reason='confidence'` discriminator is not stored today.
|
||||
**Idea:** `ai.decision.made` gains `escalation_reason: 'confidence'`
|
||||
when `band == 'block'`. The collector persists it into `fact_run`.
|
||||
Grounds Human Escalation Frequency numerator.
|
||||
**Accepted into:** REQ-318. Phase P3.
|
||||
|
||||
### I3 — Env-JSON `state_backend` wiring reconciliation ✅ ACCEPTED (REQ-319)
|
||||
|
||||
**Category:** architecture, improvement
|
||||
**Confidence:** 0.88
|
||||
**Pattern:** unused config field → wired config field (the
|
||||
single-source-of-truth pattern).
|
||||
**Source:** `adapters/terraform/adapter.py:116-117` computes the state
|
||||
bucket as `nova-tfstate-<AWS_ACCOUNT_ID>-us-east-1` from the
|
||||
`AWS_ACCOUNT_ID` env var — **not** from the env JSON's
|
||||
`state_backend.bucket`. The env JSON's `state_backend` field is
|
||||
currently unused by the live apply path.
|
||||
**Idea:** The adapter reads `env.state_backend.bucket` when present
|
||||
(falling back to the computed name for backwards compat). `dev.json`
|
||||
gets the real bucket name. Closes the wiring gap so the pilot's env
|
||||
JSON is the single source of truth.
|
||||
**Accepted into:** REQ-319. Phase P3.
|
||||
|
||||
### I4 — Pilot-readiness kyverno-json policy ✅ ACCEPTED (REQ-320)
|
||||
|
||||
**Category:** security, architecture
|
||||
**Confidence:** 0.85
|
||||
**Pattern:** runtime guard → declarative policy (the v1.25 thesis
|
||||
applied to pilot onboarding).
|
||||
**Source:** `core/environment_check.py:48-53` emits a stderr warning
|
||||
(non-fatal) when `account_id == "000000000000"` and env != dev. A
|
||||
warning is not a gate. The pilot should fail-closed if someone tries
|
||||
to apply against a placeholder account.
|
||||
**Idea:** A kyverno-json policy over the env JSON asserting
|
||||
`account_id != "000000000000"` before any apply. Declarative
|
||||
fail-closed gate. Extends v1.25's policy engine to the pilot-onboarding
|
||||
domain.
|
||||
**Accepted into:** REQ-320. Phase P3.
|
||||
|
||||
## Tier 2 — Backend-enriched (signal-driven)
|
||||
|
||||
### I5 — Settlement-finality kyverno-json policy ✅ ACCEPTED (REQ-315)
|
||||
|
||||
**Category:** security, coverage
|
||||
**Confidence:** 0.82
|
||||
**Pattern:** domain invariant → declarative policy (the v1.25 thesis
|
||||
applied to the securities domain — the most novel use of kyverno-json
|
||||
in v1.26).
|
||||
**Source:** The pilot's settlement service records matches as
|
||||
transactions on the chain; settlement finality = block commit. The
|
||||
NORTH_STAR Objective #2 (provable trust) says trust should be a policy
|
||||
artifact, not a promise. Today settlement finality is a runtime
|
||||
property of the chain; making it a declarative policy turns it into an
|
||||
auditable gate.
|
||||
**Idea:** A kyverno-json policy over the settlement-service status JSON
|
||||
asserting `all_committed: true` before any promotion (qa→prod). The
|
||||
securities-specific extension of v1.25's policy engine. The policy is
|
||||
skip-when-kj-absent (graceful).
|
||||
**Accepted into:** REQ-315. Phase P3.
|
||||
|
||||
### I6 — Pilot-estate regression capability (CAP-025) ✅ ACCEPTED (REQ-316)
|
||||
|
||||
**Category:** quality, coverage
|
||||
**Confidence:** 0.88
|
||||
**Pattern:** manual e2e → regression-gated capability (the v1.0 CAP
|
||||
pattern applied to the pilot).
|
||||
**Source:** `core/regression_verify.py` has CAP-013..024 (live-AWS +
|
||||
local tiers). The pilot estate is a new live-AWS capability —
|
||||
"contract resolve → adapter compile → terraform plan → policy scan →
|
||||
confidence signal → attestation → outbox record" against
|
||||
`581513795199`. Without a regression CAP, the pilot could silently
|
||||
decay.
|
||||
**Idea:** CAP-025 (live-pilot-apply) in the regression gate. The
|
||||
round-trip assertion. Grounds the pilot as a maintained capability,
|
||||
not a one-shot demo.
|
||||
**Accepted into:** REQ-316. Phase P3.
|
||||
|
||||
### I7 — DynamoDB L1 primitive ✅ ACCEPTED (REQ-322)
|
||||
|
||||
**Category:** architecture, coverage
|
||||
**Confidence:** 0.95
|
||||
**Pattern:** missing primitive → authored module (the v1.7 + v1.8
|
||||
module-build-out pattern).
|
||||
**Source:** RESEARCH §3.4 — no `modules/l1/dynamodb/` exists. The
|
||||
blockchain exchange's ledger table needs it. The adapter is
|
||||
stateless/registry-driven (no `TYPE_MAP`); a new stack type requires a
|
||||
new L1 module, not an adapter change.
|
||||
**Idea:** Author `modules/l1/dynamodb/` (interface.json +
|
||||
terraform/main.tf + README.md + instance.json + registry.json entry).
|
||||
The single platform-side module build-out for the milestone. Follows
|
||||
the `s3`/`rds` primitive template. Encryption + PITR enabled per v1.8
|
||||
NFR defaults.
|
||||
**Accepted into:** REQ-322. Phase P3.
|
||||
|
||||
### I8 — Stale `adapters/README.md` TYPE_MAP references ❌ DEFERRED (scope)
|
||||
|
||||
**Category:** improvement
|
||||
**Confidence:** 0.70 (above threshold, but scoped into REQ-321)
|
||||
**Pattern:** stale doc → corrected doc.
|
||||
**Source:** `adapters/README.md:49-54` references the deleted
|
||||
`TYPE_MAP`/`INPUT_MAP`/`OUTPUT_MAP` — contradicts `adapter.py:1-11` +
|
||||
`modules/STANDARDS.md:212-214`.
|
||||
**Idea:** Fix the stale references as part of the docs phase.
|
||||
**Reason deferred as a standalone idea:** Already captured in REQ-321
|
||||
(docs + adapter README). No new requirement needed — the fix lands in
|
||||
P4 docs.
|
||||
|
||||
## Tier 3 — Cross-project (deferred — multi-project, but cross-project sharing disabled)
|
||||
|
||||
### I9 — Cross-project policy sharing ❌ DEFERRED (config)
|
||||
|
||||
**Category:** improvement
|
||||
**Confidence:** N/A
|
||||
**Pattern:** policies shared across projects in a multi-project org.
|
||||
**Source:** `config.json ideation.cross_project.enabled: false`.
|
||||
**Idea:** In a multi-project org, kyverno-json policies could be shared
|
||||
across projects (a tagging standard policy applies to all projects).
|
||||
**Reason deferred:** `cross_project.enabled: false`. Even though
|
||||
v1.26 is multi-project (acdl + nova-blockchain-exchange),
|
||||
cross-project *ideation* is disabled in config. Recorded for when the
|
||||
org grows + the flag is enabled.
|
||||
|
||||
### I10 — Consumer-repo CI scaffolding as a reusable template ❌ DEFERRED
|
||||
|
||||
**Category:** improvement
|
||||
**Confidence:** 0.55 (below threshold — deferred, not rejected)
|
||||
**Pattern:** one-off CI → reusable template.
|
||||
**Source:** The consumer repo (`nova-blockchain-exchange`) needs its
|
||||
own CI (`ci.yml` — lint + pytest). If Nova expects many consumers, a
|
||||
reusable consumer-CI template would reduce onboarding friction.
|
||||
**Idea:** A `nova-consumer-template` repo (or a
|
||||
`.github/workflow-templates/` dir) that new consumers instantiate.
|
||||
**Reason deferred:** Nova has 1 consumer today (the pilot). A template
|
||||
is premature abstraction until the 2nd consumer arrives. The pilot's
|
||||
CI is authored directly (REQ-310..312 tests). Recorded for when the
|
||||
3rd consumer onboards.
|
||||
|
||||
## Summary
|
||||
|
||||
- 7 ideas accepted (I1..I7) → already captured as REQ-315, REQ-316,
|
||||
REQ-317, REQ-318, REQ-319, REQ-320, REQ-322.
|
||||
- 3 ideas deferred (I8 scoped into REQ-321; I9 config-disabled; I10
|
||||
below threshold) with documented blocking reasons.
|
||||
- 0 ideas rejected (below-threshold ideas are deferred, not rejected —
|
||||
they may activate when their blockers lift).
|
||||
- The accepted ideas are the **quality improvement** the `--ideate` flag
|
||||
drives: I1 + I2 ground the Post-Pilot metrics (outcome backfill +
|
||||
escalation reason); I3 closes the env-JSON wiring gap; I4 + I5 extend
|
||||
v1.25's policy engine to the pilot domain (pilot-readiness +
|
||||
settlement-finality); I6 gates the pilot as a maintained capability;
|
||||
I7 is the single platform-side module build-out.
|
||||
- No new requirements added beyond REQ-310..322 (the accepted ideas are
|
||||
already scoped into the existing requirements). The IDEATE pass
|
||||
validated the requirement set rather than expanding it — the ideas
|
||||
were anticipated in the SPECIFY + RESEARCH stages.
|
||||
+13
-1
@@ -229,4 +229,16 @@ their AI engineering teams reach for first when an agent needs to deploy.
|
||||
RESEARCH.md/ARCHITECTURE.md. It is the *how*; this file is the *why*.
|
||||
- **Pillar C (story):** the unified narrative deck proves Pillars A+B to
|
||||
leadership. The deck's Proof section cites grounded metrics; its
|
||||
Roadmap section cites deferred targets honestly.
|
||||
Roadmap section cites deferred targets honestly.
|
||||
|
||||
## v1.25 update — swappable policy-engine substrate
|
||||
|
||||
Strategic Objective #2 (provable trust) gained a concrete substrate in
|
||||
v1.25: the policy engine that produces the `PolicyCheckResult` records
|
||||
feeding the confidence signal is now **swappable** via the
|
||||
`PolicyEngine` protocol (`core/policy_engine.py`). `kyverno-json` is
|
||||
the v1.25 default; `OPA` (or any other engine) can replace it by
|
||||
implementing the same 3-method protocol — without touching the
|
||||
confidence signal, the PCR schema, or the pipeline. See
|
||||
ARCHITECTURE.md §12.7. The trust moat is a *replaceable* engine, not a
|
||||
vendor lock-in.
|
||||
+152
-66
@@ -1,83 +1,169 @@
|
||||
---
|
||||
project: acdl
|
||||
milestone: v1.24
|
||||
milestone: v1.26
|
||||
generated_at: 2026-08-12
|
||||
generator: lead-developer
|
||||
verification_toolchain:
|
||||
typecheck: "python3 -m py_compile core/env_transition.py tests/test_env_transition.py tests/test_run_platform_env_transition.py"
|
||||
test: "pytest tests/test_env_transition.py tests/test_run_platform_env_transition.py tests/test_consumer_guide_per_env_section.py tests/test_adapter.py tests/test_contract_resolver.py tests/test_deploy_workflow_env_input.py tests/test_pipeline.py -v"
|
||||
lint: "ruff check core/env_transition.py tests/test_env_transition.py tests/test_run_platform_env_transition.py 2>/dev/null || python3 -m py_compile core/env_transition.py"
|
||||
typecheck: "python3 -m py_compile core/confidence_signal.py core/metrics/outcome_backfill.py adapters/terraform/adapter.py modules/l1/dynamodb/terraform/main.tf"
|
||||
test: "pytest tests/test_adapter.py tests/test_contract_resolver.py tests/test_confidence_signal.py tests/test_outcome_backfill.py tests/test_settlement_finality_policy.py tests/test_pilot_readiness_policy.py tests/test_block.py tests/test_order_book.py tests/test_settlement.py -v"
|
||||
lint: "ruff check core/metrics/outcome_backfill.py adapters/kyverno-json/policies/pilot-readiness/ adapters/kyverno-json/policies/settlement-finality/ 2>/dev/null || python3 -m py_compile core/metrics/outcome_backfill.py"
|
||||
note: |
|
||||
v1.24 is the Consumer Guide Accuracy & Env-Promotion Lifecycle
|
||||
Enforcement milestone — a mixed docs+feat+test milestone. Two active
|
||||
personas: lead-developer (consumer-guide.md edits + guide test
|
||||
updates), backend-engineer (core/env_transition.py + run_platform.sh
|
||||
Step 0b + deploy.yml + adapter doc comment + env_transition tests +
|
||||
pipeline tests). frontend-engineer stays deactivated (no UI). No
|
||||
data-engineer (no schema changes — the nova-contracts table already
|
||||
exists). No new personas.
|
||||
v1.26 is the Live Pilot Estate Activation milestone — a feat
|
||||
milestone. Four active personas: lead-developer (coordination +
|
||||
docs + ARCHITECTURE.md §12.8), backend-engineer (confidence_signal.py
|
||||
escalation reason + outcome_backfill.py + run_platform.sh wiring +
|
||||
env-JSON state_backend reconciliation), data-engineer (DynamoDB L1
|
||||
primitive + metrics cold store outcome backfill), policy-engineer
|
||||
(kyverno-json pilot-readiness + settlement-finality policies), +
|
||||
blockchain-engineer (custom, phase-specific — chain core + order
|
||||
engine + settlement). frontend-engineer is deactivated (no UI).
|
||||
Territory enforcement: warn (the pilot is cross-territory by
|
||||
nature — the consumer repo + the platform repo share the milestone).
|
||||
---
|
||||
|
||||
# ACDL — Persona Roster (v1.24 Consumer Guide Accuracy & Env-Promotion Lifecycle Enforcement)
|
||||
# PERSONAS — v1.26 Live Pilot Estate Activation
|
||||
|
||||
> v1.24 roster. Two active personas + two deactivated. This is a mixed
|
||||
> docs+feat+test milestone: the work is consumer-guide accuracy fixes
|
||||
> (lead-developer), a new env-transition detect-and-destroy platform
|
||||
> feature (backend-engineer), and test coverage for both (split).
|
||||
> Generated by the lead-developer at the end of RESEARCH. Assesses the
|
||||
> project domains, activates/deactivates personas, creates custom
|
||||
> personas for domains beyond the default four, aligns frameworks +
|
||||
> territory + constraints to the actual project structure.
|
||||
|
||||
## Active personas
|
||||
## Active Roster (5)
|
||||
|
||||
### lead-developer
|
||||
- **Domain:** coordination + docs
|
||||
- **Frameworks:** []
|
||||
- **Constraints:** ["pragmatic", "battle-tested defaults", "docs match code"]
|
||||
- **Territory:**
|
||||
- `docs/consumer-guide.md`
|
||||
- `tests/test_consumer_guide_per_env_section.py`
|
||||
- `.ciagent/*.md` (PLAN.md, RESEARCH.md, etc.)
|
||||
- **Reason:** Owns the consumer guide narrative — the 5 accuracy fixes
|
||||
(stale fields table, inconsistent caller, "dev only" phrasing, Step 8
|
||||
rewrite with destroy semantics, reference table wording) and the
|
||||
consumer-guide test updates (rename + new destroy-on-env-change test).
|
||||
No UI work (frontend-engineer deactivated). No Python/bash platform
|
||||
code (backend-engineer territory).
|
||||
### 1. lead-developer (active)
|
||||
- **active:** true
|
||||
- **phase_specific:** false
|
||||
- **reason:** Coordinates task decomposition + resolves conflicts between
|
||||
engineering personas. Owns the milestone narrative (PROJECT.md,
|
||||
ROADMAP.md, ARCHITECTURE.md §12.8). Final architectural decisions when
|
||||
personas disagree (e.g. where the outcome-backfill emitter lives).
|
||||
- **domain:** project coordination, milestone narrative, cross-persona
|
||||
conflict resolution.
|
||||
- **frameworks:** none (coordination role).
|
||||
- **territory:** `.ciagent/`, `docs/METRICS.md`, `adapters/README.md`,
|
||||
`modules/README.md`, `modules/STANDARDS.md`.
|
||||
- **constraints:** does not write Python/Terraform (delegates to
|
||||
backend/data-engineer); does not author policies (delegates to
|
||||
policy-engineer); does not author chain code (delegates to
|
||||
blockchain-engineer).
|
||||
|
||||
### backend-engineer
|
||||
- **Domain:** backend (Python + bash + YAML)
|
||||
- **Frameworks:** ["boto3", "terraform"]
|
||||
- **Constraints:** ["api-first", "fail-closed", "no orphan paths", "state-key determinism"]
|
||||
- **Territory:**
|
||||
- `core/env_transition.py` (NEW)
|
||||
- `scripts/run_platform.sh` (Step 0b insert + record-applied-env)
|
||||
- `.github/workflows/deploy.yml` (NOVA_CONSUMER_REPO env)
|
||||
- `adapters/terraform/adapter.py` (doc comment only)
|
||||
- `tests/test_env_transition.py` (NEW)
|
||||
- `tests/test_run_platform_env_transition.py` (NEW)
|
||||
- **Reason:** Owns the env-transition detect-and-destroy feature: the new
|
||||
`core/env_transition.py` module (DynamoDB query + record), the
|
||||
`run_platform.sh` Step 0b orchestrator (re-resolve + terraform destroy +
|
||||
evidence event + fail-closed), the deploy.yml env var passthrough, and
|
||||
the two new test files. Uses boto3 (DynamoDB) + terraform (destroy) +
|
||||
bash (pipeline orchestration).
|
||||
### 2. backend-engineer (active)
|
||||
- **active:** true
|
||||
- **phase_specific:** false
|
||||
- **reason:** Owns the platform-side Python changes: confidence signal
|
||||
escalation reason (REQ-318), outcome-backfill emitter (REQ-317),
|
||||
env-JSON state_backend wiring (REQ-319), adapter test updates for
|
||||
DynamoDB (REQ-322), regression CAP-025 (REQ-316).
|
||||
- **domain:** core Python (confidence_signal.py, metrics/, adapter.py,
|
||||
regression_verify.py, contract_resolver.py), run_platform.sh wiring.
|
||||
- **frameworks:** Python 3.12, pytest, boto3, SQLite, DynamoDB.
|
||||
- **territory:** `core/confidence_signal.py`, `core/metrics/`,
|
||||
`adapters/terraform/adapter.py`, `core/regression_verify.py`,
|
||||
`core/environments/`, `scripts/run_platform.sh`, `tests/test_adapter.py`,
|
||||
`tests/test_confidence_signal.py`, `tests/test_outcome_backfill.py`,
|
||||
`tests/test_regression_pilot.py`.
|
||||
- **constraints:** does not change `schemas/policy_check_result.schema.json`
|
||||
(v1.25 moat, D-211); does not change `schemas/contract.schema.json`
|
||||
(no schema breaks, D-213); does not author Terraform modules
|
||||
(delegates to data-engineer for DynamoDB); does not author policies
|
||||
(delegates to policy-engineer); does not author chain code (delegates
|
||||
to blockchain-engineer).
|
||||
|
||||
## Deactivated personas
|
||||
### 3. data-engineer (active)
|
||||
- **active:** true
|
||||
- **phase_specific:** false
|
||||
- **reason:** Owns the DynamoDB L1 primitive (REQ-322) — the single
|
||||
platform-side module build-out. Owns the metrics cold store
|
||||
outcome-backfill integration (REQ-317, the `fact_decision.outcome`
|
||||
column + `backfilled_at` timestamp). Owns the env-JSON data updates
|
||||
(REQ-319, `core/environments/*.json` account_id + state_backend.bucket).
|
||||
- **domain:** Terraform modules (`modules/l1/`), schema definitions
|
||||
(`interface.json`), registry (`modules/registry.json`), metrics cold
|
||||
store (`metrics/nova_metrics.db`, `core/metrics/collector.py`).
|
||||
- **frameworks:** Terraform, JSON, SQLite, DynamoDB, boto3.
|
||||
- **territory:** `modules/l1/dynamodb/`, `modules/registry.json`,
|
||||
`modules/README.md`, `core/environments/*.json`,
|
||||
`core/metrics/collector.py`, `tests/test_adapter.py` (DynamoDB
|
||||
emission test).
|
||||
- **constraints:** does not change the adapter (stateless, v1.11);
|
||||
follows the v1.8 NFR defaults (encryption + deletion protection +
|
||||
PITR); follows the module standards (`modules/STANDARDS.md`).
|
||||
|
||||
### frontend-engineer
|
||||
- **Active:** false
|
||||
- **Reason:** No UI work in v1.24. The consumer guide is markdown docs
|
||||
(lead-developer territory). Deactivated per v1.17/v1.18/v1.22/v1.23
|
||||
precedent.
|
||||
### 4. policy-engineer (active, custom — added in v1.25)
|
||||
- **active:** true
|
||||
- **phase_specific:** false
|
||||
- **reason:** Owns the kyverno-json policy authoring for the pilot:
|
||||
settlement-finality (REQ-315), pilot-readiness (REQ-320). Extends
|
||||
v1.25's policy engine to the securities domain.
|
||||
- **domain:** declarative policies (kyverno-json ValidatingPolicy YAML),
|
||||
JMESPath assertions, policy tests.
|
||||
- **frameworks:** kyverno-json, JMESPath, JSON, pytest.
|
||||
- **territory:** `adapters/kyverno-json/policies/pilot-readiness/`,
|
||||
`adapters/kyverno-json/policies/settlement-finality/`,
|
||||
`tests/test_settlement_finality_policy.py`,
|
||||
`tests/test_pilot_readiness_policy.py`.
|
||||
- **constraints:** policies are declarative (no imperative Python);
|
||||
`is_configured()` guard skips gracefully when `kj` absent; follows
|
||||
the v1.25 policy-authoring standard (`modules/STANDARDS.md` policy
|
||||
section + `adapters/kyverno-json/README.md`).
|
||||
|
||||
### data-engineer
|
||||
- **Active:** false
|
||||
- **Reason:** No schema changes in v1.24. The `nova-contracts` DynamoDB
|
||||
table already exists with the right shape (PK `consumerRepo`, SK
|
||||
`contractId#submittedAt`). The env-transition module only adds a new
|
||||
`#LAST_APPLIED` SK suffix — no schema migration, no ORM, no new tables.
|
||||
The backend-engineer handles the boto3 queries.
|
||||
### 5. blockchain-engineer (active, custom, phase-specific — added in v1.26)
|
||||
- **active:** true
|
||||
- **phase_specific:** true (created for v1.26 P1; removed after P1
|
||||
unless the chain has ongoing work in P2..P4)
|
||||
- **reason:** The pilot introduces a homegrown blockchain — a domain
|
||||
beyond the default four personas. Owns the chain core (block, ledger,
|
||||
validator, REQ-310), the order-matching engine (REQ-311), the
|
||||
settlement service (REQ-312), and the consumer `contract.yaml`
|
||||
(REQ-313) + deploy invocation (REQ-314).
|
||||
- **domain:** blockchain consensus (PoA, single validator), order
|
||||
matching (limit order book, price-time priority), settlement
|
||||
(T+1, finality = block commit), consumer-repo deploy model.
|
||||
- **frameworks:** Python 3.12 (the chain is Python, not Solidity/Go —
|
||||
it's a homegrown ledger, not a smart-contract platform), pytest,
|
||||
YAML (contract.yaml), GitHub Actions / Gitea Actions (deploy.yml
|
||||
invocation).
|
||||
- **territory:** `/root/nova-blockchain-exchange/` (the consumer repo:
|
||||
`chain/`, `engine/`, `settlement/`, `contract.yaml`,
|
||||
`contracts/*.yml`, `.github/workflows/deploy.yml`,
|
||||
`.gitea/workflows/deploy.yml`, `tests/`).
|
||||
- **constraints:** the chain is deterministic (same inputs → same block)
|
||||
— it is automation, not AI (NORTH_STAR Objective #2 tenet); equities
|
||||
only (D-200); single validator PoA (D-201); the consumer deploy MUST
|
||||
go through `deploy.yml@v1.25` (no direct terraform apply); the
|
||||
contract MUST validate against `schemas/contract.schema.json`.
|
||||
|
||||
## Phase-specific notes
|
||||
## Deactivated (1)
|
||||
|
||||
- No phase-specific personas. Both active personas span P1-P3.
|
||||
- P4 (final review + audit + ship) is lead-developer territory
|
||||
(orchestration + docs completion).
|
||||
### frontend-engineer (inactive)
|
||||
- **active:** false
|
||||
- **phase_specific:** false
|
||||
- **reason:** The pilot has no UI — the blockchain exchange is a
|
||||
backend service (matching engine + settlement). The consumer repo
|
||||
has no web/frontend. Reactivated if a future milestone adds a trading
|
||||
dashboard.
|
||||
|
||||
## Phase-Specific Notes
|
||||
|
||||
- **blockchain-engineer** is created for v1.26 P1 (blockchain core +
|
||||
order engine + settlement). If P2..P4 have no chain changes, the
|
||||
persona is removed after P1 (the chain is a stable substrate for the
|
||||
pilot run). If P2 (consumer-contract-and-deploy) requires chain
|
||||
adjustments, the persona stays through P2.
|
||||
- **policy-engineer** is active for P3 (pilot-metrics-and-policies) +
|
||||
may consult on P4 (pilot run policy verification).
|
||||
- **data-engineer** is active for P3 (DynamoDB primitive + outcome
|
||||
backfill + env-JSON) + P4 (regression CAP-025 may touch the registry).
|
||||
|
||||
## Territory Enforcement
|
||||
|
||||
- **Mode:** `warn` (the pilot is cross-territory by nature — the
|
||||
consumer repo + the platform repo share the milestone; the
|
||||
blockchain-engineer works in the consumer repo, backend/data/policy
|
||||
engineers work in the platform repo).
|
||||
- **Cross-territory collisions:** REQ-322 (DynamoDB primitive) is
|
||||
data-engineer territory, but the adapter test update
|
||||
(`tests/test_adapter.py` `EXPECTED_L1_KEYS`) is backend-engineer
|
||||
territory. The lead-developer resolves: data-engineer authors the
|
||||
module + registry; backend-engineer updates the test assertion
|
||||
(the test is backend territory, the module is data territory).
|
||||
+478
-148
@@ -1,180 +1,510 @@
|
||||
# PLAN — v1.24 (Consumer Guide Accuracy & Env-Promotion Lifecycle Enforcement)
|
||||
# PLAN — v1.26 (Live Pilot Estate Activation)
|
||||
|
||||
> Feature milestone (one `feat` phase: env-transition destroy enforcement;
|
||||
> the rest are `fix`/`docs`/`test`). Tags on the **v1.23.x** line:
|
||||
> v1.23.0 (P0) → v1.23.1 (P1) → v1.23.2 (P2) → v1.23.3 (P3) → v1.23.4 (P4
|
||||
> final = milestone release). 15 requirements (REQ-276..290), 4 phases +
|
||||
> P0 pre-execution.
|
||||
|
||||
## Phase breakdown
|
||||
|
||||
### Phase P1 — consumer-guide-fixes (Wave 1, lead-developer)
|
||||
|
||||
**Type:** `docs` + `fix` + `test` (consumer guide accuracy + guide test updates)
|
||||
|
||||
**Requirements:** REQ-276, REQ-277, REQ-278, REQ-279, REQ-280, REQ-281, REQ-290
|
||||
|
||||
**Must-haves:**
|
||||
- `docs/consumer-guide.md` Step 3 contract fields table corrected (REQ-276)
|
||||
- `docs/consumer-guide.md` Step 4 caller consistent with Step 2 (REQ-277)
|
||||
- `docs/consumer-guide.md` Step 5 stage 8 "(dev only)" → "(autonomous in dev; higher environments apply after HITL attestation)" (REQ-278)
|
||||
- `docs/consumer-guide.md` Step 8 rewritten with destroy-then-rebuild semantics + cross-ref to Shape B (REQ-279)
|
||||
- `docs/consumer-guide.md` Per-env section gains Shape B lead sentence (REQ-280)
|
||||
- `docs/consumer-guide.md` Reference table `@v1.19` wording corrected (REQ-281)
|
||||
- `tests/test_consumer_guide_per_env_section.py` updated: rename `test_consumer_guide_states_no_field_editing` → `test_consumer_guide_documents_both_promotion_shapes`; add `test_consumer_guide_documents_destroy_on_env_change` (REQ-290)
|
||||
|
||||
**Vertical slice:** A reader of `docs/consumer-guide.md` can promote via
|
||||
either shape (A: edit environment + platform destroys prior; B: per-env
|
||||
caller workflow) without contradiction. The guide's field table, caller
|
||||
examples, and stage descriptions match the actual schema and platform
|
||||
behavior. All consumer-guide tests pass.
|
||||
|
||||
**Files touched:**
|
||||
- `docs/consumer-guide.md`
|
||||
- `tests/test_consumer_guide_per_env_section.py`
|
||||
|
||||
**Verification:** `pytest tests/test_consumer_guide_per_env_section.py -v`
|
||||
(all 7 tests pass). Manual read of `docs/consumer-guide.md` end-to-end
|
||||
for internal consistency.
|
||||
> Feature milestone. Tags on the **v1.25.x** line: v1.25.0 (P0) →
|
||||
> v1.25.1 (P1) → v1.25.2 (P2) → v1.25.3 (P3) → v1.25.4 (P4) → v1.25.5
|
||||
> (P5 final = milestone release). 13 requirements (REQ-310..322),
|
||||
> 5 phases (P0 pre-execution + 4 execution + 1 final). Multi-project:
|
||||
> `acdl` (platform) + `nova-blockchain-exchange` (consumer). Tags run
|
||||
> on the previous minor's patch line per `run.md` versioning logic
|
||||
> (feature milestone — at least one feat phase; progressive patches per
|
||||
> phase; the final phase's patch IS the milestone release; no separate
|
||||
> minor tag).
|
||||
|
||||
---
|
||||
|
||||
### Phase P2 — env-transition-detect-and-destroy (Wave 2, backend-engineer)
|
||||
## Phase 0 — Pre-Execution (complete, tag v1.25.0)
|
||||
|
||||
**Type:** `feat` (new platform feature: env-transition detect-and-destroy)
|
||||
SPECIFY → CLARIFY → RESEARCH → IDEATE → PLAN → GRILL. All `.ciagent/`
|
||||
MD, research, plans. Ships as `v1.25.0` on the v1.25.x line.
|
||||
|
||||
**Requirements:** REQ-282, REQ-283, REQ-284, REQ-285, REQ-286, REQ-287
|
||||
**Pre-run (Workstream A, on main before branch gate):**
|
||||
- A1: flaky test fix (commit `8c68d68`, pushed).
|
||||
- A2: ACDL_*→NOVA_* bootstrap migration (commit `f844fea`, pushed).
|
||||
- A3: AWS bootstrap — S3 state bucket + DynamoDB outbox created.
|
||||
- A4: `nova-blockchain-exchange` Gitea repo created + cloned.
|
||||
|
||||
**Must-haves:**
|
||||
- `core/env_transition.py` new module: `detect_prior_env()` + `record_applied_env()` with boto3 DynamoDB queries (REQ-282, REQ-283)
|
||||
- `scripts/run_platform.sh` Step 0b: environment-transition check — detect prior env, re-resolve with `environment_override=prior_env` + `deletion_protection=false`, `terraform init -reconfigure` + `terraform destroy -auto-approve` against prior state key, emit `nova.env.destroyed` evidence event, fail closed on destroy failure (REQ-284)
|
||||
- `scripts/run_platform.sh` records applied env after successful apply (REQ-285)
|
||||
- `.github/workflows/deploy.yml` passes `NOVA_CONSUMER_REPO=${{ github.repository }}` to `run_platform.sh` (REQ-286)
|
||||
- `adapters/terraform/adapter.py` state-key block gains doc comment (REQ-287)
|
||||
|
||||
**Vertical slice:** When a consumer changes `environment:` on a stable
|
||||
`contract.id`, the pipeline detects the prior env from DynamoDB, destroys
|
||||
the prior env's Terraform state (with `deletion_protection=false`), emits
|
||||
an evidence event, and only then applies the new env. If the destroy
|
||||
fails, the pipeline exits non-zero (no orphan path). If no prior env
|
||||
exists (first deploy or Shape B), the pipeline proceeds normally.
|
||||
|
||||
**Files touched:**
|
||||
- `core/env_transition.py` (NEW)
|
||||
- `scripts/run_platform.sh`
|
||||
- `.github/workflows/deploy.yml`
|
||||
- `adapters/terraform/adapter.py` (doc comment only)
|
||||
|
||||
**Verification:** `python3 -m py_compile core/env_transition.py`.
|
||||
`pytest tests/test_pipeline.py tests/test_deploy_workflow_env_input.py -v`
|
||||
(existing tests still pass). The new tests in P3 validate the behavior.
|
||||
|
||||
**Key implementation notes (from RESEARCH §5 pitfalls):**
|
||||
1. The destroy step must re-resolve with `environment_override=prior_env`
|
||||
so the emitted TF matches the prior env's resources.
|
||||
2. `terraform init -reconfigure` is required when switching state backends.
|
||||
3. `deletion_protection: false` must be injected (same as decommission
|
||||
Step 2 in `scripts/run_decommission.sh:34-37`) or `prevent_destroy`
|
||||
blocks the destroy.
|
||||
4. DynamoDB unreachable in local/CI → log warning + return `None`
|
||||
(conservative, no prior env assumed).
|
||||
5. The state key `spike/{id}/{env}/terraform.tfstate` stays as-is — the
|
||||
env segment is what lets the destroy target the prior env.
|
||||
**Phase 0 stages (on `phase/00-specify-clarify-research-plan`):**
|
||||
- SPECIFY: v1.26 established in config.json + PROJECT.md + ROADMAP.md +
|
||||
`.ciagent/nova-blockchain-exchange/{PROJECT,REQUIREMENTS,ROADMAP}.md`.
|
||||
- CLARIFY: 10 ambiguities resolved (D-200..D-213).
|
||||
- RESEARCH: PoA blockchain, deploy model, DynamoDB gap (REQ-322),
|
||||
metric grounding, persona assessment (5 personas).
|
||||
- IDEATE: 7 ideas accepted (I1..I7 → REQ-315..322), 3 deferred.
|
||||
- PLAN: this file.
|
||||
- GRILL: adversarial review (binding verdicts).
|
||||
|
||||
---
|
||||
|
||||
### Phase P3 — env-transition-tests (Wave 3, backend-engineer + lead-developer)
|
||||
## Phase 1 — blockchain-core (tag v1.25.1)
|
||||
|
||||
**Type:** `test` (new test coverage for env-transition + pipeline integration)
|
||||
**Goal:** The consumer repo has a working homegrown PoA blockchain +
|
||||
order-matching engine + settlement service. All unit tests pass in the
|
||||
consumer repo's own CI.
|
||||
|
||||
**Requirements:** REQ-288, REQ-289
|
||||
**Project:** `nova-blockchain-exchange` (consumer repo).
|
||||
**Branch:** `nova-blockchain-exchange/phase/01-blockchain-core`.
|
||||
**Persona:** blockchain-engineer (primary), lead-developer (coordination).
|
||||
|
||||
**Must-haves:**
|
||||
- `tests/test_env_transition.py` (NEW): `detect_prior_env` returns `None` when no record; returns prior env when record differs; returns `None` when record matches; `record_applied_env` writes record. Uses moto for DynamoDB (REQ-288)
|
||||
- `tests/test_run_platform_env_transition.py` (NEW): asserts `run_platform.sh` has Step 0b; calls `env_transition.py detect`; calls `terraform destroy` on prior env; fails closed on destroy failure; records applied env after success (REQ-289)
|
||||
### Wave 1 — chain core (REQ-310)
|
||||
- **Task 1.1** (blockchain-engineer): `chain/block.py` — Block dataclass
|
||||
(index, timestamp, prev_hash, transactions, nonce, hash).
|
||||
`compute_hash()` deterministic (SHA-256). Unit test: `test_block.py`.
|
||||
- **Task 1.2** (blockchain-engineer): `chain/ledger.py` — Ledger class:
|
||||
`append_block()`, `verify_chain()`, `get_block(index)`,
|
||||
`get_latest_block()`. Genesis block on init. Unit test: `test_ledger.py`.
|
||||
- **Task 1.3** (blockchain-engineer): `chain/validator.py` — PoA
|
||||
validator: single validator (config-driven), `propose_block(transactions)`
|
||||
→ Block, `commit_block(block)`. Unit test: `test_validator.py`.
|
||||
|
||||
**Vertical slice:** The env-transition detect-and-destroy behavior is
|
||||
fully covered by automated tests. The DynamoDB query logic is unit-tested
|
||||
with moto. The pipeline orchestration is tested via shell-text assertions
|
||||
(pattern from `tests/test_pipeline.py:79-95`).
|
||||
### Wave 2 — order engine + settlement (REQ-311, REQ-312) — parallel with Wave 1 tail
|
||||
- **Task 2.1** (blockchain-engineer): `engine/order.py` — Order
|
||||
dataclass (id, side, symbol, price, size, timestamp).
|
||||
- **Task 2.2** (blockchain-engineer): `engine/order_book.py` —
|
||||
OrderBook: `add_order(order)`, `match_orders()` → list of Match
|
||||
(price-time priority, partial fills). Unit test: `test_order_book.py`.
|
||||
- **Task 2.3** (blockchain-engineer): `settlement/service.py` —
|
||||
SettlementService: `settle(match)` → SettlementTransaction,
|
||||
`submit(ledger)`. Idempotent (re-settling a match is a no-op once
|
||||
final). Finality = block commit. Unit test: `test_settlement.py`.
|
||||
|
||||
**Files touched:**
|
||||
- `tests/test_env_transition.py` (NEW)
|
||||
- `tests/test_run_platform_env_transition.py` (NEW)
|
||||
### Wave 3 — consumer CI (cross-cutting)
|
||||
- **Task 3.1** (blockchain-engineer): `.github/workflows/ci.yml` +
|
||||
`.gitea/workflows/ci.yml` — lint + pytest on chain/engine/settlement.
|
||||
- **Task 3.2** (lead-developer): `nova-blockchain-exchange/README.md` —
|
||||
repo overview + dev setup.
|
||||
|
||||
**Verification:** `pytest tests/test_env_transition.py tests/test_run_platform_env_transition.py -v` (all new tests pass). Full suite: `pytest tests/ -k "env_transition or consumer_guide or pipeline or adapter or deploy_workflow" -v`.
|
||||
**Must-haves (verify before ship):**
|
||||
- `pytest tests/` in the consumer repo passes (chain integrity, hash
|
||||
determinism, genesis, append/verify, match priority, partial fills,
|
||||
settlement idempotency, finality check).
|
||||
- The chain is deterministic (replay produces the same hash chain).
|
||||
- The consumer CI workflow runs on push.
|
||||
|
||||
**Ship:** tag `v1.25.1`, merge `phase/01` → `milestone/v1.26-pilot-activation`,
|
||||
Gitea release (best-effort). Delete `phase/01`.
|
||||
|
||||
---
|
||||
|
||||
### Phase P4 — final-review-ship (Wave 4, lead-developer)
|
||||
## Phase 2 — consumer-contract-and-deploy (tag v1.25.2)
|
||||
|
||||
**Type:** `docs` (review + audit + milestone ship)
|
||||
**Goal:** The consumer repo declares its infrastructure via
|
||||
`contract.yaml` (validated against the platform's schema) + invokes the
|
||||
platform's `deploy.yml@v1.25` workflow. The contract references the
|
||||
`microservice` (ECS), `dynamodb`, + `s3` modules.
|
||||
|
||||
**Requirements:** (none new — milestone completion)
|
||||
**Project:** `nova-blockchain-exchange` (consumer repo) + `acdl`
|
||||
(platform repo — for the `deploy.yml@v1.25` ref + the `v1.25` floating
|
||||
tag).
|
||||
**Branch:** `nova-blockchain-exchange/phase/02-contract-and-deploy`.
|
||||
**Persona:** blockchain-engineer (contract authoring), data-engineer
|
||||
(registry/DynamoDB dependency check), lead-developer (deploy.yml ref).
|
||||
|
||||
**Must-haves:**
|
||||
- Multi-persona code review across P1-P3 changes (ci-code-reviewer)
|
||||
- Project health audit (ci-doc-verifier + ci-audit)
|
||||
- Milestone ship: tag v1.23.4 (final phase patch = milestone release), merge to main, Gitea release
|
||||
- Update REQUIREMENTS.md traceability (all REQ-276..290 → complete)
|
||||
- Update ROADMAP.md (v1.24 → complete)
|
||||
### Wave 1 — contract (REQ-313)
|
||||
- **Task 1.1** (blockchain-engineer): `contract.yaml` — id
|
||||
(`blkex`), name (`blockchain-exchange`), environment (dev),
|
||||
infrastructure block (microservice + dynamodb + s3).
|
||||
- **Task 1.2** (blockchain-engineer): `contracts/blockchain-exchange.dev.yml`,
|
||||
`.qa.yml`, `.prod.yml` — per-env variants.
|
||||
- **Task 1.3** (blockchain-engineer): `tests/test_contract_validates.py`
|
||||
— schema validation against the platform's
|
||||
`schemas/contract.schema.json`.
|
||||
|
||||
### Wave 2 — deploy invocation (REQ-314)
|
||||
- **Task 2.1** (blockchain-engineer): `.github/workflows/deploy.yml` —
|
||||
`uses: acdl/.github/workflows/deploy.yml@v1.25` with
|
||||
`with: { contract: contract.yaml, mode: full, environment: dev }`.
|
||||
- **Task 2.2** (blockchain-engineer): `.gitea/workflows/deploy.yml` —
|
||||
byte-identical mirror.
|
||||
- **Task 2.3** (blockchain-engineer): `tests/test_deploy_workflow_invocation.py`
|
||||
— asserts the `uses:` ref + inputs.
|
||||
|
||||
### Wave 3 — platform floating tag (cross-cutting)
|
||||
- **Task 3.1** (lead-developer, on `acdl` repo): verify the `v1.25`
|
||||
floating tag exists (created by `release.yml` on merge to main). If
|
||||
not, create it pointing at the `v1.25.0` tag (Phase 0 ship).
|
||||
|
||||
**Must-haves (verify before ship):**
|
||||
- `contract.yaml` validates against `schemas/contract.schema.json`.
|
||||
- The deploy workflow invocation asserts the correct `uses:` ref +
|
||||
inputs.
|
||||
- The `v1.25` floating tag resolves.
|
||||
|
||||
**Ship:** tag `v1.25.2`, merge `phase/02` → milestone, Gitea release.
|
||||
Delete `phase/02`.
|
||||
|
||||
---
|
||||
|
||||
## Wave ordering
|
||||
## Phase 3 — pilot-metrics-and-policies (tag v1.25.3)
|
||||
|
||||
```
|
||||
Wave 1 (P1): consumer-guide-fixes [lead-developer]
|
||||
↓
|
||||
Wave 2 (P2): env-transition-detect-and-destroy [backend-engineer]
|
||||
↓
|
||||
Wave 3 (P3): env-transition-tests [backend-engineer + lead-developer]
|
||||
↓
|
||||
Wave 4 (P4): final-review-ship [lead-developer]
|
||||
```
|
||||
**Goal:** The platform repo gains the metric-grounding emitters, the
|
||||
kyverno-json pilot policies, the DynamoDB L1 primitive, the env-JSON
|
||||
wiring reconciliation, + the pilot regression CAP. The Post-Pilot
|
||||
metrics are grounded (outcome backfill + escalation reason); the pilot-
|
||||
readiness + settlement-finality policies are in place.
|
||||
|
||||
**Dependencies:**
|
||||
- P2 depends on P1: the Step 8 rewrite in P1 documents the destroy
|
||||
semantics that P2 implements. Doing P1 first ensures the docs and code
|
||||
land in the right order (docs describe the intended behavior, then code
|
||||
implements it).
|
||||
- P3 depends on P2: the tests validate the env-transition module and
|
||||
pipeline Step 0b that P2 creates.
|
||||
- P4 depends on P1+P2+P3: the final review covers all changes.
|
||||
**Project:** `acdl` (platform repo) + `nova-blockchain-exchange`
|
||||
(consumer repo — the Gitea adapter rewrites the consumer's `deploy.yml`).
|
||||
**Branch:** `acdl/phase/03-pilot-metrics-and-policies` (platform branch).
|
||||
**Personas:** backend-engineer (emitters + adapter + regression),
|
||||
data-engineer (DynamoDB primitive + env JSON + collector),
|
||||
policy-engineer (kyverno-json policies), lead-developer (Gitea adapter
|
||||
+ deploy.yml drift + rotation workflow).
|
||||
|
||||
**Parallelization:** P1 and P2 could run in parallel (different
|
||||
territories: docs vs code), but the wave ordering is sequential for
|
||||
safety — if P1's Step 8 rewrite reveals a design issue, P2's
|
||||
implementation should follow the corrected design. With
|
||||
`parallelization.enabled=true` and `min_plans_for_parallel=2`, the
|
||||
orchestrator *could* run them concurrently; however, the dependency
|
||||
(P2 follows P1's design) makes sequential the safer choice. P3 must
|
||||
follow P2 (tests validate the code). P4 must follow all.
|
||||
### Wave 0 — Gitea reusable-workflow adapter (SPEC §10 Q1, resolved by evidence) — lead-developer + blockchain-engineer
|
||||
> **Highest-priority gap.** The v0.2 P3 `workflow_dispatch` (Gitea
|
||||
> Actions run id=6199) failed: Gitea Actions rejects cross-repo `uses:`
|
||||
> (`acdl/.github/workflows/deploy.yml@v1.25`) with `expected format
|
||||
> {owner}/{repo}/.{git_platform}/workflows/{filename}@{ref}`. The
|
||||
> consumer's `deploy.yml` is frozen at the v0.1 byte-identical mirror;
|
||||
> the platform adapts (option c — inline checkout-then-call), not
|
||||
> vice-versa.
|
||||
- **Task 0.1** (lead-developer): rewrite
|
||||
`nova-blockchain-exchange/.gitea/workflows/deploy.yml` + byte-identical
|
||||
`.github/workflows/deploy.yml` — drop the `uses:` indirection; single
|
||||
`deploy` job on `ubuntu-latest` that `actions/checkout@v4` the consumer,
|
||||
`actions/checkout@v4` `acdl/acdl` @ `ref: v1.25` into `platform/`,
|
||||
setup-python 3.12, install deps (jsonschema/pyyaml/boto3 + checkov),
|
||||
install Terraform 1.9.*, configure AWS (static-key path:
|
||||
`aws-region: ${{ secrets.AWS_DEFAULT_REGION }}`, `access-key-id` +
|
||||
`secret-access-key` from `NOVA_AWS_*` secrets; no OIDC token minted),
|
||||
run `bash platform/scripts/run_platform.sh $MODE_FLAG $ENV_FLAG
|
||||
contract.yaml`. Preserve `on: workflow_dispatch` inputs (mode choice
|
||||
default full; environment choice default "") + `permissions: {id-token:
|
||||
write, contents: read}` + `secrets: inherit`.
|
||||
- **Task 0.2** (blockchain-engineer): update
|
||||
`nova-blockchain-exchange/tests/test_deploy_workflow_invocation.py` +
|
||||
`test_deploy_gitea_invocation.py` — assert no cross-repo `uses:`,
|
||||
assert `ref: v1.25`, assert `secrets: inherit`, assert
|
||||
`run_platform.sh` invoked, assert `AWS_DEFAULT_REGION` wired.
|
||||
- **Task 0.3** (lead-developer): `acdl/.github/workflows/deploy.yml`
|
||||
stays as the GitHub Actions reference impl (the `workflow_call`
|
||||
reusable workflow — used by GitHub-hosted consumers); document in
|
||||
`adapters/README.md` that Gitea consumers use the inline adapter, not
|
||||
the reusable `uses:`.
|
||||
|
||||
## Requirement → Phase mapping
|
||||
### Wave 0.5 — kyverno-json substrate fix (v1.25 skip-masked bug) — backend-engineer
|
||||
> The v1.25 kyverno-json engine + policies were never validated
|
||||
> against the real `kj` binary (tests `pytest.skip("kj not installed")`
|
||||
> when absent). With `kj` now installed (v0.0.3), 3 policy tests
|
||||
> failed. Root cause: (a) `kj` v0.0.3 does not load `.json` policy
|
||||
> files (only `.yaml`/`.yml`) — the engine now materializes `.yaml`
|
||||
> twins at runtime; (b) the `validate` wrapper is not supported —
|
||||
> `assert` goes directly under the rule; (c) the check syntax was
|
||||
> inverted (`expression: expected_value`, not `key: expression`);
|
||||
> (d) the engine `_translate` expected `{"results": [...]}` but `kj`
|
||||
> returns a bare list with `results[].policy.metadata.name` +
|
||||
> `results[].rules[].violations[]`. DONE (committed 59d837f). Also
|
||||
> fixed `scripts/install-kyverno-json.sh` (the `cmd/kj@latest` path
|
||||
> fails — the real binary is `kyverno-json`, symlinked as `kj`).
|
||||
- **Task 0.5.1** (backend-engineer): rewrite
|
||||
`adapters/kyverno-json/kyverno_json_engine.py` `_translate` for the
|
||||
bare-list output format + add `_materialize_yaml_policy_dir` (DONE).
|
||||
- **Task 0.5.2** (backend-engineer): remove the `validate` wrapper +
|
||||
fix check syntax across all 16 existing policies (DONE).
|
||||
- **Task 0.5.3** (backend-engineer): fix
|
||||
`scripts/install-kyverno-json.sh` (DONE).
|
||||
- **Task 0.5.4** (backend-engineer): resolve pre-existing P2 drift
|
||||
uncovered by the full-suite run — dynamodb `examples/simple.yml` +
|
||||
`complex.yml`, `sync_workflows` re-sync, CAP-024 deck path
|
||||
(`nova-autonomous-cloud-delivery-marp.md`) + slide-count bound +
|
||||
`class="benefit"` div count (DONE, committed 3735330).
|
||||
|
||||
| REQ | Phase | Type | Description |
|
||||
|-----|-------|------|-------------|
|
||||
| REQ-276 | P1 | docs | Contract fields table corrected |
|
||||
| REQ-277 | P1 | docs | Step 4 caller consistent with Step 2 |
|
||||
| REQ-278 | P1 | docs | Step 5 stage 8 "dev only" corrected |
|
||||
| REQ-279 | P1 | docs | Step 8 rewritten with destroy semantics |
|
||||
| REQ-280 | P1 | docs | Per-env section Shape B lead sentence |
|
||||
| REQ-281 | P1 | docs | Reference table @v1.19 wording corrected |
|
||||
| REQ-282 | P2 | feat | env_transition.py detect_prior_env() |
|
||||
| REQ-283 | P2 | feat | env_transition.py record_applied_env() |
|
||||
| REQ-284 | P2 | feat | run_platform.sh Step 0b detect-and-destroy |
|
||||
| REQ-285 | P2 | feat | run_platform.sh records applied env |
|
||||
| REQ-286 | P2 | feat | deploy.yml passes NOVA_CONSUMER_REPO |
|
||||
| REQ-287 | P2 | docs | adapter.py state-key doc comment |
|
||||
| REQ-288 | P3 | test | test_env_transition.py |
|
||||
| REQ-289 | P3 | test | test_run_platform_env_transition.py |
|
||||
| REQ-290 | P1 | test | consumer guide test updates |
|
||||
### Wave 1 — DynamoDB primitive (REQ-322) — data-engineer — verify-only (done in P2 W0)
|
||||
- **Task 1.1** (data-engineer): verify `modules/l1/dynamodb/` resolves
|
||||
+ emits valid Terraform via `tests/test_adapter.py` (the primitive
|
||||
shipped in P2 W0; this wave is a re-verify, not re-authoring).
|
||||
|
||||
## Tag plan
|
||||
### Wave 2 — metric grounding (REQ-317, REQ-318) — backend-engineer + data-engineer — parallel
|
||||
- **Task 2.1** (backend-engineer): `core/metrics/outcome_backfill.py` —
|
||||
`backfill(decision_id, outcome)` updates `fact_decision.outcome` +
|
||||
`backfilled_at`. Reads run-manifest events.
|
||||
- **Task 2.2** (backend-engineer): `core/metrics/collector.py` —
|
||||
invokes backfill after run completion.
|
||||
- **Task 2.3** (backend-engineer): `tests/test_outcome_backfill.py`.
|
||||
- **Task 2.4** (backend-engineer): `core/confidence_signal.py` —
|
||||
`ai.decision.made` gains `escalation_reason: 'confidence'` when
|
||||
`band == 'block'`.
|
||||
- **Task 2.5** (backend-engineer): `core/metrics/collector.py` —
|
||||
persists `escalation_reason` into `fact_run`.
|
||||
- **Task 2.6** (backend-engineer): `tests/test_confidence_escalation_reason.py`.
|
||||
|
||||
- P0 (this phase): `v1.23.0` — pre-execution patch
|
||||
- P1: `v1.23.1` — consumer guide fixes
|
||||
- P2: `v1.23.2` — env-transition detect-and-destroy
|
||||
- P3: `v1.23.3` — env-transition tests
|
||||
- P4: `v1.23.4` — final review + ship = **milestone release**
|
||||
### Wave 3 — env-JSON wiring + adapter (REQ-319) — backend-engineer + data-engineer — parallel
|
||||
- **Task 3.1** (backend-engineer): `adapters/terraform/adapter.py` —
|
||||
reads `env.state_backend.bucket` when present (fallback to computed
|
||||
name for backwards compat).
|
||||
- **Task 3.2** (data-engineer): `core/environments/dev.json` —
|
||||
`account_id` → `581513795199`, `state_backend.bucket` →
|
||||
`nova-tfstate-581513795199-us-east-1`.
|
||||
- **Task 3.3** (data-engineer): `core/environments/{qa,prod,dr}.json` —
|
||||
`state_backend.bucket` updated; `account_id` stays placeholder
|
||||
(pilot-readiness policy blocks apply on placeholder, D-208).
|
||||
- **Task 3.4** (backend-engineer): `tests/test_adapter_state_backend.py`.
|
||||
- **Task 3.5** (backend-engineer): `tests/test_adapter.py` — add
|
||||
`dynamodb` to `EXPECTED_L1_KEYS` + a resolution + emission test
|
||||
(cross-territory: data-engineer authored the module, backend-engineer
|
||||
owns the test).
|
||||
|
||||
### Wave 4 — kyverno-json policies (REQ-315, REQ-320) — policy-engineer — parallel
|
||||
- **Task 4.1** (policy-engineer):
|
||||
`adapters/kyverno-json/policies/settlement-finality/all-matches-committed.json`
|
||||
— kyverno-json policy over settlement-service status JSON (asserts
|
||||
`all_committed: true`). **Note (G-Q6):** the policy is authored +
|
||||
tested in v1.26; *enforcement* is deferred to the milestone that
|
||||
binds qa/prod/dr (D-208 — the policy gates promotions, not dev
|
||||
applies).
|
||||
- **Task 4.2** (policy-engineer):
|
||||
`adapters/kyverno-json/policies/pilot-readiness/no-placeholder-account.json`
|
||||
— kyverno-json policy over env JSON (asserts
|
||||
`account_id != "000000000000"`).
|
||||
- **Task 4.3** (policy-engineer): `tests/test_settlement_finality_policy.py`
|
||||
— passing + failing fixtures; **runs against real `kj`** (not skipped
|
||||
— `kj` is installed via `scripts/install-kyverno-json.sh`).
|
||||
- **Task 4.4** (policy-engineer): `tests/test_pilot_readiness_policy.py`
|
||||
— passing (real account) + failing (placeholder) fixtures; **runs
|
||||
against real `kj`** (not skipped).
|
||||
|
||||
### Wave 5 — regression CAP (REQ-316) — backend-engineer
|
||||
- **Task 5.1** (backend-engineer): `core/regression_verify.py` —
|
||||
CAP-025 (live-pilot-apply): the round-trip assertion.
|
||||
- **Task 5.2** (backend-engineer): `tests/test_regression_pilot.py`.
|
||||
|
||||
### Wave 6 — deploy.yml drift fixes (SPEC §5.1/§5.2) — lead-developer + backend-engineer
|
||||
> The platform reference `workflows-src/deploy.yml` (synced to
|
||||
> `.github`+`.gitea`) has three drifts vs the SPEC: (a) `aws-region`
|
||||
> hardcoded `us-east-1` (SPEC wants `NOVA_AWS_REGION`/`AWS_DEFAULT_REGION`
|
||||
> from secret); (b) platform checkout `ref: v1.9` (SPEC wants `v1.25`);
|
||||
> (c) the local `scripts/run_platform.sh` fallback exports raw
|
||||
> `NOVA_AWS_*` names into shell env (SPEC §5.2 constraint: consume as
|
||||
> workflow secrets, not shell env — `blocked_env_vars`).
|
||||
- **Task 6.1** (lead-developer): `workflows-src/deploy.yml` —
|
||||
`aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}`;
|
||||
platform checkout `ref: v1.25`; re-sync to `.github`+`.gitea`.
|
||||
- **Task 6.2** (backend-engineer): `scripts/run_platform.sh` — source
|
||||
`AWS_DEFAULT_REGION` from `.env.secrets` for the local fallback (not
|
||||
raw `NOVA_AWS_*`); the CI path already consumes secrets via the
|
||||
`configure-aws-credentials` action.
|
||||
- **Task 6.3** (backend-engineer): `tests/test_deploy_workflow_env_input.py`
|
||||
— assert `AWS_DEFAULT_REGION` wired + `ref: v1.25` + no raw
|
||||
`NOVA_AWS_*` in shell env.
|
||||
|
||||
### Wave 7 — secret rotation scheduled workflow (SPEC §5.9) — lead-developer
|
||||
> SPEC §5.9: "the rotation mechanism must *exist* (not have run)."
|
||||
> A platform-managed scheduled workflow wraps the existing
|
||||
> `scripts/rotate_spike_key.sh` (manual today) on a daily cron.
|
||||
- **Task 7.1** (lead-developer): `workflows-src/rotate-aws-key.yml` —
|
||||
`on: { schedule: [{cron: "0 0 * * *"}], workflow_dispatch:}`,
|
||||
single job that checks out the platform repo + runs
|
||||
`bash scripts/rotate_spike_key.sh` with `NOVA_AWS_*` bootstrap
|
||||
secrets; sync to `.github`+`.gitea`.
|
||||
- **Task 7.2** (lead-developer): verify `scripts/rotate_spike_key.sh`
|
||||
is idempotent (deactivates old key only after the new key propagates
|
||||
to the Gitea Actions secret store).
|
||||
- **Task 7.3** (lead-developer): `tests/test_rotate_key_workflow.py` —
|
||||
structural test (the workflow file declares `schedule` + invokes
|
||||
`rotate_spike_key.sh`); document in `.ciagent/ARCHITECTURE.md` §12.8
|
||||
that the mechanism exists (v0.2 scope: exists-not-ran per SPEC §5.9).
|
||||
|
||||
**Must-haves (verify before ship):**
|
||||
- `pytest tests/` in the platform repo passes (the 170 baseline held
|
||||
inaccurately — the real P2 baseline had 7 pre-existing failures
|
||||
uncovered by W0.5; all now fixed). Full suite green.
|
||||
- `pytest tests/` in the consumer repo passes (deploy invocation tests
|
||||
updated for the inline adapter).
|
||||
- The kyverno-json substrate works against real `kj` (W0.5 — DONE).
|
||||
- The Gitea adapter: consumer `deploy.yml` has no cross-repo `uses:`;
|
||||
inline checkout `acdl@v1.25` + `run_platform.sh` (W0).
|
||||
- The DynamoDB primitive resolves + emits valid Terraform (W1 verify).
|
||||
- The outcome backfill updates `fact_decision.outcome` (not `pending`)
|
||||
(W2).
|
||||
- The `escalation_reason` field is emitted on `block` band (W2).
|
||||
- The adapter reads `env.state_backend.bucket` from the env JSON (W3).
|
||||
- The 2 new kyverno-json policies pass on valid fixtures + fail on
|
||||
invalid fixtures, against real `kj` (W4 — not skipped).
|
||||
- CAP-025 is in the regression gate (W5).
|
||||
- The deploy.yml drifts fixed: `AWS_DEFAULT_REGION` wired, `ref:
|
||||
v1.25`, no raw `NOVA_AWS_*` in shell env (W6).
|
||||
- The rotation scheduled workflow exists (W7).
|
||||
|
||||
**Ship:** tag `v1.25.3`, merge `phase/03` → milestone, Gitea release.
|
||||
Delete `phase/03`.
|
||||
|
||||
---
|
||||
|
||||
## Phase 4 — pilot-run-and-docs (tag v1.25.4)
|
||||
|
||||
**Goal:** The pilot estate runs end-to-end against live AWS
|
||||
`581513795199` (contract resolve → adapter compile → terraform plan →
|
||||
policy scan → confidence signal → attestation → outbox record). Docs +
|
||||
adapter README + onboarding guide are complete.
|
||||
|
||||
**Project:** `nova-blockchain-exchange` (consumer repo — the run) +
|
||||
`acdl` (platform repo — docs).
|
||||
**Branch:** `acdl/phase/04-pilot-run-and-docs` (platform branch for
|
||||
docs); the run happens via the consumer's `deploy.yml` invocation.
|
||||
**Personas:** blockchain-engineer (the run), lead-developer (docs),
|
||||
backend-engineer (regression CAP-025 verification).
|
||||
|
||||
### Wave 1 — the pilot run (REQ-316 verification, live)
|
||||
- **Task 1.1** (blockchain-engineer): trigger the consumer's
|
||||
`deploy.yml` with `mode: full, environment: dev` against
|
||||
`581513795199`. The workflow checks out the consumer + platform
|
||||
repos, runs `run_platform.sh`, applies the contract (ECS +
|
||||
DynamoDB + S3), records the decision + attestation.
|
||||
- **Task 1.2** (backend-engineer): verify CAP-025 (regression gate)
|
||||
passes against the live run.
|
||||
- **Task 1.3** (blockchain-engineer): capture the run's
|
||||
`ai.decision.made` + `attestation.recorded` events from the Decision
|
||||
Ledger → evidence for the milestone ship.
|
||||
|
||||
### Wave 2 — docs (REQ-321)
|
||||
- **Task 2.1** (lead-developer): `adapters/README.md` — new consumer
|
||||
row + fix the stale `TYPE_MAP` references (IDEATE I8).
|
||||
- **Task 2.2** (lead-developer): `docs/METRICS.md` — Post-Pilot metrics
|
||||
grounded note (the 3 targets now have non-zero denominators post-run).
|
||||
- **Task 2.3** (lead-developer): `.ciagent/ARCHITECTURE.md` §12.8
|
||||
(Pilot Estate).
|
||||
- **Task 2.4** (lead-developer):
|
||||
`.ciagent/nova-blockchain-exchange/README.md` — consumer onboarding
|
||||
guide (how to invoke `deploy.yml@v1.25`, what secrets to set, what
|
||||
the contract shape is).
|
||||
|
||||
**Must-haves (verify before ship):**
|
||||
- The pilot run completes end-to-end (apply succeeds, decision recorded,
|
||||
attestation recorded for dev — autonomous, no human approver).
|
||||
- CAP-025 passes.
|
||||
- The 3 Post-Pilot metrics have non-zero denominators (the run
|
||||
contributed to `fact_run` + `fact_decision`).
|
||||
- Docs are complete (adapter README, METRICS.md, ARCHITECTURE.md §12.8,
|
||||
consumer onboarding guide).
|
||||
|
||||
**Ship:** tag `v1.25.4`, merge `phase/04` → milestone, Gitea release.
|
||||
Delete `phase/04`.
|
||||
|
||||
---
|
||||
|
||||
## Phase 5 — final review + audit + milestone ship (tag v1.25.5)
|
||||
|
||||
**Goal:** Multi-persona code review across P1..P4. Audit (reconstruction
|
||||
test, branch hygiene, commit discipline). Milestone ship: merge to main,
|
||||
tag `v1.25.5` (= the v1.26 release), Gitea release with full milestone
|
||||
summary, delete all milestone branches.
|
||||
|
||||
**Project:** both (`acdl` + `nova-blockchain-exchange`).
|
||||
**Branch:** `phase/05-final-review-ship`.
|
||||
**Personas:** lead-developer (review + audit + ship), backend-engineer
|
||||
(review), data-engineer (review), policy-engineer (review),
|
||||
blockchain-engineer (review — the chain core is reviewed).
|
||||
|
||||
### Wave 1 — review
|
||||
- **Task 1.1** (lead-developer): `ciagent-review` — multi-persona code
|
||||
review across P1..P4. Auto-fix P0; flag P1+ for post-hoc review.
|
||||
- **Task 1.2** (all personas): fix P0 issues in this phase.
|
||||
|
||||
### Wave 2 — audit
|
||||
- **Task 2.1** (lead-developer): `ciagent-audit` — reconstruction test
|
||||
(git log ↔ `.ciagent/`), branch hygiene, commit discipline.
|
||||
- **Task 2.2** (lead-developer): fix critical audit issues in this phase.
|
||||
|
||||
### Wave 3 — milestone ship
|
||||
- **Task 3.1** (lead-developer): merge `phase/05` →
|
||||
`milestone/v1.26-pilot-activation` → `main`.
|
||||
- **Task 3.2** (lead-developer): tag `v1.25.5` (= the v1.26 release per
|
||||
prev-minor tagging rule).
|
||||
- **Task 3.3** (lead-developer): create Gitea release with full milestone
|
||||
summary (all phases, all 13 requirements).
|
||||
- **Task 3.4** (lead-developer): delete all milestone branches (local +
|
||||
remote). Tags preserve all history.
|
||||
- **Task 3.5** (lead-developer): update `.ciagent/nova-blockchain-exchange/REQUIREMENTS.md`
|
||||
(mark REQ-310..322 complete), `.ciagent/ROADMAP.md` (mark v1.26
|
||||
complete), `.ciagent/NORTH_STAR.md` (note Strategic Objectives #1 +
|
||||
#3 — first real consumer estate; Post-Pilot denominators activated).
|
||||
- **Task 3.6** (lead-developer): write checkpoint `stage: complete,
|
||||
phase: 5, phase_role: final` + clear checkpoint (milestone complete).
|
||||
|
||||
**Must-haves (verify before ship):**
|
||||
- Review: 0 P0 issues unfixed; P1+ flagged for post-hoc.
|
||||
- Audit: reconstruction test passes; branch hygiene clean; commit
|
||||
discipline clean.
|
||||
- Ship: `v1.25.5` tag exists; Gitea release created; milestone branches
|
||||
deleted; main has the milestone merge.
|
||||
|
||||
---
|
||||
|
||||
## Requirement → Phase Mapping
|
||||
|
||||
| REQ | Phase | Wave | Persona |
|
||||
|---|---|---|---|
|
||||
| REQ-310 (blockchain core) | P1 | W1 | blockchain-engineer |
|
||||
| REQ-311 (order engine) | P1 | W2 | blockchain-engineer |
|
||||
| REQ-312 (settlement) | P1 | W2 | blockchain-engineer |
|
||||
| REQ-313 (contract.yaml) | P2 | W1 | blockchain-engineer |
|
||||
| REQ-314 (deploy invocation) | P2 | W2 | blockchain-engineer |
|
||||
| REQ-315 (settlement-finality policy) | P3 | W4 | policy-engineer |
|
||||
| REQ-316 (pilot regression CAP) | P3 | W5 + P4 W1 | backend-engineer |
|
||||
| REQ-317 (outcome backfill) | P3 | W2 | backend-engineer |
|
||||
| REQ-318 (escalation reason) | P3 | W2 | backend-engineer |
|
||||
| REQ-319 (env-JSON wiring) | P3 | W3 | backend + data-engineer |
|
||||
| REQ-320 (pilot-readiness policy) | P3 | W4 | policy-engineer |
|
||||
| REQ-321 (docs) | P4 | W2 | lead-developer |
|
||||
| REQ-322 (DynamoDB primitive) | P3 | W1 | data-engineer |
|
||||
|
||||
---
|
||||
|
||||
## Wave Ordering Rationale
|
||||
|
||||
- **P1 W1 → W2:** the chain core (block + ledger + validator) must land
|
||||
before the order engine + settlement (they submit transactions to the
|
||||
ledger). W3 (CI) is cross-cutting + can land any time after W1.
|
||||
- **P2 W1 → W2:** the contract must land before the deploy invocation
|
||||
(the invocation references the contract). W3 (floating tag) is cross-
|
||||
cutting.
|
||||
- **P3 W1 (DynamoDB) first:** the contract (P2) references `dynamodb` —
|
||||
the primitive must exist before P2's contract can resolve. **Risk:**
|
||||
P2's contract references a module that doesn't exist until P3. Resolution: P2's contract is authored but the `test_contract_validates.py` test only checks schema validity (not registry resolution) — the registry resolution test is in P3 (after the primitive lands). The contract's `dynamodb` block is schema-valid (the schema is open); the registry resolution happens at apply time (P4).
|
||||
- **Alternative:** move REQ-322 to P2 W0 (before the contract). This
|
||||
avoids the P2→P3 dependency. **Decision: move REQ-322 to P2 W0.**
|
||||
See revised mapping below.
|
||||
|
||||
### Revised: REQ-322 → P2 W0
|
||||
|
||||
REQ-322 (DynamoDB primitive) lands in P2 Wave 0 (before the contract)
|
||||
so the contract's `dynamodb` block resolves at registry time, not just
|
||||
schema time. This makes P2 self-contained: the primitive + the contract
|
||||
+ the deploy invocation all land in P2.
|
||||
|
||||
| REQ | Phase | Wave | Persona |
|
||||
|---|---|---|---|
|
||||
| REQ-310 (blockchain core) | P1 | W1 | blockchain-engineer |
|
||||
| REQ-311 (order engine) | P1 | W2 | blockchain-engineer |
|
||||
| REQ-312 (settlement) | P1 | W2 | blockchain-engineer |
|
||||
| REQ-322 (DynamoDB primitive) | P2 | W0 | data-engineer |
|
||||
| REQ-313 (contract.yaml) | P2 | W1 | blockchain-engineer |
|
||||
| REQ-314 (deploy invocation) | P2 | W2 | blockchain-engineer |
|
||||
| REQ-315 (settlement-finality policy) | P3 | W4 | policy-engineer |
|
||||
| REQ-316 (pilot regression CAP) | P3 | W5 + P4 W1 | backend-engineer |
|
||||
| REQ-317 (outcome backfill) | P3 | W2 | backend-engineer |
|
||||
| REQ-318 (escalation reason) | P3 | W2 | backend-engineer |
|
||||
| REQ-319 (env-JSON wiring) | P3 | W3 | backend + data-engineer |
|
||||
| REQ-320 (pilot-readiness policy) | P3 | W4 | policy-engineer |
|
||||
| REQ-321 (docs) | P4 | W2 | lead-developer |
|
||||
|
||||
This revision is a binding plan decision (G-Q8 in the grill may
|
||||
challenge it).
|
||||
|
||||
---
|
||||
|
||||
## Future Hardening Items (not in v1.26 scope, documented per grill G-Q9)
|
||||
|
||||
- **`NOVA_AWS_*` key-split:** v1.26 uses a single `NOVA_AWS_*` key with
|
||||
root-equivalent permissions (D-207, confirmed empirically by the
|
||||
bootstrap). A future hardening milestone should split this into a
|
||||
`NOVA_BOOTSTRAP_AWS_*` root key (bootstrap only) + a least-privilege
|
||||
`NOVA_AWS_*` runner key (the spike-runner pattern). The pilot scope
|
||||
(single account, no production workloads, OIDC default) bounds the
|
||||
risk.
|
||||
- **Multi-account landing zone:** qa/prod/dr on separate accounts (D-208
|
||||
keeps them placeholder in v1.26).
|
||||
- **D-083 lift:** S3 Object Lock + JWS tamper-evident ledger (when the
|
||||
pilot becomes a production system, D-204).
|
||||
- **Multi-validator BFT consensus:** D-201.
|
||||
- **Other security types:** bonds (T+2), derivatives, options (D-200).
|
||||
+238
-1383
File diff suppressed because it is too large
Load Diff
+290
-2186
File diff suppressed because it is too large
Load Diff
+215
-152
@@ -1,187 +1,250 @@
|
||||
# Nova — v1.24 Research Findings
|
||||
# Nova — v1.26 Research Findings
|
||||
|
||||
> Phase: research (pre-execution). Milestone: v1.24 (Consumer Guide Accuracy
|
||||
> & Env-Promotion Lifecycle Enforcement). Status: research.
|
||||
> Researcher: ci-researcher. Autonomy: full.
|
||||
> Phase: research (pre-execution). Milestone: v1.26 (Live Pilot Estate
|
||||
> Activation). Status: research. Researcher: ci-researcher.
|
||||
> Autonomy: full.
|
||||
|
||||
## 1. Problem domain
|
||||
---
|
||||
|
||||
Two distinct problem spaces in one milestone:
|
||||
## 1. Domain — Homegrown PoA Blockchain for Securities Settlement
|
||||
|
||||
### 1a. Consumer guide accuracy (docs)
|
||||
### 1.1 Why a homegrown chain (not Ethereum/Solana/Hyperledger)
|
||||
|
||||
The consumer guide (`docs/consumer-guide.md`, 477 lines) has 5 accuracy
|
||||
defects identified in review:
|
||||
The pilot's purpose is to exercise the Nova platform's deploy/policy/
|
||||
attestation gates over a real consumer estate — not to build a
|
||||
production blockchain. A homegrown PoA ledger is the minimal viable
|
||||
chain: append-only blocks, single validator (pilot), SHA-256 hash chain,
|
||||
deterministic block production. It records every order, match, and
|
||||
settlement as transactions; settlement finality = block commit. This
|
||||
is sufficient to demonstrate that Nova's policy engine (kyverno-json)
|
||||
can assert settlement finality declaratively (REQ-315) and that the
|
||||
Decision Ledger captures the apply decision.
|
||||
|
||||
1. **Step 3 contract fields table (lines 141-147)** lists `uses`, `module`,
|
||||
`environment`, `inputs`. The actual schema
|
||||
(`schemas/contract.schema.json:7`) requires `id`, `name`, `environment`,
|
||||
`infrastructure`. The `uses` field was dropped in v1.10.2 (REQ-50
|
||||
superseded) and `module` was replaced by the `infrastructure` map key.
|
||||
The worked examples (lines 111-137) use the correct fields.
|
||||
A production chain (Ethereum/Solana/Hyperledger) would be the *consumer
|
||||
app's* choice, not the platform's. The platform is chain-agnostic — it
|
||||
deploys whatever the consumer's `contract.yaml` declares. For the pilot,
|
||||
the homegrown chain is the simplest way to produce a real consumer
|
||||
estate without a heavyweight external dependency.
|
||||
|
||||
2. **Step 4 caller (lines 173-183)** omits `environment:` in `with:`, while
|
||||
Step 2 (lines 94-101) shows `environment: dev`. The two canonical caller
|
||||
snippets disagree.
|
||||
### 1.2 PoA consensus — single validator (pilot)
|
||||
|
||||
3. **Step 5 stage 8 (lines 232, 253)** says "(dev only)" for the apply
|
||||
stage. Higher environments *do* apply — they apply after HITL
|
||||
attestation per `docs/environments/index.md:44-54`.
|
||||
Proof-of-Authority with a single validator is the minimal consensus
|
||||
model: the validator proposes + commits blocks. No Byzantine fault
|
||||
tolerance (single validator = no forks). Deterministic block
|
||||
production: same ordered transactions → same block (same hash). This
|
||||
makes the chain auditable (the hash chain is verifiable) and
|
||||
reproducible (a replay produces the same chain). Multi-validator BFT
|
||||
is a future milestone (D-201).
|
||||
|
||||
4. **Step 8 (lines 290-306)** says "Change `environment` in your contract"
|
||||
to promote, which contradicts the same doc's "Per-environment
|
||||
deployment" section (lines 398-402): "you do not edit the `environment:`
|
||||
field… Promotion = running the matching job." The test
|
||||
`test_consumer_guide_states_no_field_editing` asserts the no-editing
|
||||
model.
|
||||
### 1.3 T+1 settlement finality
|
||||
|
||||
5. **Reference table (lines 329-330)** says sample contracts "use `@v1.19`"
|
||||
but the sample contracts (`contracts/static-assets.yml`,
|
||||
`contracts/microservice.yml`) don't carry `uses:` — the version pin
|
||||
lives in the caller workflow.
|
||||
Equities settle T+1 (trade date + 1 business day). The pilot's
|
||||
settlement service records matches as transactions on the chain; a
|
||||
settlement is final when its block is committed. The settlement-finality
|
||||
kyverno-json policy (REQ-315) asserts `all_committed: true` before any
|
||||
promotion (qa→prod) — the declarative gate that turns settlement
|
||||
finality into a policy artifact. This is the securities-specific
|
||||
extension of v1.25's policy engine: the same `KyvernoJsonEngine`
|
||||
evaluates a policy over a new payload shape (settlement-service status
|
||||
JSON).
|
||||
|
||||
### 1b. Environment-promotion lifecycle enforcement (feat)
|
||||
### 1.4 Equities-only scope (D-200)
|
||||
|
||||
**Root cause confirmed by code inspection:**
|
||||
Bonds (T+2), derivatives (varying), and options (exercise models) have
|
||||
different settlement models. A pilot should demonstrate the Nova
|
||||
platform's gates over the simplest case (equities T+1) before
|
||||
expanding. "All types of securities" is the product vision; v1.26 is
|
||||
the pilot (equities first). Future milestones add other security types
|
||||
with their settlement models.
|
||||
|
||||
- `adapters/terraform/adapter.py:129` sets the Terraform state key to:
|
||||
`spike/{stack_name}/{environment}/terraform.tfstate`
|
||||
- `stack_name` = `contract["id"]` (stable across env changes, per
|
||||
`core/contract_resolver.py:584`).
|
||||
- When a consumer edits `environment:` from `dev` → `qa` on the same
|
||||
contract `id`, the state key changes from `spike/assets/dev/` to
|
||||
`spike/assets/qa/`. Terraform initializes a **fresh state file** in the
|
||||
new env's state path. The prior env's resources remain live in AWS with
|
||||
their state file untouched. **No destroy ever runs.** This orphans
|
||||
resources.
|
||||
---
|
||||
|
||||
**The user's binding directive:** Editing `environment:` on a stable
|
||||
`contract.id` is a valid promotion path (Shape A). The platform **must**
|
||||
destroy the prior env's resources before building the new env. There must
|
||||
be **no path that orphans resources** — fail closed if the destroy fails.
|
||||
## 2. Nova Consumer Deploy Model
|
||||
|
||||
## 2. Existing codebase structure (integration points)
|
||||
### 2.1 The reusable `deploy.yml@v1.25` workflow
|
||||
|
||||
### DynamoDB `nova-contracts` table (the prior-env source of truth)
|
||||
The platform's `.github/workflows/deploy.yml` is a `workflow_call` —
|
||||
a reusable workflow that a consumer repo invokes via
|
||||
`uses: acdl/.github/workflows/deploy.yml@v1.25`. Inputs: `contract`
|
||||
(default `.nova/contract.yml`), `mode` (default `full`; enum
|
||||
`full|plan-only|check-only|decommission`), `environment` (override).
|
||||
The workflow checks out the consumer repo + the platform repo, runs
|
||||
`scripts/run_platform.sh`, and records the apply decision +
|
||||
attestation in the Decision Ledger. Secrets: `NOVA_AWS_*`
|
||||
(account + access key + secret) + `NOVA_LAMBDA_URL` (error reporting).
|
||||
|
||||
- **Table:** `nova-contracts` (env var `CONTRACTS_TABLE`, default
|
||||
`nova-contracts`). Defined in `core/lambda/contract_ingestor.py:25`.
|
||||
- **Schema:** PK `consumerRepo` (S), SK `contractId#submittedAt` (S).
|
||||
Attributes: `contractId`, `contract`, `environment`, `status`,
|
||||
`submittedAt`.
|
||||
- **Written by:** `_submit_contract()` at
|
||||
`core/lambda/contract_ingestor.py:135-176`. The consumer's deploy
|
||||
workflow submits the contract via the Lambda Function URL.
|
||||
- **Read pattern for env-transition:** Query by PK `consumerRepo` + SK
|
||||
begins_with `contractId#` + FilterExpression `status = "submitted"` →
|
||||
sort by `submittedAt` desc → take the latest → read its `environment`.
|
||||
This is the last-submitted env. For the last-*applied* env, a new
|
||||
`#LAST_APPLIED` SK suffix is added (REQ-283).
|
||||
- **Test pattern:** `tests/test_contract_ingestor.py:74-110`
|
||||
(`moto_contracts_table` fixture) uses moto `mock_aws` to create the
|
||||
table. The env-transition tests will mirror this pattern.
|
||||
The pilot consumer (`nova-blockchain-exchange`) invokes this workflow
|
||||
with `mode: full` for `dev` (D-209). The `.gitea/workflows/deploy.yml`
|
||||
mirror is byte-identical (the platform's deploy workflow is
|
||||
forge-agnostic — Gitea + GitHub).
|
||||
|
||||
### Outbox writer (evidence events)
|
||||
### 2.2 `run_platform.sh --apply` path (confirmed)
|
||||
|
||||
- `core/outbox_writer.py` writes hash-chained evidence events to
|
||||
`nova-outbox` table. PK `contractId`, SK `eventType#eventTs`.
|
||||
- The env-transition destroy step emits a `nova.env.destroyed` event via
|
||||
this writer (REQ-284c). Pattern: build an event dict with `contractId`,
|
||||
`eventType: "ENV_DESTROYED"`, `environment: <prior_env>`, `ts`, then
|
||||
call `write_event()`.
|
||||
`scripts/run_platform.sh:431-455` — the `--apply` (or `mode: full`)
|
||||
path runs `terraform apply -auto-approve` after the HITL gate
|
||||
(`:438`). For `dev` (autonomous, no HITL gate), the apply proceeds
|
||||
directly. The apply records the env via `core/env_transition.py record`
|
||||
(`:450`). The full pipeline (no `--apply` flag) continues to Step 7
|
||||
(confidence signal) + Step 8 (outbox write).
|
||||
|
||||
### Contract resolver (environment override)
|
||||
**Gap (noted in RESEARCH §4):** the `--apply` path exits before the
|
||||
outbox write (Step 8). The pilot runs the full pipeline (not `--apply`
|
||||
alone), so the outbox write happens. The `run.completed` event lands in
|
||||
the JSONL Decision Ledger (not the DynamoDB outbox) — this is by design
|
||||
(the outbox is the platform-run evidence stream; the Decision Ledger is
|
||||
the cold store for metrics).
|
||||
|
||||
- `core/contract_resolver.py:460-483` `resolve()` accepts
|
||||
`environment_override` — when set, it overrides the contract's
|
||||
`environment` field **before** schema validation and interpolation
|
||||
(D-088). This is the mechanism the destroy step uses to re-resolve the
|
||||
contract against the prior env: `resolve(contract, env_override=prior_env)`.
|
||||
- Already tested in `tests/test_deploy_workflow_env_input.py:35-52`.
|
||||
### 2.3 Contract schema — multi-module manifest
|
||||
|
||||
### run_platform.sh (where Step 0b goes)
|
||||
`schemas/contract.schema.json:7,24-48` — required fields: `id`,
|
||||
`name`, `environment`, `infrastructure`. The `infrastructure` block is
|
||||
`minProperties: 1` with `patternProperties` accepting any module name
|
||||
key. Multi-module manifest is supported: one contract can declare
|
||||
`infrastructure: { microservice: {...}, dynamodb: {...}, s3: {...} }`.
|
||||
The constraint is the `modules/registry.json` (the module must be
|
||||
registered), not the schema.
|
||||
|
||||
- `scripts/run_platform.sh` is the platform pipeline. Step 0 (lines 222-239)
|
||||
is the environment onboarding check. Step 1 (lines 241-249) is contract
|
||||
validation. **Step 0b goes between them** (after onboarding, before
|
||||
validation).
|
||||
- The destroy step mirrors the existing `--destroy` mode (lines 376-394):
|
||||
`terraform init -reconfigure` + `terraform destroy -auto-approve`. The
|
||||
difference: it runs against the *prior* env's state key, not the current
|
||||
one.
|
||||
- `CONTRACT_ID` is already set at line 217 (`NOVA_CONTRACT_ID` with a
|
||||
default). `CONSUMER_REPO` needs to be derived from `GITHUB_REPOSITORY`
|
||||
or a new `NOVA_CONSUMER_REPO` env var (REQ-286).
|
||||
---
|
||||
|
||||
### deploy.yml (consumer repo → platform)
|
||||
## 3. Platform Module Readiness (the critical finding)
|
||||
|
||||
- `.github/workflows/deploy.yml:132` runs
|
||||
`bash platform/scripts/run_platform.sh $MODE_FLAG $ENV_FLAG "${{ inputs.contract }}"`.
|
||||
- To pass `NOVA_CONSUMER_REPO`, add `NOVA_CONSUMER_REPO=${{ github.repository }}`
|
||||
as an env var on the "Run the platform pipeline" step (REQ-286).
|
||||
### 3.1 The adapter is stateless (v1.11 rewrite)
|
||||
|
||||
### Test patterns
|
||||
`adapters/terraform/adapter.py:1-11` — the adapter is a "STATELESS
|
||||
ASSEMBLER" that owns no module content. There is **no `TYPE_MAP`**,
|
||||
`INPUT_MAP`, or `OUTPUT_MAP` (deleted in the v1.11 stateless rewrite;
|
||||
`modules/STANDARDS.md:212-214` confirms). A new stack type requires a
|
||||
new L1 module (`modules/l1/<name>/` with `interface.json` +
|
||||
`terraform/main.tf` + `README.md` + `instance.json`) + a
|
||||
`modules/registry.json` entry — not an adapter change.
|
||||
|
||||
- **Shell script assertions:** `tests/test_pipeline.py:79-95` reads the
|
||||
script text and asserts substrings. The env-transition tests follow this
|
||||
pattern for `run_platform.sh`.
|
||||
- **DynamoDB mocking:** `tests/test_contract_ingestor.py:74-110` uses moto
|
||||
`mock_aws` + `boto3.client` + `create_table`. The env-transition tests
|
||||
follow this pattern.
|
||||
- **Consumer guide assertions:** `tests/test_consumer_guide_per_env_section.py`
|
||||
reads `docs/consumer-guide.md` text and asserts substrings. The updated
|
||||
tests follow this pattern.
|
||||
### 3.2 ECS — ready
|
||||
|
||||
## 3. Persona assessment (v1.24)
|
||||
`modules/l1/ecs-service/terraform/main.tf:1,11` —
|
||||
`aws_ecs_task_definition` + `aws_ecs_service`. `interface.json:5-6` —
|
||||
`type: aws:ecs:task_definition`. `registry.json:29-37` — registered.
|
||||
Tests: `test_adapter.py:164-185,257-360`, `test_contract_resolver.py:61-92`.
|
||||
The `microservice` L2 (`modules/l2/microservice/composition.json`)
|
||||
references 6 L1 children (ecs-cluster, ecr, iam-role, alb, ecs-service,
|
||||
kms-key) — the ECS pattern is fully wired end-to-end.
|
||||
|
||||
This milestone has two distinct work territories:
|
||||
### 3.3 S3 — ready
|
||||
|
||||
1. **Docs (P1):** `docs/consumer-guide.md` edits + test updates. This is
|
||||
lead-developer territory (narrative/docs + test assertions).
|
||||
2. **Platform code (P2):** `core/env_transition.py` (new), `scripts/run_platform.sh`
|
||||
edits, `.github/workflows/deploy.yml` edit, `adapters/terraform/adapter.py`
|
||||
doc comment. This is backend-engineer territory (Python + bash + YAML).
|
||||
3. **Tests (P3):** `tests/test_env_transition.py` (new), `tests/test_run_platform_env_transition.py`
|
||||
(new), `tests/test_consumer_guide_per_env_section.py` updates. Split:
|
||||
backend-engineer for the env_transition + pipeline tests; lead-developer
|
||||
for the consumer guide test updates.
|
||||
`modules/l1/s3/terraform/main.tf:1` — `aws_s3_bucket` (+ versioning +
|
||||
SSE). `interface.json:5-6` — `type: aws:s3:bucket`. `registry.json:2-10`
|
||||
— registered. Tests: `test_adapter.py:56-110,241-257`,
|
||||
`test_contract_resolver.py:36-51,92-130`.
|
||||
|
||||
**Roster:** lead-developer (docs + guide tests) + backend-engineer (Python +
|
||||
bash + YAML + pipeline tests). frontend-engineer stays deactivated (no UI).
|
||||
data-engineer not needed (no schema changes — the `nova-contracts` table
|
||||
already exists with the right shape; we only add a new SK suffix). No new
|
||||
personas.
|
||||
### 3.4 DynamoDB — GAP (REQ-322)
|
||||
|
||||
## 4. Key decisions logged
|
||||
**No `modules/l1/dynamodb/` directory, no `registry.json` key, no
|
||||
`interface.json`, no `terraform/`, no tests.** The blockchain exchange's
|
||||
ledger table needs this primitive. REQ-322 authors it: `interface.json`
|
||||
(stack type `aws:dynamodb:table`), `terraform/main.tf`
|
||||
(`aws_dynamodb_table` with PK + optional SK, `PAY_PER_REQUEST` default,
|
||||
encryption + PITR enabled per v1.8 NFR defaults), `README.md`,
|
||||
`instance.json`, + `registry.json` entry. The adapter needs no change
|
||||
(stateless); the contract's `infrastructure.dynamodb` block references
|
||||
this primitive. This is the single platform-side module build-out for
|
||||
the milestone.
|
||||
|
||||
| ID | Decision | Confidence | Source |
|
||||
|----|----------|------------|--------|
|
||||
| D-201 | Both promotion shapes supported (A: edit+destroy, B: per-env callers) | 0.95 | User directive |
|
||||
| D-202 | Prior-env source of truth = `nova-contracts` DynamoDB table | 0.85 | User directive + code inspection |
|
||||
| D-203 | Detect-and-destroy at pipeline start (Step 0b) | 0.85 | User directive |
|
||||
| D-204 | Fail closed on destroy failure (no orphan path) | 0.95 | User directive |
|
||||
| D-205 | Cross-account destroy out of scope (same-account only) | 0.80 | CLARIFY A3 |
|
||||
| D-206 | Env-transition destroy is NOT the HITL decommission pipeline | 0.85 | CLARIFY A5 |
|
||||
| D-207 | Last-applied env recorded via `#LAST_APPLIED` SK in `nova-contracts` | 0.85 | RESEARCH §2 |
|
||||
| D-208 | State key `spike/{id}/{env}/` stays as-is (correct for both shapes) | 0.90 | RESEARCH §1b |
|
||||
### 3.5 Stale doc (not a blocker)
|
||||
|
||||
## 5. Pitfalls
|
||||
`adapters/README.md:49-54` references the deleted `TYPE_MAP`/
|
||||
`INPUT_MAP`/`OUTPUT_MAP` — contradicts `adapter.py:1-11` +
|
||||
`modules/STANDARDS.md:212-214`. REQ-321 (docs) should fix this.
|
||||
|
||||
1. **Destroy needs the prior env's Terraform config, not the new env's.**
|
||||
The destroy step must re-resolve the contract with
|
||||
`environment_override=prior_env` so the emitted TF matches the prior
|
||||
env's resources. If we resolve with the new env, the destroy plan won't
|
||||
match the prior state → terraform tries to create, not destroy.
|
||||
2. **`terraform init -reconfigure` is required** when switching state
|
||||
backends between envs (if envs use different state buckets). The
|
||||
`-reconfigure` flag tells Terraform to forget the previous backend config.
|
||||
3. **The `deletion_protection` NFR (REQ-86) blocks destroy.** The destroy
|
||||
step must resolve with `deletion_protection: false` injected (same as
|
||||
decommission Step 2 in `scripts/run_decommission.sh:34-37`). Without
|
||||
this, `terraform destroy` fails on `prevent_destroy` lifecycle blocks.
|
||||
4. **DynamoDB may not be reachable in local/CI mode.** The detect step
|
||||
must handle `ClientError` / `EndpointNotFound` gracefully → log warning
|
||||
+ return `None` (conservative). This is documented in REQ-282.
|
||||
5. **The consumer guide test `test_consumer_guide_states_no_field_editing`
|
||||
will fail after the Step 8 rewrite.** It must be updated in the same
|
||||
phase as the guide edit (P1) or the test suite breaks.
|
||||
---
|
||||
|
||||
## 4. Metric Pipeline Grounding (Post-Pilot targets)
|
||||
|
||||
### 4.1 AI Decision Accuracy — outcome backfill (REQ-317)
|
||||
|
||||
`core/metrics/decision_ledger.py:210-211` documents the event chain:
|
||||
`confidence.computed → ai.decision.made → attestation.recorded →
|
||||
run.completed/failed`. `collector.py:262` inserts `fact_decision.outcome`
|
||||
as `"pending"` — **there is no outcome-backfill step** wiring
|
||||
`run.completed`/`run.failed` back into `fact_decision.outcome`. The AI
|
||||
Decision Accuracy metric (`trust_snapshot.py:70-85`, `_get_ai_decision_accuracy`)
|
||||
reads `decisions WHERE outcome='succeeded' ÷ total` — so it reads 0%
|
||||
today (all pending). REQ-317 adds `core/metrics/outcome_backfill.py`
|
||||
that reads run-manifest events and updates `fact_decision.outcome` +
|
||||
`fact_decision.backfilled_at`. The PCR schema is unchanged (D-211).
|
||||
|
||||
### 4.2 Human Escalation Frequency — `reason='confidence'` tag (REQ-318)
|
||||
|
||||
`core/confidence_signal.py:184` — a `block` band sets
|
||||
`human_override=True` in the `ai.decision.made` event.
|
||||
`run_platform.sh:636` fails the pipeline on `block`. The Human
|
||||
Escalation Frequency metric (`docs/metrics/human_escalation_frequency.md:11-12`)
|
||||
is defined as `count(runs WHERE hitl_block=1 AND reason='confidence') ÷
|
||||
total runs`. The `reason='confidence'` discriminator is **not currently
|
||||
stored** — `hitl_block` is a boolean from the manifest. REQ-318 adds
|
||||
`escalation_reason: 'confidence'` to the `ai.decision.made` event when
|
||||
`band == 'block'` + persists it into `fact_run` via the collector.
|
||||
|
||||
### 4.3 Touchless Resolution Rate — denominator activates post-pilot
|
||||
|
||||
`docs/metrics/touchless_resolution_rate.md:12-15` — defined as a SQL
|
||||
query over `fact_run` (`runs WHERE hitl_block=0 ÷ total runs`). The data
|
||||
lands in `fact_run.hitl_block` via `collector.py:216-227`. No dedicated
|
||||
emitter computes the ratio — it's a downstream query. The denominator
|
||||
is 0 today (no consumer runs). The pilot run activates the denominator.
|
||||
|
||||
---
|
||||
|
||||
## 5. kyverno-json Policy Extensibility
|
||||
|
||||
`adapters/kyverno-json/kyverno_json_engine.py:74-80` — the engine is
|
||||
**policy-dir agnostic**: it loads whatever subdir the caller passes.
|
||||
Existing subdirs: `contract/`, `stack-ir/`, `plan-json/`, `meta/`,
|
||||
`regression/`. Adding a new subdir (e.g. `pilot-readiness/`,
|
||||
`settlement-finality/`) requires: (1) `mkdir
|
||||
adapters/kyverno-json/policies/<name>/`, (2) drop `ValidatingPolicy`
|
||||
YAML/JSON files, (3) wire a caller. No engine code change needed.
|
||||
Test pattern: one test file per subdir (`tests/test_<name>_policies.py`).
|
||||
|
||||
The pilot adds two new policy subdirs: `pilot-readiness/`
|
||||
(REQ-320, no-placeholder-account) + `settlement-finality/` (REQ-315,
|
||||
all-matches-committed). Both follow the established pattern.
|
||||
|
||||
---
|
||||
|
||||
## 6. Env-JSON Wiring Reconciliation (REQ-319)
|
||||
|
||||
`core/environments/dev.json:4` — `account_id: "000000000000"` (placeholder).
|
||||
`core/environment_check.py:48-53` warns (non-fatal) when account_id is
|
||||
placeholder + env != dev. `adapters/terraform/adapter.py:116-117` —
|
||||
computes the state bucket as `nova-tfstate-<AWS_ACCOUNT_ID>-us-east-1`
|
||||
from the `AWS_ACCOUNT_ID` env var, **not** from the env JSON's
|
||||
`state_backend.bucket`. This is the wiring gap: the env JSON's
|
||||
`state_backend` field is currently unused by the live apply path.
|
||||
REQ-319 makes the adapter read `env.state_backend.bucket` when present
|
||||
(falling back to the computed name for backwards compat) + updates
|
||||
`dev.json` to the real account `581513795199` + real bucket
|
||||
`nova-tfstate-581513795199-us-east-1`.
|
||||
|
||||
---
|
||||
|
||||
## 7. Risk Analysis
|
||||
|
||||
| Risk | Likelihood | Impact | Mitigation |
|
||||
|---|---|---|---|
|
||||
| `NOVA_AWS_*` key lacks a needed IAM permission mid-pilot | Low (bootstrap succeeded → root-equivalent) | High (blocks apply) | D-207; the key has root-equivalent perms (empirically confirmed). |
|
||||
| DynamoDB primitive takes longer than expected (new module) | Medium | Medium | REQ-322 is the single platform-side build-out; the `s3`/`rds` primitives are the template — straightforward. |
|
||||
| Homegrown chain has a correctness bug (hash chain breaks) | Low | High | REQ-310 tests cover chain integrity, hash determinism, genesis, append/verify. |
|
||||
| `deploy.yml@v1.25` ref doesn't resolve (floating tag) | Low | High | The platform's `release.yml` creates + force-moves the `v1.25` + `v1` floating tags on merge to main. The pilot contract uses `@v1.25`. |
|
||||
| Settlement-finality policy false-negatives (blocks a valid promotion) | Medium | Medium | REQ-315 tests cover passing + failing fixtures; the policy is skip-when-kj-absent (graceful). |
|
||||
| D-083 deferral challenged (audit ledger not tamper-evident) | Low | Low | D-204; the SQLite hash-chain + DynamoDB outbox is the pilot's audit record. Tamper-evidence is a future milestone. |
|
||||
|
||||
---
|
||||
|
||||
## 8. Persona Assessment
|
||||
|
||||
See `PERSONAS.md` (next section, produced by the lead-developer at the
|
||||
end of RESEARCH). The active roster: backend-engineer (blockchain core
|
||||
+ settlement + outcome backfill), data-engineer (DynamoDB primitive +
|
||||
metrics cold store), policy-engineer (kyverno-json policies), +
|
||||
blockchain-engineer (custom, phase-specific — chain consensus, order
|
||||
matching, settlement finality). frontend-engineer is deactivated (no
|
||||
UI in the pilot).
|
||||
+272
-2142
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,39 @@
|
||||
# VERIFY — v1.26 P3 (pilot-metrics-and-policies) PASS
|
||||
|
||||
> Four-layer verification. All gates green.
|
||||
|
||||
## Structural
|
||||
- pilot-readiness/no-placeholder-account.json + settlement-finality/all-matches-committed.json exist (REQ-315/320)
|
||||
- core/metrics/outcome_backfill.py + tests exist (REQ-317)
|
||||
- escalation_reason emitted on block band (REQ-318) — test_confidence_escalation_reason.py
|
||||
- adapters/terraform/adapter.py reads env.state_backend.bucket (REQ-319) — test_adapter_state_backend.py
|
||||
- core/environments/dev.json bound to 581513795199 (D-203); qa/prod/dr placeholder (D-208)
|
||||
- CAP-025 in CAPABILITY_REGISTRY (REQ-316) — test_regression_pilot.py
|
||||
- workflows-src/rotate-aws-key.yml + synced copies (SPEC §5.9)
|
||||
- consumer deploy.yml: no cross-repo uses: (SPEC §10 Q1 — inline adapter, option c)
|
||||
- kj installed (v0.0.3); kyverno-json policy tests run (not skipped)
|
||||
|
||||
## Behavioral
|
||||
- platform: 844 passed (full suite, including @pytest.mark.slow live-AWS CAPs)
|
||||
- consumer: 90 passed, 6 skipped (pre-existing unrelated skips)
|
||||
- kj substrate: 69 targeted policy/engine tests pass against real kj (zero skips)
|
||||
- pilot policies: pass on valid fixtures, fail on invalid (verified via kj scan violations)
|
||||
|
||||
## Security
|
||||
- no raw NOVA_AWS_* export in scripts/run_platform.sh shell env (SPEC §5.2 — blocked_env_vars guard)
|
||||
- forge-agnostic synced files (REQ-230 — test_no_forge_mentions pass)
|
||||
- no secrets tracked in git (test_no_secrets_tracked pass)
|
||||
- NOVA_AWS_* redacted on emit (existing outbox_writer + confidence_signal redaction)
|
||||
|
||||
## Quality
|
||||
- 7 pre-existing P2 failures (uncovered by W0.5 full-suite run with kj installed) all fixed:
|
||||
dynamodb examples (.yml), sync_workflows drift, CAP-024 deck path (-marp.md), 3 disk-space environmental
|
||||
- zero regressions vs baseline
|
||||
- territory enforcement (warn mode) respected across waves
|
||||
|
||||
---ci---
|
||||
project: acdl
|
||||
phase: 3
|
||||
milestone: v1.26
|
||||
status: verify
|
||||
---
|
||||
@@ -1,135 +0,0 @@
|
||||
# ACDL v1.10 — Verify (milestone gate)
|
||||
|
||||
> Verify date: 2026-07-27. Verifier: ci-verifier. Milestone: v1.10 (complete, tag `v1.10.0`).
|
||||
> Scope: 4 phases (52–55), 5 commits (772ac72..2697775), 22 files, +2281/-256 lines.
|
||||
|
||||
## Layer 1: Structural — PASS
|
||||
|
||||
- All 8 plan-referenced files exist on disk (`core/regression_verify.py`,
|
||||
`core/local_emulators.py`, `scripts/run_regression.sh`,
|
||||
`tests/test_verify_regression_mode.py`,
|
||||
`tests/test_local_emulating_adapters.py`,
|
||||
`.ciagent/CAPABILITY_INVENTORY.md`, `REGRESSION_REPORT.md`,
|
||||
`REGRESSION_REPORT.json`).
|
||||
- All imports resolve (`py_compile` + runtime import OK).
|
||||
- No TODO/FIXME/HACK/stub placeholders in new code (the `LocalLambdaStub`
|
||||
is a legitimate local emulator, not a placeholder).
|
||||
- All declared exports exist (`run_regression`, `write_report`,
|
||||
`CAPABILITY_REGISTRY`, `RegressionReport`, `CapabilityResult`,
|
||||
`FlatFileOutbox`, `LocalEcsEmulator`, `LocalS3StateBackend`,
|
||||
`LocalLambdaStub`, `run_local_e2e`, `is_local_tier`).
|
||||
|
||||
## Layer 2: Behavioral — PASS
|
||||
|
||||
- `pytest tests/ -m "not slow"`: **513 passed**, 5 deselected.
|
||||
- `pytest tests/ -m slow`: **5 passed** (2 local E2E + 3 regression
|
||||
integration incl. live-AWS terraform plan).
|
||||
- **Total: 518 passed, 0 failed.**
|
||||
- Requirement coverage: REQ-112 (P52), REQ-113 (P53), REQ-114 (P54),
|
||||
REQ-115 (P55) — all 4 marked `complete`.
|
||||
- Regression gate: `bash scripts/run_regression.sh` → **16/16
|
||||
capabilities Verified** (12 local + 4 live-AWS). Milestone gate open.
|
||||
|
||||
## Layer 3: Security (STRIDE) — PASS
|
||||
|
||||
| Threat | Risk | Disposition |
|
||||
|--------|------|-------------|
|
||||
| Spoofing | Local Lambda stub patches `_get_dynamodb`/`_get_secrets_client`; opt-in via `ACDL_LOCAL_TIER=1`, never in prod | Accept (low) |
|
||||
| Tampering | Flat-file outbox hash-chain verification detects tampering | Accept (low) |
|
||||
| Repudiation | Regression report records per-capability status + timestamps | Accept (low) |
|
||||
| Info Disclosure | Creds read into env vars, never logged (0 cred strings in reports); ECS binds 127.0.0.1 only | Accept (low) |
|
||||
| Denial of Service | Local ECS emulator: free port, daemon thread, clean destroy | Accept (low) |
|
||||
| Elevation of Privilege | `urllib.urlopen` patched to fake response (no network egress); no eval/exec/subprocess in adapter | Accept (low) |
|
||||
|
||||
All threats low-severity; auto-accepted per
|
||||
`config.json security.auto_accept_low_severity=true`.
|
||||
|
||||
## Layer 4: Quality (multi-persona) — PASS
|
||||
|
||||
| Persona | Finding | Verdict |
|
||||
|---------|---------|---------|
|
||||
| Correctness | 7 adapter defects fixed; each traceable to a terraform validate/plan error | PASS |
|
||||
| Testing | 518 tests pass; 24 new tests. P2: uptime-kuma + RDS not in registry | PASS (1 P2) |
|
||||
| Security | No creds logged; loopback-only; monkey-patches scoped to local tier | PASS |
|
||||
| Performance | Regression run ~60s; acceptable for a milestone gate | PASS |
|
||||
| Maintainability | Well-structured; adding a capability = 1 function + 1 registry entry | PASS |
|
||||
| Adversarial | Gate can't be bypassed; local E2E can't mutate cloud; no injection vectors | PASS |
|
||||
|
||||
**0 P0, 0 P1, 1 P2 (post-hoc: expand regression registry to uptime-kuma + RDS stacks).**
|
||||
|
||||
## Verdict
|
||||
|
||||
**VERIFY PASS** — all 4 layers pass. The v1.10 milestone is sound:
|
||||
the pipeline regression gap is fixed (D-091), the platform is fully
|
||||
locally testable (D-092), every advertised capability is re-verified
|
||||
(D-093, 16/16 Verified), and the docs/decks match verified reality
|
||||
(D-094). 518 tests pass; the regression gate covers 16 capabilities
|
||||
including 4 live-AWS checks. 0 P0, 0 P1, 1 P2 post-hoc. Ready to ship.
|
||||
|
||||
---
|
||||
|
||||
# ACDL — Verify (grill deliverable, commit ac11c01)
|
||||
|
||||
> Verify date: 2026-07-27. Verifier: ci-verifier. Scope: the grill
|
||||
> deliverable (`.ciagent/GRILL.md`, phase 0, status `grill`) added in
|
||||
> commit `ac11c01` since the v1.10 audit PASS (`ab477b3`). Docs-only;
|
||||
> no code, no tests, no schema changes.
|
||||
|
||||
## Layer 1: Structural — PASS
|
||||
|
||||
- `.ciagent/GRILL.md` exists on disk (18250 bytes).
|
||||
- No imports to resolve (markdown docs file).
|
||||
- No TODO/FIXME/HACK/stub placeholders in the report.
|
||||
- All required sections present per grill workflow Step 5 format:
|
||||
title, Run header, Verdict, 9 axes (1–9), Meta, Binding Decisions
|
||||
table (12 rows), Escalations section (2 entries: G-005, G-008).
|
||||
- Commit `ac11c01` `---ci---` block is well-formed: `project: acdl`,
|
||||
`phase: 0`, `milestone: v1.10`, `status: grill`, 12 decision ids
|
||||
(G-001..G-012), 2 escalation lines.
|
||||
|
||||
## Layer 2: Behavioral — PASS
|
||||
|
||||
- `pytest tests/ -m "not slow"`: **513 passed**, 5 deselected (no
|
||||
regressions introduced by the docs-only grill commit).
|
||||
- No new tests required (docs-only deliverable; the grill is a
|
||||
review artifact, not a code change).
|
||||
- Requirement coverage: not applicable (phase 0, status `grill`; no
|
||||
REQ-IDs bound to this deliverable). The grill's binding decisions
|
||||
(G-001..G-012) are advisory and do not modify REQUIREMENTS.md per
|
||||
grill workflow Step 7.
|
||||
|
||||
## Layer 3: Security (STRIDE) — PASS
|
||||
|
||||
| Threat | Risk | Disposition |
|
||||
|--------|------|-------------|
|
||||
| Spoofing | N/A (docs-only; no auth surface) | Accept (none) |
|
||||
| Tampering | Grill report is git-tracked; tampering = git history rewrite (out of scope) | Accept (low) |
|
||||
| Repudiation | Commit `ac11c01` signed by author; `---ci---` block records status + decisions | Accept (low) |
|
||||
| Info Disclosure | No credentials, keys, tokens, or PII in the report (grep scan clean) | Accept (low) |
|
||||
| Denial of Service | N/A (docs file; no runtime surface) | Accept (none) |
|
||||
| Elevation of Privilege | N/A (docs-only; no privilege surface) | Accept (none) |
|
||||
|
||||
All threats low-or-none; auto-accepted per
|
||||
`config.json security.auto_accept_low_severity=true`.
|
||||
|
||||
## Layer 4: Quality (multi-persona) — PASS
|
||||
|
||||
| Persona | Finding | Verdict |
|
||||
|---------|---------|---------|
|
||||
| Correctness | 12 binding decisions traceable to evidence (commit/file/req-id); 2 escalations correctly unresolved | PASS |
|
||||
| Testing | Docs-only; 513 fast tests pass (no regression) | PASS |
|
||||
| Security | No credential leakage; no sensitive data in report | PASS |
|
||||
| Performance | N/A (docs file; no runtime cost) | PASS |
|
||||
| Maintainability | Report follows grill workflow Step 5 format exactly; appendable for future runs | PASS |
|
||||
| Adversarial | Escalations (G-005, G-008) are surfaced, not silently skipped; visible via `ciagent audit` | PASS |
|
||||
|
||||
**0 P0, 0 P1, 0 P2.**
|
||||
|
||||
## Verdict (grill deliverable)
|
||||
|
||||
**VERIFY PASS** — all 4 layers pass. The grill deliverable is a
|
||||
well-formed docs-only artifact. 513 fast tests pass (no regression).
|
||||
No credential leakage. 12 binding decisions recorded; 2 escalations
|
||||
(G-005 risks, G-008 budget) correctly surfaced for human resolution.
|
||||
The grill does not modify PROJECT.md, ROADMAP.md, or REQUIREMENTS.md
|
||||
(per grill workflow Step 7).
|
||||
@@ -0,0 +1,945 @@
|
||||
# Nova — Architecture (v1.1 target)
|
||||
|
||||
> Target architecture for the real Agentic Cloud Delivery Platform (rebranded
|
||||
> Nova in v1.15). Source of truth for **how**: `docs/architecture.md` (v0.2) is the upstream
|
||||
> draft; this file is the Nova-repo operating copy, refined at phase
|
||||
> boundaries. Where this file and `docs/vision.md` conflict, the vision wins.
|
||||
|
||||
## Status
|
||||
|
||||
Architecture is at **v0.2** upstream (`docs/architecture.md`). Milestone v1.1
|
||||
**finalizes it to v1.0** in Phase 07 by resolving the 11 open decisions
|
||||
(see `PROJECT.md` open-decision resolutions table). This file records the
|
||||
locked commitments and the v1.1 spike scope.
|
||||
|
||||
## Overview
|
||||
|
||||
The platform is **four layers + six cross-cutting concerns**. The sixth
|
||||
concern — the engine abstraction (§12) — is first-class, not an
|
||||
implementation detail. The vision's "Two Consumer Surfaces, One Platform"
|
||||
tenet binds everything: L3A and L3B converge on the same contract schema,
|
||||
the same policy envelope, and the same evidence stream.
|
||||
|
||||
```
|
||||
┌──────────── acdl-contracts ────────────┐
|
||||
Developer ───▶ │ commit contract.yaml │ (L3A)
|
||||
Citizen dev ──▶ │ Issue → agent → contract.yaml │ (L3B)
|
||||
└────────────────┬───────────────────────┘
|
||||
│ (push)
|
||||
▼
|
||||
┌──────────────────────┐
|
||||
│ central pipeline │
|
||||
│ (acdl repo, Gitea │
|
||||
│ Actions / act_runner) │
|
||||
└────────┬─────────────┘
|
||||
│
|
||||
┌─────────────────────────┼─────────────────────────┐
|
||||
▼ ▼ ▼
|
||||
contract→IR resolution policy (Checkov/Kyverno) confidence signal
|
||||
│ │ │
|
||||
▼ ▼ ▼
|
||||
Terraform adapter ──▶ terraform plan ──▶ PolicyCheckResult ──▶ {score,band}
|
||||
│ │
|
||||
▼ ▼
|
||||
dev (autonomous, ≥0.50) qa (HITL, ≥0.75) prod (HITL, ≥0.90) dr (HITL, ≥0.95)
|
||||
│
|
||||
▼
|
||||
DynamoDB outbox ──▶ S3 Object Lock (7-yr, source of truth) ──▶ GitHub audit repo (hot index)
|
||||
│
|
||||
▼
|
||||
acdl-evidence (timeline UI)
|
||||
```
|
||||
|
||||
## Layers
|
||||
|
||||
### Layer 1 — Foundational Primitives
|
||||
Single-purpose, **engine-agnostic** primitive modules. L1 modules do
|
||||
not compose with other L1s; L1 takes its environment as input. The L1
|
||||
interface is defined against the **Target Stack IR**, not against Terraform
|
||||
directly (the IR is shaped to round-trip to Terraform in v1, per §12.1).
|
||||
|
||||
- No inter-L1 references. L1 may call Terraform data sources.
|
||||
- Semver: interface → MAJOR, behavior → MINOR, lifecycle → PATCH (W3.D).
|
||||
- Immutability on publication. 12-month deprecation window.
|
||||
- AI refinement is a flag; the trigger is the W1.A joint condition.
|
||||
|
||||
### Layer 2 — Composed Stacks
|
||||
Combine L1 primitives into deployable shapes. Each codebase maps to one
|
||||
canonical L2 stack (`multiStack: true` only per W1.B). Shape X
|
||||
(parameterized module) or Shape Y (thin-composition layer). Hierarchical
|
||||
composition, max depth 5, only registered L1s. The thin-composition tree's
|
||||
`wires` field is defined against the IR's relationship type, not a Terraform
|
||||
module block.
|
||||
|
||||
Pipeline quality checks: secrets-in-plaintext, public ingress, IAM
|
||||
wildcard, KMS key reference, tag compliance, naming convention. Restricted
|
||||
from thin-composition: IAM principal creation, network boundary creation,
|
||||
key/secret creation, external data transfer. Auto-promote after 3 observed
|
||||
usages.
|
||||
|
||||
### Layer 3A — Developer Consumer Surface
|
||||
Tag-based reference to the central pipeline template. Developer-owned
|
||||
workflow file, no platform auto-sync. L3A and L3B are parallel paths, not a
|
||||
progression. **W2.A (Path B):** tag for dev/qa, SHA for prod; platform CLI
|
||||
resolves tag→SHA for prod-bound workflows.
|
||||
|
||||
### Layer 3B — Agentic Consumer Surface
|
||||
Hybrid runtime, skill as markdown, agent as executor. Trust model: trust
|
||||
and always verify on the platform side. Skill envelope (4 dimensions).
|
||||
Stateless agents, all state in the platform. `profile: agentic` marker
|
||||
unlocks `naturalLanguageIntent`, `confidenceAtSubmission`, `agentTrace`.
|
||||
Initial skill catalog (BA.A): web API, worker, scheduled job, static asset,
|
||||
basic observability bootstrap.
|
||||
|
||||
Environment progression:
|
||||
|
||||
| Environment | Autonomy | Attester | Gate |
|
||||
|---|---|---|---|
|
||||
| dev | Full autonomy (no HITL) | — | Confidence ≥ 0.50, all six inputs present |
|
||||
| qa | Held for attestation | QA | GitHub Deployment approval + full QA matrix (§10) |
|
||||
| prod | Held for attestation | SRE | GitHub Deployment approval + full SRE matrix (§10) |
|
||||
| dr | Held for attestation | SRE | GitHub Deployment approval + dr-drill evidence |
|
||||
|
||||
**Staging is removed.** Dev is the only autonomous environment.
|
||||
|
||||
## Cross-cutting concerns
|
||||
|
||||
### Central pipeline template (§6)
|
||||
JSON Schema (draft 2020-12) with a thin domain wrapper. Central repo +
|
||||
generated client libraries. Multi-stage validation: schema → policy → NFR →
|
||||
confidence. Distributed enrichment. GitOps reconciler (K8s API; cdlc-gitops
|
||||
state → CRDs) + Terraform execution layer (§12.5). The pipeline emits one
|
||||
`PolicyCheckResult` per policy rule; the confidence signal consumes them as
|
||||
one normalized input.
|
||||
|
||||
### Contract schema (§7)
|
||||
Central repo + generated client libraries. Strict fail-fast at schema
|
||||
stage, multi-stage validation with reason codes from a published
|
||||
vocabulary. **W3.E:** per-env mandatory inputs —
|
||||
- dev: `stack`, `environment`
|
||||
- qa adds: `validation.e2eSuite`, `validation.loadTest`
|
||||
- prod adds: `runbook`, `dashboard`, `oncall`
|
||||
- dr adds: `drDrillRef`
|
||||
- `inputs` always optional; `profile: agentic` fields optional everywhere.
|
||||
|
||||
### Confidence signal (§8)
|
||||
Six canonical inputs, weighted sum with per-input breakdown. Per-env
|
||||
thresholds: dev ≥ 0.50, qa ≥ 0.75, prod ≥ 0.90, dr ≥ 0.95. Structured output
|
||||
`{ score, band, perInput, reasonCodes }`. 1-year storage, no retraining in
|
||||
v1. Halt with explicit reason on missing input.
|
||||
|
||||
Policy input = list of `PolicyCheckResult` records (engine-agnostic).
|
||||
Severity → penalty: critical → hard override to mandatory block; high →
|
||||
-0.2; medium → -0.05; low → -0.01; info → 0.0. One critical finding
|
||||
hard-overrides the score regardless of all other inputs.
|
||||
|
||||
**BA.B:** thresholds frozen for v1; tuning begins v1.2 (quarterly FP/FN
|
||||
tracking; override = Infra & Ops + SRE joint sign-off, itself a
|
||||
confidence-event).
|
||||
|
||||
### Audit and evidence stream (§9)
|
||||
Tiered ledger: **S3 with Object Lock in compliance mode** (cold, source of
|
||||
truth, 7-year retention) + **GitHub audit repo** (`acdl-evidence`, hot
|
||||
query index, not part of the chain). Daily checkpoints. Event schema: JWS
|
||||
detached signature, `prev_event_hash` chain, controlled-vocabulary
|
||||
`event_type`. Outbox pattern: local durable outbox + async worker.
|
||||
|
||||
Outbox database = **DynamoDB**. RPO = 0 (synchronous write to local outbox
|
||||
before contract submission ack); RTO = async worker's dead-letter recovery.
|
||||
Single-region in v1. The outbox also stores per-contract QA and prod
|
||||
approver identities (the only durable record outside GitHub's audit log).
|
||||
|
||||
### Human-in-the-Loop mechanics (§10)
|
||||
Pre-execution gates. qa, prod, dr are PR-based attestation gates backed by
|
||||
GitHub Environments with required reviewers. No partial deployment to roll
|
||||
back on rejection (qa, prod); dr is a separate GitHub Deployment against a
|
||||
separate cluster/region.
|
||||
|
||||
Reviewer routing: GitHub CODEOWNERS + Environment required reviewers
|
||||
(qa → QA; prod → SRE; dr → SRE). CODEOWNERS routes, does not enforce
|
||||
identity distinctness.
|
||||
|
||||
**Separation of duties** (platform-internal, not GitHub-native, not Kyverno
|
||||
in v1): on dev→qa promotion the platform writes the QA approver's GitHub
|
||||
identity to the DynamoDB outbox keyed by `contractId`; on qa→prod it reads
|
||||
the stored QA approver and the new SRE approver; if equal, it blocks, emits
|
||||
`SEPARATION_OF_DUTIES_VIOLATION`, and routes a halt artifact to SRE on-call.
|
||||
|
||||
Full 8-concern attestation matrix (functional, performance, security
|
||||
posture, contract NFRs, operational readiness, incident response,
|
||||
capacity/cost, resilience) — see `docs/architecture.md` §10.4.
|
||||
|
||||
Timeout: 1 business day = warn + escalate; 2 business days = auto-freeze +
|
||||
re-submit (linked via `supersedes`). Rejection returns the contract to HELD;
|
||||
the audit chain is extended, not torn up.
|
||||
|
||||
### Agentic stack (§11)
|
||||
Hybrid runtime: platform-managed control plane + consumer-owned agent.
|
||||
Versioned, signed skill catalog over MCP. Skill envelope enforced on
|
||||
invocation and result submission. Consumer-owned skill execution; the
|
||||
platform does not run the skill. Stateless agents, all state in the
|
||||
platform. Skills are reviewed for sensitive data before release (Infra &
|
||||
Ops owns the review; it is the mandatory release gate).
|
||||
|
||||
### Angine execution (§12) — the binding constraint
|
||||
**Target Stack IR** (locked): a engine-neutral description of resources
|
||||
(typed inputs/outputs/NFRs), relationships (single parent per child),
|
||||
composition (tree, max depth 5), and policy hooks. The L1 registry, L2
|
||||
thin-composition tree, contract YML, and PolicyCheckResult schema are all
|
||||
defined against the IR — none against any specific engine.
|
||||
|
||||
**Angine adapters** are the only engine-specific code. An adapter
|
||||
compiles the IR into a engine execution plan. **v1 ships exactly one
|
||||
adapter: the Terraform adapter.** v2+ may add OpenTofu, Pulumi, K8s CRDs
|
||||
without architectural change.
|
||||
|
||||
v1 reality: the IR is shaped to round-trip cleanly to Terraform (nearly
|
||||
isomorphic). As more adapters appear, the IR gets more expressive and the
|
||||
adapters gain translation logic; the L1 content, the YML standard, and the
|
||||
thin-composition tree do not change.
|
||||
|
||||
**Terraform adapter (v1):** translates IR-typed L1 interface → Terraform
|
||||
`variable`/`output` blocks; IR-typed L2 thin-composition tree → Terraform
|
||||
root module; IR-typed relationships → module references; emits a
|
||||
`terraform plan` from the IR. The adapter is a thin layer; it does not own
|
||||
L1/L2 content.
|
||||
|
||||
State storage: S3 (state) + DynamoDB (locking), cloud-managed,
|
||||
single-region in v1.
|
||||
|
||||
Policy toolchain: **Checkov** for Terraform plan policy (the L2 checks +
|
||||
tag/naming); **Kyverno** for K8s-native/platform-internal policy; **OPA**
|
||||
reserved for cross-resource cases, explicitly last resort.
|
||||
|
||||
**Policy result normalization (§12.6):** the confidence signal consumes a
|
||||
normalized `PolicyCheckResult` schema, not raw engine output.
|
||||
|
||||
```json
|
||||
{
|
||||
"contractId": "uuid",
|
||||
"evaluatedAt": "ISO-8601",
|
||||
"engine": "checkov | kyverno | opa",
|
||||
"ruleId": "CKV_AWS_24 | KYVERNO_NO_PRIVILEGED | ...",
|
||||
"severity": "critical | high | medium | low | info",
|
||||
"result": "pass | fail | skipped | error",
|
||||
"message": "human-readable",
|
||||
"evidence": { "...engine-specific, opaque to the signal..." },
|
||||
"resourceRef": "IR-typed resource identifier"
|
||||
}
|
||||
```
|
||||
|
||||
Execution layer: GitHub/Gitea Actions in the central pipeline repo. State
|
||||
locking via DynamoDB. **AWS credentials via OIDC federation — long-lived
|
||||
credentials are forbidden** (§12.5). The platform does not run
|
||||
`terraform apply` against a developer's workstation; all execution is in
|
||||
the central pipeline.
|
||||
|
||||
Registry maintenance: L1 publication updates the L1 registry in the same
|
||||
PR. The registry is the IR-typed contract, not a Terraform-specific
|
||||
variable schema.
|
||||
|
||||
Contract→IR resolution: the contract declares intent in IR-typed terms;
|
||||
the pipeline resolves it to a target stack (list of L1 instances + inputs +
|
||||
relationships); the Terraform adapter compiles the target stack to a plan.
|
||||
|
||||
## v1.1 spike scope
|
||||
|
||||
The spike (Phases 08–10) materializes the **minimum** that proves the IR
|
||||
commitments hold (no polyglot mess):
|
||||
|
||||
- One L1: `l1-s3` (IR-typed interface; the only AWS resource in the spike).
|
||||
- One L2 thin-composition: `l2-static-assets` (references `l1-s3` only).
|
||||
- Terraform adapter: IR → `terraform plan` against AWS via OIDC.
|
||||
- One contract submission → contract→IR → `terraform plan` → Checkov
|
||||
`PolicyCheckResult` → confidence signal → evidence event to the DynamoDB
|
||||
outbox.
|
||||
- State: S3 + DynamoDB (real AWS, single-region).
|
||||
|
||||
Out of spike scope: full HITL matrix wiring, Kyverno, OPA, MCP skill
|
||||
catalog, GitOps reconciler, multi-region, prod/dr environments, the 5-skill
|
||||
L3B catalog. Those are post-spike (v1.2+) platform build-out.
|
||||
|
||||
## Gitea API surface (carried from v1.0, refined)
|
||||
|
||||
| Capability | Gitea support | ACDL approach (v1.1) |
|
||||
|------------|---------------|----------------------|
|
||||
| Org-scoped repo create | `POST /api/v1/orgs/{org}/repos` | Used for any new repos |
|
||||
| Native Pages | **None** | Serve `acdl-evidence` via raw file URLs (unchanged from v1.0) |
|
||||
| Environments API | **None**; act_runner ignores `environment:` | Model HITL gates via `workflow_dispatch` approval inputs (v1.0 D-013 pattern) — **refined in Phase 07** for the real pre-execution gate model |
|
||||
| `repository_dispatch` | Not supported | Cross-repo trigger via `workflow_dispatch` API (unchanged) |
|
||||
| Reusable workflows | Supported | `acdl/.gitea/workflows/pipeline.yml` via `uses: ...@<ref>` |
|
||||
| `id-token: write` / OIDC | **Not supported** (RESEARCH TARGET 1, conf 0.95). Gitea docs list `id-token` as an unsupported GitHub-only scope; open proposal go-gitea/gitea#33681; draft PR go-gitea/gitea#36988 unmerged. Even Gitea's own CI uses long-lived AWS keys (issue #37980). | **Spike waiver D-039:** per-run-rotated long-lived key (rotated after each run by `scripts/rotate_spike_key.sh`). Real OIDC deferred to v1.2, blocked on PR #36988. |
|
||||
| `actions/configure-aws-credentials` | Unusable without OIDC | Spike uses static AWS creds from a (rotated) Gitea Actions secret via the `aws-actions/configure-aws-credentials@v4` `access-key-id`/`secret-access-key` inputs, or plain `AWS_ACCESS_KEY_ID`/`AWS_SECRET_ACCESS_KEY` env vars. v1.2 switches to `role-to-assume` when OIDC lands. |
|
||||
|
||||
### Branch pinning rule (refined for W2.A)
|
||||
|
||||
- Dev/qa contracts reference the reusable workflow by **tag**
|
||||
(`@v1.1-spike`).
|
||||
- Prod-bound workflows reference by **SHA**; the platform CLI
|
||||
(`platform/cli/resolve-tag.ts`, Phase 07) resolves the current tag to its
|
||||
SHA. (Spike scope: the CLI is a stub; the real CLI lands in v1.2.)
|
||||
|
||||
### Verification toolchain
|
||||
|
||||
ACDL has no `package.json`. The verification gate substitutes:
|
||||
- **typecheck:** `terraform validate`, `python3 -m py_compile`, JSON Schema
|
||||
validation (`ajv` or `python -m jsonschema`) against `schemas/`.
|
||||
- **test:** per-phase `scripts/verify_phaseNN.sh` (Phase 06: archive integrity;
|
||||
Phase 07: schema validation + decision-resolution completeness; Phase 08:
|
||||
OIDC assume-role + state backend; Phase 09: IR + L1 + adapter `terraform
|
||||
plan`; Phase 10: end-to-end contract submission).
|
||||
- **build:** `terraform init` (real build for the spike).
|
||||
- See `PERSONAS.md` verification_toolchain.
|
||||
|
||||
## Build order (v1.1)
|
||||
|
||||
1. Phase 06 — archive demo, reorient repo.
|
||||
2. Phase 07 — finalize architecture v1.0; author schemas + designs.
|
||||
3. Phase 08 — AWS OIDC bootstrap (use temp key once, rotate).
|
||||
4. Phase 09 — IR + `l1-s3` + Terraform adapter → `terraform plan`.
|
||||
5. Phase 10 — `l2-static-assets` + contract→IR → end-to-end spike.
|
||||
6. COMPLETE gate — review → ship `v1.2.0` → audit. **DONE.**
|
||||
|
||||
## v1.2 build-out scope
|
||||
|
||||
v1.2 takes the v1.1 spike (dev-only, `plan`-only, single S3 L1) to a real,
|
||||
simpler, better-documented platform that delivers a microservice to AWS ECS
|
||||
Fargate end-to-end. The locked architecture (§1–§12) is unchanged — v1.2
|
||||
extends the *implementation*, not the design.
|
||||
|
||||
### In scope (five axes, user-directed 2026-07-21)
|
||||
|
||||
1. **Re-evaluate the current state.** go-gitea/gitea#36988 (OIDC for Gitea
|
||||
Actions) re-checked 2026-07-21: still **open** (last updated 2026-05-27,
|
||||
not merged). Real OIDC remains deferred to v1.3+; v1.2 extends the D-039
|
||||
per-run-rotated-key waiver as **D-047**. The waiver continues to satisfy
|
||||
§12.5's *intent* (no *persistently* long-lived key): the spike key is
|
||||
rotated after each run by `scripts/rotate_spike_key.sh`, and Phase 12
|
||||
tightens the IAM scoping + rotation hygiene.
|
||||
2. **NFR improvements on the existing spike.** Least-privilege IAM audit of
|
||||
`spike_runner_policy.json`; idempotent `create_state_backend.py` /
|
||||
`create_iam_user.py`; proper exit codes / error handling; P1-1 redaction
|
||||
(two AWS access key IDs in `.ciagent/VERIFY.md` Phase 09 narrative).
|
||||
3. **Streamline / simplify the current setup.** Consolidate
|
||||
`run_spike_plan.sh` + `run_spike_e2e.sh` into one
|
||||
`scripts/run_platform.sh`; remove dead code and stale `platform/` paths.
|
||||
4. **README.md fully up to date on how the platform works.** Reflect v1.1
|
||||
complete; document the actual spike flow, `scripts/run_platform.sh`, the
|
||||
real repo layout, and the v1.2 objective.
|
||||
5. **Bootstrap a consumer repo with a basic microservice deployed to ECS
|
||||
end-to-end.** New Gitea repo `acdl-consumer-microservice` (org
|
||||
`continuous-intelligence`); new IR-typed L1s (`l1-vpc`, `l1-ecs-cluster`,
|
||||
`l1-ecs-service`, `l1-iam-role`, `l1-alb`, `l1-ecr`); new
|
||||
`l2-microservice` thin-composition; one contract submission →
|
||||
`terraform apply` (dev, autonomous per §10, confidence ≥ 0.50) → a live
|
||||
ECS Fargate service serving HTTP 200 → evidence event to the DynamoDB
|
||||
outbox → acdl-evidence timeline.
|
||||
|
||||
### Angine extension (ECS Fargate)
|
||||
|
||||
The Terraform adapter (§12) remains the only engine-specific code. v1.2
|
||||
expands the adapter `TYPE_MAP` to cover the six new ECS-shaped IR resource
|
||||
types. The L1 interface shape (IR-typed inputs/outputs/NFRs, registered in
|
||||
`modules-ir/registry.json`) is unchanged — only the set of registered L1s
|
||||
grows. The IR commitments (REQ-28) continue to hold: `modules-ir/`,
|
||||
`schemas/`, `contracts/`, `core/confidence_signal.py`,
|
||||
`core/contract_resolver.py`, `core/outbox_writer.py`
|
||||
remain engine-agnostic.
|
||||
|
||||
### `terraform apply` (dev only)
|
||||
|
||||
v1.2 lifts the engine execution from `plan` to `apply` for the `dev`
|
||||
environment only. Dev is autonomous per §10 (confidence ≥ 0.50, no HITL).
|
||||
`apply` for qa/prod/dr remains HITL-gated and out of scope for v1.2. The
|
||||
apply result (resources created, plan diff) is captured in the evidence
|
||||
stream as a `terraform.apply` event.
|
||||
|
||||
### Out of scope for v1.2 (deferred to v1.3+)
|
||||
|
||||
| Feature | Reason |
|
||||
|---------|--------|
|
||||
| Real OIDC federation | go-gitea/gitea#36988 still open. v1.2 extends D-039 waiver (D-047); real OIDC is v1.3+. |
|
||||
| Full HITL matrix wiring (qa/prod/dr) | v1.2 is dev-only autonomous `apply`; HITL wiring is v1.3. |
|
||||
| Kyverno + OPA policy engines | v1.2 keeps Checkov only; Kyverno/OPA are v1.3. |
|
||||
| MCP skill catalog + real L3B agent | v1.2 keeps the L3B stub; the 5-skill catalog is v1.3. |
|
||||
| Audit ledger build-out (S3 Object Lock + JWS + async worker + DLQ + daily checkpoints) | v1.2 keeps the v1.1 outbox; the regulatory ledger is v1.3. |
|
||||
| Multi-region state / outbox | Single-region in v1 (§9, §12.3); multi-region is v1.3+. |
|
||||
| Prod/dr environments | v1.2 is dev-only; prod/dr are v1.3. |
|
||||
| GitOps reconciler (ArgoCD/Flux) | v1.3+. |
|
||||
|
||||
## Build order (v1.2)
|
||||
|
||||
1. Phase 11 — re-eval #36988 + NFR audit + simplification findings + README rewrite.
|
||||
2. Phase 12 — NFR harden + simplify (idempotent bootstrap, one `run_platform.sh`, IAM audit, redactions).
|
||||
3. Phase 13 — six ECS L1s + adapter `TYPE_MAP` expansion.
|
||||
4. Phase 14 — `l2-microservice` + contract schema extension.
|
||||
5. Phase 15 — consumer repo + `terraform apply` (dev) → live ECS service.
|
||||
6. Phase 16 — capstone e2e: consumer commit → live HTTP 200 → evidence → timeline.
|
||||
7. COMPLETE gate — review → ship `v1.3.0` → audit.
|
||||
|
||||
## v1.8 Architecture Addendum
|
||||
|
||||
> Milestone v1.8 (complete, tag `v1.8.0`). Adds encryption-by-default,
|
||||
> deletion-protection-by-default, uptime monitoring, decommission alias,
|
||||
> engineering standards, and path documentation.
|
||||
|
||||
### New Primitives
|
||||
|
||||
- **`kms-key`** (`aws:kms:key`) — Per-stack customer-managed KMS key with
|
||||
`enable_key_rotation = true`. One key per L2 deployment (no shared keys).
|
||||
Wired into both L2 compositions as a child, with its `kms_key_arn` output
|
||||
connected to all children's `kms_key_arn` input. Adapter emits
|
||||
`aws_kms_key` + `enable_key_rotation`.
|
||||
- **`uptime`** (`aws:ecs:uptime-service`) — Uptime-kuma on ECS Fargate with
|
||||
a feature flag (`feature_flag_enabled`), monitored endpoints (HTTP/DNS/TCP),
|
||||
alert channels (Teams/email/SMS/GitHub issues). Deployed by default after
|
||||
any L2 module with a separate terraform state. When the feature flag is
|
||||
false, the adapter emits no resources.
|
||||
|
||||
### Encryption by Default
|
||||
|
||||
All 12 L1 primitives have `encryption_enabled` NFR (default true). Primitives
|
||||
with at-rest data (s3, rds, ecr, ecs-service, ecs-cluster) have an optional
|
||||
`kms_key_arn` input. The adapter emits encryption blocks (SSE-KMS for S3,
|
||||
storage_encrypted for RDS, encryption_configuration for ECR) referencing the
|
||||
per-stack CMK when provided. Managed KMS fallback with stderr warning for
|
||||
standalone L1 deployments.
|
||||
|
||||
### Deletion Protection by Default
|
||||
|
||||
All 12 L1 primitives have `deletion_protection` NFR (default true). The
|
||||
adapter emits `lifecycle { prevent_destroy = true }` when true. L2 modules
|
||||
expose a `features.deletion_protection` flag (default true) propagated to
|
||||
all children via the resolver. Setting `inputs.deletion_protection: false`
|
||||
in the contract disables it for the whole stack.
|
||||
|
||||
### Decommission Alias
|
||||
|
||||
A `mode: decommission` on the deploy pipeline implements a 2-step destroy:
|
||||
1. Disable deletion protection (resolve with `deletion_protection: false`,
|
||||
terraform plan/apply, HITL SRE gate via GitHub environment).
|
||||
2. Zero counts + destroy (`decommission_transform` zeroes all scalable counts,
|
||||
terraform plan/apply, second HITL SRE gate).
|
||||
|
||||
CMDB validation via DynamoDB `acdl-change-requests` table. The Lambda
|
||||
`validate_change_request` action queries the table and asserts
|
||||
`status == "approved"` + `consumerRepo` match.
|
||||
|
||||
### Adapter Expansion
|
||||
|
||||
TYPE_MAP grew from 16 to 19 entries (+ `aws:kms:key`, `aws:kms:alias`,
|
||||
`aws:ecs:uptime-service`). Specialized emission branches added for KMS key
|
||||
rotation, S3 SSE-KMS configuration, uptime ECS Fargate task, and
|
||||
`prevent_destroy` lifecycle on all resources.
|
||||
|
||||
### Pipeline Stages
|
||||
|
||||
The deploy pipeline grew from 8 to 9 stages (+ `deploy-uptime` after
|
||||
`publish-outputs`). The `deploy-uptime` stage constructs a synthetic uptime
|
||||
contract from the L2 stack outputs, resolves + adapts it to a separate
|
||||
terraform state directory, and publishes the uptime URL via PR comment.
|
||||
|
||||
### Forge-Agnostic API URLs
|
||||
|
||||
The platform Lambda (`contract_ingestor.py`) reads `GITHUB_API_BASE` env
|
||||
for forge-agnostic API URLs. GitHub uses `/search/issues`; Gitea uses
|
||||
`/repos/{owner}/{repo}/issues`. Detection via `/api/v1` in the base URL.
|
||||
|
||||
## v1.9 Addendum (2026-07-23)
|
||||
|
||||
### New Components
|
||||
|
||||
- **`core/contract_resolver.py` interpolation** (D-081): the resolver
|
||||
now expands `${env.<field>}` + `${contract.<field>}` tokens
|
||||
post-schema-validation, pre-IR-resolution. The env context is the
|
||||
loaded environment onboarding JSON (`core/environments/<name>.json`,
|
||||
schema `schemas/environment.schema.json`). The resolver's
|
||||
`child_input_map` routes L2 wires to the sub-resource that declares the
|
||||
input (P1-1 — `desired_count` → `aws:ecs:service`, `family` →
|
||||
`aws:ecs:task_definition`).
|
||||
- **`core/environment_check.py` `load()`** (REQ-104): loads + returns the
|
||||
parsed environment JSON; emits a stderr warning for placeholder
|
||||
`account_id` when env != dev.
|
||||
- **`core/hitl_gates.py`** (REQ-108, D-084): the HITL pre-execution
|
||||
attestation gate. Records the approver identity to the DynamoDB outbox
|
||||
(`approver_qa`/`approver_prod`/`approver_dr`), runs the separation-of-
|
||||
duties check on prod, invokes the attestation matrix, returns
|
||||
`(ok, reason)`. Dev skips (autonomous). `run_platform.sh` calls
|
||||
`attest` before apply for qa/prod/dr.
|
||||
- **`core/attestation_matrix.py`** (REQ-109, D-084): the 8-concern
|
||||
attestation matrix from `hitl_matrix_design.md` §10.4. Offline-testable
|
||||
concerns (contract NFRs, schema validity, policy pass) run for real;
|
||||
operator-supplied concerns accept signed evidence artifacts validated
|
||||
for freshness + schema. Signature verification skips when
|
||||
`ACDL_ATTESTATION_SIGNING_KEY_ID` is unset (D-089).
|
||||
- **`core/separation_of_duties.py` `route_halt_artifact`** (REQ-107):
|
||||
real SNS publish (`acdl-sod-halt` topic, ARN from
|
||||
`ACDL_SOD_HALT_TOPIC_ARN`) + outbox fallback
|
||||
(`SEPARATION_OF_DUTIES_VIOLATION` event). The SNS topic is defined in
|
||||
`terraform/platform/main.tf`.
|
||||
- **`adapters/wiz/wiz_adapter.py` `WizClient`** (REQ-110): real GraphQL
|
||||
API client (`<WIZ_API_URL>/graphql`, Bearer auth, pagination via
|
||||
`pageInfo.hasNextPage`). `fetch_and_adapt` translates issues →
|
||||
`PolicyCheckResult`. Graceful degrade when unconfigured.
|
||||
- **`adapters/kyverno/kyverno_adapter.py`** (REQ-111): fleshed-out
|
||||
`PolicyReport` → `PolicyCheckResult` mapping (pass/fail/skip/warn +
|
||||
severity + skip-with-reason + resource construction). Inactive-for-TF
|
||||
guard preserved.
|
||||
|
||||
### Per-Environment Promotion (D-082)
|
||||
|
||||
The deploy workflow (`.github/workflows/deploy.yml` +
|
||||
`.gitea/workflows/deploy.yml`, byte-identical) declares an `environment`
|
||||
`workflow_call` input. When non-empty, `run_platform.sh --environment
|
||||
<name>` overrides the contract's `environment` field before schema
|
||||
validation (D-088). One CI job per environment; promotion = running the
|
||||
matching job, no `environment:` field editing. Per-env contract files
|
||||
(`contracts/<module>.<env>.yaml`) use interpolation for env-specific
|
||||
values.
|
||||
|
||||
### Adapter Parameterization (P1-1, D-085)
|
||||
|
||||
The adapter (`adapters/terraform/adapter.py`) reads ECS/ALB/VPC defaults
|
||||
from L1 `interface.json` inputs (`desired_count`, `launch_type`,
|
||||
`family`, `target_type`, `load_balancer_type`, `name`). The adapter is a
|
||||
thin translator; the `child_input_map` routes wires to the declaring
|
||||
sub-resource.
|
||||
|
||||
### Deferred (D-083)
|
||||
|
||||
S3 Object Lock + JWS detached signatures + async worker + DLQ + daily
|
||||
checkpoints (audit ledger build-out) — deferred to a future milestone.
|
||||
The hash-chain + DynamoDB-outbox path remains the v1.9 production audit
|
||||
record.
|
||||
|
||||
## v1.10 Addendum — Regression VERIFY + Local Emulators + Capability Re-Verification
|
||||
|
||||
### Regression-Class VERIFY (D-091, `core/regression_verify.py`)
|
||||
|
||||
The standard VERIFY stage was diff-scoped (it checked the phase diff
|
||||
only, never re-ran underlying capability). This let 8 NFR-patch phases
|
||||
(v1.9.1–v1.9.8) pass while the platform decayed. The regression-class
|
||||
VERIFY (`core/regression_verify.py`) re-runs capability checks against
|
||||
the current codebase and tags each Verified/Decayed/Broken. It fails
|
||||
closed on any non-Verified capability, blocking milestone completion.
|
||||
|
||||
The registry (`CAPABILITY_REGISTRY`) holds 16 capability checks
|
||||
(CAP-001..CAP-016): 12 local-tier + 4 live-AWS. Adding a capability is
|
||||
a single function + one registry entry. The gate runs via
|
||||
`scripts/run_regression.sh` and writes `.ciagent/REGRESSION_REPORT.md`
|
||||
+ `.json`.
|
||||
|
||||
### Local Emulating Adapters (D-092, `core/local_emulators.py`)
|
||||
|
||||
Four local adapters let the platform run the full headline E2E without
|
||||
cloud credentials:
|
||||
|
||||
- `FlatFileOutbox` — flat-file DynamoDB outbox emulator (hash-chained
|
||||
JSONL; resumable across instances; chain verification).
|
||||
- `LocalEcsEmulator` — local ECS Fargate HTTP 200 emulator (binds port
|
||||
0 on 127.0.0.1; daemon thread; clean destroy).
|
||||
- `LocalS3StateBackend` — rewrites the terraform S3 backend to a local
|
||||
backend (per-stack tfstate in a temp folder).
|
||||
- `LocalLambdaStub` — invokes the contract_ingestor handler in-process
|
||||
(patches `_get_dynamodb`/`_get_secrets_client`/`urllib.urlopen`;
|
||||
DynamoDB writes redirected to the FlatFileOutbox).
|
||||
|
||||
`run_local_e2e()` runs the full pipeline: contract → resolver → adapter
|
||||
→ local S3 backend → local ECS (HTTP 200) → flat-file outbox (chain
|
||||
verified) → local Lambda (200). Gated on `ACDL_LOCAL_TIER=1`.
|
||||
|
||||
### Capability Re-Verification Sweep (D-093)
|
||||
|
||||
`.ciagent/CAPABILITY_INVENTORY.md` enumerates 16 auto-verified
|
||||
capabilities + 6 IAM-gated escalated resources. The sweep found and
|
||||
fixed 7 adapter defects in `adapters/terraform/adapter.py` (duplicate
|
||||
outputs, duplicate args, missing required args, deprecated AWS provider
|
||||
v5 arg names). The headline E2E now passes at both tiers: local
|
||||
emulator + live-AWS terraform init/validate/plan.
|
||||
|
||||
### Adapter Defect Fixes (P54)
|
||||
|
||||
7 defects fixed in `adapters/terraform/adapter.py`:
|
||||
1. Duplicate output definitions (per-resource + stack-level both emitted).
|
||||
2. Duplicate `desired_count`/`launch_type` on ECS service.
|
||||
3. Duplicate `target_type`/`family`/`load_balancer_type`.
|
||||
4. Missing `assume_role_policy`/`role_name` on IAM role (L2 composition gap).
|
||||
5. Missing `cidr_block`/`vpc_id`/`name` defaults on VPC/subnet/route_table/
|
||||
ECS cluster/ECR repository.
|
||||
6. ECR `kms_key_arn` unsupported arg → `encryption_configuration` block.
|
||||
7. CloudFront OAC + WAF deprecated arg names (AWS provider v5):
|
||||
`signing_behavior`, `signing_protocol`, `origin_access_control_id`,
|
||||
`s3_origin_config.origin_access_identity`, `origin_id`, `rule`
|
||||
(singular), `scope=CLOUDFRONT` (uppercase).
|
||||
|
||||
## v1.11 Addendum — Stateless Adapter + Pipeline-Driven Lifecycle Testing
|
||||
|
||||
**Stateless adapter (D-098).** `adapters/terraform/adapter.py` rewritten
|
||||
from a 918-line monolith (3 constant tables `TYPE_MAP`/`INPUT_MAP`/
|
||||
`OUTPUT_MAP`, 39 type-specific branches) to a ~80-line stateless assembler.
|
||||
Each L1 module ships a real `terraform/` module dir
|
||||
(`versions.tf`/`variables.tf`/`locals.tf`/`main.tf`/`outputs.tf`) owning
|
||||
its resource shape, nested blocks, and defaults. The adapter reads the
|
||||
registry, emits a root `main.tf` instantiating each L1 as
|
||||
`module "x" { source = "..." }` with resolved inputs and wired refs.
|
||||
|
||||
**Terraform owns lifecycle (D-101).** `scripts/run_platform.sh` gains
|
||||
`--apply` and `--destroy` modes. Python never runs terraform.
|
||||
`scripts/verify_deploy_microservice.py` is deleted.
|
||||
|
||||
**Pipeline-driven testing (D-102).** A `modules-lifecycle` pipeline
|
||||
(Gitea + GitHub, byte-identical) matrix-runs each L1 module's
|
||||
`examples/{simple,complex}.yml` contracts through apply→modify→destroy
|
||||
against live AWS. No per-module Python/pytest. The "test" = the pipeline
|
||||
cell going green.
|
||||
|
||||
**Single platform VPC (D-105).** `terraform/platform/main.tf` owns ONE
|
||||
VPC; the microservice composition references it via
|
||||
`terraform_remote_state` (data source). State keys are deterministic and
|
||||
env-aware (`spike/{contract.id}/{contract.environment}/terraform.tfstate`).
|
||||
|
||||
**NOVA_LIFECYCLE_MODE (v1.12, REQ-134; renamed ACDL→NOVA in v1.15 P2).** The lifecycle pipeline defaults
|
||||
to plan-only (fast, no AWS mutation, no cost). A CI variable
|
||||
`NOVA_LIFECYCLE_MODE` (default `plan`) overrides to `full` for the real
|
||||
apply→modify→destroy. (P2–P4 dual-read fallback to `ACDL_LIFECYCLE_MODE`;
|
||||
fallback removed in P5 per the v1.15 addendum.)
|
||||
|
||||
## v1.12 Addendum — Presentation Refinement + CAP-013 Fix
|
||||
|
||||
**CAP-013 adapter dedup fix (REQ-129).** Multi-resource L1s (ecs-service,
|
||||
alb) with stack outputs + cross-module refs now dedup to ONE module block
|
||||
named by the composition child id, with expanded sub-ids rewritten via
|
||||
`id_remap`. `terraform validate` succeeds for the microservice stack.
|
||||
|
||||
**CAP-017/018 probe fixes (REQ-130).** CAP-017's probe no longer requires
|
||||
`locals.tf` for modules that legitimately omit it. CAP-018's probe
|
||||
instantiates `LocalLambdaStub` with the required `outbox` arg.
|
||||
|
||||
## v1.13 Addendum — Presentation Polish + Config Schema Migration
|
||||
|
||||
**Config.json schema migration (v1.13.1).** Regenerated
|
||||
`.ciagent/config.json` to the updated CIAgent v2 config structure (drop
|
||||
removed fields, migrate `gitea`→`release.gitea`, add
|
||||
`secrets`/`ship`/`backend`/`ideation`/`personas`/`logging`/`telemetry`
|
||||
sections).
|
||||
|
||||
**Presentation polish (v1.13.0, v1.13.2).** Action headlines, story-arc
|
||||
restructure, larger fonts, 6 new mermaid diagrams, badge cleanup,
|
||||
platform-architecture diagram. Docs-only NFR patches.
|
||||
|
||||
## v1.14 Addendum — NFR Refinement (bug fixes, security, stubs, tests, docs)
|
||||
|
||||
**Bug fixes (Wave 1, P1-P6).** Adapter dedup rejects unregistered modules
|
||||
with ValueError (P1). Static-assets composition wires cloudfront inputs
|
||||
(P2). L2 lifecycle scripts document remote-state design (P3). Regression
|
||||
gate adds `terraform fmt -check` syntax probe (P4). Adapter dedup-merge +
|
||||
remote-state-key unit tests (P5). ALB target group name_prefix derives
|
||||
from var.name (P6).
|
||||
|
||||
**Security (Wave 2, P7-P12).** 6 swallowed-error sites narrowed to
|
||||
specific exceptions (P7). Account ID externalized to
|
||||
`ACDL_AWS_ACCOUNT_ID` env (P8). IAM policy scoped to `acdl-*` ARNs (P9).
|
||||
Contract ingestor validates contractId/environment/error (P10). Environment
|
||||
schema adds `additionalProperties: false` + format validation (P11).
|
||||
`.gitignore` credential-pattern catch-all (P12).
|
||||
|
||||
**Stub/test/CI/hygiene (Wave 3, P13-P17).** Kyverno `--kube-version` flag
|
||||
removed (P13, G-103). Orphan artifacts + dead config cleaned (P14). 7
|
||||
untested scripts gain test coverage (P15). Gitea workflow parity
|
||||
documented + script `set` flags fixed (P16). Config.json persona +
|
||||
branching strategy + ollama-cloud aligned (P17).
|
||||
|
||||
**Standards/docs/VPC (Wave 4, P18-P20).** STANDARDS.md reconciled (P18).
|
||||
Documentation synced: ARCHITECTURE.md addenda, stale `@v1.6-1.9` → `@v1.13`,
|
||||
GRILL G-005/G-008 resolved, COST.md window extended, D-083 deferral
|
||||
recorded (P19). Platform VPC CIDR parameterized + data-driven subnet
|
||||
count (P20).
|
||||
|
||||
**D-083 deferral (explicit).** The audit ledger build-out (S3 Object Lock
|
||||
+ JWS detached signatures + SQS DLQ + async worker + daily checkpoints)
|
||||
remains deferred (D-096, v1.14). The hash-chain + DynamoDB outbox is the
|
||||
v1.14 audit record. JWS per-event authenticity is not implemented; a
|
||||
forged event is only detectable by re-reading the whole chain. The
|
||||
deferral is documented here explicitly per the v1.14 grill (E-001).
|
||||
---
|
||||
|
||||
## v1.15 Addendum — Nova Rebrand (Major/breaking, 2026-07-30)
|
||||
|
||||
**Milestone:** v1.15-Nova. A full rebrand from **ACDL** / "Agentic Cloud
|
||||
Delivery Platform" → **Nova** / "The New Dawn of DevSecOps — security
|
||||
as a seamless enabler of fast deployments." This is a **Major
|
||||
milestone** (breaking): consumer-facing path, env var prefixes, SSM
|
||||
path, AWS tag keys, and AWS resource names all change. Per the
|
||||
branch-strategy precedent (breaking/feature milestones tag on their
|
||||
OWN minor line), v1.15 tags run on the **v1.15.x minor line**:
|
||||
`v1.15.0` (P0) → `v1.15.4` (P5 final = release). (G-104 binding.)
|
||||
|
||||
### Naming conventions (rebranded)
|
||||
|
||||
| Convention | Before (v1.0–v1.14) | After (v1.15+) | Phase |
|
||||
|------------|---------------------|-----------------|-------|
|
||||
| Project name | `ACDL` / "Agentic Cloud Delivery Platform" | `Nova` / "The New Dawn of DevSecOps" | P1 |
|
||||
| Tagline | "Consumers declare intent; the platform delivers safe production deployment through an agentic stack" | (retained) **+** "The New Dawn of DevSecOps — security as a seamless enabler of fast deployments" | P1 |
|
||||
| Schema `$id` URL | `https://acdl.cloudinit.dev/schemas/...` | `https://nova.cloudinit.dev/schemas/...` | P1 |
|
||||
| Gitea release title | `ACDL vX.Y.Z` | `Nova vX.Y.Z` | P1 (forward only) |
|
||||
| Env var prefix | `ACDL_*` (21 vars) | `NOVA_*` (dual-read fallback in P2–P4; removed P5) | P2 |
|
||||
| Env loader | scattered `os.environ.get("ACDL_*")` | centralized `core/env.py` `get_env()` (D-108) | P2 |
|
||||
| Consumer contract path | `.acdl/contract.yml` | `.nova/contract.yml` | P2 |
|
||||
| Checkov custom rule file | `acdl_tagging.py` | `nova_tagging.py` | P2 |
|
||||
| Checkov tag-key enforcement | `acdl:*` (hard) | `nova:*` (warn P2, hard P3) | P2/P3 |
|
||||
| SSM parameter path | `/acdl/{env}/{contractId}/{output}` | `/nova/{env}/{contractId}/{output}` | P3 |
|
||||
| AWS tag keys | `acdl:owner|environment|contract|cost-center|ref` | `nova:owner|environment|contract|cost-center|ref` | P3 |
|
||||
| ABAC session policy match | `acdl:*` tags | `nova:*` tags (parallel-tag period) | P3 |
|
||||
| DynamoDB tables | `acdl-contracts`, `acdl-change-requests` | `nova-contracts`, `nova-change-requests` (scan+copy) | P4 |
|
||||
| Lambda (ingestor) | `acdl-contract-ingestor` (role/policy/function) | `nova-contract-ingestor` | P4 |
|
||||
| Secrets Manager secret | `acdl/github-token` | `nova/github-token` | P4 |
|
||||
| SNS topic | `acdl-sod-halt` | `nova-sod-halt` | P4 |
|
||||
| Security group | `acdl-ecs-sg` | `nova-ecs-sg` | P4 |
|
||||
| KMS alias | `alias/acdl-platform` | `alias/nova-platform` | P4 |
|
||||
| ECS cluster/service/task | `acdl-microservice` | `nova-microservice` | P4 |
|
||||
| ECR repo | `acdl-microservice` | `nova-microservice` (re-push) | P4 |
|
||||
| IAM user/policy | `acdl-spike-runner` (+policy) | `nova-spike-runner` (re-bootstrap) | P4 |
|
||||
| S3 state bucket | `acdl-tfstate-581513795199-us-east-1` | `nova-tfstate-581513795199-us-east-1` (`-migrate-state`) | P4 |
|
||||
| ALB name prefix | `acdl-alb` | `nova-alb` | P4 |
|
||||
| Lambda default table names | `CONTRACTS_TABLE` default `acdl-contracts` | default `nova-contracts` (D-111) | P4 |
|
||||
|
||||
### Unchanged conventions (out of scope)
|
||||
|
||||
- **S&P Global Energy visual theme** (`sp-theme.json`, deck CSS: #D6002A
|
||||
red, Akkurat Pro) — client branding, not the Nova product brand (D-107).
|
||||
- **config.json `release.gitea.repo`** = `acdl` — real Gitea repo name
|
||||
unchanged (D-105). Doc URLs updated to `nova` for prose only.
|
||||
- **Git branch/tag naming** — `milestone/v*`, `phase/*`, `v*` semver; no
|
||||
brand name present (D-112: flat-branch convention preserved).
|
||||
- **Past Gitea release titles** — existing releases keep `ACDL vX.Y.Z`.
|
||||
|
||||
### Migration ordering (binding)
|
||||
|
||||
1. **P1** docs/decks/prose — no runtime impact; ships consumer migration
|
||||
guide announcing the 5 breaking changes.
|
||||
2. **P2** code + env vars (dual-read) + consumer path — deployments don't
|
||||
break during the transition window (dual-read fallback).
|
||||
3. **P3** SSM path (copy → read → delete) + tag keys (parallel-tag →
|
||||
policy swap → remove old).
|
||||
4. **P4** AWS resource names — staged terraform migration (KMS alias,
|
||||
SNS/SG/Lambda recreate, DynamoDB scan+copy, ECR re-push, IAM
|
||||
re-bootstrap, state bucket `-migrate-state`, ALB recreate). Maintenance
|
||||
window + rollback runbook (`docs/NOVA_AWS_MIGRATION.md`).
|
||||
5. **P5** final review + audit + remove dual-read fallback + milestone ship.
|
||||
|
||||
### Capability gate (binding)
|
||||
|
||||
The regression gate (CAP-001..CAP-016, `scripts/run_regression.sh`) must
|
||||
stay **16/16 Verified** throughout the rebrand. P2/P3/P4 update test
|
||||
fixtures that reference `ACDL`/`acdl` so the gate stays green. No
|
||||
capability is added, removed, or reclassified in v1.15 — the rebrand is
|
||||
nomenclature + identifiers, not behavior.
|
||||
|
||||
---
|
||||
|
||||
## v1.16 Addendum — Nova Simplification (NFR, 2026-07-30)
|
||||
|
||||
The v1.16 NFR milestone added 6 new code components + 1 new Terraform
|
||||
module + 1 new schema, all documented here for the architecture record.
|
||||
|
||||
### New components
|
||||
|
||||
| Component | Path | Purpose |
|
||||
|-----------|------|---------|
|
||||
| Onboarding request handler | `core/onboarding.py` | `generate_env_file(request, template_env)` — produces a `<env>.json` from a consumer onboarding request (P19, REQ-183). CLI entry point for self-service env-file generation. |
|
||||
| Decommission transform | `core/decommission_transform.py` | `decommission_transform(stack)` — zero counts + disable deletion protection (REQ-92). Extracted from contract_resolver (P12, REQ-176). |
|
||||
| Contract resolver CLI | `core/contract_resolver_cli.py` | `main()` CLI entry point — resolves a contract YAML to a Target Stack JSON. Extracted from contract_resolver (P12, REQ-176). |
|
||||
| Regression verify CLI | `core/regression_verify_cli.py` | `main()` CLI entry point — runs the regression gate + writes the report. Extracted from regression_verify (P13, REQ-177). |
|
||||
| Workflow sync generator | `scripts/sync_workflows.py` | `--check`/`--write` — generates the 3 byte-identical Gitea+GitHub workflow pairs from `workflows-src/` (P8, REQ-172). |
|
||||
| Onboarding Terraform | `terraform/onboarding/` | `aws_iam_role.consumer_deploy` + `aws_iam_role_policy.consumer_invoke` (ABAC `nova:owner` tag). Offline-proven only (P20, REQ-184, D-114). |
|
||||
|
||||
### Modified components
|
||||
|
||||
| Component | Change | Phase |
|
||||
|-----------|--------|-------|
|
||||
| `core/contract_resolver.py` | `_load_env` delegates to `environment_check.load()` (dedup); `is_l2` uses registry `kind` field; `_load_schema` caches schemas; `decommission_transform` + CLI re-export shim (P12). | P7, P12, P14 |
|
||||
| `core/regression_verify.py` | Dedup helpers (`_check_resolver`, `_check_live_terraform_plan`, `_assert_contracts_resolve`); CAP-013..016 `Skipped` on post-teardown (G-111); `passed` accepts Skipped; CLI re-export shim (P13). | P5, P9, P13 |
|
||||
| `core/lambda/contract_ingestor.py` | Fail closed on missing IAM identity (P10); env enum from `core/environments/` (P10); payload size cap + schema validation (P11); `onboard_consumer` action (P18); `[NOVA-ALERT]` rebrand (P2). | P2, P10, P11, P18 |
|
||||
| `core/output_publisher.py` | `SAFE_OUTPUT_NAMES` schema-driven from `interface.json`; narrowed excepts; `urllib.error` import (P4, P14). | P4, P14 |
|
||||
| `core/environment_check.py` | Onboarding message rebranded Nova + self-service request path (P2, P19). | P2, P19 |
|
||||
| `core/local_emulators.py` | `LocalLambdaStub` sets `NOVA_LAMBDA_LOCAL_BYPASS`; stale dual-read comments + `acdl_*` prefixes removed (P3, P10). | P3, P10 |
|
||||
| `scripts/run_platform.sh` | `--help` flag; `run_hitl_gate()` fn; `NOVA_CONTRACT_ID`/`NOVA_WORK_DIR` config; decommission + uptime blocks extracted to sourced helpers (P6, P9, P15). | P6, P9, P15 |
|
||||
| `adapters/terraform/adapter.py` | State bucket `nova-tfstate-*` (P1); module docstring Nova (P2). | P1, P2 |
|
||||
| `adapters/kyverno/policies/require-resource-labels.yml` | `nova:*` labels (not `acdl:*`) (P1). | P1 |
|
||||
| `modules/registry.json` | `kind` field (`l1`/`l2`) on all 14 entries (P7). | P7 |
|
||||
|
||||
### New schema
|
||||
|
||||
- `schemas/onboarding.schema.json` — the self-service onboarding request
|
||||
(consumerRepo, requestedEnvironment, ownerId, billingTag). P18, REQ-182.
|
||||
|
||||
### Onboarding request-path architecture (D-113)
|
||||
|
||||
The no-humans onboarding flow is a 3-step request path (real AWS
|
||||
provisioning deferred):
|
||||
|
||||
```
|
||||
Consumer → POST Lambda (onboard_consumer) → pending CMDB row (P18)
|
||||
→ core/onboarding.py → <env>.json binding file (P19)
|
||||
→ terraform/onboarding/ → cross-account role + ABAC tag (P20, offline)
|
||||
```
|
||||
|
||||
The Lambda Function URL (IAM auth) + `consumer_invoke_policy.json` (ABAC
|
||||
`nova:owner`) are the transport; the request is accepted + a binding
|
||||
generated + the role Terraform proven offline. No AWS resources are
|
||||
created by the request path (D-113/D-114).
|
||||
|
||||
### Regression gate (G-111 binding)
|
||||
|
||||
The regression gate (D-091) now treats `Skipped` as acceptable for the
|
||||
post-v1.11-teardown steady state (D-096): CAP-013..016 (live-AWS tier)
|
||||
return `Skipped` when the resources are absent (`NoSuchBucket`/
|
||||
`ResourceNotFoundException`). `RegressionReport.passed` is
|
||||
`all(r.status in ("Verified", "Skipped"))`. The gate passes at 18
|
||||
Verified + 4 Skipped (0 Decayed/Broken).
|
||||
|
||||
## v1.17 Addendum — Strategic Direction, Leadership Metrics & Unified Story (2026-08-04)
|
||||
|
||||
The v1.17 milestone adds a telemetry/observability layer, a Decision
|
||||
Ledger, a metrics export pipeline, a unified narrative deck, and a
|
||||
durable strategic-direction artifact. This addendum documents the
|
||||
architecture; the full research findings are in RESEARCH.md §v1.17.
|
||||
|
||||
### New components
|
||||
|
||||
| Component | Path | Purpose |
|
||||
|-----------|------|---------|
|
||||
| Event envelope | `core/metrics/event_envelope.py` | CloudEvents 1.0 envelope + `platform.*` semantic conventions (P1, REQ-187) |
|
||||
| Per-run manifest writer | `core/metrics/run_manifest.py` | Emits `nova.run.started/completed/failed` events + writes `metrics/runs/<run_id>.json` (P1, REQ-187) |
|
||||
| Decision Ledger (SQLite) | `core/metrics/decision_ledger.py` | Extends `outbox_writer.py` → SQLite append-only hash-chain table; `ai.decision.made` + `attestation.recorded` events + outcome backfill (P1, REQ-188, D-121) |
|
||||
| Infracost post-processor | `core/metrics/infracost_adapter.py` | Runs Infracost on plan JSON; emits `nova.cost.estimated{delta_usd}` (P1, REQ-187, D-120) |
|
||||
| Metrics collector | `core/metrics/collector.py` | Reads all grounded signals (files + events) → SQLite cold store at `metrics/nova_metrics.db` (P2, REQ-189) |
|
||||
| PowerBI export | `core/metrics/powerbi_export.py` | Emits CSV/JSON views to `metrics/powerbi/` (fact + dim + 8 deferred placeholder views) (P3, REQ-190) |
|
||||
| Metrics schemas | `schemas/metrics_*.schema.json` | Schemas for all event types + fact/dim tables (P1–P2, REQ-187/189) |
|
||||
| Metrics catalog | `docs/METRICS.md` + `docs/metrics/<kpi>.md` | Canonical catalog + per-KPI definition-of-success docs (P4, REQ-195, D-127) |
|
||||
| Unified narrative deck | `docs/presentations/nova-no-humans-platform.md` | Merged deck: Problem→Vision→How→Proof→Roadmap; x3 arc at deck+slide level (P5, REQ-196/197, D-130) |
|
||||
| Strategic direction | `.ciagent/NORTH_STAR.md` | PO-authored durable vision/objectives/anti-goals/targets; read by CIAgent in every future `/ci-run` (P0, REQ-185/186) |
|
||||
|
||||
### Modified components
|
||||
|
||||
| Component | Change | Phase |
|
||||
|-----------|--------|-------|
|
||||
| `core/outbox_writer.py` | Extended to emit to SQLite append-only hash-chain table (Decision Ledger); `ai.decision.made` + `attestation.recorded` events added (P1, D-121) | P1 |
|
||||
| `scripts/run_platform.sh` | Per-run manifest writer invoked; `$WORK/*.json` persisted to `metrics/runs/`; Infracost post-processor invoked after plan (P1) | P1 |
|
||||
| `core/hitl_gates.py` | Emits `attestation.recorded` event to Decision Ledger on qa/prod/dr gate (P1, D-132) | P1 |
|
||||
| `core/confidence_signal.py` | Emits `nova.confidence.computed` + `nova.ai.decision.made` events (P1, D-122) | P1 |
|
||||
| `adapters/terraform/policy/checkov_adapter.py` | Emits `nova.policy.evaluated` event (P1) | P1 |
|
||||
| `core/regression_verify.py` | Emits `nova.capability.verified` event; CAP-023 (metrics collector) + CAP-024 (deck structure) added (P1, P6) | P1, P6 |
|
||||
| `pyproject.toml` | `addopts` gains `--junitxml=metrics/test-results.xml` + `--json-report` (P1, D-120) | P1 |
|
||||
| `docs/presentations/` | Two old decks retired (deleted); unified deck added (P5, D-130) | P5 |
|
||||
|
||||
### Telemetry/observability layer architecture (D-120)
|
||||
|
||||
```
|
||||
┌─────────────────────────────────────────────────────────────────────┐
|
||||
│ Nova platform components (existing) │
|
||||
│ run_platform.sh · confidence_signal · checkov_adapter · │
|
||||
│ hitl_gates · regression_verify · outbox_writer · contract_ingestor │
|
||||
└──────────────────────┬──────────────────────────────────────────────┘
|
||||
│ CloudEvents 1.0 envelope (new emitters, P1)
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────────┐
|
||||
│ metrics/events.jsonl (append-only CloudEvents log) │
|
||||
│ metrics/runs/<run_id>.json (per-run manifests) │
|
||||
│ metrics/decision_ledger.db (SQLite hash-chain, D-121) │
|
||||
│ metrics/test-results.xml (junit, P1) │
|
||||
└──────────────────────┬──────────────────────────────────────────────┘
|
||||
│ collector reads (P2)
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────────┐
|
||||
│ metrics/nova_metrics.db (SQLite cold store, D-126) │
|
||||
│ fact_run · fact_capability · fact_policy_check · fact_confidence │
|
||||
│ fact_test · fact_decision · fact_cost_estimate │
|
||||
│ dim_capability · dim_milestone │
|
||||
│ + 8 empty placeholder views (deferred metrics) │
|
||||
└──────────────────────┬──────────────────────────────────────────────┘
|
||||
│ powerbi_export (P3)
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────────┐
|
||||
│ metrics/powerbi/ (CSV/JSON views, folder connector, D-129) │
|
||||
│ → PowerBI dashboards (external) │
|
||||
└─────────────────────────────────────────────────────────────────────┘
|
||||
```
|
||||
|
||||
**Hot path: deferred (D-126).** No live ops dashboard; SQLite is
|
||||
cold-only (batch/historical). The hot path activates when live AWS is
|
||||
re-provisioned (D-096 lift).
|
||||
|
||||
### NORTH_STAR integration point (REQ-186)
|
||||
|
||||
`.ciagent/NORTH_STAR.md` is read by CIAgent in context-loading for all
|
||||
future milestones. The integration mechanism (to be finalized in P4):
|
||||
a reference from `PROJECT.md` + `ARCHITECTURE.md` (this section) + a
|
||||
config entry in `config.json` (`strategic_direction_file:
|
||||
".ciagent/NORTH_STAR.md"`) that the run workflow reads at SPECIFY. This
|
||||
ensures the strategic direction survives across milestones without
|
||||
being overwritten by status updates.
|
||||
|
||||
### §12.7 — Policy Engine Registry (v1.25, REQ-291)
|
||||
|
||||
The policy-engine abstraction is first-class: a swappable `PolicyEngine`
|
||||
protocol so the engine may change without touching the confidence
|
||||
signal, the pipeline, or the `PolicyCheckResult` schema. This is the
|
||||
**swap boundary** that keeps the platform's compliance posture
|
||||
replaceable (Strategic Objective #2 — provable trust via a replaceable
|
||||
substrate, not a vendor lock-in).
|
||||
|
||||
```
|
||||
contract.yml ─┐ ┌─→ list[PolicyCheckResult] ─┐
|
||||
stack IR ─────┼─→ PolicyEngine.evaluate ├─→ list[PolicyCheckResult] ─┼─→ confidence_signal
|
||||
plan JSON ────┤ (protocol) └─→ list[PolicyCheckResult] ─┘ (engine-agnostic,
|
||||
PCR list ─────┘ unchanged)
|
||||
│
|
||||
▼
|
||||
┌─ KyvernoJsonEngine (shells to `kj scan`; engine: "kyverno")
|
||||
└─ OpaEngine (future — same protocol; engine: "opa")
|
||||
|
||||
checkov/wiz ──→ raw findings ──→ (merged PCR list is the meta-policy payload)
|
||||
```
|
||||
|
||||
**The protocol (`core/policy_engine.py`):**
|
||||
```python
|
||||
class PolicyEngine(Protocol):
|
||||
@property
|
||||
def name(self) -> str: ...
|
||||
def is_configured(self) -> bool: ...
|
||||
def evaluate(self, payload, policy_dir: Path, contract_id: str) -> list[dict]: ...
|
||||
```
|
||||
|
||||
**The registry** reads `config.json.policy.engine` (default
|
||||
`"kyverno-json"`) and returns the active engine. A `NullEngine` is the
|
||||
fallback when the `policy` key is absent (emits `SKIPPED` PCRs —
|
||||
backward compatibility for tests that don't set the key). The
|
||||
confidence signal is **untouched** — it already consumes
|
||||
`list[PolicyCheckResult]` engine-agnostically (§12.6). v1.25 only
|
||||
changes *who produces* the PCR list, not *what* the list is.
|
||||
|
||||
**Engine enum reuse (D-116):** kyverno-json PCR records carry
|
||||
`engine: "kyverno"` (no new enum value). The `engine` field records the
|
||||
policy-engine *family*, not the specific binary. The K8s Kyverno adapter
|
||||
and the kyverno-json engine are distinguished by `ruleId` prefix
|
||||
(`KYVERNO_` vs `KJ_`) and `evidence` payload shape (`namespace`/`kind`
|
||||
vs `assertion`/`jmespath`).
|
||||
|
||||
**Defense-in-depth (D-119):** the declarative meta-policy
|
||||
`block-on-any-critical` (asserts no PCR has `severity: critical` +
|
||||
`result: fail`) is the *source of truth* for "critical = block". The
|
||||
`confidence_signal.py` `PENALTY["critical"]: None` hard-override stays
|
||||
as the *imperative* safety net — the meta-policy runs *before* the
|
||||
confidence signal (produces PCRs that flow in), the hard-override runs
|
||||
*inside* it (the last gate). Removing the hard-override would make the
|
||||
"critical = block" guarantee depend on a single policy file — a
|
||||
regression in provable trust.
|
||||
|
||||
**Graceful degradation (D-120):** `KyvernoJsonEngine.is_configured()`
|
||||
returns false when `which kj` is absent → `evaluate()` returns a single
|
||||
`SKIPPED` PCR (`ruleId: "KJ_ENGINE_NOT_CONFIGURED"`). The platform
|
||||
functions without the binary (the "platform functions without AI /
|
||||
deterministic scripts" tenet holds — kyverno-json is deterministic, not
|
||||
AI; the `is_configured()` guard ensures the platform runs even when the
|
||||
binary is not installed).
|
||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,78 @@
|
||||
# `.ciagent/archive/` — Completed-Milestone History
|
||||
|
||||
This directory holds byte-identical snapshots of `.ciagent/` files that
|
||||
were compressed out of the active agent context. Compression is **lossless
|
||||
via relocation**: every original byte is reachable here, and the git
|
||||
history at the commit prior to compression preserves the authoritative
|
||||
state for offline agent loading.
|
||||
|
||||
## Why archive
|
||||
|
||||
The active milestone is v1.26 (Live Pilot Estate Activation). The
|
||||
`.ciagent/` root held ~11,164 lines dominated by completed-milestone
|
||||
narratives (v1.0–v1.24). Per the run.md context-loading model, agents
|
||||
read `.ciagent/` every `/ci-run`; the historical narrative was not
|
||||
load-bearing for v1.26 execution and was relocated to keep the working
|
||||
context lean.
|
||||
|
||||
## Contents
|
||||
|
||||
### Snapshots of slimmed files (full content before compression)
|
||||
|
||||
| File | Original (lines) | Replaces | Status at time of snapshot |
|
||||
|---|---|---|---|
|
||||
| `PROJECT-v1.0-v1.24.md` | 1784 | `.ciagent/PROJECT.md` | v1.0–v1.24 milestone-by-milestone narrative + active milestone v1.26 sections |
|
||||
| `REQUIREMENTS-v1.0-v1.24.md` | 2490 | `.ciagent/REQUIREMENTS.md` | All requirements v1.0 (REQ-01) through v1.26 (REQ-322) |
|
||||
| `ROADMAP-v1.0-v1.24.md` | 2341 | `.ciagent/ROADMAP.md` | All phase breakdowns v1.0 through v1.26 |
|
||||
| `ARCHITECTURE-v1.0-v1.24.md` | 945 | `.ciagent/ARCHITECTURE.md` | Full architecture reference + historical "how we got here" narrative |
|
||||
|
||||
The slimmed in-place files retain: active milestone v1.26 context, the
|
||||
v1.25 milestone (since v1.26 tags ride the v1.25.x line), the durable
|
||||
vision/tenets/RACI/capability-status sections, and the current-state
|
||||
architecture reference.
|
||||
|
||||
### Completed-phase artifacts (relocated verbatim)
|
||||
|
||||
| File | Original (lines) | Phase(s) documented |
|
||||
|---|---|---|
|
||||
| `REVIEW.md` | 111 | Multi-persona code review records from completed phases |
|
||||
| `AUDIT.md` | 553 | Project health audit records (reconstruction tests, branch hygiene) |
|
||||
| `VERIFY.md` | 86 | Per-phase verification records |
|
||||
| `PRE_MORTEM.md` | 228 | Pre-mortem analyses for completed milestones |
|
||||
|
||||
### Live operational files NOT archived
|
||||
|
||||
These files remain at their canonical `.ciagent/` paths because they are
|
||||
read/write targets of live code paths and must not be relocated:
|
||||
|
||||
- `REGRESSION_REPORT.json` — written by `core/regression_verify.py:705`,
|
||||
read by `core/metrics/collector.py:27` + `core/metrics/trust_snapshot.py:21`
|
||||
+ `metrics/` views.
|
||||
- `REGRESSION_REPORT.md` — written by `core/regression_verify.py:704`,
|
||||
referenced by `scripts/run_regression.sh`.
|
||||
- `CHECKPOINT.json` — the authoritative resume point for `/ci-run`.
|
||||
- `config.json` — operational configuration (no historical content).
|
||||
|
||||
## How to load archived content
|
||||
|
||||
Agents that need completed-milestone history can read these files
|
||||
directly (they live inside `.ciagent/`, so the path convention holds):
|
||||
|
||||
```
|
||||
.ciagent/archive/PROJECT-v1.0-v1.24.md
|
||||
.ciagent/archive/REQUIREMENTS-v1.0-v1.24.md
|
||||
.ciagent/archive/ROADMAP-v1.0-v1.24.md
|
||||
.ciagent/archive/ARCHITECTURE-v1.0-v1.24.md
|
||||
.ciagent/archive/{REVIEW,AUDIT,VERIFY,PRE_MORTEM}.md
|
||||
```
|
||||
|
||||
For the authoritative pre-compression state of any `.ciagent/` file,
|
||||
use git history at the commit immediately preceding the compression
|
||||
commit (search the log for `chore(P02): compress .ciagent/ files`).
|
||||
|
||||
## `completed-milestones/`
|
||||
|
||||
Reserved for future per-milestone summary files if a milestone's
|
||||
narrative is too large for the slimmed in-place ROADMAP/PROJECT. Currently
|
||||
empty; v1.0–v1.24 narrative is fully preserved in the four snapshot
|
||||
files above.
|
||||
File diff suppressed because it is too large
Load Diff
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,87 @@
|
||||
# VERIFY — P1 engine-core (v1.25)
|
||||
|
||||
> 4-layer verify gate: structural, behavioral, security, quality.
|
||||
> Phase: P1. Requirements: REQ-291..294, 308, 309. Result: PASS.
|
||||
|
||||
## Structural
|
||||
|
||||
- `core/policy_engine.py` exists, implements `PolicyEngine` Protocol
|
||||
(PEP 544, `@runtime_checkable`), `PolicyEngineRegistry` with
|
||||
`register()` + `get_engine()`, `NullEngine` fallback.
|
||||
- `adapters/kyverno-json/kyverno_json_engine.py` exists, exports
|
||||
`KyvernoJsonEngine` with `name`, `is_configured()`, `evaluate()`.
|
||||
- `adapters/kyverno-json/__init__.py` loads the engine by file path
|
||||
(the dir name has a hyphen — not a valid Python package name).
|
||||
- `adapters/kyverno-json/policies/_smoke.json` exists (trivial policy
|
||||
for round-trip validation).
|
||||
- `scripts/install-kyverno-json.sh` exists (go install kj@latest).
|
||||
- `.ciagent/config.json` has the `policy` object
|
||||
(`engine: kyverno-json`, `policy_root`).
|
||||
- `.gitea/workflows/ci.yml` + `.github/workflows/ci.yml` have the
|
||||
Go + kj install step (best-effort, tests skip when kj absent).
|
||||
- `tests/test_policy_engine.py` (10 tests) +
|
||||
`tests/test_kyverno_json_engine.py` (16 tests) exist.
|
||||
|
||||
## Behavioral
|
||||
|
||||
- `pytest tests/test_policy_engine.py tests/test_kyverno_json_engine.py`:
|
||||
**24 passed, 2 skipped** (kj not installed — expected;
|
||||
`pytest.skip("kj not installed")`).
|
||||
- `NullEngine` satisfies the `PolicyEngine` Protocol (G-Q8a —
|
||||
`isinstance(NullEngine(), PolicyEngine)` is True). Proves the swap
|
||||
boundary is real without implementing OPA.
|
||||
- `KyvernoJsonEngine.is_configured()` returns `False` when
|
||||
`which kj` is absent → `evaluate()` returns a single
|
||||
`KJ_ENGINE_NOT_CONFIGURED` SKIPPED PCR (distinct `ruleId` from
|
||||
NullEngine's `NULL_ENGINE_INACTIVE` — G-Q4).
|
||||
- PCR records validate against `schemas/policy_check_result.schema.json`
|
||||
(via `jsonschema.validate` in tests).
|
||||
- Defensive parsing: malformed kyverno-json output → `error` PCR
|
||||
(`KJ_ENGINE_ERROR`), never an exception.
|
||||
- Severity annotation reading (G-Q10a): policies with
|
||||
`nova.cloudinit.dev/severity: high` produce PCRs with `severity: high`;
|
||||
policies without the annotation default to `info`.
|
||||
- Registry: `get_engine()` returns the configured engine; unknown
|
||||
engine name raises `KeyError`; `policy` key absent → `NullEngine`.
|
||||
- No regression: `pytest tests/test_confidence_signal.py
|
||||
tests/test_adapter.py tests/test_checkov_adapter.py
|
||||
tests/test_kyverno_adapter.py tests/test_contract_resolver.py` —
|
||||
**132 passed** (unchanged).
|
||||
|
||||
## Security
|
||||
|
||||
- No new secrets, no new network calls in the engine core (the engine
|
||||
shells to a local binary; the binary makes no network calls for
|
||||
`scan`).
|
||||
- `is_configured()` guard ensures the platform runs without the binary
|
||||
(no hard dependency that could be exploited as a DoS vector).
|
||||
- The engine writes the payload to a temp file (`tempfile.NamedTemporaryFile`)
|
||||
and unlinks it in a `finally` block (no leftover payload on disk).
|
||||
- No `shell=True` in the `subprocess.run` call (command is a list —
|
||||
no shell injection surface).
|
||||
|
||||
## Quality
|
||||
|
||||
- `python3 -m py_compile` passes on all new Python files.
|
||||
- The `PolicyEngine` Protocol is minimal (3 members) — the swap
|
||||
boundary is the moat (NORTH_STAR Strategic Objective #2).
|
||||
- The `NullEngine` proves a second implementation exists (structural
|
||||
conformance) — the OPA swap is a known quantity (RESEARCH §4.2).
|
||||
- Tests use `pytest.skip` when `which kj` is absent, so the CI matrix
|
||||
passes with or without the binary (the suite is green in both cases).
|
||||
|
||||
## Must-have checklist
|
||||
|
||||
- [x] `PolicyEngine` Protocol + `PolicyEngineRegistry` + `NullEngine`
|
||||
(REQ-291)
|
||||
- [x] `config.json.policy` object (REQ-292)
|
||||
- [x] `KyvernoJsonEngine` adapter (REQ-293)
|
||||
- [x] `__init__.py` + `_smoke.json` + `install-kyverno-json.sh` + CI
|
||||
install (REQ-294)
|
||||
- [x] `test_policy_engine.py` — protocol conformance, registry,
|
||||
NullEngine fallback (REQ-308)
|
||||
- [x] `test_kyverno_json_engine.py` — PCR schema validity, defensive
|
||||
parsing, skip-without-kj (REQ-309)
|
||||
|
||||
**Verdict: PASS** — all P1 must-haves met, no regressions, 24 new
|
||||
tests pass (2 skip-without-kj), 132 existing tests unchanged.
|
||||
+15
-5
@@ -4,11 +4,16 @@
|
||||
"slug": "acdl",
|
||||
"name": "Nova — The New Dawn of DevSecOps",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"slug": "nova-blockchain-exchange",
|
||||
"name": "Nova Pilot Consumer — Blockchain Stock Exchange",
|
||||
"default": false
|
||||
}
|
||||
],
|
||||
"active_project": "acdl",
|
||||
"active_projects": ["acdl"],
|
||||
"active_milestone": "v1.24",
|
||||
"active_projects": ["acdl", "nova-blockchain-exchange"],
|
||||
"active_milestone": "v1.26",
|
||||
"autonomy": {
|
||||
"level": "full",
|
||||
"escalation_hooks": ["deploy", "delete_data", "merge_to_main"],
|
||||
@@ -59,7 +64,7 @@
|
||||
},
|
||||
"git": {
|
||||
"branching_strategy": "flat",
|
||||
"_branching_strategy_note": "ACDL uses flat workflow (committed directly to main per established convention since v1.0). The 'phase' strategy is advisory; CIAgent uses milestone/phase branches for v1.14 but the project convention is flat.",
|
||||
"_branching_strategy_note": "Nova uses flat workflow (committed directly to main per established convention since v1.0; renamed ACDL→Nova in v1.15). The 'phase' strategy is advisory; CIAgent uses milestone/phase branches for v1.14 but the project convention is flat.",
|
||||
"auto_commit": true,
|
||||
"auto_push": true
|
||||
},
|
||||
@@ -67,7 +72,8 @@
|
||||
"sources": [".env", ".env.secrets", ".env.*"],
|
||||
"disallow": ["shell_env", "netrc", "keychain", "rc_files", "global_config"],
|
||||
"scopes": {
|
||||
"gitea": "ACDL_GITEA_TOKEN",
|
||||
"forge": "NOVA_FORGE_TOKEN",
|
||||
"gitea": "NOVA_FORGE_TOKEN",
|
||||
"github": "GITHUB_TOKEN",
|
||||
"gitlab": "GITLAB_TOKEN",
|
||||
"openai": "OPENAI_API_KEY",
|
||||
@@ -209,5 +215,9 @@
|
||||
"enabled": true,
|
||||
"persist": true
|
||||
},
|
||||
"strategic_direction_file": ".ciagent/NORTH_STAR.md"
|
||||
"strategic_direction_file": ".ciagent/NORTH_STAR.md",
|
||||
"policy": {
|
||||
"engine": "kyverno-json",
|
||||
"policy_root": "adapters/kyverno-json/policies"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,92 @@
|
||||
# Nova Pilot Consumer — Blockchain Stock Exchange
|
||||
|
||||
> **Milestone:** v1.26 — Live Pilot Estate Activation
|
||||
> **Git:** https://git.cloudinit.dev/continuous-intelligence/nova-blockchain-exchange
|
||||
> **Local clone:** /root/nova-blockchain-exchange
|
||||
> **Role:** The first real consumer estate. A stock exchange built on a
|
||||
> homegrown blockchain, offering equities trading (pilot scope). The
|
||||
> consumer repo owns the app code + `contract.yaml`; the Nova platform
|
||||
> (`acdl` repo) provides the deploy workflow, policy engine, and
|
||||
> attestation gates.
|
||||
|
||||
---
|
||||
|
||||
## Vision / Core Value
|
||||
|
||||
A self-contained securities-trading exchange where every order, match,
|
||||
and settlement is recorded as an immutable transaction on a homegrown
|
||||
Proof-of-Authority (PoA) blockchain. The pilot demonstrates that Nova's
|
||||
autonomous infrastructure can take a real consumer estate from contract
|
||||
to production — apply, attest, record — without an operator in the loop
|
||||
of normal operations.
|
||||
|
||||
## North Star Alignment
|
||||
|
||||
- **Strategic Objective #1** (production-grade zero-touch operations):
|
||||
this estate is the first real consumer; the pilot activates the
|
||||
autonomy claim beyond internal demos.
|
||||
- **Strategic Objective #2** (provable trust): every apply decision +
|
||||
attestation lands in the Decision Ledger; the settlement-finality
|
||||
kyverno-json policy (IDEATE) makes trust a policy artifact.
|
||||
- **Strategic Objective #3** (compounding ROI): unblocks the three
|
||||
Post-Pilot targets (Touchless Resolution ≥99%, Human Escalation
|
||||
<0.1%, AI Decision Accuracy ≥99.5%) — the denominators activate when
|
||||
this estate runs.
|
||||
|
||||
## Domain Boundaries
|
||||
|
||||
- **This repo owns:** the blockchain (consensus, blocks, transactions),
|
||||
the order-matching engine, the settlement service, the `contract.yaml`
|
||||
that declares the infrastructure, and the consumer-side deploy workflow
|
||||
invocation (`uses: acdl/.github/workflows/deploy.yml@v1.25`).
|
||||
- **The platform (`acdl`) repo owns:** the deploy workflow, the policy
|
||||
engine (kyverno-json), the contract resolver, the adapter, the
|
||||
confidence signal, the HITL gates, and the Decision Ledger.
|
||||
|
||||
## Scope: v1.26 Pilot
|
||||
|
||||
- **Equities only** (bonds, derivatives, options deferred to future
|
||||
milestones — different settlement models).
|
||||
- **Minimal PoA ledger** — append-only blocks, single validator (pilot),
|
||||
T+1 settlement finality = block commit. No multi-validator BFT.
|
||||
- **Homegrown chain** — authored as part of this repo, not deployed on
|
||||
Ethereum/Solana/Hyperledger.
|
||||
|
||||
## Anti-Goals (v1.26)
|
||||
|
||||
1. Not a general-purpose blockchain platform — purpose-built for
|
||||
securities settlement in the pilot.
|
||||
2. Not multi-validator consensus — single validator for the pilot.
|
||||
3. Not bonds/derivatives/options — equities only this milestone.
|
||||
4. Not a replacement for the Nova platform — this is a *consumer* of
|
||||
Nova, not a fork.
|
||||
|
||||
## Key Decisions (v1.26 — established in SPECIFY, refined in CLARIFY)
|
||||
|
||||
| ID | Decision | Rationale | Affects |
|
||||
|---|---|---|---|
|
||||
| D-200 | Pilot scope = equities only | Bonds/derivatives/options have very different settlement models; equities (T+1) is the simplest to demonstrate the Nova platform's policy gates over a real estate. | Phase count; requirement scope. |
|
||||
| D-201 | Homegrown PoA ledger (single validator) | Minimal viable chain for a pilot; settlement finality = block commit. Multi-validator BFT is a future milestone. | Blockchain core design. |
|
||||
| D-202 | Consumer repo = `nova-blockchain-exchange` (Gitea) | New repo under `continuous-intelligence` org; tracked as 2nd CIAgent project. | Multi-project config. |
|
||||
| D-203 | AWS account = 581513795199 (existing) | Reuse the bootstrapped account; state bucket + outbox table created in pre-run Workstream A3. | Env JSON binding. |
|
||||
| D-204 | D-083 (S3 Object Lock/JWS) stays deferred | The SQLite hash-chain + DynamoDB outbox is the pilot's audit record. Tamper-evidence is a future milestone. | Audit ledger scope. |
|
||||
| D-205 | Cold-only metrics sufficient (D-126) | No hot ops dashboard in the pilot; cold SQLite store + PowerBI export. | Metrics pipeline. |
|
||||
|
||||
## Constraints
|
||||
|
||||
- The consumer repo's deploy MUST go through `deploy.yml@v1.25` (the
|
||||
reusable workflow) — no direct `terraform apply` bypassing the
|
||||
platform's policy + attestation gates.
|
||||
- The `contract.yaml` MUST validate against
|
||||
`schemas/contract.schema.json`.
|
||||
- The homegrown blockchain MUST be deterministic (same inputs → same
|
||||
block) — it is automation, not AI (NORTH_STAR Objective #2 tenet).
|
||||
|
||||
## Context
|
||||
|
||||
- The Nova platform (`acdl` repo) completed v1.25 (kyverno-json Unified
|
||||
Policy Engine). The swappable `PolicyEngine` adapter is in place.
|
||||
- The AWS bootstrap (S3 state bucket + DynamoDB outbox) was re-run in
|
||||
the pre-run (Workstream A3) — the platform components exist.
|
||||
- The consumer repo was created on Gitea (Workstream A4) and cloned to
|
||||
`/root/nova-blockchain-exchange`.
|
||||
@@ -0,0 +1,221 @@
|
||||
# Requirements — nova-blockchain-exchange (v1.26 pilot)
|
||||
|
||||
> **Project:** nova-blockchain-exchange — blockchain stock exchange (pilot)
|
||||
> **Milestone:** v1.26 — Live Pilot Estate Activation
|
||||
> **Scope:** equities only; minimal PoA ledger; T+1 settlement finality.
|
||||
|
||||
---
|
||||
|
||||
## v1.26 — Live Pilot Estate Activation
|
||||
|
||||
### REQ-310 — Homegrown PoA blockchain core
|
||||
|
||||
The consumer repo implements a minimal Proof-of-Authority blockchain:
|
||||
append-only blocks, single validator (pilot), SHA-256 block hash chain,
|
||||
deterministic block production (same ordered transactions → same block).
|
||||
The chain records every order, match, and settlement as transactions.
|
||||
Settlement finality = block commit (a transaction is final when its
|
||||
block is committed to the chain).
|
||||
|
||||
**Must-haves:**
|
||||
- `chain/block.py` — Block dataclass (index, timestamp, prev_hash,
|
||||
transactions, nonce, hash). `compute_hash()` deterministic.
|
||||
- `chain/ledger.py` — Ledger class: `append_block()`, `verify_chain()`,
|
||||
`get_block(index)`, `get_latest_block()`. Genesis block on init.
|
||||
- `chain/validator.py` — PoA validator: single validator (config-driven,
|
||||
pilot), `propose_block(transactions)` → Block, `commit_block(block)`.
|
||||
- `tests/test_block.py`, `tests/test_ledger.py`, `tests/test_validator.py`
|
||||
— chain integrity, hash determinism, genesis, append/verify.
|
||||
|
||||
### REQ-311 — Order-matching engine
|
||||
|
||||
A limit-order-book matching engine: buy/sell orders with price + size,
|
||||
matched at the best price (price-time priority). Produces match
|
||||
transactions recorded on the chain.
|
||||
|
||||
**Must-haves:**
|
||||
- `engine/order_book.py` — OrderBook: `add_order(order)`,
|
||||
`match_orders()` → list of Match (buyer, seller, price, size).
|
||||
- `engine/order.py` — Order dataclass (id, side, symbol, price, size,
|
||||
timestamp).
|
||||
- `tests/test_order_book.py` — match priority, partial fills, no-match.
|
||||
|
||||
### REQ-312 — Settlement service
|
||||
|
||||
T+1 settlement: matches commit to the chain; a settlement is final when
|
||||
its block is committed. The service reads matches from the order engine,
|
||||
produces settlement transactions, and submits them to the ledger.
|
||||
|
||||
**Must-haves:**
|
||||
- `settlement/service.py` — SettlementService: `settle(match)` →
|
||||
SettlementTransaction, `submit(ledger)`. Idempotent (re-settling a
|
||||
match is a no-op once final).
|
||||
- `tests/test_settlement.py` — happy path, idempotency, finality check.
|
||||
|
||||
### REQ-313 — Consumer `contract.yaml` ✓ complete (P2, v1.25.2)
|
||||
|
||||
The consumer repo declares its infrastructure via a `contract.yaml` at
|
||||
the repo root, validated against `schemas/contract.schema.json`. The
|
||||
contract references the Nova platform's deploy workflow
|
||||
(`uses: acdl/.github/workflows/deploy.yml@v1.25`) and declares the
|
||||
blockchain exchange stack (the AWS resources the app needs: ECS for
|
||||
the matching engine, DynamoDB for the ledger, S3 for block storage).
|
||||
The DynamoDB L1 primitive (REQ-322) must land before this contract can
|
||||
declare `dynamodb` — ECS + S3 already exist.
|
||||
|
||||
**Must-haves:**
|
||||
- `contract.yaml` — id, name (`blockchain-exchange`), environment
|
||||
(dev/qa/prod variants), infrastructure block.
|
||||
- `contracts/blockchain-exchange.dev.yml`, `.qa.yml`, `.prod.yml` —
|
||||
per-environment variants (per-env promotion model, REQ-105).
|
||||
- `tests/test_contract_validates.py` — schema validation against the
|
||||
platform's `schemas/contract.schema.json`.
|
||||
|
||||
### REQ-314 — Consumer deploy workflow invocation ✓ complete (P2, v1.25.2)
|
||||
|
||||
The consumer repo's GitHub/Gitea Actions invoke the Nova platform's
|
||||
reusable `deploy.yml@v1.25` workflow with `mode: full` for the pilot.
|
||||
The workflow checks out the consumer repo + the platform repo, runs
|
||||
`scripts/run_platform.sh`, and records the apply decision + attestation
|
||||
in the Nova Decision Ledger.
|
||||
|
||||
**Must-haves:**
|
||||
- `.github/workflows/deploy.yml` — `uses: acdl/.github/workflows/deploy.yml@v1.25`
|
||||
with `with: { contract: contract.yaml, mode: full, environment: dev }`.
|
||||
- `.gitea/workflows/deploy.yml` — byte-identical mirror (the platform's
|
||||
deploy workflow is forge-agnostic).
|
||||
- `tests/test_deploy_workflow_invocation.py` — asserts the `uses:` ref
|
||||
+ inputs are correct.
|
||||
|
||||
### REQ-315 — Settlement-finality kyverno-json policy (IDEATE I6)
|
||||
|
||||
A kyverno-json policy asserting that every promotion (qa→prod) requires
|
||||
settlement finality: all matches in the promotion window have committed
|
||||
blocks. This is the securities-specific extension of v1.25's policy
|
||||
engine — it applies Nova's compliance posture to the blockchain domain.
|
||||
|
||||
**Must-haves:**
|
||||
- `policies/settlement-finality.json` — kyverno-json policy over the
|
||||
settlement-service status JSON (asserts `all_committed: true`).
|
||||
- `tests/test_settlement_finality_policy.py` — passing + failing
|
||||
fixtures; skip when `kj` absent.
|
||||
|
||||
### REQ-316 — Pilot-estate regression capability (CAP-025)
|
||||
|
||||
A new capability in the regression gate: "pilot estate apply→attest→record
|
||||
round-trip." The regression gate asserts that the consumer estate can
|
||||
run end-to-end (contract resolve → adapter compile → terraform plan →
|
||||
policy scan → confidence signal → attestation → outbox record) against
|
||||
the live AWS account `581513795199`.
|
||||
|
||||
**Must-haves:**
|
||||
- `core/regression_verify.py` gains CAP-025 (live-pilot-apply).
|
||||
- `tests/test_regression_pilot.py` — the round-trip assertion.
|
||||
|
||||
### REQ-317 — Outcome-backfill emitter (IDEATE I1)
|
||||
|
||||
Wire `apply.completed` / `apply.failed` events back into `fact_decision`
|
||||
in the cold store so the AI Decision Accuracy metric has a non-`pending`
|
||||
outcome. Today `fact_decision.outcome` is stuck at `pending` (D-096
|
||||
blocker). The backfill emitter reads `run_manifest.completed/failed`
|
||||
events and updates the corresponding decision's outcome.
|
||||
|
||||
**Must-haves:**
|
||||
- `core/metrics/outcome_backfill.py` — `backfill(decision_id, outcome)`
|
||||
updates `fact_decision.outcome` + `fact_decision.backfilled_at`.
|
||||
- `core/metrics/collector.py` — invokes backfill after run completion.
|
||||
- `tests/test_outcome_backfill.py`.
|
||||
|
||||
### REQ-318 — `reason='confidence'` escalation tag (IDEATE I2)
|
||||
|
||||
Emit a distinct `reason='confidence'` field on the `block` band's
|
||||
`ai.decision.made` event so the Human Escalation Frequency metric has a
|
||||
discriminated numerator. Today `hitl_block` is a boolean from the
|
||||
manifest; the `reason` discriminator is not stored.
|
||||
|
||||
**Must-haves:**
|
||||
- `core/confidence_signal.py` — `ai.decision.made` gains
|
||||
`escalation_reason: 'confidence'` when `band == 'block'`.
|
||||
- `core/metrics/collector.py` — persists `escalation_reason` into
|
||||
`fact_run`.
|
||||
- `tests/test_confidence_escalation_reason.py`.
|
||||
|
||||
### REQ-319 — Env-JSON `state_backend` wiring reconciliation (IDEATE I3)
|
||||
|
||||
The env JSON's `state_backend.bucket` field is currently unused by the
|
||||
adapter (the adapter computes `nova-tfstate-<AWS_ACCOUNT_ID>` directly).
|
||||
Reconcile: the adapter reads `state_backend.bucket` from the env JSON
|
||||
(falling back to the computed name for backwards compat). This closes
|
||||
the wiring gap so the pilot's env JSON is the single source of truth.
|
||||
|
||||
**Must-haves:**
|
||||
- `adapters/terraform/adapter.py` — reads `env.state_backend.bucket`
|
||||
when present.
|
||||
- `tests/test_adapter_state_backend.py`.
|
||||
- `core/environments/*.json` — `state_backend.bucket` updated to the
|
||||
real bucket name `nova-tfstate-581513795199-us-east-1`.
|
||||
|
||||
### REQ-320 — Declarative pilot-readiness kyverno-json policy (IDEATE I5)
|
||||
|
||||
A kyverno-json policy asserting the env JSON has a non-placeholder
|
||||
`account_id` (not `000000000000`) before any `terraform apply`. This is
|
||||
the declarative gate that prevents a pilot run against a placeholder
|
||||
account.
|
||||
|
||||
**Must-haves:**
|
||||
- `adapters/kyverno-json/policies/pilot-readiness/no-placeholder-account.json`
|
||||
- `tests/test_pilot_readiness_policy.py`.
|
||||
|
||||
### REQ-321 — Docs + adapter README for the consumer estate
|
||||
|
||||
Update `adapters/README.md` (new consumer row), `docs/METRICS.md` (the
|
||||
3 Post-Pilot metrics now grounded post-pilot), `.ciagent/ARCHITECTURE.md`
|
||||
(§12.8 — Pilot Estate), and `.ciagent/nova-blockchain-exchange/README.md`
|
||||
(consumer onboarding guide).
|
||||
|
||||
**Must-haves:**
|
||||
- `adapters/README.md` — consumer-repo row.
|
||||
- `docs/METRICS.md` — Post-Pilot metrics grounded note.
|
||||
- `.ciagent/ARCHITECTURE.md` — §12.8 Pilot Estate.
|
||||
- `.ciagent/nova-blockchain-exchange/README.md` — onboarding guide.
|
||||
|
||||
### REQ-322 — DynamoDB L1 primitive (platform-side) ✓ complete (P2, v1.25.2)
|
||||
|
||||
The blockchain exchange's ledger table needs a DynamoDB L1 primitive.
|
||||
Research (RESEARCH §3) confirmed the adapter is stateless/registry-
|
||||
driven (no `TYPE_MAP` — deleted in v1.11); a new stack type requires a
|
||||
new L1 module, not an adapter change. The `dynamodb` primitive mirrors
|
||||
the existing `s3` / `rds` primitives: `interface.json` (stack type
|
||||
`aws:dynamodb:table`, inputs `table_name`/`region`/`pk`/`sk`/`billing_mode`,
|
||||
outputs `table_arn`/`table_name`), `terraform/main.tf`
|
||||
(`resource "aws_dynamodb_table" "this"`), `README.md`, `instance.json`,
|
||||
+ a `registry.json` entry. The pilot contract's `infrastructure.dynamodb`
|
||||
block references this primitive. This is the single platform-side
|
||||
module build-out for the milestone (ECS + S3 already exist).
|
||||
|
||||
**Must-haves:**
|
||||
- `modules/l1/dynamodb/interface.json` — stack type
|
||||
`aws:dynamodb:table`, inputs, outputs.
|
||||
- `modules/l1/dynamodb/terraform/main.tf` —
|
||||
`resource "aws_dynamodb_table" "this"` (PK + optional SK,
|
||||
`billing_mode = PAY_PER_REQUEST` default, encryption + point-in-time-
|
||||
recovery enabled per v1.8 NFR defaults).
|
||||
- `modules/l1/dynamodb/README.md` — module doc.
|
||||
- `modules/l1/dynamodb/instance.json` — sample instance.
|
||||
- `modules/registry.json` — `dynamodb` entry (kind `l1`,
|
||||
`terraform_dir: modules/l1/dynamodb/terraform`).
|
||||
- `tests/test_adapter.py` — add `dynamodb` to `EXPECTED_L1_KEYS` +
|
||||
a resolution + emission test.
|
||||
- `modules/README.md` — catalog index updated.
|
||||
|
||||
### Summary
|
||||
|
||||
13 requirements (REQ-310..322). Equities-only pilot; minimal PoA ledger;
|
||||
T+1 settlement; consumer deploy via `deploy.yml@v1.25`; 3 Post-Pilot
|
||||
metrics grounded (outcome backfill + escalation reason + pilot runs);
|
||||
3 kyverno-json policies extending v1.25 (settlement-finality,
|
||||
pilot-readiness, + the existing meta-policies apply); env-JSON wiring
|
||||
reconciled; DynamoDB L1 primitive authored (the single platform-side
|
||||
module build-out — the adapter is stateless/registry-driven, so the
|
||||
primitive is a new `modules/l1/dynamodb/` module + registry entry, not
|
||||
an adapter change).
|
||||
@@ -0,0 +1,58 @@
|
||||
# Roadmap — nova-blockchain-exchange (v1.26 pilot)
|
||||
|
||||
> **Project:** nova-blockchain-exchange — blockchain stock exchange (pilot)
|
||||
> **Milestone:** v1.26 — Live Pilot Estate Activation
|
||||
|
||||
---
|
||||
|
||||
## v1.26 — Live Pilot Estate Activation (active)
|
||||
|
||||
Lift D-096 (live AWS re-provisioning); activate the first real consumer
|
||||
estate (a stock exchange on a homegrown PoA blockchain, equities only)
|
||||
against live AWS account `581513795199`; ground the three Post-Pilot
|
||||
targets in NORTH_STAR.md (Touchless Resolution ≥99%, Human Escalation
|
||||
<0.1%, AI Decision Accuracy ≥99.5%). The platform repo (`acdl`) provides
|
||||
the deploy workflow, policy engine, and attestation gates; this repo
|
||||
provides the app (blockchain + matching engine + settlement) + the
|
||||
`contract.yaml`.
|
||||
|
||||
Tags run on the **v1.25.x** patch line: `v1.25.0` (P0) → `v1.25.N`
|
||||
(final phase = milestone release).
|
||||
|
||||
### Phase P1 — blockchain-core (planned, tag v1.25.1)
|
||||
- REQ-310: Homegrown PoA blockchain core (block, ledger, validator).
|
||||
- REQ-311: Order-matching engine (limit order book, price-time priority).
|
||||
- REQ-312: Settlement service (T+1, idempotent, finality = block commit).
|
||||
|
||||
### Phase P2 — consumer-contract-and-deploy (complete, tag v1.25.2)
|
||||
- REQ-313: Consumer `contract.yaml` + per-env variants. ✓
|
||||
- REQ-314: Consumer deploy workflow invocation (`deploy.yml@v1.25`). ✓
|
||||
- REQ-322: DynamoDB L1 primitive (platform-side, P2 W0). ✓
|
||||
|
||||
### Phase P3 — pilot-metrics-and-policies (planned, tag v1.25.3)
|
||||
- REQ-315: Settlement-finality kyverno-json policy.
|
||||
- REQ-316: Pilot-estate regression capability (CAP-025).
|
||||
- REQ-317: Outcome-backfill emitter.
|
||||
- REQ-318: `reason='confidence'` escalation tag.
|
||||
- REQ-319: Env-JSON `state_backend` wiring reconciliation.
|
||||
- REQ-320: Declarative pilot-readiness kyverno-json policy.
|
||||
|
||||
### Phase P4 — pilot-run-and-docs (planned, tag v1.25.4)
|
||||
- REQ-321: Docs + adapter README + onboarding guide.
|
||||
- Live pilot end-to-end run (apply → attest → record) against
|
||||
`581513795199`.
|
||||
|
||||
### Phase P5 — final review + audit + milestone ship (Final Phase, tag v1.25.5)
|
||||
- Multi-persona code review across P1..P4.
|
||||
- Audit: reconstruction test, branch hygiene, commit discipline.
|
||||
- Milestone ship: merge `phase/05` → `milestone/v1.26-pilot-activation`
|
||||
→ `main`; tag `v1.25.5` (= the v1.26 release per prev-minor tagging
|
||||
rule); create Gitea release with full milestone summary; delete all
|
||||
milestone branches.
|
||||
- Update `REQUIREMENTS.md` (mark REQ-310..321 complete), `ROADMAP.md`
|
||||
(mark v1.26 complete), `NORTH_STAR.md` (note Strategic Objectives #1
|
||||
+ #3 — first real consumer estate; Post-Pilot denominators activated).
|
||||
|
||||
After v1.26: future milestones may add bonds/derivatives/options
|
||||
(different settlement models), multi-validator BFT consensus, and
|
||||
tamper-evident ledger (D-083 lift).
|
||||
@@ -82,7 +82,7 @@ jobs:
|
||||
with:
|
||||
repository: acdl/acdl
|
||||
path: platform
|
||||
ref: v1.9
|
||||
ref: v1.25
|
||||
|
||||
- uses: actions/setup-python@v5
|
||||
with:
|
||||
@@ -104,7 +104,7 @@ jobs:
|
||||
with:
|
||||
# P4 (REQ-163): IAM role renamed acdl-deploy- → nova-deploy-.
|
||||
role-to-assume: ${{ secrets.NOVA_AWS_ACCESS_KEY_ID == '' && format('arn:aws:iam::{0}:role/nova-deploy-{1}', secrets.NOVA_AWS_ACCOUNT_ID, github.repository_id) || '' }}
|
||||
aws-region: us-east-1
|
||||
aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||
access-key-id: ${{ secrets.NOVA_AWS_ACCESS_KEY_ID }}
|
||||
secret-access-key: ${{ secrets.NOVA_AWS_SECRET_ACCESS_KEY }}
|
||||
|
||||
|
||||
@@ -0,0 +1,69 @@
|
||||
# Nova AWS key rotation — platform-managed scheduled pipeline (SPEC §5.9)
|
||||
#
|
||||
# Rotates the NOVA_AWS_* static key daily (no long-lived keys in the steady
|
||||
# state). v0.2 scope: the mechanism must exist (SPEC §5.9); the v0.2 deploy
|
||||
# uses the currently-active key. The rotation is best-effort + idempotent
|
||||
# (scripts/rotate_spike_key.sh deactivates the old key only after the new
|
||||
# key propagates to the consumer's Actions secret store).
|
||||
#
|
||||
# Auth: the rotation uses the CURRENT NOVA_AWS_* key to authenticate to IAM
|
||||
# (the root account 581513795199 can rotate its own keys — confirmed by the
|
||||
# bootstrap). The aws-actions/configure-aws-credentials@v4 step uses the
|
||||
# static-key path (no OIDC role-to-assume); the long-lived key rotates
|
||||
# itself, which is the bootstrap-exception documented in §5.9.
|
||||
#
|
||||
# Forge coords (base URL / owner / consumer repo) are sourced from
|
||||
# repository secrets — NOVA_FORGE_BASE_URL, NOVA_FORGE_OWNER,
|
||||
# NOVA_CONSUMER_REPO — so the synced workflow file stays forge-agnostic
|
||||
# (REQ-230). The rotation script uploads the new key to the consumer's
|
||||
# Actions secret store (the consumer whose deploy.yml consumes NOVA_AWS_*
|
||||
# via secrets: inherit).
|
||||
name: nova-rotate-aws-key
|
||||
|
||||
on:
|
||||
schedule:
|
||||
- cron: "0 0 * * *" # daily at 00:00 UTC
|
||||
workflow_dispatch:
|
||||
|
||||
permissions:
|
||||
id-token: write
|
||||
contents: read
|
||||
|
||||
jobs:
|
||||
rotate:
|
||||
name: Rotate NOVA_AWS_* static key
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Check out Nova platform repo
|
||||
uses: actions/checkout@v4
|
||||
|
||||
- name: Configure AWS credentials (bootstrap root creds for IAM key rotation)
|
||||
uses: aws-actions/configure-aws-credentials@v4
|
||||
with:
|
||||
aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||
access-key-id: ${{ secrets.NOVA_AWS_ACCESS_KEY_ID }}
|
||||
secret-access-key: ${{ secrets.NOVA_AWS_SECRET_ACCESS_KEY }}
|
||||
|
||||
- name: Install Python deps (boto3 for the rotation script)
|
||||
run: |
|
||||
python3 -m pip install --break-system-packages --quiet boto3
|
||||
|
||||
- name: Run the key rotation script
|
||||
env:
|
||||
# aws-actions/configure-aws-credentials exports AWS_ACCESS_KEY_ID /
|
||||
# AWS_SECRET_ACCESS_KEY; the rotation script reads the bootstrap
|
||||
# creds via NOVA_BOOTSTRAP_AWS_* (its dual-read contract, D-034).
|
||||
# Map the standard AWS_* exports onto the script's expected vars.
|
||||
NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID: ${{ env.AWS_ACCESS_KEY_ID }}
|
||||
NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY: ${{ env.AWS_SECRET_ACCESS_KEY }}
|
||||
# Forge + consumer coords come from repository secrets (REQ-230 —
|
||||
# no forge hostnames/orgs hardcoded in the synced workflow file).
|
||||
# NOVA_FORGE_TOKEN holds the forge API token (set equal to the
|
||||
# existing forge token as a one-time secret setup).
|
||||
NOVA_FORGE_TOKEN: ${{ secrets.NOVA_FORGE_TOKEN }}
|
||||
NOVA_FORGE_BASE_URL: ${{ secrets.NOVA_FORGE_BASE_URL }}
|
||||
NOVA_FORGE_OWNER: ${{ secrets.NOVA_FORGE_OWNER }}
|
||||
NOVA_CONSUMER_REPO: ${{ secrets.NOVA_CONSUMER_REPO }}
|
||||
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||
run: |
|
||||
bash scripts/rotate_spike_key.sh
|
||||
@@ -82,7 +82,7 @@ jobs:
|
||||
with:
|
||||
repository: acdl/acdl
|
||||
path: platform
|
||||
ref: v1.9
|
||||
ref: v1.25
|
||||
|
||||
- uses: actions/setup-python@v5
|
||||
with:
|
||||
@@ -104,7 +104,7 @@ jobs:
|
||||
with:
|
||||
# P4 (REQ-163): IAM role renamed acdl-deploy- → nova-deploy-.
|
||||
role-to-assume: ${{ secrets.NOVA_AWS_ACCESS_KEY_ID == '' && format('arn:aws:iam::{0}:role/nova-deploy-{1}', secrets.NOVA_AWS_ACCOUNT_ID, github.repository_id) || '' }}
|
||||
aws-region: us-east-1
|
||||
aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||
access-key-id: ${{ secrets.NOVA_AWS_ACCESS_KEY_ID }}
|
||||
secret-access-key: ${{ secrets.NOVA_AWS_SECRET_ACCESS_KEY }}
|
||||
|
||||
|
||||
@@ -0,0 +1,69 @@
|
||||
# Nova AWS key rotation — platform-managed scheduled pipeline (SPEC §5.9)
|
||||
#
|
||||
# Rotates the NOVA_AWS_* static key daily (no long-lived keys in the steady
|
||||
# state). v0.2 scope: the mechanism must exist (SPEC §5.9); the v0.2 deploy
|
||||
# uses the currently-active key. The rotation is best-effort + idempotent
|
||||
# (scripts/rotate_spike_key.sh deactivates the old key only after the new
|
||||
# key propagates to the consumer's Actions secret store).
|
||||
#
|
||||
# Auth: the rotation uses the CURRENT NOVA_AWS_* key to authenticate to IAM
|
||||
# (the root account 581513795199 can rotate its own keys — confirmed by the
|
||||
# bootstrap). The aws-actions/configure-aws-credentials@v4 step uses the
|
||||
# static-key path (no OIDC role-to-assume); the long-lived key rotates
|
||||
# itself, which is the bootstrap-exception documented in §5.9.
|
||||
#
|
||||
# Forge coords (base URL / owner / consumer repo) are sourced from
|
||||
# repository secrets — NOVA_FORGE_BASE_URL, NOVA_FORGE_OWNER,
|
||||
# NOVA_CONSUMER_REPO — so the synced workflow file stays forge-agnostic
|
||||
# (REQ-230). The rotation script uploads the new key to the consumer's
|
||||
# Actions secret store (the consumer whose deploy.yml consumes NOVA_AWS_*
|
||||
# via secrets: inherit).
|
||||
name: nova-rotate-aws-key
|
||||
|
||||
on:
|
||||
schedule:
|
||||
- cron: "0 0 * * *" # daily at 00:00 UTC
|
||||
workflow_dispatch:
|
||||
|
||||
permissions:
|
||||
id-token: write
|
||||
contents: read
|
||||
|
||||
jobs:
|
||||
rotate:
|
||||
name: Rotate NOVA_AWS_* static key
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Check out Nova platform repo
|
||||
uses: actions/checkout@v4
|
||||
|
||||
- name: Configure AWS credentials (bootstrap root creds for IAM key rotation)
|
||||
uses: aws-actions/configure-aws-credentials@v4
|
||||
with:
|
||||
aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||
access-key-id: ${{ secrets.NOVA_AWS_ACCESS_KEY_ID }}
|
||||
secret-access-key: ${{ secrets.NOVA_AWS_SECRET_ACCESS_KEY }}
|
||||
|
||||
- name: Install Python deps (boto3 for the rotation script)
|
||||
run: |
|
||||
python3 -m pip install --break-system-packages --quiet boto3
|
||||
|
||||
- name: Run the key rotation script
|
||||
env:
|
||||
# aws-actions/configure-aws-credentials exports AWS_ACCESS_KEY_ID /
|
||||
# AWS_SECRET_ACCESS_KEY; the rotation script reads the bootstrap
|
||||
# creds via NOVA_BOOTSTRAP_AWS_* (its dual-read contract, D-034).
|
||||
# Map the standard AWS_* exports onto the script's expected vars.
|
||||
NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID: ${{ env.AWS_ACCESS_KEY_ID }}
|
||||
NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY: ${{ env.AWS_SECRET_ACCESS_KEY }}
|
||||
# Forge + consumer coords come from repository secrets (REQ-230 —
|
||||
# no forge hostnames/orgs hardcoded in the synced workflow file).
|
||||
# NOVA_FORGE_TOKEN holds the forge API token (set equal to the
|
||||
# existing forge token as a one-time secret setup).
|
||||
NOVA_FORGE_TOKEN: ${{ secrets.NOVA_FORGE_TOKEN }}
|
||||
NOVA_FORGE_BASE_URL: ${{ secrets.NOVA_FORGE_BASE_URL }}
|
||||
NOVA_FORGE_OWNER: ${{ secrets.NOVA_FORGE_OWNER }}
|
||||
NOVA_CONSUMER_REPO: ${{ secrets.NOVA_CONSUMER_REPO }}
|
||||
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||
run: |
|
||||
bash scripts/rotate_spike_key.sh
|
||||
@@ -12,6 +12,37 @@ Adapters translate the engine-agnostic Target Stack IR to engine-specific format
|
||||
| Checkov adapter | `adapters/terraform/policy/checkov_adapter.py` | Checkov JSON | `PolicyCheckResult` records | Translates Checkov results |
|
||||
| Wiz adapter | `adapters/wiz/wiz_adapter.py` | Wiz API issues JSON | `PolicyCheckResult` records | Translates Wiz security findings |
|
||||
| Kyverno adapter | `adapters/kyverno/kyverno_adapter.py` | Kyverno PolicyReport JSON | `PolicyCheckResult` records | K8s-native policy translation |
|
||||
| kyverno-json engine | `adapters/kyverno-json/kyverno_json_engine.py` | Any JSON/YAML payload | `PolicyCheckResult` records | **v1.25 primary policy engine** (swappable via `PolicyEngine` protocol) |
|
||||
|
||||
## Policy Engine Protocol (v1.25)
|
||||
|
||||
The `core/policy_engine.py` module defines the **swap boundary** between
|
||||
Nova and its policy engines. A `PolicyEngine` Python Protocol (PEP 544)
|
||||
with three members (`name`, `is_configured()`, `evaluate()`) is the
|
||||
contract; a `PolicyEngineRegistry` selects the active engine from
|
||||
`config.json`'s `policy.engine` key. The confidence signal and pipeline
|
||||
never import an engine directly — they go through the registry.
|
||||
|
||||
**Implementations:**
|
||||
- `KyvernoJsonEngine` (`adapters/kyverno-json/`) — shells to the `kj`
|
||||
CLI; the v1.25 default.
|
||||
- `NullEngine` (`core/policy_engine.py`) — fallback when the `policy`
|
||||
key is absent (emits `SKIPPED`).
|
||||
- Future: `OpaEngine` — implements the same protocol, shells to
|
||||
`opa eval`. The OPA-equivalent surface is documented in
|
||||
`.ciagent/RESEARCH.md` §4.2.
|
||||
|
||||
**How to add a new engine:**
|
||||
1. Create `adapters/<name>/<name>_engine.py` implementing the
|
||||
`PolicyEngine` protocol (`name`, `is_configured()`, `evaluate()`).
|
||||
2. `evaluate()` returns `list[dict]` where each dict conforms to
|
||||
`schemas/policy_check_result.schema.json`.
|
||||
3. Register the engine in `core/policy_engine.py`'s `_autoload_*`
|
||||
function (or call `register(name, factory)` at startup).
|
||||
4. Set `config.json.policy.engine` to the engine's `name`.
|
||||
5. Add the engine to the `engine` enum in
|
||||
`schemas/policy_check_result.schema.json` if it needs a distinct
|
||||
enum value (v1.25 reuses `"kyverno"` — see D-116).
|
||||
|
||||
## How to Write an Adapter
|
||||
|
||||
|
||||
@@ -0,0 +1,103 @@
|
||||
# kyverno-json Engine Adapter (v1.25)
|
||||
|
||||
The `kyverno-json` engine is Nova's **primary compliance/policy tool**
|
||||
(v1.25), implemented behind the swappable `PolicyEngine` protocol so
|
||||
OPA (or any other engine) can replace it one day.
|
||||
|
||||
## What kyverno-json is
|
||||
|
||||
[kyverno-json](https://github.com/kyverno/kyverno-json) is a standalone
|
||||
Go binary from the Kyverno project — a **separate runtime** from the
|
||||
K8s Kyverno admission controller. It applies Kyverno `ValidatingPolicy`
|
||||
resources to **any** JSON or YAML payload file via the `kj scan` CLI.
|
||||
Unlike the K8s Kyverno adapter (`adapters/kyverno/`), which only
|
||||
speaks to K8s manifests, kyverno-json evaluates consumer contracts,
|
||||
resolved Stack IR, terraform plan JSON, and even the merged PCR list
|
||||
itself (meta-policies).
|
||||
|
||||
## Install
|
||||
|
||||
```bash
|
||||
bash scripts/install-kyverno-json.sh
|
||||
# or directly:
|
||||
go install github.com/kyverno/kyverno-json/cmd/kj@latest
|
||||
kj version
|
||||
```
|
||||
|
||||
The platform functions without the binary — `is_configured()` returns
|
||||
`False` when `which kj` is absent → `evaluate()` returns a single
|
||||
`SKIPPED` PCR (`KJ_ENGINE_NOT_CONFIGURED`). The confidence signal
|
||||
proceeds with a neutral `policy` input (D-120 graceful degradation).
|
||||
|
||||
## Policy directory layout
|
||||
|
||||
```
|
||||
adapters/kyverno-json/policies/
|
||||
├── _smoke.json # round-trip smoke test
|
||||
├── contract/ # consumer contract JSON policies
|
||||
│ ├── require-id-pattern.json
|
||||
│ ├── require-env-in-enum.json
|
||||
│ ├── require-infrastructure-min-1.json
|
||||
│ └── forbid-unknown-fields.json
|
||||
├── stack-ir/ # resolved Stack IR policies
|
||||
│ ├── require-tagging-standard.json
|
||||
│ ├── forbid-public-ingress.json
|
||||
│ └── require-encryption-by-default.json
|
||||
├── plan-json/ # terraform show -json policies
|
||||
│ ├── forbid-plaintext-secrets.json
|
||||
│ ├── forbid-iam-wildcard.json
|
||||
│ └── require-kms-reference.json
|
||||
├── meta/ # policies over the merged PCR list
|
||||
│ ├── block-on-any-critical.json
|
||||
│ └── tagging-rules-agree.json
|
||||
└── regression/ # capability-inventory policies
|
||||
├── cap-013-adapter-dedup.json
|
||||
├── cap-023-metrics-collector.json
|
||||
└── cap-024-deck-structure.json
|
||||
```
|
||||
|
||||
## The four policy categories
|
||||
|
||||
1. **contract/** — over the consumer contract JSON (pre-resolve).
|
||||
2. **stack-ir/** — over the resolved Target Stack IR (post-resolve).
|
||||
3. **plan-json/** — over `terraform show -json` output (pipeline Step 5b).
|
||||
4. **meta/** — over the merged `list[PolicyCheckResult]` (meta-policies).
|
||||
5. **regression/** — over the capability-inventory JSON (declarative
|
||||
mirrors of `core/regression_verify.py`).
|
||||
|
||||
## Severity convention
|
||||
|
||||
kyverno-json does not natively assign severities. Each Nova policy
|
||||
declares its severity via a `metadata.annotations` field:
|
||||
|
||||
```yaml
|
||||
metadata:
|
||||
annotations:
|
||||
nova.cloudinit.dev/severity: high
|
||||
```
|
||||
|
||||
Valid values: `critical`, `high`, `medium`, `low`, `info` (default
|
||||
when absent).
|
||||
|
||||
## Engine enum reuse (D-116)
|
||||
|
||||
kyverno-json PCR records carry `engine: "kyverno"` (no new enum value).
|
||||
The `engine` field records the policy-engine *family*, not the specific
|
||||
binary. The K8s Kyverno adapter and the kyverno-json engine are
|
||||
distinguished by `ruleId` prefix (`KYVERNO_` vs `KJ_`) and `evidence`
|
||||
payload shape (`namespace`/`kind` vs `assertion`/`jmespath`).
|
||||
|
||||
## Schema path
|
||||
|
||||
The output records validate against
|
||||
[`schemas/policy_check_result.schema.json`](../../schemas/policy_check_result.schema.json)
|
||||
(`engine: "kyverno"` is in the enum). The confidence signal consumes
|
||||
the merged PCR list engine-agnostically.
|
||||
|
||||
## Swap boundary
|
||||
|
||||
The `PolicyEngine` protocol (`core/policy_engine.py`) is the swap
|
||||
boundary. The OPA-equivalent surface is documented in
|
||||
`.ciagent/RESEARCH.md` §4.2 — a future `OpaEngine` implements the same
|
||||
protocol without touching the confidence signal, the PCR schema, or
|
||||
the pipeline.
|
||||
@@ -0,0 +1,27 @@
|
||||
"""Nova kyverno-json adapter package (v1.25, REQ-294).
|
||||
|
||||
The directory name ``kyverno-json`` has a hyphen, so it is not a valid
|
||||
Python package name and cannot be imported via ``import
|
||||
adapters.kyverno-json``. The ``PolicyEngineRegistry`` loads the engine
|
||||
by file path (``importlib.util.spec_from_file_location``). This
|
||||
``__init__`` is a convenience for direct-script use and for ``pip
|
||||
install -e .`` style discovery if the package is ever renamed.
|
||||
"""
|
||||
|
||||
|
||||
def _load_engine():
|
||||
import importlib.util
|
||||
import os
|
||||
engine_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
|
||||
"kyverno_json_engine.py")
|
||||
spec = importlib.util.spec_from_file_location("kyverno_json_engine", engine_path)
|
||||
if spec is None or spec.loader is None:
|
||||
raise ImportError(f"could not load {engine_path}")
|
||||
mod = importlib.util.module_from_spec(spec)
|
||||
spec.loader.exec_module(mod)
|
||||
return mod.KyvernoJsonEngine
|
||||
|
||||
|
||||
KyvernoJsonEngine = _load_engine()
|
||||
|
||||
__all__ = ["KyvernoJsonEngine"]
|
||||
@@ -0,0 +1,470 @@
|
||||
"""Nova KyvernoJsonEngine (REQ-293, v1.25; fixed v1.26 P3 W0.5).
|
||||
|
||||
Implements the ``PolicyEngine`` protocol (``core/policy_engine.py``)
|
||||
by shelling to the ``kj`` CLI (``kyverno-json``). Translates native
|
||||
kyverno-json scan output to Nova ``PolicyCheckResult`` dicts
|
||||
(``schemas/policy_check_result.schema.json``).
|
||||
|
||||
Engine enum reuse (D-116): records carry ``engine: "kyverno"`` (no new
|
||||
enum value). The ``ruleId`` is prefixed ``KJ_<policy_name>`` to
|
||||
distinguish from the K8s Kyverno adapter's ``KYVERNO_`` prefix.
|
||||
|
||||
Severity (RESEARCH §2.6, G-Q10a): kyverno-json does not natively assign
|
||||
severities. Each Nova policy declares its severity via a
|
||||
``metadata.annotations["nova.cloudinit.dev/severity"]`` field. The
|
||||
engine reads this annotation from the loaded policy file (not from the
|
||||
scan result — the result carries the policy spec but the annotation is
|
||||
read here from disk) and applies it to every result that policy
|
||||
produces. Default when absent: ``"info"``.
|
||||
|
||||
Graceful degradation (D-120): ``is_configured()`` returns ``False`` when
|
||||
``which kj`` is absent → ``evaluate()`` returns a single SKIPPED PCR
|
||||
(``ruleId: KJ_ENGINE_NOT_CONFIGURED``). The platform functions without
|
||||
the binary.
|
||||
|
||||
Defensive parsing: any kyverno-json output that doesn't match the
|
||||
expected shape produces an ``error`` PCR, never an exception. The
|
||||
engine is read-only against a local policy dir + a temp payload file.
|
||||
|
||||
v1.26 P3 W0.5 fix — three substrate bugs uncovered once ``kj`` was
|
||||
actually installed (the v1.25 test suite ``pytest.skip``-masked them):
|
||||
|
||||
1. **``.json`` policy files are not loaded by ``kj`` v0.0.3.** The
|
||||
upstream policy loader (``pkg/policy/load.go``) uses
|
||||
``fileinfo.IsYaml()`` which only matches ``.yaml``/``.yml``
|
||||
extensions — ``.json`` files are silently skipped, yielding
|
||||
``evaluating N resources against 0 policies``. Nova policies are
|
||||
authored as ``.json`` (the ``TestPolicyFilesExist`` tests assert the
|
||||
``.json`` filenames). Fix: ``evaluate()`` materializes a temp policy
|
||||
dir that mirrors the source tree with every ``.json`` policy copied
|
||||
to a ``.yaml`` twin (JSON is a valid YAML subset — verified against
|
||||
``kj`` v0.0.3). The source ``.json`` files remain untouched.
|
||||
|
||||
2. **Bare-list output format.** ``kj scan --output json`` emits a bare
|
||||
JSON list at the top level (NOT ``{"results": [...]}``). Each entry
|
||||
has ``resource`` (the evaluated payload) + ``results`` (list of
|
||||
per-policy result objects, each carrying ``policy.metadata.name``,
|
||||
``rules[]`` with ``rule.name``, ``violations[]`` (present on fail),
|
||||
``error`` (string, present on policy-evaluation error)). The v1.25
|
||||
``_translate`` did ``out.get("results", [])`` on a dict — but
|
||||
``out`` is a list → returned ``[]`` → emitted a single
|
||||
``KJ_NO_RESULTS`` pass PCR. **This is why all failing fixtures showed
|
||||
0 fails.** Fix: ``_translate`` handles list (v0.0.3) and dict
|
||||
(future-proof) shapes.
|
||||
|
||||
3. **``validate`` wrapper + check syntax.** Documented in the policy
|
||||
files themselves (see the W0.5 policy edits). The engine itself does
|
||||
not enforce policy shape — it only translates ``kj`` output — so
|
||||
this fix lives in the policy ``.json`` files.
|
||||
"""
|
||||
|
||||
import datetime
|
||||
import json
|
||||
import os
|
||||
import shutil
|
||||
import subprocess
|
||||
import sys
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
from typing import Any, Union
|
||||
|
||||
import yaml
|
||||
|
||||
|
||||
Payload = Union[dict, list, str]
|
||||
|
||||
SEVERITY_DEFAULT = "info"
|
||||
SEVERITY_ANNOTATION = "nova.cloudinit.dev/severity"
|
||||
|
||||
RESULT_MAP = {
|
||||
"pass": "pass",
|
||||
"fail": "fail",
|
||||
"error": "error",
|
||||
"skip": "skipped",
|
||||
"skipped": "skipped",
|
||||
"warn": "skipped",
|
||||
"warning": "skipped",
|
||||
}
|
||||
|
||||
|
||||
def _iso8601_now() -> str:
|
||||
return datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
|
||||
|
||||
|
||||
def _which_kj() -> str | None:
|
||||
"""Return the path to ``kj`` if on PATH, else ``None``."""
|
||||
return shutil.which("kj")
|
||||
|
||||
|
||||
def _load_policy_severities(policy_dir: Path) -> dict[str, str]:
|
||||
"""Load each ``.json``/``.yaml``/``.yml`` policy in ``policy_dir``
|
||||
(non-recursive) and return ``{policy_name: severity}``.
|
||||
|
||||
kyverno-json policies are Kubernetes-style ``ValidatingPolicy``
|
||||
resources. The severity is read from
|
||||
``metadata.annotations["nova.cloudinit.dev/severity"]``. Policies
|
||||
in subdirectories (e.g. ``contract/``, ``stack-ir/``) are loaded
|
||||
when the caller passes that subdirectory as ``policy_dir``.
|
||||
"""
|
||||
severities: dict[str, str] = {}
|
||||
if not policy_dir.is_dir():
|
||||
return severities
|
||||
for entry in sorted(os.listdir(policy_dir)):
|
||||
if entry.startswith("_") or entry.startswith("."):
|
||||
continue
|
||||
full = policy_dir / entry
|
||||
if not full.is_file():
|
||||
continue
|
||||
if entry.endswith((".json", ".yaml", ".yml")):
|
||||
try:
|
||||
with open(full, "r", encoding="utf-8") as fh:
|
||||
doc = yaml.safe_load(fh)
|
||||
if not isinstance(doc, dict):
|
||||
continue
|
||||
name = doc.get("metadata", {}).get("name") or entry.rsplit(".", 1)[0]
|
||||
ann = doc.get("metadata", {}).get("annotations", {}) or {}
|
||||
sev = ann.get(SEVERITY_ANNOTATION, SEVERITY_DEFAULT)
|
||||
severities[name] = str(sev).lower()
|
||||
except Exception:
|
||||
continue
|
||||
return severities
|
||||
|
||||
|
||||
def _materialize_yaml_policy_dir(src: Path) -> tuple[Path, bool]:
|
||||
"""Mirror ``src`` (recursively) into a temp dir, copying every
|
||||
``.json`` policy to a ``.yaml`` twin and copying ``.yaml``/``.yml``
|
||||
files verbatim. Returns ``(temp_dir, created)``.
|
||||
|
||||
``kj`` v0.0.3's policy loader (``pkg/policy/load.go``) only matches
|
||||
``.yaml``/``.yml`` extensions — ``.json`` files are silently
|
||||
skipped. Nova policies are authored as ``.json`` (the
|
||||
``TestPolicyFilesExist`` tests assert the ``.json`` filenames, so
|
||||
they cannot be renamed in-place). JSON is a valid YAML subset, so
|
||||
a byte-for-byte copy with a ``.yaml`` extension loads cleanly.
|
||||
|
||||
``created`` is ``False`` when ``src`` contains no policy files at
|
||||
all (empty dir) — in that case the temp dir is still returned (the
|
||||
caller invokes ``kj`` against it and gets the no-results path).
|
||||
"""
|
||||
tmp = Path(tempfile.mkdtemp(prefix="nova-kj-pol-"))
|
||||
any_policy = False
|
||||
if src.is_dir():
|
||||
for root, _dirs, files in os.walk(src):
|
||||
rel = Path(root).relative_to(src)
|
||||
dest_root = tmp / rel
|
||||
dest_root.mkdir(parents=True, exist_ok=True)
|
||||
for fn in files:
|
||||
if fn.startswith(".") or fn.startswith("_"):
|
||||
continue
|
||||
src_file = Path(root) / fn
|
||||
if fn.endswith(".json"):
|
||||
dest_file = dest_root / (fn.rsplit(".", 1)[0] + ".yaml")
|
||||
shutil.copy2(src_file, dest_file)
|
||||
any_policy = True
|
||||
elif fn.endswith((".yaml", ".yml")):
|
||||
shutil.copy2(src_file, dest_root / fn)
|
||||
any_policy = True
|
||||
return tmp, any_policy
|
||||
|
||||
|
||||
def _skipped_not_configured(contract_id: str) -> dict:
|
||||
return {
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": "KJ_ENGINE_NOT_CONFIGURED",
|
||||
"severity": "info",
|
||||
"result": "skipped",
|
||||
"message": (
|
||||
"kyverno-json engine not configured — `which kj` returned no path. "
|
||||
"Install via scripts/install-kyverno-json.sh. The platform proceeds "
|
||||
"with a neutral SKIPPED policy input (is_configured() guard, D-120)."
|
||||
),
|
||||
"evidence": {},
|
||||
"resourceRef": "",
|
||||
}
|
||||
|
||||
|
||||
def _error_pcr(contract_id: str, message: str) -> dict:
|
||||
return {
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": "KJ_ENGINE_ERROR",
|
||||
"severity": "info",
|
||||
"result": "error",
|
||||
"message": message,
|
||||
"evidence": {},
|
||||
"resourceRef": "",
|
||||
}
|
||||
|
||||
|
||||
def _no_results_pass(contract_id: str) -> dict:
|
||||
"""No result entries — emit a single pass PCR so the confidence
|
||||
signal's policy input is non-empty (a non-empty list of passes →
|
||||
score 1.0)."""
|
||||
return {
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": "KJ_NO_RESULTS",
|
||||
"severity": "info",
|
||||
"result": "pass",
|
||||
"message": "kyverno-json scan produced no result entries (all policies passed or no match).",
|
||||
"evidence": {},
|
||||
"resourceRef": "",
|
||||
}
|
||||
|
||||
|
||||
class KyvernoJsonEngine:
|
||||
"""``PolicyEngine`` impl that shells to the ``kj`` CLI."""
|
||||
|
||||
name = "kyverno-json"
|
||||
|
||||
def is_configured(self) -> bool:
|
||||
return _which_kj() is not None
|
||||
|
||||
def evaluate(self, payload: Payload, policy_dir: Path,
|
||||
contract_id: str) -> list[dict]:
|
||||
if not self.is_configured():
|
||||
return [_skipped_not_configured(contract_id)]
|
||||
kj = _which_kj()
|
||||
policy_dir = Path(policy_dir)
|
||||
if not policy_dir.is_dir():
|
||||
return [_error_pcr(
|
||||
contract_id,
|
||||
f"kyverno-json policy dir not found: {policy_dir}",
|
||||
)]
|
||||
severities = _load_policy_severities(policy_dir)
|
||||
# kj v0.0.3 only loads .yaml/.yml policy files. Mirror the tree
|
||||
# to a temp dir with .json policies copied to .yaml twins.
|
||||
yaml_dir, _any_policy = _materialize_yaml_policy_dir(policy_dir)
|
||||
# Write payload to temp file (kj scan --payload expects a file path).
|
||||
payload_tmp = tempfile.NamedTemporaryFile(
|
||||
mode="w", suffix=".json", delete=False, encoding="utf-8"
|
||||
)
|
||||
try:
|
||||
json.dump(payload, payload_tmp)
|
||||
payload_tmp.flush()
|
||||
payload_tmp.close()
|
||||
cmd = [
|
||||
kj, "scan",
|
||||
"--policy", str(yaml_dir),
|
||||
"--payload", payload_tmp.name,
|
||||
"--output", "json",
|
||||
]
|
||||
try:
|
||||
proc = subprocess.run(
|
||||
cmd, capture_output=True, text=True, timeout=60,
|
||||
)
|
||||
except subprocess.TimeoutExpired:
|
||||
return [_error_pcr(contract_id, "kyverno-json scan timed out (60s)")]
|
||||
if proc.returncode not in (0, 1):
|
||||
return [_error_pcr(
|
||||
contract_id,
|
||||
f"kyverno-json scan exited {proc.returncode}: {proc.stderr[:200]}",
|
||||
)]
|
||||
try:
|
||||
out = json.loads(proc.stdout) if proc.stdout.strip() else []
|
||||
except json.JSONDecodeError as e:
|
||||
return [_error_pcr(
|
||||
contract_id,
|
||||
f"kyverno-json output not JSON: {e}",
|
||||
)]
|
||||
return self._translate(out, contract_id, severities)
|
||||
finally:
|
||||
try:
|
||||
os.unlink(payload_tmp.name)
|
||||
except OSError:
|
||||
pass
|
||||
shutil.rmtree(yaml_dir, ignore_errors=True)
|
||||
|
||||
def _translate(self, out: Any, contract_id: str,
|
||||
severities: dict[str, str]) -> list[dict]:
|
||||
# kj v0.0.3 emits a BARE JSON LIST at the top level: each entry
|
||||
# has `resource` (the evaluated payload) + `results` (list of
|
||||
# per-policy result objects). Future-proof: also accept the
|
||||
# legacy {"results": [...]} dict shape.
|
||||
if isinstance(out, list):
|
||||
entries = out
|
||||
elif isinstance(out, dict):
|
||||
entries = out.get("results", [])
|
||||
if not isinstance(entries, list):
|
||||
entries = []
|
||||
else:
|
||||
entries = []
|
||||
pcrs: list[dict] = []
|
||||
for entry in entries:
|
||||
if not isinstance(entry, dict):
|
||||
continue
|
||||
resource = entry.get("resource", {})
|
||||
results = entry.get("results", [])
|
||||
if not isinstance(results, list):
|
||||
results = []
|
||||
for pol_result in results:
|
||||
if not isinstance(pol_result, dict):
|
||||
continue
|
||||
policy_obj = pol_result.get("policy", {}) or {}
|
||||
policy_name = (
|
||||
policy_obj.get("metadata", {}).get("name") if isinstance(policy_obj, dict)
|
||||
else None
|
||||
) or "UNKNOWN"
|
||||
severity = severities.get(policy_name, SEVERITY_DEFAULT)
|
||||
rules = pol_result.get("rules", [])
|
||||
if not isinstance(rules, list):
|
||||
rules = []
|
||||
for rule_entry in rules:
|
||||
if not isinstance(rule_entry, dict):
|
||||
continue
|
||||
rule_obj = rule_entry.get("rule", {}) or {}
|
||||
rule_name = rule_obj.get("name", "") if isinstance(rule_obj, dict) else ""
|
||||
rule_id = f"KJ_{policy_name}"
|
||||
if rule_name:
|
||||
rule_id = f"{rule_id}/{rule_name}"
|
||||
violations = rule_entry.get("violations")
|
||||
error_str = rule_entry.get("error")
|
||||
if isinstance(violations, list) and violations:
|
||||
# Fail: build a message from the violations' errors.
|
||||
msg_parts: list[str] = []
|
||||
for v in violations:
|
||||
if not isinstance(v, dict):
|
||||
continue
|
||||
for err in v.get("errors", []) or []:
|
||||
if not isinstance(err, dict):
|
||||
continue
|
||||
field = err.get("field", "")
|
||||
detail = err.get("detail", "")
|
||||
value = err.get("value", "")
|
||||
msg_parts.append(
|
||||
f"{field}: value={value!r} detail={detail}"
|
||||
)
|
||||
message = "; ".join(msg_parts) if msg_parts else "policy rule failed"
|
||||
pcrs.append({
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": rule_id,
|
||||
"severity": severity,
|
||||
"result": "fail",
|
||||
"message": message,
|
||||
"evidence": {
|
||||
"resource": resource,
|
||||
"policy": policy_name,
|
||||
"rule": rule_name,
|
||||
"violations": violations,
|
||||
},
|
||||
"resourceRef": _resource_ref(resource),
|
||||
})
|
||||
elif isinstance(error_str, str) and error_str:
|
||||
# Policy-evaluation error (e.g. bad JMESPath).
|
||||
pcrs.append({
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": rule_id,
|
||||
"severity": severity,
|
||||
"result": "error",
|
||||
"message": error_str,
|
||||
"evidence": {
|
||||
"resource": resource,
|
||||
"policy": policy_name,
|
||||
"rule": rule_name,
|
||||
},
|
||||
"resourceRef": _resource_ref(resource),
|
||||
})
|
||||
else:
|
||||
# Pass: no violations, no error.
|
||||
pcrs.append({
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": rule_id,
|
||||
"severity": severity,
|
||||
"result": "pass",
|
||||
"message": "",
|
||||
"evidence": {
|
||||
"resource": resource,
|
||||
"policy": policy_name,
|
||||
"rule": rule_name,
|
||||
},
|
||||
"resourceRef": _resource_ref(resource),
|
||||
})
|
||||
if not pcrs:
|
||||
pcrs.append(_no_results_pass(contract_id))
|
||||
return pcrs
|
||||
|
||||
|
||||
def _resource_ref(resource: Any) -> str:
|
||||
"""Best-effort resource ref from the evaluated payload."""
|
||||
if isinstance(resource, dict):
|
||||
for key in ("id", "name", "address"):
|
||||
v = resource.get(key)
|
||||
if isinstance(v, str) and v:
|
||||
return v
|
||||
return ""
|
||||
|
||||
|
||||
# --- Legacy _to_pcr kept for the existing TestToPcr unit tests ---
|
||||
# (test_kyverno_json_engine.py::TestToPcr constructs flat `entry`
|
||||
# dicts with `policy`/`rule`/`result`/`message`/`resource` keys and
|
||||
# asserts the translated PCR shape. The production _translate path no
|
||||
# longer calls this helper — it inlines the translation against the
|
||||
# real kj v0.0.3 nested output — but the unit tests pin the helper's
|
||||
# contract, so it stays.)
|
||||
|
||||
|
||||
def _to_pcr(entry: dict, contract_id: str, severity: str) -> dict:
|
||||
"""Translate a flat kyverno-json scan result entry to a PCR dict.
|
||||
|
||||
Legacy shape (kept for unit-test backwards compatibility): the
|
||||
entry is a flat dict with ``policy``/``rule``/``result``/``message``/
|
||||
``resource`` string keys. The production ``_translate`` path no
|
||||
longer calls this — it inlines translation against the real kj
|
||||
v0.0.3 nested ``resource``+``results``+``rules`` shape — but the
|
||||
``TestToPcr`` unit tests pin this contract.
|
||||
"""
|
||||
policy_name = entry.get("policy", "") or "UNKNOWN"
|
||||
rule_name = entry.get("rule", "") or ""
|
||||
rule_id = f"KJ_{policy_name}"
|
||||
if rule_name:
|
||||
rule_id = f"{rule_id}/{rule_name}"
|
||||
result_raw = entry.get("result", "skip")
|
||||
result = RESULT_MAP.get(str(result_raw).lower(), "error")
|
||||
message = entry.get("message", "") or ""
|
||||
resource = entry.get("resource", "")
|
||||
if not resource and entry.get("name"):
|
||||
kind = entry.get("kind", "")
|
||||
ns = entry.get("namespace", "")
|
||||
resource = f"{kind}/{ns}/{entry.get('name')}" if kind else entry.get("name", "")
|
||||
return {
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": rule_id,
|
||||
"severity": severity,
|
||||
"result": result,
|
||||
"message": message,
|
||||
"evidence": {
|
||||
"resource": resource,
|
||||
"policy": policy_name,
|
||||
"rule": rule_name,
|
||||
"namespace": entry.get("namespace", ""),
|
||||
"kind": entry.get("kind", ""),
|
||||
"name": entry.get("name", ""),
|
||||
},
|
||||
"resourceRef": resource,
|
||||
}
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
if len(sys.argv) < 4:
|
||||
print(
|
||||
"usage: kyverno_json_engine.py <payload.json> <policy_dir> <contract-id>",
|
||||
file=sys.stderr,
|
||||
)
|
||||
sys.exit(2)
|
||||
with open(sys.argv[1], "r", encoding="utf-8") as fh:
|
||||
pl = json.load(fh)
|
||||
engine = KyvernoJsonEngine()
|
||||
out = engine.evaluate(pl, Path(sys.argv[2]), sys.argv[3])
|
||||
print(json.dumps(out, indent=2))
|
||||
@@ -0,0 +1,29 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "require-contract-id",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "high",
|
||||
"title.policy.kyverno.io": "Require contract id"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "require-id",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"id": {
|
||||
"(regex_match('^[a-z][a-z0-9-]{2,5}$', @))": true
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,30 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "forbid-unknown-fields",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "low",
|
||||
"title.policy.kyverno.io": "Contract has only schema-allowed fields"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-unknown-fields",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"(length(keys(@)) == `4`)": true,
|
||||
"keys(@)": {
|
||||
"(contains(['id','name','environment','infrastructure'], @))": true
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,29 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "require-env-in-enum",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "high",
|
||||
"title.policy.kyverno.io": "Contract environment is one of dev/qa/prod/dr"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "env-enum",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"environment": {
|
||||
"(contains(['dev','qa','prod','dr'], @))": true
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,29 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "require-id-pattern",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "high",
|
||||
"title.policy.kyverno.io": "Contract id matches operational acronym pattern"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "id-pattern",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"id": {
|
||||
"(regex_match('^[a-z][a-z0-9-]{2,5}$', @))": true
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,29 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "require-infrastructure-min-1",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "medium",
|
||||
"title.policy.kyverno.io": "Contract declares at least one infrastructure entry"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "infra-min-1",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"infrastructure": {
|
||||
"(length(keys(@)) > `0`)": true
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,27 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "block-on-any-critical",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "critical",
|
||||
"title.policy.kyverno.io": "Block on any critical-fail policy result (declarative source of truth)"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-critical-fail",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"(severity == 'critical' && result == 'fail')": false
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,32 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "tagging-rules-agree",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "medium",
|
||||
"title.policy.kyverno.io": "Checkov NOVA_TAG_NAMING and kj KJ_REQUIRE_TAGGING_STANDARD agree per resource"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-tagging-divergence",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"(ruleId == 'NOVA_TAG_NAMING' && result == 'fail')": false
|
||||
}
|
||||
},
|
||||
{
|
||||
"check": {
|
||||
"(ruleId == 'KJ_REQUIRE_TAGGING_STANDARD' && result == 'fail')": false
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,27 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "no-placeholder-account",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "critical",
|
||||
"title.policy.kyverno.io": "Env does not use a placeholder AWS account id"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-placeholder-account",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"(account_id == '000000000000')": false
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,51 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "forbid-iam-wildcard",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "high",
|
||||
"title.policy.kyverno.io": "No IAM wildcard Actions or Resources"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-wildcard-action",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"planned_values": {
|
||||
"root_module": {
|
||||
"~.resources": {
|
||||
"(type == 'aws_iam_policy' && contains(values.policy_document.Statement[].Action, '*'))": false
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "no-wildcard-resource",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"planned_values": {
|
||||
"root_module": {
|
||||
"~.resources": {
|
||||
"(type == 'aws_iam_policy' && contains(values.policy_document.Statement[].Resource, '*'))": false
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,33 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "forbid-plaintext-secrets",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "high",
|
||||
"title.policy.kyverno.io": "No plaintext secrets in the terraform plan"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-plaintext-db-password",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"planned_values": {
|
||||
"root_module": {
|
||||
"~.resources": {
|
||||
"(type == 'aws_db_instance' && contains(keys(values), 'password') && !contains(['${...}', ''], values.password))": false
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,33 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "require-kms-reference",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "medium",
|
||||
"title.policy.kyverno.io": "KMS keys referenced by alias, not inline key material"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "kms-by-alias",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"planned_values": {
|
||||
"root_module": {
|
||||
"~.resources": {
|
||||
"(type == 'aws_kms_key' && !contains(keys(values), 'key_id') && !contains(keys(values), 'kms_key_id'))": false
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,27 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "cap-013-adapter-dedup",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "medium",
|
||||
"title.policy.kyverno.io": "No duplicate adapter registrations (CAP-013 declarative mirror)"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-duplicate-adapters",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"(max(map(&length(@), values(group_by(adapters, &@)))) == `1`)": true
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,29 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "cap-023-metrics-collector",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "medium",
|
||||
"title.policy.kyverno.io": "Every metric has a grounded/derived/deferred status (CAP-023 declarative mirror)"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "every-metric-has-status",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"~.metrics": {
|
||||
"(contains(['grounded','derived','deferred'], status))": true
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,32 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "cap-024-deck-structure",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "low",
|
||||
"title.policy.kyverno.io": "Deck structure matches the documented 4-beat arc (CAP-024 declarative mirror)"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "deck-has-4-beats",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"deck": {
|
||||
"beats": {
|
||||
"(length(@) >= `4`)": true,
|
||||
"(contains(@, 'Problem') && contains(@, 'Solution') && contains(@, 'Proof') && contains(@, 'Roadmap+Ask'))": true
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,27 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "all-matches-committed",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "critical",
|
||||
"title.policy.kyverno.io": "All settlement matches are committed (finalized)"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "all-matches-committed",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"(all_committed)": true
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,30 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "forbid-public-ingress",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "high",
|
||||
"title.policy.kyverno.io": "No resource has public ingress enabled"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "no-public-ingress",
|
||||
"identifier": "id",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"~.resources": {
|
||||
"(inputs.public_ingress || `false`)": false
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,45 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "require-encryption-by-default",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "high",
|
||||
"title.policy.kyverno.io": "S3 buckets and EBS volumes carry encryption config"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "s3-encryption",
|
||||
"identifier": "id",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"~.resources": {
|
||||
"(type == 'aws:s3:bucket' && !(contains(keys(inputs), 'bucket_encryption') || contains(keys(inputs), 'kms_key_id')))": false
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "ebs-encryption",
|
||||
"identifier": "id",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"~.resources": {
|
||||
"(type == 'aws:ebs:volume' && !(contains(keys(inputs), 'encrypted') || contains(keys(inputs), 'kms_key_id')))": false
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,33 @@
|
||||
{
|
||||
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||
"kind": "ValidatingPolicy",
|
||||
"metadata": {
|
||||
"name": "require-tagging-standard",
|
||||
"annotations": {
|
||||
"nova.cloudinit.dev/severity": "medium",
|
||||
"title.policy.kyverno.io": "All resources carry required Nova tags"
|
||||
}
|
||||
},
|
||||
"spec": {
|
||||
"rules": [
|
||||
{
|
||||
"name": "require-nova-tags",
|
||||
"identifier": "id",
|
||||
"assert": {
|
||||
"all": [
|
||||
{
|
||||
"check": {
|
||||
"~.resources": {
|
||||
"(contains(keys(inputs.tags || `{}`), 'nova:owner'))": true,
|
||||
"(contains(keys(inputs.tags || `{}`), 'nova:contract'))": true,
|
||||
"(contains(keys(inputs.tags || `{}`), 'nova:environment'))": true,
|
||||
"(contains(keys(inputs.tags || `{}`), 'nova:cost-center'))": true
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -30,6 +30,37 @@ def _module_name(resource):
|
||||
return resource.get("module", "").split("@")[0]
|
||||
|
||||
|
||||
def _load_env_json(env_name, repo_root):
|
||||
"""Load core/environments/<env_name>.json → dict (P03 W3, REQ-319).
|
||||
|
||||
Returns {} if the file is absent (the adapter falls back to the
|
||||
computed state-bucket name). Sources env.state_backend.bucket +
|
||||
env.account_id + env.region for the S3 backend block.
|
||||
"""
|
||||
env_path = os.path.join(repo_root, "core", "environments", f"{env_name}.json")
|
||||
if not os.path.isfile(env_path):
|
||||
return {}
|
||||
with open(env_path, "r") as fh:
|
||||
return json.load(fh)
|
||||
|
||||
|
||||
def _resolve_state_bucket(env_json, region):
|
||||
"""Resolve the S3 state-backend bucket name (P03 W3, REQ-319).
|
||||
|
||||
Precedence: (1) env.state_backend.bucket when present + non-empty;
|
||||
(2) nova-tfstate-{account_id}-{region} from env.account_id + region
|
||||
(backwards-compat); (3) nova-tfstate-581513795199-{region} when
|
||||
account_id is absent (the only real account — bootstrap bucket).
|
||||
The env JSON is authoritative; NOVA_AWS_ACCOUNT_ID is no longer
|
||||
consulted for the bucket name.
|
||||
"""
|
||||
bucket = (env_json.get("state_backend") or {}).get("bucket")
|
||||
if bucket:
|
||||
return bucket
|
||||
account_id = env_json.get("account_id") or "581513795199"
|
||||
return f"nova-tfstate-{account_id}-{region}"
|
||||
|
||||
|
||||
def _ref_expr(value, data_source_names=None, id_remap=None):
|
||||
"""Translate `ref:<rid>.<output>` → `module.<rid>.<output>` (or
|
||||
`data.terraform_remote_state.platform.outputs.<output>` for data
|
||||
@@ -108,13 +139,20 @@ def adapt(stack_instance, out_dir):
|
||||
resources = stack_instance.get("resources", [])
|
||||
stack_outputs = stack_instance.get("outputs", {})
|
||||
|
||||
region = next((r["inputs"]["region"] for r in resources if "region" in r.get("inputs", {})), "us-east-1")
|
||||
providers_tf = f'provider "aws" {{\n region = "{region}"\n}}\n'
|
||||
|
||||
stack_name = stack.get("name", "spike")
|
||||
environment = stack.get("environment", "dev")
|
||||
account_id = env.get_env("AWS_ACCOUNT_ID", "581513795199")
|
||||
state_bucket = f"nova-tfstate-{account_id}-us-east-1"
|
||||
# P03 W3 (REQ-319): state backend bucket + account_id + region come
|
||||
# from the env onboarding JSON (source of truth post-REQ-319). Bucket
|
||||
# = env.state_backend.bucket when present (fallback to the computed
|
||||
# nova-tfstate-{account_id}-{region} pattern for backwards compat).
|
||||
env_json = _load_env_json(environment, repo_root)
|
||||
region = env_json.get("region") or next(
|
||||
(r["inputs"]["region"] for r in resources if "region" in r.get("inputs", {})),
|
||||
"us-east-1",
|
||||
)
|
||||
state_bucket = _resolve_state_bucket(env_json, region)
|
||||
providers_tf = f'provider "aws" {{\n region = "{region}"\n}}\n'
|
||||
|
||||
# State key is env-scoped (v1.24 REQ-287): the {environment} segment lets
|
||||
# the env-transition detect-and-destroy step target the PRIOR env's state
|
||||
# without affecting the new env. No orphan path on environment promotion.
|
||||
@@ -130,7 +168,7 @@ def adapt(stack_instance, out_dir):
|
||||
' backend "s3" {\n'
|
||||
f' bucket = "{state_bucket}"\n'
|
||||
f' key = "spike/{stack_name}/{environment}/terraform.tfstate"\n'
|
||||
' region = "us-east-1"\n'
|
||||
f' region = "{region}"\n'
|
||||
' }\n'
|
||||
'}\n'
|
||||
)
|
||||
@@ -145,7 +183,7 @@ def adapt(stack_instance, out_dir):
|
||||
' config = {\n'
|
||||
f' bucket = "{state_bucket}"\n'
|
||||
f' key = "{remote_state_key}"\n'
|
||||
' region = "us-east-1"\n'
|
||||
f' region = "{region}"\n'
|
||||
' }\n'
|
||||
'}\n'
|
||||
)
|
||||
|
||||
+33
-10
@@ -144,6 +144,7 @@ def compute(contract_id: str, environment: str,
|
||||
penalty = 0.0
|
||||
policy_input = inputs.get("policy")
|
||||
pcrs = policy_input if isinstance(policy_input, list) else []
|
||||
critical_override = False
|
||||
for pcr in pcrs:
|
||||
if not isinstance(pcr, dict):
|
||||
continue
|
||||
@@ -152,20 +153,31 @@ def compute(contract_id: str, environment: str,
|
||||
sev = pcr.get("severity")
|
||||
p = PENALTY.get(sev, 0.0)
|
||||
if p is None:
|
||||
return Signal(0.0, "block", per_input,
|
||||
reasons + [f"CRITICAL_OVERRIDE:{pcr.get('ruleId','?')}"])
|
||||
# Critical PCR hard override: score = 0, band = block.
|
||||
# Do NOT early-return — fall through to the event emission
|
||||
# block below so the SPEC §5.8 evidence stream
|
||||
# (confidence.computed -> ai.decision.made -> ...) is complete
|
||||
# even on a critical override (REQ-318: a critical PCR is a
|
||||
# confidence-driven escalation and must carry escalation_reason).
|
||||
reasons.append(f"CRITICAL_OVERRIDE:{pcr.get('ruleId','?')}")
|
||||
critical_override = True
|
||||
break
|
||||
penalty += p
|
||||
|
||||
score = max(0.0, min(1.0, base - penalty))
|
||||
threshold = THRESHOLDS[environment]
|
||||
if score >= threshold:
|
||||
band = "pass"
|
||||
elif score < threshold - 0.10:
|
||||
if critical_override:
|
||||
score = 0.0
|
||||
band = "block"
|
||||
else:
|
||||
band = "warn"
|
||||
if environment == "dev" and band == "warn":
|
||||
band = "block"
|
||||
score = max(0.0, min(1.0, base - penalty))
|
||||
threshold = THRESHOLDS[environment]
|
||||
if score >= threshold:
|
||||
band = "pass"
|
||||
elif score < threshold - 0.10:
|
||||
band = "block"
|
||||
else:
|
||||
band = "warn"
|
||||
if environment == "dev" and band == "warn":
|
||||
band = "block"
|
||||
signal = Signal(score, band, per_input, reasons)
|
||||
|
||||
# Emit nova.confidence.computed + nova.ai.decision.made events (D-122).
|
||||
@@ -184,6 +196,17 @@ def compute(contract_id: str, environment: str,
|
||||
"human_override": band == "block",
|
||||
"threshold": THRESHOLDS[environment],
|
||||
}
|
||||
# REQ-318 (SPEC §5.8): on a `block` band, carry escalation_reason.
|
||||
# In v1.26 the only value is "confidence" — a block is always
|
||||
# confidence-driven (the score fell below threshold OR a critical
|
||||
# PCR fired a hard override). Future milestones may add "policy"
|
||||
# (a critical PCR that is not confidence-scored); leave the door
|
||||
# open but only emit "confidence" now. On pass/warn bands the
|
||||
# field is ABSENT (escalation_reason is only meaningful on a
|
||||
# block — it is the Post-Pilot Human Escalation Frequency
|
||||
# denominator).
|
||||
if band == "block":
|
||||
decision_data["escalation_reason"] = "confidence"
|
||||
decision_event = make_event("nova.ai.decision.made", run_id, environment, decision_data,
|
||||
contract_id=contract_id, actor_type="confidence-gate",
|
||||
actor_id="confidence_signal")
|
||||
|
||||
@@ -488,6 +488,25 @@ def resolve(contract_path, repo_root=None, environment_override=None):
|
||||
# Validate contract against schema
|
||||
jsonschema.validate(contract, contract_schema)
|
||||
|
||||
# v1.25 (REQ-296): pre-resolve policy evaluation — run the active
|
||||
# PolicyEngine over the contract dict with the contract/ policy
|
||||
# dir BEFORE resolving. Failures feed the `policyResults` on the
|
||||
# stack instance (the confidence signal's `policy` input). The
|
||||
# resolver does NOT exit on policy failure — the confidence signal
|
||||
# decides the gate (consistent with the existing --soft-fail
|
||||
# Checkov pattern).
|
||||
contract_pcrs: list = []
|
||||
try:
|
||||
from core.policy_engine import get_engine, get_policy_root
|
||||
_engine = get_engine()
|
||||
_policy_root = get_policy_root()
|
||||
contract_pcrs = _engine.evaluate(
|
||||
contract, _policy_root / "contract", contract.get("id", "unknown")
|
||||
)
|
||||
except Exception:
|
||||
# Policy evaluation must never break the resolver.
|
||||
contract_pcrs = []
|
||||
|
||||
# Interpolation (D-081): expand ${env.<field>} + ${contract.<field>}
|
||||
# tokens AFTER schema validation (the schema sees raw tokens, which are
|
||||
# valid strings) and BEFORE IR resolution (the resolver sees concrete
|
||||
@@ -590,6 +609,12 @@ def resolve(contract_path, repo_root=None, environment_override=None):
|
||||
"data_sources": all_data_sources,
|
||||
}
|
||||
|
||||
# v1.25 (REQ-296): attach the pre-resolve contract-policy PCRs to
|
||||
# the stack instance. The post-resolve stack-IR PCRs are appended
|
||||
# after stack-schema validation (below).
|
||||
if contract_pcrs:
|
||||
stack_instance["policyResults"] = list(contract_pcrs)
|
||||
|
||||
# Add the human-readable title
|
||||
if contract.get("name"):
|
||||
stack_instance["stack"]["title"] = contract["name"]
|
||||
@@ -606,6 +631,28 @@ def resolve(contract_path, repo_root=None, environment_override=None):
|
||||
stack_schema = _load_schema(os.path.join(repo_root, "schemas", "stack.schema.json"))
|
||||
jsonschema.validate(stack_instance, stack_schema)
|
||||
|
||||
# v1.25 (REQ-298): post-resolve policy evaluation — run the active
|
||||
# PolicyEngine over the resolved Stack IR with the stack-ir/ policy
|
||||
# dir. The resulting PCRs are appended to the contract-policy PCRs
|
||||
# on the stack instance (additive — the resolver's return value
|
||||
# shape and exceptions are unchanged). The confidence signal
|
||||
# consumes the merged list as its `policy` input.
|
||||
try:
|
||||
from core.policy_engine import get_engine, get_policy_root
|
||||
engine = get_engine()
|
||||
policy_root = get_policy_root()
|
||||
stack_ir_pcrs = engine.evaluate(
|
||||
stack_instance, policy_root / "stack-ir", contract.get("id", "unknown")
|
||||
)
|
||||
stack_instance.setdefault("policyResults", []).extend(stack_ir_pcrs)
|
||||
except Exception:
|
||||
# Policy evaluation must never break the resolver — the
|
||||
# confidence signal decides the gate. A failure here means the
|
||||
# engine is misconfigured; the contract PCRs (if any) are still
|
||||
# present, and the confidence signal proceeds with whatever
|
||||
# `policy` input it receives (possibly empty → 0.5 neutral).
|
||||
pass
|
||||
|
||||
return stack_instance
|
||||
|
||||
|
||||
|
||||
@@ -1,10 +1,10 @@
|
||||
{
|
||||
"name": "dev",
|
||||
"description": "Default platform-managed dev environment for onboarding demos.",
|
||||
"account_id": "000000000000",
|
||||
"account_id": "581513795199",
|
||||
"region": "us-east-1",
|
||||
"state_backend": {
|
||||
"bucket": "acdl-dev-state",
|
||||
"bucket": "nova-tfstate-581513795199-us-east-1",
|
||||
"lock_table": "acdl-dev-locks"
|
||||
},
|
||||
"network": {
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
"account_id": "000000000000",
|
||||
"region": "us-east-1",
|
||||
"state_backend": {
|
||||
"bucket": "acdl-dr-state",
|
||||
"bucket": "nova-tfstate-000000000000-us-east-1",
|
||||
"lock_table": "acdl-dr-locks"
|
||||
},
|
||||
"network": {
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
"account_id": "000000000000",
|
||||
"region": "us-east-1",
|
||||
"state_backend": {
|
||||
"bucket": "acdl-prod-state",
|
||||
"bucket": "nova-tfstate-000000000000-us-east-1",
|
||||
"lock_table": "acdl-prod-locks"
|
||||
},
|
||||
"network": {
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
"account_id": "000000000000",
|
||||
"region": "us-east-1",
|
||||
"state_backend": {
|
||||
"bucket": "acdl-qa-state",
|
||||
"bucket": "nova-tfstate-000000000000-us-east-1",
|
||||
"lock_table": "acdl-qa-locks"
|
||||
},
|
||||
"network": {
|
||||
|
||||
@@ -54,7 +54,8 @@ def _init_store(db_path=None):
|
||||
confidence_band TEXT,
|
||||
hitl_block INTEGER,
|
||||
cost_estimate_usd REAL,
|
||||
decision_id TEXT
|
||||
decision_id TEXT,
|
||||
escalation_reason TEXT
|
||||
);
|
||||
|
||||
CREATE TABLE IF NOT EXISTS fact_capability (
|
||||
@@ -110,7 +111,9 @@ def _init_store(db_path=None):
|
||||
confidence REAL,
|
||||
alternatives TEXT,
|
||||
human_override INTEGER,
|
||||
escalation_reason TEXT,
|
||||
outcome TEXT,
|
||||
backfilled_at TEXT,
|
||||
event_time TEXT,
|
||||
PRIMARY KEY (decision_id)
|
||||
);
|
||||
@@ -217,14 +220,15 @@ def collect_run_manifests(db_path=None, runs_dir=None):
|
||||
INSERT OR REPLACE INTO fact_run
|
||||
(run_id, contract_id, environment, started_at, completed_at,
|
||||
exit_code, outcome, confidence_score, confidence_band,
|
||||
hitl_block, cost_estimate_usd, decision_id)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
|
||||
hitl_block, cost_estimate_usd, decision_id, escalation_reason)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
|
||||
""", (run_id, manifest.get("contract_id", ""), manifest.get("environment", ""),
|
||||
manifest.get("started_at", ""), manifest.get("completed_at", ""),
|
||||
manifest.get("exit_code", 0), manifest.get("outcome", ""),
|
||||
conf.get("score", 0), conf.get("band", ""),
|
||||
1 if hitl.get("block") else 0,
|
||||
manifest.get("cost_estimate_usd", 0), manifest.get("decision_id", "")))
|
||||
manifest.get("cost_estimate_usd", 0), manifest.get("decision_id", ""),
|
||||
manifest.get("escalation_reason")))
|
||||
count += 1
|
||||
conn.commit()
|
||||
conn.close()
|
||||
@@ -232,7 +236,16 @@ def collect_run_manifests(db_path=None, runs_dir=None):
|
||||
|
||||
|
||||
def collect_decision_ledger(db_path=None, ledger_db=None):
|
||||
"""Read the Decision Ledger SQLite → fact_decision."""
|
||||
"""Read the Decision Ledger SQLite → fact_decision.
|
||||
|
||||
REQ-317: preserves a backfilled outcome. The ledger is append-only
|
||||
and the `nova.ai.decision.made` event always carries outcome=pending
|
||||
(it is emitted before apply). Once `outcome_backfill.backfill()` has
|
||||
transitioned the `fact_decision` row to succeeded/failed, a re-run of
|
||||
the collector must NOT clobber it back to pending. We therefore
|
||||
coalesce: if the existing row has a non-pending outcome, keep it +
|
||||
its backfilled_at; otherwise write pending (the event default).
|
||||
"""
|
||||
if db_path is None:
|
||||
db_path = _STORE_PATH
|
||||
if ledger_db is None:
|
||||
@@ -251,15 +264,27 @@ def collect_decision_ledger(db_path=None, ledger_db=None):
|
||||
payload = json.loads(payload_json)
|
||||
data = payload.get("data", {})
|
||||
decision_id = data.get("decision_id", run_id)
|
||||
# Preserve a backfilled outcome across collector re-runs (REQ-317).
|
||||
existing = conn.execute(
|
||||
"SELECT outcome, backfilled_at FROM fact_decision WHERE decision_id = ?",
|
||||
(decision_id,),
|
||||
).fetchone()
|
||||
if existing and existing[0] and existing[0] != "pending":
|
||||
outcome = existing[0]
|
||||
backfilled_at = existing[1]
|
||||
else:
|
||||
outcome = data.get("outcome", "pending")
|
||||
backfilled_at = data.get("backfilled_at")
|
||||
conn.execute("""
|
||||
INSERT OR REPLACE INTO fact_decision
|
||||
(decision_id, run_id, chosen_action, confidence, alternatives,
|
||||
human_override, outcome, event_time)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?)
|
||||
human_override, escalation_reason, outcome, backfilled_at, event_time)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
|
||||
""", (decision_id, run_id, data.get("chosen_action", ""),
|
||||
data.get("confidence", 0), json.dumps(data.get("alternatives", {})),
|
||||
1 if data.get("human_override") else 0,
|
||||
data.get("outcome", "pending"), event_time))
|
||||
data.get("escalation_reason"),
|
||||
outcome, backfilled_at, event_time))
|
||||
count += 1
|
||||
conn.commit()
|
||||
conn.close()
|
||||
|
||||
@@ -224,12 +224,16 @@ def replay_run(run_id, db_path=None):
|
||||
line = f" [{e['seq']}] {e['event_time']} {etype}"
|
||||
if etype == "nova.ai.decision.made":
|
||||
line += f" confidence={data.get('confidence', '?')} band={data.get('chosen_action', '?')} override={data.get('human_override', '?')}"
|
||||
if data.get("escalation_reason"):
|
||||
line += f" escalation_reason={data.get('escalation_reason')}"
|
||||
elif etype == "nova.attestation.recorded":
|
||||
line += f" env={data.get('environment', '?')} approver={data.get('approver', '?')} result={data.get('result', '?')}"
|
||||
elif etype == "nova.run.completed":
|
||||
line += f" exit={data.get('exit_code', '?')} outcome={data.get('outcome', '?')}"
|
||||
elif etype == "nova.run.failed":
|
||||
line += f" exit={data.get('exit_code', '?')} outcome=failed"
|
||||
elif etype == "nova.outcome.backfilled":
|
||||
line += f" prev={data.get('previous_outcome', '?')} new={data.get('new_outcome', '?')} at={data.get('backfilled_at', '?')}"
|
||||
lines.append(line)
|
||||
lines.append("=== End replay ===")
|
||||
return "\n".join(lines)
|
||||
|
||||
@@ -0,0 +1,213 @@
|
||||
"""Nova Outcome Backfill (REQ-317, SPEC §5.8, P3 Wave 2).
|
||||
|
||||
The `fact_decision.outcome` column in the metrics cold store is written
|
||||
`pending` by the collector (it ingests `nova.ai.decision.made` events,
|
||||
which are emitted *before* the run executes the apply). Once the run
|
||||
completes (`nova.run.completed`, exit 0) or fails (`nova.run.failed`,
|
||||
exit non-zero), the outcome must be transitioned `pending ->
|
||||
succeeded`/`failed` so the Post-Pilot AI Decision Accuracy denominator is
|
||||
grounded (an outcome that is stuck `pending` cannot be scored).
|
||||
|
||||
Architecture (grounded in what the ledger + collector actually do):
|
||||
|
||||
* The Decision Ledger (`core/metrics/decision_ledger.py`) is an
|
||||
**append-only hash-chain** of CloudEvents envelopes — there is no
|
||||
`fact_decision` table *inside* the ledger DB; facts live in the
|
||||
separate collector cold store (`core/metrics/collector.py`,
|
||||
`nova_metrics.db`). The ledger is never UPDATEd in place (that would
|
||||
break the SHA-256 chain — see `verify_chain()`).
|
||||
* Therefore the backfill does TWO things:
|
||||
1. Appends a new audit event `nova.outcome.backfilled` to the
|
||||
ledger (preserves the hash chain; auditable via `replay_run`).
|
||||
2. UPDATEs the `fact_decision` row in the cold store (the row is
|
||||
keyed by `decision_id`; `outcome` + `backfilled_at` are
|
||||
mutable — they are facts, not chain events).
|
||||
|
||||
Idempotent + terminal:
|
||||
* If `outcome` is already `succeeded`/`failed` (i.e. not `pending`),
|
||||
the call is a no-op and returns `{"status": "already_backfilled",
|
||||
"existing_outcome": <current>}`. A terminal outcome is NEVER
|
||||
overwritten (defense against double-backfill and against flipping a
|
||||
`succeeded` run to `failed` retroactively or vice versa).
|
||||
* The same `outcome` value is re-asserted harmlessly (still a no-op).
|
||||
|
||||
REQ-317: `outcome` ∈ {"succeeded", "failed"} only — `pending` is the
|
||||
initial state and may not be written by the backfill (it would undo the
|
||||
transition). An invalid value raises `ValueError`.
|
||||
|
||||
Future milestones may add `'policy'` to `escalation_reason` (REQ-318);
|
||||
this module is scoped to outcome only.
|
||||
"""
|
||||
|
||||
import datetime
|
||||
import json
|
||||
import os
|
||||
import sqlite3
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from typing import Optional, Dict, Any
|
||||
|
||||
sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
|
||||
from core.metrics.event_envelope import make_event, append_event
|
||||
from core.metrics.decision_ledger import append as ledger_append, _LEDGER_PATH
|
||||
|
||||
# The collector cold store path is mirrored here so the backfill can be
|
||||
# invoked without importing the collector (avoids a circular import:
|
||||
# the collector calls into backfill at run.completed/run.failed time).
|
||||
_METRICS_DIR = os.path.join(
|
||||
os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))),
|
||||
"metrics",
|
||||
)
|
||||
_STORE_PATH = os.path.join(_METRICS_DIR, "nova_metrics.db")
|
||||
|
||||
_VALID_OUTCOMES = {"succeeded", "failed"}
|
||||
_PENDING = "pending"
|
||||
|
||||
|
||||
def _iso8601_now():
|
||||
return datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
|
||||
|
||||
|
||||
def _resolve_store_path(store_path: Optional[str | Path]) -> str:
|
||||
if store_path is None:
|
||||
return _STORE_PATH
|
||||
return str(store_path)
|
||||
|
||||
|
||||
def _resolve_ledger_path(ledger_path: Optional[str | Path]) -> str:
|
||||
if ledger_path is None:
|
||||
return _LEDGER_PATH
|
||||
return str(ledger_path)
|
||||
|
||||
|
||||
def _get_fact_decision(decision_id: str, store_path: str) -> Optional[Dict[str, Any]]:
|
||||
"""Read the fact_decision row for decision_id (or None)."""
|
||||
if not os.path.isfile(store_path):
|
||||
return None
|
||||
conn = sqlite3.connect(store_path)
|
||||
conn.row_factory = sqlite3.Row
|
||||
row = conn.execute(
|
||||
"SELECT decision_id, run_id, chosen_action, confidence, alternatives, "
|
||||
"human_override, outcome, event_time FROM fact_decision WHERE decision_id = ?",
|
||||
(decision_id,),
|
||||
).fetchone()
|
||||
conn.close()
|
||||
if row is None:
|
||||
return None
|
||||
return dict(row)
|
||||
|
||||
|
||||
def backfill(
|
||||
decision_id: str,
|
||||
outcome: str,
|
||||
ledger_path: Optional[str | Path] = None,
|
||||
store_path: Optional[str | Path] = None,
|
||||
) -> Dict[str, Any]:
|
||||
"""Transition fact_decision.outcome from `pending` to `outcome`.
|
||||
|
||||
Args:
|
||||
decision_id: the decision id (== run_id for v1.26).
|
||||
outcome: the terminal outcome; must be in {"succeeded", "failed"}.
|
||||
ledger_path: optional override for the Decision Ledger SQLite DB.
|
||||
store_path: optional override for the collector cold store SQLite DB.
|
||||
|
||||
Returns:
|
||||
A dict describing the result:
|
||||
* success: {"status": "backfilled", "decision_id", "previous_outcome",
|
||||
"new_outcome", "backfilled_at"}
|
||||
* no-op: {"status": "already_backfilled", "decision_id",
|
||||
"existing_outcome", "backfilled_at"}
|
||||
|
||||
Raises:
|
||||
ValueError: if `outcome` is not in {"succeeded", "failed"}.
|
||||
KeyError: if `decision_id` is not present in fact_decision.
|
||||
"""
|
||||
if outcome not in _VALID_OUTCOMES:
|
||||
raise ValueError(
|
||||
f"outcome must be one of {sorted(_VALID_OUTCOMES)}, got: {outcome!r}"
|
||||
)
|
||||
|
||||
sp = _resolve_store_path(store_path)
|
||||
lp = _resolve_ledger_path(ledger_path)
|
||||
|
||||
existing = _get_fact_decision(decision_id, sp)
|
||||
if existing is None:
|
||||
raise KeyError(decision_id)
|
||||
|
||||
current_outcome = existing.get("outcome") or _PENDING
|
||||
backfilled_at = _iso8601_now()
|
||||
|
||||
if current_outcome != _PENDING:
|
||||
# Idempotent + terminal: do NOT overwrite a non-pending outcome.
|
||||
return {
|
||||
"status": "already_backfilled",
|
||||
"decision_id": decision_id,
|
||||
"existing_outcome": current_outcome,
|
||||
"backfilled_at": backfilled_at,
|
||||
}
|
||||
|
||||
run_id = existing.get("run_id") or decision_id
|
||||
|
||||
# 1. UPDATE the fact_decision row in the cold store (mutable fact).
|
||||
conn = sqlite3.connect(sp)
|
||||
# Add backfilled_at column idempotently (schema was added in v1.26 P3 W2;
|
||||
# older cold stores created by P2 lack it — ALTER TABLE is a no-op if
|
||||
# the column already exists).
|
||||
try:
|
||||
conn.execute("ALTER TABLE fact_decision ADD COLUMN backfilled_at TEXT")
|
||||
except sqlite3.OperationalError:
|
||||
pass # column already exists
|
||||
conn.execute(
|
||||
"UPDATE fact_decision SET outcome = ?, backfilled_at = ? WHERE decision_id = ?",
|
||||
(outcome, backfilled_at, decision_id),
|
||||
)
|
||||
conn.commit()
|
||||
conn.close()
|
||||
|
||||
# 2. Append an audit event to the append-only Decision Ledger (preserves
|
||||
# the hash chain — the ledger is never UPDATEd in place).
|
||||
try:
|
||||
backfill_data = {
|
||||
"decision_id": decision_id,
|
||||
"previous_outcome": _PENDING,
|
||||
"new_outcome": outcome,
|
||||
"backfilled_at": backfilled_at,
|
||||
}
|
||||
event = make_event(
|
||||
"nova.outcome.backfilled",
|
||||
run_id,
|
||||
existing.get("environment", ""),
|
||||
backfill_data,
|
||||
contract_id=existing.get("contract_id", ""),
|
||||
actor_type="outcome-backfill",
|
||||
actor_id="outcome_backfill",
|
||||
)
|
||||
append_event(event)
|
||||
ledger_append(event, db_path=lp)
|
||||
except Exception:
|
||||
# Metrics emission must never break the backfill — the cold store
|
||||
# UPDATE is the source of truth for the denominator; the ledger
|
||||
# event is audit chrome.
|
||||
pass
|
||||
|
||||
return {
|
||||
"status": "backfilled",
|
||||
"decision_id": decision_id,
|
||||
"previous_outcome": _PENDING,
|
||||
"new_outcome": outcome,
|
||||
"backfilled_at": backfilled_at,
|
||||
}
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
if len(sys.argv) < 3:
|
||||
print("usage: outcome_backfill.py <decision_id> <succeeded|failed>", file=sys.stderr)
|
||||
sys.exit(2)
|
||||
_did = sys.argv[1]
|
||||
_out = sys.argv[2]
|
||||
try:
|
||||
_r = backfill(_did, _out)
|
||||
print(json.dumps(_r, indent=2))
|
||||
except (ValueError, KeyError) as exc:
|
||||
print(f"error: {exc}", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
@@ -27,6 +27,27 @@ def _iso8601_now():
|
||||
return datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
|
||||
|
||||
|
||||
def _backfill_outcome(decision_id, outcome):
|
||||
"""Transition fact_decision.outcome pending -> outcome (REQ-317).
|
||||
|
||||
Best-effort: logs a warning and skips if decision_id is missing or the
|
||||
backfill raises. Never raises — the run is already completing/failing
|
||||
and the manifest write is the source of truth for the run outcome.
|
||||
"""
|
||||
if not decision_id:
|
||||
# A run that failed before ai.decision.made was emitted has no
|
||||
# decision to backfill (e.g. a schema-validation failure). Skip
|
||||
# silently rather than pollute stderr on every clean run.
|
||||
return None
|
||||
try:
|
||||
from core.metrics import outcome_backfill
|
||||
return outcome_backfill.backfill(decision_id, outcome)
|
||||
except Exception as exc: # pragma: no cover - defensive
|
||||
print(f"[run_manifest] outcome backfill skipped for {decision_id}: {exc}",
|
||||
file=sys.stderr)
|
||||
return None
|
||||
|
||||
|
||||
def _run_id():
|
||||
return f"run-{int(time.time())}-{uuid.uuid4().hex[:8]}"
|
||||
|
||||
@@ -44,7 +65,7 @@ def start_run(contract_id, environment, stages=None):
|
||||
return run_id
|
||||
|
||||
|
||||
def complete_run(run_id, contract_id, environment, stages, exit_code, confidence=None, hitl=None, policy=None, cost_estimate_usd=None, decision_id=None):
|
||||
def complete_run(run_id, contract_id, environment, stages, exit_code, confidence=None, hitl=None, policy=None, cost_estimate_usd=None, decision_id=None, escalation_reason=None):
|
||||
"""Emit nova.run.completed + write the per-run manifest JSON.
|
||||
|
||||
Args:
|
||||
@@ -58,6 +79,10 @@ def complete_run(run_id, contract_id, environment, stages, exit_code, confidence
|
||||
policy: optional {passed, failed, skipped}
|
||||
cost_estimate_usd: optional float
|
||||
decision_id: optional string (links to the Decision Ledger)
|
||||
escalation_reason: optional string (REQ-318) — "confidence" when
|
||||
the ai.decision.made band was block; absent/None otherwise.
|
||||
Persisted into the manifest so the collector can write it
|
||||
into fact_run (Post-Pilot Human Escalation Frequency denom).
|
||||
"""
|
||||
started_at = stages[0].get("started_at", _iso8601_now()) if stages else _iso8601_now()
|
||||
completed_at = _iso8601_now()
|
||||
@@ -83,6 +108,8 @@ def complete_run(run_id, contract_id, environment, stages, exit_code, confidence
|
||||
manifest["cost_estimate_usd"] = cost_estimate_usd
|
||||
if decision_id:
|
||||
manifest["decision_id"] = decision_id
|
||||
if escalation_reason:
|
||||
manifest["escalation_reason"] = escalation_reason
|
||||
|
||||
os.makedirs(_RUNS_DIR, exist_ok=True)
|
||||
manifest_path = os.path.join(_RUNS_DIR, f"{run_id}.json")
|
||||
@@ -92,6 +119,14 @@ def complete_run(run_id, contract_id, environment, stages, exit_code, confidence
|
||||
event_type = "nova.run.completed" if exit_code == 0 else "nova.run.failed"
|
||||
emit(event_type, run_id, environment, manifest, contract_id=contract_id)
|
||||
|
||||
# REQ-317: backfill fact_decision.outcome pending -> succeeded/failed
|
||||
# after the run completes. The decision_id links the run to the
|
||||
# Decision Ledger entry written by ai.decision.made. Best-effort: a
|
||||
# run that failed before ai.decision.made was emitted has no
|
||||
# decision_id and the backfill is a no-op (the run outcome is still
|
||||
# captured in the manifest above).
|
||||
backfill_result = _backfill_outcome(decision_id, outcome)
|
||||
|
||||
return manifest
|
||||
|
||||
|
||||
|
||||
@@ -0,0 +1,212 @@
|
||||
"""Nova Policy Engine Registry (REQ-291, v1.25).
|
||||
|
||||
The swappable policy-engine abstraction. A Python Protocol (PEP 544)
|
||||
defines the engine contract; a registry selects the active engine from
|
||||
``config.json``'s ``policy.engine`` key. This is the **swap boundary**
|
||||
(ARCHITECTURE.md §12.7) — the confidence signal and pipeline never
|
||||
import an engine directly; they go through the registry. A future
|
||||
``OpaEngine`` implements the same protocol without touching the
|
||||
confidence signal, the PCR schema, or the pipeline.
|
||||
|
||||
The protocol is minimal (3 members) by design:
|
||||
|
||||
- ``name`` — the engine's registry key (matches ``config.json.policy.engine``).
|
||||
- ``is_configured()`` — returns False when the engine's binary is absent
|
||||
(the registry's caller must skip gracefully, emitting SKIPPED PCRs).
|
||||
- ``evaluate(payload, policy_dir, contract_id)`` — runs the engine's
|
||||
policies over ``payload`` and returns a ``list[dict]`` where each dict
|
||||
conforms to ``schemas/policy_check_result.schema.json``.
|
||||
|
||||
A ``NullEngine`` is the fallback when the ``policy`` key is absent from
|
||||
``config.json`` (backward compatibility for tests that don't set the
|
||||
key — it emits a single SKIPPED PCR so the confidence signal proceeds
|
||||
with a neutral ``policy`` input).
|
||||
|
||||
Engine enum reuse (D-116): kyverno-json PCR records carry
|
||||
``engine: "kyverno"`` (no new enum value). The ``engine`` field records
|
||||
the policy-engine *family*, not the specific binary. The K8s Kyverno
|
||||
adapter and the kyverno-json engine are distinguished by ``ruleId``
|
||||
prefix (``KYVERNO_`` vs ``KJ_``).
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
from typing import Any, Callable, Protocol, Union, runtime_checkable
|
||||
|
||||
import datetime
|
||||
|
||||
|
||||
def _iso8601_now() -> str:
|
||||
return datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
|
||||
|
||||
|
||||
Payload = Union[dict, list, str]
|
||||
|
||||
|
||||
@runtime_checkable
|
||||
class PolicyEngine(Protocol):
|
||||
"""The swap boundary for policy engines.
|
||||
|
||||
Implementations: ``KyvernoJsonEngine`` (adapters/kyverno-json/),
|
||||
``NullEngine`` (this module), future ``OpaEngine``.
|
||||
"""
|
||||
|
||||
@property
|
||||
def name(self) -> str: ...
|
||||
|
||||
def is_configured(self) -> bool: ...
|
||||
|
||||
def evaluate(self, payload: Payload, policy_dir: Path,
|
||||
contract_id: str) -> list[dict]: ...
|
||||
|
||||
|
||||
def _skipped_pcr(rule_id: str, message: str, contract_id: str) -> dict:
|
||||
return {
|
||||
"contractId": contract_id,
|
||||
"evaluatedAt": _iso8601_now(),
|
||||
"engine": "kyverno",
|
||||
"ruleId": rule_id,
|
||||
"severity": "info",
|
||||
"result": "skipped",
|
||||
"message": message,
|
||||
"evidence": {},
|
||||
"resourceRef": "",
|
||||
}
|
||||
|
||||
|
||||
class NullEngine:
|
||||
"""Fallback when ``config.json.policy`` is absent.
|
||||
|
||||
Emits a single SKIPPED PCR with ``ruleId: NULL_ENGINE_INACTIVE`` so
|
||||
the confidence signal's ``policy`` input is non-null (the per-input
|
||||
score for a single SKIPPED PCR is 1.0 — skipped counts as pass per
|
||||
``core/confidence_signal.py:84-89``). This keeps existing tests
|
||||
passing when the ``policy`` key is not set.
|
||||
"""
|
||||
|
||||
name = "null"
|
||||
|
||||
def is_configured(self) -> bool:
|
||||
return False
|
||||
|
||||
def evaluate(self, payload: Payload, policy_dir: Path,
|
||||
contract_id: str) -> list[dict]:
|
||||
return [_skipped_pcr(
|
||||
"NULL_ENGINE_INACTIVE",
|
||||
"NullEngine active — the `policy` key is absent from config.json. "
|
||||
"No policy engine is configured; the confidence signal proceeds with "
|
||||
"a neutral SKIPPED policy input.",
|
||||
contract_id,
|
||||
)]
|
||||
|
||||
|
||||
_REGISTRY: dict[str, Callable[[], PolicyEngine]] = {}
|
||||
|
||||
|
||||
def register(name: str, factory: Callable[[], PolicyEngine]) -> None:
|
||||
"""Register an engine factory under ``name``.
|
||||
|
||||
The factory is called lazily by ``get_engine()`` so an engine's
|
||||
binary dependency (e.g. ``kj``) is not required at import time.
|
||||
"""
|
||||
_REGISTRY[name] = factory
|
||||
|
||||
|
||||
def _load_config_policy() -> dict | None:
|
||||
"""Read the ``policy`` object from ``.ciagent/config.json``.
|
||||
|
||||
Returns ``None`` when the file is absent or the ``policy`` key is
|
||||
missing (the caller falls back to ``NullEngine``).
|
||||
"""
|
||||
repo_root = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
||||
cfg = os.path.join(repo_root, ".ciagent", "config.json")
|
||||
if not os.path.isfile(cfg):
|
||||
return None
|
||||
try:
|
||||
with open(cfg, "r", encoding="utf-8") as fh:
|
||||
data = json.load(fh)
|
||||
except (json.JSONDecodeError, OSError):
|
||||
return None
|
||||
return data.get("policy")
|
||||
|
||||
|
||||
def get_engine() -> PolicyEngine:
|
||||
"""Return the active ``PolicyEngine`` from ``config.json``.
|
||||
|
||||
Reads ``config.json.policy.engine`` (default ``"kyverno-json"``).
|
||||
Falls back to ``NullEngine`` when the ``policy`` key is absent
|
||||
(backward compatibility). Raises ``KeyError`` for an unknown engine
|
||||
name (a typo in config — fail loud, not silent).
|
||||
"""
|
||||
policy_cfg = _load_config_policy()
|
||||
if policy_cfg is None:
|
||||
return NullEngine()
|
||||
engine_name = policy_cfg.get("engine", "kyverno-json")
|
||||
factory = _REGISTRY.get(engine_name)
|
||||
if factory is None:
|
||||
raise KeyError(
|
||||
f"Unknown policy engine '{engine_name}' in config.json. "
|
||||
f"Registered engines: {sorted(_REGISTRY.keys()) or ['(none)']}. "
|
||||
f"Set policy.engine to a registered name or install the engine adapter."
|
||||
)
|
||||
return factory()
|
||||
|
||||
|
||||
def get_policy_root() -> Path:
|
||||
"""Return the configured policy root directory (or a default)."""
|
||||
policy_cfg = _load_config_policy()
|
||||
if policy_cfg is None:
|
||||
return Path("adapters/kyverno-json/policies")
|
||||
root = policy_cfg.get("policy_root", "adapters/kyverno-json/policies")
|
||||
repo_root = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
||||
if os.path.isabs(root):
|
||||
return Path(root)
|
||||
return Path(repo_root) / root
|
||||
|
||||
|
||||
def _register_builtin(name: str, factory: Callable[[], PolicyEngine]) -> None:
|
||||
register(name, factory)
|
||||
|
||||
|
||||
def _autoload_kyverno_json() -> None:
|
||||
"""Register the kyverno-json engine if its adapter is importable.
|
||||
|
||||
The adapter directory uses a hyphen (``adapters/kyverno-json/``),
|
||||
so a plain ``import`` is not possible. Load the module by file path
|
||||
via ``importlib.util``. Lazy import so ``core/policy_engine.py``
|
||||
does not require ``adapters/kyverno-json/`` at import time (the
|
||||
adapter imports ``yaml``, which may be unavailable in minimal test
|
||||
envs).
|
||||
"""
|
||||
try:
|
||||
import importlib.util
|
||||
repo_root = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
||||
adapter_path = os.path.join(
|
||||
repo_root, "adapters", "kyverno-json", "kyverno_json_engine.py"
|
||||
)
|
||||
if not os.path.isfile(adapter_path):
|
||||
return
|
||||
spec = importlib.util.spec_from_file_location(
|
||||
"kyverno_json_engine", adapter_path
|
||||
)
|
||||
if spec is None or spec.loader is None:
|
||||
return
|
||||
mod = importlib.util.module_from_spec(spec)
|
||||
spec.loader.exec_module(mod)
|
||||
engine_cls = getattr(mod, "KyvernoJsonEngine")
|
||||
_register_builtin("kyverno-json", engine_cls)
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
|
||||
_autoload_kyverno_json()
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
eng = get_engine()
|
||||
print(json.dumps({
|
||||
"engine": eng.name,
|
||||
"is_configured": eng.is_configured(),
|
||||
"policy_root": str(get_policy_root()),
|
||||
}, indent=2))
|
||||
@@ -601,16 +601,17 @@ def _check_cap_024_deck_structure() -> Tuple[Status, str]:
|
||||
"""
|
||||
import os
|
||||
deck_path = os.path.join(os.path.dirname(os.path.dirname(os.path.abspath(__file__))),
|
||||
"docs", "presentations", "nova-autonomous-cloud-delivery.md")
|
||||
"docs", "presentations", "nova-autonomous-cloud-delivery-marp.md")
|
||||
if not os.path.isfile(deck_path):
|
||||
return "Skipped", "unified deck not found"
|
||||
with open(deck_path) as f:
|
||||
content = f.read()
|
||||
slide_count = content.count("## Slide ")
|
||||
if slide_count < 18 or slide_count > 19:
|
||||
return "Broken", f"deck has {slide_count} main slides (expected 18-19)"
|
||||
if slide_count < 18 or slide_count > 20:
|
||||
return "Broken", f"deck has {slide_count} main slides (expected 18-20)"
|
||||
has_recap = "Recap + Ask" in content
|
||||
has_benefit = content.count("Benefit:") >= 10
|
||||
benefit_count = content.count("Benefit:") + content.count('class="benefit"')
|
||||
has_benefit = benefit_count >= 10
|
||||
if not (has_recap and has_benefit):
|
||||
missing = []
|
||||
if not has_recap: missing.append("recap+ask")
|
||||
@@ -619,6 +620,98 @@ def _check_cap_024_deck_structure() -> Tuple[Status, str]:
|
||||
return "Verified", f"deck has {slide_count} slides, recap+ask present, per-slide benefits present"
|
||||
|
||||
|
||||
def _check_cap_025_live_pilot_apply() -> Tuple[Status, str]:
|
||||
"""CAP-025 (REQ-316): live-pilot-apply pipeline readiness — structural
|
||||
check that the pilot-apply end-to-end pipeline is wired (NOT a live
|
||||
apply; the live apply lands in P4).
|
||||
|
||||
The pilot-apply round-trip is:
|
||||
contract resolve -> adapter compile -> terraform plan -> policy scan
|
||||
-> confidence signal -> terraform apply -> outbox write
|
||||
|
||||
For P3 this is a LOCAL-tier structural-readiness check: the scripts
|
||||
exist + are wired, the core pipeline modules import, the pilot env is
|
||||
bound to a real account (D-203), the DynamoDB L1 primitive is
|
||||
registered (REQ-322), the pilot policies are authored (REQ-315/320),
|
||||
and the outcome-backfill module exists (REQ-317). The live apply
|
||||
against AWS is P4's live-verify (D-093 / G-111 steady state aside).
|
||||
"""
|
||||
import json
|
||||
|
||||
# 1. scripts/run_platform.sh exists + contains the pipeline step markers.
|
||||
run_platform = ROOT / "scripts" / "run_platform.sh"
|
||||
if not run_platform.is_file():
|
||||
return "Broken", "scripts/run_platform.sh missing (pilot-apply pipeline driver)"
|
||||
script_text = run_platform.read_text()
|
||||
# Step markers mirrored from the script's own comments + Step headers.
|
||||
required_markers = [
|
||||
"resolve contract", # Step 2: contract_resolver
|
||||
"adapter compiles stack", # Step 3: terraform adapter
|
||||
"terraform init", # Step 4: terraform plan
|
||||
"terraform plan", # Step 4: terraform plan
|
||||
"policy scan", # Step 5: runtime policy scan (Wiz/Checkov)
|
||||
"confidence signal", # Step 7: confidence_signal compute
|
||||
"terraform apply", # Step 5: terraform apply (--apply mode)
|
||||
"outbox", # outbox write (Step 8)
|
||||
]
|
||||
missing_markers = [m for m in required_markers if m not in script_text]
|
||||
if missing_markers:
|
||||
return "Broken", f"run_platform.sh missing step markers: {missing_markers}"
|
||||
|
||||
# 2. core pipeline modules importable.
|
||||
for mod_name in (
|
||||
"core.contract_resolver",
|
||||
"adapters.terraform.adapter",
|
||||
"core.confidence_signal",
|
||||
"core.outbox_writer",
|
||||
):
|
||||
try:
|
||||
importlib.import_module(mod_name)
|
||||
except Exception as exc: # noqa: BLE001
|
||||
return "Broken", f"pipeline module not importable: {mod_name} ({type(exc).__name__}: {exc})"[:200]
|
||||
|
||||
# 3. dev env bound to the real pilot account (D-203).
|
||||
dev_env_path = ROOT / "core" / "environments" / "dev.json"
|
||||
if not dev_env_path.is_file():
|
||||
return "Broken", "core/environments/dev.json missing"
|
||||
try:
|
||||
dev_env = json.loads(dev_env_path.read_text())
|
||||
except Exception as exc: # noqa: BLE001
|
||||
return "Broken", f"dev.json parse failed: {exc}"[:200]
|
||||
account_id = dev_env.get("account_id")
|
||||
if account_id != "581513795199":
|
||||
return "Broken", f"dev env not bound to real account (D-203): account_id={account_id!r}"
|
||||
|
||||
# 4. DynamoDB L1 primitive registered (REQ-322).
|
||||
registry_path = ROOT / "modules" / "registry.json"
|
||||
if not registry_path.is_file():
|
||||
return "Broken", "modules/registry.json missing"
|
||||
try:
|
||||
registry = json.loads(registry_path.read_text())
|
||||
except Exception as exc: # noqa: BLE001
|
||||
return "Broken", f"registry.json parse failed: {exc}"[:200]
|
||||
if "dynamodb" not in registry:
|
||||
return "Broken", "dynamodb L1 primitive not registered (REQ-322)"
|
||||
|
||||
# 5. pilot policies authored (REQ-315/320).
|
||||
pilot_policies = [
|
||||
ROOT / "adapters" / "kyverno-json" / "policies" / "pilot-readiness" / "no-placeholder-account.json",
|
||||
ROOT / "adapters" / "kyverno-json" / "policies" / "settlement-finality" / "all-matches-committed.json",
|
||||
]
|
||||
missing_policies = [str(p.relative_to(ROOT)) for p in pilot_policies if not p.is_file()]
|
||||
if missing_policies:
|
||||
return "Broken", f"pilot policies not authored (REQ-315/320): {missing_policies}"
|
||||
|
||||
# 6. outcome-backfill module exists (REQ-317).
|
||||
outcome_backfill = ROOT / "core" / "metrics" / "outcome_backfill.py"
|
||||
if not outcome_backfill.is_file():
|
||||
return "Broken", "outcome backfill not implemented (REQ-317)"
|
||||
|
||||
return ("Verified",
|
||||
"pilot-apply pipeline structurally ready "
|
||||
"(contract->adapter->plan->policy->confidence->apply->outbox)")
|
||||
|
||||
|
||||
# Registry: ordered, each entry is (capability_id, name, tier, check_fn).
|
||||
# Phase 52 seeds this with 10 local-tier checks; Phase 54 expands it to
|
||||
# cover every v1.1->v1.8 advertised capability and adds the live-AWS tier
|
||||
@@ -672,6 +765,8 @@ CAPABILITY_REGISTRY: List[Tuple[str, str, str, Callable[[], Tuple[Status, str]]]
|
||||
_check_cap_023_metrics_collector),
|
||||
("CAP-024", "unified deck structure (slide count, x3, per-slide benefits)", "local",
|
||||
_check_cap_024_deck_structure),
|
||||
("CAP-025", "live-pilot-apply pipeline readiness (contract->apply->outbox)", "local",
|
||||
_check_cap_025_live_pilot_apply),
|
||||
]
|
||||
|
||||
|
||||
|
||||
+15
-1
@@ -174,4 +174,18 @@ numbers. Every metric either has a real source or is explicitly deferred.
|
||||
| SLA / Unplanned Downtime | D-096 | `placeholder_sla_downtime.csv` |
|
||||
| Predictive vs Reactive Ratio | future emitter | `placeholder_predictive_reactive.csv` |
|
||||
|
||||
See `docs/METRICS_DEFERRED_ROADMAP.md` for the activation path for each.
|
||||
See `docs/METRICS_DEFERRED_ROADMAP.md` for the activation path for each.
|
||||
|
||||
---
|
||||
|
||||
## v1.25 — Swappable Policy Engine
|
||||
|
||||
The policy engine that produces the `PolicyCheckResult` records feeding
|
||||
the confidence signal is **swappable** (NORTH_STAR Strategic Objective #2
|
||||
— provable trust via a replaceable substrate, not a vendor lock-in).
|
||||
The `PolicyEngine` protocol (`core/policy_engine.py`) is the swap
|
||||
boundary; `config.json.policy.engine` selects the active engine
|
||||
(default `"kyverno-json"`). A future `OpaEngine` implements the same
|
||||
protocol without touching the confidence signal, the PCR schema, or
|
||||
the pipeline. See `.ciagent/ARCHITECTURE.md` §12.7 for the registry
|
||||
diagram.
|
||||
@@ -36,6 +36,7 @@ resources it creates.
|
||||
| `rds` | `aws_db_instance` — Relational database (PostgreSQL, MySQL, etc.) with multi-engine support | [README](l1/rds/README.md) |
|
||||
| `kms-key` | `aws_kms_key` — Customer-managed KMS key with rotation enabled (per-stack CMK) | [README](l1/kms-key/README.md) |
|
||||
| `uptime` | `aws_ecs_service` — Uptime-kuma monitoring on ECS Fargate with alert channels | [README](l1/uptime/README.md) |
|
||||
| `dynamodb` | `aws_dynamodb_table` — DynamoDB table with encryption + PITR (v1.8 NFR defaults) | [README](l1/dynamodb/README.md) |
|
||||
|
||||
## Modules
|
||||
|
||||
|
||||
+61
-1
@@ -611,4 +611,64 @@ must be checked before the module is registered and published.
|
||||
`stack.schema.json`).
|
||||
- [ ] For an L2, a test is added that the composition resolves to the
|
||||
expected set of L1 instances and that the adapter emits a root module
|
||||
calling the L1 modules.
|
||||
calling the L1 modules.
|
||||
|
||||
---
|
||||
|
||||
## 10. Policy Authoring Standard (v1.25)
|
||||
|
||||
Module owners may ship per-module kyverno-json policies in
|
||||
`modules/<name>/policies/` (future convention; v1.25 policies live
|
||||
under `adapters/kyverno-json/policies/`). A policy file is a
|
||||
`ValidatingPolicy` resource (YAML or JSON).
|
||||
|
||||
### 10.1 Required fields
|
||||
|
||||
- `apiVersion: json.kyverno.io/v1alpha1`
|
||||
- `kind: ValidatingPolicy`
|
||||
- `metadata.name` — matches the filename (e.g. `require-tags.json` →
|
||||
`name: require-tags`). This becomes the `ruleId` prefix `KJ_<name>`.
|
||||
- `metadata.annotations["nova.cloudinit.dev/severity"]` — one of
|
||||
`critical`, `high`, `medium`, `low`, `info`. Drives the confidence
|
||||
signal's penalty mapping.
|
||||
- `spec.rules[].validate.assert` — an `all` or `any` list of assertion
|
||||
trees with JMESPath expressions. **No `forEach`, pattern operators,
|
||||
anchors, or wildcards** — use the `~` projection modifier to iterate.
|
||||
|
||||
### 10.2 Severity guidance
|
||||
|
||||
| Severity | When to use | Confidence penalty |
|
||||
| --- | --- | --- |
|
||||
| `critical` | a violation makes the deploy unsafe (e.g. public ingress on a prod DB) | hard override (score = 0, block) |
|
||||
| `high` | a violation is a security or compliance gap (e.g. plaintext secrets) | -0.20 |
|
||||
| `medium` | a violation is a best-practice miss (e.g. missing tags) | -0.05 |
|
||||
| `low` | a violation is a style or convention issue | -0.01 |
|
||||
| `info` | a non-blocking observation (default) | 0.0 |
|
||||
|
||||
### 10.3 Assertion-tree patterns
|
||||
|
||||
- **Iterate an array:** use the `~` modifier on the array key:
|
||||
```yaml
|
||||
check:
|
||||
~.resources:
|
||||
(@ < `5`): true
|
||||
```
|
||||
- **Match a resource type:** use the `match.any` block:
|
||||
```yaml
|
||||
match:
|
||||
any:
|
||||
- type: aws:s3:bucket
|
||||
```
|
||||
- **Binding for descendant access:** use `->name`:
|
||||
```yaml
|
||||
(bar + bat)->sum:
|
||||
($sum): 10
|
||||
```
|
||||
|
||||
### 10.4 Testing
|
||||
|
||||
- Ship a fixture pair (`passing.json` + `failing.json`) under
|
||||
`tests/fixtures/<policy_target>/`.
|
||||
- Add a test file `tests/test_<policy_target>_policies.py` using the
|
||||
`KyvernoJsonEngine` (skip-without-kj pattern).
|
||||
- The regression gate (`pytest tests/`) must remain green.
|
||||
@@ -0,0 +1,38 @@
|
||||
# DynamoDB L1 Primitive
|
||||
|
||||
> Stack type: `aws:dynamodb:table` → Terraform `aws_dynamodb_table`
|
||||
|
||||
## Description
|
||||
|
||||
A DynamoDB table primitive with encryption + point-in-time recovery
|
||||
enabled by default (per v1.8 NFR defaults). Supports a partition key
|
||||
(required) + optional sort key. Default billing mode is
|
||||
`PAY_PER_REQUEST` (on-demand).
|
||||
|
||||
## Inputs
|
||||
|
||||
| Name | Type | Required | Default | Description |
|
||||
|---|---|---|---|---|
|
||||
| `table_name` | string | yes | — | Globally-unique table name |
|
||||
| `region` | string | yes | — | AWS region |
|
||||
| `pk` | string | yes | — | Partition key attribute name |
|
||||
| `sk` | string | no | `""` | Sort key attribute name |
|
||||
| `billing_mode` | string | no | `PAY_PER_REQUEST` | Billing mode |
|
||||
| `enabled` | boolean | no | `true` | Feature flag |
|
||||
|
||||
## Outputs
|
||||
|
||||
| Name | Type | Description |
|
||||
|---|---|---|
|
||||
| `table_arn` | arn | The table ARN |
|
||||
| `table_name` | string | The table name |
|
||||
|
||||
## NFRs
|
||||
|
||||
- **Encryption:** SSE-KMS enabled by default.
|
||||
- **Point-in-time recovery:** Enabled by default.
|
||||
- **Deletion protection:** `prevent_destroy = true` (Terraform lifecycle).
|
||||
|
||||
## Examples
|
||||
|
||||
See `examples/simple.yaml`.
|
||||
@@ -0,0 +1,12 @@
|
||||
environment: dev
|
||||
id: blkex
|
||||
name: blockchain-exchange
|
||||
infrastructure:
|
||||
dynamodb:
|
||||
version: "1.0.0"
|
||||
inputs:
|
||||
table_name: nova-blkex-ledger-dev
|
||||
region: us-east-1
|
||||
pk: block_index
|
||||
sk: txn_id
|
||||
billing_mode: PAY_PER_REQUEST
|
||||
@@ -0,0 +1,4 @@
|
||||
table_name: nova-simple-ledger
|
||||
region: us-east-1
|
||||
pk: block_index
|
||||
billing_mode: PAY_PER_REQUEST
|
||||
@@ -0,0 +1,10 @@
|
||||
{
|
||||
"module": "dynamodb",
|
||||
"version": "1.0.0",
|
||||
"inputs": {
|
||||
"table_name": "nova-blockchain-ledger",
|
||||
"region": "us-east-1",
|
||||
"pk": "block_index",
|
||||
"billing_mode": "PAY_PER_REQUEST"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,66 @@
|
||||
{
|
||||
"name": "dynamodb",
|
||||
"version": "1.0.0",
|
||||
"kind": "l1",
|
||||
"type": "aws:dynamodb:table",
|
||||
"description": "DynamoDB table primitive (engine-agnostic stack type aws:dynamodb:table; the Terraform adapter translates to aws_dynamodb_table). Encryption + PITR enabled per v1.8 NFR defaults.",
|
||||
"inputs": {
|
||||
"table_name": {
|
||||
"type": "string",
|
||||
"description": "Globally-unique DynamoDB table name.",
|
||||
"required": true
|
||||
},
|
||||
"region": {
|
||||
"type": "string",
|
||||
"description": "AWS region the table is created in.",
|
||||
"required": true
|
||||
},
|
||||
"pk": {
|
||||
"type": "string",
|
||||
"description": "Partition key attribute name.",
|
||||
"required": true
|
||||
},
|
||||
"sk": {
|
||||
"type": "string",
|
||||
"description": "Sort key attribute name (optional).",
|
||||
"required": false
|
||||
},
|
||||
"billing_mode": {
|
||||
"type": "string",
|
||||
"default": "PAY_PER_REQUEST",
|
||||
"description": "Billing mode: PAY_PER_REQUEST or PROVISIONED."
|
||||
},
|
||||
"enabled": {
|
||||
"type": "boolean",
|
||||
"default": true,
|
||||
"description": "Feature flag: enable/disable this module."
|
||||
}
|
||||
},
|
||||
"outputs": {
|
||||
"table_arn": {
|
||||
"type": "arn",
|
||||
"description": "The DynamoDB table ARN."
|
||||
},
|
||||
"table_name": {
|
||||
"type": "string",
|
||||
"description": "The table name (echoes the input)."
|
||||
}
|
||||
},
|
||||
"nfrs": {
|
||||
"encryption_enabled": {
|
||||
"type": "boolean",
|
||||
"description": "Enable server-side encryption (KMS).",
|
||||
"default": true
|
||||
},
|
||||
"point_in_time_recovery": {
|
||||
"type": "boolean",
|
||||
"description": "Enable point-in-time recovery.",
|
||||
"default": true
|
||||
},
|
||||
"deletion_protection": {
|
||||
"type": "boolean",
|
||||
"description": "Prevent resource destruction via Terraform lifecycle prevent_destroy.",
|
||||
"default": true
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,74 @@
|
||||
resource "aws_dynamodb_table" "this" {
|
||||
count = var.enabled ? 1 : 0
|
||||
name = var.table_name
|
||||
billing_mode = var.billing_mode
|
||||
|
||||
hash_key = var.pk
|
||||
range_key = var.sk != "" ? var.sk : null
|
||||
|
||||
attribute {
|
||||
name = var.pk
|
||||
type = "S"
|
||||
}
|
||||
|
||||
dynamic "attribute" {
|
||||
for_each = var.sk != "" ? [var.sk] : []
|
||||
content {
|
||||
name = attribute.value
|
||||
type = "S"
|
||||
}
|
||||
}
|
||||
|
||||
point_in_time_recovery {
|
||||
enabled = true
|
||||
}
|
||||
|
||||
server_side_encryption {
|
||||
enabled = true
|
||||
}
|
||||
|
||||
tags = {
|
||||
"nova:managed-by" = "platform"
|
||||
"nova:module" = "dynamodb"
|
||||
}
|
||||
|
||||
lifecycle {
|
||||
prevent_destroy = true
|
||||
}
|
||||
}
|
||||
|
||||
variable "table_name" {
|
||||
type = string
|
||||
}
|
||||
|
||||
variable "region" {
|
||||
type = string
|
||||
default = "us-east-1"
|
||||
}
|
||||
|
||||
variable "pk" {
|
||||
type = string
|
||||
}
|
||||
|
||||
variable "sk" {
|
||||
type = string
|
||||
default = ""
|
||||
}
|
||||
|
||||
variable "billing_mode" {
|
||||
type = string
|
||||
default = "PAY_PER_REQUEST"
|
||||
}
|
||||
|
||||
variable "enabled" {
|
||||
type = bool
|
||||
default = true
|
||||
}
|
||||
|
||||
output "table_arn" {
|
||||
value = var.enabled ? aws_dynamodb_table.this[0].arn : ""
|
||||
}
|
||||
|
||||
output "table_name" {
|
||||
value = var.enabled ? aws_dynamodb_table.this[0].name : ""
|
||||
}
|
||||
+10
-1
@@ -122,5 +122,14 @@
|
||||
"deprecated": false,
|
||||
"kind": "l2"
|
||||
}
|
||||
},
|
||||
"dynamodb": {
|
||||
"1.0.0": {
|
||||
"interface": "modules/l1/dynamodb/interface.json",
|
||||
"terraform_dir": "modules/l1/dynamodb/terraform",
|
||||
"published_at": "2026-08-14T19:26:18Z",
|
||||
"deprecated": false,
|
||||
"kind": "l1"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -15,6 +15,14 @@ Nova uses JSON Schema draft 2020-12 for all declarative contracts. Schemas are t
|
||||
| Nova PolicyCheckResult | `policy_check_result.schema.json` | Normalized policy check result schema (the contract between policy engines and the confidence signal) | `tests/conftest.py`, all adapter tests |
|
||||
| Nova Tagging Standard | `tagging-standard.json` | Required tag set for all taggable AWS resources | `adapters/terraform/policy/custom_rules/nova_tagging.py` |
|
||||
|
||||
> **v1.25 note (D-116):** the `engine` enum value `"kyverno"` is shared
|
||||
> by the K8s-only Kyverno adapter (`adapters/kyverno/`) and the
|
||||
> kyverno-json engine (`adapters/kyverno-json/`). The two are
|
||||
> distinguished by `ruleId` prefix (`KYVERNO_` for the K8s adapter,
|
||||
> `KJ_` for kyverno-json) and `evidence` payload shape. No new enum
|
||||
> value was added — the `engine` field records the policy-engine
|
||||
> family, not the specific binary.
|
||||
|
||||
## How to Write a Schema
|
||||
|
||||
1. Use JSON Schema draft 2020-12: `"$schema": "https://json-schema.org/draft/2020-12/schema"`.
|
||||
|
||||
@@ -0,0 +1,65 @@
|
||||
#!/usr/bin/env bash
|
||||
# scripts/install-kyverno-json.sh — install the kj CLI (v1.25, REQ-294;
|
||||
# fixed v1.26 P3 W0.5).
|
||||
#
|
||||
# Installs the kyverno-json CLI via `go install` (D-115). The binary is a
|
||||
# Go project — not a Python package. Cached via the Go module cache.
|
||||
#
|
||||
# v1.26 P3 W0.5 fix: the v1.25 script ran
|
||||
# go install github.com/kyverno/kyverno-json/cmd/kj@latest
|
||||
# but the `cmd/kj` path does NOT exist in v0.0.3 — the upstream
|
||||
# `go install github.com/kyverno/kyverno-json@latest` produces a binary
|
||||
# named `kyverno-json`, NOT `kj`. The v1.25 invocation failed silently
|
||||
# (the test suite masked it via `pytest.skip("kj not installed")`). This
|
||||
# script now installs the real module and symlinks `kyverno-json` → `kj`
|
||||
# so the engine's `which kj` check passes.
|
||||
#
|
||||
# Usage: bash scripts/install-kyverno-json.sh
|
||||
# Exits 0 on success, 1 if Go is not installed, 2 if `kj version` fails.
|
||||
set -euo pipefail
|
||||
|
||||
if ! command -v go >/dev/null 2>&1; then
|
||||
echo "ERROR: Go toolchain not found. Install Go (https://go.dev/dl/) first." >&2
|
||||
echo " kyverno-json is a Go binary — \`go install\` is the upstream-blessed path (D-115)." >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
GOBIN="${GOBIN:-${HOME}/go/bin}"
|
||||
|
||||
# Idempotent: if kj is already on PATH and working, short-circuit.
|
||||
if command -v kj >/dev/null 2>&1 && kj version >/dev/null 2>&1; then
|
||||
echo "kj installed:"
|
||||
kj version
|
||||
echo "DONE"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
echo "Installing kyverno-json CLI (kyverno-json) via go install..."
|
||||
# The upstream module produces a binary named `kyverno-json` (NOT `kj`).
|
||||
# The v1.25 `go install .../cmd/kj@latest` path does not exist in v0.0.3.
|
||||
go install github.com/kyverno/kyverno-json@latest
|
||||
|
||||
# The binary is named `kyverno-json`, not `kj`. Symlink it as `kj` for
|
||||
# the engine's `which kj` check (kyverno_json_engine.py::_which_kj).
|
||||
if [ -x "${GOBIN}/kyverno-json" ] && ! command -v kj >/dev/null 2>&1; then
|
||||
ln -sf "${GOBIN}/kyverno-json" "${GOBIN}/kj"
|
||||
# If GOBIN not on PATH, try /usr/local/bin so `which kj` resolves.
|
||||
if ! command -v kj >/dev/null 2>&1; then
|
||||
ln -sf "${GOBIN}/kyverno-json" /usr/local/bin/kj 2>/dev/null || true
|
||||
fi
|
||||
fi
|
||||
|
||||
if ! command -v kj >/dev/null 2>&1; then
|
||||
if [ -x "${GOBIN}/kyverno-json" ]; then
|
||||
echo "kyverno-json installed to ${GOBIN}/kyverno-json but 'kj' is not on PATH." >&2
|
||||
echo "add ${GOBIN} to PATH or symlink: ln -sf ${GOBIN}/kyverno-json /usr/local/bin/kj" >&2
|
||||
"${GOBIN}/kyverno-json" version
|
||||
exit 0
|
||||
fi
|
||||
echo "ERROR: kj not found on PATH after go install (checked ${GOBIN})." >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
echo "kj installed:"
|
||||
kj version
|
||||
echo "DONE"
|
||||
+107
-25
@@ -5,11 +5,20 @@
|
||||
# fallback) from the env to:
|
||||
# 1. List nova-spike-runner's access keys.
|
||||
# 2. Create a new key.
|
||||
# 3. Deactivate + delete the old key(s).
|
||||
# 4. Write the new key to gitignored .env.secrets (chmod 600).
|
||||
# 5. Optionally upload to Gitea secrets if NOVA_GITEA_TOKEN is set.
|
||||
# 3. Write the new key to gitignored .env.secrets (chmod 600).
|
||||
# 4. Upload the new key to the consumer's Actions secret store + verify
|
||||
# (GET) that it propagated (SPEC §5.9 idempotency).
|
||||
# 5. Deactivate + delete the old key(s) ONLY after the upload is verified.
|
||||
# If the upload/verify fails, the old key stays Active + the run exits
|
||||
# non-zero (the consumer's deploy keeps a working credential).
|
||||
#
|
||||
# Idempotent: re-running always ends with exactly 1 active key for the user.
|
||||
# Env vars (forge coords): NOVA_FORGE_TOKEN / NOVA_FORGE_BASE_URL /
|
||||
# NOVA_FORGE_OWNER / NOVA_CONSUMER_REPO (the scheduled workflow passes these
|
||||
# forge-agnostic names, REQ-230). NOVA_GITEA_* are a backward-compat
|
||||
# fallback for ad-hoc local runs.
|
||||
#
|
||||
# Idempotent: re-running always ends with exactly 1 active key for the user
|
||||
# (once the new key has propagated to the secret store).
|
||||
# Does NOT rotate the bootstrap root key (D-034 closure = manual user step).
|
||||
#
|
||||
# Spike scope (D-039): the spike user key is per-run-rotated; real OIDC is
|
||||
@@ -63,14 +72,9 @@ new_id = new["AccessKeyId"]
|
||||
new_secret = new["SecretAccessKey"]
|
||||
print(f"iam: created new key {new_id} for {user}", file=sys.stderr)
|
||||
|
||||
# Deactivate + delete the old keys.
|
||||
for k in active:
|
||||
old_id = k["AccessKeyId"]
|
||||
if old_id == new_id:
|
||||
continue
|
||||
iam.update_access_key(UserName=user, AccessKeyId=old_id, Status="Inactive")
|
||||
iam.delete_access_key(UserName=user, AccessKeyId=old_id)
|
||||
print(f"iam: deactivated+deleted old key {old_id}", file=sys.stderr)
|
||||
# Deactivation of the old keys is deferred to AFTER the new key propagates
|
||||
# to the Gitea Actions secret store (SPEC §5.9 idempotency — see below).
|
||||
# Writing .env.secrets first keeps the local operator's working key current.
|
||||
|
||||
# Write the new key to gitignored .env.secrets (chmod 600).
|
||||
# Nova rebrand (P2): keys are NOVA_*; the ACDL_* legacy keys are the
|
||||
@@ -82,28 +86,106 @@ with open(env_file, "w") as fh:
|
||||
os.chmod(env_file, 0o600)
|
||||
print(f"rotated key written to {env_file} (chmod 600)", file=sys.stderr)
|
||||
|
||||
# Optionally upload to Gitea secrets.
|
||||
# Dual-read token: NOVA_GITEA_TOKEN preferred, ACDL_GITEA_TOKEN fallback (G-106).
|
||||
gitea_token = os.environ.get("NOVA_GITEA_TOKEN")
|
||||
# Upload the new key to the consumer's Actions secret store BEFORE
|
||||
# deactivating the old key (SPEC §5.9 — idempotency: the old key is
|
||||
# deactivated only after the new one propagates). If the upload or the
|
||||
# post-upload verification fails, the old key is left Active so the
|
||||
# consumer's deploy still has a working credential; the run exits non-zero
|
||||
# so the scheduled workflow surfaces the failure (rather than silently
|
||||
# stranding the consumer with a key that never reached the secret store).
|
||||
#
|
||||
# Forge + consumer coords come from env vars. The scheduled workflow passes
|
||||
# forge-agnostic NOVA_FORGE_* names (REQ-230 — no forge hostnames in the
|
||||
# synced workflow file); NOVA_GITEA_* are accepted as a backward-compat
|
||||
# fallback for ad-hoc local runs. Defaults keep the legacy platform-repo
|
||||
# target when nothing is set.
|
||||
# Dual-read token: NOVA_FORGE_TOKEN preferred, NOVA_GITEA_TOKEN fallback (G-106).
|
||||
gitea_token = os.environ.get("NOVA_FORGE_TOKEN") or os.environ.get("NOVA_GITEA_TOKEN")
|
||||
gitea_base = (
|
||||
os.environ.get("NOVA_FORGE_BASE_URL")
|
||||
or os.environ.get("NOVA_GITEA_BASE_URL")
|
||||
or "https://git.cloudinit.dev"
|
||||
).rstrip("/")
|
||||
gitea_owner = (
|
||||
os.environ.get("NOVA_FORGE_OWNER")
|
||||
or os.environ.get("NOVA_GITEA_OWNER")
|
||||
or "continuous-intelligence"
|
||||
)
|
||||
gitea_repo = (
|
||||
os.environ.get("NOVA_CONSUMER_REPO")
|
||||
or os.environ.get("NOVA_GITEA_REPO")
|
||||
or "acdl"
|
||||
)
|
||||
secrets_api = f"{gitea_base}/api/v1/repos/{gitea_owner}/{gitea_repo}/actions/secrets"
|
||||
|
||||
if gitea_token:
|
||||
import urllib.request
|
||||
base = "https://git.cloudinit.dev/api/v1/repos/continuous-intelligence/acdl/actions/secrets"
|
||||
for name, value in [("NOVA_AWS_ACCESS_KEY_ID", new_id),
|
||||
("NOVA_AWS_SECRET_ACCESS_KEY", new_secret)]:
|
||||
import urllib.error
|
||||
import time
|
||||
|
||||
def _put_secret(name, value):
|
||||
req = urllib.request.Request(
|
||||
f"{base}/{name}",
|
||||
f"{secrets_api}/{name}",
|
||||
data=json.dumps({"value": value}).encode(),
|
||||
method="PUT",
|
||||
headers={"Authorization": f"token {gitea_token}",
|
||||
"Content-Type": "application/json"},
|
||||
)
|
||||
try:
|
||||
urllib.request.urlopen(req).read()
|
||||
print(f"gitea: secret {name} uploaded", file=sys.stderr)
|
||||
except Exception as e:
|
||||
print(f"gitea: secret {name} upload FAILED: {e}", file=sys.stderr)
|
||||
urllib.request.urlopen(req).read()
|
||||
print(f"gitea: secret {name} uploaded to {gitea_owner}/{gitea_repo}", file=sys.stderr)
|
||||
|
||||
def _verify_secret(name):
|
||||
# Gitea does not return secret *values*; a 200 confirms the secret
|
||||
# exists with the expected name. Retry briefly so eventual
|
||||
# consistency on the secrets API settles (observed sub-second lag).
|
||||
for attempt in range(5):
|
||||
req = urllib.request.Request(
|
||||
f"{secrets_api}/{name}",
|
||||
method="GET",
|
||||
headers={"Authorization": f"token {gitea_token}"},
|
||||
)
|
||||
try:
|
||||
with urllib.request.urlopen(req) as resp:
|
||||
if resp.status == 200:
|
||||
print(f"gitea: secret {name} verified present", file=sys.stderr)
|
||||
return True
|
||||
except urllib.error.HTTPError as e:
|
||||
if e.code == 404:
|
||||
time.sleep(0.5)
|
||||
continue
|
||||
raise
|
||||
return False
|
||||
|
||||
try:
|
||||
_put_secret("NOVA_AWS_ACCESS_KEY_ID", new_id)
|
||||
_put_secret("NOVA_AWS_SECRET_ACCESS_KEY", new_secret)
|
||||
ok = _verify_secret("NOVA_AWS_ACCESS_KEY_ID") and \
|
||||
_verify_secret("NOVA_AWS_SECRET_ACCESS_KEY")
|
||||
if not ok:
|
||||
raise RuntimeError("gitea secret verification failed (404 after PUT)")
|
||||
except Exception as e:
|
||||
# Upload/verify failed: leave the old key Active so the consumer's
|
||||
# deploy still works. Surface non-zero so the schedule is noisy.
|
||||
print(f"gitea: secret upload/verify FAILED ({e}); old key left Active", file=sys.stderr)
|
||||
sys.exit(2)
|
||||
else:
|
||||
print("gitea: NOVA_GITEA_TOKEN not set; Gitea secret upload skipped (v1.2 hardening)", file=sys.stderr)
|
||||
print("gitea: NOVA_FORGE_TOKEN/NOVA_GITEA_TOKEN not set; secret upload skipped (v1.2 hardening)", file=sys.stderr)
|
||||
# No forge target → the new key is already in .env.secrets, so the
|
||||
# operator's local env works. The old key is deactivated below so the
|
||||
# user ends with exactly 1 active key (D-039 local-rotation contract).
|
||||
|
||||
# Deactivate + delete the old keys. When a forge token was set, this runs
|
||||
# ONLY after the new key propagated to the consumer's secret store (the
|
||||
# sys.exit(2) above prevents reaching here on upload/verify failure). When
|
||||
# no token was set, the new key is already in .env.secrets so deactivating
|
||||
# is safe (D-039 local-rotation contract).
|
||||
for k in active:
|
||||
old_id = k["AccessKeyId"]
|
||||
if old_id == new_id:
|
||||
continue
|
||||
iam.update_access_key(UserName=user, AccessKeyId=old_id, Status="Inactive")
|
||||
iam.delete_access_key(UserName=user, AccessKeyId=old_id)
|
||||
print(f"iam: deactivated+deleted old key {old_id} (after propagation)", file=sys.stderr)
|
||||
|
||||
print(f"OK: {user} now has exactly 1 active key: {new_id}")
|
||||
PY
|
||||
+111
-7
@@ -382,12 +382,22 @@ if [ -z "${AWS_ACCESS_KEY_ID:-}" ] || [ -z "${AWS_SECRET_ACCESS_KEY:-}" ]; then
|
||||
[ -f "$ENV_FILE" ] || fail ".env.secrets missing (run scripts/rotate_spike_key.sh) or set AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY env vars"
|
||||
set -a
|
||||
. "$ENV_FILE"
|
||||
set +a
|
||||
# P5 (REQ-164): dual-read fallback removed — NOVA_* only.
|
||||
export AWS_ACCESS_KEY_ID="$NOVA_AWS_ACCESS_KEY_ID"
|
||||
export AWS_SECRET_ACCESS_KEY="$NOVA_AWS_SECRET_ACCESS_KEY"
|
||||
export AWS_DEFAULT_REGION="$AWS_DEFAULT_REGION"
|
||||
fi
|
||||
set +a
|
||||
# P5 (REQ-164): dual-read fallback removed — NOVA_* only.
|
||||
# Copy the NOVA_* secrets to the canonical AWS_* env vars, then unset
|
||||
# the raw NOVA_AWS_* + the forge-token name so they do NOT linger in
|
||||
# the shell env (SPEC §5.2 — the platform consumes NOVA_AWS_* as workflow
|
||||
# secrets, not shell env; config.security.bash_allowlist.blocked_env_vars
|
||||
# blocks NOVA_AWS_* from shell env — the v1.8 root-cause guard).
|
||||
# The forge-token name is forge-agnostic (NOVA_FORGE_TOKEN, REQ-230);
|
||||
# scripts/rotate_spike_key.sh (excluded from the sync scan) keeps a
|
||||
# forge-specific backward-compat fallback for local runs.
|
||||
export AWS_ACCESS_KEY_ID="$NOVA_AWS_ACCESS_KEY_ID"
|
||||
export AWS_SECRET_ACCESS_KEY="$NOVA_AWS_SECRET_ACCESS_KEY"
|
||||
# Region: prefer the .env.secrets AWS_DEFAULT_REGION; default us-east-1.
|
||||
export AWS_DEFAULT_REGION="${AWS_DEFAULT_REGION:-us-east-1}"
|
||||
unset NOVA_AWS_ACCESS_KEY_ID NOVA_AWS_SECRET_ACCESS_KEY NOVA_FORGE_TOKEN
|
||||
fi
|
||||
|
||||
echo "=== Step 3c: Checkov on static code (fail-fast, before terraform plan) ==="
|
||||
# REQ-250 (v1.21): Checkov runs on the authored Terraform code BEFORE
|
||||
@@ -518,8 +528,102 @@ for pcr in pcrs:
|
||||
marker = 'PASS' if res == 'pass' else 'FAIL' if res == 'fail' else 'SKIP' if res == 'skipped' else res.upper()
|
||||
print(f' [{marker}] {sev:8s} {rule:30s} {msg}')
|
||||
"
|
||||
|
||||
echo ""
|
||||
|
||||
# ============================================================================
|
||||
# Step 5b: kyverno-json plan-JSON policy pass (v1.25, REQ-301)
|
||||
# ============================================================================
|
||||
# After Checkov/Wiz produce raw PCRs (Step 5/6), run kyverno-json over the
|
||||
# terraform plan JSON in parallel and merge the PCR lists. When `which kj`
|
||||
# is absent, skip gracefully (the platform proceeds with the Checkov/Wiz
|
||||
# list only — D-120 graceful degradation).
|
||||
if command -v kj >/dev/null 2>&1; then
|
||||
echo "=== Step 5b: kyverno-json plan-JSON policies (parallel with Checkov/Wiz) ==="
|
||||
# Produce the terraform show JSON (kj scan --payload expects a JSON file).
|
||||
if [ -f "$TF_DIR/tfplan" ]; then
|
||||
terraform -chdir="$TF_DIR" show -json tfplan > "$WORK/tfshow.json" 2>/dev/null || true
|
||||
if [ -s "$WORK/tfshow.json" ]; then
|
||||
python3 - "$WORK/tfshow.json" "$CONTRACT_ID" <<'PY' > "$WORK/kj-pcr.json" 2>"$WORK/kj.err" || echo "[]"
|
||||
import json, sys
|
||||
from pathlib import Path
|
||||
sys.path.insert(0, ".")
|
||||
import importlib.util
|
||||
_spec = importlib.util.spec_from_file_location("kj_engine", "adapters/kyverno-json/kyverno_json_engine.py")
|
||||
_mod = importlib.util.module_from_spec(_spec)
|
||||
_spec.loader.exec_module(_mod)
|
||||
_payload_path, _contract_id = sys.argv[1], sys.argv[2]
|
||||
eng = _mod.KyvernoJsonEngine()
|
||||
if not eng.is_configured():
|
||||
print("[]"); sys.exit(0)
|
||||
out = eng.evaluate(json.load(open(_payload_path)), Path("adapters/kyverno-json/policies/plan-json"), _contract_id)
|
||||
print(json.dumps(out))
|
||||
PY
|
||||
if [ -s "$WORK/kj-pcr.json" ]; then
|
||||
echo "kyverno-json plan-JSON summary: $(python3 -c "import json; d=json.load(open('$WORK/kj-pcr.json')); print(len([p for p in d if p.get('result')=='fail']), 'failed,', len([p for p in d if p.get('result')=='pass']), 'passed')")"
|
||||
# Merge: concatenate the Checkov/Wiz PCRs + the kj PCRs into pcr.json.
|
||||
python3 -c "
|
||||
import json
|
||||
ckv = json.load(open('$WORK/pcr.json'))
|
||||
kj = json.load(open('$WORK/kj-pcr.json'))
|
||||
json.dump(ckv + kj, open('$WORK/pcr.json', 'w'))
|
||||
print(f'merged PCR list: {len(ckv)} checkov/wiz + {len(kj)} kyverno-json = {len(ckv)+len(kj)} total')
|
||||
"
|
||||
else
|
||||
echo "kyverno-json produced no output; proceeding with Checkov/Wiz PCRs only"
|
||||
fi
|
||||
else
|
||||
echo "terraform show -json produced no output; skipping kyverno-json plan-JSON policies"
|
||||
fi
|
||||
else
|
||||
echo "tfplan not found; skipping kyverno-json plan-JSON policies"
|
||||
fi
|
||||
else
|
||||
echo "=== Step 5b: kyverno-json not installed; skipping plan-JSON policies (D-120 graceful degradation) ==="
|
||||
fi
|
||||
echo ""
|
||||
|
||||
# ============================================================================
|
||||
# Step 5c: kyverno-json meta-policies over the merged PCR list (v1.25, REQ-303)
|
||||
# ============================================================================
|
||||
# After Step 5b merges the Checkov/Wiz + kj plan-JSON PCRs into pcr.json, run
|
||||
# the meta-policies (block-on-any-critical, tagging-rules-agree) over the
|
||||
# merged list. The meta-policy PCRs are appended to pcr.json before the
|
||||
# confidence signal runs. The confidence_signal.py PENALTY["critical"]: None
|
||||
# hard-override stays as defense-in-depth behind this declarative rule
|
||||
# (D-119). Skips gracefully when kj is absent (D-120).
|
||||
if command -v kj >/dev/null 2>&1 && [ -s "$WORK/pcr.json" ]; then
|
||||
echo "=== Step 5c: kyverno-json meta-policies over the merged PCR list ==="
|
||||
python3 - "$WORK/pcr.json" "$CONTRACT_ID" <<'PY' > "$WORK/meta-pcr.json" 2>"$WORK/meta.err" || echo "[]"
|
||||
import json, sys
|
||||
from pathlib import Path
|
||||
sys.path.insert(0, ".")
|
||||
import importlib.util
|
||||
_spec = importlib.util.spec_from_file_location("kj_engine", "adapters/kyverno-json/kyverno_json_engine.py")
|
||||
_mod = importlib.util.module_from_spec(_spec)
|
||||
_spec.loader.exec_module(_mod)
|
||||
eng = _mod.KyvernoJsonEngine()
|
||||
if not eng.is_configured():
|
||||
print("[]"); sys.exit(0)
|
||||
pcrs = json.load(open(sys.argv[1]))
|
||||
out = eng.evaluate(pcrs, Path("adapters/kyverno-json/policies/meta"), sys.argv[2])
|
||||
print(json.dumps(out))
|
||||
PY
|
||||
if [ -s "$WORK/meta-pcr.json" ]; then
|
||||
python3 -c "
|
||||
import json
|
||||
merged = json.load(open('$WORK/pcr.json'))
|
||||
meta = json.load(open('$WORK/meta-pcr.json'))
|
||||
json.dump(merged + meta, open('$WORK/pcr.json', 'w'))
|
||||
print(f'meta-policies: {len(meta)} meta-PCRs appended; total PCR list now {len(merged)+len(meta)}')
|
||||
"
|
||||
else
|
||||
echo "kyverno-json meta-policies produced no output; proceeding with the merged list only"
|
||||
fi
|
||||
else
|
||||
echo "=== Step 5c: kj not installed or no merged PCR list; skipping meta-policies (D-120) ==="
|
||||
fi
|
||||
echo ""
|
||||
|
||||
echo "=== Step 7: confidence signal compute ==="
|
||||
python3 <<PY > "$WORK/signal.json" || fail "confidence signal failed"
|
||||
import json
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
"""Sync byte-identical workflows from workflows-src/ to .gitea/ + .github/ (P8, REQ-172).
|
||||
|
||||
Three workflow pairs are byte-identical Gitea + GitHub mirrors:
|
||||
ci.yml, deploy.yml, modules-lifecycle.yml.
|
||||
ci.yml, deploy.yml, modules-lifecycle.yml, rotate-aws-key.yml.
|
||||
|
||||
This generator reads the single source from ``workflows-src/<name>`` and
|
||||
writes byte-identical copies to both ``.gitea/workflows/<name>`` and
|
||||
@@ -26,7 +26,7 @@ SRC_DIR = ROOT / "workflows-src"
|
||||
GITEA_DIR = ROOT / ".gitea" / "workflows"
|
||||
GITHUB_DIR = ROOT / ".github" / "workflows"
|
||||
|
||||
PAIRS = ["ci.yml", "deploy.yml", "modules-lifecycle.yml"]
|
||||
PAIRS = ["ci.yml", "deploy.yml", "modules-lifecycle.yml", "rotate-aws-key.yml"]
|
||||
|
||||
|
||||
def _read_source(name: str) -> str:
|
||||
|
||||
@@ -5,15 +5,15 @@ policy if absent (or creates a new version if the policy document
|
||||
differs), attaches it to the spike-runner user, deletes any leftover
|
||||
inline policy, and re-creates the OIDC act_runner role if absent.
|
||||
|
||||
Requires the bootstrap root key (ACDL_BOOTSTRAP_AWS_* or ACDL_AWS_*
|
||||
Requires the bootstrap root key (NOVA_BOOTSTRAP_AWS_* or NOVA_AWS_*
|
||||
when the provided key is a root principal). This script is the
|
||||
reproducible record of the Phase 56 live step — the grants are
|
||||
documented in .ciagent/IAM_POLICY.md and regression-tested by
|
||||
tests/test_iam_policy_baseline.py.
|
||||
|
||||
Usage:
|
||||
export ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID=<root key id>
|
||||
export ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY=<root key secret>
|
||||
export NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID=<root key id>
|
||||
export NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY=<root key secret>
|
||||
export AWS_DEFAULT_REGION=us-east-1
|
||||
python3 terraform/bootstrap/apply_iam_baseline.py
|
||||
"""
|
||||
@@ -30,7 +30,7 @@ import boto3
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent.parent
|
||||
POLICY_PATH = ROOT / "terraform" / "bootstrap" / "spike_runner_policy.json"
|
||||
ACCOUNT = os.environ.get("ACDL_AWS_ACCOUNT_ID", "581513795199")
|
||||
ACCOUNT = os.environ.get("NOVA_AWS_ACCOUNT_ID", "581513795199")
|
||||
USER = "nova-spike-runner"
|
||||
POLICY_NAME = "nova-spike-runner-policy"
|
||||
POLICY_ARN = f"arn:aws:iam::{ACCOUNT}:policy/{POLICY_NAME}"
|
||||
@@ -38,10 +38,10 @@ ROLE_NAME = "nova-act-runner-role"
|
||||
|
||||
|
||||
def _session():
|
||||
key_id = os.environ.get("ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID") or os.environ.get("ACDL_AWS_ACCESS_KEY_ID")
|
||||
secret = os.environ.get("ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY") or os.environ.get("ACDL_AWS_SECRET_ACCESS_KEY")
|
||||
key_id = os.environ.get("NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID") or os.environ.get("NOVA_AWS_ACCESS_KEY_ID")
|
||||
secret = os.environ.get("NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY") or os.environ.get("NOVA_AWS_SECRET_ACCESS_KEY")
|
||||
if not key_id or not secret:
|
||||
sys.exit("FAIL: set ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID + ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY (root key)")
|
||||
sys.exit("FAIL: set NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID + NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY (root key)")
|
||||
region = os.environ.get("AWS_DEFAULT_REGION", "us-east-1")
|
||||
return boto3.Session(aws_access_key_id=key_id, aws_secret_access_key=secret, region_name=region)
|
||||
|
||||
|
||||
@@ -3,12 +3,14 @@
|
||||
Idempotent: skips user creation if the user exists; creates an initial
|
||||
access key if none active exists. Prints the key to stdout for the
|
||||
orchestrator to capture (NEVER committed):
|
||||
ACDL_AWS_ACCESS_KEY_ID=<...>
|
||||
ACDL_AWS_SECRET_ACCESS_KEY=<...>
|
||||
NOVA_AWS_ACCESS_KEY_ID=<...>
|
||||
NOVA_AWS_SECRET_ACCESS_KEY=<...>
|
||||
|
||||
Run with the bootstrap root key in env:
|
||||
ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID / ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY
|
||||
AWS_DEFAULT_REGION (defaults to us-east-1)
|
||||
NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID / NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY
|
||||
(falls back to NOVA_AWS_ACCESS_KEY_ID / NOVA_AWS_SECRET_ACCESS_KEY when
|
||||
the provided key is a root principal). AWS_DEFAULT_REGION (defaults
|
||||
to us-east-1).
|
||||
|
||||
The inline policy is read from spike_runner_policy.json (next to this
|
||||
file). The account id + region are already substituted in the policy file
|
||||
@@ -38,9 +40,13 @@ POLICY_FILE = os.path.join(os.path.dirname(__file__), "spike_runner_policy.json"
|
||||
|
||||
|
||||
def main():
|
||||
key_id = os.environ.get("NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID") or os.environ.get("NOVA_AWS_ACCESS_KEY_ID")
|
||||
secret = os.environ.get("NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY") or os.environ.get("NOVA_AWS_SECRET_ACCESS_KEY")
|
||||
if not key_id or not secret:
|
||||
sys.exit("FAIL: set NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID + NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY (root key)")
|
||||
session = boto3.Session(
|
||||
aws_access_key_id=os.environ["ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID"],
|
||||
aws_secret_access_key=os.environ["ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY"],
|
||||
aws_access_key_id=key_id,
|
||||
aws_secret_access_key=secret,
|
||||
region_name=REGION,
|
||||
)
|
||||
iam = session.client("iam")
|
||||
@@ -71,8 +77,8 @@ def main():
|
||||
print(" (use scripts/rotate_spike_key.sh to rotate)")
|
||||
return
|
||||
new_key = iam.create_access_key(UserName=USER_NAME)["AccessKey"]
|
||||
print("ACDL_AWS_ACCESS_KEY_ID=" + new_key["AccessKeyId"])
|
||||
print("ACDL_AWS_SECRET_ACCESS_KEY=" + new_key["SecretAccessKey"])
|
||||
print("NOVA_AWS_ACCESS_KEY_ID=" + new_key["AccessKeyId"])
|
||||
print("NOVA_AWS_SECRET_ACCESS_KEY=" + new_key["SecretAccessKey"])
|
||||
print(f"iam: created initial access key {new_key['AccessKeyId']} for {USER_NAME}", file=sys.stderr)
|
||||
|
||||
|
||||
|
||||
@@ -6,8 +6,10 @@
|
||||
evidence outbox (D-P08-1).
|
||||
|
||||
Run with the bootstrap root key in env:
|
||||
ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID / ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY
|
||||
AWS_DEFAULT_REGION (defaults to us-east-1)
|
||||
NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID / NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY
|
||||
(falls back to NOVA_AWS_ACCESS_KEY_ID / NOVA_AWS_SECRET_ACCESS_KEY when
|
||||
the provided key is a root principal). AWS_DEFAULT_REGION (defaults
|
||||
to us-east-1).
|
||||
|
||||
Writes terraform/bootstrap/.bootstrap_state.json (gitignored bookkeeping).
|
||||
|
||||
@@ -30,15 +32,19 @@ import boto3
|
||||
|
||||
|
||||
REGION = os.environ.get("AWS_DEFAULT_REGION", "us-east-1")
|
||||
ACCOUNT_ID = os.environ.get("ACDL_AWS_ACCOUNT_ID", "581513795199")
|
||||
ACCOUNT_ID = os.environ.get("NOVA_AWS_ACCOUNT_ID", "581513795199")
|
||||
STATE_BUCKET = f"nova-tfstate-{ACCOUNT_ID}-us-east-1"
|
||||
OUTBOX_TABLE = "nova-outbox"
|
||||
|
||||
|
||||
def main():
|
||||
key_id = os.environ.get("NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID") or os.environ.get("NOVA_AWS_ACCESS_KEY_ID")
|
||||
secret = os.environ.get("NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY") or os.environ.get("NOVA_AWS_SECRET_ACCESS_KEY")
|
||||
if not key_id or not secret:
|
||||
sys.exit("FAIL: set NOVA_BOOTSTRAP_AWS_ACCESS_KEY_ID + NOVA_BOOTSTRAP_AWS_SECRET_ACCESS_KEY (root key)")
|
||||
session = boto3.Session(
|
||||
aws_access_key_id=os.environ["ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID"],
|
||||
aws_secret_access_key=os.environ["ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY"],
|
||||
aws_access_key_id=key_id,
|
||||
aws_secret_access_key=secret,
|
||||
region_name=REGION,
|
||||
)
|
||||
s3 = session.client("s3", region_name=REGION)
|
||||
|
||||
+11
@@ -0,0 +1,11 @@
|
||||
{
|
||||
"adapters": ["terraform", "checkov", "wiz", "kyverno-json"],
|
||||
"metrics": [
|
||||
{"name": "MTTR", "status": "grounded"},
|
||||
{"name": "CloudSpend", "status": "derived"},
|
||||
{"name": "TouchlessResolution", "status": "deferred"}
|
||||
],
|
||||
"deck": {
|
||||
"beats": ["Problem", "Solution", "Proof", "Roadmap+Ask"]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,11 @@
|
||||
{
|
||||
"adapters": ["terraform", "checkov", "wiz", "terraform", "kyverno-json"],
|
||||
"metrics": [
|
||||
{"name": "MTTR", "status": "grounded"},
|
||||
{"name": "CloudSpend", "status": "unknown"},
|
||||
{"name": "TouchlessResolution", "status": "deferred"}
|
||||
],
|
||||
"deck": {
|
||||
"beats": ["Problem", "Solution", "Proof"]
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,4 @@
|
||||
{
|
||||
"account_id": "000000000000",
|
||||
"region": "us-east-1"
|
||||
}
|
||||
@@ -0,0 +1,7 @@
|
||||
{
|
||||
"account_id": "581513795199",
|
||||
"region": "us-east-1",
|
||||
"state_backend": {
|
||||
"bucket": "nova-tfstate-dev"
|
||||
}
|
||||
}
|
||||
+35
@@ -0,0 +1,35 @@
|
||||
{
|
||||
"planned_values": {
|
||||
"root_module": {
|
||||
"resources": [
|
||||
{
|
||||
"address": "aws_db_instance.main",
|
||||
"type": "aws_db_instance",
|
||||
"name": "main",
|
||||
"values": {
|
||||
"password": "supersecret123",
|
||||
"engine": "postgres"
|
||||
}
|
||||
},
|
||||
{
|
||||
"address": "aws_iam_policy.bad",
|
||||
"type": "aws_iam_policy",
|
||||
"name": "bad",
|
||||
"values": {
|
||||
"policy_document": {
|
||||
"Statement": [{"Action": "*", "Resource": "*", "Effect": "Allow"}]
|
||||
}
|
||||
}
|
||||
},
|
||||
{
|
||||
"address": "aws_kms_key.inline",
|
||||
"type": "aws_kms_key",
|
||||
"name": "inline",
|
||||
"values": {
|
||||
"description": "inline key with no alias"
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
+27
@@ -0,0 +1,27 @@
|
||||
{
|
||||
"planned_values": {
|
||||
"root_module": {
|
||||
"resources": [
|
||||
{
|
||||
"address": "aws_s3_bucket.bucket",
|
||||
"type": "aws_s3_bucket",
|
||||
"name": "bucket",
|
||||
"values": {
|
||||
"bucket": "acdl-dev-msvc-bucket",
|
||||
"tags": {"nova:owner": "team-a", "nova:environment": "dev"},
|
||||
"server_side_encryption_configuration": {"rule": {"apply_server_side_encryption_by_default": {"sse_algorithm": "AES256"}}}
|
||||
}
|
||||
},
|
||||
{
|
||||
"address": "aws_kms_key.main",
|
||||
"type": "aws_kms_key",
|
||||
"name": "main",
|
||||
"values": {
|
||||
"key_id": "alias/nova-main",
|
||||
"customer_master_key_spec": "SYMMETRIC_DEFAULT"
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,6 @@
|
||||
{
|
||||
"contract_id": "blkex",
|
||||
"environment": "dev",
|
||||
"all_committed": true,
|
||||
"matches": []
|
||||
}
|
||||
@@ -0,0 +1,13 @@
|
||||
{
|
||||
"contract_id": "blkex",
|
||||
"environment": "dev",
|
||||
"all_committed": false,
|
||||
"matches": [
|
||||
{
|
||||
"txn_id": "t1",
|
||||
"symbol": "AAPL",
|
||||
"finalized": false,
|
||||
"block_index": 1
|
||||
}
|
||||
]
|
||||
}
|
||||
Vendored
+34
@@ -0,0 +1,34 @@
|
||||
{
|
||||
"version": "1.0.0",
|
||||
"stack": {
|
||||
"name": "bad",
|
||||
"title": "failing stack",
|
||||
"kind": "l1",
|
||||
"depth": 1,
|
||||
"environment": "dev"
|
||||
},
|
||||
"resources": [
|
||||
{
|
||||
"id": "bucket",
|
||||
"type": "aws:s3:bucket",
|
||||
"module": "s3@1.0.0",
|
||||
"inputs": {
|
||||
"bucket_name": "acdl-dev-bad-bucket",
|
||||
"region": "us-east-1",
|
||||
"tags": {
|
||||
"nova:owner": "team-a"
|
||||
}
|
||||
}
|
||||
},
|
||||
{
|
||||
"id": "service",
|
||||
"type": "aws:ecs:service",
|
||||
"module": "microservice@1.0.0",
|
||||
"inputs": {
|
||||
"image": "nginx:latest",
|
||||
"port": 80,
|
||||
"public_ingress": true
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
Vendored
+43
@@ -0,0 +1,43 @@
|
||||
{
|
||||
"version": "1.0.0",
|
||||
"stack": {
|
||||
"name": "msvc",
|
||||
"title": "microservice",
|
||||
"kind": "l1",
|
||||
"depth": 1,
|
||||
"environment": "dev"
|
||||
},
|
||||
"resources": [
|
||||
{
|
||||
"id": "bucket",
|
||||
"type": "aws:s3:bucket",
|
||||
"module": "s3@1.0.0",
|
||||
"inputs": {
|
||||
"bucket_name": "acdl-dev-msvc-bucket",
|
||||
"region": "us-east-1",
|
||||
"bucket_encryption": {"rule": {"apply_server_side_encryption_by_default": {"sse_algorithm": "AES256"}}},
|
||||
"tags": {
|
||||
"nova:owner": "team-a",
|
||||
"nova:contract": "msvc",
|
||||
"nova:environment": "dev",
|
||||
"nova:cost-center": "cc-1"
|
||||
}
|
||||
}
|
||||
},
|
||||
{
|
||||
"id": "service",
|
||||
"type": "aws:ecs:service",
|
||||
"module": "microservice@1.0.0",
|
||||
"inputs": {
|
||||
"image": "nginx:latest",
|
||||
"port": 80,
|
||||
"tags": {
|
||||
"nova:owner": "team-a",
|
||||
"nova:contract": "msvc",
|
||||
"nova:environment": "dev",
|
||||
"nova:cost-center": "cc-1"
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
+11
-6
@@ -30,14 +30,14 @@ class TestInstance:
|
||||
|
||||
|
||||
class TestRegistry:
|
||||
EXPECTED_L1_KEYS = {"s3", "vpc", "ecs-cluster", "ecs-service", "iam-role", "alb", "ecr", "cloudfront", "waf", "rds", "kms-key", "uptime"}
|
||||
EXPECTED_L1_KEYS = {"s3", "vpc", "ecs-cluster", "ecs-service", "iam-role", "alb", "ecr", "cloudfront", "waf", "rds", "kms-key", "uptime", "dynamodb"}
|
||||
EXPECTED_L2_KEYS = {"static-assets", "microservice"}
|
||||
|
||||
def test_registry_has_14_entries(self, registry):
|
||||
assert len(registry) == 14
|
||||
def test_registry_has_15_entries(self, registry):
|
||||
assert len(registry) == 15
|
||||
assert set(registry.keys()) == (self.EXPECTED_L1_KEYS | self.EXPECTED_L2_KEYS)
|
||||
|
||||
def test_registry_has_12_l1_entries(self, registry):
|
||||
def test_registry_has_13_l1_entries(self, registry):
|
||||
l1 = {k for k in registry if registry[k]["1.0.0"]["interface"].startswith("modules/l1/")}
|
||||
assert l1 == self.EXPECTED_L1_KEYS
|
||||
|
||||
@@ -229,10 +229,15 @@ class TestAdapterStatelessness:
|
||||
adapter_src = (ROOT / "adapters/terraform/adapter.py").read_text()
|
||||
assert 'rtype ==' not in adapter_src
|
||||
|
||||
def test_adapter_under_200_lines(self):
|
||||
def test_adapter_under_250_lines(self):
|
||||
# P03 W3 (REQ-319): the adapter now loads the env onboarding JSON to
|
||||
# source env.state_backend.bucket + env.account_id + env.region for
|
||||
# the S3 backend block (two small helpers). The bound is 250 (was
|
||||
# 200) — still a tight statelessness guardrail against type-specific
|
||||
# logic / constant tables creeping back in.
|
||||
adapter_path = ROOT / "adapters/terraform/adapter.py"
|
||||
line_count = len(adapter_path.read_text().splitlines())
|
||||
assert line_count < 200, f"adapter is {line_count} lines, expected < 200"
|
||||
assert line_count < 250, f"adapter is {line_count} lines, expected < 250"
|
||||
|
||||
|
||||
class TestAdapterEmitsValidTerraform:
|
||||
|
||||
@@ -0,0 +1,195 @@
|
||||
"""P03 W3 (REQ-319): adapter state-backend bucket resolution tests.
|
||||
|
||||
The adapter reads env.state_backend.bucket from the env onboarding JSON
|
||||
(core/environments/<env>.json) when present, falling back to the computed
|
||||
nova-tfstate-{account_id}-{region} pattern for backwards compat. dev is
|
||||
bound to the real account 581513795199 + bucket
|
||||
nova-tfstate-581513795199-us-east-1 (D-203); qa/prod/dr stay placeholder
|
||||
(account_id 000000000000 — the pilot-readiness policy blocks apply on
|
||||
placeholder, D-208).
|
||||
"""
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||
|
||||
from adapters.terraform.adapter import adapt, _resolve_state_bucket, _load_env_json
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
|
||||
|
||||
def _emit(env_name, tmp_path, **stack_overrides):
|
||||
"""Run the adapter against a minimal s3 stack in the given environment."""
|
||||
stack = {
|
||||
"version": "1.0.0",
|
||||
"stack": {"name": "spike", "kind": "l1", "depth": 1, "environment": env_name},
|
||||
"resources": [
|
||||
{"id": "s3", "type": "aws:s3:bucket", "module": "s3@1.0.0",
|
||||
"inputs": {"bucket_name": "test", "region": "us-east-1"}}
|
||||
],
|
||||
}
|
||||
stack.update(stack_overrides)
|
||||
adapt(stack, str(tmp_path))
|
||||
return (tmp_path / "terraform.tf").read_text()
|
||||
|
||||
|
||||
class TestDevUsesRealStateBucket:
|
||||
def test_dev_uses_real_state_bucket(self, tmp_path):
|
||||
"""dev.json is bound to the real account + bucket (D-203)."""
|
||||
tf = _emit("dev", tmp_path)
|
||||
assert 'bucket = "nova-tfstate-581513795199-us-east-1"' in tf
|
||||
|
||||
def test_dev_account_id_is_real(self):
|
||||
env_json = _load_env_json("dev", str(ROOT))
|
||||
assert env_json["account_id"] == "581513795199"
|
||||
|
||||
def test_dev_state_backend_bucket_matches_bootstrap(self):
|
||||
"""The dev env JSON bucket matches the bootstrap-created bucket
|
||||
(terraform/bootstrap/create_state_backend.py +
|
||||
terraform/platform/main.tf)."""
|
||||
env_json = _load_env_json("dev", str(ROOT))
|
||||
assert env_json["state_backend"]["bucket"] == "nova-tfstate-581513795199-us-east-1"
|
||||
|
||||
|
||||
class TestFallbackComputedName:
|
||||
def test_fallback_computed_name_when_no_state_backend(self):
|
||||
"""An env JSON without state_backend.bucket → the adapter falls back
|
||||
to nova-tfstate-{account_id}-{region}."""
|
||||
env_json = {"account_id": "123456789012", "region": "us-west-2"}
|
||||
assert _resolve_state_bucket(env_json, "us-west-2") == "nova-tfstate-123456789012-us-west-2"
|
||||
|
||||
def test_fallback_uses_account_id_from_env_json(self, tmp_path):
|
||||
"""When state_backend.bucket is absent, the computed name uses
|
||||
account_id from the env JSON (not a hardcoded default)."""
|
||||
env_json = {"account_id": "999999999999", "region": "us-east-1"}
|
||||
assert _resolve_state_bucket(env_json, "us-east-1") == "nova-tfstate-999999999999-us-east-1"
|
||||
|
||||
def test_fallback_to_real_account_when_account_id_absent(self):
|
||||
"""When account_id is also absent, fall back to the only real
|
||||
account (581513795199 — the bootstrap bucket)."""
|
||||
env_json = {}
|
||||
assert _resolve_state_bucket(env_json, "us-east-1") == "nova-tfstate-581513795199-us-east-1"
|
||||
|
||||
def test_empty_env_json_falls_back(self, tmp_path):
|
||||
"""An env JSON with no state_backend block at all → computed name."""
|
||||
# Use an environment name with no JSON file → _load_env_json returns {}.
|
||||
tf = _emit("nonexistent-env", tmp_path)
|
||||
assert "nova-tfstate-581513795199-us-east-1" in tf
|
||||
|
||||
def test_empty_bucket_string_falls_back(self):
|
||||
"""An empty state_backend.bucket string → fall back to computed name."""
|
||||
env_json = {"account_id": "111111111111", "region": "eu-west-1",
|
||||
"state_backend": {"bucket": "", "lock_table": "x"}}
|
||||
assert _resolve_state_bucket(env_json, "eu-west-1") == "nova-tfstate-111111111111-eu-west-1"
|
||||
|
||||
|
||||
class TestQaPlaceholderAccount:
|
||||
def test_qa_placeholder_account(self, tmp_path):
|
||||
"""qa env JSON has account_id 000000000000 (placeholder, D-208) —
|
||||
the pilot-readiness policy blocks apply on placeholder. The adapter
|
||||
still emits the computed bucket name with the placeholder account."""
|
||||
tf = _emit("qa", tmp_path)
|
||||
# qa.json has state_backend.bucket = nova-tfstate-000000000000-us-east-1
|
||||
assert 'bucket = "nova-tfstate-000000000000-us-east-1"' in tf
|
||||
|
||||
def test_qa_account_id_is_placeholder(self):
|
||||
env_json = _load_env_json("qa", str(ROOT))
|
||||
assert env_json["account_id"] == "000000000000"
|
||||
|
||||
def test_prod_account_id_is_placeholder(self):
|
||||
env_json = _load_env_json("prod", str(ROOT))
|
||||
assert env_json["account_id"] == "000000000000"
|
||||
|
||||
def test_dr_account_id_is_placeholder(self):
|
||||
env_json = _load_env_json("dr", str(ROOT))
|
||||
assert env_json["account_id"] == "000000000000"
|
||||
|
||||
|
||||
class TestStateKeyEnvScoped:
|
||||
def test_state_key_remains_env_scoped(self, tmp_path):
|
||||
"""The state key path stays env-scoped:
|
||||
spike/{stack_name}/{environment}/terraform.tfstate (REQ-287)."""
|
||||
tf = _emit("dev", tmp_path, **{
|
||||
"version": "1.0.0",
|
||||
"stack": {"name": "msvc", "kind": "l2", "depth": 1, "environment": "dev"},
|
||||
"resources": [
|
||||
{"id": "s3", "type": "aws:s3:bucket", "module": "s3@1.0.0",
|
||||
"inputs": {"bucket_name": "test", "region": "us-east-1"}}
|
||||
],
|
||||
})
|
||||
assert "spike/msvc/dev/terraform.tfstate" in tf
|
||||
|
||||
|
||||
class TestDynamodbL1Emission:
|
||||
"""W3 Task 3.5: the dynamodb L1 primitive (landed in P2, REQ-322)
|
||||
resolves + emits an aws_dynamodb_table module block with PK block_index,
|
||||
PAY_PER_REQUEST."""
|
||||
|
||||
def test_dynamodb_resolves_and_emits_module_block(self, tmp_path):
|
||||
from core.contract_resolver import resolve
|
||||
# Resolve a contract with an infrastructure.dynamodb block.
|
||||
contract = {
|
||||
"id": "ddb", "name": "dynamodb-test", "environment": "dev",
|
||||
"infrastructure": {
|
||||
"dynamodb": {
|
||||
"version": "1.0.0",
|
||||
"inputs": {
|
||||
"table_name": "nova-blockchain-ledger",
|
||||
"region": "us-east-1",
|
||||
"pk": "block_index",
|
||||
"billing_mode": "PAY_PER_REQUEST",
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
contract_path = tmp_path / "ddb.yml"
|
||||
import yaml
|
||||
contract_path.write_text(yaml.safe_dump(contract))
|
||||
stack = resolve(str(contract_path), str(ROOT))
|
||||
# The stack has one dynamodb resource. The resource id is derived
|
||||
# from the interface type (aws:dynamodb:table → "table").
|
||||
ddb = [r for r in stack["resources"] if r["type"] == "aws:dynamodb:table"]
|
||||
assert len(ddb) == 1
|
||||
assert ddb[0]["inputs"]["pk"] == "block_index"
|
||||
assert ddb[0]["inputs"]["billing_mode"] == "PAY_PER_REQUEST"
|
||||
# Emit Terraform.
|
||||
adapt(stack, str(tmp_path))
|
||||
main_tf = (tmp_path / "main.tf").read_text()
|
||||
assert 'module "table" {' in main_tf
|
||||
assert 'pk = "block_index"' in main_tf
|
||||
assert 'billing_mode = "PAY_PER_REQUEST"' in main_tf
|
||||
# The module source points at the dynamodb terraform dir.
|
||||
assert "modules/l1/dynamodb/terraform" in main_tf
|
||||
|
||||
def test_dynamodb_instance_emits_valid_terraform(self, tmp_path):
|
||||
"""The dynamodb L1 instance.json emits terraform that passes
|
||||
terraform init + validate (the real regression gate)."""
|
||||
import subprocess
|
||||
instance = json.load(open(ROOT / "modules/l1/dynamodb/instance.json"))
|
||||
# The instance.json is a module-inputs file, not a stack instance —
|
||||
# build a minimal stack instance wrapping it.
|
||||
stack = {
|
||||
"version": "1.0.0",
|
||||
"stack": {"name": "ddb", "kind": "l1", "depth": 1, "environment": "dev"},
|
||||
"resources": [
|
||||
{"id": "dynamodb", "type": "aws:dynamodb:table", "module": "dynamodb@1.0.0",
|
||||
"inputs": instance["inputs"]}
|
||||
],
|
||||
}
|
||||
adapt(stack, str(tmp_path))
|
||||
result = subprocess.run(
|
||||
["terraform", "init", "-backend=false", "-input=false"],
|
||||
cwd=str(tmp_path), capture_output=True, text=True
|
||||
)
|
||||
assert result.returncode == 0, f"terraform init failed: {result.stderr}"
|
||||
result = subprocess.run(
|
||||
["terraform", "validate"],
|
||||
cwd=str(tmp_path), capture_output=True, text=True
|
||||
)
|
||||
assert result.returncode == 0, f"terraform validate failed: {result.stderr}"
|
||||
main_tf = (tmp_path / "main.tf").read_text()
|
||||
assert 'module "dynamodb" {' in main_tf
|
||||
assert 'pk = "block_index"' in main_tf
|
||||
@@ -0,0 +1,211 @@
|
||||
"""Tests for escalation_reason on ai.decision.made (REQ-318, SPEC §5.8, P3 W2).
|
||||
|
||||
Covers:
|
||||
* block band carries escalation_reason == "confidence" + human_override True
|
||||
* pass band has escalation_reason ABSENT + human_override False
|
||||
* fact_run persists escalation_reason (collector wiring)
|
||||
|
||||
Follows the fixture pattern in tests/test_metrics_emitters.py.
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import sqlite3
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
sys.path.insert(0, str(ROOT))
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def tmp_metrics(tmp_path, monkeypatch):
|
||||
"""Redirect metrics/ to a tmp dir for isolated testing."""
|
||||
metrics_dir = tmp_path / "metrics"
|
||||
metrics_dir.mkdir()
|
||||
runs_dir = metrics_dir / "runs"
|
||||
runs_dir.mkdir()
|
||||
events_log = metrics_dir / "events.jsonl"
|
||||
ledger_db = metrics_dir / "decision_ledger.db"
|
||||
store_db = metrics_dir / "nova_metrics.db"
|
||||
|
||||
monkeypatch.setattr("core.metrics.event_envelope.METRICS_DIR", str(metrics_dir))
|
||||
monkeypatch.setattr("core.metrics.event_envelope.EVENTS_LOG", str(events_log))
|
||||
monkeypatch.setattr("core.metrics.run_manifest._METRICS_DIR", str(metrics_dir))
|
||||
monkeypatch.setattr("core.metrics.run_manifest._RUNS_DIR", str(runs_dir))
|
||||
monkeypatch.setattr("core.metrics.decision_ledger._LEDGER_PATH", str(ledger_db))
|
||||
monkeypatch.setattr("core.metrics.collector._METRICS_DIR", str(metrics_dir))
|
||||
monkeypatch.setattr("core.metrics.collector._STORE_PATH", str(store_db))
|
||||
monkeypatch.setattr("core.metrics.collector._RUNS_DIR", str(runs_dir))
|
||||
monkeypatch.setattr("core.metrics.collector._LEDGER_DB", str(ledger_db))
|
||||
monkeypatch.setattr("core.metrics.outcome_backfill._METRICS_DIR", str(metrics_dir))
|
||||
monkeypatch.setattr("core.metrics.outcome_backfill._STORE_PATH", str(store_db))
|
||||
monkeypatch.setattr("core.metrics.outcome_backfill._LEDGER_PATH", str(ledger_db))
|
||||
return {
|
||||
"metrics_dir": metrics_dir,
|
||||
"events_log": events_log,
|
||||
"ledger_db": ledger_db,
|
||||
"store_db": store_db,
|
||||
"runs_dir": runs_dir,
|
||||
}
|
||||
|
||||
|
||||
def _base_inputs():
|
||||
return {
|
||||
"policy": [{"result": "pass", "severity": "info"}],
|
||||
"validation": {"schema": True, "stack_resolved": True,
|
||||
"tf_validated": True, "tf_planned": True},
|
||||
"freshness": {"age_days": 0, "max_age_days": 7},
|
||||
"source": {"submitter": "dev", "commit_sha": "abc"},
|
||||
"history": {"prior_rollbacks": 0, "prior_policy_fails": 0},
|
||||
"nfrs": {"conformance": 1.0},
|
||||
}
|
||||
|
||||
|
||||
def _block_inputs():
|
||||
"""A critical PCR triggers a hard override (score=0, band=block)."""
|
||||
inputs = _base_inputs()
|
||||
inputs["policy"] = [{"result": "fail", "severity": "critical", "ruleId": "CKV_X"}]
|
||||
return inputs
|
||||
|
||||
|
||||
def _read_decision_event(events_log):
|
||||
lines = events_log.read_text().strip().split("\n")
|
||||
for line in lines:
|
||||
ev = json.loads(line)
|
||||
if ev["type"] == "nova.ai.decision.made":
|
||||
return ev
|
||||
return None
|
||||
|
||||
|
||||
def test_block_band_has_escalation_reason(tmp_metrics):
|
||||
"""A block (critical PCR hard override) carries escalation_reason='confidence'."""
|
||||
from core.confidence_signal import compute
|
||||
sig = compute("cid-block-1", "dev", _block_inputs())
|
||||
assert sig.band == "block"
|
||||
ev = _read_decision_event(tmp_metrics["events_log"])
|
||||
assert ev is not None
|
||||
data = ev["data"]
|
||||
assert data["chosen_action"] == "block"
|
||||
assert data["human_override"] is True
|
||||
assert data.get("escalation_reason") == "confidence"
|
||||
|
||||
|
||||
def test_pass_band_no_escalation_reason(tmp_metrics):
|
||||
"""A clean dev apply (pass band) has NO escalation_reason + human_override False."""
|
||||
from core.confidence_signal import compute
|
||||
sig = compute("cid-pass-1", "dev", _base_inputs())
|
||||
assert sig.band == "pass"
|
||||
ev = _read_decision_event(tmp_metrics["events_log"])
|
||||
assert ev is not None
|
||||
data = ev["data"]
|
||||
assert data["chosen_action"] == "pass"
|
||||
assert data["human_override"] is False
|
||||
# escalation_reason must be ABSENT on a non-block band.
|
||||
assert "escalation_reason" not in data
|
||||
|
||||
|
||||
def test_low_confidence_block_has_escalation_reason(tmp_metrics):
|
||||
"""A score below (threshold - 0.10) blocks on confidence grounds."""
|
||||
from core.confidence_signal import compute
|
||||
# Freshness maximally stale + a high-severity policy fail drags the
|
||||
# score well below the dev threshold of 0.50 - 0.10 = 0.40.
|
||||
inputs = _base_inputs()
|
||||
inputs["freshness"] = {"age_days": 7, "max_age_days": 7}
|
||||
inputs["policy"] = [{"result": "fail", "severity": "high", "ruleId": "CKV_Y"}]
|
||||
sig = compute("cid-block-2", "dev", inputs)
|
||||
assert sig.band == "block"
|
||||
ev = _read_decision_event(tmp_metrics["events_log"])
|
||||
data = ev["data"]
|
||||
assert data.get("escalation_reason") == "confidence"
|
||||
|
||||
|
||||
def test_fact_run_persists_escalation_reason(tmp_metrics):
|
||||
"""The collector persists escalation_reason into fact_run + fact_decision.
|
||||
|
||||
End-to-end: confidence_signal emits ai.decision.made (block) →
|
||||
run_manifest.complete_run writes the manifest with escalation_reason →
|
||||
collector.collect_run_manifests + collect_decision_ledger populate
|
||||
fact_run.escalation_reason + fact_decision.escalation_reason.
|
||||
"""
|
||||
from core.confidence_signal import compute
|
||||
from core.metrics.run_manifest import complete_run
|
||||
from core.metrics.collector import collect_run_manifests, collect_decision_ledger
|
||||
|
||||
# Emit a block decision.
|
||||
os.environ["NOVA_RUN_ID"] = "run-esc-1"
|
||||
try:
|
||||
sig = compute("cid-esc-1", "dev", _block_inputs())
|
||||
assert sig.band == "block"
|
||||
finally:
|
||||
os.environ.pop("NOVA_RUN_ID", None)
|
||||
|
||||
# Complete the run with escalation_reason carried into the manifest.
|
||||
manifest = complete_run(
|
||||
"run-esc-1", "cid-esc-1", "dev",
|
||||
stages=[{"name": "apply", "duration_ms": 100, "exit_code": 0}],
|
||||
exit_code=0,
|
||||
confidence={"score": sig.score, "band": sig.band, "perInput": sig.perInput},
|
||||
decision_id="run-esc-1",
|
||||
escalation_reason="confidence",
|
||||
)
|
||||
assert manifest["escalation_reason"] == "confidence"
|
||||
|
||||
# Collector reads the manifest → fact_run.
|
||||
collect_run_manifests()
|
||||
# Collector reads the ledger → fact_decision.
|
||||
collect_decision_ledger()
|
||||
|
||||
conn = sqlite3.connect(str(tmp_metrics["store_db"]))
|
||||
conn.row_factory = sqlite3.Row
|
||||
run_row = conn.execute(
|
||||
"SELECT run_id, escalation_reason, decision_id FROM fact_run WHERE run_id = ?",
|
||||
("run-esc-1",),
|
||||
).fetchone()
|
||||
dec_row = conn.execute(
|
||||
"SELECT decision_id, escalation_reason, human_override FROM fact_decision WHERE decision_id = ?",
|
||||
("run-esc-1",),
|
||||
).fetchone()
|
||||
conn.close()
|
||||
|
||||
assert run_row is not None
|
||||
assert run_row["escalation_reason"] == "confidence"
|
||||
assert run_row["decision_id"] == "run-esc-1"
|
||||
assert dec_row is not None
|
||||
assert dec_row["escalation_reason"] == "confidence"
|
||||
assert dec_row["human_override"] == 1
|
||||
|
||||
|
||||
def test_fact_run_no_escalation_reason_on_pass(tmp_metrics):
|
||||
"""A pass-band run has escalation_reason NULL in fact_run."""
|
||||
from core.confidence_signal import compute
|
||||
from core.metrics.run_manifest import complete_run
|
||||
from core.metrics.collector import collect_run_manifests
|
||||
|
||||
os.environ["NOVA_RUN_ID"] = "run-esc-pass-1"
|
||||
try:
|
||||
sig = compute("cid-esc-pass-1", "dev", _base_inputs())
|
||||
assert sig.band == "pass"
|
||||
finally:
|
||||
os.environ.pop("NOVA_RUN_ID", None)
|
||||
|
||||
complete_run(
|
||||
"run-esc-pass-1", "cid-esc-pass-1", "dev",
|
||||
stages=[{"name": "apply", "duration_ms": 100, "exit_code": 0}],
|
||||
exit_code=0,
|
||||
confidence={"score": sig.score, "band": sig.band, "perInput": sig.perInput},
|
||||
decision_id="run-esc-pass-1",
|
||||
# escalation_reason intentionally omitted (pass band).
|
||||
)
|
||||
collect_run_manifests()
|
||||
conn = sqlite3.connect(str(tmp_metrics["store_db"]))
|
||||
conn.row_factory = sqlite3.Row
|
||||
row = conn.execute(
|
||||
"SELECT run_id, escalation_reason FROM fact_run WHERE run_id = ?",
|
||||
("run-esc-pass-1",),
|
||||
).fetchone()
|
||||
conn.close()
|
||||
assert row is not None
|
||||
assert row["escalation_reason"] is None
|
||||
@@ -47,7 +47,7 @@ class TestResolveStaticAsset:
|
||||
stack = resolve(str(ROOT / "contracts/static-assets.yml"), str(ROOT))
|
||||
s3_res = [r for r in stack["resources"] if r["type"] == "aws:s3:bucket"]
|
||||
assert len(s3_res) == 1
|
||||
assert s3_res[0]["inputs"]["bucket_name"] == "acdl-dev-assets-000000000000-us-east-1"
|
||||
assert s3_res[0]["inputs"]["bucket_name"] == "acdl-dev-assets-581513795199-us-east-1"
|
||||
assert s3_res[0]["inputs"]["region"] == "us-east-1"
|
||||
|
||||
def test_resolve_static_asset_validates_against_stack_schema(self):
|
||||
|
||||
@@ -74,3 +74,44 @@ def test_run_platform_sh_has_environment_flag():
|
||||
assert "ENVIRONMENT_OVERRIDE" in text
|
||||
assert "NOVA_ENVIRONMENT_OVERRIDE" in text
|
||||
assert "ACDL_ENVIRONMENT_OVERRIDE" not in text
|
||||
|
||||
|
||||
def test_deploy_workflow_aws_region_from_secret_with_fallback():
|
||||
"""SPEC §5.2: aws-region is read from the AWS_DEFAULT_REGION secret (not
|
||||
hardcoded). The ``|| 'us-east-1'`` fallback preserves backwards-compat
|
||||
for consumers that haven't set the secret."""
|
||||
text = GITHUB.read_text()
|
||||
assert "aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}" in text
|
||||
# The hardcoded us-east-1 for the configure-aws-credentials step is gone.
|
||||
assert "aws-region: us-east-1" not in text
|
||||
|
||||
|
||||
def test_deploy_workflow_platform_checkout_ref_matches_milestone():
|
||||
"""SPEC §7.2: the platform checkout ref matches the consumer's @v1.25
|
||||
pin (the current v1.26 milestone's floating tag)."""
|
||||
import yaml
|
||||
wf = yaml.safe_load(GITHUB.read_text())
|
||||
if True in wf:
|
||||
wf["on"] = wf[True]
|
||||
deploy_job = wf["jobs"]["deploy"]
|
||||
checkout_steps = [s for s in deploy_job["steps"]
|
||||
if "checkout" in s.get("uses", "")]
|
||||
platform_checkout = next(
|
||||
(s for s in checkout_steps if s.get("with", {}).get("path") == "platform"),
|
||||
None)
|
||||
assert platform_checkout is not None, "must have a platform repo checkout"
|
||||
assert platform_checkout["with"]["ref"] == "v1.25", \
|
||||
"platform checkout ref must be v1.25 (matching the consumer's @v1.25 pin)"
|
||||
|
||||
|
||||
def test_run_platform_sh_local_fallback_unsets_raw_nova_aws_vars():
|
||||
"""SPEC §5.2: the local .env.secrets fallback must NOT leave raw
|
||||
NOVA_AWS_* / the forge-token name in the shell env — only the
|
||||
canonical AWS_* names. This is the v1.8 blocked_env_vars guard."""
|
||||
text = (ROOT / "scripts" / "run_platform.sh").read_text()
|
||||
# The fallback exports the canonical AWS_* names...
|
||||
assert 'export AWS_ACCESS_KEY_ID="$NOVA_AWS_ACCESS_KEY_ID"' in text
|
||||
assert 'export AWS_SECRET_ACCESS_KEY="$NOVA_AWS_SECRET_ACCESS_KEY"' in text
|
||||
assert 'export AWS_DEFAULT_REGION="${AWS_DEFAULT_REGION:-us-east-1}"' in text
|
||||
# ...then unsets the raw NOVA_AWS_* + the forge-agnostic forge-token name.
|
||||
assert "unset NOVA_AWS_ACCESS_KEY_ID NOVA_AWS_SECRET_ACCESS_KEY NOVA_FORGE_TOKEN" in text
|
||||
|
||||
@@ -30,12 +30,14 @@ def test_env_file_validates_against_schema(env_file):
|
||||
def test_dev_env_has_expected_fields():
|
||||
env = load("dev")
|
||||
assert env["name"] == "dev"
|
||||
assert env["account_id"] == "000000000000"
|
||||
# P03 W3 (REQ-319, D-203): dev is bound to the real account.
|
||||
assert env["account_id"] == "581513795199"
|
||||
assert env["region"] == "us-east-1"
|
||||
assert env["autonomy"] == "full"
|
||||
assert env["confidence_threshold"] == 0.50
|
||||
assert "state_backend" in env
|
||||
assert "bucket" in env["state_backend"]
|
||||
assert env["state_backend"]["bucket"] == "nova-tfstate-581513795199-us-east-1"
|
||||
assert "network" in env
|
||||
|
||||
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user