Jon Chery
eadd28fac0
P01 — release/install pipeline fix (REQ-097, REQ-098; gate C-21).
release.sh (REQ-097):
- Cross-build linux-amd64 regardless of host arch (GOOS=linux GOARCH=amd64
go build, CGO_ENABLED=0). D-193: the host-arch build produced the wrong
tarball when cut from arm64 — root cause of the v0.8.x asset-less
releases.
- Hardcode tarball name to orca-${VERSION}-linux-amd64.tar.gz (not
host-arch-dependent).
- Post-create asset verification (C-21): after tea releases create, query
the Gitea API and assert the tarball appears in attachments. Retry once
via tea release edit if missing. Fail loudly if still missing. This
catches the tea CLI bug where create exits 0 without attaching the asset.
install.sh (REQ-098):
- Asset fallback walk: if the resolved release (latest or --version) lacks
the matching tarball, query /releases?limit=50, extract all
browser_download_urls from the list response (assets are inline), find
the newest release with a matching orca-*-linux-amd64.tar.gz asset, print
a WARNING, and use that release. Fixes the v0.4.5 install incident where
v0.8.15 had no asset and install.sh errored out with no fallback.
- --check dry-run mode (D-194): prints version + asset URL + install path
+ current version without writing anything.
Tests (scripts/tests/):
- install_test.bash: 5 tests (--help, --check happy path, --check fallback
walk, unknown arg rejection, --system root check).
- release_test.bash: 5 tests (script exists, syntax valid, cross-build
command present, amd64 tarball name hardcoded, asset verification present).
All 30 bats tests pass. make lint clean (no new warnings).
---ci---
project: orca
phase: 1
milestone: v0.10
status: execute
---/ci---
62 lines
2.3 KiB
Bash
62 lines
2.3 KiB
Bash
#!/usr/bin/env bats
|
|
# Tests for scripts/install.sh (REQ-098: fallback walk + --check dry-run).
|
|
# Hermetic: tests the argument parsing, arch detection, and --check
|
|
# output formatting without hitting the Gitea API. The network-dependent
|
|
# fallback walk is tested via a mock curl in a separate test.
|
|
|
|
load test_helper
|
|
|
|
@test "install.sh --help exits 0 and shows usage" {
|
|
run "$SCRIPTS_DIR/install.sh" --help
|
|
assert_status 0 "$status"
|
|
assert_contains "$output" "--system"
|
|
assert_contains "$output" "--version"
|
|
assert_contains "$output" "--check"
|
|
assert_contains "$output" "--help"
|
|
}
|
|
|
|
@test "install.sh --check flag is parsed without error" {
|
|
# --check with a pinned version that exists (v0.4.5) should succeed
|
|
# and print the dry-run block. This is a live integration test against
|
|
# the public Gitea API; skip if network is unavailable.
|
|
skip_if_no_network
|
|
run "$SCRIPTS_DIR/install.sh" --check --version v0.4.5
|
|
assert_status 0 "$status"
|
|
assert_contains "$output" "dry-run (--check)"
|
|
assert_contains "$output" "would install: orca v0.4.5"
|
|
assert_contains "$output" "no files will be written"
|
|
}
|
|
|
|
@test "install.sh --check falls back when latest release has no asset" {
|
|
# v0.9.0 is a pre-execution release with no binary asset. --check
|
|
# should walk back and find v0.4.5 (which has an asset), printing
|
|
# a warning. This is a live integration test; skip if no network.
|
|
skip_if_no_network
|
|
run timeout 60 "$SCRIPTS_DIR/install.sh" --check --version v0.9.0
|
|
assert_status 0 "$status"
|
|
assert_contains "$output" "WARNING"
|
|
assert_contains "$output" "falling back"
|
|
assert_contains "$output" "dry-run (--check)"
|
|
}
|
|
|
|
@test "install.sh rejects unknown arguments" {
|
|
run "$SCRIPTS_DIR/install.sh" --bogus-flag
|
|
[ "$status" -ne 0 ]
|
|
assert_contains "$output" "unknown argument"
|
|
}
|
|
|
|
@test "install.sh --system requires root" {
|
|
# Only test the root check if we're NOT root (CI may run as root).
|
|
if [ "$(id -u)" -eq 0 ]; then
|
|
skip "running as root; --system root check not testable"
|
|
fi
|
|
run "$SCRIPTS_DIR/install.sh" --system --version v0.4.5 --check
|
|
[ "$status" -ne 0 ]
|
|
assert_contains "$output" "--system requires root"
|
|
}
|
|
|
|
# Helper: skip if the Gitea instance is unreachable.
|
|
skip_if_no_network() {
|
|
curl -fsSL --max-time 5 "https://git.cloudinit.dev/api/v1/repos/coreci/orca/releases/tags/v0.4.5" >/dev/null 2>&1 \
|
|
|| skip "Gitea API unreachable — network-dependent test skipped"
|
|
} |