Jon Chery
fc94326b0e
P00 — Re-architecture Foundation (deprecation/migration/test-infra/persona/docs). Deprecation sweep (REQ-068, REQ-072, REQ-089): - Add // Deprecated: doc comments to internal/daemon (R-001), internal/transport (REQ-073), internal/security/ca.go+csr.go (D-101/REQ-076), internal/engine/ dispatcher.go+peer.go (CLI-side scheduler), internal/cli/daemon.go. - orca daemon emits slog.Warn deprecation banner on every run (ungated); fires R-001 + v0.10-P05 drain-and-stop + v0.10-P14 deletion. - orca cert and orca node join (mTLS path) emit deprecation warnings; proxmox SSH path (the v0.9 replacement) does not warn. - Add --no-deprecation-warnings global flag on root command (PersistentPreRunE) for orca upgrade migrations. - 12 new daemon/cert/node deprecation tests in internal/cli/daemon_test.go (cli coverage 81.9%, warnDeprecated 100%). - Add DEPRECATED banners to v0.8 sections of ARCHITECTURE.md (verified the v0.9 supersession section + Supersession Table from prior turn are present). Bash tooling gate (grill C-06, C-15, C-16, C-17, C-18): - scripts/tests/test_helper.bash + example_test.bash — bats framework + helpers. - scripts/lib/orca-log.sh — slog-compatible JSON logging to syslog (C-17). - scripts/orca-verify-render.sh — render-contract validator skeleton (C-16). - scripts/tests/orca-log_test.bash + orca-verify-render_test.bash — 20 bats tests total (happy + failure paths per C-15). - .shellcheckrc — project shellcheck config. - Makefile: test-bash + lint-bash targets (graceful skip if tools missing); wired into test + lint targets. - internal/emit/contract.go + contract_test.go — versioned JSON render contract (orca.emit/v1) between Go emitters and bash appliers (C-16). - .ciagent/BASH_CAPABILITY_MAP_v0.9.md — maps shipped internal/transport capabilities to bash-side equivalents or accepted drops (C-18). - D-186 recorded in PROJECT.md: bash exempt from Go coverage gate; compensating control is bats + shellcheck + shfmt (C-06). verify-reqs: 90 requirements consistent. Build/test/lint/fmt all green. 20 bats tests pass. Go tests pass. No v0.8 code deleted — only marked deprecated (deletion deferred to v0.10-P14 per REQ-090 dual-write window). ---ci--- project: orca phase: P00 milestone: v0.9 status: execute ---/ci---
69 lines
2.0 KiB
Bash
69 lines
2.0 KiB
Bash
#!/usr/bin/env bats
|
|
# Tests for scripts/orca-verify-render.sh (C-16 render-format contract validator).
|
|
# Covers happy path (valid input returns 0) and failure paths (schema mismatch,
|
|
# missing fields, missing file, missing argument).
|
|
|
|
load test_helper
|
|
|
|
VERIFY_RENDER="$SCRIPTS_DIR/orca-verify-render.sh"
|
|
TMP_BUNDLE=""
|
|
|
|
setup() {
|
|
TMP_BUNDLE="$(mktemp)"
|
|
}
|
|
|
|
teardown() {
|
|
[ -n "$TMP_BUNDLE" ] && rm -f "$TMP_BUNDLE"
|
|
}
|
|
|
|
@test "verify-render happy path: valid artifacts return 0" {
|
|
cat >"$TMP_BUNDLE" <<'EOF'
|
|
{"schema_version":"orca.emit/v1","kind":"systemd","path":"/etc/systemd/system/x.service","content":"[Service]","mode":"0644"}
|
|
{"schema_version":"orca.emit/v1","kind":"traefik","path":"/etc/traefik/dynamic/orca.yml","content":"tls:{}","mode":"0644"}
|
|
EOF
|
|
run "$VERIFY_RENDER" "$TMP_BUNDLE"
|
|
assert_status 0 "$status"
|
|
assert_contains "$output" "2 artifacts valid"
|
|
}
|
|
|
|
@test "verify-render failure: schema_version mismatch returns non-zero" {
|
|
cat >"$TMP_BUNDLE" <<'EOF'
|
|
{"schema_version":"orca.emit/v2","kind":"systemd","path":"/x","mode":"0644"}
|
|
EOF
|
|
run "$VERIFY_RENDER" "$TMP_BUNDLE"
|
|
[ "$status" -ne 0 ]
|
|
assert_contains "$output" "schema_version mismatch"
|
|
}
|
|
|
|
@test "verify-render failure: missing schema_version returns non-zero" {
|
|
cat >"$TMP_BUNDLE" <<'EOF'
|
|
{"kind":"systemd","path":"/x","mode":"0644"}
|
|
EOF
|
|
run "$VERIFY_RENDER" "$TMP_BUNDLE"
|
|
[ "$status" -ne 0 ]
|
|
assert_contains "$output" "missing schema_version"
|
|
}
|
|
|
|
@test "verify-render failure: missing bundle argument returns 2" {
|
|
run "$VERIFY_RENDER"
|
|
assert_status 2 "$status"
|
|
assert_contains "$output" "usage:"
|
|
}
|
|
|
|
@test "verify-render failure: non-existent bundle returns 2" {
|
|
run "$VERIFY_RENDER" "/nonexistent/bundle.json"
|
|
assert_status 2 "$status"
|
|
assert_contains "$output" "bundle not found"
|
|
}
|
|
|
|
@test "verify-render skips blank lines and comments" {
|
|
cat >"$TMP_BUNDLE" <<'EOF'
|
|
# this is a comment
|
|
|
|
{"schema_version":"orca.emit/v1","kind":"systemd","path":"/x","content":"c","mode":"0644"}
|
|
|
|
EOF
|
|
run "$VERIFY_RENDER" "$TMP_BUNDLE"
|
|
assert_status 0 "$status"
|
|
assert_contains "$output" "1 artifacts valid"
|
|
} |