orca/internal/runtime at 2cbfb5d5618b8c4920880a8b434004be6bc5bf96 - orca

Files

T

Jon Chery ce2441f312 fix(P01): command injection in podman/wasm runtimes (REQ-119, F3)

---ci---
project: orca
phase: 1
milestone: v0.12
status: execute
---/ci---

shellQuote the jobspec-supplied command string (cmdStr) before
interpolating into SSH exec in podman.go (Start) and wasm.go (Start).
Previously cmdStr was interpolated unquoted, allowing a malicious
jobspec command with shell metacharacters (; | $() backticks newline
> <) to inject commands on the peer.

Fixes:
- internal/runtime/runtime.go: add shellQuote helper (mirrors
  internal/sshpush.shellQuote; duplicated to avoid import cycle).
- internal/runtime/podman.go: Start quotes name + cmdStr; Stop/rm/
  inspect quote name (defense-in-depth).
- internal/runtime/wasm.go: Start uses env 'ORCA_ALLOC_ID=<id>' (so
  the UUID-style alloc ID is safely assigned) and shellQuote(cmdStr).

Tests: 21 new injection regression tests (10 podman + 9 wasm + 2 image)
covering ; && | $() backticks newline $IFS > < (). All pass. Existing
runtime tests still pass. go vet + gofmt clean.

2026-08-07 10:49:08 +00:00

C01_WASMTIME_CGO_EVAL.md

feat(P07a/b/c): runtime abstraction — 5 backends (process/podman/wasm/pve-vm/pve-ct), C-01 satisfied (REQ-078)

2026-08-05 18:31:25 +00:00

podman_test.go

fix(P01): command injection in podman/wasm runtimes (REQ-119, F3)

2026-08-07 10:49:08 +00:00

podman.go

fix(P01): command injection in podman/wasm runtimes (REQ-119, F3)

2026-08-07 10:49:08 +00:00

process_test.go

feat(P07a/b/c): runtime abstraction — 5 backends (process/podman/wasm/pve-vm/pve-ct), C-01 satisfied (REQ-078)