fc94326b0e
P00 — Re-architecture Foundation (deprecation/migration/test-infra/persona/docs). Deprecation sweep (REQ-068, REQ-072, REQ-089): - Add // Deprecated: doc comments to internal/daemon (R-001), internal/transport (REQ-073), internal/security/ca.go+csr.go (D-101/REQ-076), internal/engine/ dispatcher.go+peer.go (CLI-side scheduler), internal/cli/daemon.go. - orca daemon emits slog.Warn deprecation banner on every run (ungated); fires R-001 + v0.10-P05 drain-and-stop + v0.10-P14 deletion. - orca cert and orca node join (mTLS path) emit deprecation warnings; proxmox SSH path (the v0.9 replacement) does not warn. - Add --no-deprecation-warnings global flag on root command (PersistentPreRunE) for orca upgrade migrations. - 12 new daemon/cert/node deprecation tests in internal/cli/daemon_test.go (cli coverage 81.9%, warnDeprecated 100%). - Add DEPRECATED banners to v0.8 sections of ARCHITECTURE.md (verified the v0.9 supersession section + Supersession Table from prior turn are present). Bash tooling gate (grill C-06, C-15, C-16, C-17, C-18): - scripts/tests/test_helper.bash + example_test.bash — bats framework + helpers. - scripts/lib/orca-log.sh — slog-compatible JSON logging to syslog (C-17). - scripts/orca-verify-render.sh — render-contract validator skeleton (C-16). - scripts/tests/orca-log_test.bash + orca-verify-render_test.bash — 20 bats tests total (happy + failure paths per C-15). - .shellcheckrc — project shellcheck config. - Makefile: test-bash + lint-bash targets (graceful skip if tools missing); wired into test + lint targets. - internal/emit/contract.go + contract_test.go — versioned JSON render contract (orca.emit/v1) between Go emitters and bash appliers (C-16). - .ciagent/BASH_CAPABILITY_MAP_v0.9.md — maps shipped internal/transport capabilities to bash-side equivalents or accepted drops (C-18). - D-186 recorded in PROJECT.md: bash exempt from Go coverage gate; compensating control is bats + shellcheck + shfmt (C-06). verify-reqs: 90 requirements consistent. Build/test/lint/fmt all green. 20 bats tests pass. Go tests pass. No v0.8 code deleted — only marked deprecated (deletion deferred to v0.10-P14 per REQ-090 dual-write window). ---ci--- project: orca phase: P00 milestone: v0.9 status: execute ---/ci---
121 lines
3.5 KiB
Go
121 lines
3.5 KiB
Go
package emit
|
|
|
|
import (
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestArtifactValidate_valid(t *testing.T) {
|
|
a := &Artifact{
|
|
SchemaVersion: SchemaVersion,
|
|
Kind: KindSystemd,
|
|
Path: "/etc/systemd/system/orca-alloc.service",
|
|
Content: "[Service]\nExecStart=/bin/true\n",
|
|
Mode: "0644",
|
|
}
|
|
if err := a.Validate(); err != nil {
|
|
t.Fatalf("expected valid, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestArtifactValidate_schemaVersionMismatch(t *testing.T) {
|
|
a := &Artifact{SchemaVersion: "orca.emit/v0", Kind: KindSystemd, Path: "/x", Mode: "0644"}
|
|
err := a.Validate()
|
|
if err == nil {
|
|
t.Fatal("expected error for mismatched schema_version")
|
|
}
|
|
if !strings.Contains(err.Error(), "schema_version mismatch") {
|
|
t.Fatalf("expected schema_version error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestArtifactValidate_missingKind(t *testing.T) {
|
|
a := &Artifact{SchemaVersion: SchemaVersion, Path: "/x", Mode: "0644"}
|
|
err := a.Validate()
|
|
if err == nil || !strings.Contains(err.Error(), "kind is required") {
|
|
t.Fatalf("expected kind-required error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestArtifactValidate_missingPath(t *testing.T) {
|
|
a := &Artifact{SchemaVersion: SchemaVersion, Kind: KindTraefik, Mode: "0644"}
|
|
err := a.Validate()
|
|
if err == nil || !strings.Contains(err.Error(), "path is required") {
|
|
t.Fatalf("expected path-required error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestArtifactValidate_missingMode(t *testing.T) {
|
|
a := &Artifact{SchemaVersion: SchemaVersion, Kind: KindSudoers, Path: "/x"}
|
|
err := a.Validate()
|
|
if err == nil || !strings.Contains(err.Error(), "mode is required") {
|
|
t.Fatalf("expected mode-required error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestMarshalValidate_rejectsInvalid(t *testing.T) {
|
|
a := &Artifact{SchemaVersion: "bad", Kind: "", Path: "", Mode: ""}
|
|
if _, err := a.Marshal(); err == nil {
|
|
t.Fatal("expected Marshal to reject invalid artifact")
|
|
}
|
|
}
|
|
|
|
func TestUnmarshalArtifact_valid(t *testing.T) {
|
|
raw := `{"schema_version":"orca.emit/v1","kind":"systemd","path":"/x","content":"c","mode":"0644"}`
|
|
a, err := UnmarshalArtifact([]byte(raw))
|
|
if err != nil {
|
|
t.Fatalf("expected valid, got %v", err)
|
|
}
|
|
if a.Kind != KindSystemd {
|
|
t.Fatalf("expected kind systemd, got %s", a.Kind)
|
|
}
|
|
}
|
|
|
|
func TestUnmarshalArtifact_rejectsBadJSON(t *testing.T) {
|
|
if _, err := UnmarshalArtifact([]byte("not json")); err == nil {
|
|
t.Fatal("expected error for bad JSON")
|
|
}
|
|
}
|
|
|
|
func TestUnmarshalArtifact_rejectsSchemaMismatch(t *testing.T) {
|
|
raw := `{"schema_version":"orca.emit/v2","kind":"x","path":"/x","mode":"0644"}`
|
|
if _, err := UnmarshalArtifact([]byte(raw)); err == nil {
|
|
t.Fatal("expected error for schema mismatch")
|
|
}
|
|
}
|
|
|
|
func TestRoundTrip(t *testing.T) {
|
|
orig := &Artifact{
|
|
SchemaVersion: SchemaVersion,
|
|
Kind: KindSyncthing,
|
|
Path: "/etc/syncthing/config.xml",
|
|
Content: "<config/>",
|
|
Mode: "0600",
|
|
}
|
|
data, err := orig.Marshal()
|
|
if err != nil {
|
|
t.Fatalf("Marshal: %v", err)
|
|
}
|
|
back, err := UnmarshalArtifact(data)
|
|
if err != nil {
|
|
t.Fatalf("Unmarshal: %v", err)
|
|
}
|
|
if back.Path != orig.Path || back.Kind != orig.Kind || back.Mode != orig.Mode {
|
|
t.Fatalf("round-trip mismatch: %+v vs %+v", orig, back)
|
|
}
|
|
}
|
|
|
|
func TestAllKinds(t *testing.T) {
|
|
for _, k := range []Kind{KindSystemd, KindTraefik, KindSyncthing, KindSudoers, KindSSHD, KindEnvFile, KindCredential} {
|
|
a := &Artifact{SchemaVersion: SchemaVersion, Kind: k, Path: "/x", Mode: "0644"}
|
|
if err := a.Validate(); err != nil {
|
|
t.Errorf("kind %s: %v", k, err)
|
|
}
|
|
// verify it marshals
|
|
if _, err := json.Marshal(a); err != nil {
|
|
t.Errorf("marshal kind %s: %v", k, err)
|
|
}
|
|
}
|
|
}
|