Jon Chery
437aab39b4
P0a1 — Re-architecture Foundation (path resolver + config demotion). Path resolver (REQ-070, R-002): - internal/paths/paths.go: 23 functions for the multi-namespace layout (Root/ClusterDir/NamespaceDir/NS*/DefaultNamespace/CA/MasterKey/CacheDB/ Txn/Peers/KnownHosts/SSH/Server/Config). Honors $ORCA_HOME. 100% coverage. - internal/certpaths/certpaths.go: refactored as thin shim delegating to paths, preserving the v0.8 flat-layout API for backward compat during the dual-write window (REQ-090). Package doc explains the v0.10-P14 migration plan. certpaths deleted after v0.10-P14. 100% coverage. Config demotion (REQ-069, R-014): - internal/config/markdown.go: minimal hand-rolled YAML frontmatter parser (no new dep — yaml.v3 not in go.mod). Returns same *Config struct as HCL. - internal/config/config.go: renamed Load body to LoadHCL (// Deprecated per R-013), added dispatcher Load() routing on extension (.hcl->HCL, .md->Markdown, .yaml->Markdown). Signature preserved so root.go unchanged. - dispatch_test.go + markdown_test.go: 89.8% coverage on config package. Known_hosts flock (REQ-063, deferred P1 from REVIEW_v0.8 A2): - internal/security/flock.go: stdlib syscall.Flock advisory lock helper. - internal/proxmox/bootstrap.go: TOFUHostKeyCallback capture + ResetHostKey both acquire the flock before read-modify-write on known_hosts. Prevents concurrent writers under v0.9 parallel SSH fan-out. 3 flock tests. CA migration spec (grill C-07): - .ciagent/CA_MIGRATION_SPEC_v0.9.md: Option A (preserve trust root, RECOMMENDED) vs Option B (forced re-bootstrap). Pre-flight checks, migration steps, rollback, post-migration invariants, spike plan. Verification: build pass, 17/17 Go packages pass, 20/20 bats pass, gofmt clean, go vet clean, verify-reqs 90 consistent. Coverage: paths 100%, certpaths 100%, config 89.8%, emit covered. ---ci--- project: orca phase: P0a1 milestone: v0.9 status: execute ---/ci---
112 lines
2.8 KiB
Go
112 lines
2.8 KiB
Go
package config
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestLoad_DispatchHCL(t *testing.T) {
|
|
p := writeTestFile(t, t.TempDir(), "config.hcl", exampleHCL)
|
|
cfg, err := Load(p)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.DBPath != "/tmp/orca/test.db" {
|
|
t.Errorf("DBPath=%q", cfg.DBPath)
|
|
}
|
|
if cfg.NodeCapacity == nil || cfg.NodeCapacity.CPU != 4 {
|
|
t.Errorf("NodeCapacity=%+v", cfg.NodeCapacity)
|
|
}
|
|
}
|
|
|
|
func TestLoad_DispatchMarkdown(t *testing.T) {
|
|
p := writeTestFile(t, t.TempDir(), "config.md", exampleMarkdown)
|
|
cfg, err := Load(p)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.DBPath != "/tmp/orca/test.db" {
|
|
t.Errorf("DBPath=%q", cfg.DBPath)
|
|
}
|
|
if cfg.ListenAddr != "127.0.0.1:9999" {
|
|
t.Errorf("ListenAddr=%q", cfg.ListenAddr)
|
|
}
|
|
if cfg.NodeCapacity == nil || cfg.NodeCapacity.CPU != 4 {
|
|
t.Errorf("NodeCapacity=%+v", cfg.NodeCapacity)
|
|
}
|
|
}
|
|
|
|
func TestLoad_DispatchYAML(t *testing.T) {
|
|
body := "listen_addr: 0.0.0.0:5555\ndb_path: /bare.db\nnode_capacity:\n cpu: 2\n memory_mb: 4096\n"
|
|
p := writeTestFile(t, t.TempDir(), "config.yaml", body)
|
|
cfg, err := Load(p)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.ListenAddr != "0.0.0.0:5555" {
|
|
t.Errorf("ListenAddr=%q", cfg.ListenAddr)
|
|
}
|
|
if cfg.DBPath != "/bare.db" {
|
|
t.Errorf("DBPath=%q", cfg.DBPath)
|
|
}
|
|
if cfg.NodeCapacity == nil || cfg.NodeCapacity.CPU != 2 {
|
|
t.Errorf("NodeCapacity=%+v", cfg.NodeCapacity)
|
|
}
|
|
}
|
|
|
|
func TestLoad_DispatchYML(t *testing.T) {
|
|
body := "listen_addr: 1.2.3.4:9\n"
|
|
p := writeTestFile(t, t.TempDir(), "config.yml", body)
|
|
cfg, err := Load(p)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.ListenAddr != "1.2.3.4:9" {
|
|
t.Errorf("ListenAddr=%q", cfg.ListenAddr)
|
|
}
|
|
}
|
|
|
|
func TestLoad_DispatchFirstExistingWins(t *testing.T) {
|
|
dir := t.TempDir()
|
|
missing := filepath.Join(dir, "missing.md")
|
|
existing := writeTestFile(t, dir, "real.hcl", exampleHCL)
|
|
cfg, err := Load(missing, existing)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.DBPath != "/tmp/orca/test.db" {
|
|
t.Errorf("DBPath=%q", cfg.DBPath)
|
|
}
|
|
}
|
|
|
|
func TestLoad_DispatchMissingReturnsZero(t *testing.T) {
|
|
cfg, err := Load(filepath.Join(t.TempDir(), "nope.md"))
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg == nil {
|
|
t.Fatal("nil config")
|
|
}
|
|
if cfg.DBPath != "" || cfg.ListenAddr != "" || cfg.NodeCapacity != nil {
|
|
t.Errorf("expected zero config, got %+v", cfg)
|
|
}
|
|
}
|
|
|
|
func TestLoad_DispatchHCLMalformed(t *testing.T) {
|
|
p := writeTestFile(t, t.TempDir(), "bad.hcl", "db_path = ")
|
|
if _, err := Load(p); err == nil {
|
|
t.Fatal("expected error for malformed HCL")
|
|
}
|
|
}
|
|
|
|
func TestLoad_DispatchUnknownExtFallsBackToHCL(t *testing.T) {
|
|
p := writeTestFile(t, t.TempDir(), "config.unknown", exampleHCL)
|
|
cfg, err := Load(p)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.DBPath != "/tmp/orca/test.db" {
|
|
t.Errorf("DBPath=%q", cfg.DBPath)
|
|
}
|
|
}
|