Commit Graph

9 Commits

Author SHA1 Message Date
Jon Chery df3f980fa0 fix(P1): move release to Gitea Actions step — CoreCI disk full issue
Release / ci (push) Failing after 5m54s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
CoreCI's SQLite logging fills the runner's disk during go test -race,
causing the release job to fail when writing the tarball (3-second
failure). The release job ran inside CoreCI's shell-isolated executor
which shares the same disk as CoreCI's SQLite DB.

Fix: move the release logic (build tarball + upload to Gitea) to a
separate Gitea Actions step that runs AFTER coreci run completes.
This step runs in the Gitea Actions runner directly (full env, no
CoreCI disk constraints). The .coreci.yml now only has build→test
jobs. The release is handled by scripts/ci-release.sh called from the
Gitea Actions workflow.

Architecture:
  Gitea Actions ci job:
    1. Checkout + Set up Go + Install CoreCI
    2. coreci run (executes .coreci.yml: build → test)
    3. sh scripts/ci-release.sh (build tarball + upload to Gitea API)

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 22:36:56 +00:00
Jon Chery 7e26490b5f fix(P1): release job uses existing bin/orca from build job
Release / ci (push) Failing after 7m21s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
The release job's go build fails due to disk full (CoreCI's SQLite
logging fills the disk during go test -race). The build job already
builds bin/orca successfully — the release job should just package it
and upload. Only rebuild if bin/orca doesn't exist.

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 22:27:38 +00:00
Jon Chery 8ca5ffd0fc fix(P1): clean disk before release + fallback to existing binary
Release / ci (push) Failing after 8m5s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
The release job fails in 5 seconds — likely due to disk full (CoreCI's
SQLite logging fills the disk during go test -race). Fix:
1. Clean up coverage.out and Go build cache before the release job
2. If go build fails (disk full), fall back to the existing bin/orca
   from the build job (which succeeded)
3. Add more error handling for tar/sha256sum

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 22:18:45 +00:00
Jon Chery 5c07fafa18 fix(P1): add CI_GITEA_TOKEN for shell-isolated env forwarding
Release / ci (push) Failing after 7m30s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
CoreCI's buildIsolatedEnv only forwards CI_* and CORECI_* prefixed vars
from os.Environ(). GITEA_TOKEN is not prefixed, so it's only available
if it's in the job vars map (via ${{ secrets.GITEA_TOKEN }}). The
secret resolver's os.Getenv fallback should work, but to be safe, also
set CI_GITEA_TOKEN in the workflow env (always forwarded as a CI_* var).

Add debug output for GITEA_TOKEN length and CI context vars.

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 22:10:16 +00:00
Jon Chery fb89c30d91 fix(P1): simplify release job — direct Gitea API, skip tea+changelog
Release / ci (push) Failing after 7m29s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
The release job failed (exit 1) likely due to make changelog or tea
install failing. Simplify: use the Gitea API directly (curl) to check
for existing release, create if missing, attach assets. Skip make
changelog (use a simple release note) and skip tea install (curl is
pre-installed on the runner).

Also: the build job succeeded (status=success in logs), test ran. The
disk full errors (SQLite DB) are CoreCI internal logging issues, not
affecting the job execution itself.

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 22:01:04 +00:00
Jon Chery b8f766de03 fix(P1): use #!/bin/sh not bash — runner uses dash as /bin/sh
Release / ci (push) Failing after 7m27s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
The Gitea Actions runner (ubuntu-latest) uses dash as /bin/sh. The
previous script used #!/bin/bash with 'set -uo pipefail' — pipefail is
bash-only and causes 'set: illegal option -o pipefail' (exit 2) in dash.
This was the root cause of the build job failing in 2 seconds.

Fix: #!/bin/sh with 'set -u' only (no pipefail). Removed bash-only
features. The script is POSIX-compliant.

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 21:51:56 +00:00
Jon Chery 566145d45a fix(P1): debug build job — add stderr logging, remove set -e
Release / ci (push) Failing after 6m20s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
The build job fails with exit 2 but stdout/stderr is not visible in
Gitea Actions logs (CoreCI captures it internally). Add stderr logging
for PATH, go location, and Go env vars. Remove set -e so the script
continues past errors and we can see all output.

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 21:44:16 +00:00
Jon Chery 4a97cb1ea2 fix(P1): set Go env vars in ci-run.sh — shell-isolated executor drops them
Release / ci (push) Failing after 6m14s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
CoreCI's buildIsolatedEnv does NOT forward GOROOT, GOPATH, GOCACHE,
GOMODCACHE (they're in the systemVars deny-list in pass_through.go).
The shell-isolated executor's env only has PATH, HOME, LANG, TMPDIR,
TERM, CI + CORECI_* + CI_* + job vars. Without GOMODCACHE/GOCACHE, Go
commands fail (can't find module/build cache). Fix: re-derive them from
the go binary on PATH via 'go env GOROOT' etc.

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 21:37:01 +00:00
Jon Chery 1b71e0515f fix(P1): wrap CI jobs in scripts/ci-run.sh — CoreCI forbids shell metacharacters in invoke: (REQ-184)
Release / ci (push) Failing after 6m19s
Release / container-orca (push) Has been skipped
Release / container-traefik (push) Has been skipped
CoreCI's ValidateShellCommand (internal/runner/validate.go) rejects
invoke: strings containing &|;`><$() — security measure to prevent
shell injection. The previous .coreci.yml jobs had inline invoke:
commands with || redirects and $(date) substitution, causing:
  job "gitleaks" failed: shell command contains forbidden metacharacters

Fix: all complex logic moved to scripts/ci-run.sh. Each .coreci.yml job
uses invoke: "sh scripts/ci-run.sh <job-name>" — no metacharacters in
the invoke: string. The script itself can use any shell features
internally (CoreCI only validates the invoke: field, not what the script
does).

---ci---
project: orca
phase: 1
milestone: v0.16
status: execute
---/ci---
2026-08-12 21:29:22 +00:00