fix(P05): final review fixes — PERSONAS.md body, config --addr precedence, migration 0007 dedup

Audit fix: PERSONAS.md body roster updated for v0.7 (was stale v0.6
content). Review P1-004: daemon --addr now uses cmd.Flags().Changed()
to detect explicit flag, so config listen_addr only applies when --addr
was not explicitly passed (correct flag>env>file>default precedence).
Review P1-001: migration 0007 now dedups existing duplicate serial_hex
rows before creating the UNIQUE index (backward-compat with v0.6 DBs
that accumulated duplicates before the constraint existed).

---ci---
project: orca
phase: 5
milestone: v0.7
status: execute
requirements:
  covered: [REQ-053, REQ-054, REQ-055, REQ-056]
  partial: []
---/ci---
This commit is contained in:
Jon Chery
2026-08-04 00:28:48 +00:00
parent afcd15cde4
commit d7d6961261
3 changed files with 40 additions and 35 deletions
+1 -1
View File
@@ -36,7 +36,7 @@ var daemonCmd = &cobra.Command{
log := newLogger()
addr := daemonAddr
if cfg := configFromCtx(cmd.Context()); cfg != nil && cfg.ListenAddr != "" && addr == ":8080" {
if cfg := configFromCtx(cmd.Context()); cfg != nil && cfg.ListenAddr != "" && !cmd.Flags().Changed("addr") {
addr = cfg.ListenAddr
}
srv := daemon.NewServer(daemon.Options{