release(v0.4.0): purge learnship, migrate .planning→.ci, fix backends, add test coverage
- Remove all learnship references: Decision.learnship_equivalent field,
agent persona prompts, opencode.json permissions, test fixtures
- Migrate verification layers from .planning/ to .ci/: structural
checks .ci/ dir + ROADMAP.md, behavioral checks ROADMAP.md
- Fix ollama-local: remove sync require+curl blocking, use async
fetchAvailableModels() in callModel
- Fix opencode.json: use __OPENCODE_DIR__ template tokens, remove
legacy learnship permission entries
- Remove duplicate install script from package.json (keep postinstall)
- Fix quality any-regex false positives (target type annotations only)
- Add backends test coverage: backends.test.ts, tool-registry.test.ts
- Version bump 0.3.0 → 0.4.0
- Artifacts module: rename .planning→.ci internal paths
- Remove dead TODO_PATTERN/FIXME_PATTERN constants
---ci---
phase: 3
milestone: v0.4
status: complete
requirements:
covered: [REQ-09, REQ-10, REQ-11, REQ-13, REQ-14, REQ-17]
partial: []
decisions:
- id: D-001
decision: purge all learnship references from codebase
rationale: project is CI-only, learnship is no longer a dependency
confidence: 0.99
category: scope
alternatives: [keep for historical reference]
- id: D-002
decision: migrate verification from .planning/ to .ci/ paths
rationale: .planning/ is removed schema, all current state lives in .ci/
confidence: 0.95
category: architecture
alternatives: [keep dual-path support]
- id: D-003
decision: use __OPENCODE_DIR__ template tokens in opencode.json
rationale: hardcoded ~ paths fail in containers and non-standard homes
confidence: 0.90
category: implementation_approach
alternatives: [keep tilde expansion]
---/ci---
This commit is contained in:
@@ -141,38 +141,36 @@ export class BehavioralVerification extends VerificationLayer {
|
||||
}
|
||||
|
||||
private checkPlanMustHaves(projectPath: string, phase: number): VerificationCheck {
|
||||
const planPath = path.join(
|
||||
const roadmapPath = path.join(
|
||||
projectPath,
|
||||
".planning",
|
||||
"phases",
|
||||
`phase-${phase}`,
|
||||
"PLAN.md"
|
||||
".ci",
|
||||
"ROADMAP.md"
|
||||
);
|
||||
|
||||
if (!fs.existsSync(planPath)) {
|
||||
if (!fs.existsSync(roadmapPath)) {
|
||||
return this.check(
|
||||
"Plan must-haves covered",
|
||||
"skipped",
|
||||
`No PLAN.md found for phase ${phase}`
|
||||
"No ROADMAP.md found — run 'ci init' first"
|
||||
);
|
||||
}
|
||||
|
||||
const content = fs.readFileSync(planPath, "utf-8");
|
||||
const content = fs.readFileSync(roadmapPath, "utf-8");
|
||||
const hasMustHaves = content.toLowerCase().includes("must");
|
||||
const hasTasks = content.includes("- [") || content.includes("* [");
|
||||
const hasPhases = content.includes("Phase") || content.includes("phase");
|
||||
|
||||
if (!hasTasks && !hasMustHaves) {
|
||||
if (!hasPhases && !hasMustHaves) {
|
||||
return this.check(
|
||||
"Plan must-haves covered",
|
||||
"warning",
|
||||
"PLAN.md has no tasks or must-have items"
|
||||
"ROADMAP.md has no phases or must-have items"
|
||||
);
|
||||
}
|
||||
|
||||
return this.check(
|
||||
"Plan must-haves covered",
|
||||
"pass",
|
||||
"PLAN.md contains task definitions"
|
||||
"ROADMAP.md contains phase definitions"
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
@@ -8,13 +8,11 @@ describe("VerificationPipeline", () => {
|
||||
|
||||
beforeEach(() => {
|
||||
tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "ci-pipeline-test-"));
|
||||
const phaseDir = path.join(tempDir, ".planning", "phases", "phase-1");
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, "PLAN.md"), "# Plan\n\n- [ ] Task 1\n- [ ] Task 2\n");
|
||||
const ciDir = path.join(tempDir, ".ci");
|
||||
fs.mkdirSync(ciDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(ciDir, "config.json"), JSON.stringify({ autonomy: { level: "full" } }));
|
||||
fs.writeFileSync(path.join(ciDir, "specification.md"), "# Test\n## Objective\nBuild it\n\n## Requirements\n- Feature A\n");
|
||||
fs.writeFileSync(path.join(ciDir, "ROADMAP.md"), "# Roadmap\n\n## Phases\n\n### Phase 1: Init\n**Goal**: Set up project\n**Status**: not_started\n");
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
|
||||
@@ -28,7 +28,7 @@ const CODE_QUALITY_PATTERNS: Array<{
|
||||
message: "Direct console.log usage — consider structured logging",
|
||||
},
|
||||
{
|
||||
pattern: /any\b/g,
|
||||
pattern: /(?:as\s+any\b|:\s*any\b|<any>|any\[\s*\])/g,
|
||||
severity: "P1",
|
||||
category: "type_safety",
|
||||
message: "Use of 'any' type — loses type safety",
|
||||
|
||||
@@ -14,12 +14,12 @@ describe("StructuralVerification", () => {
|
||||
fs.rmSync(tempDir, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
function setupProjectStructure(hasPhaseDir = true, hasPlan = true, hasCIConfig = true, hasSpec = true) {
|
||||
if (hasPhaseDir) {
|
||||
const phaseDir = path.join(tempDir, ".planning", "phases", "phase-1");
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
if (hasPlan) {
|
||||
fs.writeFileSync(path.join(phaseDir, "PLAN.md"), "# Plan\n\nTasks:\n- [ ] Task 1\n- [ ] Task 2\n");
|
||||
function setupProjectStructure(hasCIDir = true, hasRoadmap = true, hasCIConfig = true, hasSpec = true) {
|
||||
if (hasCIDir) {
|
||||
const ciDir = path.join(tempDir, ".ci");
|
||||
fs.mkdirSync(ciDir, { recursive: true });
|
||||
if (hasRoadmap) {
|
||||
fs.writeFileSync(path.join(ciDir, "ROADMAP.md"), "# Roadmap\n\n## Phases\n\n### Phase 1: Init\n**Goal**: Set up project\n**Status**: not_started\n");
|
||||
}
|
||||
}
|
||||
if (hasCIConfig) {
|
||||
@@ -43,10 +43,10 @@ describe("StructuralVerification", () => {
|
||||
expect(result.name).toBe("Structural");
|
||||
expect(result.checks.length).toBeGreaterThan(0);
|
||||
|
||||
const phaseDirCheck = result.checks.find((c) => c.name === "Phase directory exists");
|
||||
const phaseDirCheck = result.checks.find((c) => c.name === ".ci directory exists");
|
||||
expect(phaseDirCheck?.status).toBe("pass");
|
||||
|
||||
const planCheck = result.checks.find((c) => c.name === "PLAN.md exists");
|
||||
const planCheck = result.checks.find((c) => c.name === "ROADMAP.md exists");
|
||||
expect(planCheck?.status).toBe("pass");
|
||||
|
||||
const configCheck = result.checks.find((c) => c.name === "CI config valid");
|
||||
@@ -56,29 +56,29 @@ describe("StructuralVerification", () => {
|
||||
expect(specCheck?.status).toBe("pass");
|
||||
});
|
||||
|
||||
it("fails when phase directory is missing", async () => {
|
||||
setupProjectStructure(false, false, true, true);
|
||||
it("fails when .ci directory is missing", async () => {
|
||||
setupProjectStructure(false, false, false, false);
|
||||
const verifier = new StructuralVerification();
|
||||
const result = await verifier.verify(tempDir, 1);
|
||||
|
||||
const phaseDirCheck = result.checks.find((c) => c.name === "Phase directory exists");
|
||||
const phaseDirCheck = result.checks.find((c) => c.name === ".ci directory exists");
|
||||
expect(phaseDirCheck?.status).toBe("fail");
|
||||
});
|
||||
|
||||
it("fails when PLAN.md is missing", async () => {
|
||||
it("warns when ROADMAP.md is missing", async () => {
|
||||
setupProjectStructure(true, false, true, true);
|
||||
const verifier = new StructuralVerification();
|
||||
const result = await verifier.verify(tempDir, 1);
|
||||
|
||||
const planCheck = result.checks.find((c) => c.name === "PLAN.md exists");
|
||||
expect(planCheck?.status).toBe("fail");
|
||||
const planCheck = result.checks.find((c) => c.name === "ROADMAP.md exists");
|
||||
expect(planCheck?.status).toBe("warning");
|
||||
});
|
||||
|
||||
it("fails when CI config has invalid JSON", async () => {
|
||||
const ciDir = path.join(tempDir, ".ci");
|
||||
fs.mkdirSync(ciDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(ciDir, "config.json"), "not valid json{{{");
|
||||
fs.mkdirSync(path.join(tempDir, ".planning", "phases", "phase-1"), { recursive: true });
|
||||
fs.mkdirSync(path.join(tempDir, ".ci"), { recursive: true });
|
||||
|
||||
const verifier = new StructuralVerification();
|
||||
const result = await verifier.verify(tempDir, 1);
|
||||
@@ -91,8 +91,6 @@ describe("StructuralVerification", () => {
|
||||
const srcDir = path.join(tempDir, "src");
|
||||
fs.mkdirSync(srcDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(srcDir, "app.ts"), "export function main() { /* TODO: implement */ }");
|
||||
fs.mkdirSync(path.join(tempDir, ".planning", "phases", "phase-1"), { recursive: true });
|
||||
fs.writeFileSync(path.join(tempDir, ".planning", "phases", "phase-1", "PLAN.md"), "# Plan");
|
||||
const ciDir = path.join(tempDir, ".ci");
|
||||
fs.mkdirSync(ciDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(ciDir, "config.json"), "{}");
|
||||
|
||||
@@ -13,9 +13,6 @@ const STUB_PATTERNS = [
|
||||
/not\s+implemented/i,
|
||||
];
|
||||
|
||||
const TODO_PATTERN = /\bTODO\b/gi;
|
||||
const FIXME_PATTERN = /\bFIXME\b/gi;
|
||||
|
||||
export class StructuralVerification extends VerificationLayer {
|
||||
readonly layer = 1;
|
||||
readonly name = "Structural";
|
||||
@@ -44,30 +41,24 @@ export class StructuralVerification extends VerificationLayer {
|
||||
}
|
||||
|
||||
private checkPhaseDir(projectPath: string, phase: number) {
|
||||
const phaseDir = path.join(projectPath, ".planning", "phases", `phase-${phase}`);
|
||||
const exists = fs.existsSync(phaseDir);
|
||||
const ciDir = path.join(projectPath, ".ci");
|
||||
const exists = fs.existsSync(ciDir);
|
||||
return this.check(
|
||||
"Phase directory exists",
|
||||
".ci directory exists",
|
||||
exists ? "pass" : "fail",
|
||||
exists ? `Phase ${phase} directory found` : `Phase ${phase} directory not found`,
|
||||
phaseDir
|
||||
exists ? ".ci directory found" : ".ci directory not found",
|
||||
ciDir
|
||||
);
|
||||
}
|
||||
|
||||
private checkPlanExists(projectPath: string, phase: number) {
|
||||
const planPath = path.join(
|
||||
projectPath,
|
||||
".planning",
|
||||
"phases",
|
||||
`phase-${phase}`,
|
||||
"PLAN.md"
|
||||
);
|
||||
const exists = fs.existsSync(planPath);
|
||||
const roadmapPath = path.join(projectPath, ".ci", "ROADMAP.md");
|
||||
const exists = fs.existsSync(roadmapPath);
|
||||
return this.check(
|
||||
"PLAN.md exists",
|
||||
exists ? "pass" : "fail",
|
||||
exists ? "PLAN.md found" : "PLAN.md not found",
|
||||
planPath
|
||||
"ROADMAP.md exists",
|
||||
exists ? "pass" : "warning",
|
||||
exists ? "ROADMAP.md found" : "ROADMAP.md not found (run 'ci init' first)",
|
||||
roadmapPath
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user