Jon Chery
f68f85c9fd
---ci---
project: acdl
phase: 20
milestone: v1.5
status: review
verdict: READY TO SHIP
p0: 1 (fixed — contract path resolution in deploy workflow)
p1: 6 (flagged post-hoc)
---/ci---
Multi-persona review of v1.5 phase 20 (docs + reusable deploy workflow).
P0 (blocking) — AUTO-FIXED:
- C1: scripts/run_platform.sh contract path resolution broken in deploy
workflow. The reusable workflow invokes run_platform.sh from the consumer
workspace root with a relative contract path (.acdl/contract.yaml), but
run_platform.sh does `cd "$ROOT"` (platform repo) early, so the relative
path resolved against the platform repo and the pipeline could never run.
Fix (commit 75c2274): capture CALLER_CWD before cd "$ROOT"; resolve
caller-supplied relative paths against CALLER_CWD; default no-arg contract
stays relative to ROOT (preserves platform-local CI). Reproduced pre-fix;
verified post-fix.
P1 (important) — FLAGGED FOR POST-HOC REVIEW (do not block ship):
- C2: ref: v1.4 in the deploy workflow platform checkout — no v1.4 tag exists
(only v1.4.0 / v1.4.1). Operator must create a floating v1.4 tag or change
the ref to v1.4.1.
- C3: modules/l2/{static-asset,microservice}/README.md still use @v1 in their
Usage examples; missed by the v1.4 bump.
- S1: static-key override is not wired. ACDL_AWS_* env vars on the OIDC step
are not read by aws-actions/configure-aws-credentials@v4 (it reads AWS_*
or its own access-key/secret-key inputs). The README/CONSUMER_GUIDE claim
a working override that doesn't function as written. Needs a conditional
step or renamed env vars + input wiring.
- S2: README overstates ABAC repo:org/repo:ref:... scoping. The workflow
constructs a numeric role name (github.repository_id); the actual claim
enforcement lives in the IAM trust policy, not in this workflow.
- T1: no deploy-workflow triggers conformance test (CI workflow has one;
deploy doesn't). Minor — reusable workflows use workflow_call, not push
triggers, but the contract's triggers field is then unenforced.
- A1: terraform/spike/terraform.tf uploaded as artifact leaks the AWS account
ID via the state-backend bucket name. Recommend excluding terraform.tf or
gating artifact upload to non-public repos.
P2 (nits) — listed for awareness: floating-tag terminology imprecision (M1),
header comment "Gitea Actions" in the GitHub copy (M2, intentional byte-
identical), pip install split (P1-perf), comment drift in pipelines/deploy.yaml
header (C4), module README internal inconsistency (C5).
Verdict: READY TO SHIP. The one P0 is fixed. The 6 P1s are post-hoc items —
the deploy workflow is a scaffold whose first real consumer run requires
operator setup (tag, IAM role, secrets) that gates go-live. The P1s should
be addressed before any consumer invokes uses: acdl/.gitea/workflows/
deploy.yml@v1.4 in earnest.
Tests: 154 pass (19 new). run_ci.sh green.
76 lines
2.5 KiB
JSON
76 lines
2.5 KiB
JSON
{
|
|
"$schema": "https://json-schema.org/draft/2020-12/schema",
|
|
"$id": "https://acdl.cloudinit.dev/schemas/deploy-pipeline.schema.json",
|
|
"title": "ACDL Central Deployment Pipeline Contract",
|
|
"description": "Declarative contract for the ACDL deployment pipeline. Declares the stages that run when a consumer submits a contract: validate-contract, resolve-stack, terraform-plan, checkov, confidence, apply. The platform (scripts/run_platform.sh) implements these stages. Consumers reference this pipeline via 'uses: acdl/pipelines/deploy.yaml@v1' in their contract YAML.",
|
|
"type": "object",
|
|
"required": ["name", "triggers", "runner", "stages"],
|
|
"properties": {
|
|
"name": {
|
|
"type": "string",
|
|
"description": "Pipeline name."
|
|
},
|
|
"environment": {
|
|
"type": "string",
|
|
"enum": ["dev", "production"],
|
|
"description": "Declared environment. dev = autonomous; production = HITL gates."
|
|
},
|
|
"triggers": {
|
|
"type": "object",
|
|
"required": ["push", "pull_request"],
|
|
"properties": {
|
|
"push": {
|
|
"type": "array",
|
|
"items": {"type": "string"},
|
|
"description": "Branches that trigger the pipeline on push."
|
|
},
|
|
"pull_request": {
|
|
"type": "array",
|
|
"items": {"type": "string"},
|
|
"description": "Branches that trigger the pipeline on PR."
|
|
}
|
|
}
|
|
},
|
|
"runner": {
|
|
"type": "string",
|
|
"description": "Runner image (e.g. 'ubuntu-latest')."
|
|
},
|
|
"python_version": {
|
|
"type": "string",
|
|
"description": "Python version for setup-python action."
|
|
},
|
|
"stages": {
|
|
"type": "array",
|
|
"minItems": 1,
|
|
"items": {"$ref": "#/$defs/stage"}
|
|
}
|
|
},
|
|
"$defs": {
|
|
"stage": {
|
|
"type": "object",
|
|
"required": ["name", "command", "required"],
|
|
"properties": {
|
|
"name": {
|
|
"type": "string",
|
|
"description": "Stage name."
|
|
},
|
|
"command": {
|
|
"type": "string",
|
|
"description": "The shell command to run for this stage."
|
|
},
|
|
"required": {
|
|
"type": "boolean",
|
|
"description": "If true, a non-zero exit code fails the pipeline."
|
|
},
|
|
"install": {
|
|
"type": "string",
|
|
"description": "Optional: pip install command to run before the stage command."
|
|
},
|
|
"description": {
|
|
"type": "string",
|
|
"description": "Optional: human-readable description of what this stage does."
|
|
}
|
|
}
|
|
}
|
|
}
|
|
} |