f68f85c9fd
---ci---
project: acdl
phase: 20
milestone: v1.5
status: review
verdict: READY TO SHIP
p0: 1 (fixed — contract path resolution in deploy workflow)
p1: 6 (flagged post-hoc)
---/ci---
Multi-persona review of v1.5 phase 20 (docs + reusable deploy workflow).
P0 (blocking) — AUTO-FIXED:
- C1: scripts/run_platform.sh contract path resolution broken in deploy
workflow. The reusable workflow invokes run_platform.sh from the consumer
workspace root with a relative contract path (.acdl/contract.yaml), but
run_platform.sh does `cd "$ROOT"` (platform repo) early, so the relative
path resolved against the platform repo and the pipeline could never run.
Fix (commit 75c2274): capture CALLER_CWD before cd "$ROOT"; resolve
caller-supplied relative paths against CALLER_CWD; default no-arg contract
stays relative to ROOT (preserves platform-local CI). Reproduced pre-fix;
verified post-fix.
P1 (important) — FLAGGED FOR POST-HOC REVIEW (do not block ship):
- C2: ref: v1.4 in the deploy workflow platform checkout — no v1.4 tag exists
(only v1.4.0 / v1.4.1). Operator must create a floating v1.4 tag or change
the ref to v1.4.1.
- C3: modules/l2/{static-asset,microservice}/README.md still use @v1 in their
Usage examples; missed by the v1.4 bump.
- S1: static-key override is not wired. ACDL_AWS_* env vars on the OIDC step
are not read by aws-actions/configure-aws-credentials@v4 (it reads AWS_*
or its own access-key/secret-key inputs). The README/CONSUMER_GUIDE claim
a working override that doesn't function as written. Needs a conditional
step or renamed env vars + input wiring.
- S2: README overstates ABAC repo:org/repo:ref:... scoping. The workflow
constructs a numeric role name (github.repository_id); the actual claim
enforcement lives in the IAM trust policy, not in this workflow.
- T1: no deploy-workflow triggers conformance test (CI workflow has one;
deploy doesn't). Minor — reusable workflows use workflow_call, not push
triggers, but the contract's triggers field is then unenforced.
- A1: terraform/spike/terraform.tf uploaded as artifact leaks the AWS account
ID via the state-backend bucket name. Recommend excluding terraform.tf or
gating artifact upload to non-public repos.
P2 (nits) — listed for awareness: floating-tag terminology imprecision (M1),
header comment "Gitea Actions" in the GitHub copy (M2, intentional byte-
identical), pip install split (P1-perf), comment drift in pipelines/deploy.yaml
header (C4), module README internal inconsistency (C5).
Verdict: READY TO SHIP. The one P0 is fixed. The 6 P1s are post-hoc items —
the deploy workflow is a scaffold whose first real consumer run requires
operator setup (tag, IAM role, secrets) that gates go-live. The P1s should
be addressed before any consumer invokes uses: acdl/.gitea/workflows/
deploy.yml@v1.4 in earnest.
Tests: 154 pass (19 new). run_ci.sh green.
181 lines
5.8 KiB
Python
181 lines
5.8 KiB
Python
import json
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
|
|
|
from acdl_platform.confidence_signal import (
|
|
WEIGHTS, PENALTY, THRESHOLDS, compute, Signal, _per_input_score,
|
|
)
|
|
|
|
|
|
class TestWeights:
|
|
def test_weights_sum_to_one(self):
|
|
assert sum(WEIGHTS.values()) == pytest.approx(1.0)
|
|
|
|
def test_policy_weight_highest(self):
|
|
assert WEIGHTS["policy"] == 0.30
|
|
|
|
def test_validation_weight(self):
|
|
assert WEIGHTS["validation"] == 0.25
|
|
|
|
|
|
class TestThresholds:
|
|
def test_dev_threshold(self):
|
|
assert THRESHOLDS["dev"] == 0.50
|
|
|
|
def test_qa_threshold(self):
|
|
assert THRESHOLDS["qa"] == 0.75
|
|
|
|
def test_prod_threshold(self):
|
|
assert THRESHOLDS["prod"] == 0.90
|
|
|
|
def test_dr_threshold(self):
|
|
assert THRESHOLDS["dr"] == 0.95
|
|
|
|
|
|
class TestPenalty:
|
|
def test_critical_is_none(self):
|
|
assert PENALTY["critical"] is None
|
|
|
|
def test_high_penalty(self):
|
|
assert PENALTY["high"] == 0.20
|
|
|
|
def test_medium_penalty(self):
|
|
assert PENALTY["medium"] == 0.05
|
|
|
|
def test_low_penalty(self):
|
|
assert PENALTY["low"] == 0.01
|
|
|
|
def test_info_no_penalty(self):
|
|
assert PENALTY["info"] == 0.0
|
|
|
|
|
|
class TestPerInputScore:
|
|
def test_missing_input_returns_half(self):
|
|
score, reasons = _per_input_score("policy", None)
|
|
assert score == 0.5
|
|
assert "INPUT_MISSING:policy" in reasons
|
|
|
|
def test_empty_policy_list(self):
|
|
score, reasons = _per_input_score("policy", [])
|
|
assert score == 0.5
|
|
assert reasons == []
|
|
|
|
def test_all_pass_policy(self):
|
|
pcrs = [{"result": "pass"}, {"result": "pass"}]
|
|
score, reasons = _per_input_score("policy", pcrs)
|
|
assert score == 1.0
|
|
assert reasons == []
|
|
|
|
def test_mixed_policy(self):
|
|
pcrs = [{"result": "pass"}, {"result": "fail"}]
|
|
score, reasons = _per_input_score("policy", pcrs)
|
|
assert score == 0.5
|
|
|
|
def test_skipped_counts_as_pass(self):
|
|
pcrs = [{"result": "skipped"}]
|
|
score, reasons = _per_input_score("policy", pcrs)
|
|
assert score == 1.0
|
|
|
|
def test_validation_all_true(self):
|
|
score, reasons = _per_input_score("validation", {
|
|
"schema": True, "stack_resolved": True,
|
|
"tf_validated": True, "tf_planned": True
|
|
})
|
|
assert score == 1.0
|
|
|
|
def test_validation_partial(self):
|
|
score, reasons = _per_input_score("validation", {
|
|
"schema": True, "stack_resolved": True,
|
|
"tf_validated": False, "tf_planned": False
|
|
})
|
|
assert score == 0.5
|
|
|
|
def test_freshness_fresh(self):
|
|
score, _ = _per_input_score("freshness", {"age_days": 0, "max_age_days": 7})
|
|
assert score == 1.0
|
|
|
|
def test_freshness_stale(self):
|
|
score, _ = _per_input_score("freshness", {"age_days": 7, "max_age_days": 7})
|
|
assert score == pytest.approx(0.0)
|
|
|
|
def test_source_complete(self):
|
|
score, _ = _per_input_score("source", {"submitter": "dev", "commit_sha": "abc"})
|
|
assert score == 1.0
|
|
|
|
def test_source_partial(self):
|
|
score, _ = _per_input_score("source", {"submitter": "dev"})
|
|
assert score == 0.5
|
|
|
|
def test_history_clean(self):
|
|
score, _ = _per_input_score("history", {"prior_rollbacks": 0, "prior_policy_fails": 0})
|
|
assert score == 1.0
|
|
|
|
def test_history_with_failures(self):
|
|
score, _ = _per_input_score("history", {"prior_rollbacks": 2, "prior_policy_fails": 3})
|
|
assert score == pytest.approx(0.3)
|
|
|
|
def test_nfrs_none(self):
|
|
score, _ = _per_input_score("nfrs", {"conformance": None})
|
|
assert score == 0.5
|
|
|
|
def test_nfrs_full(self):
|
|
score, _ = _per_input_score("nfrs", {"conformance": 0.95})
|
|
assert score == 0.95
|
|
|
|
|
|
class TestCompute:
|
|
def _base_inputs(self):
|
|
return {
|
|
"policy": [{"result": "pass"}],
|
|
"validation": {"schema": True, "stack_resolved": True,
|
|
"tf_validated": True, "tf_planned": True},
|
|
"freshness": {"age_days": 0, "max_age_days": 7},
|
|
"source": {"submitter": "dev", "commit_sha": "abc"},
|
|
"history": {"prior_rollbacks": 0, "prior_policy_fails": 0},
|
|
"nfrs": {"conformance": None},
|
|
}
|
|
|
|
def test_dev_pass(self):
|
|
sig = compute("test-001", "dev", self._base_inputs())
|
|
assert sig.band == "pass"
|
|
assert sig.score >= 0.50
|
|
|
|
def test_missing_input_blocks(self):
|
|
inputs = self._base_inputs()
|
|
del inputs["policy"]
|
|
sig = compute("test-002", "dev", inputs)
|
|
assert sig.band == "block"
|
|
assert sig.score == 0.0
|
|
assert any("INPUT_MISSING" in r for r in sig.reasonCodes)
|
|
|
|
def test_critical_policy_blocks(self):
|
|
inputs = self._base_inputs()
|
|
inputs["policy"] = [{"result": "fail", "severity": "critical", "ruleId": "CKV_X"}]
|
|
sig = compute("test-003", "dev", inputs)
|
|
assert sig.band == "block"
|
|
assert sig.score == 0.0
|
|
assert any("CRITICAL_OVERRIDE" in r for r in sig.reasonCodes)
|
|
|
|
def test_high_policy_lowers_score(self):
|
|
inputs = self._base_inputs()
|
|
inputs["policy"] = [{"result": "fail", "severity": "high", "ruleId": "CKV_Y"}]
|
|
sig = compute("test-004", "dev", inputs)
|
|
assert sig.score < 1.0
|
|
|
|
def test_dev_warn_becomes_block(self):
|
|
sig = compute("test-005", "dev", self._base_inputs())
|
|
assert sig.band != "warn"
|
|
|
|
def test_signal_has_per_input(self):
|
|
sig = compute("test-006", "dev", self._base_inputs())
|
|
assert "policy" in sig.perInput
|
|
assert "validation" in sig.perInput
|
|
assert "nfrs" in sig.perInput
|
|
|
|
def test_all_six_inputs_present(self):
|
|
sig = compute("test-007", "dev", self._base_inputs())
|
|
assert len(sig.perInput) == 6 |