continuous-intelligence/acdl

Fork 0

Files

T

History

Jon Chery f68f85c9fd

acdl-ci / Lint (push) Successful in 7s

Details

acdl-ci / Test (push) Successful in 15s

Details

acdl-ci / Platform check-only (offline) (push) Successful in 9s

Details

review(v1.5): READY TO SHIP — multi-persona code review

---ci---
project: acdl
phase: 20
milestone: v1.5
status: review
verdict: READY TO SHIP
p0: 1 (fixed — contract path resolution in deploy workflow)
p1: 6 (flagged post-hoc)
---/ci---

Multi-persona review of v1.5 phase 20 (docs + reusable deploy workflow).

P0 (blocking) — AUTO-FIXED:
- C1: scripts/run_platform.sh contract path resolution broken in deploy
  workflow. The reusable workflow invokes run_platform.sh from the consumer
  workspace root with a relative contract path (.acdl/contract.yaml), but
  run_platform.sh does `cd "$ROOT"` (platform repo) early, so the relative
  path resolved against the platform repo and the pipeline could never run.
  Fix (commit 75c2274): capture CALLER_CWD before cd "$ROOT"; resolve
  caller-supplied relative paths against CALLER_CWD; default no-arg contract
  stays relative to ROOT (preserves platform-local CI). Reproduced pre-fix;
  verified post-fix.

P1 (important) — FLAGGED FOR POST-HOC REVIEW (do not block ship):
- C2: ref: v1.4 in the deploy workflow platform checkout — no v1.4 tag exists
  (only v1.4.0 / v1.4.1). Operator must create a floating v1.4 tag or change
  the ref to v1.4.1.
- C3: modules/l2/{static-asset,microservice}/README.md still use @v1 in their
  Usage examples; missed by the v1.4 bump.
- S1: static-key override is not wired. ACDL_AWS_* env vars on the OIDC step
  are not read by aws-actions/configure-aws-credentials@v4 (it reads AWS_*
  or its own access-key/secret-key inputs). The README/CONSUMER_GUIDE claim
  a working override that doesn't function as written. Needs a conditional
  step or renamed env vars + input wiring.
- S2: README overstates ABAC repo:org/repo:ref:... scoping. The workflow
  constructs a numeric role name (github.repository_id); the actual claim
  enforcement lives in the IAM trust policy, not in this workflow.
- T1: no deploy-workflow triggers conformance test (CI workflow has one;
  deploy doesn't). Minor — reusable workflows use workflow_call, not push
  triggers, but the contract's triggers field is then unenforced.
- A1: terraform/spike/terraform.tf uploaded as artifact leaks the AWS account
  ID via the state-backend bucket name. Recommend excluding terraform.tf or
  gating artifact upload to non-public repos.

P2 (nits) — listed for awareness: floating-tag terminology imprecision (M1),
  header comment "Gitea Actions" in the GitHub copy (M2, intentional byte-
  identical), pip install split (P1-perf), comment drift in pipelines/deploy.yaml
  header (C4), module README internal inconsistency (C5).

Verdict: READY TO SHIP. The one P0 is fixed. The 6 P1s are post-hoc items —
the deploy workflow is a scaffold whose first real consumer run requires
operator setup (tag, IAM role, secrets) that gates go-live. The P1s should
be addressed before any consumer invokes uses: acdl/.gitea/workflows/
deploy.yml@v1.4 in earnest.

Tests: 154 pass (19 new). run_ci.sh green.

2026-07-22 17:24:28 +00:00

interface.json

review(v1.5): READY TO SHIP — multi-persona code review

2026-07-22 17:24:28 +00:00

README.md

review(v1.5): READY TO SHIP — multi-persona code review

2026-07-22 17:24:28 +00:00

README.md

vpc — VPC with subnets and routing

Module kind: L1 primitive | Version: 1.0.0

A VPC with one subnet per availability zone and a route table with a default route through an internet gateway. The networking foundation that other modules (ALB, ECS service) reference for subnet ids.

Resources

Resource	Type	Purpose
vpc	`aws_vpc`	The VPC itself
subnet	`aws_subnet`	One subnet per availability zone
route_table	`aws_route_table`	Route table with default route 0.0.0.0/0
internet_gateway	`aws_internet_gateway`	IGW for public internet access
route_table_association	`aws_route_table_association`	Binds subnet to route table

Inputs

Name	Type	Required	Default	Description
`cidr`	string	yes	—	VPC CIDR block, e.g. `10.0.0.0/16`
`azs`	string	yes	—	Comma-separated availability zones, e.g. `us-east-1a,us-east-1b`
`name`	string	yes	—	Name tag for the VPC and child resources
`region`	string	yes	—	AWS region the VPC is created in

Outputs

Name	Type	Description
`vpc_id`	string	The VPC id
`subnet_ids`	string	Comma-separated subnet ids

Usage

{
  "id": "vpc",
  "type": "aws:ec2:vpc",
  "module": "vpc@1.0.0",
  "inputs": {
    "cidr": "10.0.0.0/16",
    "azs": "us-east-1a,us-east-1b",
    "name": "acdl-microservice",
    "region": "us-east-1"
  }
}

The azs input is split on comma; one subnet is created per zone. The route table gets a default route 0.0.0.0/0 → internet gateway. Other modules reference subnet_ids for their network placement.

Compliance extension points

VPC Flow Logs — add aws_flow_log + CloudWatch Logs group / S3 destination (SOX ITGC, SOC2 CC7.2, HIPAA §164.312(b), DORA ICT risk logging).
Private subnets + NAT gateway — add private subnets with a NAT gateway so ECS tasks don't need public IPs (SOC2 CC6.6, PCI-DSS 1.3, HIPAA network isolation).
VPC endpoints — add S3, ECR, KMS, DynamoDB, CloudWatch interface/gateway endpoints to keep traffic off the public internet (SOC2 CC6.7, GDPR Art.32(1)(a), DORA ICT third-party risk).
Security groups — add aws_security_group as a first-class sub-resource (currently missing; needed for all regulated deployments) (SOC2 CC6.6, PCI-DSS 1.2).
Network ACLs — add aws_network_acl for subnet-level segmentation (PCI-DSS 1.3).

Versioning

1.0.0 — interface MAJOR, behavior MINOR, lifecycle PATCH. MAJOR bumps require a new registry entry (immutable publication); old entries enter a 12-month deprecation window.