Jon Chery
13846d553a
Code review (correctness lens) found the same P5 mechanical-edit defect
in two more test files: the ACDL_* fallback delenv was replaced with a
duplicate NOVA_* delenv (leaving a dead duplicate line, a stale 'ACDL_*
fallback until P5' comment, and the ACDL_* var no longer cleaned).
- tests/test_route_halt_artifact.py: two sites (stderr-fallback +
outbox-fallback) each deleted NOVA_SOD_HALT_TOPIC_ARN twice.
- tests/test_adapter.py::test_default_remote_state_key: deleted
NOVA_REMOTE_STATE_KEY twice.
With core/env.py NOVA-only as of P5, a single NOVA_* delenv is the
correct precondition. Collapsed to one delenv per var + updated comments.
---ci---
project: acdl
phase: 5
milestone: v1.15
status: verify
lessons:
- P0 fix applied: duplicate monkeypatch.delenv('NOVA_*') in test_route_halt_artifact.py (2 sites) + test_adapter.py collapsed to a single delenv consistent with the P5 NOVA-only core/env.py.
---/ci---
70 lines
3.1 KiB
Python
70 lines
3.1 KiB
Python
"""REQ-107: route_halt_artifact is a real implementation (SNS + outbox fallback)."""
|
|
import json
|
|
import os
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest import mock
|
|
|
|
import pytest
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
sys.path.insert(0, str(ROOT))
|
|
|
|
from core.separation_of_duties import route_halt_artifact
|
|
|
|
|
|
def test_route_halt_publishes_to_sns_when_arn_set(monkeypatch):
|
|
"""With NOVA_SOD_HALT_TOPIC_ARN set, the SNS client receives the publish."""
|
|
monkeypatch.setenv("NOVA_SOD_HALT_TOPIC_ARN", "arn:aws:sns:us-east-1:000000000000:nova-sod-halt")
|
|
sns_client = mock.MagicMock()
|
|
route_halt_artifact("contract-123", "SEPARATION_OF_DUTIES_VIOLATION: x==y",
|
|
oncall_client=sns_client)
|
|
sns_client.publish.assert_called_once()
|
|
call = sns_client.publish.call_args
|
|
assert call.kwargs["TopicArn"] == "arn:aws:sns:us-east-1:000000000000:nova-sod-halt"
|
|
assert "contract-123" in call.kwargs["Message"]
|
|
assert "SEPARATION_OF_DUTIES_VIOLATION" in call.kwargs["Message"]
|
|
assert call.kwargs["Subject"] == "ACDL SoD halt"
|
|
|
|
|
|
def test_route_halt_falls_back_to_stderr_when_arn_unset(monkeypatch, capsys):
|
|
"""Without NOVA_SOD_HALT_TOPIC_ARN, a stderr emission occurs."""
|
|
# P5 (REQ-164): ACDL_* fallback removed — NOVA_* only.
|
|
monkeypatch.delenv("NOVA_SOD_HALT_TOPIC_ARN", raising=False)
|
|
# Mock outbox_writer.write_event to avoid AWS calls.
|
|
with mock.patch("core.outbox_writer.write_event", return_value=None):
|
|
route_halt_artifact("contract-456", "violation", oncall_client=None)
|
|
captured = capsys.readouterr()
|
|
assert "contract-456" in captured.err
|
|
assert "violation" in captured.err
|
|
|
|
|
|
def test_route_halt_outbox_fallback_writes_event(monkeypatch):
|
|
"""Without the SNS ARN, the outbox fallback writes a SEPARATION_OF_DUTIES_VIOLATION event."""
|
|
# P5 (REQ-164): ACDL_* fallback removed — NOVA_* only.
|
|
monkeypatch.delenv("NOVA_SOD_HALT_TOPIC_ARN", raising=False)
|
|
with mock.patch("core.outbox_writer.write_event") as mock_write:
|
|
route_halt_artifact("contract-789", "sod violation", oncall_client=None)
|
|
mock_write.assert_called_once()
|
|
event = mock_write.call_args[0][0]
|
|
assert event["contractId"] == "contract-789"
|
|
assert event["eventType"] == "SEPARATION_OF_DUTIES_VIOLATION"
|
|
assert "sod violation" in event["reason"]
|
|
|
|
|
|
def test_route_halt_sns_failure_falls_back_to_outbox(monkeypatch):
|
|
"""If SNS publish raises, the outbox fallback is used."""
|
|
monkeypatch.setenv("NOVA_SOD_HALT_TOPIC_ARN", "arn:aws:sns:us-east-1:000000000000:nova-sod-halt")
|
|
sns_client = mock.MagicMock()
|
|
sns_client.publish.side_effect = Exception("SNS down")
|
|
with mock.patch("core.outbox_writer.write_event") as mock_write:
|
|
route_halt_artifact("contract-fail", "violation", oncall_client=sns_client)
|
|
mock_write.assert_called_once()
|
|
|
|
|
|
def test_sns_topic_defined_in_terraform():
|
|
"""terraform/platform/main.tf defines the nova-sod-halt SNS topic."""
|
|
tf = (ROOT / "terraform" / "platform" / "main.tf").read_text()
|
|
assert "aws_sns_topic" in tf
|
|
assert "nova-sod-halt" in tf
|
|
assert "nova_sod_halt_topic_arn" in tf |