Jon Chery
f68f85c9fd
---ci---
project: acdl
phase: 20
milestone: v1.5
status: review
verdict: READY TO SHIP
p0: 1 (fixed — contract path resolution in deploy workflow)
p1: 6 (flagged post-hoc)
---/ci---
Multi-persona review of v1.5 phase 20 (docs + reusable deploy workflow).
P0 (blocking) — AUTO-FIXED:
- C1: scripts/run_platform.sh contract path resolution broken in deploy
workflow. The reusable workflow invokes run_platform.sh from the consumer
workspace root with a relative contract path (.acdl/contract.yaml), but
run_platform.sh does `cd "$ROOT"` (platform repo) early, so the relative
path resolved against the platform repo and the pipeline could never run.
Fix (commit 75c2274): capture CALLER_CWD before cd "$ROOT"; resolve
caller-supplied relative paths against CALLER_CWD; default no-arg contract
stays relative to ROOT (preserves platform-local CI). Reproduced pre-fix;
verified post-fix.
P1 (important) — FLAGGED FOR POST-HOC REVIEW (do not block ship):
- C2: ref: v1.4 in the deploy workflow platform checkout — no v1.4 tag exists
(only v1.4.0 / v1.4.1). Operator must create a floating v1.4 tag or change
the ref to v1.4.1.
- C3: modules/l2/{static-asset,microservice}/README.md still use @v1 in their
Usage examples; missed by the v1.4 bump.
- S1: static-key override is not wired. ACDL_AWS_* env vars on the OIDC step
are not read by aws-actions/configure-aws-credentials@v4 (it reads AWS_*
or its own access-key/secret-key inputs). The README/CONSUMER_GUIDE claim
a working override that doesn't function as written. Needs a conditional
step or renamed env vars + input wiring.
- S2: README overstates ABAC repo:org/repo:ref:... scoping. The workflow
constructs a numeric role name (github.repository_id); the actual claim
enforcement lives in the IAM trust policy, not in this workflow.
- T1: no deploy-workflow triggers conformance test (CI workflow has one;
deploy doesn't). Minor — reusable workflows use workflow_call, not push
triggers, but the contract's triggers field is then unenforced.
- A1: terraform/spike/terraform.tf uploaded as artifact leaks the AWS account
ID via the state-backend bucket name. Recommend excluding terraform.tf or
gating artifact upload to non-public repos.
P2 (nits) — listed for awareness: floating-tag terminology imprecision (M1),
header comment "Gitea Actions" in the GitHub copy (M2, intentional byte-
identical), pip install split (P1-perf), comment drift in pipelines/deploy.yaml
header (C4), module README internal inconsistency (C5).
Verdict: READY TO SHIP. The one P0 is fixed. The 6 P1s are post-hoc items —
the deploy workflow is a scaffold whose first real consumer run requires
operator setup (tag, IAM role, secrets) that gates go-live. The P1s should
be addressed before any consumer invokes uses: acdl/.gitea/workflows/
deploy.yml@v1.4 in earnest.
Tests: 154 pass (19 new). run_ci.sh green.
86 lines
2.4 KiB
JSON
86 lines
2.4 KiB
JSON
{
|
|
"name": "ecs-service",
|
|
"version": "1.0.0",
|
|
"kind": "l1",
|
|
"type": "aws:ecs:task_definition",
|
|
"description": "ECS Fargate service primitive (substrate-agnostic stack types aws:ecs:task_definition + aws:ecs:service; the Terraform adapter translates to aws_ecs_task_definition/aws_ecs_service).",
|
|
"inputs": {
|
|
"image": {
|
|
"type": "string",
|
|
"description": "ECR image URL for the task container.",
|
|
"required": true
|
|
},
|
|
"port": {
|
|
"type": "number",
|
|
"description": "Container port the service listens on.",
|
|
"required": true
|
|
},
|
|
"cpu": {
|
|
"type": "number",
|
|
"description": "Task CPU units (Fargate).",
|
|
"required": false,
|
|
"default": 256
|
|
},
|
|
"memory": {
|
|
"type": "number",
|
|
"description": "Task memory (MiB, Fargate).",
|
|
"required": false,
|
|
"default": 512
|
|
},
|
|
"env": {
|
|
"type": "string",
|
|
"description": "Environment variables as a JSON map string (optional).",
|
|
"required": false
|
|
},
|
|
"cluster_arn": {
|
|
"type": "arn",
|
|
"description": "ECS cluster ARN (ref to ecs-cluster).",
|
|
"required": true
|
|
},
|
|
"subnets": {
|
|
"type": "string",
|
|
"description": "Comma-separated subnet ids (ref to vpc).",
|
|
"required": true
|
|
},
|
|
"security_group": {
|
|
"type": "string",
|
|
"description": "Security group id for the service ENIs.",
|
|
"required": true
|
|
},
|
|
"lb_target_group_arn": {
|
|
"type": "arn",
|
|
"description": "Optional ALB target group ARN (ref to alb).",
|
|
"required": false
|
|
},
|
|
"region": {
|
|
"type": "string",
|
|
"description": "AWS region the service is created in.",
|
|
"required": true
|
|
}
|
|
},
|
|
"outputs": {
|
|
"service_arn": {
|
|
"type": "arn",
|
|
"description": "The ECS service ARN."
|
|
},
|
|
"task_def_arn": {
|
|
"type": "arn",
|
|
"description": "The ECS task definition ARN."
|
|
}
|
|
},
|
|
"nfrs": {},
|
|
"resources": [
|
|
{
|
|
"type": "aws:ecs:task_definition",
|
|
"description": "Fargate task definition; the adapter jsonencodes image/port/env into container_definitions.",
|
|
"inputs": ["image", "port", "cpu", "memory", "env"],
|
|
"outputs": ["task_def_arn"]
|
|
},
|
|
{
|
|
"type": "aws:ecs:service",
|
|
"description": "Fargate service running the task definition in the cluster + subnets.",
|
|
"inputs": ["cluster_arn", "subnets", "security_group", "lb_target_group_arn"],
|
|
"outputs": ["service_arn"]
|
|
}
|
|
]
|
|
} |