Jon Chery
cd637808f5
---ci---
project: acdl
phase: 41
milestone: v1.9
status: execute
---/ci---
Phase 41 — per-environment-ci-jobs (REQ-105, REQ-106, D-082):
Per-env contracts (REQ-105):
- contracts/static-assets.{dev,qa,prod,dr}.yaml + microservice.{dev,qa,prod,dr}.yaml
(8 files, each sets environment: to its own name, uses interpolation).
- Default contracts/static-assets.yaml + microservice.yaml preserved (backwards compat).
Deploy workflow environment input (REQ-106):
- .github/workflows/deploy.yml + .gitea/workflows/deploy.yml (byte-identical):
new 'environment' workflow_call input (default empty, override).
- scripts/run_platform.sh: --environment <name> flag; exports
ACDL_ENVIRONMENT_OVERRIDE; re-runs env check against the override.
- core/contract_resolver.py: resolve(environment_override=...) (D-088);
CLI honors --environment flag + ACDL_ENVIRONMENT_OVERRIDE env var.
Consumer guide (REQ-106):
- docs/consumer-guide.md: 'Per-environment deployment' section with 4
caller-workflow examples (dev/qa/prod/dr), HITL gate structure
(approve_qa/approve_prod/approve_dr, D-042), interpolation reference table.
- Documents promotion-without-editing + hybrid model (per-env contracts
OR single contract + env input).
Tests: +40 (test_per_env_contracts.py, test_deploy_workflow_env_input.py,
test_consumer_guide_per_env_section.py). 446 passed; run_ci.sh green;
deploy workflows byte-identical.
81 lines
2.9 KiB
Python
81 lines
2.9 KiB
Python
"""REQ-106: deploy workflow environment input + run_platform.sh --environment.
|
|
Both deploy workflows (Gitea + GitHub) declare the environment input,
|
|
are byte-identical, and the resolver supports environment_override.
|
|
"""
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
sys.path.insert(0, str(ROOT))
|
|
|
|
from core.contract_resolver import resolve
|
|
|
|
GITHUB = ROOT / ".github" / "workflows" / "deploy.yml"
|
|
GITEA = ROOT / ".gitea" / "workflows" / "deploy.yml"
|
|
|
|
|
|
def test_both_deploy_workflows_exist():
|
|
assert GITHUB.is_file()
|
|
assert GITEA.is_file()
|
|
|
|
|
|
def test_deploy_workflows_byte_identical():
|
|
assert GITHUB.read_text() == GITEA.read_text(), "deploy workflows must be byte-identical"
|
|
|
|
|
|
def test_deploy_workflow_has_environment_input():
|
|
text = GITHUB.read_text()
|
|
assert "environment:" in text
|
|
assert "Target environment override" in text
|
|
# The input is declared in the workflow_call inputs section.
|
|
assert 'default: ""' in text
|
|
|
|
|
|
def test_deploy_workflow_passes_env_flag_to_run_platform():
|
|
text = GITHUB.read_text()
|
|
assert "--environment" in text
|
|
assert "ENV_FLAG" in text
|
|
assert "inputs.environment" in text
|
|
|
|
|
|
def test_resolver_environment_override_changes_env():
|
|
"""D-088: environment_override changes the resolved environment."""
|
|
stack = resolve(str(ROOT / "contracts" / "static-assets.yaml"),
|
|
environment_override="qa")
|
|
s3 = [r for r in stack["resources"] if r["type"] == "aws:s3:bucket"][0]
|
|
assert "qa" in s3["inputs"]["bucket_name"]
|
|
|
|
|
|
def test_resolver_environment_override_prod():
|
|
stack = resolve(str(ROOT / "contracts" / "static-assets.yaml"),
|
|
environment_override="prod")
|
|
s3 = [r for r in stack["resources"] if r["type"] == "aws:s3:bucket"][0]
|
|
assert "prod" in s3["inputs"]["bucket_name"]
|
|
|
|
|
|
def test_resolver_environment_override_dr():
|
|
stack = resolve(str(ROOT / "contracts" / "static-assets.yaml"),
|
|
environment_override="dr")
|
|
s3 = [r for r in stack["resources"] if r["type"] == "aws:s3:bucket"][0]
|
|
assert "dr" in s3["inputs"]["bucket_name"]
|
|
|
|
|
|
def test_resolver_no_override_uses_contract_env():
|
|
stack = resolve(str(ROOT / "contracts" / "static-assets.yaml"))
|
|
s3 = [r for r in stack["resources"] if r["type"] == "aws:s3:bucket"][0]
|
|
assert "dev" in s3["inputs"]["bucket_name"]
|
|
|
|
|
|
def test_resolver_override_none_uses_contract_env():
|
|
"""Passing environment_override=None uses the contract's environment."""
|
|
stack = resolve(str(ROOT / "contracts" / "static-assets.yaml"),
|
|
environment_override=None)
|
|
s3 = [r for r in stack["resources"] if r["type"] == "aws:s3:bucket"][0]
|
|
assert "dev" in s3["inputs"]["bucket_name"]
|
|
|
|
|
|
def test_run_platform_sh_has_environment_flag():
|
|
text = (ROOT / "scripts" / "run_platform.sh").read_text()
|
|
assert "--environment" in text
|
|
assert "ENVIRONMENT_OVERRIDE" in text
|
|
assert "ACDL_ENVIRONMENT_OVERRIDE" in text |