ad3cc5f129
acdl-ci / Lint (pull_request) Successful in 7s
acdl-ci / Test (pull_request) Successful in 4m3s
acdl-ci / Platform check-only (offline) (pull_request) Successful in 21s
acdl-modules-lifecycle / CI VPC apply (pull_request) Failing after 1m25s
acdl-modules-lifecycle / L1 lifecycle (alb) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (cloudfront) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (ecr) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (ecs-cluster) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (ecs-service) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (iam-role) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (kms-key) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (rds) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (s3) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (uptime) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (vpc) (pull_request) Has been skipped
acdl-modules-lifecycle / L1 lifecycle (waf) (pull_request) Has been skipped
acdl-modules-lifecycle / CI VPC destroy (pull_request) Successful in 44s
Two architectural changes: 1. Created terraform/ci-vpc/ — a short-lived VPC for L1 module lifecycle testing, separate from the long-lived platform VPC. Created before VPC-dependent modules (alb, ecs-service, rds, uptime) are tested, destroyed after. Outputs (vpc_id, subnet_ids, sg_id, cluster_arn) are passed to those modules via scripts/run_lifecycle_test.sh + run_lifecycle_destroy.sh wrappers that inject the CI VPC outputs into the example contracts. 2. Updated the workflow to use ci-vpc-apply → lifecycle (with artifact passing) → ci-vpc-destroy (always runs). 8 module-specific fixes: - s3: unique bucket names (acdl-ci-s3a-simple/complex) instead of globally-taken 'my-simple-bucket' - kms-key: alias name with no spaces (locals.tf → alias/acdl-ci-kms) - iam-role: example contract uses role_name (not name, which the interface doesn't declare) - ecs-service: example contract uses family (not name); VPC inputs (cluster_arn, subnets, security_group) injected by CI VPC wrapper - uptime: added subnets, security_group, cluster_arn to interface + module; network_configuration is dynamic (only when subnets provided) - rds: added subnet_ids input + db_subnet_group resource (conditional on subnet_ids being non-empty) - alb: removed hardcoded placeholder sg/subnet values from examples; vpc_id + subnets + security_group injected by CI VPC wrapper - cloudfront: removed invalid placeholder WAF ARN from complex example Regression: 479 passed, 0 skipped, 5 deselected. All 24 example contracts pass --check-only. ---ci--- project: acdl phase: P59 milestone: v1.11 status: execute ---/ci---
112 lines
2.4 KiB
Terraform
112 lines
2.4 KiB
Terraform
# ACDL CI VPC — short-lived VPC for L1 module lifecycle testing.
|
|
#
|
|
# Created by the modules-lifecycle pipeline before testing VPC-dependent
|
|
# modules (alb, ecs-service, rds, uptime). Destroyed after all tests complete.
|
|
# Separate from the long-lived platform VPC (terraform/platform).
|
|
#
|
|
# State: spike/ci-vpc/terraform.tfstate (separate from platform/ and module states)
|
|
|
|
terraform {
|
|
required_version = ">= 1.9, < 1.10"
|
|
required_providers {
|
|
aws = {
|
|
source = "hashicorp/aws"
|
|
version = "~> 5.0"
|
|
}
|
|
}
|
|
backend "s3" {
|
|
bucket = "acdl-tfstate-581513795199-us-east-1"
|
|
key = "spike/ci-vpc/terraform.tfstate"
|
|
region = "us-east-1"
|
|
}
|
|
}
|
|
|
|
provider "aws" {
|
|
region = "us-east-1"
|
|
}
|
|
|
|
data "aws_availability_zones" "available" {
|
|
state = "available"
|
|
}
|
|
|
|
resource "aws_vpc" "ci" {
|
|
cidr_block = "10.1.0.0/16"
|
|
tags = {
|
|
Name = "acdl-ci-vpc"
|
|
"acdl:owner" = "acdl"
|
|
"acdl:environment" = "ci"
|
|
}
|
|
}
|
|
|
|
resource "aws_subnet" "ci" {
|
|
count = 2
|
|
vpc_id = aws_vpc.ci.id
|
|
cidr_block = cidrsubnet(aws_vpc.ci.cidr_block, 8, count.index + 1)
|
|
availability_zone = data.aws_availability_zones.available.names[count.index]
|
|
tags = {
|
|
Name = "acdl-ci-subnet-${count.index}"
|
|
"acdl:owner" = "acdl"
|
|
"acdl:environment" = "ci"
|
|
}
|
|
}
|
|
|
|
resource "aws_internet_gateway" "ci" {
|
|
vpc_id = aws_vpc.ci.id
|
|
tags = {
|
|
Name = "acdl-ci-igw"
|
|
}
|
|
}
|
|
|
|
resource "aws_route_table" "ci" {
|
|
vpc_id = aws_vpc.ci.id
|
|
route {
|
|
cidr_block = "0.0.0.0/0"
|
|
gateway_id = aws_internet_gateway.ci.id
|
|
}
|
|
}
|
|
|
|
resource "aws_route_table_association" "ci" {
|
|
count = 2
|
|
subnet_id = aws_subnet.ci[count.index].id
|
|
route_table_id = aws_route_table.ci.id
|
|
}
|
|
|
|
resource "aws_security_group" "ecs" {
|
|
name = "acdl-ci-ecs-sg"
|
|
description = "Security group for CI ECS services"
|
|
vpc_id = aws_vpc.ci.id
|
|
|
|
ingress {
|
|
from_port = 80
|
|
to_port = 80
|
|
protocol = "tcp"
|
|
cidr_blocks = ["0.0.0.0/0"]
|
|
}
|
|
|
|
egress {
|
|
from_port = 0
|
|
to_port = 0
|
|
protocol = "-1"
|
|
cidr_blocks = ["0.0.0.0/0"]
|
|
}
|
|
}
|
|
|
|
resource "aws_ecs_cluster" "ci" {
|
|
name = "acdl-ci-cluster"
|
|
}
|
|
|
|
output "vpc_id" {
|
|
value = aws_vpc.ci.id
|
|
}
|
|
|
|
output "subnet_ids" {
|
|
value = join(",", aws_subnet.ci[*].id)
|
|
}
|
|
|
|
output "ecs_security_group_id" {
|
|
value = aws_security_group.ecs.id
|
|
}
|
|
|
|
output "cluster_arn" {
|
|
value = aws_ecs_cluster.ci.arn
|
|
} |