Jon Chery
bee9d02f01
---ci---
project: acdl
phase: 40
milestone: v1.9
status: execute
---/ci---
Phase 40 — contract-interpolation (REQ-103, REQ-104, D-081):
Interpolation:
- core/contract_resolver.py: _expand_vars(value, context) recursively
expands ${env.<field>} + ${contract.<field>} tokens (dotted paths
supported, e.g. ${env.state_backend.bucket}). Unknown tokens raise
ValueError (fail loud). Expansion is post-schema-validation,
pre-IR-resolution.
- resolve() accepts environment_override (D-088) — overrides the
contract's environment field BEFORE schema validation so interpolation
context is consistent.
- env context loaded via _load_env (self-contained, works as script +
package import); 'environment' alias for env 'name' so
${env.environment} resolves.
Environment schema + bindings:
- schemas/environment.schema.json (draft 2020-12): name, account_id,
region, state_backend, network, runner_role_arn, autonomy, confidence_threshold.
- core/environments/qa.json, prod.json, dr.json placeholder bindings
(attested, thresholds 0.75/0.90/0.95, placeholder account_id with
stderr warning at load).
- core/environment_check.py: load(env_name) helper + placeholder warning.
Sample contracts:
- contracts/static-assets.yaml + microservice.yaml use
acdl-${env.environment}-${contract.module}-${env.account_id}-${env.region}
naming pattern (region + account id + environment).
Tests: +35 (test_environment_schema.py, test_interpolation.py,
test_sample_contracts_interpolate.py). 406 passed; run_ci.sh green;
run_platform.sh --check-only green. Existing fixture-based tests
preserved (instance.json static fixtures unaffected).
99 lines
2.6 KiB
Python
99 lines
2.6 KiB
Python
"""REQ-104: environment JSON schema + qa/prod/dr bindings + load()."""
|
|
import json
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import jsonschema
|
|
import pytest
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
sys.path.insert(0, str(ROOT))
|
|
|
|
from core.environment_check import load, check
|
|
|
|
ENV_DIR = ROOT / "core" / "environments"
|
|
SCHEMA = ROOT / "schemas" / "environment.schema.json"
|
|
|
|
ENV_FILES = ["dev.json", "qa.json", "prod.json", "dr.json"]
|
|
|
|
|
|
def _schema():
|
|
return json.loads(SCHEMA.read_text())
|
|
|
|
|
|
@pytest.mark.parametrize("env_file", ENV_FILES)
|
|
def test_env_file_validates_against_schema(env_file):
|
|
env = json.loads((ENV_DIR / env_file).read_text())
|
|
jsonschema.validate(env, _schema())
|
|
|
|
|
|
def test_dev_env_has_expected_fields():
|
|
env = load("dev")
|
|
assert env["name"] == "dev"
|
|
assert env["account_id"] == "000000000000"
|
|
assert env["region"] == "us-east-1"
|
|
assert env["autonomy"] == "full"
|
|
assert env["confidence_threshold"] == 0.50
|
|
assert "state_backend" in env
|
|
assert "bucket" in env["state_backend"]
|
|
assert "network" in env
|
|
|
|
|
|
def test_qa_env_attested_with_075_threshold():
|
|
env = load("qa")
|
|
assert env["autonomy"] == "attested"
|
|
assert env["confidence_threshold"] == 0.75
|
|
|
|
|
|
def test_prod_env_attested_with_090_threshold():
|
|
env = load("prod")
|
|
assert env["autonomy"] == "attested"
|
|
assert env["confidence_threshold"] == 0.90
|
|
|
|
|
|
def test_dr_env_attested_with_095_threshold():
|
|
env = load("dr")
|
|
assert env["autonomy"] == "attested"
|
|
assert env["confidence_threshold"] == 0.95
|
|
|
|
|
|
def test_load_unknown_env_raises():
|
|
with pytest.raises(FileNotFoundError):
|
|
load("nonexistent")
|
|
|
|
|
|
def test_load_returns_dict():
|
|
env = load("dev")
|
|
assert isinstance(env, dict)
|
|
|
|
|
|
def test_placeholder_account_warning_for_non_dev(capsys):
|
|
"""A stderr warning is emitted when account_id is the placeholder and env != dev."""
|
|
load("qa")
|
|
captured = capsys.readouterr()
|
|
assert "placeholder account_id" in captured.err
|
|
assert "qa" in captured.err
|
|
|
|
|
|
def test_no_warning_for_dev_placeholder(capsys):
|
|
load("dev")
|
|
captured = capsys.readouterr()
|
|
assert "placeholder account_id" not in captured.err
|
|
|
|
|
|
def test_check_still_works_for_dev():
|
|
ok, msg = check(env_name="dev")
|
|
assert ok is True
|
|
|
|
|
|
def test_check_fails_for_unknown_env():
|
|
ok, msg = check(env_name="nonexistent")
|
|
assert ok is False
|
|
assert "nonexistent" in msg
|
|
|
|
|
|
def test_account_id_is_12_digits():
|
|
for env_file in ENV_FILES:
|
|
env = json.loads((ENV_DIR / env_file).read_text())
|
|
assert len(env["account_id"]) == 12
|
|
assert env["account_id"].isdigit() |