Jon Chery
1fd37a2843
Phase 23 (v1.7) — tagging standards and security adapters.
* schemas/tagging-standard.json (D-054): canonical required-tags schema
(acdl:owner, acdl:contract, acdl:environment, acdl:cost-center).
* adapters/terraform/policy/custom_rules/acdl_tagging.py: Checkov custom
rule (ACDL_TAG_NAMING) loaded via --external-checks-dir; closes D-043
(synthetic SKIPPED record replaced by real PASS/FAIL records).
* checkov_adapter.py: removed _emit_tag_naming_skipped(), added
ACDL_TAG_NAMING to RULE_MAP, updated docstring.
* scripts/run_platform.sh: both Checkov invocations pass
--external-checks-dir adapters/terraform/policy/custom_rules/.
* adapters/wiz/ (D-052): Wiz adapter translating issue records to
PolicyCheckResult (engine: "wiz"); graceful degradation emits
WIZ_NOT_CONFIGURED SKIPPED when unconfigured; is_configured() gate.
* adapters/kyverno/ (D-053): Kyverno adapter translating PolicyReport
results to PolicyCheckResult (engine: "kyverno"); ready but inactive
for Terraform-only stacks; 3 sample ClusterPolicies in policies/.
* schemas/policy_check_result.schema.json: engine enum += "wiz".
* tests: fixtures + test_wiz_adapter.py (8 tests) + test_kyverno_adapter.py
(13 tests); updated test_checkov_adapter.py to not expect the removed
synthetic ACDL_TAG_NAMING SKIPPED record.
* scripts/run_ci.sh: lint stage compiles the new adapter modules.
202 tests pass; CI pipeline OK (lint + test + check-only).
Deviations:
- Wiz adapt() had an AttributeError on bare-list top-level input
(data.get() on a list); fixed to dispatch on isinstance(data, list)
before calling .get(). No spec change — bare-list handling is implied
by the original docstring's "data if isinstance(data, list)" branch.
- Kyverno _to_pcr({}) defaults result to "skipped" (entry.get("result",
"skip") -> "skip"), not "error"; test expectation corrected. Added an
explicit unknown-result-string test to cover the "error" fallback.
---ci---
project: acdl
phase: 23
milestone: v1.7
status: execute
---/ci---
46 lines
1.7 KiB
JSON
46 lines
1.7 KiB
JSON
{
|
|
"$schema": "https://json-schema.org/draft/2020-12/schema",
|
|
"$id": "https://acdl.dev/schemas/tagging-standard.json",
|
|
"title": "ACDL Tagging Standard",
|
|
"description": "Required tags for all taggable AWS resources created by the platform. Enforced by a Checkov custom YAML rule (adapters/terraform/policy/custom_rules/acdl_tagging.yaml). The checkov adapter maps ACDL_TAG_NAMING as a real rule (D-054, D-043 closure).",
|
|
"type": "object",
|
|
"properties": {
|
|
"required_tags": {
|
|
"type": "object",
|
|
"description": "The set of tags that must be present on every taggable AWS resource.",
|
|
"properties": {
|
|
"acdl:owner": {
|
|
"type": "string",
|
|
"description": "The consumer repository name (e.g. 'consumer-repo'). Injected from the ABAC session."
|
|
},
|
|
"acdl:contract": {
|
|
"type": "string",
|
|
"description": "The contract ID (UUID)."
|
|
},
|
|
"acdl:environment": {
|
|
"type": "string",
|
|
"enum": ["dev", "qa", "prod", "dr"],
|
|
"description": "The environment name."
|
|
},
|
|
"acdl:cost-center": {
|
|
"type": "string",
|
|
"description": "The cost center (consumer-provided or platform-default 'acdl-default')."
|
|
}
|
|
},
|
|
"required": ["acdl:owner", "acdl:contract", "acdl:environment", "acdl:cost-center"],
|
|
"additionalProperties": false
|
|
},
|
|
"default_values": {
|
|
"type": "object",
|
|
"description": "Default values used when the consumer does not supply the tag.",
|
|
"properties": {
|
|
"acdl:cost-center": {
|
|
"type": "string",
|
|
"default": "acdl-default"
|
|
}
|
|
}
|
|
}
|
|
},
|
|
"required": ["required_tags"],
|
|
"additionalProperties": false
|
|
} |