Files
acdl/adapters/terraform/adapter.py
T
Jon Chery ec3b2dd9eb
acdl-ci / Lint (pull_request) Successful in 9s
acdl-ci / Platform check-only (offline) (pull_request) Successful in 31s
acdl-modules-lifecycle / CI VPC apply (pull_request) Successful in 42s
acdl-ci / Test (pull_request) Successful in 4m47s
acdl-modules-lifecycle / L1 lifecycle (alb) (pull_request) Failing after 1m20s
acdl-modules-lifecycle / L1 lifecycle (cloudfront) (pull_request) Failing after 1m18s
acdl-modules-lifecycle / L1 lifecycle (ecr) (pull_request) Successful in 2m53s
acdl-modules-lifecycle / L1 lifecycle (ecs-cluster) (pull_request) Successful in 3m14s
acdl-modules-lifecycle / L1 lifecycle (iam-role) (pull_request) Successful in 2m49s
acdl-modules-lifecycle / L1 lifecycle (ecs-service) (pull_request) Failing after 5m24s
acdl-modules-lifecycle / L1 lifecycle (kms-key) (pull_request) Failing after 1m39s
acdl-modules-lifecycle / L1 lifecycle (rds) (pull_request) Failing after 1m20s
acdl-modules-lifecycle / L1 lifecycle (s3) (pull_request) Successful in 3m18s
acdl-modules-lifecycle / L1 lifecycle (vpc) (pull_request) Successful in 2m55s
acdl-modules-lifecycle / L1 lifecycle (uptime) (pull_request) Failing after 5m25s
acdl-modules-lifecycle / L2 lifecycle (microservice) (pull_request) Failing after 1m1s
acdl-modules-lifecycle / L2 lifecycle (static-assets) (pull_request) Failing after 1m29s
acdl-modules-lifecycle / L1 lifecycle (waf) (pull_request) Successful in 3m21s
acdl-modules-lifecycle / CI VPC destroy (pull_request) Failing after 20m46s
fix(review): P1 fixes — adapter dedup validation + inventory summary
P1-1: Adapter dedup now raises ValueError when a module isn't in the
registry (previously silently dropped unknown-module resources — the
exact defect class the v1.10 sweep was built to catch).

P1-4: CAPABILITY_INVENTORY summary table updated from 16 to 22 (6 new
CAP-017..022 added in v1.11). Headline and body now agree.

Adapter: 196 lines (still under 200).
Regression: 485 passed, 5 deselected.

---ci---
project: acdl
phase: 0
milestone: v1.11
status: review
---/ci---
2026-07-29 12:32:31 +00:00

197 lines
7.9 KiB
Python

"""ACDL Terraform adapter — stateless assembler (v1.11 RESTART, P56a).
The adapter is a STATELESS ASSEMBLER. It owns no module content — no resource
shape, no nested HCL blocks, no defaults, no type-specific logic. It reads
the registry to find each L1 module's terraform/ dir, then emits a root
main.tf that instantiates each resource as a `module "<rid>" { source = ... }`
block with resolved inputs and wired refs.
Engine-specific knowledge (resource type, arg names, nested blocks, defaults)
lives in the per-module terraform/ subdir (versions/variables/locals/main/
outputs.tf), NOT in this file. interface.json stays engine-agnostic.
CLI: adapter.py <instance.json> <out_dir>
"""
import json
import os
import sys
def _load_registry(repo_root):
"""Load registry.json → {module_name: terraform_dir}."""
with open(os.path.join(repo_root, "modules", "registry.json")) as fh:
registry = json.load(fh)
terraform_dirs = {}
for name, versions in registry.items():
latest = versions.get("1.0.0", {})
if "terraform_dir" in latest:
terraform_dirs[name] = latest["terraform_dir"]
return terraform_dirs
def _module_name(resource):
"""Extract the module name from a resource's `module` field (e.g. s3@1.0.0 → s3)."""
return resource.get("module", "").split("@")[0]
def _ref_expr(value, data_source_names=None):
"""Translate a `ref:<rid>.<output>` string to a Terraform interpolation.
For module resources: `module.<rid>.<output>`.
For data sources (platform-owned): `data.terraform_remote_state.platform.outputs.<output>`.
Returns None if the value is not a ref."""
if not isinstance(value, str) or not value.startswith("ref:"):
return None
body = value[len("ref:"):]
rid, out_name = body.split(".", 1)
if data_source_names and rid in data_source_names:
return f"data.terraform_remote_state.platform.outputs.{out_name}"
return f"module.{rid}.{out_name}"
def _tf_value(value, data_source_names=None):
"""Render a Python value as a Terraform expression fragment."""
if isinstance(value, bool):
return "true" if value else "false"
if isinstance(value, (int, float)) and not isinstance(value, bool):
return str(value)
if isinstance(value, str):
ref = _ref_expr(value, data_source_names)
if ref is not None:
return ref
stripped = value.lstrip()
if stripped and stripped[0] in "{[":
try:
parsed = json.loads(value)
if isinstance(parsed, (dict, list)):
return f"jsonencode({json.dumps(parsed, sort_keys=True)})"
except json.JSONDecodeError:
pass
return f'"{value}"'
if isinstance(value, (dict, list)):
return f"jsonencode({json.dumps(value, sort_keys=True)})"
raise ValueError(f"unsupported input value type {type(value).__name__}")
def _emit_module_block(resource, terraform_dirs, repo_root, data_source_names=None):
"""Emit a `module "<rid>" { source = ... ... }` block for one resource."""
rid = resource["id"]
name = _module_name(resource)
tf_dir = terraform_dirs.get(name)
if not tf_dir:
raise ValueError(f"no terraform_dir in registry for module '{name}' (resource {rid})")
source_path = os.path.join(repo_root, tf_dir)
lines = [f'module "{rid}" {{', f' source = "{source_path}"']
for in_name, value in resource.get("inputs", {}).items():
if in_name == "region":
continue
lines.append(f" {in_name} = {_tf_value(value, data_source_names)}")
lines.append("}")
return "\n".join(lines)
def _emit_root_output(out_name, rid, module_output_name):
"""Emit a root output wiring a module output to a stack output."""
return f'output "{out_name}" {{\n value = module.{rid}.{module_output_name}\n}}'
def adapt(stack_instance, out_dir):
"""Emit main.tf + terraform.tf + providers.tf to out_dir for the stack instance."""
os.makedirs(out_dir, exist_ok=True)
repo_root = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
terraform_dirs = _load_registry(repo_root)
stack = stack_instance.get("stack", {})
resources = stack_instance.get("resources", [])
stack_outputs = stack_instance.get("outputs", {})
# --- providers.tf: aws provider, region from the first resource's inputs.region ---
region = "us-east-1"
for r in resources:
if "region" in r.get("inputs", {}):
region = r["inputs"]["region"]
break
providers_tf = f'provider "aws" {{\n region = "{region}"\n}}\n'
# --- terraform.tf: required_version + required_providers + S3 backend ---
stack_name = stack.get("name", "spike")
environment = stack.get("environment", "dev")
terraform_tf = (
'terraform {\n'
' required_version = ">= 1.9, < 1.10"\n'
' required_providers {\n'
' aws = {\n'
' source = "hashicorp/aws"\n'
' version = "~> 5.0"\n'
' }\n'
' }\n'
' backend "s3" {\n'
' bucket = "acdl-tfstate-581513795199-us-east-1"\n'
f' key = "spike/{stack_name}/{environment}/terraform.tfstate"\n'
' region = "us-east-1"\n'
' }\n'
'}\n'
)
# --- data sources: emit terraform_remote_state for platform-owned resources ---
data_source_names = stack_instance.get("data_sources", [])
data_blocks = []
if data_source_names:
remote_state_key = os.environ.get("ACDL_REMOTE_STATE_KEY", "platform/terraform.tfstate")
data_blocks.append(
'data "terraform_remote_state" "platform" {\n'
' backend = "s3"\n'
' config = {\n'
' bucket = "acdl-tfstate-581513795199-us-east-1"\n'
f' key = "{remote_state_key}"\n'
' region = "us-east-1"\n'
' }\n'
'}\n'
)
# --- main.tf: data blocks + module instantiations + root outputs ---
parts = list(data_blocks)
# Deduplicate: multi-resource L1s (e.g. cloudfront) expand to multiple
# stack resources sharing one terraform dir. Emit ONE module block per
# dir, merging inputs. Use the first resource's id as the module name.
seen = {} # terraform_dir → resource
for r in resources:
tf_dir = terraform_dirs.get(_module_name(r))
if not tf_dir:
raise ValueError(f"no terraform_dir in registry for module '{_module_name(r)}' (resource {r['id']})")
if tf_dir in seen:
for k, v in r.get("inputs", {}).items():
if k != "region" and k not in seen[tf_dir].get("inputs", {}):
seen[tf_dir].setdefault("inputs", {})[k] = v
for k, v in r.get("outputs", {}).items():
seen[tf_dir].setdefault("outputs", {})[k] = v
else:
seen[tf_dir] = r
merged = list(seen.values()) if seen else resources
parts.extend(_emit_module_block(r, terraform_dirs, repo_root, set(data_source_names)) for r in merged)
for out_name, out_spec in stack_outputs.items():
if isinstance(out_spec, dict) and "from" in out_spec:
rid = out_spec["from"]
mod_out = out_spec.get("output", out_name)
parts.append(_emit_root_output(out_name, rid, mod_out))
main_tf = "\n\n".join(parts) + "\n"
with open(os.path.join(out_dir, "main.tf"), "w") as fh:
fh.write(main_tf)
with open(os.path.join(out_dir, "terraform.tf"), "w") as fh:
fh.write(terraform_tf)
with open(os.path.join(out_dir, "providers.tf"), "w") as fh:
fh.write(providers_tf)
return out_dir
if __name__ == "__main__":
if len(sys.argv) != 3:
print("usage: adapter.py <instance.json> <out_dir>", file=sys.stderr)
sys.exit(2)
with open(sys.argv[1], "r") as fh:
stack = json.load(fh)
adapt(stack, sys.argv[2])
print(f"adapter: emitted terraform to {sys.argv[2]}", file=sys.stderr)