acdl/.ciagent/REVIEW.md

ACDL v1.10 — Review

Review date: 2026-07-27. Reviewer: ci-code-reviewer. Milestone: v1.10. Scope: 5 commits (772ac72..950db56), 22 files, +2281/-256 lines.

Commits reviewed

Commit	Phase	Type	Summary
772ac72	52	docs	v1.10 milestone plan (PLAN stage)
9897df0	52	fix	regression-class VERIFY (D-091)
217653d	53	feat	local emulating adapters (D-092)
44d1d19	54	fix	capability re-verification sweep — 7 adapter defects fixed
950db56	55	docs	rewrite PROJECT/ROADMAP/decks to verified reality

P0 issues

0 P0. No correctness, security, or data-loss issues found.

P1 issues

0 P1. No maintainability or design issues requiring post-hoc review.

Correctness

• The regression-class VERIFY (D-091) correctly fails closed on any non-Verified capability. The decay-surfacing test proves the gate catches Broken. The 16-capability registry covers both local and live-AWS tiers.
• The 7 adapter defect fixes are each traceable to a specific terraform validate/plan error they resolved. The fixes are defensive (skip-in-generic-loop + emit-in-type-specific-block) and do not regress the static-assets stack (verified: terraform plan passes for both contracts).
• The local emulators (D-092) correctly emulate ECS, outbox, S3 state, and Lambda without cloud credentials. The headline E2E runs end-to-end against the local tier. PASS.

Security

• No AWS credentials logged. The regression module reads .env.secrets and passes creds via env vars to subprocesses only.
• The local ECS emulator binds to 127.0.0.1 (loopback) only.
• The local Lambda stub patches urllib.urlopen to a fake response so report_error does not hit the network.
• No new network calls or cloud mutations introduced (plan-only). PASS.

Performance

• The regression run completes in ~60s (16 capabilities). The slow checks (CAP-009 pytest, CAP-010 run_ci, CAP-013/014 terraform plan) are the bulk; acceptable for a milestone gate. PASS.

Maintainability

• core/regression_verify.py (532 lines) is well-structured: a dataclass report, a registry of capability checks, a run_regression entrypoint, and a write_report helper. Adding a new capability is a single function + registry entry.
• core/local_emulators.py (489 lines) is organized as four independent adapter classes + a run_local_e2e convenience function.
• The adapter defect fixes are localized (skip lists + type-specific default blocks); no large refactors. PASS.

Adversarial

• Could the regression gate pass while cloud resources are actually broken? No — the live-AWS checks (CAP-013..CAP-016) probe the real AWS account. The 6 IAM-gated resources are explicitly escalated, not silently passed.
• Could the local emulators mask a real cloud failure? No — the local tier is additive; the live-AWS tier (CAP-013/014) runs the real terraform plan. The emulators prove runtime behavior; the live plan proves deployment correctness.
• Could the adapter fixes introduce a regression in a stack not tested? Possible — the registry covers microservice + static-assets. The uptime-kuma and RDS stacks are not in the registry. P2 (post-hoc): add uptime-kuma + RDS contracts to the regression registry in a future patch. PASS (1 P2 flagged for post-hoc).

Verdict

READY TO SHIP — 0 P0, 0 P1, 1 P2 (post-hoc: expand regression registry to uptime-kuma + RDS stacks). The v1.10 milestone achieves its goal: the pipeline regression gap is fixed, the platform is fully locally testable, every advertised capability is re-verified, and the docs/decks match verified reality.