Jon Chery
ca99241843
acdl-ci / Lint (push) Successful in 7s
acdl-ci / Test (push) Successful in 27s
acdl-ci / Platform check-only (offline) (push) Successful in 9s
verify(P28-38): code review — 1 P0 auto-fixed, 3 P1 fixes, 2 P1 flagged
---ci---
project: acdl
phase: 28-38
milestone: v1.8
status: verify
lessons:
- P0 fix: pipelines/deploy.yaml stale terraform/spike paths updated to run_platform.sh
- P1 fix: removed import sys from inside _emit_resource function body
- P1 fix: removed unused cpu/memory vars in uptime emission
- P1 fix: decommission consumerRepo now uses GITHUB_REPOSITORY env
---/ci---
P0: deploy.yaml 3 stage commands referenced removed terraform/spike dir.
P1 fixes: import sys, unused vars, consumerRepo env.
P1 flagged: uptime hardcoded subnet/sg, uses ref not bumped to v1.8.
P2 flagged: deploy-uptime flag standalone, pre-v1.8 READMEs missing NFRs.
Tests: 350 passed.