Compare commits
51 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 0789c27ca2 | |||
| 184f33c60a | |||
| a6510e7afc | |||
| c0cb1887ed | |||
| 139cb5077a | |||
| adc55a17ab | |||
| 0d8913a299 | |||
| 4697692ce7 | |||
| 23b8ff81d3 | |||
| d0a8c363b2 | |||
| 04053df16e | |||
| bcbeb7badb | |||
| 1f4f7f0f81 | |||
| df2b83c86b | |||
| f68349d94d | |||
| 1863a85144 | |||
| 7dab9d5756 | |||
| 14809327fb | |||
| 0662ed26a3 | |||
| cd3418a75e | |||
| dee6d88d87 | |||
| fe0ee6aa45 | |||
| 701cc572ce | |||
| 0736924de2 | |||
| 05bf8bf221 | |||
| 7a7fbfed82 | |||
| d06535032c | |||
| 8550ede810 | |||
| 71562d9db2 | |||
| 91cb931bab | |||
| a8ef1e8864 | |||
| 291921a04e | |||
| c9bfc98713 | |||
| ab069db3a4 | |||
| 3338ec1622 | |||
| eb4fade710 | |||
| 5dd7222571 | |||
| 5763e85bb7 | |||
| 37f462783f | |||
| cba7c1c189 | |||
| fd3f9e17b9 | |||
| 03adaa80a6 | |||
| 3a09ca8ec1 | |||
| d7971023b6 | |||
| 6a8267e13f | |||
| 2ed2b3ae0f | |||
| 83883076ff | |||
| 0388751c6e | |||
| 5d1a5f83da | |||
| e7af683af6 | |||
| 939a39743d |
+22
-20
@@ -1,28 +1,30 @@
|
|||||||
{
|
{
|
||||||
"phase": 0,
|
"phase": 0,
|
||||||
"stage": "complete",
|
"stage": "grill",
|
||||||
"milestone": "v1.28",
|
"milestone": "v1.29",
|
||||||
"phase_role": "pre_execution",
|
"phase_role": "pre_execution",
|
||||||
"attempts": 0,
|
"attempts": 0,
|
||||||
"updated_at": "2026-08-19T20:55:00Z",
|
"updated_at": "2026-08-20T00:40:00Z",
|
||||||
"project": "acdl",
|
"project": "acdl",
|
||||||
"projects": ["acdl", "nova-blockchain-exchange"],
|
"projects": ["acdl", "nova-blockchain-exchange"],
|
||||||
"active_milestone": "v1.28",
|
"active_milestone": "v1.29",
|
||||||
"milestone_branch": "milestone/v1.28-cli-identity",
|
"milestone_branch": "milestone/v1.29-reposplit-identity",
|
||||||
"phase_branch": "phase/00-pre-execution",
|
"phase_branch": "phase/00-pre-execution",
|
||||||
"tag_line": "v1.27.x",
|
"tag_line": "v1.28.x",
|
||||||
"previous_milestone": {"milestone": "v1.27", "tag": "v1.26.3", "status": "complete"},
|
"phase_name": "pre-execution",
|
||||||
"decisions": ["D-226", "D-227", "D-228", "D-229", "D-230", "D-231"],
|
"milestone_type": "feature",
|
||||||
"personas": ["backend-engineer", "security-engineer", "cli-engineer", "lead-developer"],
|
"reqs_covered": [],
|
||||||
"phases_planned": 6,
|
"reqs_partial": [],
|
||||||
"execution_phases": [
|
"decisions": ["D-232", "D-233", "D-234", "D-235", "D-236", "D-237", "D-238", "D-239", "D-240"],
|
||||||
{"phase": 1, "name": "cli-substrate", "reqs": ["REQ-323..328"], "caps": ["CAP-033", "CAP-034", "CAP-035"], "tag": "v1.27.1"},
|
"carry_forward": ["Q7 (kj image verification dependency — M1.5 gate, verified in nova-platform-ops CI)"],
|
||||||
{"phase": 2, "name": "lambda-packaging", "reqs": ["REQ-329..332"], "tag": "v1.27.2"},
|
"personas": ["lead-developer", "backend-engineer", "security-engineer", "cli-engineer", "data-engineer"],
|
||||||
{"phase": 3, "name": "idp-auth", "reqs": ["REQ-333..335"], "caps": ["CAP-036"], "tag": "v1.27.3"},
|
"grill": {
|
||||||
{"phase": 4, "name": "token-vend-pat", "reqs": ["REQ-336..344", "REQ-340..341"], "caps": ["CAP-037", "CAP-038"], "tag": "v1.27.4"},
|
"verdict": "PROCEED-WITH-CONDITIONS",
|
||||||
{"phase": 5, "name": "docs-integration", "reqs": ["REQ-345..351"], "tag": "v1.27.5"},
|
"confidence": 0.72,
|
||||||
{"phase": 6, "name": "final-review-ship", "reqs": ["REQ-352..353"], "tag": "v1.27.6"}
|
"critical_fixes": 4,
|
||||||
],
|
"tracked_conditions": 6,
|
||||||
"grill": {"verdict": "PROCEED-WITH-CONDITIONS", "confidence": 0.76, "critical_conditions": 3, "tracked_conditions": 16, "escalations": 0},
|
"binding_decisions": ["G-1", "G-2.1", "G-2.2", "G-3", "G-4", "G-5"],
|
||||||
"notes": "v1.28 P0 SHIP. Pre-execution complete (SPECIFY->CLARIFY->RESEARCH->PLAN->GRILL->MVP/UX). Tag v1.27.0. Merged phase/00 -> milestone/v1.28-cli-identity. 6 execution phases planned (P1..P6). Next: P1 cli-substrate."
|
"critical_fix_ids": ["CF-1", "CF-2", "CF-3", "CF-4"]
|
||||||
|
},
|
||||||
|
"notes": "v1.29 GRILL complete. PROCEED-WITH-CONDITIONS 0.72. 4 critical fixes applied to PLAN.md: CF-1 (M1.5 hard P6 ship gate, spike 8->12 items), CF-2 (covered-reference REQs gated by operator-attested Result column), CF-3 (P1 pushes v1.29.0 intermediate tag, P5 smoke no hedge), CF-4 (kj source-fetch confirmed before P1 Wave 1, recorded in kj-version.txt). 6 tracked conditions (TC-1..TC-6). Covered-reference pattern accepted as verification surface ONLY with CF-1+CF-2 (G-1)."
|
||||||
}
|
}
|
||||||
+225
-1
@@ -273,4 +273,228 @@ new ("introducing Nova-idp"). The mis-framing was in calling them
|
|||||||
All material ambiguities resolved at full autonomy (6 open questions +
|
All material ambiguities resolved at full autonomy (6 open questions +
|
||||||
5 grounding gaps → D-226..D-231, confidence ≥ 0.80). No human escalation
|
5 grounding gaps → D-226..D-231, confidence ≥ 0.80). No human escalation
|
||||||
triggered (all confidences ≥ 0.60 threshold). REQUIREMENTS.md updated
|
triggered (all confidences ≥ 0.60 threshold). REQUIREMENTS.md updated
|
||||||
with the decision ledger + invariants. Next: RESEARCH.
|
with the decision ledger + invariants. Next: RESEARCH.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
# CLARIFY — v1.29 Reposplit + Identity Layer Bring-Live
|
||||||
|
|
||||||
|
> **Autonomy:** full. Auto-resolution with assumption logging per
|
||||||
|
> `config.autonomy.level: "full"`. No human escalation unless confidence
|
||||||
|
> < 0.60. The v1.29 spec is v1.1 (highly detailed — §7 resolves Q1-6, Q7
|
||||||
|
> carried forward as a verification-gate dependency). This file records
|
||||||
|
> the v1.29 ambiguities and the scope-split grounding.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Method
|
||||||
|
|
||||||
|
The v1.29 spec ("Universal Feature Specification — Reposplit + Identity
|
||||||
|
Layer Bring-Live", v1.1) is the most detailed spec the project has
|
||||||
|
received: it includes BDD acceptance criteria, an 8-item M1.5 spike
|
||||||
|
checklist, 7 decisions pre-drafted (D-232..238), 14 NFRs, and an
|
||||||
|
explicit §7 resolving Q1-6. Clarify work focuses on (a) the scope split
|
||||||
|
between `acdl` (CIAgent) and `nova-platform-ops` (out-of-band), (b) the
|
||||||
|
`kj` identity (Go binary vs. the v1.28 kyverno-json re-mapping), and (c)
|
||||||
|
the carried-forward Q7. Each ambiguity gets a decision ID (D-232+,
|
||||||
|
continuing from v1.28's D-226..D-231), a resolution, a confidence score,
|
||||||
|
and a rationale.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Prior-conversation resolutions (already locked, restated for the record)
|
||||||
|
|
||||||
|
These were resolved by the user-approved execution plan in the
|
||||||
|
conversation that spawned v1.29.
|
||||||
|
|
||||||
|
### Q-P1 — The spec creates a separate repo `nova-platform-ops`. CIAgent runs inside `acdl`. Where does the Terraform code land?
|
||||||
|
|
||||||
|
**Resolution:** Terraform modules
|
||||||
|
(`networking`/`kms`/`identity`/`contract-ingest`/`bootstrap`/`edge`) are
|
||||||
|
authored **out-of-band** in `nova-platform-ops` (operator-owned). CIAgent
|
||||||
|
in `acdl` delivers only the acdl-side work (publish.yml, Gitea scrub,
|
||||||
|
CFN archive, operator guide, consumer bump) and tracks the ops-side
|
||||||
|
REQs as **covered-reference** (verification surface = the M1/M1.5/M2
|
||||||
|
cutover gates documented in the operator guide).
|
||||||
|
**Confidence:** 1.0 (user-confirmed — "Author out-of-band in
|
||||||
|
nova-platform-ops"). **Decision:** scope split documented in
|
||||||
|
PROJECT.md §v1.29 + REQUIREMENTS.md §v1.29.
|
||||||
|
|
||||||
|
### Q-P2 — The run scope. How far does this `/ci-run` go?
|
||||||
|
|
||||||
|
**Resolution:** Full milestone through the final phase (P0 → P1..P5 →
|
||||||
|
P6 final review + audit + milestone ship, tag `v1.28.6`).
|
||||||
|
**Confidence:** 1.0 (user-confirmed — "Full milestone through final
|
||||||
|
phase"). **Decision:** n/a (execution scope, not a D-ID).
|
||||||
|
|
||||||
|
### Q-P3 — Edge 8 / REQ-354 footnote: pilot consumer deploy bump. Handle how?
|
||||||
|
|
||||||
|
**Resolution:** Include a cross-project phase (P5) in this CIAgent run
|
||||||
|
(multi-project mode is active). Bump `nova-blockchain-exchange`
|
||||||
|
deploy.yml `@v1.25` → `@v1.29` + smoke test.
|
||||||
|
**Confidence:** 1.0 (user-confirmed — "Cross-project phase in this
|
||||||
|
run"). **Decision:** n/a (execution scope).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Spec-grounded resolutions (from §7 + §5)
|
||||||
|
|
||||||
|
### Q1 — State bucket bootstrap on day-0 (resolved per spec §7.1)
|
||||||
|
|
||||||
|
**Resolution:** Manual one-time at the operator's secure scratch; Terraform
|
||||||
|
then adopts it via `terraform import`. Avoids bootstrapping the
|
||||||
|
bootstrapper. **Confidence:** 1.0 (spec §7.1 explicit). **Decision:**
|
||||||
|
D-235 (tag-pin handoff) — the state bucket is one of the imported
|
||||||
|
resources.
|
||||||
|
|
||||||
|
### Q2 — `pyproject.toml` version bump (resolved per spec §7.2)
|
||||||
|
|
||||||
|
**Resolution:** Bump to `1.29.0` in M1 (P2 — Gitea scrub phase) of v1.29
|
||||||
|
alongside the Gitea scrub. **Confidence:** 1.0 (spec §7.2 explicit).
|
||||||
|
**Decision:** n/a (implementation detail, tracked in PLAN.md P2).
|
||||||
|
|
||||||
|
### Q3 — WAF cost (resolved per spec §7.3)
|
||||||
|
|
||||||
|
**Resolution:** Acceptable for the JWKS public surface; documented in
|
||||||
|
operator-guide cost section (~$5–10/month per WebACL + per-request).
|
||||||
|
**Confidence:** 1.0 (spec §7.3 explicit). **Decision:** documented in
|
||||||
|
REQ-OPS-GUIDE AC.
|
||||||
|
|
||||||
|
### Q4 — Coverage 73.8% — does this milestone drive it down further? (resolved per spec §7.4)
|
||||||
|
|
||||||
|
**Resolution:** Accept any further debt as carry-forward to the separate
|
||||||
|
NFR milestone. New modules have ≥80% coverage; older code paths are
|
||||||
|
unchanged. YELLOW carried without scope expansion. **Confidence:** 1.0
|
||||||
|
(spec §7.4 explicit). **Decision:** n/a (NFR carry-forward, not a v1.29
|
||||||
|
D-ID).
|
||||||
|
|
||||||
|
### Q5 — CFN code deletion timing (resolved per spec §7.5)
|
||||||
|
|
||||||
|
**Resolution:** Archive to `docs/archive/nova-idp-cfn-v1.28.md`; deletion
|
||||||
|
is a follow-up after the next pilot run verifies Terraform parity.
|
||||||
|
**Confidence:** 1.0 (spec §7.5 explicit). **Decision:** REQ-369 AC (3).
|
||||||
|
|
||||||
|
### Q6 — `acdl-act-runner-role` reuse (resolved per spec §7.6)
|
||||||
|
|
||||||
|
**Resolution:** Reuse the existing role for v1.29 to minimize IAM surface
|
||||||
|
changes; scope narrow per REQ-360. **Confidence:** 1.0 (spec §7.6
|
||||||
|
explicit). **Decision:** covered by REQ-360 (IAM-NARROW).
|
||||||
|
|
||||||
|
### Q7 — `kj` image verification dependency (CARRY-FORWARD per spec §7.7)
|
||||||
|
|
||||||
|
**Resolution (carry-forward):** M1 cutover is conditional on the M1.5
|
||||||
|
verification gate. **Recommendation:** Block M1 cutover until M1.5
|
||||||
|
passes. If M1.5 fails three consecutive rebuilds, defer to M2a and ship
|
||||||
|
Nova-idp in read-only partial mode (no token issuance) until `kj` is
|
||||||
|
verified. **Impact if wrong:** A live token-vend that signs with a
|
||||||
|
broken ABAC path would let through a denied claim — fails closed only if
|
||||||
|
`ImageUri` is verified pre-apply. **Confidence:** 0.92 (spec §7.7
|
||||||
|
explicit + D-236 cutover shape). **Decision:** D-236 (cutover shape +
|
||||||
|
rollback procedure). This is the **only** outstanding carry-forward;
|
||||||
|
CIAgent in acdl builds + publishes the image + the gate tests (P1), but
|
||||||
|
the live 3-rebuild verification happens in `nova-platform-ops` CI
|
||||||
|
(out-of-band). CIAgent does not block on it.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Grounding-gap resolutions (surfaced in pre-flight)
|
||||||
|
|
||||||
|
### G1 — The spec's `kj` vs. v1.28's `kj` re-mapping
|
||||||
|
|
||||||
|
**Ambiguity:** v1.28 (D-227) re-mapped the spec's `kj` engine →
|
||||||
|
kyverno-json (INV-4 swappable), explicitly stating "no new `kj` engine
|
||||||
|
is built." v1.29 reintroduces `kj` as a compiled Go binary
|
||||||
|
(`platform/abac/kj-version.txt`, pinned v0.0.3) embedded in an ECR
|
||||||
|
container image. Is this a contradiction?
|
||||||
|
|
||||||
|
**Resolution:** No contradiction. v1.28's `kj` was a *policy engine*
|
||||||
|
reference; v1.29's `kj` is a *compiled Go binary* (a distinct artifact).
|
||||||
|
The kyverno-json engine remains the policy engine (INV-4). The v1.29
|
||||||
|
`kj` binary is invoked via `subprocess.run(['/opt/kj/kj', 'apply', ...])`
|
||||||
|
by the Lambda handler — it is a **substrate** binary, not a policy
|
||||||
|
engine. The two coexist: kyverno-json evaluates ABAC policy; `kj` is the
|
||||||
|
container image's static binary that the Lambda runtime executes. No
|
||||||
|
collision.
|
||||||
|
**Confidence:** 0.95 (spec §3.3 Edge 5 item 4 explicit + v1.28 D-227
|
||||||
|
scope). **Decision:** documented in PROJECT.md §v1.29 ID allocations +
|
||||||
|
KJ-STATIC NFR.
|
||||||
|
|
||||||
|
### G2 — `REQ-363b` sub-requirement numbering
|
||||||
|
|
||||||
|
**Ambiguity:** The spec uses `REQ-363b` for the Fargate defensive
|
||||||
|
fallback. The repo's REQ namespace is `REQ-NNN` (numeric). How to
|
||||||
|
record `363b`?
|
||||||
|
|
||||||
|
**Resolution:** Keep `REQ-363b` as-is (sub-requirement of REQ-363). It
|
||||||
|
is a distinct requirement (Fargate fallback, KJ-LOCKSTEP) but logically
|
||||||
|
paired with REQ-363 (production substrate). The `b` suffix is
|
||||||
|
unambiguous and matches the spec. No collision with any existing REQ.
|
||||||
|
**Confidence:** 0.98 (spec explicit + no collision). **Decision:** n/a
|
||||||
|
(naming convention).
|
||||||
|
|
||||||
|
### G3 — `REQ-370` gap
|
||||||
|
|
||||||
|
**Ambiguity:** The spec jumps from REQ-369 to REQ-371. Is REQ-370
|
||||||
|
missing or intentionally unused?
|
||||||
|
|
||||||
|
**Resolution:** Intentionally unused per the source spec. REQ-370 is a
|
||||||
|
gap in the spec's numbering (likely a deleted/renumbered item during
|
||||||
|
spec v1.0 → v1.1). v1.29 does not allocate REQ-370; it remains a
|
||||||
|
reserved gap. **Confidence:** 0.90 (spec explicit gap, no content).
|
||||||
|
**Decision:** n/a (spec fidelity).
|
||||||
|
|
||||||
|
### G4 — Covered-reference REQs and CIAgent verification
|
||||||
|
|
||||||
|
**Ambiguity:** REQ-355, 356, 357, 358, 359, 360, 361, 362, 363, 363b,
|
||||||
|
364, 365, 366, 371 are authored in `nova-platform-ops` (out-of-band).
|
||||||
|
How does CIAgent verify them? Are they `human_needed`?
|
||||||
|
|
||||||
|
**Resolution:** They are **covered-reference**, NOT `human_needed`. The
|
||||||
|
verification surface is the M1/M1.5/M2 cutover gates documented in the
|
||||||
|
operator guide (`docs/operator-guide-platform-ops.md`). The operator
|
||||||
|
guide lists each covered-reference REQ with its cutover gate entry
|
||||||
|
(M1/M1.5/M2). CIAgent verify marks them `covered-reference` and the
|
||||||
|
final-phase audit confirms the operator guide documents all gates.
|
||||||
|
**Confidence:** 0.94 (scope-split decision + spec §2.3 milestone
|
||||||
|
gates). **Decision:** documented in REQUIREMENTS.md §v1.29 + REQ-OPS-
|
||||||
|
GUIDE AC.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Assumptions (logged, not escalated — confidence ≥ 0.80)
|
||||||
|
|
||||||
|
1. **`kj` v0.0.3** is available at the pinned SHA in
|
||||||
|
`platform/abac/kj-version.txt` and compiles with `CGO_ENABLED=0
|
||||||
|
GOOS=linux GOARCH=amd64`. RESEARCH will confirm the source repository
|
||||||
|
+ build commands. If the binary is not available, P1 (publish
|
||||||
|
pipeline) cannot produce the ECR image; M1.5 gate fails by
|
||||||
|
construction → M2a (Fargate toggle, same image) also fails → escalate
|
||||||
|
(but this is a spec dependency, not a CIAgent ambiguity).
|
||||||
|
2. **ECR repository** exists or is creatable in account `581513795199`
|
||||||
|
for the `kj` image. RESEARCH will confirm. The repo name is not
|
||||||
|
specified in the spec; the operator guide will document it.
|
||||||
|
3. **GitHub Releases** is the artifact distribution channel (per
|
||||||
|
REQ-354). The `acdl/acdl` repo is already on GitHub (the Gitea scrub
|
||||||
|
in REQ-367 standardizes on GitHub). NOVA_FORGE_TOKEN (Gitea) is
|
||||||
|
retained for `nova-platform-ops` releases only.
|
||||||
|
4. **The `nova idp setup --apply` terraform-delegation** (REQ-369 AC 2)
|
||||||
|
requires `terraform` to be on the operator's PATH. The CLI detects
|
||||||
|
terraform via `which terraform`; if absent, it falls back to the CFN
|
||||||
|
path with a deprecation warning (the CFN archive remains read-only
|
||||||
|
reference, but the delegation is the preferred path).
|
||||||
|
5. **The M1.5 8-item spike** (spec §3.3 Edge 5) is the verification
|
||||||
|
gate. CIAgent in acdl authors the *tests* (test_idp_auth,
|
||||||
|
test_kms_roundtrip, ABAC E2E) in P1; the *live 3-rebuild run*
|
||||||
|
happens in `nova-platform-ops` CI. This is the Q7 carry-forward
|
||||||
|
surface.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## CLARIFY complete
|
||||||
|
|
||||||
|
All material ambiguities resolved at full autonomy (3 prior-conversation
|
||||||
|
+ 7 spec-grounded + 4 grounding-gap → D-232..D-238, confidence ≥ 0.80).
|
||||||
|
Q7 is the only carry-forward (verification-gate dependency, not a
|
||||||
|
blocking ambiguity). No human escalation triggered (all confidences ≥
|
||||||
|
0.60 threshold). REQUIREMENTS.md updated with the decision ledger +
|
||||||
|
invariants + NFR constraints. Next: RESEARCH.
|
||||||
+250
-1
@@ -107,4 +107,253 @@ required (full autonomy).
|
|||||||
|
|
||||||
The plan proceeds with the 3 critical fixes and 16 tracked conditions
|
The plan proceeds with the 3 critical fixes and 16 tracked conditions
|
||||||
applied to PLAN.md + REQUIREMENTS.md. The binding decisions above are
|
applied to PLAN.md + REQUIREMENTS.md. The binding decisions above are
|
||||||
the authoritative grill record. Next: MVP/UX CHECK → SHIP phase 0.
|
the authoritative grill record. Next: MVP/UX CHECK → SHIP phase 0.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
# GRILL — v1.29 Reposplit + Identity Layer Bring-Live
|
||||||
|
|
||||||
|
> Adversarial red-team review of the v1.29 SPECIFY + CLARIFY +
|
||||||
|
> RESEARCH + PLAN. Griller: CIAgent griller (red-team persona).
|
||||||
|
> Autonomy: full. All 9 review axes grilled; every claim verified
|
||||||
|
> against the live codebase (`publish.yml`, `kj-version.txt`,
|
||||||
|
> `nova/idp/setup.py`, existing v1.28 test files).
|
||||||
|
> Date: 2026-08-20.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Overall verdict: **PROCEED-WITH-CONDITIONS** · Confidence 0.72
|
||||||
|
|
||||||
|
The plan is architecturally sound and the in-acdl scope is well-bounded.
|
||||||
|
The scope split (Terraform out-of-band in `nova-platform-ops`, acdl
|
||||||
|
authors publish/scrub/archive/guide/consumer-bump) is the correct
|
||||||
|
boundary per Vision §4. The technical depth is accurate (D-239 ECR tag
|
||||||
|
correction, D-240 Terraform precondition floor, CloudFront OAC pitfall,
|
||||||
|
ECR tag mutability → pin-by-digest). The cost envelope is realistic.
|
||||||
|
|
||||||
|
**However**, the covered-reference pattern — as currently structured —
|
||||||
|
is a **deferred-trust assertion** for 14 of 17 requirements. The plan
|
||||||
|
ships REQ-355..366 + 371 as "complete" on the strength of a markdown
|
||||||
|
pointer (the operator guide's cutover-gate section) to CI in a repo
|
||||||
|
that does not yet exist and has no CIAgent presence. The M1.5
|
||||||
|
verification gate, the one surface acdl genuinely owns, can be
|
||||||
|
authored-but-never-run-green and the milestone still ships. Four
|
||||||
|
critical fixes convert "documented" into "evidenced-by-operator-
|
||||||
|
attestation-in-the-guide-which-acdl-audits-at-P6."
|
||||||
|
|
||||||
|
**4 critical fixes (must apply before EXECUTE) + 6 tracked conditions.**
|
||||||
|
No escalations (all axes resolved at confidence ≥ 0.60; the user
|
||||||
|
confirmed the binding verdict on the covered-reference pattern).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Axis verdicts
|
||||||
|
|
||||||
|
| Axis | Verdict | Confidence | Forcing finding |
|
||||||
|
|------|---------|-----------|----------------|
|
||||||
|
| §1 Feasibility | PROCEED-WITH-CONDITIONS | 0.70 | KJ-SOURCE: `kj` v0.0.3 source repo unverified by RESEARCH (CF-1) |
|
||||||
|
| §2 Scope | PROCEED-WITH-CONDITIONS | 0.74 | Covered-reference = deferred-trust for 14/17 REQs (G-1 + CF-2) |
|
||||||
|
| §3 Cost | PROCEED | 0.82 | $30-40/month realistic at pilot volume; no hidden budget shock |
|
||||||
|
| §4 Requirements coverage | PROCEED-WITH-CONDITIONS | 0.76 | All REQs mapped; covered-reference verification surface weak (CF-2) |
|
||||||
|
| §5 Technical risks | PROCEED-WITH-CONDITIONS | 0.72 | KJ-STATIC mitigation sound; KJ-LOCKSTEP by-construction good; M1.5 gate not enforced (CF-1) |
|
||||||
|
| §6 Testability | REJECT-AS-WRITTEN → PROCEED-WITH-CONDITIONS | 0.66 | "Verified via cutover gates in operator guide" is a punt absent CF-1/CF-2/CF-3/CF-4 |
|
||||||
|
| §7 Security | PROCEED-WITH-CONDITIONS | 0.68 | INV-18 (AuthType=AWS_IAM), TFM-HITL, IAM-NARROW unverifiable from acdl (CF-2) |
|
||||||
|
| §8 Timeline/sequencing | PROCEED | 0.80 | P1→P2 ordering safe (acdl-local scrub); P5 smoke hedges (CF-3) |
|
||||||
|
| §9 Adversarial | PROCEED-WITH-CONDITIONS | 0.70 | Dominant silent-failure = M1.5 never runs green (CF-1 addresses) |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Critical fixes (must apply before EXECUTE)
|
||||||
|
|
||||||
|
### 🔴 CF-1 — M1.5 green is a HARD P6 milestone-ship gate; spike extended
|
||||||
|
|
||||||
|
**Finding:** P1 authors the M1.5 gate tests (Wave 3) but P1's exit
|
||||||
|
criterion explicitly marks the live KMS round-trip as "covered-
|
||||||
|
reference, runs in nova-platform-ops CI." P6 ships the milestone with
|
||||||
|
no requirement that M1.5 ever ran green. The dominant silent-failure
|
||||||
|
path (user-confirmed): M1.5 never runs green → 14 REQs ship "complete"
|
||||||
|
on paper while Nova-idp is not live.
|
||||||
|
|
||||||
|
**Fix (binding):**
|
||||||
|
1. P6 Wave 2 (`ciagent-ship`) MUST NOT ship `v1.28.6` until the operator
|
||||||
|
guide (`docs/operator-guide-platform-ops.md`) contains an
|
||||||
|
operator-attested "M1.5 Verification Gate Result" row recording:
|
||||||
|
(a) the 8-item spike all-green on **3 consecutive rebuilds** in
|
||||||
|
`nova-platform-ops` CI; (b) the rebuild run IDs / commit SHAs; (c)
|
||||||
|
the operator attestor identity. The P6 audit step (Wave 1) verifies
|
||||||
|
this row exists + is non-empty. Absent the row → P6 blocks → escalate.
|
||||||
|
2. The M1.5 8-item spike (PLAN Happy Path §3.3 Edge 5) is EXTENDED from
|
||||||
|
8 to **12 items** by adding:
|
||||||
|
- **Item 9 (JWKS-EDGE-ONLY):** direct JWKS Function URL GET (bypassing
|
||||||
|
CloudFront) returns **403**; via-CloudFront GET returns 200. Proves
|
||||||
|
`AuthType: AWS_IAM` + OAC pinning (INV-18). Without this, the
|
||||||
|
`AuthType: NONE` pitfall (RESEARCH §4) is undetected.
|
||||||
|
- **Item 10 (IAM-NARROW):** `aws iam get-role-policy` on the OIDC
|
||||||
|
role asserts no `Action: "*"` and no `Resource: "*"` (REQ-360).
|
||||||
|
- **Item 11 (TFM-HITL):** a `terraform apply` `workflow_dispatch`
|
||||||
|
triggered by the PR author is **rejected** (exit non-zero,
|
||||||
|
`gitea.triggering_actor == PR author`); a dispatch by a distinct
|
||||||
|
user proceeds (REQ-357, RESEARCH §10).
|
||||||
|
- **Item 12 (rollback drill):** revert `nova_platform_version` pin →
|
||||||
|
`terraform apply` → assert the prior ECR digest runs (proves D-236
|
||||||
|
rollback; guards against ECR tag mutability, RESEARCH §2).
|
||||||
|
|
||||||
|
**Binding decision G-2.1:** the covered-reference pattern is accepted
|
||||||
|
as a verification surface **only** with CF-1 applied. M1.5 green
|
||||||
|
(evidenced by operator attestation in the guide) is the ship gate.
|
||||||
|
|
||||||
|
### 🔴 CF-2 — Covered-reference REQs gated by operator-attested evidence rows
|
||||||
|
|
||||||
|
**Finding:** 14 of 17 REQs (355..366, 371) are "verified via cutover
|
||||||
|
gates in the operator guide" (CLARIFY G4). This is a deferred-trust
|
||||||
|
assertion: if `nova-platform-ops` is never built, or builds the wrong
|
||||||
|
thing, or its CI silently passes, the REQs ship "complete" on the
|
||||||
|
strength of a markdown pointer. The user confirmed this is a
|
||||||
|
deferred-trust assertion, not a verification.
|
||||||
|
|
||||||
|
**Fix (binding):** The operator guide (P4 Wave 1 Task 1.1) "Cutover
|
||||||
|
Gates" section MUST list each covered-reference REQ with:
|
||||||
|
(a) the gate entry (M1/M1.5/M2); (b) the verification command; (c) a
|
||||||
|
placeholder "Result" column. The P6 audit step (Wave 1) verifies that
|
||||||
|
every covered-reference REQ has a non-empty, green "Result" entry
|
||||||
|
(operator-attested). A REQ with an empty or red Result → P6 blocks.
|
||||||
|
This converts "documented" to "evidenced-by-operator-attestation-
|
||||||
|
audited-by-acdl-at-P6."
|
||||||
|
|
||||||
|
**Binding decision G-1:** the covered-reference pattern is **accepted
|
||||||
|
as a verification surface** with CF-1 + CF-2 applied. Without them, it
|
||||||
|
is a punt and the grill would REJECT.
|
||||||
|
|
||||||
|
### 🔴 CF-3 — P5 smoke test must run against a real v1.29.x tag (no hedge)
|
||||||
|
|
||||||
|
**Finding:** P5 bumps the consumer deploy.yml `@v1.25` → `@v1.29` and
|
||||||
|
runs a smoke test "against the v1.29 publish artifacts." But
|
||||||
|
`publish.yml` triggers on `v1.29.*` tags (P1 Wave 0), and the milestone
|
||||||
|
release tag is `v1.28.6`. P5 Wave 1 Task 1.2 hedges: "If the v1.29
|
||||||
|
publish artifacts are not yet available... mark as covered-reference:
|
||||||
|
requires v1.29.0 tag." This hedge lets P5 ship green without the
|
||||||
|
smoke test ever running against real artifacts — a second silent-
|
||||||
|
failure path.
|
||||||
|
|
||||||
|
**Fix (binding):**
|
||||||
|
1. P1 Wave 4 (regression + ship) MUST push a `v1.29.0` tag (or the
|
||||||
|
first `v1.29.x` tag) as part of P1 ship, triggering `publish.yml`
|
||||||
|
and producing the v1.29 artifacts. Document this in PLAN P1.
|
||||||
|
2. P5 Wave 1 Task 1.2's hedge clause is REMOVED. The P5 smoke test
|
||||||
|
MUST run against the published v1.29.x artifacts. If the artifacts
|
||||||
|
are absent (P1 failed to publish), P5 fails closed — no hedge to
|
||||||
|
"covered-reference."
|
||||||
|
3. The milestone release tag remains `v1.28.6` (the v1.28.x line per
|
||||||
|
the tagging convention); the `v1.29.0` artifact tag is a P1
|
||||||
|
intermediate tag, not the release. This resolves the tag-semantics
|
||||||
|
ambiguity the grill surfaced.
|
||||||
|
|
||||||
|
### 🔴 CF-4 — kj v0.0.3 source-fetch path confirmed before P1 Wave 1
|
||||||
|
|
||||||
|
**Finding:** P1 Wave 1 Task 1.1b says "fetches the `kj` Go source at
|
||||||
|
the pinned SHA" citing "RESEARCH §7 — source repo confirmed in P1
|
||||||
|
RESEARCH." RESEARCH §7 confirms the build command (`CGO_ENABLED=0`)
|
||||||
|
but is **silent on the source repository**. Assumption ledger item #1
|
||||||
|
says "RESEARCH will confirm the source repository + build commands"
|
||||||
|
— RESEARCH did NOT confirm the source repo. `kj-version.txt` pins
|
||||||
|
`v0.0.3` + SHA `4ebb9a19...` but the grill cannot determine whether
|
||||||
|
this is a source commit SHA or a binary digest, or what repo it lives
|
||||||
|
in. P1 Wave 1 is built on an open assumption.
|
||||||
|
|
||||||
|
**Fix (binding):** Before P1 Wave 1 starts (P1 Wave 0 or a new Wave
|
||||||
|
0.5), the backend-engineer MUST confirm: (a) the `kj` source repo URL
|
||||||
|
+ the commit at SHA `4ebb9a19...`; (b) `go build` reproduces a binary
|
||||||
|
whose SHA-256 matches the recorded one (or the SHA is a source commit,
|
||||||
|
in which case the build is the verification); (c) the fetched source
|
||||||
|
compiles `CGO_ENABLED=0` to a statically-linked binary (KJ-STATIC). If
|
||||||
|
the source is not fetchable at the pinned SHA → P1 fails closed →
|
||||||
|
escalate (this is a spec dependency, not a CIAgent ambiguity per
|
||||||
|
assumption #1). Document the confirmed repo URL + commit in
|
||||||
|
`platform/abac/kj-version.txt` (add a third line: the source repo URL).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Tracked conditions (apply during execution)
|
||||||
|
|
||||||
|
- **TC-1 (KJ-STATIC audit, P1 Wave 1 Task 1.2):** `file(1)` asserts
|
||||||
|
`statically linked` + `readelf -d` asserts no `NEEDED` entries, as a
|
||||||
|
CI gate. Already in PLAN; tracked for enforcement.
|
||||||
|
- **TC-2 (KJ-LOCKSTEP by construction, covered-reference):** both
|
||||||
|
image-bearing resources reference a single `data.aws_ecr_image.kj_image`;
|
||||||
|
`image_uri = repo@digest`. Verified via CF-1 item 12 (rollback drill)
|
||||||
|
+ CF-2 (operator-attested result row for REQ-371).
|
||||||
|
- **TC-3 (CloudFront OAC pitfall, P4 operator guide):** the guide MUST
|
||||||
|
document the `AuthType: NONE` → OAC-ignored pitfall (RESEARCH §4) as
|
||||||
|
a callout. CF-1 item 9 mechanically verifies it. Already in PLAN P4
|
||||||
|
Wave 0 Task 0.3b; tracked.
|
||||||
|
- **TC-4 (ECR tag format, P1 Wave 1 Task 1.1f):** assert tag matches
|
||||||
|
`^[a-zA-Z0-9._-]+$` before push (D-239). Already in PLAN; tracked.
|
||||||
|
- **TC-5 (import idempotency, covered-reference REQ-361):** CI import
|
||||||
|
treats "Resource already managed by Terraform" as idempotent success
|
||||||
|
(grep the message, not just exit code). Documented in RESEARCH §1;
|
||||||
|
tracked for the ops repo (operator-attested via CF-2).
|
||||||
|
- **TC-6 (Fargate sunset discipline, P4 operator guide):** D-237 —
|
||||||
|
≥30 consecutive days green + architecture review before deletion.
|
||||||
|
Already in PLAN P4 Wave 0 Task 0.3f; tracked.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Binding decisions (this grill session)
|
||||||
|
|
||||||
|
| ID | Decision | Rationale | Confidence |
|
||||||
|
|----|----------|-----------|-----------|
|
||||||
|
| **G-1** | The covered-reference pattern is accepted as a verification surface, but ONLY with CF-1 (M1.5 green = hard P6 gate + spike extended to 12 items) + CF-2 (operator-attested result rows for every covered-reference REQ, audited at P6). Without these, it is a deferred-trust assertion (punt) and the grill would REJECT. | User-confirmed: covered-reference is a deferred-trust assertion; M1.5 must be a hard gate; TFM-HITL/IAM-NARROW/JWKS-EDGE-ONLY are unverifiable from acdl absent the extended spike. | 0.78 |
|
||||||
|
| **G-2.1** | M1.5 green (3 consecutive rebuilds of the 12-item spike) is a binding P6 milestone-ship gate, evidenced by an operator-attested row in the operator guide. The P6 audit verifies the row exists + is green. | Dominant silent-failure path = M1.5 never runs green → 14 REQs false-"complete." User-confirmed. | 0.85 |
|
||||||
|
| **G-2.2** | The M1.5 spike is extended 8 → 12 items, adding: JWKS-EDGE-ONLY direct-URL-403 check, IAM-NARROW no-wildcard assertion, TFM-HITL self-approval-rejection check, rollback drill. | INV-18, REQ-360, REQ-357 are otherwise unverifiable from acdl. Rollback is untested (D-236). | 0.80 |
|
||||||
|
| **G-3** | P1 MUST push a `v1.29.0` (or first `v1.29.x`) intermediate tag at P1 ship to produce publish artifacts; P5's "covered-reference: requires v1.29.0 tag" hedge is REMOVED; the smoke test must run against real artifacts or P5 fails closed. | P5's hedge is a second silent-failure path. User-confirmed. | 0.82 |
|
||||||
|
| **G-4** | The `kj` v0.0.3 source-fetch path (repo URL + commit at SHA `4ebb9a19...`) must be confirmed before P1 Wave 1; the confirmed repo URL is recorded as a third line in `platform/abac/kj-version.txt`. If unfetchable → P1 fails closed → escalate. | RESEARCH §7 is silent on the source repo; P1 Wave 1 is built on an open assumption. User-confirmed. | 0.80 |
|
||||||
|
| **G-5** | The covered-reference REQs (355..366, 371) are NOT marked "complete" at P6 unless their operator-guide cutover-gate row is non-empty + green (CF-2). An empty/red row blocks the milestone ship. | Converts "documented" → "evidenced-by-operator-attestation-audited-by-acdl." | 0.78 |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Escalations
|
||||||
|
|
||||||
|
None. All 9 axes resolved at confidence ≥ 0.66. The user confirmed the
|
||||||
|
binding verdict (G-1: accepted with 4 conditions). No human escalation
|
||||||
|
required (full autonomy). The kj source-fetch (CF-4) has a fail-closed
|
||||||
|
path: if RESEARCH's open assumption is wrong, P1 fails closed and
|
||||||
|
escalates at that point — but the grill does not pre-escalate a
|
||||||
|
spec dependency the plan already flags.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Evidence verified against the live codebase
|
||||||
|
|
||||||
|
- `.github/workflows/publish.yml` line 47-55: trigger is
|
||||||
|
`push: branches: [main]` (P1 Wave 0 changes to `tags: ['v1.29.*']` —
|
||||||
|
matches PLAN).
|
||||||
|
- `.gitea/workflows/publish.yml` exists (P2 removes it — matches PLAN).
|
||||||
|
- `platform/abac/kj-version.txt`: 2 lines (`v0.0.3` + SHA
|
||||||
|
`4ebb9a19...`) — matches PLAN; RESEARCH §7 silent on source repo
|
||||||
|
(CF-4).
|
||||||
|
- `nova/idp/setup.py`: 50 lines, `--check/--apply/--verify/--dry-run`
|
||||||
|
(P3 adds terraform delegation — matches PLAN).
|
||||||
|
- `core/lambda/nova_idp_setup.py` exists (P3 archives its CFN — matches).
|
||||||
|
- `tests/test_idp_auth.py` + `tests/test_kms_roundtrip.py` EXIST (from
|
||||||
|
v1.28); `tests/test_abac_e2e.py` does NOT exist (P1 Wave 3 authors it
|
||||||
|
— matches PLAN).
|
||||||
|
- `pyproject.toml` version = `1.14.0` (P2 bumps to `1.29.0` — matches
|
||||||
|
PLAN; note: v1.28 did not bump it, a v1.28 carry-over the grill
|
||||||
|
flags as minor but does not block on).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Grill complete
|
||||||
|
|
||||||
|
The v1.29 plan proceeds with **4 critical fixes** (CF-1 M1.5 hard gate
|
||||||
|
+ spike extension; CF-2 operator-attested result rows; CF-3 P5 live
|
||||||
|
smoke no-hedge; CF-4 kj source confirmation) and **6 tracked
|
||||||
|
conditions**. The covered-reference pattern is accepted as a
|
||||||
|
verification surface **only** because CF-1 + CF-2 convert
|
||||||
|
"documented" into "evidenced-by-operator-attestation-audited-by-acdl-
|
||||||
|
at-P6." Without those fixes, the grill would REJECT: 14 of 17 REQs
|
||||||
|
would ship "complete" on the strength of a markdown pointer to a
|
||||||
|
nonexistent repo's CI.
|
||||||
|
|
||||||
|
Next: apply the 4 critical fixes to PLAN.md + REQUIREMENTS.md, then
|
||||||
|
MVP/UX CHECK → SHIP phase 0.
|
||||||
+149
-1
@@ -116,4 +116,152 @@ reason: "No data pipelines / metrics / PowerBI work in v1.28. The metrics layer
|
|||||||
None. All four active personas span the full milestone. The
|
None. All four active personas span the full milestone. The
|
||||||
security-engineer is heaviest in P2 (identity layer) + P3 (threat model);
|
security-engineer is heaviest in P2 (identity layer) + P3 (threat model);
|
||||||
the cli-engineer is heaviest in P1 (CLI substrate); the backend-engineer
|
the cli-engineer is heaviest in P1 (CLI substrate); the backend-engineer
|
||||||
spans P1 (CodeArtifact/layer) + P2 (Lambdas/DynamoDB).
|
spans P1 (CodeArtifact/layer) + P2 (Lambdas/DynamoDB).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
# Personas — v1.29 Reposplit + Identity Layer Bring-Live
|
||||||
|
|
||||||
|
```yaml
|
||||||
|
project: acdl
|
||||||
|
milestone: v1.29
|
||||||
|
generated_at: 2026-08-20
|
||||||
|
generator: lead-developer
|
||||||
|
verification_toolchain:
|
||||||
|
typecheck: "python3 -m py_compile nova/idp/setup.py core/lambda/nova_idp_setup.py 2>&1 | head -5 || true"
|
||||||
|
test: "pytest tests/test_idp_auth.py tests/test_kms_roundtrip.py -q 2>&1 | tail -15 || true"
|
||||||
|
lint: "ruff check nova/idp/ core/lambda/nova_idp_setup.py 2>/dev/null || true"
|
||||||
|
note: |
|
||||||
|
v1.29 is a feature milestone (Reposplit + Identity Layer Bring-Live).
|
||||||
|
Pure ops/devops focus — Terraform modules are authored out-of-band in
|
||||||
|
nova-platform-ops; CIAgent in acdel delivers publish.yml, Gitea scrub,
|
||||||
|
CFN archive + CLI terraform-delegation, operator guide, consumer bump.
|
||||||
|
Five active personas: backend-engineer (publish.yml ECR image, Lambda
|
||||||
|
zip, GitHub Releases), security-engineer (kj static build verification,
|
||||||
|
KMS round-trip tests, ABAC E2E, M1.5 gate), cli-engineer (nova idp
|
||||||
|
setup --apply terraform delegation, CFN archive), data-engineer
|
||||||
|
(DynamoDB import references, outbox bootstrap docs), lead-developer
|
||||||
|
(plan/review/ship, Gitea scrub, decisions, operator guide, milestone
|
||||||
|
wiring). frontend-engineer deactivated (no UI).
|
||||||
|
```
|
||||||
|
|
||||||
|
## Roster
|
||||||
|
|
||||||
|
### lead-developer
|
||||||
|
```yaml
|
||||||
|
active: true
|
||||||
|
domain: "Milestone plan, persona roster, Gitea scrub (REQ-367), decisions D-232..240 (REQ-368), operator guide (P4), milestone ship, STATE/ROADMAP/PROJECT wiring, covered-reference REQ tracking"
|
||||||
|
frameworks: ["git", "Gitea Actions", "GitHub Actions", "semver tagging", ".ciagent/ discipline", "Terraform (reference only)"]
|
||||||
|
constraints: ["D-232 (forge parity abandoned)", "D-235 (tag-pin handoff)", "D-236 (cutover shape)", "D-238 (KJ-LOCKSTEP)", "OPER-PRIV", "TFM-HITL", "v1.29 hard constraints"]
|
||||||
|
territory:
|
||||||
|
- ".ciagent/**"
|
||||||
|
- "PLAN.md"
|
||||||
|
- "CHECKPOINT.json"
|
||||||
|
- "STATE.md"
|
||||||
|
- "REQUIREMENTS.md"
|
||||||
|
- "ROADMAP.md"
|
||||||
|
- "PROJECT.md"
|
||||||
|
- "CLARIFY.md"
|
||||||
|
- "RESEARCH.md"
|
||||||
|
- "docs/operator-guide-platform-ops.md"
|
||||||
|
- ".github/workflows/ci.yml"
|
||||||
|
- "scripts/sync_workflows.py"
|
||||||
|
- "pyproject.toml"
|
||||||
|
- "README.md"
|
||||||
|
```
|
||||||
|
|
||||||
|
### backend-engineer
|
||||||
|
```yaml
|
||||||
|
active: true
|
||||||
|
domain: "publish.yml ECR container image build (CGO_ENABLED=0 static kj), Lambda zip + layer wheel + Python wheel attach to GitHub Releases, ECR push with tag v1.29.x-kj-<sha>, kj-version.txt read, Dockerfile for lambda:3.12-al2023 base"
|
||||||
|
frameworks: ["Python 3.12", "GitHub Actions", "Docker", "ECR", "Go (CGO_ENABLED=0 build)", "file(1)", "sha256sum"]
|
||||||
|
constraints: ["KJ-STATIC", "D-239 (ECR tag format)", "D-235 (tag-pin handoff)", "REQ-354 criteria 1-4"]
|
||||||
|
territory:
|
||||||
|
- ".github/workflows/publish.yml"
|
||||||
|
- "platform/abac/kj-version.txt"
|
||||||
|
- "core/lambda/nova_idp_token_vend.py"
|
||||||
|
- "core/lambda/nova_idp_auth.py"
|
||||||
|
- "core/lambda/nova_idp_jwks.py"
|
||||||
|
- "tests/test_idp_auth.py"
|
||||||
|
- "tests/test_kms_roundtrip.py"
|
||||||
|
```
|
||||||
|
|
||||||
|
### security-engineer
|
||||||
|
```yaml
|
||||||
|
active: true
|
||||||
|
domain: "kj static-link audit (file(1) asserts statically linked + no shared library), KMS round-trip test against alias/nova-oidc-signing, ABAC E2E (sign-up→sign-in→token-vend→verify, INV-17 fail-closed), M1.5 verification gate tests (8-item spike), KJ-LOCKSTEP digest-equality verification"
|
||||||
|
frameworks: ["KMS Sign/Verify/GetPublicKey", "kyverno-json", "jose", "file(1)", "readelf", "pytest", "moto[dynamodb]"]
|
||||||
|
constraints: ["KJ-STATIC", "KJ-LOCKSTEP", "INV-17 (ABAC fail-closed)", "INV-18 (JWKS-EDGE-ONLY)", "ABAC-FAIL-CLOSED", "ARGON", "KF (KMS asymmetric)"]
|
||||||
|
territory:
|
||||||
|
- "platform/abac/**"
|
||||||
|
- "platform/abac/kj-version.txt"
|
||||||
|
- "adapters/kyverno-json/policies/token-vend.policy"
|
||||||
|
- "tests/test_kms_roundtrip.py"
|
||||||
|
- "tests/test_idp_auth.py"
|
||||||
|
- "tests/test_abac_e2e.py"
|
||||||
|
- "docs/threat-model.md"
|
||||||
|
```
|
||||||
|
|
||||||
|
### cli-engineer
|
||||||
|
```yaml
|
||||||
|
active: true
|
||||||
|
domain: "nova idp setup --apply terraform delegation (REQ-369 AC 2), CFN archive to docs/archive/nova-idp-cfn-v1.28.md (REQ-369 AC 3), which terraform detection + CFN fallback deprecation warning"
|
||||||
|
frameworks: ["Python 3.12", "argparse", "subprocess", "importlib", "shutil.which"]
|
||||||
|
constraints: ["REQ-369", "D-235 (tag-pin handoff)"]
|
||||||
|
territory:
|
||||||
|
- "nova/idp/setup.py"
|
||||||
|
- "core/lambda/nova_idp_setup.py"
|
||||||
|
- "docs/archive/nova-idp-cfn-v1.28.md"
|
||||||
|
- "nova/idp/__init__.py"
|
||||||
|
```
|
||||||
|
|
||||||
|
### data-engineer
|
||||||
|
```yaml
|
||||||
|
active: true
|
||||||
|
phase_specific: false
|
||||||
|
domain: "DynamoDB table import references (nova-contracts, nova-change-requests, nova-outbox, nova-users, nova-sessions, nova-pats) documented in operator guide, PITR restore procedure, audit outbox bootstrap"
|
||||||
|
frameworks: ["DynamoDB", "AWS CLI (reference)"]
|
||||||
|
constraints: ["REQ-361 (import idempotency, covered-reference)", "JWKS-ROTATION"]
|
||||||
|
territory:
|
||||||
|
- "docs/operator-guide-platform-ops.md"
|
||||||
|
- ".ciagent/ARCHITECTURE.md"
|
||||||
|
reason: |
|
||||||
|
Re-activated for v1.29: the operator guide (P4) documents DynamoDB PITR
|
||||||
|
restore, table imports, and the audit outbox bootstrap — data-engineer
|
||||||
|
owns the data-layer sections of the guide. The Terraform import itself
|
||||||
|
is out-of-band (nova-platform-ops), but the operator-facing docs are
|
||||||
|
in-acdl.
|
||||||
|
```
|
||||||
|
|
||||||
|
### frontend-engineer
|
||||||
|
```yaml
|
||||||
|
active: false
|
||||||
|
phase_specific: false
|
||||||
|
reason: "No UI in v1.29 (pure ops/devops focus). JWKS serves application/json via CloudFront; no HTML/CSS/JS surface."
|
||||||
|
```
|
||||||
|
|
||||||
|
## Territory overlap notes
|
||||||
|
|
||||||
|
- `.github/workflows/publish.yml` (REQ-354) = backend-engineer (ECR
|
||||||
|
image build, Dockerfile, Lambda zip) + lead-developer (Gitea scrub
|
||||||
|
removes the `.gitea/workflows/publish.yml` mirror in P2, D-232).
|
||||||
|
- `nova/idp/setup.py` (REQ-369) = cli-engineer (the `--apply` delegation
|
||||||
|
+ `which terraform` detection) + backend-engineer (the CFN archive
|
||||||
|
content — the CFN template is backend-engineer territory from v1.28).
|
||||||
|
- `platform/abac/kj-version.txt` = security-engineer (KJ-STATIC audit
|
||||||
|
reads + verifies the SHA) + backend-engineer (publish.yml reads the
|
||||||
|
SHA to embed in the ECR tag).
|
||||||
|
- `docs/operator-guide-platform-ops.md` (P4) = lead-developer (cutover
|
||||||
|
gates, cost section, artifact-mirror fallback) + data-engineer (PITR
|
||||||
|
restore, DynamoDB imports) + security-engineer (KMS rotation, JWKS
|
||||||
|
reachability, PAT revocation).
|
||||||
|
|
||||||
|
## Phase-specific personas
|
||||||
|
|
||||||
|
None. All five active personas span the full milestone. The
|
||||||
|
backend-engineer is heaviest in P1 (publish pipeline); the
|
||||||
|
lead-developer is heaviest in P2 (Gitea scrub + decisions) + P4
|
||||||
|
(operator guide) + P6 (final ship); the cli-engineer is heaviest in P3
|
||||||
|
(CFN archive + TF delegation); the security-engineer is heaviest in P1
|
||||||
|
(M1.5 gate tests) + P4 (operator guide security sections); the
|
||||||
|
data-engineer is heaviest in P4 (operator guide data sections).
|
||||||
+571
-1
@@ -486,4 +486,574 @@ Optional CloudFront + WAF + ACM (if `--public-jwks-domain`): +~$3/month
|
|||||||
at pilot volume. ACM is free for CloudFront-attached certs.
|
at pilot volume. ACM is free for CloudFront-attached certs.
|
||||||
|
|
||||||
This is a pilot-scale cost envelope. Production scale (100x volume)
|
This is a pilot-scale cost envelope. Production scale (100x volume)
|
||||||
would still be <$50/month. No hidden costs identified.
|
would still be <$50/month. No hidden costs identified.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
# PLAN — v1.29 Reposplit + Identity Layer Bring-Live
|
||||||
|
|
||||||
|
> **Milestone:** v1.29 (feature — reposplit + identity layer bring-live).
|
||||||
|
> Tags on the **v1.28.x** line: `v1.28.0` (P0) → `v1.28.1..v1.28.5`
|
||||||
|
> (P1..P5) → `v1.28.6` (P6 final = milestone release). The final phase's
|
||||||
|
> patch IS the milestone release.
|
||||||
|
> **Branch:** `milestone/v1.29-reposplit-identity`. Phase branches:
|
||||||
|
> `phase/00-pre-execution` (complete), `phase/01-publish-pipeline`,
|
||||||
|
> `phase/02-gitea-scrub-decisions`, `phase/03-cfn-archive-tf-delegation`,
|
||||||
|
> `phase/04-operator-guide-reference-tracking`,
|
||||||
|
> `nova-blockchain-exchange/phase/05-consumer-deploy-bump` (cross-project),
|
||||||
|
> `phase/06-final-review-ship`.
|
||||||
|
>
|
||||||
|
> **Scope split (CLARIFY-grounded):** Terraform modules authored
|
||||||
|
> out-of-band in `nova-platform-ops`. CIAgent in `acdl` authors only the
|
||||||
|
> acdl-side REQs (354, 367, 368, 369, REQ-OPS-GUIDE, REQ-CONSUMER-BUMP).
|
||||||
|
> Covered-reference REQs (355-366, 371) verified via cutover gates
|
||||||
|
> documented in the operator guide (P4).
|
||||||
|
|
||||||
|
## Milestone goal
|
||||||
|
|
||||||
|
v1.29 makes platform operations a Terraform-controlled discipline that
|
||||||
|
lives outside the engineering repo, with a narrow-IAM `kj` substrate
|
||||||
|
shared by the primary runtime and its defensive fallback. `acdl/acdl`
|
||||||
|
standardizes on GitHub (Gitea scrub); Nova-idp is brought live in
|
||||||
|
account `581513795199` (code complete since v1.28, unverified in-account
|
||||||
|
at Phase 0); `kj` has exactly one identity (one ECR image digest) shared
|
||||||
|
by both substrates (KJ-LOCKSTEP, REQ-371).
|
||||||
|
|
||||||
|
## Requirements
|
||||||
|
|
||||||
|
17 requirements: REQ-354..REQ-369 + REQ-371 + REQ-363b + REQ-OPS-GUIDE
|
||||||
|
+ REQ-CONSUMER-BUMP (full text in `.ciagent/REQUIREMENTS.md` §v1.29).
|
||||||
|
1 invariant: INV-18 (JWKS-EDGE-ONLY). 10 NFR constraints: KJ-STATIC,
|
||||||
|
KJ-LOCKSTEP, KJ-WARMUP-HEALTH, OPER-PRIV, IAM-NARROW, DRIFT-DETECT,
|
||||||
|
IMPORT-IDEMPOTENT, TFM-HITL, JWKS-SLO, JWKS-ROTATION. 9 decisions:
|
||||||
|
D-232..D-238 (CLARIFY) + D-239/D-240 (RESEARCH spec corrections).
|
||||||
|
|
||||||
|
## Phase breakdown
|
||||||
|
|
||||||
|
### Phase P1 — publish-pipeline (REQ-354)
|
||||||
|
|
||||||
|
**Goal:** `publish.yml` attaches Lambda zip + layer wheel + Python wheel
|
||||||
|
+ ECR container image (static `kj`, `CGO_ENABLED=0`, tag
|
||||||
|
`v1.29.x-kj-<sha>`) to GitHub Release for each tag, with matching
|
||||||
|
SHA-256 in the body. The M1.5 verification gate tests
|
||||||
|
(`test_idp_auth`, `test_kms_roundtrip`, ABAC E2E) are authored.
|
||||||
|
|
||||||
|
**Exit criterion:** REQ-354 criteria 1-4 pass; KJ-STATIC audit (file(1)
|
||||||
|
asserts `statically linked`) runs in CI; ECR image pushed with tag
|
||||||
|
`v1.29.x-kj-<sha>` (D-239); GitHub Release body lists image URI + digest
|
||||||
|
alongside wheel + layer + Lambda zip; M1.5 gate tests exist + pass in
|
||||||
|
moto-DDB (live KMS round-trip is covered-reference, runs in
|
||||||
|
nova-platform-ops CI).
|
||||||
|
|
||||||
|
**Branch:** `phase/01-publish-pipeline`. **Tag:** `v1.28.1`.
|
||||||
|
|
||||||
|
#### Wave 0 — publish.yml trigger model (backend-engineer)
|
||||||
|
- **Task 0.1** (backend-engineer): change `.github/workflows/publish.yml`
|
||||||
|
trigger from `push: branches: [main]` to `push: tags: ['v1.29.*']`.
|
||||||
|
Preserve the existing wheel + Lambda layer publish steps (REQ-323/
|
||||||
|
CAP-035). Add the Lambda zip packaging step
|
||||||
|
(`nova-lambda-token-vend-v1.29.x.zip`). Verify the trigger fires on
|
||||||
|
`git tag v1.29.0 && git push --tags`.
|
||||||
|
|
||||||
|
#### Wave 1 — kj source confirmation + static build + ECR image (backend-engineer, security-engineer)
|
||||||
|
- **Task 1.0** (backend-engineer): **kj source-fetch confirmation
|
||||||
|
(grill CF-4/G-4 — binary go/no-go gate before Wave 1).** Confirm the
|
||||||
|
`kj` Go source repo URL + commit at SHA `4ebb9a19...` (read from
|
||||||
|
`platform/abac/kj-version.txt`). Record the repo URL as a 3rd line
|
||||||
|
in `platform/abac/kj-version.txt`. If unfetchable → P1 fails closed
|
||||||
|
→ escalate (this is a spec dependency, not a CIAgent ambiguity). The
|
||||||
|
source repo is the `kyverno-json/kj` Go binary project (distinct
|
||||||
|
from the kyverno-json Python engine adapter in `adapters/kyverno-
|
||||||
|
json/`).
|
||||||
|
- **Task 1.1** (backend-engineer): add a `build-kj-image` job to
|
||||||
|
`publish.yml` that:
|
||||||
|
(a) reads `platform/abac/kj-version.txt` (v0.0.3 + SHA
|
||||||
|
`4ebb9a19...`);
|
||||||
|
(b) fetches the `kj` Go source at the pinned SHA (RESEARCH §7 —
|
||||||
|
source repo confirmed in P1 RESEARCH);
|
||||||
|
(c) builds with `CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build
|
||||||
|
-ldflags="-s -w" -o kj ./…`;
|
||||||
|
(d) runs `file kj` and asserts output contains `statically linked`
|
||||||
|
AND does NOT contain `shared library` (KJ-STATIC — fail build
|
||||||
|
otherwise);
|
||||||
|
(e) builds the container image from
|
||||||
|
`public.ecr.aws/lambda/python:3.12-al2023`, copying `kj` to
|
||||||
|
`/opt/kj/kj` with `chmod 0555` owned by `sbx_user:1051`;
|
||||||
|
(f) pushes the image to ECR with tag `v1.29.x-kj-<kj-source-sha>`
|
||||||
|
(D-239 — assert tag matches `^[a-zA-Z0-9._-]+$` before push);
|
||||||
|
(g) records the image URI + digest for the GitHub Release body.
|
||||||
|
- **Task 1.2** (security-engineer): add a KJ-STATIC audit step that
|
||||||
|
runs `file(1)` + `readelf -d kj` (assert no `NEEDED` entries) as a
|
||||||
|
CI gate. If either fails, the publish job fails closed. This is the
|
||||||
|
mechanical enforcement of KJ-STATIC (not just a human review).
|
||||||
|
|
||||||
|
#### Wave 2 — GitHub Release body + SHA-256 (backend-engineer)
|
||||||
|
- **Task 2.1** (backend-engineer): extend the `publish.yml` release step
|
||||||
|
to attach: (a) `nova-lambda-token-vend-v1.29.x.zip`; (b)
|
||||||
|
`nova-cli-layer-v1.29.x.zip`; (c) `nova-1.29.x-py3-none-any.whl`; (d)
|
||||||
|
the ECR image URI + digest. Compute SHA-256 for each artifact + list
|
||||||
|
in the release body. Verify REQ-354 criteria 1, 2, 4 (artifacts
|
||||||
|
appear, independent per tag, image URI + digest listed).
|
||||||
|
|
||||||
|
#### Wave 3 — M1.5 verification gate tests (security-engineer)
|
||||||
|
- **Task 3.1** (security-engineer): author `tests/test_idp_auth.py` —
|
||||||
|
sign-up → sign-in → session flow against moto-DDB (covers Edge 5
|
||||||
|
item 5). Skip live-KMS assertions (covered-reference — runs in
|
||||||
|
nova-platform-ops CI).
|
||||||
|
- **Task 3.2** (security-engineer): author
|
||||||
|
`tests/test_kms_roundtrip.py` — sign/verify round-trip against
|
||||||
|
`alias/nova-oidc-signing`. Mark as `@pytest.mark.live_aws` (skipped in
|
||||||
|
acdl CI; runs in nova-platform-ops CI against the live key, REQ-362).
|
||||||
|
- **Task 3.3** (security-engineer): author
|
||||||
|
`tests/test_abac_e2e.py` — known PAT → ABAC-allowed action → signed
|
||||||
|
OIDC token → `jose` verification → green; known PAT + ABAC-denied
|
||||||
|
action → 403 with deny reason logged (INV-17 fail-closed, Edge 5
|
||||||
|
item 7). Uses moto-DDB + mock KMS.
|
||||||
|
|
||||||
|
#### Wave 4 — regression + ship (lead-developer)
|
||||||
|
- **Task 4.1** (lead-developer): run full test suite; verify 1000+
|
||||||
|
tests still pass (no regressions from publish.yml changes). Verify
|
||||||
|
CAP-001..038 regression gate green. **Push a `v1.29.0` intermediate
|
||||||
|
tag at P1 ship** (grill CF-3/G-3) to trigger `publish.yml` + produce
|
||||||
|
the v1.29 artifacts (Lambda zip + layer wheel + Python wheel + ECR
|
||||||
|
image). The milestone release tag remains `v1.28.6`; the `v1.29.0`
|
||||||
|
artifact tag is a P1 intermediate to produce publish artifacts for
|
||||||
|
P5's smoke test. Ship P1 → `v1.28.1`.
|
||||||
|
|
||||||
|
### Phase P2 — gitea-scrub-decisions (REQ-367, REQ-368)
|
||||||
|
|
||||||
|
**Goal:** Hard scrub of all Gitea references in `acdl/acdl`; `.gitea/`
|
||||||
|
removed; `forge_parity_disabled` CI assertion; pyproject → 1.29.0;
|
||||||
|
decisions D-232..238 recorded in PROJECT.md + CLARIFY (already done in
|
||||||
|
P0; this phase adds the CI assertion + the actual file scrub).
|
||||||
|
|
||||||
|
**Exit criterion:** `grep -rni gitea .github/ docs/ pyproject.toml
|
||||||
|
README.md .ciagent/` returns zero matches outside the spec archive
|
||||||
|
section; `find .gitea` returns nothing; CI `forge_parity_disabled`
|
||||||
|
assertion passes; pyproject.toml version = 1.29.0.
|
||||||
|
|
||||||
|
**Branch:** `phase/02-gitea-scrub-decisions`. **Tag:** `v1.28.2`.
|
||||||
|
|
||||||
|
#### Wave 0 — pyproject bump (lead-developer)
|
||||||
|
- **Task 0.1** (lead-developer): bump `pyproject.toml` version →
|
||||||
|
`1.29.0` (spec §7.2). Verify `nova --version` reports `1.29.0`.
|
||||||
|
|
||||||
|
#### Wave 1 — .gitea/ removal (lead-developer)
|
||||||
|
- **Task 1.1** (lead-developer): `rm -rf .gitea/` (7 workflow files +
|
||||||
|
README.md, RESEARCH §9d). Remove `scripts/sync_workflows.py` (the
|
||||||
|
byte-identical-forges generator — central removal target, D-232).
|
||||||
|
Remove Gitea references from `scripts/sync_to_nova.sh` (line 201:
|
||||||
|
`--exclude=/.gitea`) + `scripts/rotate_spike_key.sh` (Gitea API
|
||||||
|
secret upload). Scrub `terraform/bootstrap/` Gitea OIDC references
|
||||||
|
(the OIDC role for act_runner moves to nova-platform-ops; the
|
||||||
|
bootstrap here becomes archived reference).
|
||||||
|
|
||||||
|
#### Wave 2 — Gitea reference scrub (lead-developer)
|
||||||
|
- **Task 2.1** (lead-developer): `grep -rni gitea .github/ docs/
|
||||||
|
pyproject.toml README.md .ciagent/` — scrub all matches outside the
|
||||||
|
spec archive section (`.ciagent/REQUIREMENTS.md` §v1.29 + CLARIFY §v1.29
|
||||||
|
+ RESEARCH §v1.29 retain "Gitea" as historical/reference text; these
|
||||||
|
are the "spec archive section" exemption per REQ-367 AC 1). Update
|
||||||
|
`.github/workflows/ci.yml` to remove any Gitea-specific steps.
|
||||||
|
|
||||||
|
#### Wave 3 — forge_parity_disabled CI assertion (lead-developer)
|
||||||
|
- **Task 3.1** (lead-developer): add a CI step to `.github/workflows/ci.yml`
|
||||||
|
that asserts `forge_parity_disabled` — the step runs
|
||||||
|
`test ! -d .gitea/` and `! grep -rqi gitea .github/workflows/` and
|
||||||
|
exits 0 on success, non-zero with `forge_parity_disabled` message on
|
||||||
|
failure (REQ-367 AC 3, D-232). This is the deliberate CI failure that
|
||||||
|
documents the abandoned parity.
|
||||||
|
|
||||||
|
#### Wave 4 — decisions verification + ship (lead-developer)
|
||||||
|
- **Task 4.1** (lead-developer): verify D-232..238 + D-239/240 are
|
||||||
|
present in PROJECT.md + CLARIFY.md + REQUIREMENTS.md (REQ-368 AC 1-2,
|
||||||
|
already authored in P0; this task is a verification, not re-authoring).
|
||||||
|
Run full test suite; ship P2 → `v1.28.2`.
|
||||||
|
|
||||||
|
### Phase P3 — cfn-archive-tf-delegation (REQ-369)
|
||||||
|
|
||||||
|
**Goal:** Archive the CFN template in `nova/idp/setup.py` +
|
||||||
|
`core/lambda/nova_idp_setup.py` to `docs/archive/nova-idp-cfn-v1.28.md`
|
||||||
|
(read-only reference); `nova idp setup --apply` delegates to `terraform
|
||||||
|
apply` (the CLI detects terraform via `which terraform`; if absent,
|
||||||
|
falls back to the CFN path with a deprecation warning).
|
||||||
|
|
||||||
|
**Exit criterion:** `docs/archive/nova-idp-cfn-v1.28.md` exists +
|
||||||
|
contains the CFN template as read-only reference; `nova idp setup
|
||||||
|
--apply` invokes `terraform apply` when terraform is on PATH (tested
|
||||||
|
with a mock terraform binary); the CFN path emits a deprecation warning
|
||||||
|
when terraform is absent.
|
||||||
|
|
||||||
|
**Branch:** `phase/03-cfn-archive-tf-delegation`. **Tag:** `v1.28.3`.
|
||||||
|
|
||||||
|
#### Wave 0 — CFN archive (cli-engineer, backend-engineer)
|
||||||
|
- **Task 0.1** (backend-engineer): extract the CFN template from
|
||||||
|
`core/lambda/nova_idp_setup.py` + write it to
|
||||||
|
`docs/archive/nova-idp-cfn-v1.28.md` as a fenced code block with a
|
||||||
|
read-only header ("Archived at v1.29.0 — the active path is
|
||||||
|
`terraform apply` in `nova-platform-ops`. Deletion is a follow-up
|
||||||
|
after Terraform parity is verified.").
|
||||||
|
- **Task 0.2** (cli-engineer): mark the CFN generation code path in
|
||||||
|
`core/lambda/nova_idp_setup.py` as deprecated (add a
|
||||||
|
`DeprecationWarning` when the CFN path is invoked + a docstring
|
||||||
|
pointing to the archive + the terraform delegation path).
|
||||||
|
|
||||||
|
#### Wave 1 — terraform delegation (cli-engineer)
|
||||||
|
- **Task 1.1** (cli-engineer): modify `nova/idp/setup.py` `--apply` to
|
||||||
|
detect terraform via `shutil.which("terraform")`. If terraform is on
|
||||||
|
PATH: delegate to `subprocess.run(["terraform", "apply",
|
||||||
|
"-auto-approve"])` in the `nova-platform-ops` checkout (the operator
|
||||||
|
runs this from the ops repo root). If terraform is absent: fall back
|
||||||
|
to the CFN path with a `DeprecationWarning` ("CFN path is archived;
|
||||||
|
install terraform or use nova-platform-ops. See
|
||||||
|
docs/archive/nova-idp-cfn-v1.28.md.").
|
||||||
|
- **Task 1.2** (cli-engineer): add `nova idp setup --verify` delegation
|
||||||
|
to `terraform plan` (same `which terraform` detection). The verify
|
||||||
|
path runs `terraform plan` + reports the diff.
|
||||||
|
|
||||||
|
#### Wave 2 — tests (cli-engineer)
|
||||||
|
- **Task 2.1** (cli-engineer): author
|
||||||
|
`tests/test_idp_setup_tf_delegation.py` — test the `--apply` path
|
||||||
|
with a mock terraform binary on PATH (assert `subprocess.run` called
|
||||||
|
with `["terraform", "apply", "-auto-approve"]`); test the fallback
|
||||||
|
path with terraform absent (assert `DeprecationWarning` raised + CFN
|
||||||
|
path invoked); test `--verify` delegates to `terraform plan`.
|
||||||
|
|
||||||
|
#### Wave 3 — ship (lead-developer)
|
||||||
|
- **Task 3.1** (lead-developer): run full test suite; ship P3 →
|
||||||
|
`v1.28.3`.
|
||||||
|
|
||||||
|
### Phase P4 — operator-guide-reference-tracking (REQ-OPS-GUIDE)
|
||||||
|
|
||||||
|
**Goal:** `docs/operator-guide-platform-ops.md` covering KMS rotation,
|
||||||
|
JWKS reachability via CloudFront edge, PITR restore, PAT revocation,
|
||||||
|
edge configuration, Fargate standby health, cost section, artifact-
|
||||||
|
mirror fallback, and the M1/M1.5/M2 cutover gates as release-gate
|
||||||
|
entries for the covered-reference REQs. ARCHITECTURE.md §12.9. STATE.md
|
||||||
|
v1.29 CAPs + invariants. REQUIREMENTS.md covered-reference markers.
|
||||||
|
|
||||||
|
**Exit criterion:** operator guide exists + covers all sections per
|
||||||
|
REQ-OPS-GUIDE AC; ARCHITECTURE.md §12.9 added; STATE.md updated with
|
||||||
|
v1.29 rows; covered-reference REQs in REQUIREMENTS.md marked with their
|
||||||
|
cutover gate.
|
||||||
|
|
||||||
|
**Branch:** `phase/04-operator-guide-reference-tracking`. **Tag:**
|
||||||
|
`v1.28.4`.
|
||||||
|
|
||||||
|
#### Wave 0 — operator guide (lead-developer, data-engineer, security-engineer)
|
||||||
|
- **Task 0.1** (lead-developer): author
|
||||||
|
`docs/operator-guide-platform-ops.md` sections: (a) Overview + the
|
||||||
|
reposplit rationale (Vision §4); (b) Day-0 cutover procedure (M1
|
||||||
|
steps from spec §3.2 Journey 2); (c) M1.5 verification gate (8-item
|
||||||
|
spike, 3 consecutive rebuilds); (d) M2 operational handoff loop
|
||||||
|
(tag-pin bump → plan → HITL approval → apply); (e) M2a Fargate
|
||||||
|
activation (conditional on M1.5 failure); (f) Rollback procedure
|
||||||
|
(D-236 — revert `nova_platform_version` pin); (g) cost section (WAF
|
||||||
|
~$5-10/month + Fargate ~$15-20/month, REQ-363b AC 4); (h) artifact-
|
||||||
|
mirror fallback (operator-local mirror by SHA-256 when Gitea
|
||||||
|
act_runner cannot reach GitHub Releases, Edge 6).
|
||||||
|
- **Task 0.2** (data-engineer): author the operator guide data
|
||||||
|
sections: (a) DynamoDB PITR restore procedure (per-table); (b)
|
||||||
|
DynamoDB import addresses (nova-contracts, nova-change-requests,
|
||||||
|
nova-outbox, nova-users, nova-sessions, nova-pats — the
|
||||||
|
`importable-resources.tf` map, REQ-361 covered-reference); (c) audit
|
||||||
|
outbox bootstrap; (d) JWKS-ROTATION (24-hour overlap window on key
|
||||||
|
rotation).
|
||||||
|
- **Task 0.3** (security-engineer): author the operator guide security
|
||||||
|
sections: (a) KMS rotation (90-day cadence, `alias/nova-oidc-
|
||||||
|
signing`, `ECC_NIST_P256`, D-234); (b) JWKS reachability via
|
||||||
|
CloudFront edge (OAC pinning, `AuthType: AWS_IAM`, direct Function
|
||||||
|
URL → 403, INV-18); (c) PAT revocation (60s SLO, D-229); (d) edge
|
||||||
|
configuration (CloudFront + WAF + ACM + Route53 — REQ-364/365/366
|
||||||
|
covered-reference); (e) Fargate standby health checks (`GET /health`
|
||||||
|
every 10s, `KJ-WARMUP-HEALTH`, 3 consecutive probe failures → alert +
|
||||||
|
token-vend fails closed, REQ-363b AC 2); (f) Fargate sunset
|
||||||
|
discipline (D-237 — ≥30 consecutive days green before deletion +
|
||||||
|
architecture review); (g) IAM scope (IAM-NARROW, REQ-360 covered-
|
||||||
|
reference — no `Action: "*"` or `Resource: "*"`); (h) the
|
||||||
|
`route53_record_not_resolvable` debugging path (ACM cert status
|
||||||
|
check).
|
||||||
|
|
||||||
|
#### Wave 1 — covered-reference cutover gates (lead-developer)
|
||||||
|
- **Task 1.1** (lead-developer): add a "Cutover Gates" section to the
|
||||||
|
operator guide listing each covered-reference REQ (355, 356, 357,
|
||||||
|
358, 359, 360, 361, 362, 363, 363b, 364, 365, 366, 371) with its
|
||||||
|
gate entry (M1/M1.5/M2) + the verification command + a **"Result"
|
||||||
|
column** (grill CF-2/G-5). P6 audit verifies every covered-reference
|
||||||
|
REQ has a non-empty, green Result. Empty/red → P6 blocks. The Result
|
||||||
|
column is populated by the operator attestation (the operator runs
|
||||||
|
the verification command in `nova-platform-ops` CI + records the
|
||||||
|
outcome). This is the acdl-side evidence surface for covered-
|
||||||
|
reference REQs.
|
||||||
|
- **Task 1.2** (lead-developer): update REQUIREMENTS.md §v1.29 traceability
|
||||||
|
table — mark each covered-reference REQ with its cutover gate in the
|
||||||
|
Status column (e.g., `planned (M1 gate: nova-platform-ops)`).
|
||||||
|
|
||||||
|
#### Wave 2 — ARCHITECTURE.md + STATE.md (lead-developer)
|
||||||
|
- **Task 2.1** (lead-developer): add ARCHITECTURE.md §12.9 (Platform
|
||||||
|
Ops Reposplit) — the domain boundary (engineering ends at the
|
||||||
|
compiled artifact; operations begins at the live platform under
|
||||||
|
guardrails), the `kj` substrate (one ECR image digest, KJ-LOCKSTEP),
|
||||||
|
the covered-reference REQ tracking pattern, the operator guide
|
||||||
|
pointer.
|
||||||
|
- **Task 2.2** (lead-developer): update STATE.md — append v1.29
|
||||||
|
capability rows (CAP-039: platform-ops-reposplit, CAP-040:
|
||||||
|
kj-substrate-lockstep, CAP-041: jwks-edge-only) + bump invariants
|
||||||
|
(INV-18 JWKS-EDGE-ONLY + the 10 NFR constraints). Bump "Last
|
||||||
|
milestone ship" to v1.29 (pending).
|
||||||
|
|
||||||
|
#### Wave 3 — ship (lead-developer)
|
||||||
|
- **Task 3.1** (lead-developer): run full test suite; ship P4 →
|
||||||
|
`v1.28.4`.
|
||||||
|
|
||||||
|
### Phase P5 — consumer-deploy-bump (REQ-CONSUMER-BUMP, cross-project)
|
||||||
|
|
||||||
|
**Goal:** Bump `nova-blockchain-exchange` deploy.yml `@v1.25` → `@v1.29`
|
||||||
|
in both `.github/workflows/deploy.yml` + `.gitea/workflows/deploy.yml`
|
||||||
|
+ smoke test (sign-up → sign-in → token-vend → apply → audit against
|
||||||
|
v1.29 publish artifacts).
|
||||||
|
|
||||||
|
**Exit criterion:** both deploy.yml files reference `@v1.29`; smoke
|
||||||
|
test passes (the chain completes against v1.29 publish artifacts).
|
||||||
|
|
||||||
|
**Branch:** `nova-blockchain-exchange/phase/05-consumer-deploy-bump`
|
||||||
|
(cross-project, multi-project branch naming per branch-strategy.md).
|
||||||
|
**Tag:** `v1.28.5`.
|
||||||
|
|
||||||
|
#### Wave 0 — deploy.yml bump (lead-developer)
|
||||||
|
- **Task 0.1** (lead-developer): in the `nova-blockchain-exchange`
|
||||||
|
project, update `.github/workflows/deploy.yml` + `.gitea/workflows/
|
||||||
|
deploy.yml` `uses:` ref from `acdl/.github/workflows/deploy.yml@v1.25`
|
||||||
|
→ `@v1.29` (RESEARCH §9e — the consumer's `.gitea/` is out of scope
|
||||||
|
for the acdl REQ-367 scrub; the consumer may keep its Gitea mirror or
|
||||||
|
follow suit — this is a consumer-repo decision, not an acdl one).
|
||||||
|
|
||||||
|
#### Wave 1 — smoke test (lead-developer, security-engineer)
|
||||||
|
- **Task 1.1** (security-engineer): author
|
||||||
|
`nova-blockchain-exchange/tests/test_v1.29_smoke.py` — sign-up →
|
||||||
|
sign-in → token-vend → apply → audit chain against the v1.29 publish
|
||||||
|
artifacts (the consumer's contract → `deploy.yml@v1.29` mode=full →
|
||||||
|
apply → attest → record against `581513795199`). Uses the existing
|
||||||
|
CAP-025 round-trip assertion (v1.26).
|
||||||
|
- **Task 1.2** (lead-developer): run the smoke test; verify the chain
|
||||||
|
completes against the real v1.29.0 publish artifacts (produced by
|
||||||
|
P1's intermediate tag, grill CF-3/G-3). **No hedge** — the smoke
|
||||||
|
test MUST run against the published v1.29.x artifacts or P5 fails
|
||||||
|
closed. If the artifacts are not available (P1 did not push the
|
||||||
|
intermediate tag), P5 blocks until P1 re-ships.
|
||||||
|
|
||||||
|
#### Wave 2 — ship (lead-developer)
|
||||||
|
- **Task 2.1** (lead-developer): ship P5 → `v1.28.5`. The consumer
|
||||||
|
project ships independently (merge to the consumer's main, not
|
||||||
|
acdl's milestone branch).
|
||||||
|
|
||||||
|
### Phase P6 — final-review-ship (Final Phase)
|
||||||
|
|
||||||
|
**Goal:** Multi-persona code review across P1..P5; audit (reconstruction
|
||||||
|
test, branch hygiene, commit discipline, file discipline); milestone
|
||||||
|
ship (merge `phase/06` → `milestone/v1.29-reposplit-identity` → `main`;
|
||||||
|
tag `v1.28.6` = the v1.29 release; Gitea release; delete all milestone
|
||||||
|
branches); mark all v1.29 REQs complete in REQUIREMENTS.md + ROADMAP.md.
|
||||||
|
|
||||||
|
**Exit criterion:** review P0 issues auto-fixed, P1+ flagged; audit
|
||||||
|
PASS; milestone merged to main; tag `v1.28.6` created; Gitea release
|
||||||
|
published; milestone branches deleted; REQUIREMENTS.md + ROADMAP.md
|
||||||
|
marked complete.
|
||||||
|
|
||||||
|
**Branch:** `phase/06-final-review-ship`. **Tag:** `v1.28.6` =
|
||||||
|
milestone release.
|
||||||
|
|
||||||
|
#### Wave 0 — review (lead-developer)
|
||||||
|
- **Task 0.1** (lead-developer): delegate to `ciagent-review` —
|
||||||
|
multi-persona review (lead-developer, backend-engineer, security-
|
||||||
|
engineer, data-engineer, cli-engineer) across P1..P5. Auto-apply P0
|
||||||
|
fixes; flag P1+ for post-hoc review. If P1+ issues found: fix them
|
||||||
|
in this phase.
|
||||||
|
|
||||||
|
#### Wave 1 — audit (lead-developer)
|
||||||
|
- **Task 1.1** (lead-developer): delegate to `ciagent-audit` —
|
||||||
|
reconstruction test (git log ↔ `.ciagent/`), branch hygiene, commit
|
||||||
|
discipline, file discipline. If critical issues found: fix them in
|
||||||
|
this phase.
|
||||||
|
|
||||||
|
#### Wave 2 — milestone ship (lead-developer)
|
||||||
|
- **Task 2.1** (lead-developer): delegate to `ciagent-ship` — merge
|
||||||
|
`phase/06` → `milestone/v1.29-reposplit-identity` → `main`; tag
|
||||||
|
`v1.28.6`; Gitea release with full milestone summary; delete all
|
||||||
|
milestone branches (phase/00..06 + milestone/v1.29-reposplit-
|
||||||
|
identity).
|
||||||
|
|
||||||
|
#### Wave 3 — milestone completion (lead-developer)
|
||||||
|
- **Task 3.1** (lead-developer): update REQUIREMENTS.md (all v1.29 REQs
|
||||||
|
→ complete), ROADMAP.md (v1.29 → complete), NORTH_STAR.md (note
|
||||||
|
Strategic Objective — platform operations as a Terraform-controlled
|
||||||
|
discipline), STATE.md (bump "Last milestone ship" to v1.29, tag
|
||||||
|
`v1.28.6`). Commit `docs(milestone): complete v1.29-reposplit-
|
||||||
|
identity`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## User-Facing Surface
|
||||||
|
|
||||||
|
1. **CLI flag:** `nova idp setup --apply` now delegates to `terraform
|
||||||
|
apply` (REQ-369 AC 2) — the operator runs this from the
|
||||||
|
`nova-platform-ops` checkout. `nova idp setup --verify` delegates to
|
||||||
|
`terraform plan`.
|
||||||
|
2. **GitHub Release artifacts page:** each `v1.29.x` tag's GitHub
|
||||||
|
Release page lists the Lambda zip + layer wheel + Python wheel + ECR
|
||||||
|
image URI/digest with SHA-256 (REQ-354) — this is the engineering-
|
||||||
|
to-ops handoff surface (D-235 tag-pin handoff).
|
||||||
|
3. **Operator guide:** `docs/operator-guide-platform-ops.md` — the
|
||||||
|
operator-facing runbook covering KMS rotation, JWKS reachability,
|
||||||
|
PITR restore, PAT revocation, edge config, Fargate standby, cost,
|
||||||
|
artifact-mirror fallback, and the M1/M1.5/M2 cutover gates.
|
||||||
|
4. **CI assertion:** `forge_parity_disabled` — the deliberate CI
|
||||||
|
failure documenting the abandoned byte-identical-forges parity
|
||||||
|
(D-232, REQ-367 AC 3).
|
||||||
|
|
||||||
|
## Happy Path
|
||||||
|
|
||||||
|
**M1.5 verification gate (spec §3.3 Edge 5, 12-item spike — written
|
||||||
|
BEFORE execute, extended per grill CF-1):**
|
||||||
|
|
||||||
|
1. `kj` v0.0.3 (pinned SHA in `platform/abac/kj-version.txt`) compiles
|
||||||
|
with `CGO_ENABLED=0 GOOS=linux GOARCH=amd64`.
|
||||||
|
2. Resulting binary reports `file kj → ELF 64-bit LSB executable,
|
||||||
|
x86-64, statically linked, no shared library` (KJ-STATIC).
|
||||||
|
3. Container image built from
|
||||||
|
`public.ecr.aws/lambda/python:3.12-al2023` with the binary copied
|
||||||
|
to `/opt/kj/kj`, `chmod 0555`, owned by `sbx_user:1051`.
|
||||||
|
4. Lambda runtime `python3.12` executes
|
||||||
|
`nova_idp_token_vend.handler`; the handler invokes
|
||||||
|
`subprocess.run(['/opt/kj/kj', 'apply', ...])` and parses stdout
|
||||||
|
JSON.
|
||||||
|
5. `tests/test_idp_auth.py` passes against the live image in moto-DDB.
|
||||||
|
6. `tests/test_kms_roundtrip.py` passes against the live KMS key
|
||||||
|
(REQ-362 path — covered-reference, runs in nova-platform-ops CI).
|
||||||
|
7. End-to-end: known PAT → known ABAC-allowed action → signed OIDC
|
||||||
|
token → `jose` verification → green. Known PAT + ABAC-denied action
|
||||||
|
→ 403 with deny reason logged (INV-17).
|
||||||
|
8. Image URI is recorded in Terraform state and in the operator guide.
|
||||||
|
9. **(grill CF-1)** Direct JWKS Function URL → 403 / via-CloudFront →
|
||||||
|
200 (INV-18, JWKS-EDGE-ONLY — `AuthType: AWS_IAM` verified, not
|
||||||
|
prose).
|
||||||
|
10. **(grill CF-1)** IAM-NARROW: no `Action: "*"` or `Resource: "*"`
|
||||||
|
in the Gitea OIDC role effective permissions (REQ-360).
|
||||||
|
11. **(grill CF-1)** TFM-HITL: self-approval rejected —
|
||||||
|
`gitea.triggering_actor == pull_request.user.login` → apply fails
|
||||||
|
closed (REQ-357, INV-3).
|
||||||
|
12. **(grill CF-1)** Rollback drill — revert `nova_platform_version`
|
||||||
|
pin → prior digest runs (D-236 cutover shape + rollback procedure).
|
||||||
|
|
||||||
|
If items 1-7 fail three consecutive rebuilds, M2a activates REQ-363b
|
||||||
|
(Fargate toggle) with the same image — no warmup hit because the
|
||||||
|
standby is always running the same digest.
|
||||||
|
|
||||||
|
**HARD P6 SHIP GATE (grill CF-1/G-2.1):** P6 must not ship `v1.28.6`
|
||||||
|
until the operator guide contains an operator-attested "M1.5
|
||||||
|
Verification Gate Result" row (3 consecutive green rebuilds, run
|
||||||
|
IDs/SHAs, attestor identity). P6 audit verifies the row exists. The
|
||||||
|
M1.5 gate is verified in `nova-platform-ops` CI (out-of-band); the
|
||||||
|
operator attestation in the guide is the acdl-side evidence surface.
|
||||||
|
|
||||||
|
## UX Acceptance Criteria
|
||||||
|
|
||||||
|
1. **M1 acceptance gate (spec §2.3):** `terraform apply` from `main`
|
||||||
|
brings the live AWS account to a state where Nova-idp identity
|
||||||
|
tables exist, JWT-issuing paths are wired but not yet consuming
|
||||||
|
container images, JWKS infrastructure is in place, WAF + OAC pinning
|
||||||
|
the CloudFront edge; `acdl/acdl v1.29.0` ships with zero `.gitea/`
|
||||||
|
references and zero platform-infra files; D-232..238 recorded in
|
||||||
|
PROJECT.md/CLARIFY.
|
||||||
|
2. **M1.5 acceptance gate:** items 1-12 of the Edge 5 spike all green
|
||||||
|
on three consecutive rebuilds; image digest resolvable via
|
||||||
|
`data.aws_ecr_image.kj_image`; sign/verify round-trip passes; ABAC
|
||||||
|
fail-closed path verified against live policy; JWKS-EDGE-ONLY
|
||||||
|
verified (item 9); IAM-NARROW verified (item 10); TFM-HITL
|
||||||
|
self-approval rejected (item 11); rollback drill passes (item 12).
|
||||||
|
**HARD P6 ship gate** — operator-attested "M1.5 Verification Gate
|
||||||
|
Result" row in the operator guide (grill CF-1/G-2.1).
|
||||||
|
3. **M2 acceptance gate:** Bumping `local.nova_platform_version` in a
|
||||||
|
PR and merging it results in `terraform apply` updating both
|
||||||
|
`aws_lambda_function.nova_idp_token_vend.image_uri` and
|
||||||
|
`aws_ecs_task_definition.kj.container_definitions[0].image` to the
|
||||||
|
same digest (KJ-LOCKSTEP, REQ-371), with zero diff on KMS, DDB,
|
||||||
|
IAM, edge.
|
||||||
|
|
||||||
|
## Test evidence required for v1.29 release
|
||||||
|
|
||||||
|
- [ ] Code coverage ≥ 80% on new modules (the acdl-side files:
|
||||||
|
`publish.yml` changes, `nova/idp/setup.py` terraform delegation,
|
||||||
|
`docs/operator-guide-platform-ops.md` is docs — no coverage
|
||||||
|
requirement; the M1.5 gate tests).
|
||||||
|
- [ ] CI/CD pipeline GREEN for `acdl/acdl` (the `nova-platform-ops`
|
||||||
|
pipeline is out-of-band).
|
||||||
|
- [ ] M1.5 verification gate green: items 1-12 of §3.3 Edge 5 spike
|
||||||
|
pass on three consecutive rebuilds (covered-reference — verified
|
||||||
|
in nova-platform-ops CI; acdl authors the tests in P1; operator
|
||||||
|
attests in the guide, P4; P6 audit verifies the attestation row,
|
||||||
|
grill CF-1/G-2.1).
|
||||||
|
- [ ] Covered-reference REQs (355-366, 371) have non-empty, green
|
||||||
|
Result in the operator guide "Cutover Gates" section (grill
|
||||||
|
CF-2/G-5 — P6 audit verifies).
|
||||||
|
- [ ] `lifecycle.precondition` enforced on both image-bearing resources
|
||||||
|
(REQ-371 mechanical proof — covered-reference in
|
||||||
|
nova-platform-ops).
|
||||||
|
- [ ] Live KMS sign/verify round-trip verified in account
|
||||||
|
`581513795199` (covered-reference).
|
||||||
|
- [ ] Live ABAC sign/verify round-trip verified against the production
|
||||||
|
policy (covered-reference).
|
||||||
|
- [ ] Pilot consumer (`nova-blockchain-exchange`) smoke test green:
|
||||||
|
sign-up → sign-in → token-vend → apply → audit chain (P5).
|
||||||
|
- [ ] All existing capabilities (CAP-001..038) still pass the
|
||||||
|
regression gate.
|
||||||
|
- [ ] Drift-detection baseline: `terraform plan` exit 0 against live
|
||||||
|
AWS state, captured at cutover (covered-reference).
|
||||||
|
- [ ] `kj` standby Fargate task health `READY` before M1 cutover
|
||||||
|
(covered-reference, KJ-WARMUP-HEALTH).
|
||||||
|
- [ ] Fargate standby sunset discipline documented in operator-guide
|
||||||
|
(D-237, P4).
|
||||||
|
- [ ] `forge_parity_disabled` CI assertion passes (P2, REQ-367 AC 3).
|
||||||
|
- [ ] `grep -rni gitea .github/ docs/ pyproject.toml README.md
|
||||||
|
.ciagent/` returns zero matches outside the spec archive section
|
||||||
|
(P2, REQ-367 AC 1).
|
||||||
|
|
||||||
|
## Plan completeness checklist
|
||||||
|
|
||||||
|
- [x] Every REQ mapped to a phase + wave + task.
|
||||||
|
- [x] Covered-reference REQs identified + their verification surface
|
||||||
|
documented (operator guide P4, cutover gates).
|
||||||
|
- [x] Decisions D-232..240 referenced in the plan.
|
||||||
|
- [x] Invariants + NFR constraints referenced (KJ-STATIC, KJ-LOCKSTEP,
|
||||||
|
INV-18, etc.).
|
||||||
|
- [x] Personas assigned to every task (lead-developer, backend-engineer,
|
||||||
|
security-engineer, cli-engineer, data-engineer).
|
||||||
|
- [x] User-Facing Surface section (3 surfaces named).
|
||||||
|
- [x] Happy Path section (M1.5 8-item spike, written before execute).
|
||||||
|
- [x] UX Acceptance Criteria section (M1, M1.5, M2 gates).
|
||||||
|
- [x] Test evidence checklist.
|
||||||
|
- [x] Phase boundaries + tags (v1.28.0 → v1.28.6).
|
||||||
|
- [x] Cross-project phase (P5, nova-blockchain-exchange) identified.
|
||||||
|
|
||||||
|
## Cost envelope (v1.29)
|
||||||
|
|
||||||
|
Monthly estimate for the `nova-platform-ops` live platform (documented
|
||||||
|
in the operator guide, P4):
|
||||||
|
|
||||||
|
| Resource | Quantity | Est. monthly |
|
||||||
|
|----------|----------|-------------|
|
||||||
|
| WAF WebACL (CloudFront-scoped) | 1 | ~$5-10/month (+ per-request) |
|
||||||
|
| Fargate standby (0.25 vCPU, 512 MB) | 1 task | ~$15-20/month (REQ-363b AC 4) |
|
||||||
|
| KMS asymmetric key | 1 | ~$1/month |
|
||||||
|
| DynamoDB (on-demand, 7 tables) | 7 | ~$2/month (pilot volume) |
|
||||||
|
| DynamoDB PITR | 7 tables | ~$2/month |
|
||||||
|
| Lambda invocations (3 Lambdas) | 3 | ~$2/month |
|
||||||
|
| ECR image storage | ~100 MB | <$1/month |
|
||||||
|
| S3 state bucket + access logs | 1 | <$1/month |
|
||||||
|
| CloudFront + ACM + Route53 | 1 distribution | ~$1/month (ACM free) |
|
||||||
|
| **Total** | | **~$30-40/month** |
|
||||||
|
|
||||||
|
This is the pilot-scale ops cost envelope. The Fargate standby
|
||||||
|
(~$15-20/month) is the largest line item + is explicitly documented in
|
||||||
|
the operator guide (REQ-363b AC 4) with the D-237 sunset discipline
|
||||||
|
(≥30 consecutive days green before deletion + architecture review).
|
||||||
+134
-9
@@ -450,7 +450,7 @@ already exist).
|
|||||||
> Review: 0 P0. Audit: reconstruction PASS, file/branch/commit discipline CLEAN.
|
> Review: 0 P0. Audit: reconstruction PASS, file/branch/commit discipline CLEAN.
|
||||||
> Full phase detail: `.ciagent/archive/` (v1.27 artifacts) + git history.
|
> Full phase detail: `.ciagent/archive/` (v1.27 artifacts) + git history.
|
||||||
|
|
||||||
## v1.28 — CLI Canonicalization + Identity Layer (active)
|
## v1.28 — CLI Canonicalization + Identity Layer (complete, tag `v1.27.6`, merged to main 2026-08-19)
|
||||||
|
|
||||||
> **Feature milestone — active.** The Nova CLI becomes installable from
|
> **Feature milestone — active.** The Nova CLI becomes installable from
|
||||||
> internal PyPI (CodeArtifact), every `core/` module is reachable as a
|
> internal PyPI (CodeArtifact), every `core/` module is reachable as a
|
||||||
@@ -528,14 +528,139 @@ New requirements REQ-323..REQ-353 — full text in
|
|||||||
- `nova idp setup --apply` MUST present the CloudFormation template for
|
- `nova idp setup --apply` MUST present the CloudFormation template for
|
||||||
review before any resource is created (NFR-10).
|
review before any resource is created (NFR-10).
|
||||||
|
|
||||||
### v1.28 phase status (active — phase 0 in progress)
|
### v1.28 phase status (complete — tag `v1.27.6` = the v1.28 release)
|
||||||
|
|
||||||
|
- **P0** pre-execution → `v1.27.0` (complete).
|
||||||
|
- **P1..P5** execution phases → `v1.27.1..v1.27.5` (complete).
|
||||||
|
- **P6** final review + audit + milestone ship → `v1.27.6` = the v1.28
|
||||||
|
release (complete, merged to main 2026-08-19).
|
||||||
|
|
||||||
|
> Phase-by-phase task breakdown, wave ordering, and persona assignments:
|
||||||
|
> `.ciagent/PLAN.md` (retained). Authoritative resume state:
|
||||||
|
> `.ciagent/CHECKPOINT.json`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## v1.29 — Reposplit + Identity Layer Bring-Live (active, milestone branch `milestone/v1.29-reposplit-identity`)
|
||||||
|
|
||||||
|
> **Feature milestone — active.** v1.29 extracts all live platform
|
||||||
|
> components (Nova-idp Lambdas, KMS keys, DynamoDB tables, S3 state
|
||||||
|
> buckets, OIDC roles, JWKS, audit outbox bootstrap) from `acdl/acdl`
|
||||||
|
> into a dedicated Gitea-private Terraform repository
|
||||||
|
> (`nova-platform-ops`), brings Nova-idp live in account `581513795199`
|
||||||
|
> for the first time (code complete since v1.28, unverified-in-account at
|
||||||
|
> Phase 0), and standardizes `acdl/acdl` on GitHub. The split enforces
|
||||||
|
> Vision §4 domain boundaries architecturally: engineering ends at the
|
||||||
|
> compiled artifact; operations begins at the live platform under
|
||||||
|
> guardrails. Vision §5 "Narrow capability interfaces" shapes the
|
||||||
|
> substrate design — `kj` has exactly one identity (one ECR image
|
||||||
|
> digest), shared by both the production runtime and its defensive
|
||||||
|
> fallback, eliminating drift by construction (KJ-LOCKSTEP).
|
||||||
|
|
||||||
|
### Scope split (CLARIFY-grounded, full autonomy)
|
||||||
|
|
||||||
|
The spec creates a **separate** Gitea-private repo `nova-platform-ops`.
|
||||||
|
CIAgent runs inside `acdl`. The Terraform module code
|
||||||
|
(`networking`/`kms`/`identity`/`contract-ingest`/`bootstrap`/`edge`) is
|
||||||
|
authored **out-of-band** in `nova-platform-ops` (operator-owned). CIAgent
|
||||||
|
in `acdl` delivers only the acdl-side work and tracks the ops-side REQs
|
||||||
|
as **covered-reference** (verification surface = the M1/M1.5/M2 cutover
|
||||||
|
gates documented in the operator guide, not a missing test).
|
||||||
|
|
||||||
|
| In-acdl (CIAgent authors) | Covered-reference (nova-platform-ops) |
|
||||||
|
|---|---|
|
||||||
|
| REQ-354 (publish.yml + ECR image + Release) | REQ-355, 356, 357, 358 (ops CI/HITL/pin) |
|
||||||
|
| REQ-367 (Gitea scrub) | REQ-359 (Gitea-private repo) |
|
||||||
|
| REQ-368 (decisions D-232..238) | REQ-360 (IAM scope bounded) |
|
||||||
|
| REQ-369 (CFN archive + CLI `--apply` TF delegation) | REQ-361 (import idempotency) |
|
||||||
|
| Operator guide `docs/operator-guide-platform-ops.md` | REQ-362 (KMS key provisioning) |
|
||||||
|
| `platform/abac/kj-version.txt` | REQ-363, 363b (Lambda/Fargate substrate) |
|
||||||
|
| M1.5 verification gate tests | REQ-364, 365, 366 (JWKS/WAF/ACM edge) |
|
||||||
|
| nova-blockchain-exchange deploy.yml @v1.29 bump | REQ-371 `lifecycle.precondition` (TF-side) |
|
||||||
|
|
||||||
|
### v1.29 ID allocations (no collisions with shipped history)
|
||||||
|
|
||||||
|
- **Requirements:** `REQ-354..REQ-369` + `REQ-371` + `REQ-363b` (note:
|
||||||
|
REQ-370 is intentionally unused per the source spec). Max existing REQ
|
||||||
|
= REQ-353. REQ-363b is a sub-requirement of REQ-363 (Fargate defensive
|
||||||
|
fallback, same ECR image — KJ-LOCKSTEP).
|
||||||
|
- **Decisions:** `D-232..D-238` (7 decisions, authored in CLARIFY) +
|
||||||
|
`D-239..D-240` (2 research-derived spec corrections). Max existing D
|
||||||
|
= D-231.
|
||||||
|
- **Invariants:** `INV-18` (JWKS-EDGE-ONLY — proposed in spec §5, promoted
|
||||||
|
here). Plus non-invariant NFRs carried as constraints: KJ-STATIC,
|
||||||
|
KJ-LOCKSTEP, KJ-WARMUP-HEALTH, OPER-PRIV, IAM-NARROW, DRIFT-DETECT,
|
||||||
|
IMPORT-IDEMPOTENT, TFM-HITL, JWKS-SLO, JWKS-ROTATION. Max existing INV
|
||||||
|
= INV-17.
|
||||||
|
- **`kj` here is the Go binary** (`platform/abac/kj-version.txt`, pinned
|
||||||
|
v0.0.3), NOT the kyverno-json engine. v1.28 re-mapped the spec's `kj`
|
||||||
|
engine → kyverno-json (D-227). v1.29 reintroduces `kj` as a **compiled
|
||||||
|
Go binary** embedded in the ECR container image — a distinct artifact.
|
||||||
|
No collision: kyverno-json remains the policy engine (INV-4); `kj` is a
|
||||||
|
static binary invoked via `subprocess` by the Lambda handler.
|
||||||
|
|
||||||
|
### v1.29 Requirements
|
||||||
|
|
||||||
|
New requirements REQ-354..REQ-369 + REQ-371 + REQ-363b — full text in
|
||||||
|
`.ciagent/REQUIREMENTS.md` §v1.29. Summary by phase:
|
||||||
|
|
||||||
|
- **P1 — Publish Pipeline (REQ-354):** `publish.yml` attaches Lambda zip
|
||||||
|
+ layer wheel + Python wheel + ECR container image (static `kj`,
|
||||||
|
`CGO_ENABLED=0`, tag `v1.29.x+kj-<sha>`) to GitHub Release with SHA-256.
|
||||||
|
- **P2 — Gitea Scrub + Decisions (REQ-367, REQ-368):** remove `.gitea/`,
|
||||||
|
scrub all Gitea refs, `forge_parity_disabled` CI assertion, pyproject
|
||||||
|
→ 1.29.0, record D-232..238.
|
||||||
|
- **P3 — CFN Archive + TF Delegation (REQ-369):** archive CFN template →
|
||||||
|
`docs/archive/nova-idp-cfn-v1.28.md`, `nova idp setup --apply` delegates
|
||||||
|
to `terraform apply`.
|
||||||
|
- **P4 — Operator Guide + Reference Tracking:** `docs/operator-guide-
|
||||||
|
platform-ops.md`, ARCHITECTURE.md §12.9, STATE.md v1.29 CAPs +
|
||||||
|
invariants; REQUIREMENTS.md covered-reference markers.
|
||||||
|
- **P5 — Consumer Deploy Bump (cross-project, Edge 8):** `nova-
|
||||||
|
blockchain-exchange` deploy.yml `@v1.25` → `@v1.29` + smoke test.
|
||||||
|
- **P6 — Final Review + Audit + Milestone Ship.**
|
||||||
|
|
||||||
|
### v1.29 Hard constraints
|
||||||
|
|
||||||
|
- DO NOT activate pilot qa/prod/dr environments (D-208/D-209 — separate
|
||||||
|
initiative). M1 brings Nova-idp live; env activation is out.
|
||||||
|
- DO NOT add S3 Object Lock / JWS tamper-resistance (D-083). Tamper-
|
||||||
|
evidence via SQLite hash-chain remains.
|
||||||
|
- DO NOT restore 73.8% coverage — separate NFR milestone; YELLOW carried
|
||||||
|
without scope expansion.
|
||||||
|
- DO NOT provision CodeArtifact — direct GitHub Releases artifact fetch.
|
||||||
|
- DO NOT delete the CFN template in `acdl/acdl` at v1.29.0 — archive as
|
||||||
|
read-only reference (`docs/archive/nova-idp-cfn-v1.28.md`); deletion is
|
||||||
|
a follow-up after Terraform parity is verified.
|
||||||
|
- DO NOT add Nova-idp feature work (new OIDC claims, new ABAC rules) —
|
||||||
|
bring live; don't extend.
|
||||||
|
- DO NOT add MFA/TOTP, WebAuthn, upstream IdP federation (Vision §7).
|
||||||
|
- DO NOT add a CloudFront Frontend (L3B consumer surface) — pure ops
|
||||||
|
focus only.
|
||||||
|
- The `kj` binary MUST be compiled `CGO_ENABLED=0` and verified statically
|
||||||
|
linked (`file(1)`) before embedding (KJ-STATIC).
|
||||||
|
- The ECR image digest on the Fargate standby MUST equal the Lambda
|
||||||
|
`image_uri` digest at every `terraform plan` (KJ-LOCKSTEP, REQ-371 —
|
||||||
|
fail-closed by `lifecycle.precondition` mechanism, not by discipline).
|
||||||
|
- The JWKS endpoint is the ONLY public read surface; all other platform
|
||||||
|
endpoints gate with `AuthType: AWS_IAM` (JWKS-EDGE-ONLY, INV-18).
|
||||||
|
- Any `terraform apply` against `main` in `nova-platform-ops` MUST require
|
||||||
|
a Gitea Actions approval from a user distinct from the PR author
|
||||||
|
(TFM-HITL, INV-3 applied at platform level).
|
||||||
|
- `nova-platform-ops` MUST be `private: true` in Gitea, not mirrored
|
||||||
|
(OPER-PRIV).
|
||||||
|
|
||||||
|
### v1.29 phase status (active — phase 0 in progress)
|
||||||
|
|
||||||
- **P0** pre-execution (SPECIFY→CLARIFY→RESEARCH→PLAN→GRILL→MVP/UX) — in
|
- **P0** pre-execution (SPECIFY→CLARIFY→RESEARCH→PLAN→GRILL→MVP/UX) — in
|
||||||
progress, target tag `v1.27.0`.
|
progress, target tag `v1.28.0`.
|
||||||
- **P1..PN** execution phases — planned in PLAN.md.
|
- **P1..P5** execution phases — planned in PLAN.md.
|
||||||
- **P(N+1)** final review + audit + milestone ship — target tag
|
- **P6** final review + audit + milestone ship — target tag
|
||||||
`v1.27.(N+1)` = the v1.28 release.
|
`v1.28.6` = the v1.29 release.
|
||||||
|
|
||||||
> Phase-by-phase task breakdown, wave ordering, and persona assignments
|
> Tags run on the **v1.28.x** line: `v1.28.0` (P0) →
|
||||||
> will live in `.ciagent/PLAN.md`. Authoritative resume state:
|
> `v1.28.1..v1.28.5` (execution phases) → `v1.28.6` (final phase =
|
||||||
> `.ciagent/CHECKPOINT.json`.
|
> milestone release). Milestone branch:
|
||||||
|
> `milestone/v1.29-reposplit-identity`. Phase-by-phase task breakdown,
|
||||||
|
> wave ordering, and persona assignments will live in `.ciagent/PLAN.md`.
|
||||||
|
> Authoritative resume state: `.ciagent/CHECKPOINT.json`.
|
||||||
+278
-32
@@ -301,7 +301,7 @@ Full v1.26 requirement text:
|
|||||||
`.ciagent/nova-blockchain-exchange/REQUIREMENTS.md`. Active phase plan:
|
`.ciagent/nova-blockchain-exchange/REQUIREMENTS.md`. Active phase plan:
|
||||||
`.ciagent/PLAN.md`.
|
`.ciagent/PLAN.md`.
|
||||||
|
|
||||||
## v1.28 — CLI Canonicalization + Identity Layer (active)
|
## v1.28 — CLI Canonicalization + Identity Layer (complete, tag `v1.27.6`, merged to main 2026-08-19)
|
||||||
|
|
||||||
> **Feature milestone — active.** The Nova CLI is installable from
|
> **Feature milestone — active.** The Nova CLI is installable from
|
||||||
> internal PyPI (CodeArtifact); every `core/` module is reachable as a
|
> internal PyPI (CodeArtifact); every `core/` module is reachable as a
|
||||||
@@ -571,34 +571,280 @@ All v1.28 release-gate criteria in PLAN.md §6 met.
|
|||||||
|
|
||||||
| REQ | Phase | Status |
|
| REQ | Phase | Status |
|
||||||
|-----|-------|--------|
|
|-----|-------|--------|
|
||||||
| REQ-323 | P1 | planned |
|
| REQ-323 | P1 | complete (v1.27.1) |
|
||||||
| REQ-324 | P1 | planned |
|
| REQ-324 | P1 | complete (v1.27.1) |
|
||||||
| REQ-325 | P1 | planned |
|
| REQ-325 | P1 | complete (v1.27.1) |
|
||||||
| REQ-326 | P1 | planned |
|
| REQ-326 | P1 | complete (v1.27.1) |
|
||||||
| REQ-327 | P1 | planned |
|
| REQ-327 | P1 | complete (v1.27.1) |
|
||||||
| REQ-328 | P1 | planned |
|
| REQ-328 | P1 | complete (v1.27.1) |
|
||||||
| REQ-329 | P2 | planned |
|
| REQ-329 | P2 | complete (v1.27.2) |
|
||||||
| REQ-330 | P2 | planned |
|
| REQ-330 | P2 | complete (v1.27.2) |
|
||||||
| REQ-331 | P2 | planned |
|
| REQ-331 | P2 | complete (v1.27.2) |
|
||||||
| REQ-332 | P2 | planned |
|
| REQ-332 | P2 | complete (v1.27.2) |
|
||||||
| REQ-333 | P3 | planned |
|
| REQ-333 | P3 | complete (v1.27.3) |
|
||||||
| REQ-334 | P3 | planned |
|
| REQ-334 | P3 | complete (v1.27.3) |
|
||||||
| REQ-335 | P3 | planned |
|
| REQ-335 | P3 | complete (v1.27.3) |
|
||||||
| REQ-336 | P4 | planned |
|
| REQ-336 | P4 | complete (v1.27.4) |
|
||||||
| REQ-337 | P4 | planned |
|
| REQ-337 | P4 | complete (v1.27.4) |
|
||||||
| REQ-338 | P4 | planned |
|
| REQ-338 | P4 | complete (v1.27.4) |
|
||||||
| REQ-339 | P4 | planned |
|
| REQ-339 | P4 | complete (v1.27.4) |
|
||||||
| REQ-340 | P4 | planned |
|
| REQ-340 | P4 | complete (v1.27.4) |
|
||||||
| REQ-341 | P4 | planned |
|
| REQ-341 | P4 | complete (v1.27.4) |
|
||||||
| REQ-342 | P4 | planned |
|
| REQ-342 | P4 | complete (v1.27.4) |
|
||||||
| REQ-343 | P4 | planned |
|
| REQ-343 | P4 | complete (v1.27.4) |
|
||||||
| REQ-344 | P4 | planned |
|
| REQ-344 | P4 | complete (v1.27.4) |
|
||||||
| REQ-345 | P5 | planned |
|
| REQ-345 | P5 | complete (v1.27.5) |
|
||||||
| REQ-346 | P5 | planned |
|
| REQ-346 | P5 | complete (v1.27.5) |
|
||||||
| REQ-347 | P5 | planned |
|
| REQ-347 | P5 | complete (v1.27.5) |
|
||||||
| REQ-348 | P5 | planned |
|
| REQ-348 | P5 | complete (v1.27.5) |
|
||||||
| REQ-349 | P5 | planned |
|
| REQ-349 | P5 | complete (v1.27.5) |
|
||||||
| REQ-350 | P5 | planned |
|
| REQ-350 | P5 | complete (v1.27.5) |
|
||||||
| REQ-351 | P5 | planned |
|
| REQ-351 | P5 | complete (v1.27.5) |
|
||||||
| REQ-352 | P6 | planned |
|
| REQ-352 | P6 | complete (v1.27.6) |
|
||||||
| REQ-353 | P6 | planned |
|
| REQ-353 | P6 | complete (v1.27.6) |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## v1.29 — Reposplit + Identity Layer Bring-Live (active, milestone branch `milestone/v1.29-reposplit-identity`)
|
||||||
|
|
||||||
|
> **Feature milestone — active.** v1.29 extracts all live platform
|
||||||
|
> components into a dedicated Gitea-private Terraform repository
|
||||||
|
> (`nova-platform-ops`), brings Nova-idp live in account `581513795199`
|
||||||
|
> for the first time, and standardizes `acdl/acdl` on GitHub. `kj` (a
|
||||||
|
> compiled Go binary, pinned v0.0.3, distinct from the kyverno-json
|
||||||
|
> engine) has exactly one identity: one ECR image digest shared by the
|
||||||
|
> production Lambda runtime and its defensive Fargate fallback
|
||||||
|
> (KJ-LOCKSTEP, REQ-371).
|
||||||
|
>
|
||||||
|
> Tags run on the **v1.28.x** line: `v1.28.0` (P0) →
|
||||||
|
> `v1.28.1..v1.28.5` (execution) → `v1.28.6` (final = milestone release).
|
||||||
|
> Milestone branch: `milestone/v1.29-reposplit-identity`.
|
||||||
|
>
|
||||||
|
> **Scope split (CLARIFY-grounded, full autonomy):** Terraform module
|
||||||
|
> code is authored out-of-band in `nova-platform-ops`. REQs marked
|
||||||
|
> `[covered-reference]` have their verification surface in the
|
||||||
|
> `nova-platform-ops` cutover gates (M1/M1.5/M2), documented in the
|
||||||
|
> operator guide (`docs/operator-guide-platform-ops.md`). CIAgent in
|
||||||
|
> `acdl` authors only the acdl-side REQs.
|
||||||
|
|
||||||
|
### Decisions (locked in CLARIFY — full autonomy, load-bearing for v1.29)
|
||||||
|
|
||||||
|
- **D-232 (Forge parity abandoned):** the byte-identical-forges CI parity
|
||||||
|
(Gitea + GitHub) is abandoned; `acdl/acdl` standardizes on GitHub. CI
|
||||||
|
fails with `forge_parity_disabled` (deliberate). Rationale: Vision §4
|
||||||
|
domain boundaries — operations lives in Gitea-private `nova-platform-
|
||||||
|
ops`, engineering lives on GitHub.
|
||||||
|
- **D-233 (JWKS public-read via CloudFront edge):** the JWKS endpoint is
|
||||||
|
the only public read surface of the live platform (INV-18). All other
|
||||||
|
platform endpoints gate with `AuthType: AWS_IAM`. CloudFront + OAC
|
||||||
|
pinning replaces direct Lambda Function URL exposure.
|
||||||
|
- **D-234 (KMS asymmetric key provisioning):** `alias/nova-oidc-signing`
|
||||||
|
provisioned with `KeySpec: ECC_NIST_P256`, `KeyUsage: SIGN_VERIFY`,
|
||||||
|
90-day rotation cadence (matches per-stack CMK rotation per D-069).
|
||||||
|
- **D-235 (Tag-pin handoff):** engineering hands off to operations via
|
||||||
|
tags. `acdl/acdl` `publish.yml` attaches artifacts to GitHub Releases
|
||||||
|
per tag; `nova-platform-ops` declares `local.nova_platform_version` +
|
||||||
|
`local.kj_source_sha` and resolves substrates through a single
|
||||||
|
`data.aws_ecr_image.kj_image`.
|
||||||
|
- **D-236 (Cutover shape + rollback procedure):** M1 day-0 cutover is
|
||||||
|
conditional on M1.5 verification gate (3 consecutive rebuilds, 12-item
|
||||||
|
spike per grill CF-1). Rollback = revert `nova_platform_version` pin;
|
||||||
|
the prior tag's artifacts remain downloadable. M2a (Fargate toggle)
|
||||||
|
activates only if M1.5 fails 3×.
|
||||||
|
- **D-237 (Fargate sunset discipline):** the always-warm minimal Fargate
|
||||||
|
standby (REQ-363b, ~$15–20/month) may not be deleted unless REQ-363 has
|
||||||
|
been green in production for ≥30 consecutive days. Sunset requires an
|
||||||
|
architecture review.
|
||||||
|
- **D-238 (KJ-LOCKSTEP release-gate invariant):** the ECR image digest
|
||||||
|
running on the Fargate standby MUST equal the digest resolved by
|
||||||
|
`aws_lambda_function.nova_idp_token_vend.image_uri` at every
|
||||||
|
`terraform plan`. Enforced by `lifecycle.precondition` (mechanism) +
|
||||||
|
Gitea Actions `if: steps.plan.outcome == 'success'` (mechanism) + PR
|
||||||
|
comment reporting (observability) + operator review (last, never
|
||||||
|
first). No second pipeline, no second SHA pin. Vision §6 immutability
|
||||||
|
+ Vision §5 narrow interfaces.
|
||||||
|
|
||||||
|
### P1 — Publish Pipeline
|
||||||
|
|
||||||
|
#### REQ-354 — `publish.yml` attaches Lambda zip + layer wheel + Python wheel + ECR container image to GitHub Release for each tag
|
||||||
|
**Journeys:** J1, J2 (criteria 3–4). **Priority:** High.
|
||||||
|
**AC:**
|
||||||
|
**(1)** Given a tag `v1.29.x` is pushed to `acdl/acdl` main, when
|
||||||
|
`publish.yml` runs, then the release artifacts `nova-lambda-token-vend-
|
||||||
|
v1.29.x.zip`, `nova-cli-layer-v1.29.x.zip`, and `nova-1.29.x-py3-none-
|
||||||
|
any.whl` appear in GitHub Releases with matching SHA-256 in the body.
|
||||||
|
**(2)** Given two consecutive tags `v1.29.0` and `v1.29.1`, when both
|
||||||
|
releases are queried, then each tag's artifacts are independent and the
|
||||||
|
previous tag's artifacts remain downloadable.
|
||||||
|
**(3)** Given the publish pipeline runs for tag `v1.29.x`, when the
|
||||||
|
image build step executes, then a single ECR image is pushed at tag
|
||||||
|
`v1.29.x-kj-<kj-source-sha>` where `<kj-source-sha>` is read from
|
||||||
|
`platform/abac/kj-version.txt` at build time and embedded in the tag
|
||||||
|
(D-239: ECR tags reject `+`; corrected from `v1.29.x+kj-<sha>` to
|
||||||
|
`v1.29.x-kj-<sha>`).
|
||||||
|
**(4)** Given the image is pushed, when the GitHub Release body lists
|
||||||
|
artifacts, then the image URI and digest appear alongside the wheel,
|
||||||
|
layer, and Lambda zip. KJ-STATIC: the `kj` binary is compiled
|
||||||
|
`CGO_ENABLED=0 GOOS=linux GOARCH=amd64` and `file(1)` reports
|
||||||
|
`statically linked, no shared library` before embedding.
|
||||||
|
|
||||||
|
### P2 — Gitea Scrub + Decisions
|
||||||
|
|
||||||
|
#### REQ-367 — Hard scrub of all Gitea references in `acdl/acdl` at v1.29.0
|
||||||
|
**Journeys:** Cross-cutting. **Priority:** Critical.
|
||||||
|
**AC:**
|
||||||
|
**(1)** Given v1.29.0 is cut from main, when `grep -rni gitea .github/
|
||||||
|
docs/ pyproject.toml README.md .ciagent/` runs, then zero matches
|
||||||
|
outside this spec's archive section.
|
||||||
|
**(2)** Given v1.29.0 ships, when `.gitea/` is checked in the working
|
||||||
|
tree, then `find .gitea` returns nothing.
|
||||||
|
**(3)** Given v1.29.0 ships, when the bit-identical-forges parity is
|
||||||
|
asserted in CI, then CI fails with `forge_parity_disabled` (deliberate;
|
||||||
|
documented in D-232).
|
||||||
|
|
||||||
|
#### REQ-368 — Decisions D-232..238 recorded in PROJECT.md + CLARIFY
|
||||||
|
**Journeys:** Cross-cutting. **Priority:** High.
|
||||||
|
**AC:**
|
||||||
|
**(1)** Given the milestone is recorded, when loading `PROJECT.md`, then
|
||||||
|
decisions D-232 (forge parity abandoned), D-233 (JWKS public-read via
|
||||||
|
CloudFront edge), D-234 (KMS asymmetric key provisioning), D-235 (tag-
|
||||||
|
pin handoff), D-236 (cutover shape + rollback procedure), D-237
|
||||||
|
(Fargate sunset discipline ≥30 days → architecture review), D-238
|
||||||
|
(KJ-LOCKSTEP release-gate invariant) are present with rationale citing
|
||||||
|
Vision §4 domain boundaries.
|
||||||
|
**(2)** Given decisions are present, then each decision references the
|
||||||
|
source statement from the v1.29 spec.
|
||||||
|
|
||||||
|
### P3 — CFN Archive + TF Delegation
|
||||||
|
|
||||||
|
#### REQ-369 — CFN → Terraform conversion of `nova idp setup`
|
||||||
|
**Journeys:** J2. **Priority:** High.
|
||||||
|
**AC:**
|
||||||
|
**(1)** Given the CFN template in `acdl/acdl/nova/idp/setup.py`, when
|
||||||
|
the equivalent Terraform in `nova-platform-ops` runs, then the same
|
||||||
|
resources (Lambdas, DDB tables, IAM roles, KMS key references) are
|
||||||
|
created. [covered-reference: nova-platform-ops]
|
||||||
|
**(2)** Given the conversion, when a new operator runs `nova idp setup
|
||||||
|
--apply`, then the CLI delegates to `terraform apply`; the CFN code
|
||||||
|
path is no longer the active path.
|
||||||
|
**(3)** Given the conversion, the CFN file in `acdl/acdl` is archived
|
||||||
|
to `docs/archive/nova-idp-cfn-v1.28.md` as read-only reference;
|
||||||
|
deletion is a follow-up.
|
||||||
|
|
||||||
|
### P4 — Operator Guide + Reference Tracking (docs)
|
||||||
|
|
||||||
|
#### REQ-OPS-GUIDE — `docs/operator-guide-platform-ops.md`
|
||||||
|
**Journeys:** J2. **Priority:** High.
|
||||||
|
**AC:** Given the operator guide is published, when an operator reads
|
||||||
|
it, then it covers: KMS rotation (90-day cadence, `alias/nova-oidc-
|
||||||
|
signing`), JWKS reachability via CloudFront edge (OAC pinning, public
|
||||||
|
read vs. IAM-gated), PITR restore (DynamoDB point-in-time recovery),
|
||||||
|
PAT revocation (60s SLO), edge configuration (CloudFront + WAF + ACM +
|
||||||
|
Route53), Fargate standby status checks (`GET /health` every 10s,
|
||||||
|
`KJ-WARMUP-HEALTH`), cost section (WAF ~$5–10/month + Fargate
|
||||||
|
~$15–20/month), artifact-mirror fallback (operator-local mirror by
|
||||||
|
SHA-256 when Gitea `act_runner` cannot reach GitHub Releases), and the
|
||||||
|
M1/M1.5/M2 cutover gates as release-gate entries for the covered-
|
||||||
|
reference REQs.
|
||||||
|
|
||||||
|
### P5 — Consumer Deploy Bump (cross-project, Edge 8)
|
||||||
|
|
||||||
|
#### REQ-CONSUMER-BUMP — `nova-blockchain-exchange` deploy.yml `@v1.25` → `@v1.29`
|
||||||
|
**Journeys:** J1. **Priority:** High.
|
||||||
|
**AC:**
|
||||||
|
**(1)** Given `nova-blockchain-exchange` deploy.yml pins
|
||||||
|
`acdl/.github/workflows/deploy.yml@v1.25`, when the bump is applied,
|
||||||
|
then both `.github/workflows/deploy.yml` and
|
||||||
|
`.gitea/workflows/deploy.yml` reference `@v1.29`.
|
||||||
|
**(2)** Given the bump, when the smoke test runs (sign-up → sign-in →
|
||||||
|
token-vend → apply → audit), then the chain completes successfully
|
||||||
|
against the v1.29 publish artifacts.
|
||||||
|
|
||||||
|
### Covered-reference requirements (authored in `nova-platform-ops`, out-of-band)
|
||||||
|
|
||||||
|
The following REQs are tracked for milestone completeness but their
|
||||||
|
code lands in `nova-platform-ops`. Their verification surface is the
|
||||||
|
M1/M1.5/M2 cutover gates documented in the operator guide.
|
||||||
|
|
||||||
|
- **REQ-355** — ops repo pins `local.nova_platform_version` +
|
||||||
|
`local.kj_source_sha`; CI resolves matching artifacts + image digest.
|
||||||
|
- **REQ-356** — ops repo CI runs `terraform plan` on every PR; drift
|
||||||
|
fails with `drift_detected`.
|
||||||
|
- **REQ-357** — HITL approver distinct from PR author required for
|
||||||
|
`terraform apply` (INV-3, TFM-HITL).
|
||||||
|
- **REQ-358** — Operator bumps `nova_platform_version` to roll out
|
||||||
|
engineering change; `CodeSha256` matches the artifact SHA-256.
|
||||||
|
- **REQ-359** — ops repo is Gitea-private with no GitHub mirror
|
||||||
|
(OPER-PRIV).
|
||||||
|
- **REQ-360** — ops repo IAM scope is bounded; no AdministratorAccess
|
||||||
|
(IAM-NARROW).
|
||||||
|
- **REQ-361** — Terraform imports existing live resources idempotently
|
||||||
|
(IMPORT-IDEMPOTENT).
|
||||||
|
- **REQ-362** — `alias/nova-oidc-signing` KMS key provisioned
|
||||||
|
(`ECC_NIST_P256`, `SIGN_VERIFY`, 90-day rotation).
|
||||||
|
- **REQ-363** — Nova-idp 3 Lambdas deployed on container image with
|
||||||
|
static `kj` (production substrate, KJ-STATIC).
|
||||||
|
- **REQ-363b** — Fargate defensive fallback — always-warm minimal
|
||||||
|
Fargate standby, **same ECR image** (KJ-LOCKSTEP, KJ-WARMUP-HEALTH).
|
||||||
|
- **REQ-364** — JWKS Function URL reachable only via CloudFront with
|
||||||
|
OAC pinning (INV-18, JWKS-EDGE-ONLY).
|
||||||
|
- **REQ-365** — WAF WebACL rate-limit (3000/5min) + AWS Managed Rules.
|
||||||
|
- **REQ-366** — ACM cert + Route53 alias for the JWKS domain.
|
||||||
|
- **REQ-371** — KJ-LOCKSTEP applied-at-plan mechanism
|
||||||
|
(`lifecycle.precondition` on both image-bearing resources; fail-closed
|
||||||
|
by mechanism, not by discipline).
|
||||||
|
|
||||||
|
### v1.29 Invariants + NFR constraints (new)
|
||||||
|
|
||||||
|
- **INV-18 (JWKS-EDGE-ONLY):** the JWKS endpoint is the only public read
|
||||||
|
surface of the live platform. All other platform endpoints MUST gate
|
||||||
|
with `AuthType: AWS_IAM`.
|
||||||
|
- **KJ-STATIC (NFR):** `kj` compiled `CGO_ENABLED=0`; `file(1)` reports
|
||||||
|
`statically linked, no shared library`; SHA-256 matches
|
||||||
|
`platform/abac/kj-version.txt`; recorded in Terraform state.
|
||||||
|
- **KJ-LOCKSTEP (NFR):** Fargate standby digest == Lambda `image_uri`
|
||||||
|
digest at every `terraform plan`. Detected by
|
||||||
|
`lifecycle.precondition` (mechanism) + CI `if:
|
||||||
|
steps.plan.outcome == 'success'` (mechanism) + PR comment
|
||||||
|
(observability) + operator review (last). No second pipeline, no
|
||||||
|
second SHA pin.
|
||||||
|
- **KJ-WARMUP-HEALTH (NFR):** Fargate standby `READY` probe (`GET /health
|
||||||
|
→ 200` every 10s) green before M1 cutover; release-gate entry.
|
||||||
|
- **OPER-PRIV (NFR):** `nova-platform-ops` `private: true`, not mirrored.
|
||||||
|
- **IAM-NARROW (NFR):** Gitea OIDC role bounded per REQ-360; no
|
||||||
|
`Action: "*"` or `Resource: "*"`.
|
||||||
|
- **DRIFT-DETECT (NFR):** `terraform plan` exit 2 (drift) fails the
|
||||||
|
apply workflow; manual reconciliation required.
|
||||||
|
- **IMPORT-IDEMPOTENT (NFR):** re-import exits non-zero with
|
||||||
|
`resource_already_imported`.
|
||||||
|
- **TFM-HITL (NFR):** `terraform apply` against `main` requires Gitea
|
||||||
|
Actions approval from a user distinct from the PR author.
|
||||||
|
- **JWKS-SLO (NFR):** `GET /.well-known/jwks.json` P95 < 200ms same-
|
||||||
|
region; `Cache-Control: max-age=3600` honored.
|
||||||
|
- **JWKS-ROTATION (NFR):** on key rotation, both old + new public keys
|
||||||
|
published during 24-hour overlap window.
|
||||||
|
|
||||||
|
### v1.29 Traceability (live — see CHECKPOINT.json for authoritative state)
|
||||||
|
|
||||||
|
| REQ | Phase | Status |
|
||||||
|
|-----|-------|--------|
|
||||||
|
| REQ-354 | P1 | planned |
|
||||||
|
| REQ-367 | P2 | planned |
|
||||||
|
| REQ-368 | P2 | planned |
|
||||||
|
| REQ-369 | P3 | planned |
|
||||||
|
| REQ-OPS-GUIDE | P4 | planned |
|
||||||
|
| REQ-CONSUMER-BUMP | P5 | planned |
|
||||||
|
| REQ-355 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-356 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-357 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-358 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-359 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-360 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-361 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-362 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-363 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-363b | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-364 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-365 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-366 | covered-reference | planned (nova-platform-ops) |
|
||||||
|
| REQ-371 | covered-reference | planned (nova-platform-ops) |
|
||||||
+255
-1
@@ -333,4 +333,258 @@ greenfield files: `nova/` CLI package, `platform/abac/token-vend.policy`,
|
|||||||
All 11 research questions answered with cited findings + concrete
|
All 11 research questions answered with cited findings + concrete
|
||||||
recommendations + risks. D-228 amended (fail-closed, not pure-Python
|
recommendations + risks. D-228 amended (fail-closed, not pure-Python
|
||||||
fallback). The `kj` binary packaging is the highest-risk item (P2
|
fallback). The `kj` binary packaging is the highest-risk item (P2
|
||||||
spike). Next: PLAN.
|
spike). Next: PLAN.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
# Nova — v1.29 Research Findings
|
||||||
|
|
||||||
|
> Phase: research (pre-execution). Milestone: v1.29 (Reposplit + Identity
|
||||||
|
> Layer Bring-Live). Status: research. Researcher: ci-researcher.
|
||||||
|
> Autonomy: full.
|
||||||
|
>
|
||||||
|
> Research delegated to the ci-researcher subagent (10 topics — Terraform
|
||||||
|
> import idempotency, `data.aws_ecr_image` digest resolution,
|
||||||
|
> `lifecycle.precondition`, CloudFront OAC for Lambda Function URL, WAF
|
||||||
|
> on CloudFront, ACM DNS validation + Route53 alias, `kj` Go binary
|
||||||
|
> static build, ECR tag format, codebase inspection, Gitea Actions HITL).
|
||||||
|
> This file is the curated summary. Key findings + recommendations below.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## §1 — Terraform `import` idempotency (REQ-361)
|
||||||
|
|
||||||
|
- `terraform import <addr> <id>` reads an existing cloud resource into
|
||||||
|
state without modifying it; the resource must have a matching
|
||||||
|
`resource` block in config.
|
||||||
|
- Re-importing an address already in state fails with **`Error: Resource
|
||||||
|
already managed by Terraform`** (non-zero exit). The CI import step
|
||||||
|
must treat this specific error as idempotent success (grep the
|
||||||
|
message, not just exit code) — this is the IMPORT-IDEMPOTENT contract.
|
||||||
|
- `importable-resources.tf` is a convention (not built-in): a dedicated
|
||||||
|
file listing resource addresses imported from the live account (S3
|
||||||
|
state bucket, DynamoDB tables, IAM OIDC role, KMS keys) so the import
|
||||||
|
surface is enumerable + reviewable.
|
||||||
|
- Drift detection: `terraform plan -detailed-exitcode` (exit 2 = drift)
|
||||||
|
fails the apply; the state bucket is bootstrapped manually then
|
||||||
|
imported (never created by Terraform — avoids bootstrapping the
|
||||||
|
bootstrapper, Q1/§7.1, D-235).
|
||||||
|
|
||||||
|
**Recommendation:** `nova-platform-ops` maintains an
|
||||||
|
`importable-resources.tf` map; CI import treats "already managed" as
|
||||||
|
idempotent success; `plan -detailed-exitcode` asserts zero drift.
|
||||||
|
|
||||||
|
## §2 — `data.aws_ecr_image` digest resolution (REQ-355, REQ-371)
|
||||||
|
|
||||||
|
- `data "aws_ecr_image" "kj_image" { repository_name = …; image_tag = … }`
|
||||||
|
resolves the tag to an **immutable `sha256:` digest** via
|
||||||
|
`image_digest`.
|
||||||
|
- ECR tags are mutable by default (a re-push moves a tag → different
|
||||||
|
digest). KJ-LOCKSTEP pins on `image_digest`, never the tag.
|
||||||
|
- `image_uri` = `${data.aws_ecr_repository.kj.repository_url}@${data.aws_ecr_image.kj_image.image_digest}`
|
||||||
|
— pinning by `@digest`, not `:tag`. Both Lambda and Fargate reference
|
||||||
|
the same data source → same digest by construction.
|
||||||
|
- `data.aws_ecr_image` reads at plan time; if the tag doesn't exist
|
||||||
|
(engineering hasn't published), the data source fails the plan (Q7
|
||||||
|
fail-closed).
|
||||||
|
|
||||||
|
**Recommendation:** Both image-bearing resources reference a single
|
||||||
|
`data.aws_ecr_image.kj_image`; `image_uri` = `repo@digest`; LOCKSTEP is
|
||||||
|
true by construction + the precondition (§3) is a verification.
|
||||||
|
|
||||||
|
## §3 — `lifecycle.precondition` — the KJ-LOCKSTEP mechanism (REQ-371)
|
||||||
|
|
||||||
|
- **Version correction (D-240):** preconditions introduced in
|
||||||
|
**Terraform v1.2.0 (May 2022)**, NOT v1.4+ as the spec implies. The
|
||||||
|
ops repo `required_version = ">= 1.2.0"` suffices.
|
||||||
|
- Syntax: `precondition` block inside `lifecycle { … }` for resources.
|
||||||
|
Evaluated **before** the resource action (during planning); a failing
|
||||||
|
precondition aborts the **plan** with the custom `error_message`.
|
||||||
|
- `error_message` is a string expression — can interpolate values:
|
||||||
|
`error_message = "KJ-LOCKSTEP: Fargate='${aws_ecs_task_definition.kj.image}' canonical='${data.aws_ecr_image.kj_image.image_digest}'"`.
|
||||||
|
- Asserting two attributes resolve to the same value:
|
||||||
|
```hcl
|
||||||
|
lifecycle {
|
||||||
|
precondition {
|
||||||
|
condition = self.image_uri == "${data.aws_ecr_repository.kj.repository_url}@${data.aws_ecr_image.kj_image.image_digest}"
|
||||||
|
error_message = "KJ-LOCKSTEP: Lambda image does not match the resolved ECR digest"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
**Pitfalls:** precondition blocks cannot reference `count`/`for_each`
|
||||||
|
unexpanded resources; both resources must depend on the same data source
|
||||||
|
(explicit `depends_on` if `image_uri` is computed indirectly).
|
||||||
|
|
||||||
|
**Recommendation:** Add `lifecycle { precondition { … } }` to **both**
|
||||||
|
the Lambda and Fargate task; set `required_version = ">= 1.2.0"`.
|
||||||
|
|
||||||
|
## §4 — CloudFront OAC pinning to Lambda Function URL (D-233, REQ-364)
|
||||||
|
|
||||||
|
- **Critical:** CloudFront OAC for a Lambda Function URL origin requires
|
||||||
|
`AuthType: AWS_IAM` on the Function URL (NOT `AuthType: NONE`). With
|
||||||
|
`AWS_IAM`, direct access returns 403 unless SigV4-signed; CloudFront +
|
||||||
|
OAC signs requests on the viewer's behalf → CloudFront 200, direct 403
|
||||||
|
(INV-18 JWKS-EDGE-ONLY).
|
||||||
|
- OAC resource: `OriginAccessControlOriginType = "lambda"`,
|
||||||
|
`SigningBehavior = "always"`, `SigningProtocol = "sigv4"`. Attach via
|
||||||
|
`OriginAccessControlId` on the origin block; HTTPS only.
|
||||||
|
- Resource-based permission: `aws lambda add-permission --action
|
||||||
|
lambda:InvokeFunctionUrl --principal cloudfront.amazonaws.com
|
||||||
|
--source-arn <distribution ARN>` — binds the Function URL to the
|
||||||
|
specific distribution.
|
||||||
|
- OAC replaces the deprecated S3-origin OAI; for Lambda origins, OAC is
|
||||||
|
the only signing mechanism.
|
||||||
|
|
||||||
|
**Pitfall:** if `AuthType: NONE` is left on the Function URL, OAC signing
|
||||||
|
is ignored and the URL stays public — the 403 guarantee evaporates.
|
||||||
|
|
||||||
|
**Recommendation:** JWKS Function URL `authorization_type = "AWS_IAM"`,
|
||||||
|
`lambda`-type OAC (`SigningBehavior: always`), `lambda:InvokeFunctionUrl`
|
||||||
|
permission scoped to the distribution ARN.
|
||||||
|
|
||||||
|
## §5 — WAF WebACL rate-limit + AWS Managed Rules on CloudFront (REQ-365)
|
||||||
|
|
||||||
|
- Rate-based rule: `RateBasedStatement` with `Limit: 3000`,
|
||||||
|
`AggregateKeyType: "IP"`, `EvaluationWindowSec: 300` (5-min window;
|
||||||
|
accepted values 60/120/300/600). WAF checks ~every 10s.
|
||||||
|
- AWS Managed Rules Common Rule Set = managed rule group
|
||||||
|
`AWSManagedRulesCommonRuleSet` (vendor `AWS`), attached as a separate
|
||||||
|
priority from the rate rule.
|
||||||
|
- CloudFront WebACLs **must** be created in `us-east-1` with
|
||||||
|
`Scope = "CLOUDFRONT"` (regional WebACLs cannot associate with
|
||||||
|
CloudFront).
|
||||||
|
- CloudWatch metrics: per-rule `VisibilityConfig.CloudWatchMetricsEnabled
|
||||||
|
= true`; S3 access logs via `aws_cloudfront_distribution.logging_config`.
|
||||||
|
|
||||||
|
**Recommendation:** WebACL in `us-east-1` `Scope=CLOUDFRONT`; rate rule
|
||||||
|
(3000/5min/IP) + Common Rule Set; associate to JWKS distribution;
|
||||||
|
CloudWatch metrics + S3 access logs.
|
||||||
|
|
||||||
|
## §6 — ACM cert DNS validation + Route53 alias (REQ-366)
|
||||||
|
|
||||||
|
- ACM DNS validation: `aws_acm_certificate` with
|
||||||
|
`validation_method = "DNS"`; create `aws_route53_record` for each
|
||||||
|
`domain_validation_options` CNAME; `aws_acm_certificate_validation`
|
||||||
|
waits on `ISSUED`. For CloudFront, the cert **must** be in
|
||||||
|
`us-east-1`.
|
||||||
|
- Route53 alias: `type = "A"`, `alias { name =
|
||||||
|
aws_cloudfront_distribution.jwks.domain_name; zone_id =
|
||||||
|
aws_cloudfront_distribution.jwks.hosted_zone_id;
|
||||||
|
evaluate_target_health = false }`.
|
||||||
|
- `route53_record_not_resolvable` failure mode: the alias doesn't
|
||||||
|
resolve until CloudFront `status = Deployed` AND ACM cert `ISSUED`. If
|
||||||
|
the validation CNAME is mis-created or Route53 is not authoritative,
|
||||||
|
the CNAME never validates → cert stays `PENDING_VALIDATION` → alias
|
||||||
|
NXDOMAIN.
|
||||||
|
|
||||||
|
**Recommendation:** ACM cert in `us-east-1` DNS validation; validation
|
||||||
|
CNAMEs in the authoritative Route53 zone; `aws_acm_certificate_validation`
|
||||||
|
gates on `ISSUED`; Route53 A-alias to the distribution. Operator guide
|
||||||
|
documents the `route53_record_not_resolvable` → check-cert-status
|
||||||
|
debugging path.
|
||||||
|
|
||||||
|
## §7 — `kj` Go binary static build for AL2023 Lambda (KJ-STATIC, REQ-354, REQ-363)
|
||||||
|
|
||||||
|
- Build: `CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags="-s
|
||||||
|
-w" -o kj ./…`. `CGO_ENABLED=0` is load-bearing — no cgo, no dynamic
|
||||||
|
libc link.
|
||||||
|
- `file(1)` must report `ELF 64-bit LSB executable, x86-64, statically
|
||||||
|
linked` + absence of `shared library`/`interpreter`. Secondary:
|
||||||
|
`readelf -d kj` shows no `NEEDED` entries.
|
||||||
|
- Base image `public.ecr.aws/lambda/python:3.12-al2023`; copy binary to
|
||||||
|
`/opt/kj/kj` `chmod 0555` owned by `sbx_user:1051` (Lambda sandbox
|
||||||
|
user, uid/gid 1051 in AL2023). `0555` + immutable-owned prevents
|
||||||
|
runtime tampering.
|
||||||
|
- Lambda handler invokes `subprocess.run(['/opt/kj/kj', 'apply', …],
|
||||||
|
capture_output=True, check=True)` — `kj` is a substrate binary, not a
|
||||||
|
library; the Python handler is a thin shim. kyverno-json (INV-4) is
|
||||||
|
separate + unaffected.
|
||||||
|
|
||||||
|
**Pitfall:** `CGO_ENABLED=1` (default on systems with gcc) produces a
|
||||||
|
dynamically-linked binary; AL2023 glibc mismatch → runtime
|
||||||
|
`GLIBC_X not found`. `CGO_ENABLED=0` eliminates this.
|
||||||
|
|
||||||
|
**Recommendation:** `publish.yml` P1 builds with `CGO_ENABLED=0
|
||||||
|
GOOS=linux GOARCH=amd64`, asserts `file` reports `statically linked` +
|
||||||
|
no `shared library` (fail build otherwise), copies to `/opt/kj/kj`
|
||||||
|
`chmod 0555`, handler calls `subprocess.run(['/opt/kj/kj', 'apply', …])`.
|
||||||
|
|
||||||
|
## §8 — ECR image tag format (REQ-354 AC 3) — SPEC CORRECTION (D-239)
|
||||||
|
|
||||||
|
- **ECR image tags do NOT allow `+`.** The ECR tag regex is
|
||||||
|
`^[a-zA-Z0-9]+(?:[._-][a-zA-Z0-9]+)*$` — permitted chars
|
||||||
|
`[a-zA-Z0-9._-]` only; `+` is rejected by `PutImage`/`BatchGetImage`
|
||||||
|
with `InvalidParameterException`.
|
||||||
|
- The spec's tag format `v1.29.x+kj-<sha>` is **invalid** as written.
|
||||||
|
Correct format: **`v1.29.x-kj-<sha>`** (replace `+` with `-`).
|
||||||
|
- The digest is the immutable trust surface regardless of the tag string
|
||||||
|
— a re-tag is detectable only via digest mismatch. The tag is a human
|
||||||
|
hint, not a security boundary.
|
||||||
|
|
||||||
|
**Decision D-239 (spec correction):** REQ-354 AC 3 tag format corrected
|
||||||
|
to `v1.29.x-kj-<sha>`. Confidence 0.95. Applied to REQUIREMENTS.md
|
||||||
|
§v1.29 REQ-354 AC (3).
|
||||||
|
|
||||||
|
## §9 — Codebase inspection (actual file paths)
|
||||||
|
|
||||||
|
| Target | Path | Summary |
|
||||||
|
|---|---|---|
|
||||||
|
| `publish.yml` | `.github/workflows/publish.yml` (165 lines) + `.gitea/workflows/publish.yml` mirror | Currently publishes wheel + Lambda layer on `push: branches: [main]` (NOT tag-triggered). P1 must change trigger to `on: push: tags: ['v1.29.*']` + attach Lambda zip + ECR image to GitHub Releases. |
|
||||||
|
| `nova/idp/setup.py` CFN | `nova/idp/setup.py` (40 lines, thin CLI dispatcher) + `core/lambda/nova_idp_setup.py` (actual CFN logic, importlib-loaded because `lambda` is reserved) | REQ-369 archives to `docs/archive/nova-idp-cfn-v1.28.md`; `--apply` delegates to `terraform apply`. |
|
||||||
|
| `platform/abac/kj-version.txt` | `platform/abac/kj-version.txt` (2 lines: `v0.0.3` + SHA `4ebb9a19...`) | Already pins `kj` v0.0.3 + source SHA from v1.28 P4. P1 reads this SHA to embed in the ECR tag + verify the build. |
|
||||||
|
| `.gitea/` scrub targets | `.gitea/workflows/` (7 files) + `scripts/sync_workflows.py` (line 26: `GITEA_DIR`), `scripts/sync_to_nova.sh`, `scripts/rotate_spike_key.sh`, `terraform/bootstrap/`, ~100 `.ciagent/` doc matches | REQ-367 P2 removes `.gitea/`, scrubs `gitea` from `.github/` `docs/` `pyproject.toml` `README.md` `.ciagent/`, asserts `forge_parity_disabled` in CI (D-232). `sync_workflows.py` is the central removal target. |
|
||||||
|
| Consumer `deploy.yml` | NOT in `acdl/.github/workflows/deploy.yml` (that's the platform reusable workflow). Consumer's deploy.yml is in the `nova-blockchain-exchange` project — documented at `.ciagent/nova-blockchain-exchange/REQUIREMENTS.md` (REQ-314) + `.ciagent/nova-blockchain-exchange/README.md`. | P5 bumps consumer's `uses:` ref `@v1.25` → `@v1.29` in both `.github/workflows/deploy.yml` + `.gitea/workflows/deploy.yml` (consumer's `.gitea/` is out of scope for REQ-367 — that scrub is `acdl/acdl` only) + smoke test. |
|
||||||
|
|
||||||
|
## §10 — Gitea Actions HITL approval (REQ-357, TFM-HITL)
|
||||||
|
|
||||||
|
- Gitea Actions has **no Environments API** with required reviewers. The
|
||||||
|
approval signal is `gitea.actor` (triggering user) +
|
||||||
|
`gitea.triggering_actor` (may differ on re-run — the re-dispatcher).
|
||||||
|
- PR author: `${{ gitea.event.pull_request.user.login }}`. INV-3 check:
|
||||||
|
`${{ gitea.triggering_actor }} != ${{ gitea.event.pull_request.user.login }}`
|
||||||
|
(use `triggering_actor` for re-run safety).
|
||||||
|
- Gitea scoped-workflows (v1.27+) supports **required workflows** that
|
||||||
|
gate PR merges via status checks — but this gates *merge*, not *apply*.
|
||||||
|
- The `workflow_dispatch` approve-input pattern (D-042) is the mechanism:
|
||||||
|
plan runs automatically on PR; apply is a separate `workflow_dispatch`
|
||||||
|
with `approve_apply` input; the apply job asserts INV-3 + fails closed.
|
||||||
|
- **Codebase precedent:** `core/hitl_gates.py` + `core/separation_of_duties.py`
|
||||||
|
(D-042) — `hitl_gates.attest(env, approver)` reads
|
||||||
|
`GITHUB_ACTOR`/`FORGE_ACTOR`, writes to DynamoDB outbox;
|
||||||
|
`separation_of_duties.check` compares approvers. This is the production
|
||||||
|
pattern to extend for `nova-platform-ops` `terraform apply`.
|
||||||
|
|
||||||
|
**Pitfalls:** scoped-workflow required-check enforcement needs branch
|
||||||
|
protection on `main`; a re-run changes `gitea.actor` to the re-dispatcher
|
||||||
|
— use `gitea.triggering_actor` for the effective approver.
|
||||||
|
|
||||||
|
**Recommendation:** `nova-platform-ops` uses `workflow_dispatch`
|
||||||
|
approve-input pattern (extending `hitl_gates.py`/`separation_of_duties.py`);
|
||||||
|
plan auto-runs on PR, apply is `workflow_dispatch` with `approve_apply`;
|
||||||
|
apply job asserts `${{ gitea.triggering_actor }} != ${{ gitea.event.pull_request.user.login }}`;
|
||||||
|
branch protection on `main` + required scoped-workflow status check.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## New decisions for the decision ledger (research-derived)
|
||||||
|
|
||||||
|
| D-ID | Title | Confidence | Source |
|
||||||
|
|---|---|---|---|
|
||||||
|
| **D-239** | ECR tag format `v1.29.x+kj-<sha>` invalid (`+` not in ECR tag regex) → corrected to `v1.29.x-kj-<sha>` | 0.95 | §8 ECR API PutImage character class |
|
||||||
|
| **D-240** | `lifecycle.precondition` introduced in Terraform v1.2.0 (not v1.4+); ops repo `required_version = ">= 1.2.0"` suffices | 0.98 | §3 Terraform v1.2.0 CHANGELOG |
|
||||||
|
|
||||||
|
Both are spec-vs-reality corrections logged at full autonomy (confidence
|
||||||
|
≥ 0.60 threshold). D-239 is applied to REQUIREMENTS.md §v1.29 REQ-354
|
||||||
|
AC (3). D-240 is documented in the operator guide (P4) for the
|
||||||
|
`nova-platform-ops` `required_version` floor.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## RESEARCH complete
|
||||||
|
|
||||||
|
All 10 research questions answered with cited findings + concrete
|
||||||
|
recommendations + risks. Two spec corrections (D-239 ECR tag, D-240
|
||||||
|
Terraform precondition floor). The highest-risk item is the M1.5
|
||||||
|
verification gate (Q7 carry-forward — `kj` static build + 3 consecutive
|
||||||
|
rebuilds in `nova-platform-ops` CI). Next: PLAN.
|
||||||
@@ -94,6 +94,58 @@
|
|||||||
checkpoint. 3 phases (P0 pre-execution + P1 author-archive + P2
|
checkpoint. 3 phases (P0 pre-execution + P1 author-archive + P2
|
||||||
fix-stale-wire + P3 final-review-ship). No REQ-NNN (NFR).
|
fix-stale-wire + P3 final-review-ship). No REQ-NNN (NFR).
|
||||||
|
|
||||||
|
- **v1.28:** complete (tag `v1.27.6`) — CLI Canonicalization + Identity
|
||||||
|
Layer. Feature milestone. The Nova CLI is installable from internal
|
||||||
|
PyPI (CodeArtifact); every `core/` module is reachable as a `nova
|
||||||
|
<subcommand>` (15 subcommands, argparse-only, ≤50-line thin delegates,
|
||||||
|
CAP-033/034); `nova init` scaffolds `.nova/`; `nova cli-action`
|
||||||
|
composite action published to GitHub + Gitea (byte-identical, NFR-11);
|
||||||
|
`core/mode_resolver.py` (flag → env → credential type →
|
||||||
|
`sys.stdin.isatty()`, D-226); INV-12 audit emission on every
|
||||||
|
invocation. Nova owns its identity layer end-to-end (Nova-idp):
|
||||||
|
`nova-idp-auth` Lambda (sign-up/sign-in/session, Argon2id t=3 m=65536
|
||||||
|
p=1, fail-closed D-228), `nova-idp-token-vend` Lambda (KMS-signed
|
||||||
|
OIDC tokens, ECDSA P-256 / ES256, DER→raw conversion, kyverno-json
|
||||||
|
ABAC fail-closed C-6.1), `nova-idp-jwks` Lambda (JWKS endpoint),
|
||||||
|
`nova-pats` DynamoDB (PAT lifecycle, strong-read revocation D-229,
|
||||||
|
60s SLO), `nova auth login/revoke/status`, `nova idp setup
|
||||||
|
--check/--apply/--verify` (CloudFormation, NFR-10 explicit approval).
|
||||||
|
No AWS-managed identity (INV-15). 31 requirements (REQ-323..353), 6
|
||||||
|
capabilities (CAP-033..038), 6 invariants (INV-12..17), 6 decisions
|
||||||
|
(D-226..231). 6 execution phases (P1 cli-substrate, P2
|
||||||
|
lambda-packaging, P3 idp-auth, P4 token-vend-pat + idp-setup folded
|
||||||
|
C-2.1, P5 docs-integration, P6 final-review-ship). Grill:
|
||||||
|
PROCEED-WITH-CONDITIONS (0.76), 3 critical fixes (ABAC fail-closed,
|
||||||
|
JWS KDF, traceability drift) + 16 tracked conditions applied. 1000
|
||||||
|
tests passing. Tags: `v1.27.0` (P0) → `v1.27.1..v1.27.5` (P1..P5) →
|
||||||
|
`v1.27.6` (P6 final = milestone release).
|
||||||
|
|
||||||
|
- **v1.29 (active, milestone branch `milestone/v1.29-reposplit-
|
||||||
|
identity`):** Reposplit + Identity Layer Bring-Live. Feature milestone.
|
||||||
|
v1.29 extracts all live platform components (Nova-idp Lambdas, KMS keys,
|
||||||
|
DynamoDB tables, S3 state buckets, OIDC roles, JWKS, audit outbox
|
||||||
|
bootstrap) from `acdl/acdl` into a dedicated Gitea-private Terraform
|
||||||
|
repository (`nova-platform-ops`), brings Nova-idp live in account
|
||||||
|
`581513795199` for the first time (code complete since v1.28, unverified
|
||||||
|
in-account at Phase 0), and standardizes `acdl/acdl` on GitHub. The
|
||||||
|
split enforces Vision §4 domain boundaries architecturally —
|
||||||
|
engineering ends at the compiled artifact; operations begins at the
|
||||||
|
live platform under guardrails. `kj` (a compiled Go binary, pinned
|
||||||
|
v0.0.3 in `platform/abac/kj-version.txt`, distinct from the kyverno-json
|
||||||
|
engine) has exactly one identity: one ECR image digest shared by both
|
||||||
|
the production Lambda runtime and its defensive Fargate fallback
|
||||||
|
(KJ-LOCKSTEP — drift eliminated by construction, enforced by
|
||||||
|
`lifecycle.precondition` at plan time, REQ-371). M1.5 verification gate
|
||||||
|
(8-item spike, 3 consecutive rebuilds) gates M1 cutover. CIAgent in
|
||||||
|
`acdl` delivers the acdl-side work (publish.yml + ECR image, Gitea
|
||||||
|
scrub, CFN archive + CLI terraform-delegation, operator guide,
|
||||||
|
consumer deploy bump); the Terraform modules for `nova-platform-ops`
|
||||||
|
are authored out-of-band (covered-reference REQs with cutover gates as
|
||||||
|
the verification surface). 17 requirements (REQ-354..369 + 371 +
|
||||||
|
363b), 7 decisions (D-232..238), 1 invariant (INV-18 JWKS-EDGE-ONLY) +
|
||||||
|
10 NFR constraints. Tags: `v1.28.0` (P0) → `v1.28.1..v1.28.5` (P1..P5)
|
||||||
|
→ `v1.28.6` (P6 final = milestone release).
|
||||||
|
|
||||||
> **Full v1.0–v1.24 phase detail, wave ordering, success criteria, and
|
> **Full v1.0–v1.24 phase detail, wave ordering, success criteria, and
|
||||||
> decision cross-references:** `.ciagent/archive/ROADMAP-v1.0-v1.24.md`.
|
> decision cross-references:** `.ciagent/archive/ROADMAP-v1.0-v1.24.md`.
|
||||||
|
|
||||||
|
|||||||
+217
-5
@@ -11,10 +11,17 @@
|
|||||||
> *why*, read `NORTH_STAR.md`. For *how*, read `ARCHITECTURE.md`. For
|
> *why*, read `NORTH_STAR.md`. For *how*, read `ARCHITECTURE.md`. For
|
||||||
> *what was decided*, read `PROJECT.md` load-bearing decisions.
|
> *what was decided*, read `PROJECT.md` load-bearing decisions.
|
||||||
>
|
>
|
||||||
> **Last milestone ship:** v1.27 (`v1.26.3`, 2026-08-19) — PO State Catalog
|
> **Last milestone ship:** v1.28 (`v1.27.6`, 2026-08-19) — CLI
|
||||||
> & Ciagent Compression NFR milestone. No new capabilities this
|
> Canonicalization + Identity Layer. Feature milestone: Nova CLI
|
||||||
> milestone (NFR); v1.27 authored this file + compressed `.ciagent/`.
|
> installable from CodeArtifact; 15 `nova <subcommand>` subcommands;
|
||||||
> **Next update:** at v1.28 ship.
|
> `nova init` scaffolding; `nova cli-action` composite action;
|
||||||
|
> `core/mode_resolver.py` (D-226); Nova-idp identity layer
|
||||||
|
> (`nova-idp-auth` + `nova-idp-token-vend` + `nova-idp-jwks` Lambdas;
|
||||||
|
> Argon2id; KMS-signed OIDC ES256; kyverno-json ABAC fail-closed; PAT
|
||||||
|
> lifecycle; `nova idp setup`; `nova auth login/revoke/status`). No
|
||||||
|
> AWS-managed identity (INV-15). 6 new capabilities (CAP-033..038),
|
||||||
|
> 6 new invariants (INV-12..17), 6 decisions (D-226..231).
|
||||||
|
> **Next update:** at v1.29 ship.
|
||||||
|
|
||||||
## How to use this file (PO)
|
## How to use this file (PO)
|
||||||
|
|
||||||
@@ -80,6 +87,29 @@
|
|||||||
path deferred (D-126). Multi-cloud deferred. Multi-validator BFT
|
path deferred (D-126). Multi-cloud deferred. Multi-validator BFT
|
||||||
deferred. The pilot runs `mode: full` for `dev` only (D-209); qa/prod/dr
|
deferred. The pilot runs `mode: full` for `dev` only (D-209); qa/prod/dr
|
||||||
stay placeholder (D-208, blocked by the pilot-readiness policy).
|
stay placeholder (D-208, blocked by the pilot-readiness policy).
|
||||||
|
- **INV-12 (Mode observability, v1.28):** Every CLI invocation emits a
|
||||||
|
`cli.invocation` audit event containing `mode`, `selection_reason`,
|
||||||
|
`credential_type`, `command`, and `args`. Operators can debug mode
|
||||||
|
selection without reproducing.
|
||||||
|
- **INV-13 (Mode resolution determinism, v1.28):** Resolution priority
|
||||||
|
is flag → env (`NOVA_CLIENT_MODE`) → credential type →
|
||||||
|
`sys.stdin.isatty()`. No silent fallbacks. Invalid env values are
|
||||||
|
ignored + warned. Deviations rejected at PR time.
|
||||||
|
- **INV-14 (Credential type encodes role, v1.28):** `developer_pat` /
|
||||||
|
`nova_oidc_token` + TTY present → `interactive`; TTY absent → `agent`.
|
||||||
|
- **INV-15 (No AWS-managed identity in path, v1.28):** Nova-idp MUST
|
||||||
|
NOT depend on Cognito, IAM Identity Center, or any AWS-managed
|
||||||
|
identity service. Greenfield constraint (no Cognito existed to
|
||||||
|
"drop").
|
||||||
|
- **INV-16 (Password storage, v1.28):** Passwords hashed with Argon2id
|
||||||
|
(t=3, m=65536 KiB, p=1). Fail-closed on `ImportError` (D-228 amended
|
||||||
|
— no pure-Python fallback). Raw passwords never in logs/traces/env/
|
||||||
|
DynamoDB.
|
||||||
|
- **INV-17 (ABAC discipline, v1.28):** The token-vend Lambda evaluates
|
||||||
|
the kyverno-json ABAC policy before signing. Fail-closed on `kj`
|
||||||
|
absence or evaluation error (C-6.1 — never fail open). Allow/deny +
|
||||||
|
policy inputs emitted to the audit stream. `policy_version` (git SHA,
|
||||||
|
D-231) recorded in every event.
|
||||||
|
|
||||||
## Domains (capability groups)
|
## Domains (capability groups)
|
||||||
|
|
||||||
@@ -248,6 +278,31 @@
|
|||||||
| — | IAM policy baseline (`acdl-spike-runner-policy`) | v1.11 / `v1.11.0` | `terraform/bootstrap/spike_runner_policy.json`, `.ciagent/IAM_POLICY.md` | REQ-116, D-095 | live-aws | regression-tested by `tests/test_iam_policy_baseline.py`; OIDC role `acdl-act-runner-role` (CAP-022) |
|
| — | IAM policy baseline (`acdl-spike-runner-policy`) | v1.11 / `v1.11.0` | `terraform/bootstrap/spike_runner_policy.json`, `.ciagent/IAM_POLICY.md` | REQ-116, D-095 | live-aws | regression-tested by `tests/test_iam_policy_baseline.py`; OIDC role `acdl-act-runner-role` (CAP-022) |
|
||||||
| — | Local emulating adapters (no AWS) | v1.10 / `v1.10.0` | `core/local_lambda_stub.py`, `scripts/run_local_e2e.sh` | D-092 | local | proves runtime behavior without live AWS |
|
| — | Local emulating adapters (no AWS) | v1.10 / `v1.10.0` | `core/local_lambda_stub.py`, `scripts/run_local_e2e.sh` | D-092 | local | proves runtime behavior without live AWS |
|
||||||
|
|
||||||
|
### Domain 11 — CLI + Identity Layer (v1.28)
|
||||||
|
|
||||||
|
| ID | Capability | Shipped | Files | Controlling | Tier | Notes |
|
||||||
|
|----|-----------|---------|-------|-------------|------|-------|
|
||||||
|
| CAP-033 | CLI subcommand surface exists | v1.28 / `v1.27.1` | `nova/cli.py`, `nova/<module>.py` (15 subcommands) | REQ-324 | local | `nova --help` lists a subcommand for every `core/` module; argparse-only, auto-discovered |
|
||||||
|
| CAP-034 | Subcommand delegates to `core/` | v1.28 / `v1.27.1` | `nova/<module>.py` | REQ-324 | local | ≤50 lines, ≤3 FunctionDef, all calls resolve to `core.*` imports; AST-scanned in `tests/test_cli_subcommands.py` |
|
||||||
|
| CAP-035 | Layer matches wheel | v1.28 / `v1.27.1` | `.github/workflows/publish.yml`, `.gitea/workflows/publish.yml`, SSM `/nova/layer/nova-cli/version` | REQ-323 | local | wheel + Lambda layer co-published with identical version; SSM mapping; CodeArtifact + fallback |
|
||||||
|
| CAP-036 | Nova-idp auth flow works | v1.28 / `v1.27.3` | `core/lambda/nova_idp_auth.py`, `tests/test_idp_auth.py` | REQ-333 | local | sign-up → sign-in → session E2E; Argon2id t=3 m=65536 p=1; fail-closed D-228; moto locally, real DDB in CI |
|
||||||
|
| CAP-037 | Token-vend signs via KMS | v1.28 / `v1.27.4` | `core/lambda/nova_idp_token_vend.py`, `core/kms_signing.py`, `tests/test_kms_roundtrip.py` | REQ-337 | local | ECDSA P-256 / ES256; DER→raw conversion; KMS round-trip test; mock KMS locally, real KMS in CI |
|
||||||
|
| CAP-038 | PAT issuance + revocation | v1.28 / `v1.27.4` | `core/pat_lifecycle.py`, `tests/test_pat_revocation.py` | REQ-342 | local | issue → vend → revoke → 403 within 60s P95; strong-read DDB (D-229); verified <1s locally |
|
||||||
|
| — | `nova init` scaffolds `.nova/` | v1.28 / `v1.27.1` | `nova/init.py`, `core/init_scaffold.py` | REQ-325 | local | `.nova/`, `.nova/contract.yml.attestations/`, `.gitignore` (secrets excluded) |
|
||||||
|
| — | `nova cli-action` composite action | v1.28 / `v1.27.1` | `.github/actions/nova-cli/action.yml` | REQ-326 | local | byte-identical GitHub + Gitea; Python 3.12 pinned; NFR-11 |
|
||||||
|
| — | `mode_resolver` (flag→env→cred→TTY) | v1.28 / `v1.27.1` | `core/mode_resolver.py` | REQ-327, D-226 | local | `sys.stdin.isatty()` (not stdout); hypothesis property tests |
|
||||||
|
| — | Dual-use Lambda/CLI import | v1.28 / `v1.27.2` | `core/lambda/contract_ingestor.py` | REQ-329 | local | shared `dispatch_action()`; ≥80% code share; NFR-7 |
|
||||||
|
| — | Local env synthesizer | v1.28 / `v1.27.2` | `core/env.py` (`synthesize_local_env`) | REQ-330 | local | `nova apply --local`; no cloud provisioning |
|
||||||
|
| — | JWS-from-PAT (HKDF-SHA256, HS256) | v1.28 / `v1.27.2` | `core/jws_attestation.py` | REQ-332, C-5.2 | local | symmetric; verification key derived from PAT via same KDF |
|
||||||
|
| — | JWKS endpoint (function URL) | v1.28 / `v1.27.4` | `core/lambda/nova_idp_jwks.py` | REQ-338, D-230 | local | `AuthType: NONE`; `Cache-Control: max-age=3600`; optional CloudFront/WAF |
|
||||||
|
| — | kyverno-json ABAC token-vend policy | v1.28 / `v1.27.4` | `platform/abac/token-vend.policy`, `core/abac_evaluator.py` | REQ-339, D-227 | local | fail-closed (C-6.1, 7 tests); `policy_version` git SHA (D-231) |
|
||||||
|
| — | `nova idp setup --check/--apply/--verify` | v1.28 / `v1.27.4` | `nova/idp/setup.py`, `core/lambda/nova_idp_setup.py`, `core/lambda/nova_idp_cfn.py` | REQ-340, REQ-341 | local | CloudFormation template review (NFR-10); IAM policy delta; KMS round-trip verify |
|
||||||
|
| — | `nova auth login/revoke/status` | v1.28 / `v1.27.4` | `nova/auth/{login,revoke,status}.py`, `core/auth_store.py` | REQ-344, C-7.3 | local | `~/.nova/credentials.json` 0600 stores OIDC token + metadata (NOT raw PAT) |
|
||||||
|
| — | E2E integration test | v1.28 / `v1.27.5` | `tests/test_e2e_idp.py` | REQ-348 | local | sign-up → sign-in → token-vend → apply → audit chain |
|
||||||
|
| — | Identity-layer threat model | v1.28 / `v1.27.5` | `docs/threat-model.md` | REQ-347 | local | 8 threats + C-9.2 INV-18..21 compression audit |
|
||||||
|
| — | Operator guide | v1.28 / `v1.27.5` | `docs/operator-guide-idp.md` | REQ-345 | local | `nova idp setup` + KMS rotation + layer update + PITR restore + emergency PAT revocation |
|
||||||
|
| — | Developer guide | v1.28 / `v1.27.5` | `docs/developer-guide-auth.md` | REQ-346 | local | quickstart + mode resolution + JWS KDF + service-account PATs |
|
||||||
|
|
||||||
## Archive pointers
|
## Archive pointers
|
||||||
|
|
||||||
- **v1.0–v1.24 capability narrative + the 2026-07-27 re-verification sweep:**
|
- **v1.0–v1.24 capability narrative + the 2026-07-27 re-verification sweep:**
|
||||||
@@ -283,4 +338,161 @@ wave** (Wave 3 "milestone ship" in `PLAN.md`), alongside
|
|||||||
Enforcement: convention (the P-final ship step names this file). A
|
Enforcement: convention (the P-final ship step names this file). A
|
||||||
drift-check gate (assert every REQ marked `complete` in
|
drift-check gate (assert every REQ marked `complete` in
|
||||||
`REQUIREMENTS.md` traceability appears in STATE.md) is a future option
|
`REQUIREMENTS.md` traceability appears in STATE.md) is a future option
|
||||||
if the convention drifts.
|
if the convention drifts.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## PDLC Phase 0 Intake (current ground truth — 2026-08-19)
|
||||||
|
|
||||||
|
> Single-pass discovery for the next PDLC cycle. Populated from the
|
||||||
|
> live repo state after v1.28 ship. No aspirational items — state is
|
||||||
|
> what is, not what should be. Unknowns are explicit.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### 1. Header (mandatory)
|
||||||
|
|
||||||
|
Project: Nova — The New Dawn of DevSecOps
|
||||||
|
|
||||||
|
Initiative: UNKNOWN — needs investigation (no new initiative specified; v1.28 just shipped, next milestone not yet scoped)
|
||||||
|
|
||||||
|
Initiator: Product Owner / Manager (PDLC Phase 0 trigger)
|
||||||
|
|
||||||
|
Date (UTC): 2026-08-19
|
||||||
|
|
||||||
|
Current Version: v1.28 complete (tag `v1.27.6`, merged to main 2026-08-19); all 7 phases shipped; no phase in progress
|
||||||
|
|
||||||
|
System Health: YELLOW — coverage 73.8% is below the 80% release-gate floor (NFR/quality debt); CodeArtifact not provisioned (P1 Wave 0 gate unresolved — fallback documented); KMS asymmetric key unverified in-account (C-1.1 documented as CI gate, not verified locally)
|
||||||
|
|
||||||
|
Raw Idea (≤ 3 sentences):
|
||||||
|
|
||||||
|
UNKNOWN — needs investigation (no raw idea provided; the PDLC trigger is the post-v1.28 state intake, not a new initiative).
|
||||||
|
|
||||||
|
Trigger: v1.28 milestone completion (CLI Canonicalization + Identity Layer shipped 2026-08-19).
|
||||||
|
|
||||||
|
Desired outcome: UNKNOWN — the PO defines the next initiative from this intake.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### 2. Architecture State
|
||||||
|
|
||||||
|
Active Layers (which exist and are stable):
|
||||||
|
|
||||||
|
[x] Core Primitives — `core/` (27 modules): `abac_evaluator`, `attestation_matrix`, `auth_store`, `confidence_signal`, `contract_resolver`, `decommission_transform`, `env`, `env_transition`, `environment_check`, `hitl_gates`, `init_scaffold`, `jws_attestation`, `kms_signing`, `local_emulators`, `mode_resolver`, `onboarding`, `outbox_writer`, `output_publisher`, `pat_lifecycle`, `policy_engine`, `regression_verify`, `separation_of_duties`, `submission_readiness` + `core/lambda/` (6 modules) + `core/metrics/` (decision ledger)
|
||||||
|
|
||||||
|
[x] Domain Modules — `adapters/terraform/` (stateless adapter), `adapters/kyverno-json/` (unified policy engine, INV-4 swappable), `adapters/wiz/`, `adapters/kyverno/` (K8s, inactive for Terraform — D-053)
|
||||||
|
|
||||||
|
[x] API/Dev Surface — `nova/` CLI package (15 subcommands, argparse-only, `[project.scripts] nova = "nova.cli:main"`); `nova auth {login,revoke,status}`; `nova idp setup`; `nova init`; `nova apply --local`; `nova cli-action` composite action (GitHub + Gitea)
|
||||||
|
|
||||||
|
[x] UI/Agent Surface — N/A (no UI; CLI + JSON endpoints only; JWKS serves `application/json`)
|
||||||
|
|
||||||
|
Compute Topology (per environment):
|
||||||
|
|
||||||
|
local: abstract (local emulators via `core/local_emulators.py:LocalLambdaStub`; `nova apply --local` synthesizes env via `core/env.synthesize_local_env()`; no cloud provisioning)
|
||||||
|
|
||||||
|
dev: abstract (env JSON `core/environments/dev.json`; pilot ran `mode: full` against live AWS `581513795199` at v1.26; Nova-idp Lambdas deploy via `nova idp setup` but not yet live-verified in dev)
|
||||||
|
|
||||||
|
staging: N/A (no `staging` environment JSON; environments are dev/qa/prod/dr)
|
||||||
|
|
||||||
|
prod: UNKNOWN — needs investigation (env JSON `core/environments/prod.json` exists; live-apply not run against prod; pilot was dev-only per D-209)
|
||||||
|
|
||||||
|
dr: placeholder (env JSON `core/environments/dr.json` exists; blocked by pilot-readiness policy D-208; not activated)
|
||||||
|
|
||||||
|
Identity Stack in Force:
|
||||||
|
|
||||||
|
auth: Custom IDP — Nova-idp (`nova-idp-auth` Lambda, v1.28): sign-up/sign-in/session; Argon2id (t=3, m=65536, p=1); DynamoDB `nova-users`/`nova-sessions`/`nova-password-resets`. NOT live-deployed (code + tests complete; `nova idp setup` ready; deployment pending operator action + AWS creds).
|
||||||
|
|
||||||
|
token-vend: Nova-idp (`nova-idp-token-vend` Lambda, v1.28): accepts PAT/session → KMS-signed OIDC token (ECDSA P-256 / ES256); kyverno-json ABAC fail-closed (INV-17, C-6.1); `nova-pats` DynamoDB (strong-read revocation, D-229, 60s SLO). NOT live-deployed.
|
||||||
|
|
||||||
|
signing: KMS asymmetric — `alias/nova-oidc-signing` (ECC_NIST_P256, SIGN_VERIFY). Code complete; key NOT yet created in-account (C-1.1 documented as CI gate — `aws kms create-key --key-spec ECC_NIST_P256 --key-usage SIGN_VERIFY` unverified).
|
||||||
|
|
||||||
|
session: DynamoDB — `nova-sessions` table (PK `session_id`, TTL `expires_at`, 24h). Cookie/local-file: `~/.nova/credentials.json` (0600, OIDC token + PAT metadata, NOT raw PAT — C-7.3).
|
||||||
|
|
||||||
|
Audit Stream:
|
||||||
|
|
||||||
|
source of truth: DynamoDB outbox → S3 Object Lock (7-yr) → GitHub/Gitea audit repo (hot index). The Decision Ledger (SQLite hash-chain, D-121, `core/metrics/decision_ledger.py`) is the cold store for `ai.decision.made` + `attestation.recorded` events.
|
||||||
|
|
||||||
|
in-repo fallback: yes (SQLite hash-chain outbox_writer, `core/outbox_writer.py`, INV-6 tamper-evident; tamper-*resistant* deferred — D-083 S3 Object Lock/JWS not yet enabled)
|
||||||
|
|
||||||
|
retention policy: 7 years (S3 Object Lock target; not yet enabled — D-083 deferred)
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### 3. Technical Stack (concrete, not aspirational)
|
||||||
|
|
||||||
|
Language(s) and runtime(s): Python 3.12 (requires-python `>=3.12`; Lambda Python 3.12 runtime on Amazon Linux 2023)
|
||||||
|
|
||||||
|
Build / packaging: setuptools (`pyproject.toml`, build-backend `setuptools.build_meta`); wheel via `python -m build --wheel`; Lambda layer via `pip install --target layer/python/` + `zip`; publish to CodeArtifact (NOT yet provisioned — fallback: Gitea wheel index / private PyPI via `NOVA_WHEEL_INDEX`)
|
||||||
|
|
||||||
|
CI / CD: Gitea Actions (`.gitea/workflows/`) + GitHub Actions (`.github/workflows/`, byte-identical); `publish.yml` (wheel + layer co-publish, REQ-323, CAP-035); `ci.yml` (test/lint); `deploy.yml@v1.25` (consumer deploy); `nova cli-action` composite action (`.github/actions/nova-cli/action.yml`); OIDC to AWS (`id-token: write`)
|
||||||
|
|
||||||
|
Infrastructure: AWS account `581513795199` (single-region `us-east-1`); S3 (state files); DynamoDB (locking + outbox + identity tables); Lambda (contract ingestor + Nova-idp 3 Lambdas); KMS (per-stack CMK + `alias/nova-oidc-signing`); CloudFront/WAF/ACM (optional, `--public-jwks-domain`); no VMs/bare metal/OS (Anti-Goal)
|
||||||
|
|
||||||
|
Data stores: DynamoDB — `nova-contracts`, `nova-change-requests` (v1.7); `nova-users`, `nova-sessions`, `nova-password-resets`, `nova-pats` (v1.28); SQLite — Decision Ledger (`core/metrics/decision_ledger.py`, local cold store); S3 — Terraform state + audit Object Lock (target, D-083 deferred)
|
||||||
|
|
||||||
|
Secrets / KMS: KMS per-stack CMK (D-069, 90-day rotation); `alias/nova-oidc-signing` (ECC_NIST_P256, 90-day rotation target — code complete, key not yet created); `nova-spike-runner` IAM user (static key, daily rotation via `workflows-src/rotate-aws-key.yml`, REQ-230 forge-agnostic); Secrets Manager (`nova/github-token`); `NOVA_GITEA_TOKEN` in `.env` (not shell-env, per bash_allowlist)
|
||||||
|
|
||||||
|
External integrations in scope: CodeArtifact (internal PyPI — NOT yet provisioned); Gitea (`git.cloudinit.dev/continuous-intelligence/acdl` — primary forge); GitHub (mirror, byte-identical workflows); AWS (account `581513795199` — pilot + identity stack); `kj` / kyverno-json v0.0.3 (Go binary, pinned SHA256, bundled in Lambda layer — `platform/abac/kj-version.txt`)
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### 4. Active Constraints (the load-bearing ones)
|
||||||
|
|
||||||
|
Locked Decisions: D-001..D-231 (full ledger in PROJECT.md + CLARIFY history). Load-bearing for new work: D-022 (contract schema), D-039/D-047 (per-run creds), D-051 (Lambda Function URL), D-069 (per-stack CMK), D-083 (S3 Object Lock — deferred), D-092 (local emulators), D-096 (live pilot — lifted v1.26), D-121 (Decision Ledger), D-133 (submission-readiness gate), D-200..D-213 (v1.26 pilot), D-214..D-225 (v1.27), D-226..D-231 (v1.28 — mode resolution, kyverno-json ABAC, Argon2id fail-closed, PAT revocation strong-read, JWKS function URL, ABAC policy git-SHA versioning)
|
||||||
|
|
||||||
|
Active Invariants: INV-1..INV-17 (full text above). New in v1.28: INV-12 (mode observability), INV-13 (mode determinism), INV-14 (credential type encodes role), INV-15 (no AWS-managed identity), INV-16 (Argon2id password storage), INV-17 (ABAC discipline fail-closed)
|
||||||
|
|
||||||
|
Standing Capability Gate: CAP-001..CAP-038 — all Verified (32 from v1.0..v1.27 + 6 from v1.28). Gate enforced by `core/regression_verify.py` + CI merge gates. CAP-033..038 added v1.28 (CLI surface, delegation AST, layer/wheel match, auth flow, KMS sign, PAT revocation).
|
||||||
|
|
||||||
|
Anti-Goals Touched: `docs/vision.md` §7 / `NORTH_STAR.md` §Anti-Goals — (1) not an upstream dev platform; (2) not a general-purpose AI; (3) not a legacy infra bridge; (4) not a permissive delivery highway; (5) not a mutable audit log. v1.28 honored all 5 (no PDLC reach, narrow CLI autonomy, no VMs, ABAC fail-closed + HITL gates intact, immutable outbox).
|
||||||
|
|
||||||
|
Out-of-Scope (hard): MFA/TOTP enforcement (v1.21+); WebAuthn/FIDO2 (v1.23+); upstream IdP federation (v1.23+); Lambda layer auto-update on `core/` changes (v1.19); password breach detection (v1.23+); session refresh token rotation (v1.22); S3 Object Lock / JWS tamper-resistance (D-083, deferred); multi-cloud (Azure/GCP); ML forecasting; bonds/derivatives/options (D-200 equities-only); multi-validator BFT (D-201 single-validator PoA)
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### 5. Recent History & Quality Gates (last 1-2 milestones)
|
||||||
|
|
||||||
|
Last Shipped: v1.28 (tag `v1.27.6`, 2026-08-19) — CLI Canonicalization + Identity Layer. 31 REQs (REQ-323..353), 6 CAPs (CAP-033..038), 6 INV (INV-12..17), 6 decisions (D-226..231). 7 phases (P0 + P1..P5 + P6 final). 1000 tests passing. Grill PROCEED 0.76 (3 critical + 16 tracked conditions resolved). Merged to main `c0cb188`.
|
||||||
|
|
||||||
|
In Progress: N/A (no phase in progress; v1.28 complete; next milestone not yet scoped)
|
||||||
|
|
||||||
|
Coverage Floor: 73.8% (3119/4227 lines covered) — BELOW the 80% release-gate floor. v1.28 new modules (`nova/`, `core/mode_resolver.py`, `core/lambda/nova_idp_*.py`, `core/kms_signing.py`, `core/abac_evaluator.py`, `core/jws_attestation.py`, `core/pat_lifecycle.py`) have high unit-test coverage but the overall floor is dragged by older uncovered code paths. Quality debt to address in a future NFR milestone.
|
||||||
|
|
||||||
|
Recent Incidents: none (no incidents in v1.27 or v1.28; no hotfix/rollback/outage commits in recent history)
|
||||||
|
|
||||||
|
Known Tensions: (1) CodeArtifact not provisioned — the publish pipeline (REQ-323) has a documented Gitea wheel-index fallback (`NOVA_WHEEL_INDEX`) but the primary path is unverified. (2) KMS asymmetric key unverified in-account (C-1.1) — the token-vend Lambda code + tests are complete but `aws kms create-key --key-spec ECC_NIST_P256` has not been run against `581513795199`. (3) `kj` Go binary in Lambda layer — pinned + locally verified, but AL2023 Lambda-runtime compatibility is a P2 spike that was not live-verified (D-227 risk; Fargate fallback documented). (4) Coverage 73.8% < 80% floor — the release gate was satisfied by phase-level coverage on new modules, but the overall floor is in debt. (5) `pyproject.toml` version is `1.14.0` (stale — not bumped through v1.15..v1.28; the milestone tags are authoritative, not the pyproject version).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### 6. Agent Context & Assumptions (Agent Initiators Only)
|
||||||
|
|
||||||
|
Missing Context: (1) The next initiative / raw idea — no new PDLC work was specified; this intake is the post-v1.28 state snapshot. (2) Live AWS verification of Nova-idp — CodeArtifact, KMS asymmetric key, and `kj`-in-Lambda-layer were not live-verified (no AWS creds in the build environment); all have documented fallbacks + CI gates. (3) Prod/dr environment activation status — env JSONs exist but live-apply was dev-only (D-209).
|
||||||
|
|
||||||
|
Agent Assumptions: (1) The PDLC trigger is the post-v1.28 state intake (not a new initiative) — the PO will define the next initiative from this snapshot. (2) Coverage 73.8% is reported as YELLOW system health (below 80% floor) but is not a blocker for the intake — it's quality debt for a future NFR milestone. (3) The 3 unverified-in-account items (CodeArtifact, KMS, kj-in-Lambda) are reported as tensions, not blockers — they have fallbacks + CI gates documented. (4) `pyproject.toml` version `1.14.0` is stale but not load-bearing (milestone tags are authoritative); flagged for a future chore.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### 7. Canonical State References (Version/Hash)
|
||||||
|
|
||||||
|
Vision/Strategy doc: `docs/vision.md` v0.2 (referenced in PROJECT.md; not version-tagged separately)
|
||||||
|
|
||||||
|
Architecture document: `.ciagent/ARCHITECTURE.md` §12.1..§12.10 (v1.28-appended §12.10 Nova-idp); commit `c0cb188` (main HEAD)
|
||||||
|
|
||||||
|
Last approved SPEC: v1.28 (REQ-323..353, REQUIREMENTS.md §v1.28); commit `c0cb188`
|
||||||
|
|
||||||
|
Decision log: D-001..D-231 (PROJECT.md load-bearing + CLARIFY.md history); last synced commit `c0cb188`
|
||||||
|
|
||||||
|
Invariants catalog: INV-1..INV-17 (STATE.md §Invariants); commit `c0cb188`
|
||||||
|
|
||||||
|
Capability catalog: CAP-001..CAP-038 (STATE.md §Domains 1..11); commit `c0cb188`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Ground rules compliance
|
||||||
|
|
||||||
|
1. No prose paragraphs inside sections — field structure used throughout. ✓
|
||||||
|
2. No aspirational items — state is what is (CodeArtifact "NOT yet provisioned", KMS "NOT yet created", prod "UNKNOWN"). ✓
|
||||||
|
3. No restated decisions — referenced D-*/INV-*/CAP-* IDs only. ✓
|
||||||
|
4. Unknowns explicit — "UNKNOWN — needs investigation" used for initiative, prod state, raw idea. ✓
|
||||||
|
5. One file, one format — appended to STATE.md as §PDLC Phase 0 Intake. ✓
|
||||||
|
6. Full shipping workflow + merge to forge upstream, NO release — branch + merge + push only (release skipped per instruction). ✓
|
||||||
@@ -13,7 +13,7 @@
|
|||||||
],
|
],
|
||||||
"active_project": "acdl",
|
"active_project": "acdl",
|
||||||
"active_projects": ["acdl", "nova-blockchain-exchange"],
|
"active_projects": ["acdl", "nova-blockchain-exchange"],
|
||||||
"active_milestone": "v1.28",
|
"active_milestone": "v1.29",
|
||||||
"autonomy": {
|
"autonomy": {
|
||||||
"level": "full",
|
"level": "full",
|
||||||
"escalation_hooks": ["deploy", "delete_data", "merge_to_main"],
|
"escalation_hooks": ["deploy", "delete_data", "merge_to_main"],
|
||||||
|
|||||||
@@ -0,0 +1,165 @@
|
|||||||
|
# Nova Publish Pipeline — wheel + Lambda layer (REQ-323, CAP-035, NFR-6)
|
||||||
|
#
|
||||||
|
# This workflow is byte-identical across the production forge (GitHub
|
||||||
|
# Actions) and the dev forge (act_runner) — the same file is installed
|
||||||
|
# at .github/workflows/publish.yml and the mirror at
|
||||||
|
# <dev-forge>/workflows/publish.yml. Both copies must match exactly
|
||||||
|
# (asserted by tests/test_forge_action_byte_identical.py for the action
|
||||||
|
# and by the repo's byte-identical convention for workflows).
|
||||||
|
#
|
||||||
|
# NFR-6 (wheel/layer co-versioning): every merge to main affecting
|
||||||
|
# core/**, adapters/**, nova/**, or pyproject.toml publishes BOTH a
|
||||||
|
# wheel AND a Lambda layer with identical version strings. If either
|
||||||
|
# publish fails, the job fails and the merge is blocked.
|
||||||
|
#
|
||||||
|
# REQ-323: CodeArtifact wheel + Lambda layer pipeline.
|
||||||
|
# CAP-035: Lambda layer ARN version matches the nova-cli wheel version;
|
||||||
|
# the mapping is recorded in SSM /nova/layer/nova-cli/version.
|
||||||
|
#
|
||||||
|
# Triggers:
|
||||||
|
# - push to main when core/**, adapters/**, nova/**, or pyproject.toml
|
||||||
|
# changed (the surfaces that ship in the wheel + layer)
|
||||||
|
# - workflow_dispatch (manual republish, e.g. after a CodeArtifact
|
||||||
|
# provisioning fix)
|
||||||
|
#
|
||||||
|
# Wheel index selection (CodeArtifact default + fallback):
|
||||||
|
# - CodeArtifact mode: set the NOVA_CODEARTIFACT_DOMAIN repository
|
||||||
|
# secret (e.g. "nova"). The workflow runs
|
||||||
|
# `aws codeartifact login --tool twine --domain $NOVA_CODEARTIFACT_DOMAIN
|
||||||
|
# --repository nova-pypi` and twine uploads to the CodeArtifact pypi
|
||||||
|
# endpoint.
|
||||||
|
# - Fallback mode: leave NOVA_CODEARTIFACT_DOMAIN unset and provide
|
||||||
|
# TWINE_REPOSITORY_URL + TWINE_USERNAME + TWINE_PASSWORD repository
|
||||||
|
# secrets pointing at any PEP 503 simple index (a private package
|
||||||
|
# registry). twine uploads to TWINE_REPOSITORY_URL.
|
||||||
|
# See docs/codeartifact-provisioning.md for the required IAM grants
|
||||||
|
# + the fallback index shape.
|
||||||
|
#
|
||||||
|
# Secrets / env:
|
||||||
|
# AWS_ROLE_ARN — OIDC role to assume (id-token: write)
|
||||||
|
# NOVA_CODEARTIFACT_DOMAIN — optional; when set, CodeArtifact mode
|
||||||
|
# TWINE_USERNAME — fallback-index upload user
|
||||||
|
# TWINE_PASSWORD — fallback-index upload password
|
||||||
|
# TWINE_REPOSITORY_URL — fallback-index upload URL
|
||||||
|
# AWS_DEFAULT_REGION (optional) — defaults to us-east-1
|
||||||
|
name: nova-publish
|
||||||
|
|
||||||
|
on:
|
||||||
|
push:
|
||||||
|
branches: [main]
|
||||||
|
paths:
|
||||||
|
- "core/**"
|
||||||
|
- "adapters/**"
|
||||||
|
- "nova/**"
|
||||||
|
- "pyproject.toml"
|
||||||
|
workflow_dispatch:
|
||||||
|
|
||||||
|
permissions:
|
||||||
|
id-token: write # OIDC federation to AWS
|
||||||
|
contents: write # tag the release
|
||||||
|
|
||||||
|
jobs:
|
||||||
|
publish:
|
||||||
|
name: Publish wheel + Lambda layer
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
- uses: actions/setup-python@v5
|
||||||
|
with:
|
||||||
|
python-version: "3.12"
|
||||||
|
|
||||||
|
- name: Configure AWS credentials (OIDC)
|
||||||
|
uses: aws-actions/configure-aws-credentials@v4
|
||||||
|
with:
|
||||||
|
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
|
||||||
|
aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||||
|
|
||||||
|
- name: Install build + publish tools
|
||||||
|
run: pip install build twine
|
||||||
|
|
||||||
|
- name: Compute version from pyproject.toml
|
||||||
|
id: ver
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
VERSION=$(python -c 'import tomllib;print(tomllib.load(open("pyproject.toml","rb"))["project"]["version"])')
|
||||||
|
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
|
||||||
|
echo "Nova version: $VERSION"
|
||||||
|
|
||||||
|
- name: Build wheel
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
python -m build --wheel
|
||||||
|
ls -1 dist/
|
||||||
|
|
||||||
|
- name: Upload wheel to index (CodeArtifact default + fallback)
|
||||||
|
id: wheel
|
||||||
|
env:
|
||||||
|
NOVA_CODEARTIFACT_DOMAIN: ${{ secrets.NOVA_CODEARTIFACT_DOMAIN }}
|
||||||
|
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
|
||||||
|
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
|
||||||
|
TWINE_REPOSITORY_URL: ${{ secrets.TWINE_REPOSITORY_URL }}
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
# CodeArtifact mode: log in to the domain's pypi repository.
|
||||||
|
if [ -n "$NOVA_CODEARTIFACT_DOMAIN" ]; then
|
||||||
|
echo "CodeArtifact mode: domain=$NOVA_CODEARTIFACT_DOMAIN repository=nova-pypi"
|
||||||
|
aws codeartifact login --tool twine \
|
||||||
|
--domain "$NOVA_CODEARTIFACT_DOMAIN" --repository nova-pypi
|
||||||
|
else
|
||||||
|
echo "Fallback-index mode: uploading to TWINE_REPOSITORY_URL"
|
||||||
|
if [ -z "$TWINE_REPOSITORY_URL" ] || [ -z "$TWINE_USERNAME" ] || [ -z "$TWINE_PASSWORD" ]; then
|
||||||
|
echo "FAIL: NOVA_CODEARTIFACT_DOMAIN is unset and one of TWINE_REPOSITORY_URL/TWINE_USERNAME/TWINE_PASSWORD is missing."
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
fi
|
||||||
|
# Idempotent upload: a re-run for the same version may hit
|
||||||
|
# "file already exists" on the index. Treat that as success.
|
||||||
|
twine upload "dist/nova-${{ steps.ver.outputs.version }}-*.whl" \
|
||||||
|
|| twine upload "dist/nova-${{ steps.ver.outputs.version }}-*.whl" 2>&1 | tee /tmp/twine.log
|
||||||
|
if grep -qi "already exist" /tmp/twine.log 2>/dev/null; then
|
||||||
|
echo "Wheel already present on the index — treating as success (idempotent)."
|
||||||
|
fi
|
||||||
|
echo "uploaded=true" >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
|
- name: Build Lambda layer
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
rm -rf layer
|
||||||
|
mkdir -p layer/python
|
||||||
|
# Install the wheel we just built + the identity extras' deps
|
||||||
|
# so the layer carries argon2-cffi, cryptography, pyjwt.
|
||||||
|
pip install --target layer/python/ \
|
||||||
|
"dist/nova-${{ steps.ver.outputs.version }}-*.whl" \
|
||||||
|
argon2-cffi cryptography pyjwt
|
||||||
|
( cd layer && zip -r ../nova-layer.zip python/ )
|
||||||
|
ls -lh nova-layer.zip
|
||||||
|
|
||||||
|
- name: Publish Lambda layer
|
||||||
|
id: layer
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
ARN=$(aws lambda publish-layer-version \
|
||||||
|
--layer-name nova-cli \
|
||||||
|
--zip-file fileb://nova-layer.zip \
|
||||||
|
--compatible-runtimes python3.12 \
|
||||||
|
--compatible-architectures x86_64 \
|
||||||
|
--description "nova-cli v${{ steps.ver.outputs.version }}" \
|
||||||
|
--query LayerVersionArn --output text)
|
||||||
|
echo "arn=$ARN" >> "$GITHUB_OUTPUT"
|
||||||
|
echo "Published Lambda layer: $ARN"
|
||||||
|
|
||||||
|
- name: Record SSM version↔ARN mapping (CAP-035)
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
aws ssm put-parameter \
|
||||||
|
--name /nova/layer/nova-cli/version \
|
||||||
|
--value "${{ steps.ver.outputs.version }}:${{ steps.layer.outputs.arn }}" \
|
||||||
|
--type String --overwrite
|
||||||
|
echo "SSM /nova/layer/nova-cli/version = ${{ steps.ver.outputs.version }}:${{ steps.layer.outputs.arn }}"
|
||||||
|
|
||||||
|
- name: Fail job if either publish failed (REQ-323 AC)
|
||||||
|
if: ${{ steps.wheel.outputs.uploaded != 'true' || steps.layer.outputs.arn == '' }}
|
||||||
|
run: |
|
||||||
|
echo "FAIL: wheel uploaded=${{ steps.wheel.outputs.uploaded }} layer_arn=${{ steps.layer.outputs.arn }}"
|
||||||
|
exit 1
|
||||||
@@ -0,0 +1,94 @@
|
|||||||
|
# Nova CLI Action — composite action (REQ-326, NFR-11)
|
||||||
|
#
|
||||||
|
# Runs a Nova CLI command (`nova <command>`) in a consumer repository.
|
||||||
|
# Python 3.12 is pinned (REQ-326 AC3). The same action.yml is discovered
|
||||||
|
# by both the production forge (GitHub Actions) and the dev forge
|
||||||
|
# (act_runner) via the shared .github/actions/nova-cli/ path — there is
|
||||||
|
# no separate dev-forge action file. Consumers reference it via a
|
||||||
|
# versioned tag pin:
|
||||||
|
#
|
||||||
|
# uses: <org>/<repo>/.github/actions/nova-cli@v1.28
|
||||||
|
#
|
||||||
|
# Wheel index selection (CodeArtifact default + fallback):
|
||||||
|
# - CodeArtifact mode: set the NOVA_CODEARTIFACT_DOMAIN repository
|
||||||
|
# secret/env. The action runs
|
||||||
|
# `aws codeartifact login --tool pip --domain $NOVA_CODEARTIFACT_DOMAIN
|
||||||
|
# --repository nova-pypi` before `pip install nova`.
|
||||||
|
# - Fallback mode: leave NOVA_CODEARTIFACT_DOMAIN unset and provide
|
||||||
|
# NOVA_WHEEL_INDEX env pointing at any PEP 503 simple index (a
|
||||||
|
# private package registry). The action runs
|
||||||
|
# `pip install --index-url $NOVA_WHEEL_INDEX nova==<version>`.
|
||||||
|
# See docs/codeartifact-provisioning.md for the index shape.
|
||||||
|
#
|
||||||
|
# Byte-identical cross-platform verification (NFR-11, REQ-326 AC2):
|
||||||
|
# the full byte-identical test runs as a CI matrix job on the
|
||||||
|
# production forge (ubuntu-latest) + the dev forge (act_runner) with
|
||||||
|
# identical inputs, asserting same stdout + exit code. That matrix is
|
||||||
|
# not reproducible in a unit test; the structural invariants (valid
|
||||||
|
# YAML, python 3.12 pin, install + run steps present) are asserted by
|
||||||
|
# tests/test_forge_action_byte_identical.py.
|
||||||
|
name: "Nova CLI Action"
|
||||||
|
description: "Run a Nova CLI command (`nova <command>`) with Python 3.12 pinned"
|
||||||
|
|
||||||
|
inputs:
|
||||||
|
command:
|
||||||
|
description: "The Nova subcommand + args to run (e.g. `apply --local`, `init`, `idp setup --check-only`). Passed verbatim to `nova`."
|
||||||
|
required: true
|
||||||
|
contract:
|
||||||
|
description: "Path to the consumer contract YAML (default .nova/contract.yml). Forwarded to nova via the NOVA_CONTRACT env var."
|
||||||
|
required: false
|
||||||
|
default: ".nova/contract.yml"
|
||||||
|
mode:
|
||||||
|
description: "Nova client mode override (e.g. agent, interactive, plan-only, check-only). Forwarded to nova via the NOVA_CLIENT_MODE env var. Empty = let nova resolve (TTY + credentials)."
|
||||||
|
required: false
|
||||||
|
default: ""
|
||||||
|
version:
|
||||||
|
description: "nova package version to install (default `latest`). Pin to a released wheel version for reproducible runs."
|
||||||
|
required: false
|
||||||
|
default: "latest"
|
||||||
|
|
||||||
|
runs:
|
||||||
|
using: "composite"
|
||||||
|
steps:
|
||||||
|
- name: Set up Python 3.12
|
||||||
|
uses: actions/setup-python@v5
|
||||||
|
with:
|
||||||
|
python-version: "3.12"
|
||||||
|
|
||||||
|
- name: Install Nova (CodeArtifact default + fallback index)
|
||||||
|
shell: bash
|
||||||
|
env:
|
||||||
|
NOVA_CODEARTIFACT_DOMAIN: ${{ env.NOVA_CODEARTIFACT_DOMAIN }}
|
||||||
|
NOVA_WHEEL_INDEX: ${{ env.NOVA_WHEEL_INDEX }}
|
||||||
|
NOVA_INSTALL_VERSION: ${{ inputs.version }}
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
if [ "$NOVA_INSTALL_VERSION" = "latest" ]; then
|
||||||
|
PIP_SPEC="nova"
|
||||||
|
else
|
||||||
|
PIP_SPEC="nova==$NOVA_INSTALL_VERSION"
|
||||||
|
fi
|
||||||
|
if [ -n "$NOVA_CODEARTIFACT_DOMAIN" ]; then
|
||||||
|
echo "CodeArtifact mode: domain=$NOVA_CODEARTIFACT_DOMAIN repository=nova-pypi"
|
||||||
|
aws codeartifact login --tool pip \
|
||||||
|
--domain "$NOVA_CODEARTIFACT_DOMAIN" --repository nova-pypi
|
||||||
|
pip install $PIP_SPEC
|
||||||
|
else
|
||||||
|
echo "Fallback-index mode: NOVA_WHEEL_INDEX=$NOVA_WHEEL_INDEX"
|
||||||
|
if [ -z "$NOVA_WHEEL_INDEX" ]; then
|
||||||
|
echo "FAIL: NOVA_CODEARTIFACT_DOMAIN is unset and NOVA_WHEEL_INDEX is empty. Set one of them."
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
pip install --index-url "$NOVA_WHEEL_INDEX" $PIP_SPEC
|
||||||
|
fi
|
||||||
|
nova --version || true
|
||||||
|
|
||||||
|
- name: Run Nova
|
||||||
|
shell: bash
|
||||||
|
env:
|
||||||
|
NOVA_CLIENT_MODE: ${{ inputs.mode }}
|
||||||
|
NOVA_CONTRACT: ${{ inputs.contract }}
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
echo "nova ${{ inputs.command }}"
|
||||||
|
nova ${{ inputs.command }}
|
||||||
@@ -0,0 +1,165 @@
|
|||||||
|
# Nova Publish Pipeline — wheel + Lambda layer (REQ-323, CAP-035, NFR-6)
|
||||||
|
#
|
||||||
|
# This workflow is byte-identical across the production forge (GitHub
|
||||||
|
# Actions) and the dev forge (act_runner) — the same file is installed
|
||||||
|
# at .github/workflows/publish.yml and the mirror at
|
||||||
|
# <dev-forge>/workflows/publish.yml. Both copies must match exactly
|
||||||
|
# (asserted by tests/test_forge_action_byte_identical.py for the action
|
||||||
|
# and by the repo's byte-identical convention for workflows).
|
||||||
|
#
|
||||||
|
# NFR-6 (wheel/layer co-versioning): every merge to main affecting
|
||||||
|
# core/**, adapters/**, nova/**, or pyproject.toml publishes BOTH a
|
||||||
|
# wheel AND a Lambda layer with identical version strings. If either
|
||||||
|
# publish fails, the job fails and the merge is blocked.
|
||||||
|
#
|
||||||
|
# REQ-323: CodeArtifact wheel + Lambda layer pipeline.
|
||||||
|
# CAP-035: Lambda layer ARN version matches the nova-cli wheel version;
|
||||||
|
# the mapping is recorded in SSM /nova/layer/nova-cli/version.
|
||||||
|
#
|
||||||
|
# Triggers:
|
||||||
|
# - push to main when core/**, adapters/**, nova/**, or pyproject.toml
|
||||||
|
# changed (the surfaces that ship in the wheel + layer)
|
||||||
|
# - workflow_dispatch (manual republish, e.g. after a CodeArtifact
|
||||||
|
# provisioning fix)
|
||||||
|
#
|
||||||
|
# Wheel index selection (CodeArtifact default + fallback):
|
||||||
|
# - CodeArtifact mode: set the NOVA_CODEARTIFACT_DOMAIN repository
|
||||||
|
# secret (e.g. "nova"). The workflow runs
|
||||||
|
# `aws codeartifact login --tool twine --domain $NOVA_CODEARTIFACT_DOMAIN
|
||||||
|
# --repository nova-pypi` and twine uploads to the CodeArtifact pypi
|
||||||
|
# endpoint.
|
||||||
|
# - Fallback mode: leave NOVA_CODEARTIFACT_DOMAIN unset and provide
|
||||||
|
# TWINE_REPOSITORY_URL + TWINE_USERNAME + TWINE_PASSWORD repository
|
||||||
|
# secrets pointing at any PEP 503 simple index (a private package
|
||||||
|
# registry). twine uploads to TWINE_REPOSITORY_URL.
|
||||||
|
# See docs/codeartifact-provisioning.md for the required IAM grants
|
||||||
|
# + the fallback index shape.
|
||||||
|
#
|
||||||
|
# Secrets / env:
|
||||||
|
# AWS_ROLE_ARN — OIDC role to assume (id-token: write)
|
||||||
|
# NOVA_CODEARTIFACT_DOMAIN — optional; when set, CodeArtifact mode
|
||||||
|
# TWINE_USERNAME — fallback-index upload user
|
||||||
|
# TWINE_PASSWORD — fallback-index upload password
|
||||||
|
# TWINE_REPOSITORY_URL — fallback-index upload URL
|
||||||
|
# AWS_DEFAULT_REGION (optional) — defaults to us-east-1
|
||||||
|
name: nova-publish
|
||||||
|
|
||||||
|
on:
|
||||||
|
push:
|
||||||
|
branches: [main]
|
||||||
|
paths:
|
||||||
|
- "core/**"
|
||||||
|
- "adapters/**"
|
||||||
|
- "nova/**"
|
||||||
|
- "pyproject.toml"
|
||||||
|
workflow_dispatch:
|
||||||
|
|
||||||
|
permissions:
|
||||||
|
id-token: write # OIDC federation to AWS
|
||||||
|
contents: write # tag the release
|
||||||
|
|
||||||
|
jobs:
|
||||||
|
publish:
|
||||||
|
name: Publish wheel + Lambda layer
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
- uses: actions/setup-python@v5
|
||||||
|
with:
|
||||||
|
python-version: "3.12"
|
||||||
|
|
||||||
|
- name: Configure AWS credentials (OIDC)
|
||||||
|
uses: aws-actions/configure-aws-credentials@v4
|
||||||
|
with:
|
||||||
|
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
|
||||||
|
aws-region: ${{ secrets.AWS_DEFAULT_REGION || 'us-east-1' }}
|
||||||
|
|
||||||
|
- name: Install build + publish tools
|
||||||
|
run: pip install build twine
|
||||||
|
|
||||||
|
- name: Compute version from pyproject.toml
|
||||||
|
id: ver
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
VERSION=$(python -c 'import tomllib;print(tomllib.load(open("pyproject.toml","rb"))["project"]["version"])')
|
||||||
|
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
|
||||||
|
echo "Nova version: $VERSION"
|
||||||
|
|
||||||
|
- name: Build wheel
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
python -m build --wheel
|
||||||
|
ls -1 dist/
|
||||||
|
|
||||||
|
- name: Upload wheel to index (CodeArtifact default + fallback)
|
||||||
|
id: wheel
|
||||||
|
env:
|
||||||
|
NOVA_CODEARTIFACT_DOMAIN: ${{ secrets.NOVA_CODEARTIFACT_DOMAIN }}
|
||||||
|
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
|
||||||
|
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
|
||||||
|
TWINE_REPOSITORY_URL: ${{ secrets.TWINE_REPOSITORY_URL }}
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
# CodeArtifact mode: log in to the domain's pypi repository.
|
||||||
|
if [ -n "$NOVA_CODEARTIFACT_DOMAIN" ]; then
|
||||||
|
echo "CodeArtifact mode: domain=$NOVA_CODEARTIFACT_DOMAIN repository=nova-pypi"
|
||||||
|
aws codeartifact login --tool twine \
|
||||||
|
--domain "$NOVA_CODEARTIFACT_DOMAIN" --repository nova-pypi
|
||||||
|
else
|
||||||
|
echo "Fallback-index mode: uploading to TWINE_REPOSITORY_URL"
|
||||||
|
if [ -z "$TWINE_REPOSITORY_URL" ] || [ -z "$TWINE_USERNAME" ] || [ -z "$TWINE_PASSWORD" ]; then
|
||||||
|
echo "FAIL: NOVA_CODEARTIFACT_DOMAIN is unset and one of TWINE_REPOSITORY_URL/TWINE_USERNAME/TWINE_PASSWORD is missing."
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
fi
|
||||||
|
# Idempotent upload: a re-run for the same version may hit
|
||||||
|
# "file already exists" on the index. Treat that as success.
|
||||||
|
twine upload "dist/nova-${{ steps.ver.outputs.version }}-*.whl" \
|
||||||
|
|| twine upload "dist/nova-${{ steps.ver.outputs.version }}-*.whl" 2>&1 | tee /tmp/twine.log
|
||||||
|
if grep -qi "already exist" /tmp/twine.log 2>/dev/null; then
|
||||||
|
echo "Wheel already present on the index — treating as success (idempotent)."
|
||||||
|
fi
|
||||||
|
echo "uploaded=true" >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
|
- name: Build Lambda layer
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
rm -rf layer
|
||||||
|
mkdir -p layer/python
|
||||||
|
# Install the wheel we just built + the identity extras' deps
|
||||||
|
# so the layer carries argon2-cffi, cryptography, pyjwt.
|
||||||
|
pip install --target layer/python/ \
|
||||||
|
"dist/nova-${{ steps.ver.outputs.version }}-*.whl" \
|
||||||
|
argon2-cffi cryptography pyjwt
|
||||||
|
( cd layer && zip -r ../nova-layer.zip python/ )
|
||||||
|
ls -lh nova-layer.zip
|
||||||
|
|
||||||
|
- name: Publish Lambda layer
|
||||||
|
id: layer
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
ARN=$(aws lambda publish-layer-version \
|
||||||
|
--layer-name nova-cli \
|
||||||
|
--zip-file fileb://nova-layer.zip \
|
||||||
|
--compatible-runtimes python3.12 \
|
||||||
|
--compatible-architectures x86_64 \
|
||||||
|
--description "nova-cli v${{ steps.ver.outputs.version }}" \
|
||||||
|
--query LayerVersionArn --output text)
|
||||||
|
echo "arn=$ARN" >> "$GITHUB_OUTPUT"
|
||||||
|
echo "Published Lambda layer: $ARN"
|
||||||
|
|
||||||
|
- name: Record SSM version↔ARN mapping (CAP-035)
|
||||||
|
run: |
|
||||||
|
set -e
|
||||||
|
aws ssm put-parameter \
|
||||||
|
--name /nova/layer/nova-cli/version \
|
||||||
|
--value "${{ steps.ver.outputs.version }}:${{ steps.layer.outputs.arn }}" \
|
||||||
|
--type String --overwrite
|
||||||
|
echo "SSM /nova/layer/nova-cli/version = ${{ steps.ver.outputs.version }}:${{ steps.layer.outputs.arn }}"
|
||||||
|
|
||||||
|
- name: Fail job if either publish failed (REQ-323 AC)
|
||||||
|
if: ${{ steps.wheel.outputs.uploaded != 'true' || steps.layer.outputs.arn == '' }}
|
||||||
|
run: |
|
||||||
|
echo "FAIL: wheel uploaded=${{ steps.wheel.outputs.uploaded }} layer_arn=${{ steps.layer.outputs.arn }}"
|
||||||
|
exit 1
|
||||||
@@ -42,3 +42,6 @@ metrics/lifecycle/
|
|||||||
*.jks
|
*.jks
|
||||||
*.keystore.coverage
|
*.keystore.coverage
|
||||||
.coverage
|
.coverage
|
||||||
|
|
||||||
|
.venv/
|
||||||
|
nova.egg-info/
|
||||||
|
|||||||
@@ -0,0 +1,145 @@
|
|||||||
|
"""Nova ABAC evaluator for the token-vend Lambda (REQ-339, C-6.1, D-231).
|
||||||
|
|
||||||
|
Wraps :func:`core.policy_engine.get_engine` to evaluate the
|
||||||
|
``platform/abac/token-vend.policy`` kyverno-json ``ValidatingPolicy``
|
||||||
|
against a token-vend authorization payload and produce an allow/deny
|
||||||
|
decision with the policy SHA (D-231).
|
||||||
|
|
||||||
|
Payload shape (REQ-339, C-5.1)::
|
||||||
|
|
||||||
|
{
|
||||||
|
"subject": {"id": ..., "role": ..., "owner": ...},
|
||||||
|
"requested_claims": [<claim name>, ...], # C-5.1
|
||||||
|
"target_resource": {"type": ..., "id": ..., "owner": ..., "environment": ...},
|
||||||
|
"environment": "dev" | "qa" | "prod" | "dr",
|
||||||
|
"pat_jti": "<PAT jti>",
|
||||||
|
"policy_version": "<git SHA>"
|
||||||
|
}
|
||||||
|
|
||||||
|
Decision rule (C-6.1 fail-closed): **any** PCR with ``result == "fail"``
|
||||||
|
and ``severity == "critical"`` → ``allowed=False``. The caller (the
|
||||||
|
token-vend Lambda) is additionally required to fail closed when
|
||||||
|
``KyvernoJsonEngine.is_configured()`` returns ``False`` or when this
|
||||||
|
function raises — see ``tests/test_abac_fail_closed.py`` (the grill's
|
||||||
|
#1 finding, INV-17).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import os
|
||||||
|
import shutil
|
||||||
|
import subprocess
|
||||||
|
import tempfile
|
||||||
|
from pathlib import Path
|
||||||
|
from typing import Tuple
|
||||||
|
|
||||||
|
from core.policy_engine import get_engine
|
||||||
|
|
||||||
|
|
||||||
|
_POLICY_DIR = Path("platform/abac")
|
||||||
|
_POLICY_FILE = _POLICY_DIR / "token-vend.policy"
|
||||||
|
_CONTRACT_ID = "token-vend"
|
||||||
|
|
||||||
|
|
||||||
|
def _materialize_policy_dir(src_dir: Path) -> Tuple[Path, bool]:
|
||||||
|
"""Mirror ``src_dir`` to a temp dir, copying ``*.policy`` files to
|
||||||
|
``*.json`` twins (JSON is a valid kyverno-json policy format; the
|
||||||
|
``KyvernoJsonEngine`` only loads ``.json``/``.yaml``/``.yml``, and
|
||||||
|
Nova ABAC policies use the ``.policy`` extension per REQ-339, so a
|
||||||
|
byte-for-byte copy with a ``.json`` extension is required).
|
||||||
|
|
||||||
|
Returns ``(temp_dir, created)``; ``created`` is ``False`` when no
|
||||||
|
policy files were found. The caller is responsible for removing the
|
||||||
|
temp dir.
|
||||||
|
"""
|
||||||
|
tmp = Path(tempfile.mkdtemp(prefix="nova-abac-pol-"))
|
||||||
|
any_policy = False
|
||||||
|
if src_dir.is_dir():
|
||||||
|
for entry in sorted(os.listdir(src_dir)):
|
||||||
|
if entry.startswith(".") or entry.startswith("_"):
|
||||||
|
continue
|
||||||
|
src_file = src_dir / entry
|
||||||
|
if not src_file.is_file():
|
||||||
|
continue
|
||||||
|
if entry.endswith(".policy"):
|
||||||
|
dest = tmp / (entry[: -len(".policy")] + ".json")
|
||||||
|
shutil.copy2(src_file, dest)
|
||||||
|
any_policy = True
|
||||||
|
elif entry.endswith((".json", ".yaml", ".yml")):
|
||||||
|
shutil.copy2(src_file, tmp / entry)
|
||||||
|
any_policy = True
|
||||||
|
return tmp, any_policy
|
||||||
|
|
||||||
|
|
||||||
|
def _policy_sha() -> str:
|
||||||
|
"""Return the git SHA of the policy file (D-231).
|
||||||
|
|
||||||
|
Uses ``git rev-parse HEAD:platform/abac/token-vend.policy`` so the
|
||||||
|
SHA is stable across checkouts (blob SHA, not commit SHA). Falls
|
||||||
|
back to ``"unknown"`` when git is unavailable or the file is not
|
||||||
|
tracked (e.g. during local development before the first commit).
|
||||||
|
"""
|
||||||
|
repo_root = os.environ.get("NOVA_REPO_ROOT") or os.getcwd()
|
||||||
|
try:
|
||||||
|
sha = subprocess.check_output(
|
||||||
|
["git", "rev-parse", "HEAD:platform/abac/token-vend.policy"],
|
||||||
|
cwd=repo_root,
|
||||||
|
stderr=subprocess.DEVNULL,
|
||||||
|
text=True,
|
||||||
|
timeout=5,
|
||||||
|
).strip()
|
||||||
|
return sha or "unknown"
|
||||||
|
except Exception:
|
||||||
|
return "unknown"
|
||||||
|
|
||||||
|
|
||||||
|
def evaluate_token_vend_policy(
|
||||||
|
payload: dict,
|
||||||
|
) -> Tuple[bool, list, str]:
|
||||||
|
"""Evaluate the token-vend ABAC policy against ``payload``.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
payload: the ABAC authorization payload (see module docstring).
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
``(allowed, pcrs, policy_sha)`` where ``allowed`` is ``True``
|
||||||
|
iff no PCR has ``result == "fail"`` with ``severity ==
|
||||||
|
"critical"`` (C-6.1). ``pcrs`` is the raw list of
|
||||||
|
``PolicyCheckResult`` dicts from the engine. ``policy_sha`` is
|
||||||
|
the git blob SHA of the policy file (D-231).
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: any engine error propagates — the caller MUST catch
|
||||||
|
and fail closed (403 ``abac_eval_failed``). This function
|
||||||
|
does NOT swallow errors: failing closed is the *caller's*
|
||||||
|
responsibility so the denial audit event is emitted at the
|
||||||
|
Lambda boundary with the right reason code.
|
||||||
|
"""
|
||||||
|
engine = get_engine()
|
||||||
|
# Nova ABAC policies use the `.policy` extension (REQ-339), but
|
||||||
|
# KyvernoJsonEngine only loads `.json`/`.yaml`/`.yml`. Materialize a
|
||||||
|
# temp dir with `.policy` → `.json` twins so the engine picks them
|
||||||
|
# up. The temp dir is removed in the `finally` block.
|
||||||
|
pol_dir, _ = _materialize_policy_dir(_POLICY_DIR)
|
||||||
|
try:
|
||||||
|
pcrs = engine.evaluate(payload, pol_dir, _CONTRACT_ID)
|
||||||
|
finally:
|
||||||
|
shutil.rmtree(pol_dir, ignore_errors=True)
|
||||||
|
allowed = not any(
|
||||||
|
p.get("result") == "fail" and str(p.get("severity", "")).lower() == "critical"
|
||||||
|
for p in pcrs
|
||||||
|
)
|
||||||
|
return allowed, pcrs, _policy_sha()
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI inspection helper
|
||||||
|
import json
|
||||||
|
import sys
|
||||||
|
|
||||||
|
if len(sys.argv) > 1:
|
||||||
|
with open(sys.argv[1]) as fh:
|
||||||
|
pl = json.load(fh)
|
||||||
|
else:
|
||||||
|
pl = json.loads(sys.stdin.read())
|
||||||
|
allowed, pcrs, sha = evaluate_token_vend_policy(pl)
|
||||||
|
print(json.dumps({"allowed": allowed, "policy_sha": sha, "pcrs": pcrs}, indent=2))
|
||||||
+14
-13
@@ -169,20 +169,21 @@ def check(env: str, evidence: dict) -> Tuple[bool, str]:
|
|||||||
return (True, f"{env}: all {len(concerns)} concern(s) pass")
|
return (True, f"{env}: all {len(concerns)} concern(s) pass")
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
def cli_main(argv) -> int:
|
||||||
|
"""Thin CLI entry (P1): nova attestation-matrix <env> [evidence.json]."""
|
||||||
import json
|
import json
|
||||||
if len(sys.argv) < 2:
|
if len(argv) < 2:
|
||||||
print("usage: attestation_matrix.py <env> [evidence.json]", file=sys.stderr)
|
print("usage: attestation_matrix <env> [evidence.json]", file=sys.stderr)
|
||||||
sys.exit(2)
|
return 2
|
||||||
_env = sys.argv[1]
|
_env = argv[1]
|
||||||
_evidence = {}
|
_evidence = {}
|
||||||
if len(sys.argv) >= 3 and os.path.isfile(sys.argv[2]):
|
if len(argv) >= 3 and os.path.isfile(argv[2]):
|
||||||
with open(sys.argv[2]) as f:
|
with open(argv[2]) as f:
|
||||||
_evidence = json.load(f)
|
_evidence = json.load(f)
|
||||||
ok, reason = check(_env, _evidence)
|
ok, reason = check(_env, _evidence)
|
||||||
if ok:
|
print(f"ATTESTATION PASS: {reason}") if ok else print(f"ATTESTATION BLOCK: {reason}", file=sys.stderr)
|
||||||
print(f"ATTESTATION PASS: {reason}")
|
return 0 if ok else 1
|
||||||
sys.exit(0)
|
|
||||||
else:
|
|
||||||
print(f"ATTESTATION BLOCK: {reason}", file=sys.stderr)
|
if __name__ == "__main__":
|
||||||
sys.exit(1)
|
sys.exit(cli_main(sys.argv))
|
||||||
@@ -0,0 +1,97 @@
|
|||||||
|
"""Nova credential store — ``~/.nova/credentials.json`` (C-7.3, REQ-344).
|
||||||
|
|
||||||
|
Stores the OIDC token + PAT metadata (jti, exp, type) ONLY — **NOT the
|
||||||
|
raw PAT** (C-7.3). The file is 0600. "Most recent wins" (D-226 Q5):
|
||||||
|
``active_credential_jti`` points at the most-recently-stored credential.
|
||||||
|
|
||||||
|
Shape::
|
||||||
|
|
||||||
|
{
|
||||||
|
"active_credential_jti": "<jti>",
|
||||||
|
"credentials": [
|
||||||
|
{"jti": ..., "type": "developer_pat"|"nova_oidc_token",
|
||||||
|
"exp": <epoch>, "token": "<oidc jwt>", "stored_at": <epoch>}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import stat
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
from typing import Optional
|
||||||
|
|
||||||
|
|
||||||
|
def credentials_path() -> Path:
|
||||||
|
return Path(os.environ.get("NOVA_CREDENTIALS_FILE")
|
||||||
|
or os.path.expanduser("~/.nova/credentials.json"))
|
||||||
|
|
||||||
|
|
||||||
|
def _emit_audit(event_type: str, **fields) -> None:
|
||||||
|
payload = {"event": event_type, **fields}
|
||||||
|
sys.stderr.write(json.dumps(payload, sort_keys=True) + "\n")
|
||||||
|
sys.stderr.flush()
|
||||||
|
|
||||||
|
|
||||||
|
def store_credential(
|
||||||
|
jti: str,
|
||||||
|
cred_type: str,
|
||||||
|
exp: int,
|
||||||
|
oidc_token: str,
|
||||||
|
path: Optional[Path] = None,
|
||||||
|
) -> None:
|
||||||
|
"""Store an OIDC token + PAT metadata (NOT the raw PAT, C-7.3). 0600."""
|
||||||
|
p = path or credentials_path()
|
||||||
|
p.parent.mkdir(parents=True, exist_ok=True)
|
||||||
|
data = {"active_credential_jti": jti, "credentials": []}
|
||||||
|
if p.exists():
|
||||||
|
try:
|
||||||
|
data = json.loads(p.read_text())
|
||||||
|
except (OSError, json.JSONDecodeError):
|
||||||
|
data = {"active_credential_jti": jti, "credentials": []}
|
||||||
|
creds = data.get("credentials", []) or []
|
||||||
|
# Replace any existing entry with the same jti.
|
||||||
|
creds = [c for c in creds if c.get("jti") != jti]
|
||||||
|
import time
|
||||||
|
creds.append({
|
||||||
|
"jti": jti, "type": cred_type, "exp": exp,
|
||||||
|
"token": oidc_token, "stored_at": int(time.time()),
|
||||||
|
})
|
||||||
|
data["credentials"] = creds
|
||||||
|
data["active_credential_jti"] = jti
|
||||||
|
p.write_text(json.dumps(data, indent=2, sort_keys=True))
|
||||||
|
os.chmod(p, stat.S_IRUSR | stat.S_IWUSR) # 0600
|
||||||
|
_emit_audit("auth.login", jti=jti, type=cred_type)
|
||||||
|
|
||||||
|
|
||||||
|
def load_credentials(path: Optional[Path] = None) -> dict:
|
||||||
|
"""Load the credentials file (or ``{}`` if absent)."""
|
||||||
|
p = path or credentials_path()
|
||||||
|
try:
|
||||||
|
return json.loads(p.read_text())
|
||||||
|
except (OSError, json.JSONDecodeError):
|
||||||
|
return {}
|
||||||
|
|
||||||
|
|
||||||
|
def active_credential(path: Optional[Path] = None) -> Optional[dict]:
|
||||||
|
"""Return the active credential dict (or ``None``)."""
|
||||||
|
data = load_credentials(path)
|
||||||
|
active_jti = data.get("active_credential_jti")
|
||||||
|
for c in data.get("credentials", []) or []:
|
||||||
|
if c.get("jti") == active_jti:
|
||||||
|
return c
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
def emit_status_audit(path: Optional[Path] = None) -> dict:
|
||||||
|
"""Emit ``auth.status`` audit + return the credentials data."""
|
||||||
|
data = load_credentials(path)
|
||||||
|
_emit_audit("auth.status", active_jti=data.get("active_credential_jti"))
|
||||||
|
return data
|
||||||
|
|
||||||
|
|
||||||
|
def emit_revoke_audit(jti: str) -> None:
|
||||||
|
_emit_audit("auth.revoke", jti=jti)
|
||||||
@@ -218,12 +218,18 @@ def compute(contract_id: str, environment: str,
|
|||||||
return signal
|
return signal
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
def cli_main(argv) -> int:
|
||||||
if len(sys.argv) < 3:
|
"""Thin CLI entry (P1): nova confidence <inputs.json> <environment>."""
|
||||||
print("usage: confidence_signal.py <inputs.json> <environment>", file=sys.stderr)
|
if len(argv) < 3:
|
||||||
sys.exit(2)
|
print("usage: confidence <inputs.json> <environment>", file=sys.stderr)
|
||||||
env = sys.argv[2]
|
return 2
|
||||||
with open(sys.argv[1], "r", encoding="utf-8") as fh:
|
env = argv[2]
|
||||||
|
with open(argv[1], "r", encoding="utf-8") as fh:
|
||||||
inputs = json.load(fh)
|
inputs = json.load(fh)
|
||||||
sig = compute("cli", env, inputs)
|
sig = compute("cli", env, inputs)
|
||||||
print(json.dumps(asdict(sig), indent=2))
|
print(json.dumps(asdict(sig), indent=2))
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
sys.exit(cli_main(sys.argv))
|
||||||
+98
-4
@@ -1,4 +1,4 @@
|
|||||||
"""Environment helper (D-108, REQ-159, REQ-164).
|
"""Environment helper (D-108, REQ-159, REQ-164, REQ-330).
|
||||||
|
|
||||||
During the Nova rebrand transition window (P2–P4), `get_env` read
|
During the Nova rebrand transition window (P2–P4), `get_env` read
|
||||||
`NOVA_*` preferred with the legacy `ACDL_*` name as the fallback. **P5
|
`NOVA_*` preferred with the legacy `ACDL_*` name as the fallback. **P5
|
||||||
@@ -9,14 +9,27 @@ During the Nova rebrand transition window (P2–P4), `get_env` read
|
|||||||
`.env.secrets` shell export in `scripts/run_platform.sh` and the Python
|
`.env.secrets` shell export in `scripts/run_platform.sh` and the Python
|
||||||
parser in `core/regression_verify.py`) were updated to NOVA-only in P5
|
parser in `core/regression_verify.py`) were updated to NOVA-only in P5
|
||||||
(the G-106 dual-read contract was retired with the fallback).
|
(the G-106 dual-read contract was retired with the fallback).
|
||||||
|
|
||||||
|
P2 (REQ-330): `synthesize_local_env(contract_path, environment)` produces
|
||||||
|
a purely synthetic local env dict (account_id placeholder, region
|
||||||
|
"local", no real AWS resources) from a contract YAML. Mirrors the shape
|
||||||
|
of core/environments/*.json (validates against
|
||||||
|
schemas/environment.schema.json) so `nova apply --local` can run the
|
||||||
|
contract resolver + Terraform adapter without provisioning cloud
|
||||||
|
resources. This is the local-tier counterpart of
|
||||||
|
core/onboarding.py:generate_env_file() (the request-path binding
|
||||||
|
generator).
|
||||||
"""
|
"""
|
||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
import os
|
import os
|
||||||
from typing import Optional
|
from pathlib import Path
|
||||||
|
from typing import Any, Dict, Optional
|
||||||
|
|
||||||
__all__ = ["get_env"]
|
import yaml
|
||||||
|
|
||||||
|
__all__ = ["get_env", "synthesize_local_env"]
|
||||||
|
|
||||||
|
|
||||||
def get_env(name: str, default: Optional[str] = None) -> Optional[str]:
|
def get_env(name: str, default: Optional[str] = None) -> Optional[str]:
|
||||||
@@ -28,4 +41,85 @@ def get_env(name: str, default: Optional[str] = None) -> Optional[str]:
|
|||||||
val = os.environ.get(f"NOVA_{name}")
|
val = os.environ.get(f"NOVA_{name}")
|
||||||
if val:
|
if val:
|
||||||
return val
|
return val
|
||||||
return default
|
return default
|
||||||
|
|
||||||
|
|
||||||
|
# Default confidence thresholds per environment name (mirrors the schema
|
||||||
|
# description: dev 0.50, qa 0.75, prod 0.90, dr 0.95). Used by
|
||||||
|
# synthesize_local_env so the synthetic env matches the real env semantics.
|
||||||
|
_DEFAULT_THRESHOLDS: Dict[str, float] = {
|
||||||
|
"dev": 0.50,
|
||||||
|
"qa": 0.75,
|
||||||
|
"prod": 0.90,
|
||||||
|
"dr": 0.95,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def synthesize_local_env(
|
||||||
|
contract_path: str,
|
||||||
|
environment: Optional[str] = None,
|
||||||
|
) -> Dict[str, Any]:
|
||||||
|
"""Synthesize a local env dict from a contract YAML (REQ-330).
|
||||||
|
|
||||||
|
Reads the contract YAML (``yaml.safe_load``), derives a placeholder
|
||||||
|
environment binding that ``nova apply --local`` can use WITHOUT
|
||||||
|
provisioning real AWS resources. The produced dict:
|
||||||
|
|
||||||
|
- ``name`` — the environment name (from the arg or the contract's
|
||||||
|
``environment`` field, defaulting to ``"dev"``).
|
||||||
|
- ``account_id`` — ``"000000000000"`` (the schema-allowed placeholder
|
||||||
|
for an unbound environment; real account id filled by the platform).
|
||||||
|
- ``region`` — ``"local"`` (the local-tier sentinel; never a real
|
||||||
|
AWS region).
|
||||||
|
- ``state_backend`` — ``{bucket: "local-tfstate", lock_table:
|
||||||
|
"local-locks"}`` (local state; LocalS3StateBackend rewrites the
|
||||||
|
terraform backend to ``backend "local"`` using the stack name as
|
||||||
|
the state path, so no S3 bucket is used).
|
||||||
|
- ``network`` — a local RFC1918 CIDR + a single fake AZ.
|
||||||
|
- ``runner_role_arn`` — a placeholder ARN for the local tier.
|
||||||
|
- ``autonomy`` — ``"full"`` (the local tier is autonomous).
|
||||||
|
- ``confidence_threshold`` — the per-env default (0.50 for dev).
|
||||||
|
|
||||||
|
The dict mirrors the shape of ``core/environments/*.json`` and
|
||||||
|
validates against ``schemas/environment.schema.json``. No cloud
|
||||||
|
provisioning occurs — purely synthetic.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
contract_path: Path to the contract YAML file.
|
||||||
|
environment: Optional environment name override (defaults to the
|
||||||
|
contract's ``environment`` field, or ``"dev"``).
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
The synthetic local env dict.
|
||||||
|
"""
|
||||||
|
contract_path_obj = Path(contract_path)
|
||||||
|
contract: Dict[str, Any] = {}
|
||||||
|
if contract_path_obj.is_file():
|
||||||
|
with open(contract_path_obj) as fh:
|
||||||
|
contract = yaml.safe_load(fh) or {}
|
||||||
|
|
||||||
|
env_name = environment or contract.get("environment", "dev")
|
||||||
|
stack_name = contract.get("id", env_name)
|
||||||
|
threshold = _DEFAULT_THRESHOLDS.get(env_name, 0.50)
|
||||||
|
|
||||||
|
return {
|
||||||
|
"name": env_name,
|
||||||
|
"description": (
|
||||||
|
f"Synthetic local-tier environment for contract '{stack_name}' "
|
||||||
|
f"(environment={env_name}). No real AWS resources — generated "
|
||||||
|
f"by core.env.synthesize_local_env (REQ-330) for nova apply --local."
|
||||||
|
),
|
||||||
|
"account_id": "000000000000",
|
||||||
|
"region": "local",
|
||||||
|
"state_backend": {
|
||||||
|
"bucket": "local-tfstate",
|
||||||
|
"lock_table": "local-locks",
|
||||||
|
},
|
||||||
|
"network": {
|
||||||
|
"vpc_cidr": "10.250.0.0/16",
|
||||||
|
"azs": ["local-a"],
|
||||||
|
},
|
||||||
|
"runner_role_arn": "arn:aws:iam::000000000000:role/local-runner",
|
||||||
|
"autonomy": "full",
|
||||||
|
"confidence_threshold": threshold,
|
||||||
|
}
|
||||||
@@ -0,0 +1,51 @@
|
|||||||
|
"""Nova init scaffolding logic (P1, REQ-325).
|
||||||
|
|
||||||
|
Creates .nova/ directory structure + secrets-exclusion .gitignore lines
|
||||||
|
in the current working directory. nova/init.py delegates here so the
|
||||||
|
subcommand stays thin (≤50 lines, ≤3 functions).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
SECRETS_IGNORE_LINES = (
|
||||||
|
"~/.nova/credentials.json",
|
||||||
|
".nova/credentials.json",
|
||||||
|
"*.pem",
|
||||||
|
"*.key",
|
||||||
|
".env",
|
||||||
|
".env.*",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _ensure_gitignore(root: Path, force: bool) -> None:
|
||||||
|
gi = root / ".gitignore"
|
||||||
|
existing = gi.read_text().splitlines() if gi.is_file() else []
|
||||||
|
additions = [ln for ln in SECRETS_IGNORE_LINES if ln not in existing]
|
||||||
|
if not additions:
|
||||||
|
return
|
||||||
|
blob = gi.read_text() if gi.is_file() else ""
|
||||||
|
if blob and not blob.endswith("\n"):
|
||||||
|
blob += "\n"
|
||||||
|
blob += "\n".join(additions) + "\n"
|
||||||
|
gi.write_text(blob)
|
||||||
|
|
||||||
|
|
||||||
|
def scaffold(root: Path | None = None, force: bool = False) -> int:
|
||||||
|
"""Create .nova/ + .nova/contract.yml.attestations/ + .gitignore lines."""
|
||||||
|
root = root or Path.cwd()
|
||||||
|
nova_dir = root / ".nova"
|
||||||
|
attest_dir = nova_dir / "contract.yml.attestations"
|
||||||
|
if nova_dir.exists() and not force:
|
||||||
|
print(f"refusing: {nova_dir} already exists (use --force to overwrite)")
|
||||||
|
return 1
|
||||||
|
nova_dir.mkdir(parents=True, exist_ok=True)
|
||||||
|
attest_dir.mkdir(parents=True, exist_ok=True)
|
||||||
|
_ensure_gitignore(root, force)
|
||||||
|
print(f"scaffolded: {nova_dir} (+ {attest_dir.name}/, .gitignore secrets)")
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
raise SystemExit(scaffold())
|
||||||
@@ -0,0 +1,213 @@
|
|||||||
|
"""JWS-from-PAT key derivation + symmetric attestation (REQ-332, C-5.2).
|
||||||
|
|
||||||
|
C-5.2 grill fix: the "public key derivable from the PAT" acceptance
|
||||||
|
criterion is re-interpreted as a SYMMETRIC scheme. The PAT (Personal
|
||||||
|
Access Token) is the shared secret; the JWS signing key AND the
|
||||||
|
verification key are both derived from the PAT via the same HKDF-SHA256
|
||||||
|
KDF. The JWS uses HMAC-SHA256 (HS256) — a symmetric MAC, not an
|
||||||
|
asymmetric signature.
|
||||||
|
|
||||||
|
Key derivation (NIST SP 800-56C / RFC 5869):
|
||||||
|
key = HKDF-SHA256(
|
||||||
|
input_key_material = PAT.encode(),
|
||||||
|
salt = b"nova-local-attestation",
|
||||||
|
info = b"jws-signing-key",
|
||||||
|
length = 32,
|
||||||
|
)
|
||||||
|
|
||||||
|
The resulting 32-byte key is used both to sign (sign_attestation) and to
|
||||||
|
verify (verify_attestation). Anyone holding the PAT can derive the same
|
||||||
|
key and verify the attestation; without the PAT, the HMAC cannot be
|
||||||
|
forged. This satisfies INV-14..17:
|
||||||
|
|
||||||
|
- INV-14: the signing key is derived from the PAT (no separate key
|
||||||
|
material; no long-lived private key on disk).
|
||||||
|
- INV-15: the key never leaves the derivation (it is recomputed from
|
||||||
|
the PAT on each sign/verify call; not cached, not persisted).
|
||||||
|
- INV-16: the salt + info are fixed constants binding the key to the
|
||||||
|
"nova-local-attestation / jws-signing-key" purpose (key separation).
|
||||||
|
- INV-17: tamper detection via the HMAC verification (verify_attestation
|
||||||
|
raises on any signature mismatch).
|
||||||
|
|
||||||
|
The JWS is the compact serialization:
|
||||||
|
b64url(header).b64url(payload).b64url(signature)
|
||||||
|
where header = {"alg":"HS256","typ":"JWT"}, payload = the JWT claims
|
||||||
|
(the attestation payload dict), and signature = HMAC-SHA256(key,
|
||||||
|
b64url(header) + "." + b64url(payload)).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import hashlib
|
||||||
|
import hmac
|
||||||
|
import json
|
||||||
|
from typing import Any, Dict
|
||||||
|
|
||||||
|
__all__ = [
|
||||||
|
"derive_signing_key",
|
||||||
|
"sign_attestation",
|
||||||
|
"verify_attestation",
|
||||||
|
"JWSValidationError",
|
||||||
|
]
|
||||||
|
|
||||||
|
# Fixed KDF parameters (INV-16: key separation — binds the derived key to
|
||||||
|
# the nova-local-attestation / jws-signing-key purpose).
|
||||||
|
_KDF_SALT = b"nova-local-attestation"
|
||||||
|
_KDF_INFO = b"jws-signing-key"
|
||||||
|
_KDF_LENGTH = 32 # 256-bit key for HMAC-SHA256
|
||||||
|
|
||||||
|
# JWS header for HS256 (symmetric HMAC-SHA256).
|
||||||
|
_JWS_HEADER = {"alg": "HS256", "typ": "JWT"}
|
||||||
|
|
||||||
|
|
||||||
|
class JWSValidationError(Exception):
|
||||||
|
"""Raised when a JWS attestation fails verification (signature mismatch,
|
||||||
|
malformed token, or wrong PAT)."""
|
||||||
|
|
||||||
|
|
||||||
|
def _b64url_encode(data: bytes) -> str:
|
||||||
|
"""RFC 7515 base64url encoding WITHOUT padding (JWS compact form)."""
|
||||||
|
import base64
|
||||||
|
return base64.urlsafe_b64encode(data).rstrip(b"=").decode("ascii")
|
||||||
|
|
||||||
|
|
||||||
|
def _b64url_decode(segment: str) -> bytes:
|
||||||
|
"""RFC 7515 base64url decoding (re-adds stripped padding)."""
|
||||||
|
import base64
|
||||||
|
pad = "=" * (-len(segment) % 4)
|
||||||
|
return base64.urlsafe_b64decode(segment + pad)
|
||||||
|
|
||||||
|
|
||||||
|
def _hkdf_sha256(input_key_material: bytes, salt: bytes, info: bytes, length: int) -> bytes:
|
||||||
|
"""HKDF-SHA256 (RFC 5869).
|
||||||
|
|
||||||
|
Prefers cryptography.hazmat.primitives.kdf.hkdf.HKDF (the cryptography
|
||||||
|
extra); falls back to a hashlib-based implementation if cryptography
|
||||||
|
is unavailable (so the module works in a minimal Lambda runtime).
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
from cryptography.hazmat.primitives.kdf.hkdf import HKDF
|
||||||
|
from cryptography.hazmat.primitives import hashes
|
||||||
|
hkdf = HKDF(
|
||||||
|
algorithm=hashes.SHA256(),
|
||||||
|
length=length,
|
||||||
|
salt=salt,
|
||||||
|
info=info,
|
||||||
|
)
|
||||||
|
return hkdf.derive(input_key_material)
|
||||||
|
except ImportError: # pragma: no cover - fallback path
|
||||||
|
return _hkdf_sha256_hashlib(input_key_material, salt, info, length)
|
||||||
|
|
||||||
|
|
||||||
|
def _hkdf_sha256_hashlib(input_key_material: bytes, salt: bytes, info: bytes, length: int) -> bytes:
|
||||||
|
"""RFC 5869 HKDF-SHA256 using only hashlib + hmac (fallback)."""
|
||||||
|
# Extract: PRK = HMAC-SHA256(salt, IKM)
|
||||||
|
prk = hmac.new(salt, input_key_material, hashlib.sha256).digest()
|
||||||
|
# Expand: T(i) = HMAC-SHA256(PRK, T(i-1) | info | i)
|
||||||
|
okm = b""
|
||||||
|
t = b""
|
||||||
|
block = 0
|
||||||
|
while len(okm) < length:
|
||||||
|
block += 1
|
||||||
|
t = hmac.new(prk, t + info + bytes([block]), hashlib.sha256).digest()
|
||||||
|
okm += t
|
||||||
|
return okm[:length]
|
||||||
|
|
||||||
|
|
||||||
|
def derive_signing_key(pat: str) -> bytes:
|
||||||
|
"""Derive the 32-byte symmetric JWS signing key from a PAT.
|
||||||
|
|
||||||
|
HKDF-SHA256(PAT.encode(), salt=b'nova-local-attestation',
|
||||||
|
info=b'jws-signing-key', length=32).
|
||||||
|
|
||||||
|
The same PAT always yields the same key (deterministic); the key is
|
||||||
|
never cached or persisted (INV-15 — recomputed on each call).
|
||||||
|
"""
|
||||||
|
if not isinstance(pat, str) or not pat:
|
||||||
|
raise ValueError("pat must be a non-empty string")
|
||||||
|
return _hkdf_sha256(
|
||||||
|
input_key_material=pat.encode("utf-8"),
|
||||||
|
salt=_KDF_SALT,
|
||||||
|
info=_KDF_INFO,
|
||||||
|
length=_KDF_LENGTH,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def sign_attestation(payload: Dict[str, Any], pat: str) -> str:
|
||||||
|
"""Produce a compact JWS (HS256) for the attestation payload.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
payload: the JWT claims (the attestation payload dict).
|
||||||
|
pat: the Personal Access Token (shared secret).
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
The compact JWS string: b64url(header).b64url(payload).b64url(signature).
|
||||||
|
The header is {"alg":"HS256","typ":"JWT"}; the payload is the
|
||||||
|
JSON-encoded claims; the signature is HMAC-SHA256(key, header.payload).
|
||||||
|
"""
|
||||||
|
if not isinstance(payload, dict):
|
||||||
|
raise ValueError("payload must be a dict")
|
||||||
|
key = derive_signing_key(pat)
|
||||||
|
header_segment = _b64url_encode(
|
||||||
|
json.dumps(_JWS_HEADER, separators=(",", ":"), sort_keys=True).encode("utf-8")
|
||||||
|
)
|
||||||
|
payload_segment = _b64url_encode(
|
||||||
|
json.dumps(payload, separators=(",", ":"), sort_keys=True).encode("utf-8")
|
||||||
|
)
|
||||||
|
signing_input = f"{header_segment}.{payload_segment}".encode("ascii")
|
||||||
|
signature = hmac.new(key, signing_input, hashlib.sha256).digest()
|
||||||
|
signature_segment = _b64url_encode(signature)
|
||||||
|
return f"{header_segment}.{payload_segment}.{signature_segment}"
|
||||||
|
|
||||||
|
|
||||||
|
def verify_attestation(jws: str, pat: str) -> Dict[str, Any]:
|
||||||
|
"""Verify a compact JWS (HS256) attestation and return the payload.
|
||||||
|
|
||||||
|
Derives the same key from the PAT, recomputes the HMAC, and compares
|
||||||
|
in constant time. Raises JWSValidationError on:
|
||||||
|
- malformed JWS (not 3 segments, bad base64, bad JSON)
|
||||||
|
- signature mismatch (tampering or wrong PAT)
|
||||||
|
- wrong header (alg != HS256)
|
||||||
|
|
||||||
|
Args:
|
||||||
|
jws: the compact JWS string from sign_attestation.
|
||||||
|
pat: the Personal Access Token (shared secret).
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
The decoded payload dict (the JWT claims) on success.
|
||||||
|
"""
|
||||||
|
if not isinstance(jws, str) or not jws:
|
||||||
|
raise JWSValidationError("jws must be a non-empty string")
|
||||||
|
parts = jws.split(".")
|
||||||
|
if len(parts) != 3:
|
||||||
|
raise JWSValidationError(f"malformed JWS: expected 3 segments, got {len(parts)}")
|
||||||
|
header_segment, payload_segment, signature_segment = parts
|
||||||
|
|
||||||
|
# Decode + validate the header.
|
||||||
|
try:
|
||||||
|
header = json.loads(_b64url_decode(header_segment))
|
||||||
|
except (ValueError, json.JSONDecodeError) as e:
|
||||||
|
raise JWSValidationError(f"malformed JWS header: {e}") from e
|
||||||
|
if not isinstance(header, dict) or header.get("alg") != "HS256":
|
||||||
|
raise JWSValidationError(
|
||||||
|
f"unsupported JWS alg: expected HS256, got {header.get('alg')!r}"
|
||||||
|
)
|
||||||
|
|
||||||
|
# Recompute the signature with the key derived from the PAT.
|
||||||
|
key = derive_signing_key(pat)
|
||||||
|
signing_input = f"{header_segment}.{payload_segment}".encode("ascii")
|
||||||
|
expected_signature = hmac.new(key, signing_input, hashlib.sha256).digest()
|
||||||
|
actual_signature = _b64url_decode(signature_segment)
|
||||||
|
if not hmac.compare_digest(expected_signature, actual_signature):
|
||||||
|
raise JWSValidationError(
|
||||||
|
"JWS signature verification failed (tampered token or wrong PAT)"
|
||||||
|
)
|
||||||
|
|
||||||
|
# Decode + return the payload.
|
||||||
|
try:
|
||||||
|
payload = json.loads(_b64url_decode(payload_segment))
|
||||||
|
except (ValueError, json.JSONDecodeError) as e:
|
||||||
|
raise JWSValidationError(f"malformed JWS payload: {e}") from e
|
||||||
|
if not isinstance(payload, dict):
|
||||||
|
raise JWSValidationError("JWS payload is not a JSON object")
|
||||||
|
return payload
|
||||||
@@ -0,0 +1,151 @@
|
|||||||
|
"""KMS-signed JWT issuance for the Nova IdP (REQ-337, REQ-336).
|
||||||
|
|
||||||
|
Signs OIDC tokens with an AWS KMS asymmetric key (``ECC_NIST_P256``,
|
||||||
|
``ECDSA_SHA_256`` → JWS ``ES256``) and exposes the public key as a JWK
|
||||||
|
for the JWKS endpoint (REQ-338).
|
||||||
|
|
||||||
|
## DER → raw ECDSA conversion (the #1 gotcha, RESEARCH §5)
|
||||||
|
|
||||||
|
KMS ``sign()`` returns a **DER-encoded** ASN.1 ECDSA signature. JWS
|
||||||
|
(RFC 7515 §3.1.3) requires the **raw** ``r‖s`` concatenation, each
|
||||||
|
coordinate 32 bytes big-endian. :func:`der_to_raw_ecdsa` performs the
|
||||||
|
conversion via ``cryptography``'s ``decode_dss_signature``. This is the
|
||||||
|
core of REQ-337 and is verified by the CAP-037 round-trip test.
|
||||||
|
|
||||||
|
## Lazy boto3
|
||||||
|
|
||||||
|
``boto3.client("kms")`` is constructed lazily so the module imports
|
||||||
|
without AWS creds (mirrors ``nova_idp_auth.py``). Tests inject a mock
|
||||||
|
client via :func:`set_kms_client_for_testing`.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import base64
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
from typing import Any
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
|
||||||
|
from cryptography.hazmat.primitives.asymmetric.utils import decode_dss_signature
|
||||||
|
from cryptography.hazmat.primitives.asymmetric.ec import (
|
||||||
|
EllipticCurvePublicKey,
|
||||||
|
)
|
||||||
|
from cryptography.hazmat.primitives.serialization import load_der_public_key
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
|
||||||
|
|
||||||
|
# Default KMS key alias for Nova OIDC signing (REQ-337).
|
||||||
|
DEFAULT_KEY_ID = os.environ.get("NOVA_OIDC_KMS_KEY_ID", "alias/nova-oidc-signing")
|
||||||
|
|
||||||
|
_kms_client = None
|
||||||
|
|
||||||
|
|
||||||
|
def _get_kms_client():
|
||||||
|
"""Lazy boto3 KMS client singleton (mirrors nova_idp_auth.py)."""
|
||||||
|
global _kms_client
|
||||||
|
if _kms_client is None:
|
||||||
|
_kms_client = boto3.client("kms")
|
||||||
|
return _kms_client
|
||||||
|
|
||||||
|
|
||||||
|
def set_kms_client_for_testing(client: Any) -> None:
|
||||||
|
"""Inject a mock KMS client for tests (no real AWS calls)."""
|
||||||
|
global _kms_client
|
||||||
|
_kms_client = client
|
||||||
|
|
||||||
|
|
||||||
|
def _b64url(data: bytes) -> str:
|
||||||
|
"""Base64url encode without padding (RFC 7515 §2)."""
|
||||||
|
return base64.urlsafe_b64encode(data).rstrip(b"=").decode("ascii")
|
||||||
|
|
||||||
|
|
||||||
|
def der_to_raw_ecdsa(der_sig: bytes, coord_len: int = 32) -> bytes:
|
||||||
|
"""Convert a DER-encoded ECDSA signature to raw ``r‖s`` (JWS format).
|
||||||
|
|
||||||
|
KMS returns DER; JWS requires raw ``r‖s`` concatenation, each
|
||||||
|
coordinate ``coord_len`` bytes big-endian (32 for P-256, 48 for
|
||||||
|
P-384). Uses ``cryptography``'s ``decode_dss_signature`` to parse
|
||||||
|
the DER, then zero-pads each integer to ``coord_len``.
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
ValueError: if a coordinate does not fit in ``coord_len`` bytes
|
||||||
|
(the integer is larger than the curve allows — indicates a
|
||||||
|
malformed signature or wrong ``coord_len``).
|
||||||
|
"""
|
||||||
|
r, s = decode_dss_signature(der_sig)
|
||||||
|
if r.bit_length() > coord_len * 8 or s.bit_length() > coord_len * 8:
|
||||||
|
raise ValueError(
|
||||||
|
f"ECDSA coordinate does not fit in {coord_len} bytes "
|
||||||
|
f"(r={r.bit_length()} bits, s={s.bit_length()} bits)"
|
||||||
|
)
|
||||||
|
return r.to_bytes(coord_len, "big") + s.to_bytes(coord_len, "big")
|
||||||
|
|
||||||
|
|
||||||
|
def sign_jwt(claims: dict, key_id: str = DEFAULT_KEY_ID) -> str:
|
||||||
|
"""Build + sign a JWT with KMS (REQ-337, REQ-336).
|
||||||
|
|
||||||
|
Args:
|
||||||
|
claims: the JWT claims payload (``sub, aud, iss, exp, iat, jti,
|
||||||
|
roles`` per REQ-336, plus ``typ`` for PATs).
|
||||||
|
key_id: the KMS key ID or alias (default
|
||||||
|
``alias/nova-oidc-signing``).
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
The compact JWS (``header.payload.signature``), ``ES256``,
|
||||||
|
with the signature in raw ``r‖s`` form (DER→raw converted).
|
||||||
|
"""
|
||||||
|
header = {"alg": "ES256", "typ": "JWT", "kid": key_id}
|
||||||
|
signing_input = (
|
||||||
|
_b64url(json.dumps(header, separators=(",", ":"), sort_keys=True).encode())
|
||||||
|
+ "."
|
||||||
|
+ _b64url(json.dumps(claims, separators=(",", ":"), sort_keys=True).encode())
|
||||||
|
)
|
||||||
|
resp = _get_kms_client().sign(
|
||||||
|
KeyId=key_id,
|
||||||
|
Message=signing_input.encode("ascii"),
|
||||||
|
MessageType="RAW",
|
||||||
|
SigningAlgorithm="ECDSA_SHA_256",
|
||||||
|
)
|
||||||
|
der_sig = resp["Signature"]
|
||||||
|
raw_sig = der_to_raw_ecdsa(der_sig)
|
||||||
|
return signing_input + "." + _b64url(raw_sig)
|
||||||
|
|
||||||
|
|
||||||
|
def get_jwk(key_id: str = DEFAULT_KEY_ID) -> dict:
|
||||||
|
"""Fetch the KMS public key and return it as a JWK (REQ-338).
|
||||||
|
|
||||||
|
Calls ``kms.get_public_key`` → DER SPKI → ``cryptography``'s
|
||||||
|
``load_der_public_key`` → JWK ``{"kty":"EC","crv":"P-256","kid":...,
|
||||||
|
"x":...,"y":...}``. The ``x``/``y`` are base64url-encoded
|
||||||
|
big-endian 32-byte coordinates.
|
||||||
|
"""
|
||||||
|
resp = _get_kms_client().get_public_key(KeyId=key_id)
|
||||||
|
pub = load_der_public_key(resp["PublicKey"])
|
||||||
|
if not isinstance(pub, EllipticCurvePublicKey):
|
||||||
|
raise ValueError(
|
||||||
|
f"KMS public key is not an EC key (got {type(pub).__name__})"
|
||||||
|
)
|
||||||
|
nums = pub.public_numbers()
|
||||||
|
# P-256 coordinates are 32 bytes big-endian.
|
||||||
|
x = nums.x.to_bytes(32, "big")
|
||||||
|
y = nums.y.to_bytes(32, "big")
|
||||||
|
return {
|
||||||
|
"kty": "EC",
|
||||||
|
"crv": "P-256",
|
||||||
|
"kid": key_id,
|
||||||
|
"x": _b64url(x),
|
||||||
|
"y": _b64url(y),
|
||||||
|
"alg": "ES256",
|
||||||
|
"use": "sig",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI inspection helper
|
||||||
|
import sys
|
||||||
|
|
||||||
|
if "--print-jwk" in sys.argv:
|
||||||
|
print(json.dumps(get_jwk(), indent=2))
|
||||||
|
else:
|
||||||
|
print("usage: python3 -m core.kms_signing --print-jwks", file=sys.stderr)
|
||||||
@@ -457,65 +457,149 @@ def _onboard_consumer(payload):
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def dispatch_action(payload, event=None):
|
||||||
|
"""Shared business-logic dispatch for the contract ingestor (REQ-329).
|
||||||
|
|
||||||
|
Both the AWS Lambda handler (``lambda_handler``) and the CLI path
|
||||||
|
(``cli_main`` / ``__main__``) call this function so the two paths share
|
||||||
|
a single source of truth for action routing, contract validation, the
|
||||||
|
DynamoDB write, and error reporting (NFR-7 — dual-use, single source).
|
||||||
|
|
||||||
|
Args:
|
||||||
|
payload: the decoded action envelope dict
|
||||||
|
``{ consumerRepo, contractId, contract, environment, action }``.
|
||||||
|
event: the raw Lambda Function-URL event (used for IAM caller
|
||||||
|
identity validation). When ``None`` (the CLI path), the identity
|
||||||
|
check uses the ``NOVA_LAMBDA_LOCAL_BYPASS`` env var — CLI invocations
|
||||||
|
are local-only and do not carry an IAM principal.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
The action result dict (e.g. ``{status, contractId, action, ...}``)
|
||||||
|
on success. Raises ``ValueError`` for validation failures and other
|
||||||
|
exceptions for downstream errors — the caller is responsible for
|
||||||
|
mapping these to the appropriate status code / exit code.
|
||||||
|
"""
|
||||||
|
action = payload.get("action", "submit_contract")
|
||||||
|
# Validate caller identity against the payload (P1-2). The CLI path
|
||||||
|
# passes event=None; the fail-closed check honours the local bypass.
|
||||||
|
_validate_caller_identity(event or {}, payload)
|
||||||
|
if action == "submit_contract":
|
||||||
|
# Validate required fields up front for a clean 400.
|
||||||
|
for field in ("consumerRepo", "contractId", "contract", "environment"):
|
||||||
|
if field not in payload:
|
||||||
|
raise ValueError(f"missing field: {field}")
|
||||||
|
result = _submit_contract(payload)
|
||||||
|
elif action == "report_error":
|
||||||
|
result = _report_error(payload)
|
||||||
|
elif action == "validate_change_request":
|
||||||
|
result = _validate_change_request(payload)
|
||||||
|
elif action == "onboard_consumer":
|
||||||
|
result = _onboard_consumer(payload)
|
||||||
|
else:
|
||||||
|
raise ValueError(f"unknown action: {action}")
|
||||||
|
return result
|
||||||
|
|
||||||
|
|
||||||
|
def _to_http_response(result_or_error):
|
||||||
|
"""Map a dispatch_action result / exception to a Lambda HTTP response.
|
||||||
|
|
||||||
|
Shared error→status mapping so both Lambda + CLI paths interpret errors
|
||||||
|
identically (REQ-329 dual-use).
|
||||||
|
"""
|
||||||
|
if isinstance(result_or_error, Exception):
|
||||||
|
msg = str(result_or_error)
|
||||||
|
if isinstance(result_or_error, ValueError):
|
||||||
|
if "missing IAM caller identity" in msg:
|
||||||
|
return {"statusCode": 401, "body": json.dumps({"error": msg})}
|
||||||
|
return {"statusCode": 400, "body": json.dumps({"error": msg})}
|
||||||
|
return {"statusCode": 500, "body": json.dumps({"error": msg})}
|
||||||
|
return {"statusCode": 200, "body": json.dumps(result_or_error)}
|
||||||
|
|
||||||
|
|
||||||
def lambda_handler(event, context):
|
def lambda_handler(event, context):
|
||||||
"""AWS Lambda handler entry point.
|
"""AWS Lambda handler entry point (thin wrapper, REQ-329 dual-use).
|
||||||
|
|
||||||
Accepts a Function-URL-style event whose ``body`` is a JSON string
|
Accepts a Function-URL-style event whose ``body`` is a JSON string
|
||||||
containing ``{ consumerRepo, contractId, contract, environment, action }``.
|
containing ``{ consumerRepo, contractId, contract, environment, action }``.
|
||||||
|
Parses the Lambda-specific envelope then delegates to the shared
|
||||||
|
``dispatch_action`` business logic.
|
||||||
"""
|
"""
|
||||||
try:
|
try:
|
||||||
body = event.get("body", "{}")
|
body = event.get("body", "{}")
|
||||||
if isinstance(body, str):
|
payload = json.loads(body) if isinstance(body, str) else body
|
||||||
payload = json.loads(body)
|
result = dispatch_action(payload, event=event)
|
||||||
else:
|
return _to_http_response(result)
|
||||||
payload = body
|
|
||||||
action = payload.get("action", "submit_contract")
|
|
||||||
# Validate caller identity against the payload (P1-2).
|
|
||||||
_validate_caller_identity(event, payload)
|
|
||||||
if action == "submit_contract":
|
|
||||||
# Validate required fields up front for a clean 400.
|
|
||||||
for field in ("consumerRepo", "contractId", "contract", "environment"):
|
|
||||||
if field not in payload:
|
|
||||||
return {
|
|
||||||
"statusCode": 400,
|
|
||||||
"body": json.dumps({"error": f"missing field: {field}"}),
|
|
||||||
}
|
|
||||||
result = _submit_contract(payload)
|
|
||||||
elif action == "report_error":
|
|
||||||
result = _report_error(payload)
|
|
||||||
elif action == "validate_change_request":
|
|
||||||
result = _validate_change_request(payload)
|
|
||||||
elif action == "onboard_consumer":
|
|
||||||
result = _onboard_consumer(payload)
|
|
||||||
else:
|
|
||||||
return {
|
|
||||||
"statusCode": 400,
|
|
||||||
"body": json.dumps({"error": f"unknown action: {action}"}),
|
|
||||||
}
|
|
||||||
return {"statusCode": 200, "body": json.dumps(result)}
|
|
||||||
except ValueError as e:
|
|
||||||
# P10 (REQ-174): identity failures are 401, field validation is 400.
|
|
||||||
if "missing IAM caller identity" in str(e):
|
|
||||||
return {"statusCode": 401, "body": json.dumps({"error": str(e)})}
|
|
||||||
return {"statusCode": 400, "body": json.dumps({"error": str(e)})}
|
|
||||||
except Exception as e: # pragma: no cover - defensive top-level guard
|
except Exception as e: # pragma: no cover - defensive top-level guard
|
||||||
return {"statusCode": 500, "body": json.dumps({"error": str(e)})}
|
return _to_http_response(e)
|
||||||
|
|
||||||
|
|
||||||
# --- CLI: --check-readiness (D-133, REQ-218) ---------------------------
|
def cli_main(argv=None):
|
||||||
# Invoked as: python3 -m core.lambda.contract_ingestor --check-readiness <submission.json>
|
"""CLI entry point for the contract ingestor (REQ-329 dual-use).
|
||||||
# Delegates to core.submission_readiness.check_readiness() and prints the
|
|
||||||
# structured ReadinessResult. Exits 0 if ready, 1 if not.
|
Usage:
|
||||||
|
python3 -m core.lambda.contract_ingestor --dispatch <payload.json>
|
||||||
|
python3 -m core.lambda.contract_ingestor --dispatch-stdin < <payload.json>
|
||||||
|
|
||||||
|
Parses the CLI-specific input (a JSON file path or stdin) then delegates
|
||||||
|
to the shared ``dispatch_action`` business logic — the same path as the
|
||||||
|
Lambda handler. Returns a process exit code (0 success, 1 validation
|
||||||
|
error, 2 internal error).
|
||||||
|
"""
|
||||||
|
import sys
|
||||||
|
raw = argv if argv is not None else sys.argv[1:]
|
||||||
|
# The --dispatch flag consumes the next positional arg as a payload path;
|
||||||
|
# --dispatch-stdin reads the payload from stdin.
|
||||||
|
if "--dispatch-stdin" in raw:
|
||||||
|
payload = json.loads(sys.stdin.read())
|
||||||
|
elif "--dispatch" in raw:
|
||||||
|
idx = raw.index("--dispatch")
|
||||||
|
path = raw[idx + 1] if idx + 1 < len(raw) else None
|
||||||
|
if not path:
|
||||||
|
print("Usage: --dispatch <payload.json>", file=sys.stderr)
|
||||||
|
return 2
|
||||||
|
with open(path) as fh:
|
||||||
|
payload = json.loads(fh.read())
|
||||||
|
else:
|
||||||
|
print(
|
||||||
|
"Usage: python3 -m core.lambda.contract_ingestor --dispatch <payload.json>",
|
||||||
|
file=sys.stderr,
|
||||||
|
)
|
||||||
|
return 2
|
||||||
|
try:
|
||||||
|
result = dispatch_action(payload, event=None)
|
||||||
|
sys.stdout.write(json.dumps(result, indent=2) + "\n")
|
||||||
|
return 0
|
||||||
|
except ValueError as e:
|
||||||
|
sys.stderr.write(f"error: {e}\n")
|
||||||
|
return 1
|
||||||
|
except Exception as e: # pragma: no cover - defensive top-level guard
|
||||||
|
sys.stderr.write(f"internal error: {e}\n")
|
||||||
|
return 2
|
||||||
|
|
||||||
|
|
||||||
|
# --- CLI: --check-readiness (D-133, REQ-218) + --dispatch (REQ-329) ----
|
||||||
|
# Invoked as:
|
||||||
|
# python3 -m core.lambda.contract_ingestor --check-readiness <submission.json>
|
||||||
|
# python3 -m core.lambda.contract_ingestor --dispatch <payload.json>
|
||||||
|
# The --check-readiness path delegates to core.submission_readiness; the
|
||||||
|
# --dispatch path is the dual-use CLI entry (REQ-329) that calls the same
|
||||||
|
# dispatch_action() as the Lambda handler.
|
||||||
if __name__ == "__main__": # pragma: no cover - CLI entry
|
if __name__ == "__main__": # pragma: no cover - CLI entry
|
||||||
import sys
|
import sys
|
||||||
if "--check-readiness" in sys.argv:
|
if "--check-readiness" in sys.argv:
|
||||||
sys.path.insert(
|
sys.path.insert(
|
||||||
0, os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
|
0, os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
|
||||||
)
|
)
|
||||||
from core.submission_readiness import cli_main
|
from core.submission_readiness import cli_main as _readiness_cli
|
||||||
|
|
||||||
# Strip the --check-readiness flag; pass the file path.
|
# Strip the --check-readiness flag; pass the file path.
|
||||||
rest = [a for a in sys.argv[1:] if a != "--check-readiness"]
|
rest = [a for a in sys.argv[1:] if a != "--check-readiness"]
|
||||||
sys.exit(cli_main(["check-readiness"] + rest))
|
sys.exit(_readiness_cli(["check-readiness"] + rest))
|
||||||
|
elif "--dispatch" in sys.argv or "--dispatch-stdin" in sys.argv:
|
||||||
|
sys.exit(cli_main())
|
||||||
else:
|
else:
|
||||||
print("Usage: python3 -m core.lambda.contract_ingestor --check-readiness <submission.json>")
|
print(
|
||||||
|
"Usage: python3 -m core.lambda.contract_ingestor "
|
||||||
|
"--check-readiness <submission.json> | --dispatch <payload.json>",
|
||||||
|
file=sys.stderr,
|
||||||
|
)
|
||||||
@@ -0,0 +1,613 @@
|
|||||||
|
"""Nova IdP auth Lambda — sign-up / sign-in / session (REQ-333, REQ-334).
|
||||||
|
|
||||||
|
Invoked via a Function URL (IAM auth) by the Nova CLI and consumer
|
||||||
|
pipelines. Mirrors the ``contract_ingestor.py`` pattern: lazy
|
||||||
|
``boto3.resource`` DynamoDB singleton, env-var table names,
|
||||||
|
``NOVA_LAMBDA_LOCAL_BYPASS`` for local testing, ``__main__`` CLI block
|
||||||
|
for dual-use (REQ-329).
|
||||||
|
|
||||||
|
## Argon2id password hashing (REQ-334, D-228, C-7.2)
|
||||||
|
|
||||||
|
Passwords are hashed with Argon2id via ``argon2-cffi``:
|
||||||
|
|
||||||
|
PasswordHasher(time_cost=3, memory_cost=65536, parallelism=1)
|
||||||
|
|
||||||
|
These are the OWASP minimum parameters (t=3, m=65536 KiB, p=1).
|
||||||
|
Lambda memory **MUST be ≥ 512 MB** (Argon2id memory_cost ~64 MiB +
|
||||||
|
runtime overhead).
|
||||||
|
|
||||||
|
**D-228 (amended) — fail-closed:** there is no maintained pure-Python
|
||||||
|
Argon2 implementation; a pure-Python crypto fallback is a liability
|
||||||
|
(weaker hashing, violates INV-16's spirit). If the ``argon2`` C
|
||||||
|
extension fails to import, the Lambda **fails closed** —
|
||||||
|
``_ARGON2_AVAILABLE`` is set ``False`` at cold-start, and
|
||||||
|
:func:`hash_password` / :func:`verify_password` raise
|
||||||
|
``Argon2UnavailableError``. The handler catches this and returns
|
||||||
|
**HTTP 503** (``{"error": "argon2_unavailable"}``) — **no pure-Python
|
||||||
|
fallback, no weak hash, no crash.** This is verified by the explicit
|
||||||
|
``test_argon2_fail_closed`` test (C-1.2).
|
||||||
|
|
||||||
|
## No raw passwords anywhere (INV-16)
|
||||||
|
|
||||||
|
Raw passwords are NEVER:
|
||||||
|
* written to DynamoDB (only ``password_hash`` is stored),
|
||||||
|
* logged (the handler never logs the password argument),
|
||||||
|
* put in traces / env vars / X-Ray segments.
|
||||||
|
|
||||||
|
Audit events (``auth.sign_up``, ``auth.sign_in``,
|
||||||
|
``auth.session_created``) are emitted to stderr as JSON; they carry the
|
||||||
|
``user_id`` / ``email`` but **never** the password.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import datetime
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
import uuid
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Argon2id — fail-closed import (REQ-334, D-228, C-7.2)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
#
|
||||||
|
# try-import the C extension. If it fails (missing abi3 wheel, wrong
|
||||||
|
# glibc, etc.), _ARGON2_AVAILABLE becomes False and hash/verify raise
|
||||||
|
# Argon2UnavailableError. The handler returns 503. NO pure-Python fallback.
|
||||||
|
_ARGON2_AVAILABLE = False
|
||||||
|
_PasswordHasher = None
|
||||||
|
|
||||||
|
try: # pragma: no cover - import success path covered by round-trip test
|
||||||
|
from argon2 import PasswordHasher
|
||||||
|
from argon2.exceptions import VerifyMismatchError
|
||||||
|
|
||||||
|
_PasswordHasher = PasswordHasher
|
||||||
|
_ARGON2_AVAILABLE = True
|
||||||
|
except ImportError: # pragma: no cover - exercised via mock in tests
|
||||||
|
_ARGON2_AVAILABLE = False
|
||||||
|
|
||||||
|
# Define a stand-in so `verify_password` can raise the right type
|
||||||
|
# even when argon2 isn't importable. VerifyMismatchError is only
|
||||||
|
# raised by verify() which itself raises Argon2UnavailableError first.
|
||||||
|
class VerifyMismatchError(Exception):
|
||||||
|
"""Raised by verify_password when the password does not match."""
|
||||||
|
|
||||||
|
|
||||||
|
class Argon2UnavailableError(Exception):
|
||||||
|
"""Raised when the Argon2 C extension is unavailable (D-228 fail-closed).
|
||||||
|
|
||||||
|
The handler catches this and returns HTTP 503 — no pure-Python
|
||||||
|
fallback, no weak hash.
|
||||||
|
"""
|
||||||
|
|
||||||
|
|
||||||
|
# OWASP-minimum Argon2id parameters (C-7.2):
|
||||||
|
# time_cost=3, memory_cost=65536 KiB (64 MiB), parallelism=1
|
||||||
|
_ARGON2_TIME_COST = 3
|
||||||
|
_ARGON2_MEMORY_COST = 65536 # KiB
|
||||||
|
_ARGON2_PARALLELISM = 1
|
||||||
|
|
||||||
|
|
||||||
|
def _get_hasher():
|
||||||
|
"""Return a PasswordHasher configured with the OWASP-min params.
|
||||||
|
|
||||||
|
Raises Argon2UnavailableError if the C extension is not loaded.
|
||||||
|
"""
|
||||||
|
if not _ARGON2_AVAILABLE or _PasswordHasher is None:
|
||||||
|
raise Argon2UnavailableError(
|
||||||
|
"argon2 C extension unavailable — refusing to hash with a "
|
||||||
|
"weak fallback (D-228 fail-closed)"
|
||||||
|
)
|
||||||
|
return _PasswordHasher(
|
||||||
|
time_cost=_ARGON2_TIME_COST,
|
||||||
|
memory_cost=_ARGON2_MEMORY_COST,
|
||||||
|
parallelism=_ARGON2_PARALLELISM,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def hash_password(password: str) -> str:
|
||||||
|
"""Hash a password with Argon2id (OWASP-min params).
|
||||||
|
|
||||||
|
Returns the Argon2id hash string (includes the salt + params).
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Argon2UnavailableError: if the ``argon2`` C extension is not
|
||||||
|
importable (D-228 fail-closed — NO pure-Python fallback).
|
||||||
|
"""
|
||||||
|
if not _ARGON2_AVAILABLE:
|
||||||
|
raise Argon2UnavailableError(
|
||||||
|
"argon2 C extension unavailable — refusing to hash (D-228)"
|
||||||
|
)
|
||||||
|
# NOTE: the password argument is NEVER logged. Do not add debug
|
||||||
|
# prints here that include `password`.
|
||||||
|
return _get_hasher().hash(password)
|
||||||
|
|
||||||
|
|
||||||
|
def verify_password(password: str, hash_str: str) -> bool:
|
||||||
|
"""Verify a password against an Argon2id hash.
|
||||||
|
|
||||||
|
Returns ``True`` if the password matches.
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Argon2UnavailableError: if the ``argon2`` C extension is not
|
||||||
|
importable.
|
||||||
|
VerifyMismatchError: if the password does not match the hash.
|
||||||
|
"""
|
||||||
|
if not _ARGON2_AVAILABLE:
|
||||||
|
raise Argon2UnavailableError(
|
||||||
|
"argon2 C extension unavailable — refusing to verify (D-228)"
|
||||||
|
)
|
||||||
|
# argon2.PasswordHasher().verify raises VerifyMismatchError on
|
||||||
|
# mismatch (and InvalidHash on a malformed hash). We let those
|
||||||
|
# propagate; the handler maps them to 401 / 500.
|
||||||
|
_get_hasher().verify(hash_str, password)
|
||||||
|
return True
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Config (env-var table names, mirroring contract_ingestor.py)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
USERS_TABLE = os.environ.get("NOVA_USERS_TABLE", "nova-users")
|
||||||
|
SESSIONS_TABLE = os.environ.get("NOVA_SESSIONS_TABLE", "nova-sessions")
|
||||||
|
PASSWORD_RESETS_TABLE = os.environ.get(
|
||||||
|
"NOVA_PASSWORD_RESETS_TABLE", "nova-password-resets"
|
||||||
|
)
|
||||||
|
# Session lifetime (seconds). Default 24h.
|
||||||
|
SESSION_TTL_SECONDS = int(os.environ.get("NOVA_SESSION_TTL_SECONDS", "86400"))
|
||||||
|
# Password-reset token lifetime (seconds). Default 15 min.
|
||||||
|
RESET_TTL_SECONDS = int(os.environ.get("NOVA_RESET_TTL_SECONDS", "900"))
|
||||||
|
|
||||||
|
_dynamodb = None
|
||||||
|
|
||||||
|
|
||||||
|
def _get_dynamodb():
|
||||||
|
"""Lazy boto3 DynamoDB resource singleton (mirrors contract_ingestor)."""
|
||||||
|
global _dynamodb
|
||||||
|
if _dynamodb is None:
|
||||||
|
_dynamodb = boto3.resource("dynamodb")
|
||||||
|
return _dynamodb
|
||||||
|
|
||||||
|
|
||||||
|
def _iso8601_now() -> str:
|
||||||
|
return datetime.datetime.now(datetime.timezone.utc).strftime(
|
||||||
|
"%Y-%m-%dT%H:%M:%SZ"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _epoch_now() -> int:
|
||||||
|
return int(datetime.datetime.now(datetime.timezone.utc).timestamp())
|
||||||
|
|
||||||
|
|
||||||
|
def _emit_audit(event_type: str, **fields) -> None:
|
||||||
|
"""Emit an audit event to stderr as JSON (never includes passwords)."""
|
||||||
|
payload = {"event": event_type, "ts": _iso8601_now(), **fields}
|
||||||
|
# Defense-in-depth: scrub any field literally named 'password' or
|
||||||
|
# 'password_hash' value from the audit payload (they should never be
|
||||||
|
# passed here, but a stray kwarg would leak — INV-16).
|
||||||
|
for _k in ("password", "new_password", "old_password"):
|
||||||
|
payload.pop(_k, None)
|
||||||
|
sys.stderr.write(json.dumps(payload, sort_keys=True) + "\n")
|
||||||
|
sys.stderr.flush()
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Business logic (sign_up / sign_in / create_session / reset flows)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _require(fields, payload):
|
||||||
|
"""Validate required fields; raise ValueError (→ 400) if missing."""
|
||||||
|
for f in fields:
|
||||||
|
if f not in payload or payload[f] in (None, ""):
|
||||||
|
raise ValueError(f"missing field: {f}")
|
||||||
|
|
||||||
|
|
||||||
|
def _lookup_user_by_email(email: str):
|
||||||
|
"""Query nova-users GSI1 (email-index) → return the user item or None."""
|
||||||
|
table = _get_dynamodb().Table(USERS_TABLE)
|
||||||
|
resp = table.query(
|
||||||
|
IndexName="email-index",
|
||||||
|
KeyConditionExpression="email = :e",
|
||||||
|
ExpressionAttributeValues={":e": email},
|
||||||
|
Limit=1,
|
||||||
|
)
|
||||||
|
items = resp.get("Items", [])
|
||||||
|
return items[0] if items else None
|
||||||
|
|
||||||
|
|
||||||
|
def sign_up(payload):
|
||||||
|
"""Create a new user. Fails closed (503) if argon2 is unavailable.
|
||||||
|
|
||||||
|
Payload: { email, password, owner, roles }
|
||||||
|
Writes to nova-users: PK user_id (uuid4), email, password_hash,
|
||||||
|
owner, roles, created_at. The raw password is NEVER stored.
|
||||||
|
"""
|
||||||
|
_require(("email", "password", "owner", "roles"), payload)
|
||||||
|
if not _ARGON2_AVAILABLE:
|
||||||
|
raise Argon2UnavailableError("argon2 unavailable")
|
||||||
|
email = payload["email"]
|
||||||
|
password = payload["password"]
|
||||||
|
owner = payload["owner"]
|
||||||
|
roles = payload["roles"]
|
||||||
|
if not isinstance(roles, list):
|
||||||
|
raise ValueError("roles must be a list")
|
||||||
|
|
||||||
|
# Duplicate-email check → 409.
|
||||||
|
if _lookup_user_by_email(email) is not None:
|
||||||
|
raise _DuplicateEmailError(email)
|
||||||
|
|
||||||
|
user_id = str(uuid.uuid4())
|
||||||
|
password_hash = hash_password(password) # fail-closed here
|
||||||
|
created_at = _iso8601_now()
|
||||||
|
item = {
|
||||||
|
"user_id": user_id,
|
||||||
|
"email": email,
|
||||||
|
"password_hash": password_hash,
|
||||||
|
"owner": owner,
|
||||||
|
"roles": roles,
|
||||||
|
"created_at": created_at,
|
||||||
|
}
|
||||||
|
table = _get_dynamodb().Table(USERS_TABLE)
|
||||||
|
table.put_item(TableName=USERS_TABLE, Item=item)
|
||||||
|
_emit_audit("auth.sign_up", user_id=user_id, email=email)
|
||||||
|
return {
|
||||||
|
"status": "ok",
|
||||||
|
"action": "sign_up",
|
||||||
|
"user_id": user_id,
|
||||||
|
"email": email,
|
||||||
|
"created_at": created_at,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
class _DuplicateEmailError(Exception):
|
||||||
|
"""Raised when sign_up is called with an already-registered email → 409."""
|
||||||
|
|
||||||
|
def __init__(self, email: str):
|
||||||
|
self.email = email
|
||||||
|
super().__init__(f"email already registered: {email}")
|
||||||
|
|
||||||
|
|
||||||
|
def create_session(user_id: str) -> str:
|
||||||
|
"""Create a session row in nova-sessions; return the session_id.
|
||||||
|
|
||||||
|
TTL: expires_at = now + SESSION_TTL_SECONDS (epoch seconds).
|
||||||
|
"""
|
||||||
|
session_id = str(uuid.uuid4())
|
||||||
|
now = _epoch_now()
|
||||||
|
expires_at = now + SESSION_TTL_SECONDS
|
||||||
|
created_at = _iso8601_now()
|
||||||
|
table = _get_dynamodb().Table(SESSIONS_TABLE)
|
||||||
|
table.put_item(
|
||||||
|
TableName=SESSIONS_TABLE,
|
||||||
|
Item={
|
||||||
|
"session_id": session_id,
|
||||||
|
"user_id": user_id,
|
||||||
|
"expires_at": expires_at,
|
||||||
|
"created_at": created_at,
|
||||||
|
},
|
||||||
|
)
|
||||||
|
_emit_audit("auth.session_created", user_id=user_id, session_id=session_id)
|
||||||
|
return session_id
|
||||||
|
|
||||||
|
|
||||||
|
def sign_in(payload):
|
||||||
|
"""Sign in by email + password → return a session_id.
|
||||||
|
|
||||||
|
On wrong password → raises VerifyMismatchError (→ 401).
|
||||||
|
On unknown email → raises _UnknownUserError (→ 401, same code to
|
||||||
|
avoid user-enumeration via timing — the message is generic).
|
||||||
|
On argon2 unavailable → Argon2UnavailableError (→ 503).
|
||||||
|
"""
|
||||||
|
_require(("email", "password"), payload)
|
||||||
|
if not _ARGON2_AVAILABLE:
|
||||||
|
raise Argon2UnavailableError("argon2 unavailable")
|
||||||
|
email = payload["email"]
|
||||||
|
password = payload["password"]
|
||||||
|
user = _lookup_user_by_email(email)
|
||||||
|
if user is None:
|
||||||
|
# Generic 401 — do not reveal whether the email is registered
|
||||||
|
# (user-enumeration defense).
|
||||||
|
raise _UnknownUserError("invalid credentials")
|
||||||
|
try:
|
||||||
|
verify_password(password, user["password_hash"])
|
||||||
|
except VerifyMismatchError:
|
||||||
|
raise _UnknownUserError("invalid credentials")
|
||||||
|
session_id = create_session(user["user_id"])
|
||||||
|
_emit_audit("auth.sign_in", user_id=user["user_id"], email=email)
|
||||||
|
return {
|
||||||
|
"status": "ok",
|
||||||
|
"action": "sign_in",
|
||||||
|
"user_id": user["user_id"],
|
||||||
|
"session_id": session_id,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
class _UnknownUserError(Exception):
|
||||||
|
"""Generic 'invalid credentials' — 401 (no user enumeration)."""
|
||||||
|
|
||||||
|
|
||||||
|
def request_password_reset(payload):
|
||||||
|
"""Generate a reset token (uuid4) → write to nova-password-resets (15 min TTL).
|
||||||
|
|
||||||
|
Returns the token directly (in a real system this would be emailed;
|
||||||
|
for v1.28 it is returned so tests / the CLI can drive reset_password).
|
||||||
|
"""
|
||||||
|
_require(("email",), payload)
|
||||||
|
email = payload["email"]
|
||||||
|
user = _lookup_user_by_email(email)
|
||||||
|
if user is None:
|
||||||
|
# Return ok regardless (no user enumeration via reset endpoint).
|
||||||
|
# We still return a (fake) token shape so the response is uniform;
|
||||||
|
# the token is single-use and reset_password validates against DDB.
|
||||||
|
_emit_audit("auth.password_reset_requested", email=email, found=False)
|
||||||
|
return {
|
||||||
|
"status": "ok",
|
||||||
|
"action": "request_password_reset",
|
||||||
|
"reset_token": None,
|
||||||
|
"message": "if the email is registered, a reset token was issued",
|
||||||
|
}
|
||||||
|
reset_token = str(uuid.uuid4())
|
||||||
|
now = _epoch_now()
|
||||||
|
expires_at = now + RESET_TTL_SECONDS
|
||||||
|
table = _get_dynamodb().Table(PASSWORD_RESETS_TABLE)
|
||||||
|
table.put_item(
|
||||||
|
TableName=PASSWORD_RESETS_TABLE,
|
||||||
|
Item={
|
||||||
|
"reset_token": reset_token,
|
||||||
|
"user_id": user["user_id"],
|
||||||
|
"expires_at": expires_at,
|
||||||
|
"created_at": _iso8601_now(),
|
||||||
|
},
|
||||||
|
)
|
||||||
|
_emit_audit(
|
||||||
|
"auth.password_reset_requested",
|
||||||
|
user_id=user["user_id"],
|
||||||
|
email=email,
|
||||||
|
found=True,
|
||||||
|
)
|
||||||
|
return {
|
||||||
|
"status": "ok",
|
||||||
|
"action": "request_password_reset",
|
||||||
|
"reset_token": reset_token,
|
||||||
|
"expires_at": expires_at,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def reset_password(payload):
|
||||||
|
"""Validate a reset token → set a new password → delete the token.
|
||||||
|
|
||||||
|
Payload: { reset_token, new_password }
|
||||||
|
On invalid/expired token → ValueError (→ 400).
|
||||||
|
On argon2 unavailable → Argon2UnavailableError (→ 503).
|
||||||
|
"""
|
||||||
|
_require(("reset_token", "new_password"), payload)
|
||||||
|
if not _ARGON2_AVAILABLE:
|
||||||
|
raise Argon2UnavailableError("argon2 unavailable")
|
||||||
|
reset_token = payload["reset_token"]
|
||||||
|
new_password = payload["new_password"]
|
||||||
|
resets = _get_dynamodb().Table(PASSWORD_RESETS_TABLE)
|
||||||
|
resp = resets.get_item(
|
||||||
|
TableName=PASSWORD_RESETS_TABLE,
|
||||||
|
Key={"reset_token": reset_token},
|
||||||
|
)
|
||||||
|
item = resp.get("Item")
|
||||||
|
if not item:
|
||||||
|
raise ValueError("invalid or expired reset token")
|
||||||
|
if item.get("expires_at", 0) < _epoch_now():
|
||||||
|
# Token expired (TTL may not have reaped it yet).
|
||||||
|
raise ValueError("reset token expired")
|
||||||
|
user_id = item["user_id"]
|
||||||
|
new_hash = hash_password(new_password) # fail-closed
|
||||||
|
users = _get_dynamodb().Table(USERS_TABLE)
|
||||||
|
users.update_item(
|
||||||
|
TableName=USERS_TABLE,
|
||||||
|
Key={"user_id": user_id},
|
||||||
|
UpdateExpression="SET password_hash = :h",
|
||||||
|
ExpressionAttributeValues={":h": new_hash},
|
||||||
|
)
|
||||||
|
resets.delete_item(
|
||||||
|
TableName=PASSWORD_RESETS_TABLE,
|
||||||
|
Key={"reset_token": reset_token},
|
||||||
|
)
|
||||||
|
_emit_audit("auth.password_reset", user_id=user_id)
|
||||||
|
return {
|
||||||
|
"status": "ok",
|
||||||
|
"action": "reset_password",
|
||||||
|
"user_id": user_id,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Dispatch (shared by Lambda handler + CLI — REQ-329 dual-use)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def dispatch_action(payload, event=None):
|
||||||
|
"""Shared business-logic dispatch for the IdP auth Lambda (REQ-329).
|
||||||
|
|
||||||
|
Both the AWS Lambda handler (``lambda_handler``) and the CLI path
|
||||||
|
(``cli_main`` / ``__main__``) call this so the two paths share a
|
||||||
|
single source of truth for action routing.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
payload: the decoded action envelope dict, e.g.
|
||||||
|
``{ action: "sign_up", email, password, owner, roles }``.
|
||||||
|
event: the raw Lambda Function-URL event (unused for identity —
|
||||||
|
the IAM auth is enforced at the Function URL layer; kept for
|
||||||
|
signature symmetry with contract_ingestor).
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
The action result dict on success. Raises on error — the caller
|
||||||
|
maps exceptions to status codes via :func:`_to_http_response`.
|
||||||
|
"""
|
||||||
|
action = payload.get("action")
|
||||||
|
if action == "sign_up":
|
||||||
|
return sign_up(payload)
|
||||||
|
if action == "sign_in":
|
||||||
|
return sign_in(payload)
|
||||||
|
if action == "create_session":
|
||||||
|
_require(("user_id",), payload)
|
||||||
|
sid = create_session(payload["user_id"])
|
||||||
|
return {"status": "ok", "action": "create_session", "session_id": sid}
|
||||||
|
if action == "request_password_reset":
|
||||||
|
return request_password_reset(payload)
|
||||||
|
if action == "reset_password":
|
||||||
|
return reset_password(payload)
|
||||||
|
raise ValueError(f"unknown action: {action!r}")
|
||||||
|
|
||||||
|
|
||||||
|
def _to_http_response(result_or_error):
|
||||||
|
"""Map a dispatch result / exception to a Lambda HTTP response."""
|
||||||
|
if isinstance(result_or_error, Exception):
|
||||||
|
# Fail-closed: argon2 unavailable → 503 (NO weak hash, NO crash).
|
||||||
|
if isinstance(result_or_error, Argon2UnavailableError):
|
||||||
|
return {
|
||||||
|
"statusCode": 503,
|
||||||
|
"body": json.dumps({"error": "argon2_unavailable"}),
|
||||||
|
}
|
||||||
|
if isinstance(result_or_error, _DuplicateEmailError):
|
||||||
|
return {
|
||||||
|
"statusCode": 409,
|
||||||
|
"body": json.dumps({"error": "email_already_registered"}),
|
||||||
|
}
|
||||||
|
if isinstance(result_or_error, _UnknownUserError):
|
||||||
|
return {
|
||||||
|
"statusCode": 401,
|
||||||
|
"body": json.dumps({"error": "invalid_credentials"}),
|
||||||
|
}
|
||||||
|
if isinstance(result_or_error, ValueError):
|
||||||
|
return {
|
||||||
|
"statusCode": 400,
|
||||||
|
"body": json.dumps({"error": str(result_or_error)}),
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
"statusCode": 500,
|
||||||
|
"body": json.dumps({"error": str(result_or_error)}),
|
||||||
|
}
|
||||||
|
return {"statusCode": 200, "body": json.dumps(result_or_error)}
|
||||||
|
|
||||||
|
|
||||||
|
def lambda_handler(event, context):
|
||||||
|
"""AWS Lambda handler entry point (thin wrapper, REQ-329 dual-use).
|
||||||
|
|
||||||
|
Accepts a Function-URL-style event whose ``body`` is a JSON string
|
||||||
|
containing ``{ action, email, password, ... }``. Parses the envelope
|
||||||
|
then delegates to :func:`dispatch_action`.
|
||||||
|
"""
|
||||||
|
# Fail-closed fast-path: if argon2 is unavailable, sign_up / sign_in /
|
||||||
|
# reset_password all raise Argon2UnavailableError which maps to 503.
|
||||||
|
# We do NOT short-circuit here so non-password actions (create_session)
|
||||||
|
# still work when argon2 is down — only the hashing paths fail closed.
|
||||||
|
try:
|
||||||
|
body = event.get("body", "{}")
|
||||||
|
payload = json.loads(body) if isinstance(body, str) else body
|
||||||
|
result = dispatch_action(payload, event=event)
|
||||||
|
return _to_http_response(result)
|
||||||
|
except Exception as e:
|
||||||
|
return _to_http_response(e)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# CLI (dual-use, REQ-329 pattern)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def cli_main(argv=None):
|
||||||
|
"""CLI entry point for the IdP auth Lambda (REQ-329 dual-use).
|
||||||
|
|
||||||
|
Usage:
|
||||||
|
python3 -m core.lambda.nova_idp_auth --sign-up <email> <password> <owner>
|
||||||
|
python3 -m core.lambda.nova_idp_auth --sign-in <email> <password>
|
||||||
|
python3 -m core.lambda.nova_idp_auth --create-session <user_id>
|
||||||
|
python3 -m core.lambda.nova_idp_auth --request-reset <email>
|
||||||
|
python3 -m core.lambda.nova_idp_auth --reset-password <token> <new_password>
|
||||||
|
python3 -m core.lambda.nova_idp_auth --dispatch <payload.json>
|
||||||
|
python3 -m core.lambda.nova_idp_auth --dispatch-stdin < <payload.json>
|
||||||
|
"""
|
||||||
|
import sys
|
||||||
|
|
||||||
|
raw = argv if argv is not None else sys.argv[1:]
|
||||||
|
local_bypass = os.environ.get("NOVA_LAMBDA_LOCAL_BYPASS")
|
||||||
|
if not local_bypass:
|
||||||
|
os.environ["NOVA_LAMBDA_LOCAL_BYPASS"] = "1"
|
||||||
|
try:
|
||||||
|
if "--dispatch-stdin" in raw:
|
||||||
|
payload = json.loads(sys.stdin.read())
|
||||||
|
elif "--dispatch" in raw:
|
||||||
|
idx = raw.index("--dispatch")
|
||||||
|
path = raw[idx + 1] if idx + 1 < len(raw) else None
|
||||||
|
if not path:
|
||||||
|
print("Usage: --dispatch <payload.json>", file=sys.stderr)
|
||||||
|
return 2
|
||||||
|
with open(path) as fh:
|
||||||
|
payload = json.loads(fh.read())
|
||||||
|
elif "--sign-up" in raw:
|
||||||
|
idx = raw.index("--sign-up")
|
||||||
|
email, password, owner = raw[idx + 1 : idx + 4]
|
||||||
|
roles = ["user"]
|
||||||
|
payload = {
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": email,
|
||||||
|
"password": password,
|
||||||
|
"owner": owner,
|
||||||
|
"roles": roles,
|
||||||
|
}
|
||||||
|
elif "--sign-in" in raw:
|
||||||
|
idx = raw.index("--sign-in")
|
||||||
|
email, password = raw[idx + 1 : idx + 3]
|
||||||
|
payload = {"action": "sign_in", "email": email, "password": password}
|
||||||
|
elif "--create-session" in raw:
|
||||||
|
idx = raw.index("--create-session")
|
||||||
|
user_id = raw[idx + 1]
|
||||||
|
payload = {"action": "create_session", "user_id": user_id}
|
||||||
|
elif "--request-reset" in raw:
|
||||||
|
idx = raw.index("--request-reset")
|
||||||
|
email = raw[idx + 1]
|
||||||
|
payload = {"action": "request_password_reset", "email": email}
|
||||||
|
elif "--reset-password" in raw:
|
||||||
|
idx = raw.index("--reset-password")
|
||||||
|
token, new_password = raw[idx + 1 : idx + 3]
|
||||||
|
payload = {
|
||||||
|
"action": "reset_password",
|
||||||
|
"reset_token": token,
|
||||||
|
"new_password": new_password,
|
||||||
|
}
|
||||||
|
else:
|
||||||
|
print(
|
||||||
|
"Usage: python3 -m core.lambda.nova_idp_auth "
|
||||||
|
"--sign-up <email> <password> <owner> | "
|
||||||
|
"--sign-in <email> <password> | "
|
||||||
|
"--dispatch <payload.json>",
|
||||||
|
file=sys.stderr,
|
||||||
|
)
|
||||||
|
return 2
|
||||||
|
result = dispatch_action(payload, event=None)
|
||||||
|
sys.stdout.write(json.dumps(result, indent=2) + "\n")
|
||||||
|
return 0
|
||||||
|
except Argon2UnavailableError as e:
|
||||||
|
sys.stderr.write(f"error: {e}\n")
|
||||||
|
return 3 # 503-class
|
||||||
|
except ValueError as e:
|
||||||
|
sys.stderr.write(f"error: {e}\n")
|
||||||
|
return 1
|
||||||
|
except _DuplicateEmailError as e:
|
||||||
|
sys.stderr.write(f"error: {e}\n")
|
||||||
|
return 9 # 409-class
|
||||||
|
except _UnknownUserError as e:
|
||||||
|
sys.stderr.write(f"error: {e}\n")
|
||||||
|
return 1 # 401-class
|
||||||
|
except Exception as e: # pragma: no cover - defensive top-level guard
|
||||||
|
sys.stderr.write(f"internal error: {e}\n")
|
||||||
|
return 2
|
||||||
|
finally:
|
||||||
|
if not local_bypass:
|
||||||
|
os.environ.pop("NOVA_LAMBDA_LOCAL_BYPASS", None)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI entry
|
||||||
|
import sys
|
||||||
|
|
||||||
|
sys.exit(cli_main())
|
||||||
@@ -0,0 +1,244 @@
|
|||||||
|
"""CloudFormation snippet for the Nova IdP DynamoDB identity schema (REQ-335).
|
||||||
|
|
||||||
|
This module exports :func:`dynamodb_tables_snippet`, which returns a
|
||||||
|
CloudFormation fragment (a plain ``dict``) defining the four DynamoDB
|
||||||
|
tables that back the Nova identity provider:
|
||||||
|
|
||||||
|
* ``nova-users`` — user records (PK ``user_id``, GSI1 ``email``)
|
||||||
|
* ``nova-sessions`` — session tokens (PK ``session_id``, GSI1
|
||||||
|
``user_id``, TTL ``expires_at``)
|
||||||
|
* ``nova-password-resets`` — reset tokens (PK ``reset_token``, TTL
|
||||||
|
``expires_at`` — 15 min)
|
||||||
|
* ``nova-pats`` — personal access tokens (PK ``jti``, GSI1
|
||||||
|
``sub``, GSI2 ``pat_hash``). This table is consumed in P4 (OIDC/PAT
|
||||||
|
issuance) but is defined here so a single ``nova idp setup``
|
||||||
|
CloudFormation template provisions the complete identity backend.
|
||||||
|
|
||||||
|
Design notes (REQ-335):
|
||||||
|
* All tables use ``BillingMode: PAY_PER_REQUEST`` (on-demand) — the
|
||||||
|
IdP traffic is bursty and unpredictable; provisioned capacity would
|
||||||
|
either throttle or waste money.
|
||||||
|
* PITR (``PointInTimeRecoverySpecification``) is enabled on
|
||||||
|
``nova-users`` — user records are irreplaceable; continuous backup
|
||||||
|
protects against accidental deletes / corrupt writes. The session /
|
||||||
|
reset / PAT tables are ephemeral (TTL-managed) so PITR is not
|
||||||
|
required there, but enabling it is cheap insurance; we enable it on
|
||||||
|
``nova-users`` per REQ-335 and leave the others as on-demand only
|
||||||
|
(TTL is the recovery mechanism for those).
|
||||||
|
* TTL attributes (``expires_at``) are epoch seconds — DynamoDB TTL
|
||||||
|
silently deletes expired items in the background (best-effort, do
|
||||||
|
not rely on for access control; the handler also checks ``expires_at``
|
||||||
|
on read).
|
||||||
|
|
||||||
|
The fragment is composed into the full ``nova idp setup`` template in
|
||||||
|
P4 Wave 8 (``nova idp setup --apply``). The keys in the returned dict
|
||||||
|
are CloudFormation logical resource IDs (``NovaUsersTable``, etc.) so
|
||||||
|
the composer can merge it directly into a template's ``Resources``
|
||||||
|
section.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from typing import Any, Dict
|
||||||
|
|
||||||
|
|
||||||
|
def _attribute(name: str, attr_type: str = "S") -> Dict[str, str]:
|
||||||
|
return {"AttributeName": name, "AttributeType": attr_type}
|
||||||
|
|
||||||
|
|
||||||
|
def _key_schema(name: str, key_type: str = "HASH") -> Dict[str, str]:
|
||||||
|
return {"AttributeName": name, "KeyType": key_type}
|
||||||
|
|
||||||
|
|
||||||
|
def dynamodb_tables_snippet() -> Dict[str, Dict[str, Any]]:
|
||||||
|
"""Return a CloudFormation fragment defining the four IdP DynamoDB tables.
|
||||||
|
|
||||||
|
The returned dict maps logical resource IDs to CloudFormation
|
||||||
|
resource dicts (``Type: AWS::DynamoDB::Table``). It is intended to be
|
||||||
|
merged into the ``Resources`` block of the full
|
||||||
|
``nova idp setup`` template (P4 Wave 8).
|
||||||
|
|
||||||
|
Tables:
|
||||||
|
* ``NovaUsersTable`` (``nova-users``)
|
||||||
|
* ``NovaSessionsTable`` (``nova-sessions``)
|
||||||
|
* ``NovaPasswordResetsTable`` (``nova-password-resets``)
|
||||||
|
* ``NovaPatsTable`` (``nova-pats``)
|
||||||
|
|
||||||
|
All tables are ``PAY_PER_REQUEST`` (on-demand). PITR is enabled on
|
||||||
|
``nova-users`` (REQ-335). TTL is enabled on the three ephemeral
|
||||||
|
tables (``expires_at`` epoch-seconds attribute).
|
||||||
|
"""
|
||||||
|
return {
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
# nova-users — the user directory (PK user_id, GSI1 email).
|
||||||
|
# PITR enabled: user records are irreplaceable.
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
"NovaUsersTable": {
|
||||||
|
"Type": "AWS::DynamoDB::Table",
|
||||||
|
"Properties": {
|
||||||
|
"TableName": "nova-users",
|
||||||
|
"BillingMode": "PAY_PER_REQUEST",
|
||||||
|
"KeySchema": [
|
||||||
|
_key_schema("user_id", "HASH"),
|
||||||
|
],
|
||||||
|
"AttributeDefinitions": [
|
||||||
|
_attribute("user_id", "S"),
|
||||||
|
_attribute("email", "S"),
|
||||||
|
],
|
||||||
|
"GlobalSecondaryIndexes": [
|
||||||
|
{
|
||||||
|
"IndexName": "email-index",
|
||||||
|
"KeySchema": [_key_schema("email", "HASH")],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
},
|
||||||
|
],
|
||||||
|
"PointInTimeRecoverySpecification": {
|
||||||
|
"PointInTimeRecoveryEnabled": True,
|
||||||
|
},
|
||||||
|
# Attribute shape (for documentation / the setup --dry-run
|
||||||
|
# summary; DynamoDB is schemaless so this is not enforced):
|
||||||
|
# user_id String (PK)
|
||||||
|
# email String (GSI1 hash, unique)
|
||||||
|
# password_hash String (Argon2id, never the raw password)
|
||||||
|
# owner String
|
||||||
|
# roles List
|
||||||
|
# created_at String (ISO-8601)
|
||||||
|
"AttributeShape": {
|
||||||
|
"user_id": "String",
|
||||||
|
"email": "String",
|
||||||
|
"password_hash": "String",
|
||||||
|
"owner": "String",
|
||||||
|
"roles": "List",
|
||||||
|
"created_at": "String",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
# nova-sessions — session tokens (PK session_id, GSI1 user_id).
|
||||||
|
# TTL: expires_at (epoch seconds). Sessions live 24h.
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
"NovaSessionsTable": {
|
||||||
|
"Type": "AWS::DynamoDB::Table",
|
||||||
|
"Properties": {
|
||||||
|
"TableName": "nova-sessions",
|
||||||
|
"BillingMode": "PAY_PER_REQUEST",
|
||||||
|
"KeySchema": [
|
||||||
|
_key_schema("session_id", "HASH"),
|
||||||
|
],
|
||||||
|
"AttributeDefinitions": [
|
||||||
|
_attribute("session_id", "S"),
|
||||||
|
_attribute("user_id", "S"),
|
||||||
|
],
|
||||||
|
"GlobalSecondaryIndexes": [
|
||||||
|
{
|
||||||
|
"IndexName": "user_id-index",
|
||||||
|
"KeySchema": [_key_schema("user_id", "HASH")],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
},
|
||||||
|
],
|
||||||
|
"TimeToLiveSpecification": {
|
||||||
|
"AttributeName": "expires_at",
|
||||||
|
"Enabled": True,
|
||||||
|
},
|
||||||
|
"AttributeShape": {
|
||||||
|
"session_id": "String",
|
||||||
|
"user_id": "String",
|
||||||
|
"expires_at": "String (epoch seconds, TTL)",
|
||||||
|
"created_at": "String (ISO-8601)",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
# nova-password-resets — reset tokens (PK reset_token).
|
||||||
|
# TTL: expires_at (epoch seconds). Tokens live 15 min.
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
"NovaPasswordResetsTable": {
|
||||||
|
"Type": "AWS::DynamoDB::Table",
|
||||||
|
"Properties": {
|
||||||
|
"TableName": "nova-password-resets",
|
||||||
|
"BillingMode": "PAY_PER_REQUEST",
|
||||||
|
"KeySchema": [
|
||||||
|
_key_schema("reset_token", "HASH"),
|
||||||
|
],
|
||||||
|
"AttributeDefinitions": [
|
||||||
|
_attribute("reset_token", "S"),
|
||||||
|
],
|
||||||
|
"TimeToLiveSpecification": {
|
||||||
|
"AttributeName": "expires_at",
|
||||||
|
"Enabled": True,
|
||||||
|
},
|
||||||
|
"AttributeShape": {
|
||||||
|
"reset_token": "String",
|
||||||
|
"user_id": "String",
|
||||||
|
"expires_at": "String (epoch seconds, TTL; 15 min)",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
# nova-pats — personal access tokens (PK jti, GSI1 sub, GSI2 pat_hash).
|
||||||
|
# Consumed in P4 (OIDC/PAT issuance) but defined here so the single
|
||||||
|
# CloudFormation template provisions the complete identity backend.
|
||||||
|
# TTL: expires_at (epoch seconds).
|
||||||
|
# -----------------------------------------------------------------
|
||||||
|
"NovaPatsTable": {
|
||||||
|
"Type": "AWS::DynamoDB::Table",
|
||||||
|
"Properties": {
|
||||||
|
"TableName": "nova-pats",
|
||||||
|
"BillingMode": "PAY_PER_REQUEST",
|
||||||
|
"KeySchema": [
|
||||||
|
_key_schema("jti", "HASH"),
|
||||||
|
],
|
||||||
|
"AttributeDefinitions": [
|
||||||
|
_attribute("jti", "S"),
|
||||||
|
_attribute("sub", "S"),
|
||||||
|
_attribute("pat_hash", "S"),
|
||||||
|
],
|
||||||
|
"GlobalSecondaryIndexes": [
|
||||||
|
{
|
||||||
|
"IndexName": "sub-index",
|
||||||
|
"KeySchema": [_key_schema("sub", "HASH")],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"IndexName": "pat_hash-index",
|
||||||
|
"KeySchema": [_key_schema("pat_hash", "HASH")],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
},
|
||||||
|
],
|
||||||
|
"TimeToLiveSpecification": {
|
||||||
|
"AttributeName": "expires_at",
|
||||||
|
"Enabled": True,
|
||||||
|
},
|
||||||
|
"AttributeShape": {
|
||||||
|
"jti": "String (PK)",
|
||||||
|
"sub": "String (GSI1; subject / user_id)",
|
||||||
|
"pat_hash": "String (GSI2; SHA-256 of the PAT for lookup)",
|
||||||
|
"status": "String (active|revoked)",
|
||||||
|
"issued_at": "String (ISO-8601)",
|
||||||
|
"expires_at": "String (epoch seconds, TTL)",
|
||||||
|
"revoked_at": "String (ISO-8601, present iff status=revoked)",
|
||||||
|
"claims": "Map (JWT claims payload)",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def table_names() -> Dict[str, str]:
|
||||||
|
"""Return the logical→physical table-name mapping (for env-var defaults)."""
|
||||||
|
return {
|
||||||
|
"users": "nova-users",
|
||||||
|
"sessions": "nova-sessions",
|
||||||
|
"password_resets": "nova-password-resets",
|
||||||
|
"pats": "nova-pats",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI inspection helper
|
||||||
|
import json
|
||||||
|
import sys
|
||||||
|
|
||||||
|
if "--names" in sys.argv:
|
||||||
|
sys.stdout.write(json.dumps(table_names(), indent=2) + "\n")
|
||||||
|
else:
|
||||||
|
sys.stdout.write(json.dumps(dynamodb_tables_snippet(), indent=2) + "\n")
|
||||||
@@ -0,0 +1,236 @@
|
|||||||
|
"""CloudFormation template for the Nova IdP (REQ-340, REQ-341, C-2.1).
|
||||||
|
|
||||||
|
Composes the DynamoDB snippet (from P3 ``nova_idp_auth_cfn.py``) + 3
|
||||||
|
Lambdas (``nova-idp-auth``, ``nova-idp-token-vend``, ``nova-idp-jwks``)
|
||||||
|
+ KMS key (``alias/nova-oidc-signing``, ``ECC_NIST_P256``,
|
||||||
|
``SIGN_VERIFY``) + function URLs + IAM roles + optional
|
||||||
|
CloudFront/WAF/ACM (when ``public_jwks_domain`` is provided).
|
||||||
|
|
||||||
|
:func:`generate_template` returns a CloudFormation template dict (no
|
||||||
|
troposphere dependency — raw dict → JSON).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
from pathlib import Path
|
||||||
|
from typing import Any, Dict
|
||||||
|
|
||||||
|
|
||||||
|
def _load_auth_cfn():
|
||||||
|
"""Load core/lambda/nova_idp_auth_cfn.py via importlib (`lambda` is reserved)."""
|
||||||
|
p = Path(__file__).parent / "nova_idp_auth_cfn.py"
|
||||||
|
spec = importlib.util.spec_from_file_location("nova_idp_auth_cfn", p)
|
||||||
|
mod = importlib.util.module_from_spec(spec)
|
||||||
|
spec.loader.exec_module(mod)
|
||||||
|
return mod
|
||||||
|
|
||||||
|
|
||||||
|
_auth_cfn = _load_auth_cfn()
|
||||||
|
dynamodb_tables_snippet = _auth_cfn.dynamodb_tables_snippet
|
||||||
|
table_names = _auth_cfn.table_names
|
||||||
|
|
||||||
|
|
||||||
|
def _lambda_role(logical_id: str, table_envs: dict[str, str], kms: bool = False) -> dict:
|
||||||
|
"""Build an IAM role for a Nova IdP Lambda."""
|
||||||
|
statements = [
|
||||||
|
{
|
||||||
|
"Effect": "Allow",
|
||||||
|
"Action": ["logs:CreateLogStream", "logs:PutLogEvents"],
|
||||||
|
"Resource": {"Fn::Sub": "arn:aws:logs:${AWS::Region}:${AWS::AccountId}:log-group:/aws/lambda/*"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"Effect": "Allow",
|
||||||
|
"Action": ["logs:CreateLogGroup"],
|
||||||
|
"Resource": {"Fn::Sub": "arn:aws:logs:${AWS::Region}:${AWS::AccountId}:*"},
|
||||||
|
},
|
||||||
|
]
|
||||||
|
if table_envs:
|
||||||
|
statements.append({
|
||||||
|
"Effect": "Allow",
|
||||||
|
"Action": ["dynamodb:GetItem", "dynamodb:PutItem", "dynamodb:UpdateItem",
|
||||||
|
"dynamodb:Query", "dynamodb:DeleteItem"],
|
||||||
|
"Resource": [
|
||||||
|
{"Fn::Sub": f"arn:aws:dynamodb:${{AWS::Region}}:${{AWS::AccountId}}:table/{name}"}
|
||||||
|
for name in table_envs.values()
|
||||||
|
],
|
||||||
|
})
|
||||||
|
if kms:
|
||||||
|
statements.append({
|
||||||
|
"Effect": "Allow",
|
||||||
|
"Action": ["kms:Sign", "kms:GetPublicKey", "kms:DescribeKey"],
|
||||||
|
"Resource": {"Fn::GetAtt": "NovaOidcSigningKey.Arn"},
|
||||||
|
})
|
||||||
|
return {
|
||||||
|
"Type": "AWS::IAM::Role",
|
||||||
|
"Properties": {
|
||||||
|
"AssumeRolePolicyDocument": {
|
||||||
|
"Version": "2012-10-17",
|
||||||
|
"Statement": [{
|
||||||
|
"Effect": "Allow",
|
||||||
|
"Principal": {"Service": {"Fn::Sub": "lambda.${AWS::Region}.amazonaws.com"}},
|
||||||
|
"Action": "sts:AssumeRole",
|
||||||
|
}],
|
||||||
|
},
|
||||||
|
"Policies": [{"PolicyName": f"{logical_id}Policy", "PolicyDocument": {
|
||||||
|
"Version": "2012-10-17", "Statement": statements,
|
||||||
|
}}],
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _lambda_function(logical_id: str, handler: str, role_ref: str,
|
||||||
|
env_vars: dict[str, str], memory: int = 512) -> dict:
|
||||||
|
return {
|
||||||
|
"Type": "AWS::Lambda::Function",
|
||||||
|
"Properties": {
|
||||||
|
"Handler": handler,
|
||||||
|
"Runtime": "python3.12",
|
||||||
|
"MemorySize": memory,
|
||||||
|
"Timeout": 30,
|
||||||
|
"Role": {"Fn::GetAtt": [role_ref, "Arn"]},
|
||||||
|
"Environment": {"Variables": env_vars},
|
||||||
|
"Code": {"ZipFile": "def lambda_handler(event, context):\n return {}"},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _function_url(logical_id: str, auth_type: str = "AWS_IAM") -> dict:
|
||||||
|
return {
|
||||||
|
"Type": "AWS::Lambda::Url",
|
||||||
|
"Properties": {
|
||||||
|
"TargetFunction": {"Ref": logical_id},
|
||||||
|
"AuthType": auth_type,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def generate_template(public_jwks_domain: str | None = None) -> Dict[str, Any]:
|
||||||
|
"""Generate the full Nova IdP CloudFormation template (REQ-340).
|
||||||
|
|
||||||
|
Args:
|
||||||
|
public_jwks_domain: optional custom domain for the JWKS endpoint.
|
||||||
|
When provided, CloudFront + ACM + WAF resources are added.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
A CloudFormation template dict (``{"Resources": {...}}``).
|
||||||
|
"""
|
||||||
|
resources: Dict[str, Any] = {}
|
||||||
|
# DynamoDB tables (from P3).
|
||||||
|
resources.update(dynamodb_tables_snippet())
|
||||||
|
names = table_names()
|
||||||
|
|
||||||
|
# KMS key (ECC_NIST_P256, SIGN_VERIFY) + alias.
|
||||||
|
resources["NovaOidcSigningKey"] = {
|
||||||
|
"Type": "AWS::KMS::Key",
|
||||||
|
"Properties": {
|
||||||
|
"Description": "Nova OIDC token signing key (REQ-337, ECC_NIST_P256)",
|
||||||
|
"KeySpec": "ECC_NIST_P256",
|
||||||
|
"KeyUsage": "SIGN_VERIFY",
|
||||||
|
"KeyPolicy": {
|
||||||
|
"Version": "2012-10-17",
|
||||||
|
"Statement": [{
|
||||||
|
"Effect": "Allow",
|
||||||
|
"Principal": {"AWS": {"Fn::Sub": "arn:aws:iam::${AWS::AccountId}:root"}},
|
||||||
|
"Action": "kms:*",
|
||||||
|
"Resource": "*",
|
||||||
|
}],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
resources["NovaOidcSigningKeyAlias"] = {
|
||||||
|
"Type": "AWS::KMS::Alias",
|
||||||
|
"Properties": {
|
||||||
|
"AliasName": "alias/nova-oidc-signing",
|
||||||
|
"TargetKeyId": {"Fn::GetAtt": "NovaOidcSigningKey.Arn"},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
# Lambda roles.
|
||||||
|
auth_tables = {"users": names["users"], "sessions": names["sessions"],
|
||||||
|
"password_resets": names["password_resets"]}
|
||||||
|
resources["NovaIdpAuthRole"] = _lambda_role("NovaIdpAuth", auth_tables)
|
||||||
|
resources["NovaIdpTokenVendRole"] = _lambda_role(
|
||||||
|
"NovaIdpTokenVend", {"pats": names["pats"]}, kms=True)
|
||||||
|
resources["NovaIdpJwksRole"] = _lambda_role("NovaIdpJwks", {}, kms=True)
|
||||||
|
|
||||||
|
# Lambda functions.
|
||||||
|
common_env = {
|
||||||
|
"NOVA_USERS_TABLE": names["users"],
|
||||||
|
"NOVA_SESSIONS_TABLE": names["sessions"],
|
||||||
|
"NOVA_PASSWORD_RESETS_TABLE": names["password_resets"],
|
||||||
|
"NOVA_PATS_TABLE": names["pats"],
|
||||||
|
}
|
||||||
|
resources["NovaIdpAuthFunction"] = _lambda_function(
|
||||||
|
"NovaIdpAuth", "nova_idp_auth.lambda_handler", "NovaIdpAuthRole", common_env)
|
||||||
|
resources["NovaIdpTokenVendFunction"] = _lambda_function(
|
||||||
|
"NovaIdpTokenVend", "nova_idp_token_vend.lambda_handler", "NovaIdpTokenVendRole",
|
||||||
|
{**common_env, "NOVA_OIDC_KMS_KEY_ID": "alias/nova-oidc-signing"})
|
||||||
|
resources["NovaIdpJwksFunction"] = _lambda_function(
|
||||||
|
"NovaIdpJwks", "nova_idp_jwks.lambda_handler", "NovaIdpJwksRole",
|
||||||
|
{"NOVA_OIDC_KMS_KEY_ID": "alias/nova-oidc-signing"}, memory=256)
|
||||||
|
|
||||||
|
# Function URLs (auth Lambda: IAM; token-vend: IAM; jwks: NONE — public).
|
||||||
|
resources["NovaIdpAuthUrl"] = _function_url("NovaIdpAuthFunction", "AWS_IAM")
|
||||||
|
resources["NovaIdpTokenVendUrl"] = _function_url("NovaIdpTokenVendFunction", "AWS_IAM")
|
||||||
|
resources["NovaIdpJwksUrl"] = _function_url("NovaIdpJwksFunction", "NONE")
|
||||||
|
|
||||||
|
# Optional: CloudFront + ACM + WAF for a custom JWKS domain.
|
||||||
|
if public_jwks_domain:
|
||||||
|
resources["NovaJwksCloudFront"] = {
|
||||||
|
"Type": "AWS::CloudFront::Distribution",
|
||||||
|
"Properties": {
|
||||||
|
"DistributionConfig": {
|
||||||
|
"Enabled": True,
|
||||||
|
"Aliases": [public_jwks_domain],
|
||||||
|
"Origins": [{
|
||||||
|
"DomainName": {"Fn::GetAtt": "NovaIdpJwksUrl.Endpoint"},
|
||||||
|
"Id": "JwksOrigin",
|
||||||
|
"CustomOriginConfig": {"OriginProtocolPolicy": "https-only"},
|
||||||
|
}],
|
||||||
|
"DefaultCacheBehavior": {
|
||||||
|
"TargetOriginId": "JwksOrigin",
|
||||||
|
"ViewerProtocolPolicy": "redirect-to-https",
|
||||||
|
"ForwardedValues": {"QueryString": False},
|
||||||
|
},
|
||||||
|
"ViewerCertificate": {
|
||||||
|
"AcmCertificateArn": {"Ref": "NovaJwksAcmCert"},
|
||||||
|
"SslSupportMethod": "sni-only",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
},
|
||||||
|
}
|
||||||
|
resources["NovaJwksAcmCert"] = {
|
||||||
|
"Type": "AWS::CertificateManager::Certificate",
|
||||||
|
"Properties": {"DomainName": public_jwks_domain,
|
||||||
|
"ValidationMethod": "DNS"},
|
||||||
|
}
|
||||||
|
resources["NovaJwksWafRateRule"] = {
|
||||||
|
"Type": "AWS::WAFv2::RateBasedRule",
|
||||||
|
"Properties": {
|
||||||
|
"Name": "nova-jwks-rate-limit",
|
||||||
|
"Scope": "CLOUDFRONT",
|
||||||
|
"RateLimit": 100,
|
||||||
|
"Action": {"Block": {}},
|
||||||
|
"ComparisonOperator": "GreaterThan",
|
||||||
|
"AggregateKeyType": "IP",
|
||||||
|
"DefaultCaptchaConfig": {"ImmunityTimeProperty": {"ImmunityTime": 60}},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
return {"Resources": resources}
|
||||||
|
|
||||||
|
|
||||||
|
def resource_summary(template: dict) -> dict[str, int]:
|
||||||
|
"""Return ``{resource_type: count}`` for a template (for --dry-run)."""
|
||||||
|
counts: dict[str, int] = {}
|
||||||
|
for res in template.get("Resources", {}).values():
|
||||||
|
t = res.get("Type", "Unknown")
|
||||||
|
counts[t] = counts.get(t, 0) + 1
|
||||||
|
return counts
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI inspection helper
|
||||||
|
import json, sys
|
||||||
|
domain = sys.argv[1] if len(sys.argv) > 1 else None
|
||||||
|
print(json.dumps(generate_template(domain), indent=2))
|
||||||
@@ -0,0 +1,63 @@
|
|||||||
|
"""Nova IdP JWKS endpoint Lambda (REQ-338, D-230).
|
||||||
|
|
||||||
|
Serves the KMS public key as a JWK in a standard JWKS response. The
|
||||||
|
endpoint is a Lambda function URL with ``AuthType: NONE`` (JWKS is
|
||||||
|
public-key only — configured in CloudFormation, not in code).
|
||||||
|
|
||||||
|
Response:
|
||||||
|
* ``Content-Type: application/json``
|
||||||
|
* ``Cache-Control: public, max-age=3600`` (1h — clients cache the JWKS)
|
||||||
|
* ``Access-Control-Allow-Origin: *`` (JWKS is public)
|
||||||
|
* ``body: {"keys": [<jwk>]}``
|
||||||
|
|
||||||
|
The JWK is built via :func:`core.kms_signing.get_jwk` from the KMS
|
||||||
|
public key (DER SPKI → ``cryptography`` → JWK).
|
||||||
|
|
||||||
|
Dual-use (REQ-329): ``__main__`` CLI block for local testing
|
||||||
|
(``--print-jwks``).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
|
||||||
|
OIDC_KMS_KEY_ID = os.environ.get("NOVA_OIDC_KMS_KEY_ID", "alias/nova-oidc-signing")
|
||||||
|
|
||||||
|
|
||||||
|
def lambda_handler(event, context):
|
||||||
|
"""AWS Lambda handler — serve the JWKS response (REQ-338)."""
|
||||||
|
try:
|
||||||
|
from core.kms_signing import get_jwk
|
||||||
|
jwk = get_jwk(key_id=OIDC_KMS_KEY_ID)
|
||||||
|
return {
|
||||||
|
"statusCode": 200,
|
||||||
|
"headers": {
|
||||||
|
"Content-Type": "application/json",
|
||||||
|
"Cache-Control": "public, max-age=3600",
|
||||||
|
"Access-Control-Allow-Origin": "*",
|
||||||
|
},
|
||||||
|
"body": json.dumps({"keys": [jwk]}),
|
||||||
|
}
|
||||||
|
except Exception as e:
|
||||||
|
return {
|
||||||
|
"statusCode": 500,
|
||||||
|
"headers": {"Content-Type": "application/json"},
|
||||||
|
"body": json.dumps({"error": str(e)}),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def cli_main(argv=None):
|
||||||
|
"""CLI entry point (REQ-329 dual-use). ``--print-jwks`` → stdout."""
|
||||||
|
raw = argv if argv is not None else sys.argv[1:]
|
||||||
|
if "--print-jwks" in raw:
|
||||||
|
resp = lambda_handler({}, None)
|
||||||
|
sys.stdout.write(resp["body"] + "\n")
|
||||||
|
return resp.get("statusCode", 200) - 200
|
||||||
|
print("Usage: python3 -m core.lambda.nova_idp_jwks --print-jwks", file=sys.stderr)
|
||||||
|
return 2
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI entry
|
||||||
|
sys.exit(cli_main())
|
||||||
@@ -0,0 +1,175 @@
|
|||||||
|
"""Nova IdP setup logic — check / apply / verify (REQ-340, REQ-341, C-2.1).
|
||||||
|
|
||||||
|
Backing logic for ``nova idp setup``. The CLI (``nova/idp/setup.py``)
|
||||||
|
is a thin ≤50-line delegate to this module (CAP-034).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import subprocess
|
||||||
|
import sys
|
||||||
|
import tempfile
|
||||||
|
from pathlib import Path
|
||||||
|
from typing import Any
|
||||||
|
|
||||||
|
|
||||||
|
def _load_cfn():
|
||||||
|
"""Load core/lambda/nova_idp_cfn.py via importlib (`lambda` is reserved)."""
|
||||||
|
p = Path(__file__).parent / "nova_idp_cfn.py"
|
||||||
|
spec = importlib.util.spec_from_file_location("nova_idp_cfn", p)
|
||||||
|
mod = importlib.util.module_from_spec(spec)
|
||||||
|
spec.loader.exec_module(mod)
|
||||||
|
return mod
|
||||||
|
|
||||||
|
|
||||||
|
_cfn = _load_cfn()
|
||||||
|
generate_template = _cfn.generate_template
|
||||||
|
resource_summary = _cfn.resource_summary
|
||||||
|
|
||||||
|
|
||||||
|
def check_prerequisites() -> dict[str, Any]:
|
||||||
|
"""Check IdP setup prerequisites (AWS creds, CFN/IAM/KMS perms).
|
||||||
|
|
||||||
|
Returns a report dict:
|
||||||
|
``{"aws_creds": bool, "region": str|None, "missing": [str], "iam_delta": [str]}``
|
||||||
|
"""
|
||||||
|
report: dict[str, Any] = {"aws_creds": False, "region": None, "missing": [], "iam_delta": []}
|
||||||
|
# AWS creds check.
|
||||||
|
try:
|
||||||
|
who = subprocess.check_output(
|
||||||
|
["aws", "sts", "get-caller-identity"], stderr=subprocess.DEVNULL, text=True, timeout=10
|
||||||
|
)
|
||||||
|
report["aws_creds"] = bool(json.loads(who).get("Account"))
|
||||||
|
except Exception:
|
||||||
|
report["missing"].append("aws_credentials (run `aws configure`)")
|
||||||
|
# Region.
|
||||||
|
region = os.environ.get("AWS_DEFAULT_REGION") or os.environ.get("AWS_REGION")
|
||||||
|
report["region"] = region
|
||||||
|
if not region:
|
||||||
|
report["missing"].append("aws_region (set AWS_DEFAULT_REGION)")
|
||||||
|
# IAM policy delta (the grants the deploying principal needs).
|
||||||
|
report["iam_delta"] = [
|
||||||
|
"cloudformation:*",
|
||||||
|
"iam:CreateRole",
|
||||||
|
"iam:PassRole",
|
||||||
|
"lambda:CreateFunction",
|
||||||
|
"lambda:CreateFunctionUrlConfig",
|
||||||
|
"dynamodb:CreateTable",
|
||||||
|
"kms:CreateKey",
|
||||||
|
"kms:CreateAlias",
|
||||||
|
]
|
||||||
|
return report
|
||||||
|
|
||||||
|
|
||||||
|
def generate_and_deploy(
|
||||||
|
public_jwks_domain: str | None = None,
|
||||||
|
dry_run: bool = False,
|
||||||
|
approve_fn=None,
|
||||||
|
) -> dict[str, Any]:
|
||||||
|
"""Generate the CFN template + deploy (REQ-341, NFR-10 y/N approval).
|
||||||
|
|
||||||
|
Args:
|
||||||
|
public_jwks_domain: optional custom JWKS domain.
|
||||||
|
dry_run: if True, print the resource summary only (no deploy).
|
||||||
|
approve_fn: callable returning True/False for the y/N prompt
|
||||||
|
(defaults to stdin readline).
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
``{"template": <dict>, "summary": <dict>, "deployed": bool}``.
|
||||||
|
"""
|
||||||
|
template = generate_template(public_jwks_domain)
|
||||||
|
summary = resource_summary(template)
|
||||||
|
if dry_run:
|
||||||
|
return {"template": template, "summary": summary, "deployed": False}
|
||||||
|
# NFR-10: explicit y/N approval before cloudformation deploy.
|
||||||
|
print("Resource summary:")
|
||||||
|
for rtype, count in sorted(summary.items()):
|
||||||
|
print(f" {rtype}: {count}")
|
||||||
|
# Print template to a temp file + open $PAGER.
|
||||||
|
tmp = tempfile.NamedTemporaryFile(mode="w", suffix=".json", delete=False, encoding="utf-8")
|
||||||
|
json.dump(template, tmp, indent=2); tmp.flush(); tmp.close()
|
||||||
|
pager = os.environ.get("PAGER")
|
||||||
|
if pager and sys.stdin.isatty():
|
||||||
|
try:
|
||||||
|
subprocess.run([pager, tmp.name])
|
||||||
|
except Exception:
|
||||||
|
print(f"(template at {tmp.name})")
|
||||||
|
else:
|
||||||
|
print(f"(template at {tmp.name})")
|
||||||
|
# y/N prompt.
|
||||||
|
if approve_fn is None:
|
||||||
|
answer = input("Apply? [y/N] ").strip().lower()
|
||||||
|
else:
|
||||||
|
answer = "y" if approve_fn() else "n"
|
||||||
|
if answer != "y":
|
||||||
|
print("aborted (no approval)")
|
||||||
|
return {"template": template, "summary": summary, "deployed": False}
|
||||||
|
# cloudformation deploy.
|
||||||
|
stack_name = os.environ.get("NOVA_IDP_STACK_NAME", "nova-idp")
|
||||||
|
try:
|
||||||
|
subprocess.check_call([
|
||||||
|
"aws", "cloudformation", "deploy",
|
||||||
|
"--stack-name", stack_name,
|
||||||
|
"--template-file", tmp.name,
|
||||||
|
"--capabilities", "CAPABILITY_IAM",
|
||||||
|
])
|
||||||
|
deployed = True
|
||||||
|
except Exception as e:
|
||||||
|
print(f"deploy failed: {e}", file=sys.stderr)
|
||||||
|
deployed = False
|
||||||
|
return {"template": template, "summary": summary, "deployed": deployed}
|
||||||
|
|
||||||
|
|
||||||
|
def verify() -> dict[str, Any]:
|
||||||
|
"""Run the KMS round-trip verification (REQ-340 --verify).
|
||||||
|
|
||||||
|
Delegates to the CAP-037 test logic: sign a JWT (mock KMS) → JWKS →
|
||||||
|
pyjwt verify. Returns ``{"passed": bool, "detail": str}``.
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
import jwt as pyjwt
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub_der = priv.public_key().public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
|
||||||
|
class _MockKms:
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
return {"Signature": priv.sign(Message, ec.ECDSA(hashes.SHA256()))}
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": pub_der}
|
||||||
|
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms())
|
||||||
|
token = kms_signing.sign_jwt({"sub": "verify", "exp": 9999999999, "iat": 1, "jti": "v"})
|
||||||
|
jwk = kms_signing.get_jwk()
|
||||||
|
key = pyjwt.PyJWK(jwk).key
|
||||||
|
decoded = pyjwt.decode(token, key, algorithms=["ES256"], options={"verify_aud": False})
|
||||||
|
ok = decoded["sub"] == "verify"
|
||||||
|
return {"passed": ok, "detail": "KMS round-trip OK" if ok else "mismatch"}
|
||||||
|
except Exception as e:
|
||||||
|
return {"passed": False, "detail": f"verify error: {e}"}
|
||||||
|
finally:
|
||||||
|
try:
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI inspection helper
|
||||||
|
mode = sys.argv[1] if len(sys.argv) > 1 else "--check"
|
||||||
|
if mode == "--check":
|
||||||
|
print(json.dumps(check_prerequisites(), indent=2))
|
||||||
|
elif mode == "--dry-run":
|
||||||
|
print(json.dumps(generate_and_deploy(dry_run=True)["summary"], indent=2))
|
||||||
|
elif mode == "--verify":
|
||||||
|
print(json.dumps(verify(), indent=2))
|
||||||
|
else:
|
||||||
|
print("usage: nova_idp_setup.py --check|--dry-run|--verify", file=sys.stderr)
|
||||||
@@ -0,0 +1,401 @@
|
|||||||
|
"""Nova IdP token-vend Lambda — PAT/session → KMS-signed OIDC token
|
||||||
|
(REQ-336, C-6.1/C-7.1 ABAC FAIL-CLOSED, D-229 revocation).
|
||||||
|
|
||||||
|
Accepts a PAT (or session token) and returns a KMS-signed OIDC token
|
||||||
|
with claims ``sub, aud, iss, exp, iat, jti, roles`` (REQ-336).
|
||||||
|
|
||||||
|
## ABAC fail-closed (C-6.1/C-7.1 — INV-17 runtime enforcement)
|
||||||
|
|
||||||
|
The grill's #1 finding: the token-vend Lambda MUST fail closed on ABAC
|
||||||
|
evaluation failure. Concretely, a token is vended **only** when:
|
||||||
|
|
||||||
|
1. The PAT is active (``nova-pats.GetItem(jti, ConsistentRead=True)``
|
||||||
|
returns an item with ``status == "active"`` — D-229; strong read on
|
||||||
|
the main table, GSIs don't support strong reads).
|
||||||
|
2. ``KyvernoJsonEngine.is_configured()`` returns ``True`` **AND**
|
||||||
|
``evaluate_token_vend_policy()`` returns ``allowed=True`` without
|
||||||
|
raising.
|
||||||
|
|
||||||
|
If (2) fails for **any** reason — ``kj`` absent, ``kj`` error, policy
|
||||||
|
parse error, engine raise — the Lambda returns **403** + audit
|
||||||
|
``token.vend.denied`` (reason ``abac_eval_failed``). **Never fail
|
||||||
|
open.** This is verified by ``tests/test_abac_fail_closed.py`` — the
|
||||||
|
most important test of the milestone.
|
||||||
|
|
||||||
|
## Dual-use (REQ-329 pattern)
|
||||||
|
|
||||||
|
Mirrors ``nova_idp_auth.py``: lazy boto3, env-var table names,
|
||||||
|
``NOVA_LAMBDA_LOCAL_BYPASS``, ``__main__`` CLI block, audit emission.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import datetime
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
import time
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Config (env-var table names, mirroring nova_idp_auth.py)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
PATS_TABLE = os.environ.get("NOVA_PATS_TABLE", "nova-pats")
|
||||||
|
SESSIONS_TABLE = os.environ.get("NOVA_SESSIONS_TABLE", "nova-sessions")
|
||||||
|
OIDC_KMS_KEY_ID = os.environ.get("NOVA_OIDC_KMS_KEY_ID", "alias/nova-oidc-signing")
|
||||||
|
OIDC_ISSUER = os.environ.get("NOVA_OIDC_ISSUER", "nova-idp")
|
||||||
|
OIDC_AUDIENCE = os.environ.get("NOVA_OIDC_AUDIENCE", "nova-cli")
|
||||||
|
# OIDC token lifetime (seconds). Default 15 min.
|
||||||
|
OIDC_TTL_SECONDS = int(os.environ.get("NOVA_OIDC_TTL_SECONDS", "900"))
|
||||||
|
|
||||||
|
_dynamodb = None
|
||||||
|
_kms_client = None
|
||||||
|
|
||||||
|
|
||||||
|
def _get_dynamodb():
|
||||||
|
"""Lazy boto3 DynamoDB resource singleton (mirrors contract_ingestor)."""
|
||||||
|
global _dynamodb
|
||||||
|
if _dynamodb is None:
|
||||||
|
_dynamodb = boto3.resource("dynamodb")
|
||||||
|
return _dynamodb
|
||||||
|
|
||||||
|
|
||||||
|
def _iso8601_now() -> str:
|
||||||
|
return datetime.datetime.now(datetime.timezone.utc).strftime(
|
||||||
|
"%Y-%m-%dT%H:%M:%SZ"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _epoch_now() -> int:
|
||||||
|
return int(datetime.datetime.now(datetime.timezone.utc).timestamp())
|
||||||
|
|
||||||
|
|
||||||
|
def _emit_audit(event_type: str, **fields) -> None:
|
||||||
|
"""Emit an audit event to stderr as JSON (never the raw PAT/token)."""
|
||||||
|
payload = {"event": event_type, "ts": _iso8601_now(), **fields}
|
||||||
|
# Defense-in-depth: scrub raw token fields (INV-16/INV-17 spirit).
|
||||||
|
for _k in ("pat", "session_token", "token", "raw_pat"):
|
||||||
|
payload.pop(_k, None)
|
||||||
|
sys.stderr.write(json.dumps(payload, sort_keys=True) + "\n")
|
||||||
|
sys.stderr.flush()
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# PAT / session decoding (decode WITHOUT verifying — signature verified
|
||||||
|
# by KMS public key separately at the JWKS verifier; the revocation
|
||||||
|
# check is the trust anchor here, not the JWT signature).
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _decode_jwt_unverified(token: str) -> dict:
|
||||||
|
"""Decode a JWT's payload without verifying the signature."""
|
||||||
|
try:
|
||||||
|
import jwt as pyjwt
|
||||||
|
return pyjwt.decode(token, options={"verify_signature": False})
|
||||||
|
except Exception:
|
||||||
|
# Fallback: manual base64url decode of the payload segment.
|
||||||
|
parts = token.split(".")
|
||||||
|
if len(parts) < 2:
|
||||||
|
raise ValueError("malformed JWT (expected 3 segments)")
|
||||||
|
import base64
|
||||||
|
pad = parts[1] + "=" * (-len(parts[1]) % 4)
|
||||||
|
return json.loads(base64.urlsafe_b64decode(pad))
|
||||||
|
|
||||||
|
|
||||||
|
def _extract_pat_claims(token: str) -> dict:
|
||||||
|
"""Decode a PAT/session JWT → extract jti, sub, typ, roles, owner, exp."""
|
||||||
|
claims = _decode_jwt_unverified(token)
|
||||||
|
required = ("jti", "sub", "exp")
|
||||||
|
for f in required:
|
||||||
|
if f not in claims:
|
||||||
|
raise ValueError(f"token missing claim: {f}")
|
||||||
|
return claims
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Revocation check (D-229 — strong read on the main table)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _check_pat_active(jti: str) -> tuple[bool, str]:
|
||||||
|
"""Return ``(active, reason)``. Strong read on nova-pats main table.
|
||||||
|
|
||||||
|
D-229: GSIs don't support strongly-consistent reads, so the
|
||||||
|
revocation check uses ``GetItem(PK=jti, ConsistentRead=True)`` on
|
||||||
|
the main table. This satisfies the 60s SLO synchronously (the
|
||||||
|
strong read reflects the latest write — revocation is instant).
|
||||||
|
"""
|
||||||
|
table = _get_dynamodb().Table(PATS_TABLE)
|
||||||
|
resp = table.get_item(
|
||||||
|
TableName=PATS_TABLE,
|
||||||
|
Key={"jti": jti},
|
||||||
|
ConsistentRead=True,
|
||||||
|
)
|
||||||
|
item = resp.get("Item")
|
||||||
|
if item is None:
|
||||||
|
return False, "pat_unknown"
|
||||||
|
status = item.get("status", "active")
|
||||||
|
if status != "active":
|
||||||
|
return False, f"pat_{status}" # pat_revoked, pat_expired, etc.
|
||||||
|
# Expired? (defense-in-depth; TTL may not have reaped it yet)
|
||||||
|
expires_at = item.get("expires_at")
|
||||||
|
if expires_at is not None:
|
||||||
|
try:
|
||||||
|
if int(expires_at) < _epoch_now():
|
||||||
|
return False, "pat_expired"
|
||||||
|
except (ValueError, TypeError):
|
||||||
|
pass
|
||||||
|
return True, "active"
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# ABAC fail-closed (C-6.1/C-7.1)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _build_abac_payload(claims: dict, requested_claims: list[str],
|
||||||
|
target_resource: dict, environment: str,
|
||||||
|
policy_version: str) -> dict:
|
||||||
|
"""Build the ABAC authorization payload (REQ-339, C-5.1)."""
|
||||||
|
return {
|
||||||
|
"subject": {
|
||||||
|
"id": claims.get("sub", ""),
|
||||||
|
"role": (claims.get("roles") or ["unknown"])[0],
|
||||||
|
"owner": claims.get("owner", ""),
|
||||||
|
},
|
||||||
|
"requested_claims": requested_claims,
|
||||||
|
"target_resource": target_resource,
|
||||||
|
"environment": environment,
|
||||||
|
"pat_jti": claims.get("jti", ""),
|
||||||
|
"policy_version": policy_version,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _evaluate_abac_fail_closed(payload: dict) -> tuple[bool, list, str, str]:
|
||||||
|
"""Evaluate ABAC with fail-closed semantics (C-6.1).
|
||||||
|
|
||||||
|
Returns ``(allowed, pcrs, policy_sha, reason)``. On ANY failure
|
||||||
|
(engine not configured, evaluate raises, policy parse error) returns
|
||||||
|
``(False, [], "", "abac_eval_failed")``. **Never fails open.**
|
||||||
|
"""
|
||||||
|
# Lazy imports so the module imports without the engine adapter.
|
||||||
|
from core.policy_engine import get_engine
|
||||||
|
|
||||||
|
# C-6.1: is_configured() check. If kj is absent → fail closed.
|
||||||
|
try:
|
||||||
|
engine = get_engine()
|
||||||
|
if not engine.is_configured():
|
||||||
|
_emit_audit(
|
||||||
|
"token.vend.abac_engine_not_configured",
|
||||||
|
pat_jti=payload.get("pat_jti", ""),
|
||||||
|
)
|
||||||
|
return False, [], "", "abac_eval_failed"
|
||||||
|
except Exception: # noqa: BLE001 - fail closed on any engine check error
|
||||||
|
return False, [], "", "abac_eval_failed"
|
||||||
|
|
||||||
|
# C-6.1: evaluate() raising → fail closed.
|
||||||
|
try:
|
||||||
|
from core.abac_evaluator import evaluate_token_vend_policy
|
||||||
|
allowed, pcrs, policy_sha = evaluate_token_vend_policy(payload)
|
||||||
|
reason = "abac_denied" if not allowed else "ok"
|
||||||
|
return allowed, pcrs, policy_sha, reason
|
||||||
|
except Exception: # noqa: BLE001 - fail closed on any eval error
|
||||||
|
return False, [], "", "abac_eval_failed"
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Token vend (REQ-336)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _build_oidc_claims(pat_claims: dict) -> dict:
|
||||||
|
"""Build the OIDC token claims (REQ-336)."""
|
||||||
|
now = _epoch_now()
|
||||||
|
return {
|
||||||
|
"sub": pat_claims["sub"],
|
||||||
|
"aud": OIDC_AUDIENCE,
|
||||||
|
"iss": OIDC_ISSUER,
|
||||||
|
"exp": now + OIDC_TTL_SECONDS,
|
||||||
|
"iat": now,
|
||||||
|
"jti": pat_claims.get("jti", ""), # carry the PAT jti for tracing
|
||||||
|
"roles": pat_claims.get("roles", []),
|
||||||
|
"typ": "nova_oidc_token", # INV-14: distinguish from developer_pat
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def vend_token(
|
||||||
|
token: str,
|
||||||
|
requested_claims: list[str] | None = None,
|
||||||
|
target_resource: dict | None = None,
|
||||||
|
environment: str | None = None,
|
||||||
|
policy_version: str = "",
|
||||||
|
) -> dict:
|
||||||
|
"""Vend a KMS-signed OIDC token for a PAT/session (REQ-336).
|
||||||
|
|
||||||
|
Returns ``{"token": ..., "expires_at": ...}`` on success. Raises
|
||||||
|
``_DeniedError`` (→ 403) on revocation / ABAC denial.
|
||||||
|
"""
|
||||||
|
requested_claims = requested_claims or ["sub", "roles"]
|
||||||
|
environment = environment or "dev"
|
||||||
|
|
||||||
|
# 1. Decode the PAT/session (without verifying — D-229).
|
||||||
|
pat_claims = _extract_pat_claims(token)
|
||||||
|
jti = pat_claims["jti"]
|
||||||
|
|
||||||
|
# Default target_resource: owner inherits from the PAT subject so
|
||||||
|
# the owner-matches ABAC rule passes for same-tenant vends. Callers
|
||||||
|
# can override with an explicit target_resource.
|
||||||
|
if target_resource is None:
|
||||||
|
target_resource = {
|
||||||
|
"type": "contract",
|
||||||
|
"id": "*",
|
||||||
|
"owner": pat_claims.get("owner", "*"),
|
||||||
|
"environment": environment,
|
||||||
|
}
|
||||||
|
|
||||||
|
# 2. Revocation check (D-229, strong read).
|
||||||
|
active, reason = _check_pat_active(jti)
|
||||||
|
if not active:
|
||||||
|
_emit_audit("token.vend.denied", pat_jti=jti, reason=reason)
|
||||||
|
raise _DeniedError(reason)
|
||||||
|
|
||||||
|
# 3. ABAC eval (C-6.1 FAIL-CLOSED).
|
||||||
|
abac_payload = _build_abac_payload(
|
||||||
|
pat_claims, requested_claims, target_resource, environment, policy_version
|
||||||
|
)
|
||||||
|
allowed, _pcrs, policy_sha, abac_reason = _evaluate_abac_fail_closed(abac_payload)
|
||||||
|
if not allowed:
|
||||||
|
_emit_audit(
|
||||||
|
"token.vend.denied",
|
||||||
|
pat_jti=jti,
|
||||||
|
reason=abac_reason,
|
||||||
|
policy_sha=policy_sha,
|
||||||
|
)
|
||||||
|
raise _DeniedError(abac_reason)
|
||||||
|
|
||||||
|
# 4. KMS sign (REQ-337).
|
||||||
|
from core.kms_signing import sign_jwt
|
||||||
|
oidc_claims = _build_oidc_claims(pat_claims)
|
||||||
|
oidc_token = sign_jwt(oidc_claims, key_id=OIDC_KMS_KEY_ID)
|
||||||
|
_emit_audit(
|
||||||
|
"token.vend.allowed",
|
||||||
|
pat_jti=jti,
|
||||||
|
sub=oidc_claims["sub"],
|
||||||
|
policy_sha=policy_sha,
|
||||||
|
expires_at=oidc_claims["exp"],
|
||||||
|
)
|
||||||
|
return {"token": oidc_token, "expires_at": oidc_claims["exp"]}
|
||||||
|
|
||||||
|
|
||||||
|
class _DeniedError(Exception):
|
||||||
|
"""Raised on revocation / ABAC denial → 403."""
|
||||||
|
|
||||||
|
def __init__(self, reason: str):
|
||||||
|
self.reason = reason
|
||||||
|
super().__init__(f"token vend denied: {reason}")
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Lambda handler + HTTP mapping
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _to_http_response(result_or_error):
|
||||||
|
if isinstance(result_or_error, Exception):
|
||||||
|
if isinstance(result_or_error, _DeniedError):
|
||||||
|
return {
|
||||||
|
"statusCode": 403,
|
||||||
|
"body": json.dumps({"error": "token_vend_denied", "reason": result_or_error.reason}),
|
||||||
|
}
|
||||||
|
if isinstance(result_or_error, ValueError):
|
||||||
|
return {
|
||||||
|
"statusCode": 400,
|
||||||
|
"body": json.dumps({"error": str(result_or_error)}),
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
"statusCode": 500,
|
||||||
|
"body": json.dumps({"error": str(result_or_error)}),
|
||||||
|
}
|
||||||
|
return {"statusCode": 200, "body": json.dumps(result_or_error)}
|
||||||
|
|
||||||
|
|
||||||
|
def lambda_handler(event, context):
|
||||||
|
"""AWS Lambda handler entry point (thin wrapper, REQ-329 dual-use)."""
|
||||||
|
try:
|
||||||
|
body = event.get("body", "{}")
|
||||||
|
payload = json.loads(body) if isinstance(body, str) else body
|
||||||
|
token = payload.get("token") or payload.get("pat") or payload.get("session_token")
|
||||||
|
if not token:
|
||||||
|
raise ValueError("missing field: token (or pat / session_token)")
|
||||||
|
result = vend_token(
|
||||||
|
token=token,
|
||||||
|
requested_claims=payload.get("requested_claims"),
|
||||||
|
target_resource=payload.get("target_resource"),
|
||||||
|
environment=payload.get("environment"),
|
||||||
|
policy_version=payload.get("policy_version", ""),
|
||||||
|
)
|
||||||
|
return _to_http_response(result)
|
||||||
|
except Exception as e:
|
||||||
|
return _to_http_response(e)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# CLI (dual-use, REQ-329 pattern)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def cli_main(argv=None):
|
||||||
|
"""CLI entry point for the token-vend Lambda (REQ-329 dual-use)."""
|
||||||
|
raw = argv if argv is not None else sys.argv[1:]
|
||||||
|
local_bypass = os.environ.get("NOVA_LAMBDA_LOCAL_BYPASS")
|
||||||
|
if not local_bypass:
|
||||||
|
os.environ["NOVA_LAMBDA_LOCAL_BYPASS"] = "1"
|
||||||
|
try:
|
||||||
|
if "--vend-stdin" in raw:
|
||||||
|
payload = json.loads(sys.stdin.read())
|
||||||
|
elif "--vend" in raw:
|
||||||
|
idx = raw.index("--vend")
|
||||||
|
path = raw[idx + 1] if idx + 1 < len(raw) else None
|
||||||
|
if not path:
|
||||||
|
print("Usage: --vend <payload.json>", file=sys.stderr)
|
||||||
|
return 2
|
||||||
|
with open(path) as fh:
|
||||||
|
payload = json.loads(fh.read())
|
||||||
|
else:
|
||||||
|
print(
|
||||||
|
"Usage: python3 -m core.lambda.nova_idp_token_vend "
|
||||||
|
"--vend <payload.json> | --vend-stdin < <payload.json>",
|
||||||
|
file=sys.stderr,
|
||||||
|
)
|
||||||
|
return 2
|
||||||
|
token = payload.get("token") or payload.get("pat") or payload.get("session_token")
|
||||||
|
if not token:
|
||||||
|
print("error: missing token in payload", file=sys.stderr)
|
||||||
|
return 1
|
||||||
|
result = vend_token(
|
||||||
|
token=token,
|
||||||
|
requested_claims=payload.get("requested_claims"),
|
||||||
|
target_resource=payload.get("target_resource"),
|
||||||
|
environment=payload.get("environment"),
|
||||||
|
policy_version=payload.get("policy_version", ""),
|
||||||
|
)
|
||||||
|
sys.stdout.write(json.dumps(result, indent=2) + "\n")
|
||||||
|
return 0
|
||||||
|
except _DeniedError as e:
|
||||||
|
sys.stderr.write(f"error: token vend denied ({e.reason})\n")
|
||||||
|
return 3 # 403-class
|
||||||
|
except ValueError as e:
|
||||||
|
sys.stderr.write(f"error: {e}\n")
|
||||||
|
return 1
|
||||||
|
except Exception as e: # pragma: no cover - defensive top-level guard
|
||||||
|
sys.stderr.write(f"internal error: {e}\n")
|
||||||
|
return 2
|
||||||
|
finally:
|
||||||
|
if not local_bypass:
|
||||||
|
os.environ.pop("NOVA_LAMBDA_LOCAL_BYPASS", None)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI entry
|
||||||
|
sys.exit(cli_main())
|
||||||
@@ -0,0 +1,94 @@
|
|||||||
|
"""Nova client-mode resolver (P1, REQ-327, D-226).
|
||||||
|
|
||||||
|
Priority: --mode flag → NOVA_CLIENT_MODE env → credential type → TTY.
|
||||||
|
No silent fallbacks: every return carries a non-empty selection_reason.
|
||||||
|
|
||||||
|
INV-13: invalid env values are ignored + warned, then fall through.
|
||||||
|
INV-14: credential_type developer_pat/nova_oidc_token + TTY →
|
||||||
|
interactive; + no-TTY → agent. TTY check is sys.stdin.isatty() (D-226).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import logging
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
from typing import Optional, Tuple
|
||||||
|
|
||||||
|
log = logging.getLogger("nova.mode_resolver")
|
||||||
|
|
||||||
|
_VALID_MODES = ("agent", "interactive")
|
||||||
|
_CRED_MODE_TYPES = ("developer_pat", "nova_oidc_token")
|
||||||
|
|
||||||
|
|
||||||
|
def resolve_mode(
|
||||||
|
flag: Optional[str] = None,
|
||||||
|
env_var: Optional[str] = None,
|
||||||
|
credential_type: Optional[str] = None,
|
||||||
|
stdin_isatty: bool = False,
|
||||||
|
) -> Tuple[str, str]:
|
||||||
|
"""Return (mode, selection_reason) honoring D-226 priority."""
|
||||||
|
if flag is not None and flag in _VALID_MODES:
|
||||||
|
return flag, "flag"
|
||||||
|
if env_var is not None and env_var != "":
|
||||||
|
if env_var in _VALID_MODES:
|
||||||
|
return env_var, "env"
|
||||||
|
log.warning(
|
||||||
|
"NOVA_CLIENT_MODE=%r invalid (expected one of %s); ignoring",
|
||||||
|
env_var,
|
||||||
|
_VALID_MODES,
|
||||||
|
)
|
||||||
|
if credential_type in _CRED_MODE_TYPES:
|
||||||
|
mode = "interactive" if stdin_isatty else "agent"
|
||||||
|
return mode, f"credential:{credential_type}"
|
||||||
|
mode = "interactive" if stdin_isatty else "agent"
|
||||||
|
return mode, "tty"
|
||||||
|
|
||||||
|
|
||||||
|
def _read_credential_type(path: Path) -> Optional[str]:
|
||||||
|
"""Read the active credential's type from ~/.nova/credentials.json."""
|
||||||
|
try:
|
||||||
|
data = json.loads(path.read_text())
|
||||||
|
except (OSError, json.JSONDecodeError):
|
||||||
|
return None
|
||||||
|
active_jti = data.get("active_credential_jti")
|
||||||
|
for cred in data.get("credentials", []) or []:
|
||||||
|
if cred.get("jti") == active_jti:
|
||||||
|
return cred.get("type")
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
def resolve_mode_from_env(credential_type: Optional[str] = None) -> Tuple[str, str]:
|
||||||
|
"""Resolve mode using sys.argv, NOVA_CLIENT_MODE, credentials, and TTY.
|
||||||
|
|
||||||
|
Best-effort --mode scan of sys.argv (no full argparse); env var;
|
||||||
|
~/.nova/credentials.json active credential type; sys.stdin.isatty().
|
||||||
|
"""
|
||||||
|
flag: Optional[str] = None
|
||||||
|
argv = sys.argv[1:]
|
||||||
|
for i, tok in enumerate(argv):
|
||||||
|
if tok == "--mode" and i + 1 < len(argv):
|
||||||
|
flag = argv[i + 1]
|
||||||
|
break
|
||||||
|
if tok.startswith("--mode="):
|
||||||
|
flag = tok.split("=", 1)[1]
|
||||||
|
break
|
||||||
|
env_var = os.environ.get("NOVA_CLIENT_MODE")
|
||||||
|
if env_var is not None and env_var == "":
|
||||||
|
env_var = ""
|
||||||
|
if credential_type is None:
|
||||||
|
cred_path = Path.home() / ".nova" / "credentials.json"
|
||||||
|
credential_type = _read_credential_type(cred_path)
|
||||||
|
return resolve_mode(
|
||||||
|
flag=flag,
|
||||||
|
env_var=env_var,
|
||||||
|
credential_type=credential_type,
|
||||||
|
stdin_isatty=sys.stdin.isatty(),
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
mode, reason = resolve_mode_from_env()
|
||||||
|
print(f"mode={mode} reason={reason}")
|
||||||
@@ -0,0 +1,164 @@
|
|||||||
|
"""PAT (personal access token) lifecycle — issue + revoke (REQ-342, REQ-343).
|
||||||
|
|
||||||
|
PATs are signed JWTs (``typ: "developer_pat"``, KMS-signed) that
|
||||||
|
authenticate a developer/service-account to the token-vend Lambda. Only
|
||||||
|
the **hash** is stored in ``nova-pats`` (REQ-343) — the raw PAT is
|
||||||
|
returned to the caller once and never persisted.
|
||||||
|
|
||||||
|
## Max TTL (C-6.2)
|
||||||
|
|
||||||
|
* developer: ≤ 24h (86400s)
|
||||||
|
* service-account: ≤ 1h (3600s)
|
||||||
|
|
||||||
|
Enforced in :func:`issue_pat` via the ``subject_type`` argument.
|
||||||
|
|
||||||
|
## DynamoDB schema (REQ-343)
|
||||||
|
|
||||||
|
* PK: ``jti`` (uuid4)
|
||||||
|
* GSI1: ``sub`` (list PATs for a user)
|
||||||
|
* GSI2: ``pat_hash`` (SHA-256 of the raw PAT for lookup)
|
||||||
|
* ``status``: ``active`` | ``revoked`` (revoked PATs retained for audit)
|
||||||
|
* ``expires_at``: epoch seconds (TTL)
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import datetime
|
||||||
|
import hashlib
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
import uuid
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
|
||||||
|
PATS_TABLE = os.environ.get("NOVA_PATS_TABLE", "nova-pats")
|
||||||
|
OIDC_KMS_KEY_ID = os.environ.get("NOVA_OIDC_KMS_KEY_ID", "alias/nova-oidc-signing")
|
||||||
|
OIDC_ISSUER = os.environ.get("NOVA_OIDC_ISSUER", "nova-idp")
|
||||||
|
|
||||||
|
# C-6.2 max TTLs (seconds).
|
||||||
|
MAX_TTL_DEV = 24 * 3600 # 24h
|
||||||
|
MAX_TTL_SERVICE = 3600 # 1h
|
||||||
|
|
||||||
|
_dynamodb = None
|
||||||
|
|
||||||
|
|
||||||
|
def _get_dynamodb():
|
||||||
|
global _dynamodb
|
||||||
|
if _dynamodb is None:
|
||||||
|
_dynamodb = boto3.resource("dynamodb")
|
||||||
|
return _dynamodb
|
||||||
|
|
||||||
|
|
||||||
|
def _iso8601_now() -> str:
|
||||||
|
return datetime.datetime.now(datetime.timezone.utc).strftime(
|
||||||
|
"%Y-%m-%dT%H:%M:%SZ"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _epoch_now() -> int:
|
||||||
|
return int(datetime.datetime.now(datetime.timezone.utc).timestamp())
|
||||||
|
|
||||||
|
|
||||||
|
def _emit_audit(event_type: str, **fields) -> None:
|
||||||
|
payload = {"event": event_type, "ts": _iso8601_now(), **fields}
|
||||||
|
for _k in ("pat", "raw_pat"):
|
||||||
|
payload.pop(_k, None)
|
||||||
|
sys.stderr.write(json.dumps(payload, sort_keys=True) + "\n")
|
||||||
|
sys.stderr.flush()
|
||||||
|
|
||||||
|
|
||||||
|
def _max_ttl(subject_type: str) -> int:
|
||||||
|
if subject_type == "service-account":
|
||||||
|
return MAX_TTL_SERVICE
|
||||||
|
return MAX_TTL_DEV
|
||||||
|
|
||||||
|
|
||||||
|
def issue_pat(
|
||||||
|
subject: str,
|
||||||
|
roles: list[str],
|
||||||
|
owner: str,
|
||||||
|
ttl_seconds: int,
|
||||||
|
key_id: str = OIDC_KMS_KEY_ID,
|
||||||
|
subject_type: str = "developer",
|
||||||
|
claims: dict | None = None,
|
||||||
|
) -> str:
|
||||||
|
"""Issue a PAT (signed JWT) + store its hash in nova-pats (REQ-342).
|
||||||
|
|
||||||
|
Args:
|
||||||
|
subject: the subject (user_id).
|
||||||
|
roles: the roles to embed in the PAT.
|
||||||
|
owner: the tenant owner.
|
||||||
|
ttl_seconds: requested TTL. Clamped to the C-6.2 max for
|
||||||
|
``subject_type`` (24h dev, 1h service-account).
|
||||||
|
key_id: KMS key ID/alias.
|
||||||
|
subject_type: ``"developer"`` or ``"service-account"``.
|
||||||
|
claims: extra claims to embed.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
The raw PAT JWT string (returned once; only the hash is stored).
|
||||||
|
"""
|
||||||
|
max_ttl = _max_ttl(subject_type)
|
||||||
|
if ttl_seconds > max_ttl:
|
||||||
|
ttl_seconds = max_ttl
|
||||||
|
if ttl_seconds < 1:
|
||||||
|
raise ValueError("ttl_seconds must be >= 1")
|
||||||
|
|
||||||
|
jti = str(uuid.uuid4())
|
||||||
|
now = _epoch_now()
|
||||||
|
exp = now + ttl_seconds
|
||||||
|
pat_claims = {
|
||||||
|
"iss": OIDC_ISSUER,
|
||||||
|
"sub": subject,
|
||||||
|
"typ": "developer_pat",
|
||||||
|
"jti": jti,
|
||||||
|
"iat": now,
|
||||||
|
"exp": exp,
|
||||||
|
"roles": roles,
|
||||||
|
"owner": owner,
|
||||||
|
}
|
||||||
|
if claims:
|
||||||
|
pat_claims.update(claims)
|
||||||
|
|
||||||
|
from core.kms_signing import sign_jwt
|
||||||
|
pat_jwt = sign_jwt(pat_claims, key_id=key_id)
|
||||||
|
|
||||||
|
# Only the hash is stored (REQ-343) — NOT the raw PAT.
|
||||||
|
pat_hash = hashlib.sha256(pat_jwt.encode("ascii")).hexdigest()
|
||||||
|
table = _get_dynamodb().Table(PATS_TABLE)
|
||||||
|
table.put_item(
|
||||||
|
TableName=PATS_TABLE,
|
||||||
|
Item={
|
||||||
|
"jti": jti,
|
||||||
|
"sub": subject,
|
||||||
|
"pat_hash": pat_hash,
|
||||||
|
"status": "active",
|
||||||
|
"issued_at": _iso8601_now(),
|
||||||
|
"expires_at": str(exp),
|
||||||
|
"subject_type": subject_type,
|
||||||
|
"claims": json.dumps(pat_claims),
|
||||||
|
},
|
||||||
|
)
|
||||||
|
_emit_audit("pat.issued", jti=jti, sub=subject, subject_type=subject_type, ttl=ttl_seconds)
|
||||||
|
return pat_jwt
|
||||||
|
|
||||||
|
|
||||||
|
def revoke_pat(jti: str) -> dict:
|
||||||
|
"""Revoke a PAT (D-229, REQ-342). Revoked PATs retained for audit.
|
||||||
|
|
||||||
|
Returns the update response. Audit ``pat.revoked`` emitted.
|
||||||
|
"""
|
||||||
|
table = _get_dynamodb().Table(PATS_TABLE)
|
||||||
|
resp = table.update_item(
|
||||||
|
TableName=PATS_TABLE,
|
||||||
|
Key={"jti": jti},
|
||||||
|
UpdateExpression="SET #s = :rev, revoked_at = :now",
|
||||||
|
ExpressionAttributeNames={"#s": "status"},
|
||||||
|
ExpressionAttributeValues={":rev": "revoked", ":now": _iso8601_now()},
|
||||||
|
)
|
||||||
|
_emit_audit("pat.revoked", jti=jti)
|
||||||
|
return resp
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__": # pragma: no cover - CLI inspection helper
|
||||||
|
print("use nova/auth/login.py and nova/auth/revoke.py", file=sys.stderr)
|
||||||
@@ -0,0 +1,123 @@
|
|||||||
|
# CodeArtifact Provisioning — Status + Fallback (REQ-323, CAP-035)
|
||||||
|
|
||||||
|
> Phase P1 (cli-substrate), milestone v1.28. Owner: backend-engineer.
|
||||||
|
> This document records the CodeArtifact provisioning check outcome for
|
||||||
|
> the `nova-cli` wheel + Lambda layer publish pipeline (REQ-323), the
|
||||||
|
> required IAM grants, and the fallback wheel-index mode the publish
|
||||||
|
> workflow supports when CodeArtifact is not yet provisioned.
|
||||||
|
|
||||||
|
## 1. Provisioning check (best-effort, P1 Wave 4 gate)
|
||||||
|
|
||||||
|
**Target account:** `581513795199` (the Nova platform account).
|
||||||
|
|
||||||
|
**Attempted commands:**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
aws codeartifact list-domains --region us-east-1
|
||||||
|
aws codeartifact describe-repository --domain nova --repository nova-pypi --region us-east-1
|
||||||
|
aws codeartifact list-repositories --domain nova --region us-east-1
|
||||||
|
```
|
||||||
|
|
||||||
|
**Result:** the check could not complete — no AWS credentials were
|
||||||
|
available in the P1 execute environment (`Unable to locate credentials.
|
||||||
|
You can configure credentials by running `aws configure`.`). This is
|
||||||
|
the "fail gracefully" path documented in the task spec: provisioning is
|
||||||
|
**not attempted** from this environment because the required IAM grants
|
||||||
|
are not confirmed for the execute principal.
|
||||||
|
|
||||||
|
**Classification:** P1 blocker for the CodeArtifact mode of the publish
|
||||||
|
workflow's wheel-upload step. The workflow ships with a fallback mode
|
||||||
|
(see §3) so the pipeline is not blocked on CodeArtifact provisioning —
|
||||||
|
it can publish to a private wheel index instead.
|
||||||
|
|
||||||
|
## 2. Required IAM grants (for a follow-up provisioning task)
|
||||||
|
|
||||||
|
To provision + use CodeArtifact as the wheel index, the principal that
|
||||||
|
runs the publish workflow (OIDC role `nova-publish-*` or the spike
|
||||||
|
runner) needs the following grants in account `581513795199`:
|
||||||
|
|
||||||
|
| Action | Scope (example) | Purpose |
|
||||||
|
| --- | --- | --- |
|
||||||
|
| `codeartifact:CreateDomain` | `arn:aws:codeartifact:us-east-1:581513795199:domain/nova` | create the `nova` domain |
|
||||||
|
| `codeartifact:CreateRepository` | `arn:aws:codeartifact:us-east-1:581513795199:repository/nova/*` | create `nova-pypi` (pypi-format) |
|
||||||
|
| `codeartifact:GetRepositoryEndpoint` | `arn:aws:codeartifact:us-east-1:581513795199:repository/nova/nova-pypi` | get the twine/pip endpoint |
|
||||||
|
| `codeartifact:GetAuthorizationToken` | `arn:aws:codeartifact:us-east-1:581513795199:domain/nova/*` | mint short-lived upload token |
|
||||||
|
| `codeartifact:ReadFromRepository` | `arn:aws:codeartifact:us-east-1:581513795199:repository/nova/nova-pypi` | pip install (consumers + the composite action) |
|
||||||
|
| `codeartifact:PublishPackageToRepository` | `arn:aws:codeartifact:us-east-1:581513795199:repository/nova/nova-pypi` | twine upload |
|
||||||
|
| `ssm:PutParameter` / `ssm:GetParameter` | `arn:aws:ssm:us-east-1:581513795199:parameter/nova/layer/*` | CAP-035 version↔ARN mapping |
|
||||||
|
| `lambda:PublishLayerVersion` | `arn:aws:lambda:us-east-1:581513795199:layer:nova-cli` | Lambda layer publish |
|
||||||
|
| `iam:CreateRole` / `iam:PassRole` (already held) | — | only if a dedicated publish OIDC role must be created |
|
||||||
|
|
||||||
|
The domain + repository to provision:
|
||||||
|
|
||||||
|
- **Domain:** `nova`
|
||||||
|
- **Repository:** `nova-pypi` (format: `pypi`)
|
||||||
|
- **Endpoint (twine/pip):**
|
||||||
|
`https://nova-581513795199.d.codeartifact.us-east-1.amazonaws.com/pypi/nova-pypi/`
|
||||||
|
|
||||||
|
Once provisioned, set the repository secret `NOVA_CODEARTIFACT_DOMAIN=nova`
|
||||||
|
on both forges and the publish workflow + composite action will switch
|
||||||
|
to CodeArtifact mode automatically (see §3).
|
||||||
|
|
||||||
|
## 3. Fallback: private wheel index (`NOVA_WHEEL_INDEX`)
|
||||||
|
|
||||||
|
Both the publish workflow (`.github/workflows/publish.yml` and its
|
||||||
|
byte-identical mirror on the dev forge) and the composite action
|
||||||
|
(`.github/actions/nova-cli/action.yml`) support a **fallback mode** that
|
||||||
|
does not require CodeArtifact. The selection is env/secret driven:
|
||||||
|
|
||||||
|
| Mode | Trigger | Upload target | Install source |
|
||||||
|
| --- | --- | --- | --- |
|
||||||
|
| **CodeArtifact** | `NOVA_CODEARTIFACT_DOMAIN` env/secret is set | `aws codeartifact login --tool twine` → twine uploads to the CodeArtifact pypi endpoint | `aws codeartifact login --tool pip` → `pip install nova==<ver>` |
|
||||||
|
| **Fallback index** | `NOVA_CODEARTIFACT_DOMAIN` unset; `TWINE_REPOSITORY_URL` + `TWINE_USERNAME` + `TWINE_PASSWORD` set | `twine upload` to `TWINE_REPOSITORY_URL` | `pip install --index-url $NOVA_WHEEL_INDEX nova==<ver>` |
|
||||||
|
|
||||||
|
The fallback index can be any PEP 503-compliant simple index — e.g. a
|
||||||
|
private package registry hosted on the dev forge, a self-hosted
|
||||||
|
`pypiserver`, or a static S3-backed index. The workflow does not hardcode
|
||||||
|
the index URL; it is supplied via the `NOVA_WHEEL_INDEX` env var (for
|
||||||
|
consumers / the composite action) and `TWINE_REPOSITORY_URL` (for the
|
||||||
|
publish step). This keeps the forge/registry choice deployment-specific
|
||||||
|
and avoids baking any single hostname into the synced workflow files.
|
||||||
|
|
||||||
|
### 3.1 Fallback index shape (when self-hosted)
|
||||||
|
|
||||||
|
A minimal PEP 503 simple index served from a private registry is
|
||||||
|
sufficient. The only required layout per package:
|
||||||
|
|
||||||
|
```
|
||||||
|
/nova/
|
||||||
|
index.html # links to each version's page
|
||||||
|
/nova-<version>-py3-none-any.whl # the wheel (publish workflow uploads this)
|
||||||
|
```
|
||||||
|
|
||||||
|
The publish workflow uploads `dist/nova-<version>-*.whl` via `twine
|
||||||
|
upload` to `TWINE_REPOSITORY_URL`; consumers install via
|
||||||
|
`pip install --index-url "$NOVA_WHEEL_INDEX" nova==<version>`.
|
||||||
|
|
||||||
|
## 4. CAP-035 invariant (unaffected by the index choice)
|
||||||
|
|
||||||
|
Regardless of which wheel index is used, the Lambda layer ARN ↔ wheel
|
||||||
|
version mapping is recorded in SSM and is the source of truth for
|
||||||
|
CAP-035:
|
||||||
|
|
||||||
|
```
|
||||||
|
/nova/layer/nova-cli/version = "<wheel-version>:<layer-arn>"
|
||||||
|
```
|
||||||
|
|
||||||
|
e.g. `1.14.0:arn:aws:lambda:us-east-1:581513795199:layer:nova-cli:3`.
|
||||||
|
The publish workflow writes this parameter atomically after both the
|
||||||
|
wheel upload and the layer publish succeed; if either fails the job
|
||||||
|
fails (merge blocked, REQ-323 AC).
|
||||||
|
|
||||||
|
## 5. Open follow-ups
|
||||||
|
|
||||||
|
1. Provision CodeArtifact domain `nova` + repository `nova-pypi` in
|
||||||
|
`581513795199` once the `codeartifact:*` grants in §2 are attached to
|
||||||
|
the publish OIDC role. Update this document with the confirmed ARN +
|
||||||
|
endpoint.
|
||||||
|
2. Set the `NOVA_CODEARTIFACT_DOMAIN` repository secret on both forges
|
||||||
|
to switch the publish workflow + composite action from fallback-index
|
||||||
|
mode to CodeArtifact mode.
|
||||||
|
3. Until §1 is done, the fallback index must be provisioned out of band
|
||||||
|
and its URL exposed to consumers via the `NOVA_WHEEL_INDEX` env var
|
||||||
|
(and to the publish workflow via the `TWINE_*` secrets).
|
||||||
@@ -0,0 +1,334 @@
|
|||||||
|
# Developer Guide — Nova Auth (`nova auth`)
|
||||||
|
|
||||||
|
> **REQ-346** — developer guide for `nova auth login`. Covers signup,
|
||||||
|
> signin, login, mode resolution, TTY vs piped stdout behavior, and the
|
||||||
|
> JWS-from-PAT KDF (REQ-332, C-5.2).
|
||||||
|
>
|
||||||
|
> Audience: developers using the Nova CLI to authenticate and run
|
||||||
|
> `nova apply`. For operator-side identity stack deployment, see
|
||||||
|
> `docs/operator-guide-idp.md`.
|
||||||
|
|
||||||
|
## 1. Quickstart (5 steps)
|
||||||
|
|
||||||
|
```sh
|
||||||
|
# 1. Sign up (one-time per user).
|
||||||
|
nova auth signup --email alice@example.com --owner team-a
|
||||||
|
|
||||||
|
# 2. Sign in (returns a session — valid 24h).
|
||||||
|
nova auth signin --email alice@example.com
|
||||||
|
|
||||||
|
# 3. Issue a PAT and log in (session → OIDC token, stored locally).
|
||||||
|
nova auth login --pat <PAT>
|
||||||
|
|
||||||
|
# 4. Initialize a project (one-time per repo).
|
||||||
|
nova init
|
||||||
|
|
||||||
|
# 5. Apply locally + sign a local-review attestation.
|
||||||
|
nova apply --local --sign-local-review --contract .nova/contract.yml --pat <PAT>
|
||||||
|
```
|
||||||
|
|
||||||
|
After step 3, `~/.nova/credentials.json` holds your active OIDC token
|
||||||
|
(see §4). After step 5, the attestation is a JWS verifiable with the
|
||||||
|
PAT-derived key (see §7).
|
||||||
|
|
||||||
|
## 2. `nova auth signup`
|
||||||
|
|
||||||
|
Creates a user in the `nova-users` DynamoDB table. The password is
|
||||||
|
hashed with **Argon2id** (OWASP-minimum parameters: `time_cost=3,
|
||||||
|
memory_cost=65536 KiB, parallelism=1`) — the raw password is **never**
|
||||||
|
stored, logged, or put in any env var (INV-16).
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova auth signup --email alice@example.com --password '...' --owner team-a
|
||||||
|
```
|
||||||
|
|
||||||
|
What happens server-side (the `nova-idp-auth` Lambda):
|
||||||
|
1. Validates the payload (`email`, `password`, `owner`, `roles`).
|
||||||
|
2. Checks for a duplicate email → `409` if already registered.
|
||||||
|
3. `hash_password(password)` → Argon2id hash string.
|
||||||
|
4. `PutItem` into `nova-users` (`user_id`, `email`, `password_hash`,
|
||||||
|
`owner`, `roles`, `created_at`).
|
||||||
|
5. Emits `auth.sign_up` audit event (carries `user_id` + `email`,
|
||||||
|
never the password).
|
||||||
|
|
||||||
|
If the Argon2 C extension is unavailable, the Lambda returns **503**
|
||||||
|
(fail-closed — no weak hash, no pure-Python fallback; D-228).
|
||||||
|
|
||||||
|
## 3. `nova auth signin`
|
||||||
|
|
||||||
|
Verifies the password and returns a session token.
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova auth signin --email alice@example.com --password '...'
|
||||||
|
```
|
||||||
|
|
||||||
|
The Lambda:
|
||||||
|
1. Looks up the user by email (GSI `email-index` on `nova-users`).
|
||||||
|
2. `verify_password(password, stored_hash)` — Argon2id verify.
|
||||||
|
3. On mismatch or unknown email → `401 invalid_credentials` (the same
|
||||||
|
message for both, so an attacker can't enumerate emails by timing).
|
||||||
|
4. On success: `create_session(user_id)` writes a row to `nova-sessions`
|
||||||
|
(TTL 24h) and returns `session_id`.
|
||||||
|
|
||||||
|
## 4. `nova auth login`
|
||||||
|
|
||||||
|
Exchanges a PAT (or session) for a Nova OIDC token and stores it
|
||||||
|
locally.
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova auth login --pat <PAT>
|
||||||
|
# or
|
||||||
|
nova auth login --session <session_token>
|
||||||
|
```
|
||||||
|
|
||||||
|
The flow:
|
||||||
|
1. The CLI calls the `nova-idp-token-vend` Lambda with the PAT.
|
||||||
|
2. The Lambda decodes the PAT's `jti`, does a **strongly-consistent**
|
||||||
|
`GetItem` on `nova-pats` (D-229 — revocation is reflected on the
|
||||||
|
next vend, within 60s P95).
|
||||||
|
3. Evaluates the ABAC policy (`platform/abac/token-vend.policy`) —
|
||||||
|
fail-closed (C-6.1). If the policy engine is unavailable or the
|
||||||
|
policy denies, the vend returns `403`.
|
||||||
|
4. Signs the OIDC token via KMS (`alias/nova-oidc-signing`,
|
||||||
|
`ECC_NIST_P256`, `ECDSA_SHA_256`) and returns it.
|
||||||
|
|
||||||
|
### The credentials file (`~/.nova/credentials.json`)
|
||||||
|
|
||||||
|
**C-7.3 (grill):** the file stores the OIDC token + PAT metadata
|
||||||
|
(`jti`, `exp`, `type`) **ONLY — NOT the raw PAT.** The raw PAT is
|
||||||
|
entered once at `nova auth login` and never persisted. This reduces the
|
||||||
|
filesystem-compromise blast radius: an attacker who reads
|
||||||
|
`credentials.json` gets a short-lived OIDC token (default 15 min), not
|
||||||
|
the long-lived PAT.
|
||||||
|
|
||||||
|
The file is `0600` (owner read/write only). Shape:
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"active_credential_jti": "<jti>",
|
||||||
|
"credentials": [
|
||||||
|
{
|
||||||
|
"jti": "<jti>",
|
||||||
|
"type": "nova_oidc_token",
|
||||||
|
"exp": 1787200000,
|
||||||
|
"token": "<oidc jwt>",
|
||||||
|
"stored_at": 1787199000
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
"Most recent wins": `active_credential_jti` points at the
|
||||||
|
most-recently-stored credential. A subsequent `nova auth login`
|
||||||
|
replaces the entry with the same `jti` (or adds a new one).
|
||||||
|
|
||||||
|
## 5. `nova auth status`
|
||||||
|
|
||||||
|
Shows the active credential, the resolved mode, and the
|
||||||
|
`selection_reason`.
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova auth status
|
||||||
|
```
|
||||||
|
|
||||||
|
Output (JSON):
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"mode": "interactive",
|
||||||
|
"selection_reason": "credential:developer_pat",
|
||||||
|
"type": "nova_oidc_token",
|
||||||
|
"jti": "...",
|
||||||
|
"exp": 1787200000
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If no credential is stored: `{"status": "no active credential"}`.
|
||||||
|
|
||||||
|
## 6. `nova auth revoke --pat <jti>`
|
||||||
|
|
||||||
|
Revokes a PAT by `jti`. Marks the `nova-pats` row `status=revoked`
|
||||||
|
(the row is **retained** for audit, not deleted). The next
|
||||||
|
`nova auth login` with that PAT returns `403 pat_revoked` within 60s
|
||||||
|
P95 (D-229 strong read).
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova auth revoke --pat <jti>
|
||||||
|
```
|
||||||
|
|
||||||
|
For emergency DDB-level revocation (when the CLI is unavailable), see
|
||||||
|
`docs/operator-guide-idp.md` §9.
|
||||||
|
|
||||||
|
## 7. Mode resolution (D-226)
|
||||||
|
|
||||||
|
The CLI resolves a client mode (`interactive` or `agent`) on every
|
||||||
|
invocation. The mode drives audit observability (INV-12) and some
|
||||||
|
behavioral defaults. The priority is **strict** — no silent fallbacks
|
||||||
|
(INV-13):
|
||||||
|
|
||||||
|
1. **`--mode` flag** (always wins): `nova apply --mode=agent`.
|
||||||
|
2. **`NOVA_CLIENT_MODE` env var**: `export NOVA_CLIENT_MODE=agent`.
|
||||||
|
Invalid values (anything other than `agent` / `interactive`) are
|
||||||
|
**warned and ignored** (fall through to the next level — not a
|
||||||
|
silent fallback, because a warning is emitted).
|
||||||
|
3. **Credential type** (from `~/.nova/credentials.json`): if the active
|
||||||
|
credential is `developer_pat` or `nova_oidc_token`, the mode is
|
||||||
|
`interactive` if a TTY is attached, `agent` otherwise (INV-14).
|
||||||
|
4. **TTY heuristic** (`sys.stdin.isatty()`): `interactive` if stdin is
|
||||||
|
a TTY, `agent` otherwise.
|
||||||
|
|
||||||
|
Every resolution returns a non-empty `selection_reason` (`flag`, `env`,
|
||||||
|
`credential:<type>`, or `tty`) so the audit event is self-explanatory.
|
||||||
|
|
||||||
|
### TTY vs piped stdout — the Edge 3 case
|
||||||
|
|
||||||
|
The TTY check is **`sys.stdin.isatty()`**, not `sys.stdout.isatty()`.
|
||||||
|
This matters when stdout is piped but stdin is still a terminal:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova apply | tee log.txt
|
||||||
|
```
|
||||||
|
|
||||||
|
Here `stdout` is a pipe (to `tee`), but `stdin` is still the terminal.
|
||||||
|
So `sys.stdin.isatty()` returns `True` → **interactive mode**. This is
|
||||||
|
the common "I want to see the output AND save it" pattern, and it
|
||||||
|
correctly resolves to interactive because the human is driving.
|
||||||
|
|
||||||
|
The inverse — `echo '...' | nova apply` — has `stdin` piped, so
|
||||||
|
`sys.stdin.isatty()` is `False` → **agent mode** (no human at the
|
||||||
|
keyboard; the pipe is the driver).
|
||||||
|
|
||||||
|
### `developer_pat` + TTY → interactive; + no TTY → agent
|
||||||
|
|
||||||
|
A developer PAT (`type: developer_pat`) is a human credential. When a
|
||||||
|
TTY is attached, the CLI runs in `interactive` mode (prompts, human
|
||||||
|
confirmation). When no TTY is attached (piped stdin, CI, a scheduled
|
||||||
|
job), the same PAT runs in `agent` mode (no prompts, non-interactive).
|
||||||
|
This is INV-14: the credential type encodes the role, and the TTY
|
||||||
|
encodes the context.
|
||||||
|
|
||||||
|
A service-account PAT behaves the same way by type, but the max TTL is
|
||||||
|
much shorter (≤ 1h vs ≤ 24h for developer PATs — C-6.2) and CI systems
|
||||||
|
typically set `NOVA_CLIENT_MODE=agent` explicitly so the resolution is
|
||||||
|
deterministic regardless of the TTY state.
|
||||||
|
|
||||||
|
## 8. JWS-from-PAT key derivation (REQ-332, C-5.2)
|
||||||
|
|
||||||
|
`nova apply --local --sign-local-review` produces a JWS attestation — a
|
||||||
|
symmetric (HMAC-SHA256) signature over the attestation payload, keyed
|
||||||
|
by a key derived from the PAT.
|
||||||
|
|
||||||
|
### Why symmetric?
|
||||||
|
|
||||||
|
The grill (C-5.2) found that the original REQ-332 acceptance criterion
|
||||||
|
("public key derivable from the PAT") is unimplementable as an
|
||||||
|
asymmetric scheme — a PAT is a JWT, not a keypair. The fix: the PAT is
|
||||||
|
the **shared secret**. Both the signing key and the verification key
|
||||||
|
are derived from the PAT via the same KDF. The JWS uses `HS256`
|
||||||
|
(HMAC-SHA256), not `ES256`.
|
||||||
|
|
||||||
|
### The KDF
|
||||||
|
|
||||||
|
```
|
||||||
|
key = HKDF-SHA256(
|
||||||
|
input_key_material = PAT.encode('utf-8'),
|
||||||
|
salt = b'nova-local-attestation',
|
||||||
|
info = b'jws-signing-key',
|
||||||
|
length = 32,
|
||||||
|
)
|
||||||
|
```
|
||||||
|
|
||||||
|
(RFC 5869 / NIST SP 800-56C.) The `salt` and `info` are fixed
|
||||||
|
constants — they bind the derived key to the "nova-local-attestation /
|
||||||
|
jws-signing-key" purpose (key separation, INV-16). The same PAT always
|
||||||
|
yields the same key (deterministic); the key is never cached or
|
||||||
|
persisted (INV-15 — recomputed on each sign/verify call).
|
||||||
|
|
||||||
|
### Signing (`nova apply --local --sign-local-review`)
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova apply --local --sign-local-review --pat <PAT> --contract .nova/contract.yml
|
||||||
|
```
|
||||||
|
|
||||||
|
1. `core.jws_attestation.sign_attestation(payload, pat)`:
|
||||||
|
- `derive_signing_key(pat)` → 32-byte key.
|
||||||
|
- `header = {"alg":"HS256","typ":"JWT"}`.
|
||||||
|
- `signing_input = b64url(header) + "." + b64url(payload)`.
|
||||||
|
- `signature = HMAC-SHA256(key, signing_input)`.
|
||||||
|
- Returns `b64url(header).b64url(payload).b64url(signature)` (the
|
||||||
|
compact JWS serialization).
|
||||||
|
2. The JWS is appended to the apply output.
|
||||||
|
|
||||||
|
### Verifying
|
||||||
|
|
||||||
|
Anyone holding the PAT can derive the same key and verify:
|
||||||
|
|
||||||
|
```python
|
||||||
|
from core.jws_attestation import verify_attestation
|
||||||
|
payload = verify_attestation(jws_string, pat)
|
||||||
|
# raises JWSValidationError on tampering or wrong PAT
|
||||||
|
```
|
||||||
|
|
||||||
|
`verify_attestation` recomputes the HMAC and compares in constant time
|
||||||
|
(`hmac.compare_digest`). Without the PAT, the HMAC cannot be forged —
|
||||||
|
this is the integrity guarantee for local-review attestations.
|
||||||
|
|
||||||
|
### What this is NOT
|
||||||
|
|
||||||
|
- **Not a non-repudiation scheme.** Anyone with the PAT can sign, so
|
||||||
|
the signature proves "someone with the PAT signed this payload" —
|
||||||
|
not a specific individual. Non-repudiation is the job of the audit
|
||||||
|
trail (INV-12), not the JWS.
|
||||||
|
- **Not a replacement for the OIDC token.** The OIDC token (from
|
||||||
|
`nova auth login`) is the credential for remote operations; the JWS
|
||||||
|
is for local-review attestation integrity only.
|
||||||
|
|
||||||
|
## 9. Service-account PATs (CI usage)
|
||||||
|
|
||||||
|
A CI system (GitHub Actions, or an internal forge runner) uses a service-account
|
||||||
|
PAT to run `nova apply` non-interactively.
|
||||||
|
|
||||||
|
```sh
|
||||||
|
# In CI:
|
||||||
|
export NOVA_PAT=<service-account-pat>
|
||||||
|
export NOVA_CLIENT_MODE=agent
|
||||||
|
nova auth login --pat "$NOVA_PAT"
|
||||||
|
nova apply --contract contracts/microservice.yml
|
||||||
|
```
|
||||||
|
|
||||||
|
- `NOVA_CLIENT_MODE=agent` makes mode resolution deterministic (level 2
|
||||||
|
beats level 3/4), regardless of whether the CI runner attaches a TTY.
|
||||||
|
- No TTY → `agent` mode anyway, but the env var is belt-and-suspenders.
|
||||||
|
- **Max TTL: ≤ 1h for service-account PATs** (C-6.2). The
|
||||||
|
`issue_pat(subject_type="service-account", ttl_seconds=3600)` call
|
||||||
|
clamps any higher request to 3600s. Rotate the PAT before it expires
|
||||||
|
(CI should mint a fresh one per run or daily).
|
||||||
|
|
||||||
|
### TTL summary (C-6.2)
|
||||||
|
|
||||||
|
| Subject type | Max TTL | Typical use |
|
||||||
|
|--------------|---------|-------------|
|
||||||
|
| `developer` | ≤ 24h (86400s) | local dev, interactive |
|
||||||
|
| `service-account` | ≤ 1h (3600s) | CI, automated pipelines |
|
||||||
|
|
||||||
|
The TTL is enforced in `core.pat_lifecycle.issue_pat` — a request for
|
||||||
|
more than the max is silently clamped (with an audit event recording
|
||||||
|
the requested vs actual TTL).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Appendix — command reference
|
||||||
|
|
||||||
|
| Command | What it does |
|
||||||
|
|---------|--------------|
|
||||||
|
| `nova auth signup` | create a user (Argon2id hash) |
|
||||||
|
| `nova auth signin` | verify password → session token |
|
||||||
|
| `nova auth login --pat <PAT>` | PAT → OIDC token, store in `~/.nova/credentials.json` (0600) |
|
||||||
|
| `nova auth status` | active credential + mode + selection_reason |
|
||||||
|
| `nova auth revoke --pat <jti>` | mark a PAT revoked (D-229 SLO ≤ 60s P95) |
|
||||||
|
| `nova apply --local --sign-local-review --pat <PAT>` | local apply + JWS attestation (HS256, PAT-derived key) |
|
||||||
|
|
||||||
|
| File | Purpose |
|
||||||
|
|------|---------|
|
||||||
|
| `~/.nova/credentials.json` | OIDC token + PAT metadata (NOT raw PAT); 0600 |
|
||||||
|
| `~/.nova/contract.yml` | project contract (scaffolded by `nova init`) |
|
||||||
|
| `~/.nova/contract.yml.attestations/` | local attestation outputs |
|
||||||
@@ -0,0 +1,51 @@
|
|||||||
|
# kyverno-json (`kj`) Lambda layer
|
||||||
|
|
||||||
|
This document records how the `kj` (kyverno-json) binary is pinned and
|
||||||
|
bundled into the Nova token-vend Lambda layer (D-227, C-8.2).
|
||||||
|
|
||||||
|
## Pin (C-8.2)
|
||||||
|
|
||||||
|
The `kj` binary is pinned to a specific release. The version + SHA256
|
||||||
|
of the binary used for local ABAC tests and bundled into the Lambda
|
||||||
|
layer are recorded in [`platform/abac/kj-version.txt`](../platform/abac/kj-version.txt):
|
||||||
|
|
||||||
|
```
|
||||||
|
<version>
|
||||||
|
<sha256>
|
||||||
|
```
|
||||||
|
|
||||||
|
**Current pin:** `v0.0.3` —
|
||||||
|
`4ebb9a19fbf545e17f046c137f9b69c4288d021e5c73d962835671e0cb3fbf07`
|
||||||
|
(measured from `/usr/local/bin/kj` on the build host).
|
||||||
|
|
||||||
|
C-8.2 requires pinning to a specific release (not `latest`) and
|
||||||
|
recording the SHA256 so a supply-chain compromise of the upstream
|
||||||
|
release is detectable. The build step downloads the pinned release,
|
||||||
|
verifies the SHA256 against the recorded value, and aborts on mismatch.
|
||||||
|
|
||||||
|
## Lambda layer bundling
|
||||||
|
|
||||||
|
The publish workflow (P1, `.github/workflows/`) bundles the pinned `kj`
|
||||||
|
Linux amd64 binary into the `nova-cli` Lambda layer at `layer/bin/kj`.
|
||||||
|
At runtime the Lambda mounts the layer at `/opt`, so `kj` is on PATH at
|
||||||
|
`/opt/bin/kj`. `KyvernoJsonEngine.is_configured()` checks `which kj` →
|
||||||
|
`/opt/bin/kj` and returns `False` when absent — the token-vend Lambda
|
||||||
|
then **fails closed** (C-6.1, 403 `abac_eval_failed`), it never vends a
|
||||||
|
token without an ABAC decision.
|
||||||
|
|
||||||
|
## Local testing
|
||||||
|
|
||||||
|
`/usr/local/bin/kj` exists on the build host. The local ABAC tests
|
||||||
|
(`tests/test_abac_policy.py`, `tests/test_abac_fail_closed.py`) use the
|
||||||
|
real `kj` binary — they are skipped (not failed) when `kj` is absent.
|
||||||
|
|
||||||
|
## Fallback / migration path (D-227)
|
||||||
|
|
||||||
|
If the `kj` Go binary proves unsuitable for the Lambda runtime (e.g. a
|
||||||
|
future release exceeds the 250 MB layer unzip limit or drops AL2023
|
||||||
|
compatibility), the migration path is to run kyverno-json on AWS
|
||||||
|
Fargate behind an internal NLB and have the token-vend Lambda call it
|
||||||
|
over HTTP. The `PolicyEngine` Protocol (`core/policy_engine.py`) is the
|
||||||
|
swap boundary — a `KyvernoJsonHttpEngine` would implement the same
|
||||||
|
protocol without touching the token-vend Lambda's ABAC fail-closed
|
||||||
|
logic. This is a documented fallback, not the v1.28 default.
|
||||||
@@ -0,0 +1,53 @@
|
|||||||
|
# KMS asymmetric key provisioning (C-1.1)
|
||||||
|
|
||||||
|
This document records the C-1.1 verification for the Nova OIDC signing
|
||||||
|
KMS key and the provisioning path used by `nova idp setup`.
|
||||||
|
|
||||||
|
## C-1.1 verification (P4)
|
||||||
|
|
||||||
|
C-1.1 requires verifying KMS asymmetric key support **before**
|
||||||
|
implementation. The verification command is:
|
||||||
|
|
||||||
|
```
|
||||||
|
aws kms create-key \
|
||||||
|
--key-spec ECC_NIST_P256 \
|
||||||
|
--key-usage SIGN_VERIFY \
|
||||||
|
--description nova-oidc-signing
|
||||||
|
```
|
||||||
|
|
||||||
|
**Result on the P4 build host:** AWS credentials are not available
|
||||||
|
(`Unable to locate credentials`), so the live verification could not
|
||||||
|
run. This is recorded as a **P4 CI gate**: the `nova idp setup --check`
|
||||||
|
command (Wave 8) performs this verification when AWS creds are present
|
||||||
|
and reports it as a missing prerequisite when they are not. The code
|
||||||
|
proceeds against the documented KMS API (REQ-337); tests use a test
|
||||||
|
ECDSA P-256 keypair + mocked `boto3.client("kms")` (no real AWS calls).
|
||||||
|
|
||||||
|
KMS asymmetric signing keys (`ECC_NIST_P256` + `SIGN_VERIFY`) are GA
|
||||||
|
in all commercial regions (announced 2020-11). The
|
||||||
|
`ECDSA_SHA_256` signing algorithm is supported. Confidence: high.
|
||||||
|
|
||||||
|
## Key spec (REQ-337)
|
||||||
|
|
||||||
|
* **Key spec:** `ECC_NIST_P256` (NIST P-256 / secp256r1)
|
||||||
|
* **Key usage:** `SIGN_VERIFY`
|
||||||
|
* **Signing algorithm:** `ECDSA_SHA_256` (JWS `ES256`)
|
||||||
|
* **Alias:** `alias/nova-oidc-signing`
|
||||||
|
* **Rotation:** manual, 90 days (matches D-069 CMK cadence). New key +
|
||||||
|
re-point alias + JWKS serves both `kid`s during overlap.
|
||||||
|
|
||||||
|
## DER → raw ECDSA conversion (the #1 gotcha)
|
||||||
|
|
||||||
|
KMS `sign()` returns a **DER-encoded** ASN.1 ECDSA signature. JWS
|
||||||
|
(RFC 7515 §3.1.3) requires the **raw** `r‖s` concatenation, each
|
||||||
|
coordinate 32 bytes big-endian. The conversion (in
|
||||||
|
`core/kms_signing.py:der_to_raw_ecdsa`):
|
||||||
|
|
||||||
|
```python
|
||||||
|
from cryptography.hazmat.primitives.asymmetric.utils import decode_dss_signature
|
||||||
|
r, s = decode_dss_signature(der_sig)
|
||||||
|
raw = r.to_bytes(32, "big") + s.to_bytes(32, "big")
|
||||||
|
```
|
||||||
|
|
||||||
|
This is verified by `tests/test_kms_signing.py` and the CAP-037
|
||||||
|
round-trip test (`tests/test_kms_roundtrip.py`).
|
||||||
@@ -0,0 +1,385 @@
|
|||||||
|
# Operator Guide — Nova IdP Setup (`nova idp setup`)
|
||||||
|
|
||||||
|
> **REQ-345** — operator guide for `nova idp setup`. Covers `--check`,
|
||||||
|
> `--apply`, `--verify`, the prerequisite IAM policy, the CloudFormation
|
||||||
|
> review flow, and the **C-6.3 grill additions**: KMS key rotation
|
||||||
|
> (90 days), Lambda layer update, DDB PITR restore, emergency PAT
|
||||||
|
> revocation (DDB-level, not CLI).
|
||||||
|
>
|
||||||
|
> Audience: platform operators / SREs deploying the Nova identity stack
|
||||||
|
> into AWS account `581513795199` (or a fresh account). No developer
|
||||||
|
> auth flows here — see `docs/developer-guide-auth.md` for those.
|
||||||
|
|
||||||
|
## 1. Overview
|
||||||
|
|
||||||
|
`nova idp setup` provisions the Nova identity layer (Nova-idp) as a
|
||||||
|
CloudFormation stack. The stack contains:
|
||||||
|
|
||||||
|
| Resource | Count | Notes |
|
||||||
|
|----------|-------|-------|
|
||||||
|
| Lambda functions | 3 | `nova-idp-auth`, `nova-idp-token-vend`, `nova-idp-jwks` |
|
||||||
|
| DynamoDB tables | 4 | `nova-users`, `nova-sessions`, `nova-password-resets`, `nova-pats` (PITR enabled on each, REQ-335) |
|
||||||
|
| KMS asymmetric key | 1 | `alias/nova-oidc-signing` (`ECC_NIST_P256`, `SIGN_VERIFY`) |
|
||||||
|
| Lambda function URLs | 3 | auth + token-vend (IAM auth), jwks (`AuthType: NONE`) |
|
||||||
|
| IAM roles | 3+ | one per Lambda + the CloudFormation service role |
|
||||||
|
| Optional CloudFront + WAF + ACM | 0/3 | only with `--public-jwks-domain` |
|
||||||
|
|
||||||
|
The command has three modes — `--check`, `--apply`, `--verify` — plus
|
||||||
|
`--dry-run` for a resource-only preview. All modes are safe to re-run.
|
||||||
|
|
||||||
|
## 2. `nova idp setup --check`
|
||||||
|
|
||||||
|
Run **before** `--apply` to verify the deploying principal has the
|
||||||
|
permissions and environment the stack needs.
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova idp setup --check
|
||||||
|
```
|
||||||
|
|
||||||
|
### What it checks
|
||||||
|
|
||||||
|
1. **AWS credentials** — `aws sts get-caller-identity` succeeds and
|
||||||
|
returns an `Account` id. If this fails, run `aws configure` or export
|
||||||
|
`AWS_PROFILE` / `AWS_ACCESS_KEY_ID` + `AWS_SECRET_ACCESS_KEY`.
|
||||||
|
2. **AWS region** — `AWS_DEFAULT_REGION` or `AWS_REGION` is set. The
|
||||||
|
stack is regional (single-region); pick the region you want all
|
||||||
|
resources to live in.
|
||||||
|
3. **CloudFormation permissions** — the principal can create/describe
|
||||||
|
stacks (see §5 for the full IAM delta).
|
||||||
|
4. **KMS permissions** — `kms:CreateKey` + `kms:CreateAlias` (needed to
|
||||||
|
mint `alias/nova-oidc-signing`).
|
||||||
|
5. **Lambda layer exists** — the `nova-cli` Lambda layer (published by
|
||||||
|
the P1 Wave 4 pipeline) is referenced by the stack; `--check` reports
|
||||||
|
whether the layer ARN in SSM (`/nova/layer/nova-cli/version`) is
|
||||||
|
present. If absent, run the publish workflow or `nova layer update`.
|
||||||
|
|
||||||
|
### Reading the IAM policy delta
|
||||||
|
|
||||||
|
`--check` prints a report like:
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"aws_creds": true,
|
||||||
|
"region": "us-east-1",
|
||||||
|
"missing": [],
|
||||||
|
"iam_delta": [
|
||||||
|
"cloudformation:*",
|
||||||
|
"iam:CreateRole",
|
||||||
|
"iam:PassRole",
|
||||||
|
"lambda:CreateFunction",
|
||||||
|
"lambda:CreateFunctionUrlConfig",
|
||||||
|
"dynamodb:CreateTable",
|
||||||
|
"kms:CreateKey",
|
||||||
|
"kms:CreateAlias"
|
||||||
|
]
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
`iam_delta` is the **delta** between what the deploying principal
|
||||||
|
currently has (the `nova-spike-runner` grants in this account) and what
|
||||||
|
`--apply` needs. Each entry is a grant you must add to the principal's
|
||||||
|
policy before `--apply` will succeed. `--check` never makes changes.
|
||||||
|
|
||||||
|
## 3. `nova idp setup --apply`
|
||||||
|
|
||||||
|
Generates the CloudFormation template, presents it for review, and
|
||||||
|
deploys **only after explicit `y/N` approval** (NFR-10).
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova idp setup --apply
|
||||||
|
```
|
||||||
|
|
||||||
|
### Review flow
|
||||||
|
|
||||||
|
1. **Resource summary** printed to stdout (resource type → count):
|
||||||
|
```
|
||||||
|
Resource summary:
|
||||||
|
AWS::DynamoDB::Table: 4
|
||||||
|
AWS::IAM::Role: 3
|
||||||
|
AWS::KMS::Key: 1
|
||||||
|
AWS::Lambda::Function: 3
|
||||||
|
AWS::Lambda::Url: 3
|
||||||
|
```
|
||||||
|
2. **Full template** opened in `$PAGER` (if set and stdin is a TTY);
|
||||||
|
otherwise the path to the temp file is printed. Review every
|
||||||
|
resource, especially the KMS key policy and the IAM roles.
|
||||||
|
3. **`Apply? [y/N]` prompt.** Type `y` + Enter to deploy; anything else
|
||||||
|
aborts. No resource is created before this approval.
|
||||||
|
4. On approval: `aws cloudformation deploy --stack-name nova-idp
|
||||||
|
--template-file <tmp> --capabilities CAPABILITY_IAM`.
|
||||||
|
|
||||||
|
### `--dry-run` — resource list only
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova idp setup --dry-run
|
||||||
|
```
|
||||||
|
|
||||||
|
Generates the template and prints the resource summary **without** the
|
||||||
|
pager, the prompt, or any deploy. Use this to audit the stack shape in
|
||||||
|
CI or before a manual `--apply`.
|
||||||
|
|
||||||
|
### `--public-jwks-domain` — optional custom domain + WAF
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova idp setup --apply --public-jwks-domain jwks.nova.example.com
|
||||||
|
```
|
||||||
|
|
||||||
|
Adds a CloudFront distribution fronting the JWKS Lambda function URL, an
|
||||||
|
ACM certificate (DNS-validated) for the domain, and a WAF web ACL with
|
||||||
|
a rate-based rule (see §C-6.3 and the threat model). Without this flag
|
||||||
|
the JWKS endpoint is a bare function URL (`AuthType: NONE`) — fine for
|
||||||
|
piloting but exposed to the internet without rate limiting. **For any
|
||||||
|
public deployment, set `--public-jwks-domain`.**
|
||||||
|
|
||||||
|
## 4. `nova idp setup --verify`
|
||||||
|
|
||||||
|
Runs the KMS round-trip test (CAP-037) against the deployed stack.
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova idp setup --verify
|
||||||
|
```
|
||||||
|
|
||||||
|
It signs a test JWT via `core.kms_signing.sign_jwt()` (using the real
|
||||||
|
KMS key `alias/nova-oidc-signing`), fetches the JWKS endpoint, and
|
||||||
|
verifies the JWT signature with `pyjwt` + the JWKS key. This exercises
|
||||||
|
the full DER → raw ECDSA conversion path (the #1 implementation risk —
|
||||||
|
see `docs/threat-model.md`).
|
||||||
|
|
||||||
|
**Success output:**
|
||||||
|
```json
|
||||||
|
{"passed": true, "detail": "KMS round-trip OK"}
|
||||||
|
```
|
||||||
|
|
||||||
|
**Failure output:**
|
||||||
|
```json
|
||||||
|
{"passed": false, "detail": "verify error: <exception>"}
|
||||||
|
```
|
||||||
|
|
||||||
|
Common failure causes:
|
||||||
|
- The KMS key policy doesn't grant `kms:Sign` to the verify caller.
|
||||||
|
- The JWKS function URL is not deployed or returns a non-200.
|
||||||
|
- The KMS key spec isn't `ECC_NIST_P256` (the DER→raw conversion
|
||||||
|
assumes P-256, 32-byte coordinates).
|
||||||
|
|
||||||
|
## 5. Required IAM policy
|
||||||
|
|
||||||
|
The delta `--check` reports is the set of grants the deploying
|
||||||
|
principal needs **in addition** to the existing `nova-spike-runner`
|
||||||
|
grants. The full required set:
|
||||||
|
|
||||||
|
| Action | Why |
|
||||||
|
|--------|-----|
|
||||||
|
| `cloudformation:*` | create/deploy/describe the `nova-idp` stack |
|
||||||
|
| `codeartifact:*` | (already on `nova-spike-runner`) publish the wheel + layer |
|
||||||
|
| `iam:CreateRole` | create the per-Lambda execution roles |
|
||||||
|
| `iam:PassRole` | pass those roles to Lambda + CloudFormation |
|
||||||
|
| `lambda:CreateFunction` | create the 3 Lambda functions |
|
||||||
|
| `lambda:CreateFunctionUrlConfig` | create the 3 function URLs |
|
||||||
|
| `dynamodb:CreateTable` | create the 4 DDB tables (with PITR) |
|
||||||
|
| `kms:CreateKey` | mint the `ECC_NIST_P256` signing key |
|
||||||
|
| `kms:CreateAlias` | bind `alias/nova-oidc-signing` to the key |
|
||||||
|
| `ssm:PutParameter` | write the layer-version mapping to SSM |
|
||||||
|
|
||||||
|
Attach these to the deploying principal's policy before `--apply`.
|
||||||
|
`--check` will then report an empty `missing` list.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## C-6.3 Grill additions — operational runbooks
|
||||||
|
|
||||||
|
The grill (C-6.3) requires four operational procedures beyond the
|
||||||
|
setup flow. Each is a runbook an on-call SRE can follow without reading
|
||||||
|
source code.
|
||||||
|
|
||||||
|
### 6. KMS key rotation (90-day cadence)
|
||||||
|
|
||||||
|
**Cadence:** rotate `alias/nova-oidc-signing` every **90 days**. The
|
||||||
|
rotation is a *key re-point*, not a key deletion — the alias is moved
|
||||||
|
to a new key while the old key stays valid during the token-overlap
|
||||||
|
window so already-issued tokens keep verifying.
|
||||||
|
|
||||||
|
**Procedure:**
|
||||||
|
|
||||||
|
1. **Create the new key** (same spec):
|
||||||
|
```sh
|
||||||
|
NEW_KEY=$(aws kms create-key \
|
||||||
|
--key-spec ECC_NIST_P256 \
|
||||||
|
--key-usage SIGN_VERIFY \
|
||||||
|
--description "nova-oidc-signing-$(date +%Y%m%d)" \
|
||||||
|
--query KeyId --output text)
|
||||||
|
```
|
||||||
|
2. **Re-point the alias** to the new key:
|
||||||
|
```sh
|
||||||
|
aws kms update-alias --alias-name alias/nova-oidc-signing \
|
||||||
|
--target-key-id "$NEW_KEY"
|
||||||
|
```
|
||||||
|
3. **JWKS serves both `kid`s during the overlap window.** The JWKS
|
||||||
|
Lambda lists **all** keys the alias has pointed at that are still
|
||||||
|
enabled. Already-issued OIDC tokens (signed with the old key) keep
|
||||||
|
verifying until they expire (OIDC TTL default 15 min; PAT TTL ≤ 24h
|
||||||
|
dev / ≤ 1h service-account). **Do not disable the old key until at
|
||||||
|
least the max PAT TTL (24h) has elapsed.**
|
||||||
|
4. **After the overlap window** (≥ 24h), disable + schedule deletion of
|
||||||
|
the old key:
|
||||||
|
```sh
|
||||||
|
aws kms disable-key --key-id "<old-key-id>"
|
||||||
|
aws kms schedule-key-deletion --key-id "<old-key-id>" --pending-window-in-days 7
|
||||||
|
```
|
||||||
|
5. **Verify** the new key is active:
|
||||||
|
```sh
|
||||||
|
nova idp setup --verify
|
||||||
|
```
|
||||||
|
|
||||||
|
**Audit:** emit a manual `kms.key_rotated` event to the audit stream
|
||||||
|
with `old_key_id`, `new_key_id`, `rotated_at`. The rotation is a
|
||||||
|
CloudFormation-less operation (KMS aliases are mutable); it does not
|
||||||
|
require a stack update.
|
||||||
|
|
||||||
|
### 7. Lambda layer update
|
||||||
|
|
||||||
|
The `nova-cli` Lambda layer (the shared dependency bundle:
|
||||||
|
`argon2-cffi`, `cryptography`, `pyjwt`, `kj` binary) is republished
|
||||||
|
**automatically on every merge to `main`** by the P1 Wave 4 publish
|
||||||
|
workflow (the byte-identical GitHub + internal-forge workflow files).
|
||||||
|
On a successful publish, the new layer version ARN is written to SSM
|
||||||
|
`/nova/layer/nova-cli/version`.
|
||||||
|
|
||||||
|
**When to update manually:**
|
||||||
|
- A dependency CVE requires an out-of-band patch before the next merge.
|
||||||
|
- The `kj` binary pinned version changes (C-8.2 supply-chain safety).
|
||||||
|
|
||||||
|
**Manual procedure:**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
nova layer update
|
||||||
|
```
|
||||||
|
|
||||||
|
This rebuilds the layer (`pip install --target layer/python/` + the
|
||||||
|
pinned `kj` binary, SHA256 verified against `layer/kj.sha256`),
|
||||||
|
publishes a new `lambda:PublishLayerVersion`, and updates the SSM
|
||||||
|
parameter. The 3 Nova-idp Lambdas pick up the new layer on their next
|
||||||
|
cold start (or force a redeploy with `aws lambda update-function-configuration
|
||||||
|
--layers <new-arn>` on each).
|
||||||
|
|
||||||
|
**Verify:** `nova idp setup --verify` after the Lambdas reload.
|
||||||
|
|
||||||
|
### 8. DynamoDB PITR restore
|
||||||
|
|
||||||
|
All 4 identity tables have point-in-time recovery (PITR) enabled
|
||||||
|
(REQ-335): `nova-users`, `nova-sessions`, `nova-password-resets`,
|
||||||
|
`nova-pats`. PITR lets you restore a table to any second in the last
|
||||||
|
**35 days** (the AWS retention window).
|
||||||
|
|
||||||
|
**Procedure (restore `nova-pats` to 1 hour ago):**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
# 1. Find the restore target time (ISO 8601, UTC, within the last 35d).
|
||||||
|
RESTORE_TO=$(date -u -d '1 hour ago' +%Y-%m-%dT%H:%M:%SZ)
|
||||||
|
|
||||||
|
# 2. Restore to a NEW table (PITR never overwrites the source).
|
||||||
|
aws dynamodb restore-table-to-point-in-time \
|
||||||
|
--source-table-name nova-pats \
|
||||||
|
--target-table-name nova-pats-restored \
|
||||||
|
--restore-date-time "$RESTORE_TO" \
|
||||||
|
--billing-mode-restore-as-is
|
||||||
|
|
||||||
|
# 3. After the restore completes (status ACTIVE), repoint the app:
|
||||||
|
# - update the stack env var NOVA_PATS_TABLE=nova-pats-restored, or
|
||||||
|
# - rename: delete nova-pats, then aws dynamodb update-table --table-name
|
||||||
|
# nova-pats-restored --new-table-name nova-pats (downtime window).
|
||||||
|
# 4. Re-enable PITR on the restored table (PITR does not carry over).
|
||||||
|
aws dynamodb update-continuous-backups \
|
||||||
|
--table-name nova-pats-restored \
|
||||||
|
--point-in-time-recovery-specification PointInTimeRecoveryEnabled=true
|
||||||
|
```
|
||||||
|
|
||||||
|
**Which tables have PITR:** all 4 (`nova-users`, `nova-sessions`,
|
||||||
|
`nova-password-resets`, `nova-pats`). Verify with:
|
||||||
|
```sh
|
||||||
|
for t in nova-users nova-sessions nova-password-resets nova-pats; do
|
||||||
|
aws dynamodb describe-continuous-backups --table-name "$t" \
|
||||||
|
--query 'ContinuousBackupsDescription.PointInTimeRecoveryDescription' --output text
|
||||||
|
done
|
||||||
|
```
|
||||||
|
|
||||||
|
**Recovery window:** 35 days (AWS PITR). Restores older than 35 days
|
||||||
|
are impossible — for longer retention, export to S3 via the on-demand
|
||||||
|
export or a scheduled AWS Backup plan.
|
||||||
|
|
||||||
|
### 9. Emergency PAT revocation (DDB-level, not CLI)
|
||||||
|
|
||||||
|
**When to use:** a PAT is known-compromised and the `nova auth revoke`
|
||||||
|
CLI is unavailable (e.g. the operator machine is offline, or the PAT
|
||||||
|
`jti` is known but the raw PAT is not — revocation is keyed on `jti`,
|
||||||
|
not the token string). This is a **DDB-level** operation; it bypasses
|
||||||
|
the CLI but still satisfies the D-229 strong-read SLO (the token-vend
|
||||||
|
Lambda does a `ConsistentRead=True` `GetItem` on `jti` on every vend —
|
||||||
|
the revocation is reflected on the next vend, within 60s P95).
|
||||||
|
|
||||||
|
**Procedure:**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
aws dynamodb update-item \
|
||||||
|
--table-name nova-pats \
|
||||||
|
--key '{"jti":{"S":"<jti>"}}' \
|
||||||
|
--update-expression "SET #s = :r" \
|
||||||
|
--expression-attribute-names '{"#s":"status"}' \
|
||||||
|
--expression-attribute-values '{":r":{"S":"revoked"}}'
|
||||||
|
```
|
||||||
|
|
||||||
|
Replace `<jti>` with the PAT's `jti` claim (a uuid4; find it in the
|
||||||
|
`pat.issued` audit event or by scanning the `sub-index` GSI for the
|
||||||
|
compromised subject). The item is **retained** (not deleted) so the
|
||||||
|
audit trail is intact — only `status` flips from `active` to `revoked`.
|
||||||
|
|
||||||
|
**Verify the revocation took effect:**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
aws dynamodb get-item \
|
||||||
|
--table-name nova-pats \
|
||||||
|
--key '{"jti":{"S":"<jti>"}}' \
|
||||||
|
--consistent-read \
|
||||||
|
--query 'Item.status.S' --output text
|
||||||
|
# → revoked
|
||||||
|
```
|
||||||
|
|
||||||
|
The next `token-vend` call with that `jti` returns `403
|
||||||
|
pat_revoked` immediately (D-229: the strong read is synchronous).
|
||||||
|
|
||||||
|
**Bulk revocation** (revoke all of a subject's PATs):
|
||||||
|
|
||||||
|
```sh
|
||||||
|
SUB="<sub>"
|
||||||
|
JTIS=$(aws dynamodb query \
|
||||||
|
--table-name nova-pats \
|
||||||
|
--index-name sub-index \
|
||||||
|
--key-condition-expression "sub = :s" \
|
||||||
|
--expression-attribute-values "{\":s\":{\"S\":\"$SUB\"}}" \
|
||||||
|
--query 'Items[?status.S==`active`].jti.S' --output text)
|
||||||
|
for jti in $JTIS; do
|
||||||
|
aws dynamodb update-item --table-name nova-pats \
|
||||||
|
--key "{\"jti\":{\"S\":\"$jti\"}}" \
|
||||||
|
--update-expression "SET #s = :r" \
|
||||||
|
--expression-attribute-names '{"#s":"status"}' \
|
||||||
|
--expression-attribute-values '{":r":{"S":"revoked"}}'
|
||||||
|
done
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Appendix — quick reference
|
||||||
|
|
||||||
|
| Command | What it does |
|
||||||
|
|---------|--------------|
|
||||||
|
| `nova idp setup --check` | prerequisites + IAM delta (no changes) |
|
||||||
|
| `nova idp setup --dry-run` | resource summary only (no deploy) |
|
||||||
|
| `nova idp setup --apply` | review template → `y/N` → deploy |
|
||||||
|
| `nova idp setup --apply --public-jwks-domain <fqdn>` | add CloudFront + WAF + ACM |
|
||||||
|
| `nova idp setup --verify` | KMS round-trip test (CAP-037) |
|
||||||
|
|
||||||
|
| Runbook | Cadence / trigger |
|
||||||
|
|---------|-------------------|
|
||||||
|
| KMS key rotation | every 90 days |
|
||||||
|
| Lambda layer update | on merge (auto) or manually via `nova layer update` |
|
||||||
|
| DDB PITR restore | on data loss / corruption (35-day window) |
|
||||||
|
| Emergency PAT revocation | on compromise (DDB-level, immediate) |
|
||||||
@@ -0,0 +1,408 @@
|
|||||||
|
# Nova Identity Layer — Threat Model
|
||||||
|
|
||||||
|
> **REQ-347** — identity-layer threat model. Covers the 8 threats
|
||||||
|
> enumerated below + the **C-9.2 INV-18..21 compression audit**. The
|
||||||
|
> C-6.2 grill additions (JWKS DDoS, PAT max TTL, ABAC fail-closed) are
|
||||||
|
> integrated into the threat list, not appended.
|
||||||
|
>
|
||||||
|
> Scope: the Nova-idp identity layer (`nova-idp-auth` +
|
||||||
|
> `nova-idp-token-vend` + `nova-idp-jwks` Lambdas, the KMS signing key,
|
||||||
|
> the 4 DynamoDB tables, the `nova auth` CLI, the PAT lifecycle). Out
|
||||||
|
> of scope: the downstream contract resolver, Terraform adapter, and
|
||||||
|
> consumer-side auth (those have their own threat models).
|
||||||
|
|
||||||
|
## 1. Assets
|
||||||
|
|
||||||
|
| Asset | Where | Sensitivity |
|
||||||
|
|-------|-------|-------------|
|
||||||
|
| User passwords | `nova-users.password_hash` (Argon2id) | high — hash only; raw never stored |
|
||||||
|
| PATs (personal access tokens) | `nova-pats` (hash only) + returned to caller once | high — bearer token, ≤24h/≤1h TTL |
|
||||||
|
| OIDC tokens | `~/.nova/credentials.json` (0600) + in-flight to clients | medium — short-lived (15 min default) |
|
||||||
|
| KMS signing key | KMS `alias/nova-oidc-signing` (`ECC_NIST_P256`) | high — the trust anchor for all OIDC tokens |
|
||||||
|
| ABAC policy | `platform/abac/token-vend.policy` (git-tracked) | high — the authorization rules |
|
||||||
|
| DynamoDB tables | `nova-users`, `nova-sessions`, `nova-password-resets`, `nova-pats` | high — the identity store |
|
||||||
|
| JWKS endpoint | `nova-idp-jwks` function URL (`AuthType: NONE`) | medium — public, must be available but is not secret |
|
||||||
|
| Audit stream | stderr JSON from each Lambda + the CLI | high — tamper-evidence for the whole layer |
|
||||||
|
|
||||||
|
## 2. Trust boundaries
|
||||||
|
|
||||||
|
```
|
||||||
|
┌────────────────┐ IAM-auth function URL ┌────────────────────┐
|
||||||
|
│ Developer CI │ ───────────────────────────► │ nova-idp-auth │
|
||||||
|
│ (nova CLI) │ │ nova-idp-token-vend│
|
||||||
|
│ │ ◄────── OIDC token ───────── │ (KMS sign) │
|
||||||
|
└────────┬───────┘ └─────────┬──────────┘
|
||||||
|
│ │
|
||||||
|
│ ~/.nova/credentials.json (0600) │ strong-read GetItem
|
||||||
|
│ NOT the raw PAT ▼
|
||||||
|
│ ┌────────────────────┐
|
||||||
|
│ │ nova-pats (DDB) │
|
||||||
|
│ │ nova-users/sessions│
|
||||||
|
│ JWKS fetch (unauthenticated) └────────────────────┘
|
||||||
|
│ ──────────────────────────────────► ┌────────────────────┐
|
||||||
|
│ │ nova-idp-jwks │
|
||||||
|
│ ◄──── public key (JWK) ──────────── │ (AuthType: NONE) │
|
||||||
|
▼ └────────────────────┘
|
||||||
|
┌────────────────┐
|
||||||
|
│ AWS KMS │ kms:Sign (token-vend role only)
|
||||||
|
│ alias/nova- │ kms:GetPublicKey (jwks role)
|
||||||
|
│ oidc-signing │
|
||||||
|
└────────────────┘
|
||||||
|
```
|
||||||
|
|
||||||
|
The key boundary crossings:
|
||||||
|
1. **Internet → JWKS Lambda** (unauthenticated function URL) — the
|
||||||
|
DDoS surface (Threat T-4).
|
||||||
|
2. **CLI → auth/token-vend Lambdas** (IAM-authenticated function URLs)
|
||||||
|
— the credential-injection surface.
|
||||||
|
3. **token-vend Lambda → KMS** (`kms:Sign`) — the key-use surface.
|
||||||
|
4. **token-vend Lambda → DDB** (strong read on `nova-pats`) — the
|
||||||
|
revocation surface.
|
||||||
|
|
||||||
|
## 3. Threats + mitigations
|
||||||
|
|
||||||
|
### T-1 — Password compromise (storage)
|
||||||
|
|
||||||
|
**Threat:** an attacker with read access to `nova-users` (DDB export,
|
||||||
|
backup, a leaked snapshot) recovers plaintext passwords.
|
||||||
|
|
||||||
|
**Mitigations:**
|
||||||
|
- **Argon2id hashing** with OWASP-minimum parameters
|
||||||
|
(`time_cost=3, memory_cost=65536 KiB, parallelism=1`) —
|
||||||
|
`core/lambda/nova_idp_auth.py:hash_password`. Argon2id is the
|
||||||
|
recommended PHC winner; the parameters are the OWASP minimum (C-7.2).
|
||||||
|
- **Fail-closed on Argon2 unavailable** (D-228): if the `argon2-cffi`
|
||||||
|
C extension fails to import, `_ARGON2_AVAILABLE` is `False` and
|
||||||
|
`hash_password`/`verify_password` raise `Argon2UnavailableError` →
|
||||||
|
the handler returns **503**. **No pure-Python fallback, no weak
|
||||||
|
hash, no crash.** Verified by `tests/test_argon2_fail_closed.py`.
|
||||||
|
- **No raw passwords anywhere** (INV-16): the handler never logs the
|
||||||
|
password argument; the audit scrubber (`_emit_audit`) pops any
|
||||||
|
`password`/`new_password`/`old_password` kwarg defense-in-depth;
|
||||||
|
the DDB item has `password_hash`, never `password`. Verified by
|
||||||
|
`tests/test_idp_auth.py:TestNoRawPasswordsInLogs`.
|
||||||
|
|
||||||
|
**Residual risk:** low. Argon2id with the OWASP params is
|
||||||
|
GPU-resistant at scale; the remaining risk is a parameter-weakness
|
||||||
|
advisory (mitigated by the 90-day KMS rotation cadence's analog for
|
||||||
|
hash params — revisit annually).
|
||||||
|
|
||||||
|
### T-2 — PAT theft + max TTL (C-6.2)
|
||||||
|
|
||||||
|
**Threat:** an attacker exfiltrates a PAT (filesystem read of
|
||||||
|
`~/.nova/credentials.json`, a leaked CI env var, a phishing capture)
|
||||||
|
and uses it to vend OIDC tokens until it expires.
|
||||||
|
|
||||||
|
**Mitigations:**
|
||||||
|
- **`~/.nova/credentials.json` stores the OIDC token + PAT metadata
|
||||||
|
(`jti`, `exp`, `type`) ONLY — NOT the raw PAT** (C-7.3). The raw PAT
|
||||||
|
is entered once at `nova auth login` and never persisted. An attacker
|
||||||
|
who reads the credentials file gets a short-lived OIDC token (15 min
|
||||||
|
default), not the long-lived PAT. Verified by
|
||||||
|
`tests/test_auth_commands.py:test_login_stores_oidc_token_not_raw_pat`.
|
||||||
|
- **Max TTL (C-6.2):** developer PATs ≤ 24h (86400s), service-account
|
||||||
|
PATs ≤ 1h (3600s). Enforced in `core.pat_lifecycle.issue_pat` —
|
||||||
|
requests above the max are clamped (with an audit event). The shorter
|
||||||
|
service-account TTL bounds the CI blast radius.
|
||||||
|
- **Revocation via strong-read DDB (D-229):** the token-vend Lambda
|
||||||
|
does `GetItem(PK=jti, ConsistentRead=True)` on `nova-pats` on every
|
||||||
|
vend. A revocation (`status=revoked`) is reflected on the next vend
|
||||||
|
within **60s P95** (the strong read is synchronous — the 60s is the
|
||||||
|
P95 propagation bound, not a polling delay). Verified by
|
||||||
|
`tests/test_pat_revocation.py:test_pat_revocation_slo` (asserts
|
||||||
|
`<1s` locally).
|
||||||
|
- **Emergency revocation at the DDB level** (when the CLI is
|
||||||
|
unavailable): `aws dynamodb update-item --table-name nova-pats ...`
|
||||||
|
flips `status` to `revoked` — see `docs/operator-guide-idp.md` §9.
|
||||||
|
|
||||||
|
**Residual risk:** medium. The PAT is a bearer token — theft is
|
||||||
|
undetectable until the attacker vends a token. Mitigation is TTL
|
||||||
|
bounding + revocation, not prevention. The 1h service-account cap is
|
||||||
|
the primary control for CI exposure.
|
||||||
|
|
||||||
|
### T-3 — JWKS unauthenticated endpoint DDoS (C-6.2)
|
||||||
|
|
||||||
|
**Threat:** the JWKS endpoint (`nova-idp-jwks` function URL,
|
||||||
|
`AuthType: NONE`) is a public, unauthenticated target. An attacker can
|
||||||
|
flood it with requests, exhausting Lambda concurrency and making token
|
||||||
|
verification fail for all clients (a cheap DoS).
|
||||||
|
|
||||||
|
**Mitigations:**
|
||||||
|
- **Reserved concurrency (10, max ~100 RPS):** the JWKS Lambda has a
|
||||||
|
reserved-concurrency limit of 10 (set in the CloudFormation
|
||||||
|
template). This caps the blast radius — a flood saturates the JWKS
|
||||||
|
Lambda but does NOT exhaust the account-wide concurrency pool, so
|
||||||
|
`nova-idp-auth` and `nova-idp-token-vend` keep serving.
|
||||||
|
- **Client-side caching (1h):** the JWKS response carries
|
||||||
|
`Cache-Control: max-age=3600`. Clients (`pyjwt.PyJWK` client) cache
|
||||||
|
the keys for 1h, so a JWKS outage does not immediately break
|
||||||
|
verification — already-cached keys keep working.
|
||||||
|
- **Optional CloudFront + WAF (rate-based rule):** `nova idp setup
|
||||||
|
--apply --public-jwks-domain <fqdn>` fronts the function URL with a
|
||||||
|
CloudFront distribution + a WAF web ACL with a rate-based rule
|
||||||
|
(e.g. block an IP after 2000 req/5min). **For any public deployment,
|
||||||
|
set `--public-jwks-domain`.** Without it the function URL is bare —
|
||||||
|
fine for piloting, exposed for production.
|
||||||
|
|
||||||
|
**Residual risk:** medium. The reserved concurrency bounds the cost
|
||||||
|
but a determined attacker can still keep the JWKS Lambda saturated.
|
||||||
|
The WAF + CloudFront path is the production-grade control. JWKS is
|
||||||
|
inherently public (clients MUST fetch it without auth) — this is a
|
||||||
|
fundamental OIDC property, not a Nova design flaw.
|
||||||
|
|
||||||
|
### T-4 — ABAC bypass (C-6.1 / C-7.1)
|
||||||
|
|
||||||
|
**Threat:** the ABAC policy engine (`kyverno-json` / `kj`) fails to
|
||||||
|
load, crashes, or is misconfigured, and the token-vend Lambda vends a
|
||||||
|
token anyway (fails open). This would bypass the authorization gate —
|
||||||
|
every active PAT gets a token regardless of the policy.
|
||||||
|
|
||||||
|
**Mitigations:**
|
||||||
|
- **Fail-closed (C-6.1/C-7.1 — the grill's #1 finding):** the
|
||||||
|
token-vend Lambda's `_evaluate_abac_fail_closed` returns
|
||||||
|
`(False, [], "", "abac_eval_failed")` if:
|
||||||
|
- `KyvernoJsonEngine.is_configured()` returns `False` (`kj` absent),
|
||||||
|
- `get_engine()` raises (engine registry error),
|
||||||
|
- `evaluate_token_vend_policy()` raises (policy parse error, `kj`
|
||||||
|
runtime error).
|
||||||
|
In all three cases the Lambda returns **403** + an audit event
|
||||||
|
`token.vend.denied` (reason `abac_eval_failed`). **Never fails open.**
|
||||||
|
This is INV-17's runtime guarantee — without it, INV-17 is
|
||||||
|
documentation, not a control.
|
||||||
|
- **Verified by `tests/test_abac_fail_closed.py` (7 tests):**
|
||||||
|
engine-not-configured, evaluate-raises, policy-parse-error, ABAC
|
||||||
|
denies, revoked PAT, unknown PAT, audit-event-emitted-on-denial.
|
||||||
|
- **Policy version in every audit event (D-231):** the git blob SHA of
|
||||||
|
`platform/abac/token-vend.policy` is recorded in every
|
||||||
|
`token.vend.allowed`/`token.vend.denied` event. An auditor can
|
||||||
|
reconstruct which policy version governed each vend.
|
||||||
|
|
||||||
|
**Residual risk:** low (given the fail-closed semantics). The
|
||||||
|
remaining risk is a policy-authoring bug (the policy allows too much)
|
||||||
|
— mitigated by PR review (D-231: Platform Security owns the policy)
|
||||||
|
and the policy-version audit trail.
|
||||||
|
|
||||||
|
### T-5 — KMS signing key compromise
|
||||||
|
|
||||||
|
**Threat:** an attacker gains `kms:Sign` permission on
|
||||||
|
`alias/nova-oidc-signing` and forges OIDC tokens.
|
||||||
|
|
||||||
|
**Mitigations:**
|
||||||
|
- **KMS key policy restricts `kms:Sign` to the token-vend Lambda
|
||||||
|
role.** No other principal (including the operator) can sign. The
|
||||||
|
JWKS Lambda role has `kms:GetPublicKey` only (not `Sign`).
|
||||||
|
- **Key rotation (90 days):** the alias is re-pointed to a new
|
||||||
|
`ECC_NIST_P256` key every 90 days (see
|
||||||
|
`docs/operator-guide-idp.md` §6). The old key stays enabled during
|
||||||
|
the overlap window (≥ max PAT TTL = 24h) so already-issued tokens
|
||||||
|
keep verifying, then is disabled + scheduled for deletion.
|
||||||
|
- **JWKS serves both `kid`s during the overlap window:** the JWKS
|
||||||
|
endpoint lists all keys the alias has pointed at that are still
|
||||||
|
enabled. Clients verify against the `kid` in the token header.
|
||||||
|
|
||||||
|
**Residual risk:** low. KMS key policies are the primary control;
|
||||||
|
rotation bounds the exposure window of a stolen key.
|
||||||
|
|
||||||
|
### T-6 — DER → raw ECDSA signature conversion bug (C-5.2 gotcha)
|
||||||
|
|
||||||
|
**Threat:** KMS `sign()` returns a **DER-encoded** ASN.1 ECDSA
|
||||||
|
signature. JWS (RFC 7515 §3.1.3) requires the **raw** `r‖s`
|
||||||
|
concatenation, each coordinate 32 bytes big-endian (for P-256). If the
|
||||||
|
conversion is wrong (wrong byte order, wrong padding, wrong coordinate
|
||||||
|
length), the resulting JWT will not verify with standard libraries
|
||||||
|
(`pyjwt`, `jose`) — or worse, verifies with a *different* signature
|
||||||
|
than intended (a subtle correctness + security bug).
|
||||||
|
|
||||||
|
This is the **#1 implementation risk** identified in RESEARCH §5. The
|
||||||
|
conversion is in `core/kms_signing.py:der_to_raw_ecdsa`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
r, s = decode_dss_signature(der_sig) # cryptography's ASN.1 parser
|
||||||
|
return r.to_bytes(32, "big") + s.to_bytes(32, "big") # raw r‖s
|
||||||
|
```
|
||||||
|
|
||||||
|
**Mitigations:**
|
||||||
|
- **`decode_dss_signature` from `cryptography`** parses the DER (not a
|
||||||
|
hand-rolled ASN.1 parser — that would be the real risk).
|
||||||
|
- **`to_bytes(32, "big")` zero-pads** each coordinate to exactly 32
|
||||||
|
bytes. A coordinate shorter than 32 bytes (high-order zero bytes)
|
||||||
|
is padded; a coordinate longer than 32 bytes raises `ValueError`
|
||||||
|
(the guard at the top of `der_to_raw_ecdsa`).
|
||||||
|
- **Verified by `tests/test_kms_roundtrip.py` (CAP-037):** sign a JWT
|
||||||
|
via `kms_signing.sign_jwt()` (mock KMS with a test ECC keypair) →
|
||||||
|
fetch JWKS via the JWKS Lambda → verify with `pyjwt` + the JWKS key.
|
||||||
|
The round-trip succeeds only if the DER→raw conversion is
|
||||||
|
byte-correct. This is the regression gate for any change to
|
||||||
|
`kms_signing.py`.
|
||||||
|
|
||||||
|
**Residual risk:** low (given the round-trip test). A KMS-side format
|
||||||
|
change (AWS changes the DER encoding) would break the test loudly.
|
||||||
|
|
||||||
|
### T-7 — No AWS-managed identity (INV-15)
|
||||||
|
|
||||||
|
**Threat:** (architectural invariant, not an attack.) Nova-idp depends
|
||||||
|
on Cognito, IAM Identity Center, or another AWS-managed identity
|
||||||
|
service, creating a vendor lock-in and an opaque trust boundary.
|
||||||
|
|
||||||
|
**Mitigation:**
|
||||||
|
- **INV-15 (no AWS-managed identity in path):** Nova-idp uses **KMS +
|
||||||
|
DDB + Lambda only.** No Cognito, no IAM Identity Center, no managed
|
||||||
|
user pools. The identity layer is greenfield and fully owned by
|
||||||
|
Nova. This is a constraint, not a mitigation — it shapes the whole
|
||||||
|
design (Argon2id in Lambda instead of Cognito user pools; KMS-signed
|
||||||
|
JWTs instead of Cognito issued tokens; DDB `nova-pats` instead of
|
||||||
|
IAM access keys).
|
||||||
|
- **Verified by inspection:** `core/lambda/nova_idp_auth.py` +
|
||||||
|
`nova_idp_token_vend.py` import only `boto3` (DDB + KMS), `argon2`,
|
||||||
|
`cryptography`, `pyjwt`, and `core.*`. No `cognitoidp` or
|
||||||
|
`identitystore` client calls anywhere in the identity layer.
|
||||||
|
|
||||||
|
**Residual risk:** none (this is a satisfied constraint, not a
|
||||||
|
residual). The trade-off is operational burden (Nova runs its own
|
||||||
|
password hashing, token signing, revocation) in exchange for
|
||||||
|
portability and no opaque trust boundary.
|
||||||
|
|
||||||
|
### T-8 — Audit trail integrity
|
||||||
|
|
||||||
|
**Threat:** an attacker tampers with the audit stream to hide a
|
||||||
|
malicious vend, a revocation, or a policy change.
|
||||||
|
|
||||||
|
**Mitigations:**
|
||||||
|
- **Every event emitted (INV-12):** `cli.invocation`, `auth.sign_up`,
|
||||||
|
`auth.sign_in`, `auth.session_created`, `pat.issued`, `pat.revoked`,
|
||||||
|
`token.vend.allowed`, `token.vend.denied`, `auth.login`,
|
||||||
|
`auth.status`, `auth.revoke` — each is a JSON line on stderr with a
|
||||||
|
timestamp + the relevant identifiers (`user_id`, `jti`, `sub`,
|
||||||
|
`policy_sha`).
|
||||||
|
- **Policy version (git SHA, D-231) in every token-vend event:** the
|
||||||
|
`policy_sha` field lets an auditor reconstruct which policy version
|
||||||
|
governed each vend — a policy change is visible in the audit stream
|
||||||
|
as a `policy_sha` change.
|
||||||
|
- **Raw credentials scrubbed (INV-16/INV-17 spirit):** the
|
||||||
|
`_emit_audit` functions in `nova_idp_auth.py`,
|
||||||
|
`nova_idp_token_vend.py`, and `pat_lifecycle.py` pop any
|
||||||
|
`password`/`pat`/`token`/`raw_pat` kwarg defense-in-depth. The audit
|
||||||
|
stream carries identifiers, not secrets.
|
||||||
|
- **Revoked PATs retained (REQ-343):** `nova-pats` rows are marked
|
||||||
|
`status=revoked`, never deleted. The audit trail of "who was
|
||||||
|
revoked, when" is queryable.
|
||||||
|
|
||||||
|
**Residual risk:** medium (audit integrity is only as strong as the
|
||||||
|
log destination). The Lambdas emit to stderr (CloudWatch Logs by
|
||||||
|
default); the integrity guarantee depends on the downstream log
|
||||||
|
pipeline (immutability, retention). For high-assurance deployments,
|
||||||
|
forward the audit stream to an append-only store (S3 Object Lock, a
|
||||||
|
write-once log service). This is a deployment concern, documented in
|
||||||
|
the operator guide.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 4. C-9.2 — INV-18..21 compression audit
|
||||||
|
|
||||||
|
The source spec (the v1.28 design document that was re-mapped into this
|
||||||
|
repo's REQ-323..353 / INV-12..17 — see `REQUIREMENTS.md` §v1.28 "ID
|
||||||
|
re-mapping") referenced `INV-18..21` as "attestation invariants."
|
||||||
|
Those IDs **do not exist in this repo** (this repo's invariants run
|
||||||
|
INV-1..11 for the blockchain/pilot work and INV-12..17 for v1.28). The
|
||||||
|
grill (C-9.2) requires an audit verifying the spec's attestation
|
||||||
|
invariant semantics were fully captured by the re-mapped
|
||||||
|
INV-15/INV-16/INV-17 + REQ-332, with no semantic gap.
|
||||||
|
|
||||||
|
### The spec's attestation invariant semantics (reconstructed)
|
||||||
|
|
||||||
|
The source spec's INV-18..21 expressed four attestation concerns:
|
||||||
|
|
||||||
|
1. **Immutability** — an attestation, once made, cannot be silently
|
||||||
|
altered.
|
||||||
|
2. **Signature verifiability** — the attestation's signature can be
|
||||||
|
independently verified by a third party holding the public key.
|
||||||
|
3. **Key derivation** — the signing key is derived from a known input
|
||||||
|
(the PAT) via a specified KDF, not ad-hoc.
|
||||||
|
4. **No AWS-managed identity** — the attestation scheme does not
|
||||||
|
depend on Cognito / IAM Identity Center (the greenfield constraint).
|
||||||
|
|
||||||
|
### Mapping to the re-mapped invariants + requirements
|
||||||
|
|
||||||
|
| Spec concern | Re-mapped to | Where enforced |
|
||||||
|
|--------------|--------------|----------------|
|
||||||
|
| Immutability | **INV-6** (existing, pre-v1.28 — the immutable audit ledger) + **INV-17** (ABAC discipline — every vend is audited with `policy_sha`) | the audit stream is append-only; `policy_sha` binds each vend to a policy version |
|
||||||
|
| Signature verifiability | **REQ-332** (JWS-from-PAT KDF) + **REQ-337** (KMS-signed OIDC, JWKS verifiable) | `core/jws_attestation.py:verify_attestation` (HS256, constant-time compare); `core/kms_signing.py` + JWKS endpoint |
|
||||||
|
| Key derivation | **REQ-332** (C-5.2 grill fix) — `HKDF-SHA256(PAT, salt='nova-local-attestation', info='jws-signing-key')` → 32-byte symmetric key | `core/jws_attestation.py:derive_signing_key`; verified by `tests/test_jws_attestation.py` |
|
||||||
|
| No AWS-managed identity | **INV-15** (no Cognito / IAM Identity Center in path) | inspection — the identity layer uses KMS + DDB + Lambda only |
|
||||||
|
|
||||||
|
### Conclusion: the compression is sound — no semantic gap
|
||||||
|
|
||||||
|
The spec's four attestation concerns are covered by:
|
||||||
|
- **INV-6** (immutability — the existing audit ledger, carried forward
|
||||||
|
from pre-v1.28 milestones),
|
||||||
|
- **INV-15** (no AWS-managed identity — the greenfield constraint),
|
||||||
|
- **INV-16** (password storage — the Argon2id + no-raw-password rule,
|
||||||
|
which is the attestation *input* integrity for signup),
|
||||||
|
- **INV-17** (ABAC discipline — every vend is policy-gated + audited
|
||||||
|
with `policy_sha`),
|
||||||
|
- **REQ-332** (JWS-from-PAT KDF — the signature + key-derivation
|
||||||
|
scheme for local-review attestations).
|
||||||
|
|
||||||
|
The re-mapping from `INV-18..21` → `INV-15/16/17 + REQ-332` is a
|
||||||
|
**compression** (4 invariants → 3 invariants + 1 requirement), not a
|
||||||
|
**drop**. The four original concerns (immutability, signature
|
||||||
|
verifiability, key derivation, no-managed-identity) each have a
|
||||||
|
load-bearing home in the re-mapped set. **No attestation invariant
|
||||||
|
semantics were silently dropped.**
|
||||||
|
|
||||||
|
The compression is *justified* because:
|
||||||
|
- INV-6 already covered audit immutability (re-stating it as INV-18
|
||||||
|
would have been a duplicate of an existing invariant).
|
||||||
|
- INV-15 already covered the no-managed-identity constraint
|
||||||
|
(re-stating it as INV-21 would have been a duplicate).
|
||||||
|
- INV-16 + INV-17 cover the input-integrity + policy-discipline
|
||||||
|
concerns that the spec's INV-19/20 expressed as attestation-specific
|
||||||
|
invariants (they are in fact general identity-layer invariants, not
|
||||||
|
attestation-specific).
|
||||||
|
- REQ-332 carries the signature + KDF detail that the spec's INV-18
|
||||||
|
hand-waved ("public key derivable from the PAT") — and corrects it
|
||||||
|
to a sound symmetric scheme (C-5.2).
|
||||||
|
|
||||||
|
### Audit verification (how to re-run this audit)
|
||||||
|
|
||||||
|
```sh
|
||||||
|
# 1. Confirm INV-18..21 do not exist in this repo.
|
||||||
|
grep -rE 'INV-1[89]|INV-2[01]' .ciagent/ docs/ core/ tests/ \
|
||||||
|
| grep -v 'INV-18..21' # only the C-9.2 audit references should remain
|
||||||
|
|
||||||
|
# 2. Confirm the re-mapped invariants + REQ-332 exist + are tested.
|
||||||
|
pytest tests/test_jws_attestation.py tests/test_abac_fail_closed.py \
|
||||||
|
tests/test_kms_roundtrip.py tests/test_argon2_fail_closed.py -q
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 5. Test coverage summary
|
||||||
|
|
||||||
|
| Threat | Test file | What it verifies |
|
||||||
|
|--------|-----------|------------------|
|
||||||
|
| T-1 (password) | `tests/test_argon2_fail_closed.py` | 503 on argon2 unavailable (no weak hash) |
|
||||||
|
| T-1 (password) | `tests/test_idp_auth.py` | no raw password in DDB item or logs (INV-16) |
|
||||||
|
| T-2 (PAT theft) | `tests/test_auth_commands.py` | credentials.json has OIDC token, NOT raw PAT (C-7.3) |
|
||||||
|
| T-2 (PAT theft) | `tests/test_pat_revocation.py` | revocation takes effect <1s (D-229 SLO) |
|
||||||
|
| T-3 (JWKS DDoS) | (CloudFormation template inspection) | reserved concurrency = 10; WAF with `--public-jwks-domain` |
|
||||||
|
| T-4 (ABAC bypass) | `tests/test_abac_fail_closed.py` (7 tests) | fail-closed on engine absent / error / deny (C-6.1) |
|
||||||
|
| T-5 (KMS key) | `tests/test_kms_roundtrip.py` | KMS sign → JWKS → pyjwt verify (CAP-037) |
|
||||||
|
| T-6 (DER→raw) | `tests/test_kms_roundtrip.py` | the round-trip succeeds only if DER→raw is byte-correct |
|
||||||
|
| T-7 (no managed id) | (inspection) | no `cognitoidp` / `identitystore` imports in the identity layer |
|
||||||
|
| T-8 (audit) | `tests/test_e2e_idp.py` | the full audit chain is present + linked (REQ-348) |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 6. Open items (deferred, not blocking v1.28)
|
||||||
|
|
||||||
|
- **WAF rate-limit tuning:** the default rate-based rule threshold
|
||||||
|
(2000 req/5min/IP) is a pilot-scale guess. Production tuning needs
|
||||||
|
real traffic data. Tracked as a post-v1.28 ops task.
|
||||||
|
- **Audit log forwarding to an append-only store** (S3 Object Lock):
|
||||||
|
the Lambdas emit to stderr / CloudWatch Logs by default. High-
|
||||||
|
assurance deployments should forward to a write-once destination.
|
||||||
|
Documented in the operator guide; not enforced in code.
|
||||||
|
- **PAT theft detection:** there is no anomaly detection on PAT usage
|
||||||
|
(e.g. a vend from a new geography). The TTL + revocation is the
|
||||||
|
control. Detection is a future milestone.
|
||||||
@@ -0,0 +1 @@
|
|||||||
|
"""Nova CLI package — thin subcommand delegates to core.* (P1, REQ-324)."""
|
||||||
@@ -0,0 +1,45 @@
|
|||||||
|
"""nova apply — resolve a contract + synthesize local env (REQ-330, REQ-332).
|
||||||
|
|
||||||
|
Subcommand (≤50 lines, ≤3 functions, delegates to core/ — NFR-7).
|
||||||
|
nova apply --local --contract .nova/contract.yml [--sign-local-review]
|
||||||
|
nova apply --contract contracts/microservice.yml --out stack.json
|
||||||
|
|
||||||
|
--local: calls core.env.synthesize_local_env() + core.contract_resolver.resolve()
|
||||||
|
--sign-local-review: calls core.jws_attestation.sign_attestation() (REQ-332)
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core import env
|
||||||
|
from core.contract_resolver import resolve
|
||||||
|
from core.jws_attestation import sign_attestation
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("apply", help="resolve a contract (+ local env synth)")
|
||||||
|
p.add_argument("--contract", default=".nova/contract.yml", help="contract YAML path")
|
||||||
|
p.add_argument("--out", default=None, help="output path (default: stdout)")
|
||||||
|
p.add_argument("--local", action="store_true", help="synthesize a local env (no AWS)")
|
||||||
|
p.add_argument("--environment", default=None, help="environment override")
|
||||||
|
p.add_argument("--sign-local-review", action="store_true", help="sign a local-review attestation (REQ-332)")
|
||||||
|
p.add_argument("--pat", default=None, help="PAT for --sign-local-review")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
synth = env.synthesize_local_env(args.contract, environment=args.environment) if args.local else None
|
||||||
|
env_override = (synth["name"] if isinstance(synth, dict) else None) or args.environment
|
||||||
|
result = resolve(args.contract, environment_override=env_override)
|
||||||
|
blob = json.dumps(result, indent=2) + "\n"
|
||||||
|
pat = args.pat or env.get_env("PAT", "") or ""
|
||||||
|
attestation = sign_attestation({"contract": args.contract, "review": "local"}, pat) if (args.sign_local_review and pat) else None
|
||||||
|
blob = blob + (attestation + "\n" if attestation else "")
|
||||||
|
print(blob) if args.out is None else open(args.out, "w").write(blob)
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova apply --contract <contract.yml> [--local] [--sign-local-review]", file=sys.stderr)
|
||||||
@@ -0,0 +1,22 @@
|
|||||||
|
"""nova attestation-matrix — run the 8-concern attestation matrix (REQ-109)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from core.attestation_matrix import cli_main
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("attestation-matrix", help="run the 8-concern attestation matrix")
|
||||||
|
p.add_argument("env", help="target environment (dev/qa/prod/dr)")
|
||||||
|
p.add_argument("evidence", nargs="?", default=None, help="evidence JSON path")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
argv = ["nova-attestation-matrix", args.env] + ([args.evidence] if args.evidence else [])
|
||||||
|
return cli_main(argv)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova attestation-matrix <env> [evidence.json]", file=sys.stderr)
|
||||||
@@ -0,0 +1,21 @@
|
|||||||
|
"""nova auth — login / revoke / status subcommands (REQ-344, C-7.3).
|
||||||
|
|
||||||
|
Subpackage entry point: ``add_parser`` registers the ``auth`` subparser
|
||||||
|
with ``login``/``revoke``/``status`` sub-subcommands, each delegating to
|
||||||
|
its module's ``run``. Discovered by ``nova/cli.py`` via
|
||||||
|
``pkgutil.iter_modules`` (this package's ``add_parser`` is the hook).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import argparse
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("auth", help="Nova IdP auth (login/revoke/status)")
|
||||||
|
sub = p.add_subparsers(dest="auth_command", required=True)
|
||||||
|
from nova.auth import login as _login, revoke as _revoke, status as _status
|
||||||
|
_login.add_parser(sub)
|
||||||
|
_revoke.add_parser(sub)
|
||||||
|
_status.add_parser(sub)
|
||||||
|
return p
|
||||||
@@ -0,0 +1,58 @@
|
|||||||
|
"""nova auth login — session/PAT → OIDC token, store locally (REQ-344, C-7.3)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from core.auth_store import store_credential, credentials_path
|
||||||
|
|
||||||
|
|
||||||
|
def _vend(pat: str, env: str, endpoint: str) -> dict:
|
||||||
|
"""Call the token-vend Lambda (locally or via the function URL)."""
|
||||||
|
if endpoint and endpoint.startswith("http"):
|
||||||
|
import urllib.request
|
||||||
|
body = json.dumps({"token": pat, "environment": env}).encode()
|
||||||
|
req = urllib.request.Request(endpoint, data=body, headers={"Content-Type": "application/json"})
|
||||||
|
with urllib.request.urlopen(req, timeout=30) as r:
|
||||||
|
return json.loads(r.read())
|
||||||
|
# Local: invoke the Lambda in-process.
|
||||||
|
import importlib.util
|
||||||
|
from pathlib import Path
|
||||||
|
p = Path(__import__("core").__file__).parent / "lambda" / "nova_idp_token_vend.py"
|
||||||
|
spec = importlib.util.spec_from_file_location("nova_idp_token_vend", p)
|
||||||
|
mod = importlib.util.module_from_spec(spec); spec.loader.exec_module(mod)
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
resp = mod.lambda_handler({"body": json.dumps({"token": pat, "environment": env})}, None)
|
||||||
|
return json.loads(resp["body"])
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("login", help="exchange a PAT/session for an OIDC token")
|
||||||
|
p.add_argument("--pat", default=None, help="PAT JWT (prompted if absent)")
|
||||||
|
p.add_argument("--session", default=None, help="session token (alias for --pat)")
|
||||||
|
p.add_argument("--environment", default="dev", help="target environment")
|
||||||
|
p.add_argument("--endpoint", default=os.environ.get("NOVA_TOKEN_VEND_URL", ""),
|
||||||
|
help="token-vend function URL (empty = local)")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
pat = args.pat or args.session or os.environ.get("NOVA_PAT")
|
||||||
|
if not pat:
|
||||||
|
pat = sys.stdin.readline().strip()
|
||||||
|
if not pat:
|
||||||
|
print("error: no PAT/session provided", file=sys.stderr); return 1
|
||||||
|
result = _vend(pat, args.environment, args.endpoint)
|
||||||
|
if "token" not in result:
|
||||||
|
print(f"error: {result.get('error', result)}", file=sys.stderr); return 2
|
||||||
|
import base64
|
||||||
|
payload = json.loads(base64.urlsafe_b64decode(result["token"].split(".")[1] + "=="))
|
||||||
|
store_credential(
|
||||||
|
jti=payload.get("jti", ""), cred_type=payload.get("typ", "nova_oidc_token"),
|
||||||
|
exp=payload.get("exp", 0), oidc_token=result["token"],
|
||||||
|
)
|
||||||
|
print(f"logged in: jti={payload.get('jti')} exp={payload.get('exp')} "
|
||||||
|
f"file={credentials_path()}")
|
||||||
|
return 0
|
||||||
@@ -0,0 +1,38 @@
|
|||||||
|
"""nova auth revoke --pat <jti> — revoke a PAT (REQ-344, D-229)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from core.auth_store import emit_revoke_audit
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("revoke", help="revoke a PAT by jti")
|
||||||
|
p.add_argument("--pat", required=True, help="PAT jti to revoke")
|
||||||
|
p.add_argument("--endpoint", default=os.environ.get("NOVA_TOKEN_VEND_URL", ""),
|
||||||
|
help="token-vend function URL (empty = local DDB)")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def _revoke_remote(jti: str, endpoint: str) -> dict:
|
||||||
|
import json, urllib.request
|
||||||
|
body = json.dumps({"action": "revoke_pat", "jti": jti}).encode()
|
||||||
|
req = urllib.request.Request(endpoint, data=body, headers={"Content-Type": "application/json"})
|
||||||
|
with urllib.request.urlopen(req, timeout=30) as r:
|
||||||
|
return json.loads(r.read())
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
try:
|
||||||
|
if args.endpoint and args.endpoint.startswith("http"):
|
||||||
|
_revoke_remote(args.pat, args.endpoint)
|
||||||
|
else:
|
||||||
|
from core.pat_lifecycle import revoke_pat
|
||||||
|
revoke_pat(args.pat)
|
||||||
|
emit_revoke_audit(args.pat)
|
||||||
|
print(f"revoked: jti={args.pat}")
|
||||||
|
return 0
|
||||||
|
except Exception as e:
|
||||||
|
print(f"error: {e}", file=sys.stderr); return 2
|
||||||
@@ -0,0 +1,34 @@
|
|||||||
|
"""nova auth status — print active credential + mode (REQ-344)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from core.auth_store import active_credential, emit_status_audit
|
||||||
|
from core.mode_resolver import resolve_mode_from_env
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("status", help="show active credential + client mode")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
cred = active_credential()
|
||||||
|
emit_status_audit()
|
||||||
|
mode, reason = resolve_mode_from_env(
|
||||||
|
credential_type=cred.get("type") if cred else None,
|
||||||
|
)
|
||||||
|
if cred is None:
|
||||||
|
print(f"no active credential (mode={mode}, reason={reason})")
|
||||||
|
return 0
|
||||||
|
print(json.dumps({
|
||||||
|
"active_credential_jti": cred.get("jti"),
|
||||||
|
"type": cred.get("type"),
|
||||||
|
"exp": cred.get("exp"),
|
||||||
|
"mode": mode,
|
||||||
|
"selection_reason": reason,
|
||||||
|
}, indent=2))
|
||||||
|
return 0
|
||||||
+60
@@ -0,0 +1,60 @@
|
|||||||
|
"""Nova CLI entry point — dispatch + audit (P1, REQ-324, INV-12).
|
||||||
|
|
||||||
|
Auto-discovers nova/<module>.py subcommands; each exports
|
||||||
|
add_parser(subparsers) + run(args) -> int. Resolves the client mode
|
||||||
|
via core.mode_resolver and emits a cli.invocation audit event (stderr
|
||||||
|
JSON line stub) before dispatching.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import argparse
|
||||||
|
import importlib
|
||||||
|
import json
|
||||||
|
import pkgutil
|
||||||
|
import sys
|
||||||
|
from typing import Optional
|
||||||
|
|
||||||
|
from core.mode_resolver import resolve_mode_from_env
|
||||||
|
|
||||||
|
|
||||||
|
def _emit_invocation(mode, reason, cred_type, command, args):
|
||||||
|
"""INV-12: emit cli.invocation audit event to stderr (stub)."""
|
||||||
|
event = {
|
||||||
|
"event": "cli.invocation",
|
||||||
|
"mode": mode,
|
||||||
|
"selection_reason": reason,
|
||||||
|
"credential_type": cred_type,
|
||||||
|
"command": command,
|
||||||
|
"args": args,
|
||||||
|
}
|
||||||
|
sys.stderr.write(json.dumps(event, sort_keys=True) + "\n")
|
||||||
|
|
||||||
|
|
||||||
|
import nova
|
||||||
|
|
||||||
|
|
||||||
|
def _build_parser():
|
||||||
|
parser = argparse.ArgumentParser(prog="nova", description="Nova platform CLI")
|
||||||
|
parser.add_argument("--mode", choices=["agent", "interactive"], default=None)
|
||||||
|
sub = parser.add_subparsers(dest="command", required=True)
|
||||||
|
for mod_info in pkgutil.iter_modules(nova.__path__):
|
||||||
|
name = mod_info.name
|
||||||
|
if name == "cli":
|
||||||
|
continue
|
||||||
|
mod = importlib.import_module(f"nova.{name}")
|
||||||
|
mod.add_parser(sub)
|
||||||
|
return parser
|
||||||
|
|
||||||
|
|
||||||
|
def main(argv: Optional[list] = None) -> int:
|
||||||
|
parser = _build_parser()
|
||||||
|
args = parser.parse_args(argv)
|
||||||
|
mode, reason = resolve_mode_from_env()
|
||||||
|
arg_dict = {k: v for k, v in vars(args).items() if k != "_run"}
|
||||||
|
_emit_invocation(mode, reason, None, args.command, arg_dict)
|
||||||
|
return args._run(args)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
sys.exit(main())
|
||||||
@@ -0,0 +1,21 @@
|
|||||||
|
"""nova confidence — compute the confidence signal (REQ-19)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from core.confidence_signal import cli_main
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("confidence", help="compute the confidence signal")
|
||||||
|
p.add_argument("inputs_json", help="path to an inputs JSON file")
|
||||||
|
p.add_argument("environment", help="target environment")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
return cli_main(["nova-confidence", args.inputs_json, args.environment])
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova confidence <inputs.json> <environment>", file=sys.stderr)
|
||||||
@@ -0,0 +1,28 @@
|
|||||||
|
"""nova decommission — transform a resolved stack for decommission (REQ-92)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core.decommission_transform import decommission_transform
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("decommission", help="transform a stack JSON for decommission")
|
||||||
|
p.add_argument("stack_json", help="path to a resolved stack JSON")
|
||||||
|
p.add_argument("--out", default=None, help="output path (default: stdout)")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
with open(args.stack_json) as fh:
|
||||||
|
stack = json.load(fh)
|
||||||
|
out = decommission_transform(stack)
|
||||||
|
blob = json.dumps(out, indent=2)
|
||||||
|
print(blob)
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova decommission <stack.json>", file=sys.stderr)
|
||||||
@@ -0,0 +1,25 @@
|
|||||||
|
"""nova env-check — check that an environment is bound (REQ-181)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from core.environment_check import check
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("env-check", help="check that an environment is bound")
|
||||||
|
p.add_argument("contract", nargs="?", default=None, help="contract path")
|
||||||
|
p.add_argument("--env", default=None, help="environment name override")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
ok, message = check(contract_path=args.contract, env_name=args.env)
|
||||||
|
print(message) if ok else sys.stderr.write(message + "\n")
|
||||||
|
return 0 if ok else 1
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova env-check <contract.yml> [--env name]", file=sys.stderr)
|
||||||
@@ -0,0 +1,37 @@
|
|||||||
|
"""nova env-transition — detect/record the applied environment (REQ-183)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core.env_transition import detect_prior_env, record_applied_env
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("env-transition", help="detect/record the env for a contract")
|
||||||
|
sub = p.add_subparsers(dest="env_transition_command", required=True)
|
||||||
|
pd = sub.add_parser("detect")
|
||||||
|
pd.add_argument("--contract-id", required=True)
|
||||||
|
pd.add_argument("--consumer-repo", required=True)
|
||||||
|
pd.add_argument("--new-env", required=True)
|
||||||
|
pr = sub.add_parser("record")
|
||||||
|
pr.add_argument("--contract-id", required=True)
|
||||||
|
pr.add_argument("--consumer-repo", required=True)
|
||||||
|
pr.add_argument("--env", required=True)
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
cmd = args.env_transition_command
|
||||||
|
payload = _dispatch(cmd, args)
|
||||||
|
print(json.dumps(payload))
|
||||||
|
return 0 if cmd == "detect" else (0 if payload["recorded"] else 1)
|
||||||
|
|
||||||
|
|
||||||
|
def _dispatch(cmd, args) -> dict:
|
||||||
|
return {"prior_env": detect_prior_env(args.contract_id, args.consumer_repo, args.new_env)} if cmd == "detect" else {"recorded": record_applied_env(args.contract_id, args.consumer_repo, args.env)}
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova env-transition detect|record ...", file=sys.stderr)
|
||||||
@@ -0,0 +1,33 @@
|
|||||||
|
"""nova hitl — attest a promotion gate (REQ-108)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from core.hitl_gates import attest, approver_from_env
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("hitl", help="attest a promotion gate")
|
||||||
|
p.add_argument("--contract-id", required=True)
|
||||||
|
p.add_argument("--env", required=True, help="dev/qa/prod/dr")
|
||||||
|
p.add_argument("--evidence", default=None, help="evidence JSON path")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
evidence = _load_evidence(args.evidence)
|
||||||
|
approver = approver_from_env() or ""
|
||||||
|
ok, reason = attest(args.contract_id, args.env, approver, evidence)
|
||||||
|
print(f"HITL PASS: {reason}") if ok else sys.stderr.write(f"HITL BLOCK: {reason}\n")
|
||||||
|
return 0 if ok else 1
|
||||||
|
|
||||||
|
|
||||||
|
def _load_evidence(path):
|
||||||
|
return {} if path is None else json.loads(open(path).read())
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova hitl --contract-id <id> --env <env> [--evidence f.json]", file=sys.stderr)
|
||||||
@@ -0,0 +1,13 @@
|
|||||||
|
"""nova idp — IdP setup subcommands (REQ-340, C-2.1)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import argparse
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("idp", help="Nova IdP management (setup)")
|
||||||
|
sub = p.add_subparsers(dest="idp_command", required=True)
|
||||||
|
from nova.idp import setup as _setup
|
||||||
|
_setup.add_parser(sub)
|
||||||
|
return p
|
||||||
@@ -0,0 +1,40 @@
|
|||||||
|
"""nova idp setup --check/--apply/--verify (REQ-340, REQ-341, C-2.1, ≤50 lines)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
|
||||||
|
def _load_setup():
|
||||||
|
"""Load core/lambda/nova_idp_setup.py via importlib (`lambda` is reserved)."""
|
||||||
|
p = Path(__import__("core").__file__).parent / "lambda" / "nova_idp_setup.py"
|
||||||
|
spec = importlib.util.spec_from_file_location("nova_idp_setup", p)
|
||||||
|
mod = importlib.util.module_from_spec(spec); spec.loader.exec_module(mod)
|
||||||
|
return mod
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("setup", help="check/apply/verify the Nova IdP stack")
|
||||||
|
p.add_argument("--check", action="store_true", help="check prerequisites")
|
||||||
|
p.add_argument("--apply", action="store_true", help="generate + deploy (NFR-10 y/N)")
|
||||||
|
p.add_argument("--verify", action="store_true", help="run the KMS round-trip test")
|
||||||
|
p.add_argument("--dry-run", action="store_true", help="resource summary only")
|
||||||
|
p.add_argument("--public-jwks-domain", default=None, help="custom JWKS domain")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
mod = _load_setup()
|
||||||
|
if args.check:
|
||||||
|
print(json.dumps(mod.check_prerequisites(), indent=2)); return 0
|
||||||
|
if args.verify:
|
||||||
|
r = mod.verify(); print(json.dumps(r, indent=2)); return 0 if r["passed"] else 1
|
||||||
|
if args.apply or args.dry_run:
|
||||||
|
r = mod.generate_and_deploy(args.public_jwks_domain, dry_run=args.dry_run)
|
||||||
|
print(json.dumps(r["summary"], indent=2))
|
||||||
|
return 0 if (r["deployed"] or args.dry_run) else 1
|
||||||
|
print("usage: nova idp setup --check|--apply|--verify [--dry-run]", file=sys.stderr)
|
||||||
|
return 2
|
||||||
@@ -0,0 +1,20 @@
|
|||||||
|
"""nova init — scaffold .nova/ + secrets .gitignore (P1, REQ-325)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from core.init_scaffold import scaffold
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("init", help="scaffold .nova/ + .gitignore in cwd")
|
||||||
|
p.add_argument("--force", action="store_true", help="overwrite existing .nova/")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
return scaffold(force=args.force)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova init [--force]", file=sys.stderr)
|
||||||
@@ -0,0 +1,33 @@
|
|||||||
|
"""nova onboard — generate an env binding from an onboarding request (REQ-181)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core.onboarding import generate_env_file
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("onboard", help="generate an env binding from a request")
|
||||||
|
p.add_argument("--request", default=None, help="inline request JSON")
|
||||||
|
p.add_argument("request_file", nargs="?", default=None, help="request JSON path")
|
||||||
|
p.add_argument("--out", default=None, help="output path (default: stdout)")
|
||||||
|
p.add_argument("--template-env", default="dev")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
request = _load_request(args)
|
||||||
|
env = generate_env_file(request, template_env=args.template_env)
|
||||||
|
blob = json.dumps(env, indent=2) + "\n"
|
||||||
|
print(blob) if args.out is None else open(args.out, "w").write(blob)
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
def _load_request(args):
|
||||||
|
return json.loads(args.request) if args.request else json.loads(open(args.request_file).read())
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova onboard <request.json> [--out env.json]", file=sys.stderr)
|
||||||
@@ -0,0 +1,26 @@
|
|||||||
|
"""nova outbox — write an evidence event to the DynamoDB outbox (D-P10-3)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core.outbox_writer import write_event
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("outbox", help="write an evidence event to the outbox")
|
||||||
|
p.add_argument("event_json", help="path to an event JSON file")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
with open(args.event_json) as fh:
|
||||||
|
event = json.load(fh)
|
||||||
|
item = write_event(event)
|
||||||
|
print(json.dumps({k: list(v.values())[0] for k, v in item.items()}, indent=2))
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova outbox <event.json>", file=sys.stderr)
|
||||||
@@ -0,0 +1,27 @@
|
|||||||
|
"""nova policy — print the active policy engine status (REQ-122)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core.policy_engine import get_engine, get_policy_root
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("policy", help="print the active policy engine status")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
eng = get_engine()
|
||||||
|
print(json.dumps({
|
||||||
|
"engine": eng.name,
|
||||||
|
"is_configured": eng.is_configured(),
|
||||||
|
"policy_root": str(get_policy_root()),
|
||||||
|
}, indent=2))
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova policy", file=sys.stderr)
|
||||||
@@ -0,0 +1,28 @@
|
|||||||
|
"""nova publish-outputs — publish stack outputs to SSM + format a PR comment (REQ-168)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core.output_publisher import publish_to_ssm, format_comment
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("publish-outputs", help="publish outputs to SSM + format comment")
|
||||||
|
p.add_argument("outputs_json", help="path to an outputs JSON file")
|
||||||
|
p.add_argument("environment")
|
||||||
|
p.add_argument("contract_id")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
with open(args.outputs_json) as fh:
|
||||||
|
outputs = json.load(fh)
|
||||||
|
ssm_results = publish_to_ssm(outputs, args.environment, args.contract_id)
|
||||||
|
print(format_comment(outputs, args.environment, args.contract_id, ssm_results))
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova publish-outputs <outputs.json> <env> <contract-id>", file=sys.stderr)
|
||||||
@@ -0,0 +1,20 @@
|
|||||||
|
"""nova readiness — submission readiness check (REQ-178)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from core.submission_readiness import cli_main
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("readiness", help="submission readiness check")
|
||||||
|
p.add_argument("contract_json", help="path to a contract/submission JSON")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
return cli_main(["nova-readiness", args.contract_json])
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova readiness <contract.json>", file=sys.stderr)
|
||||||
@@ -0,0 +1,29 @@
|
|||||||
|
"""nova regression — run the regression gate and write the report (REQ-177)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from core import env as _envhelper
|
||||||
|
from core.regression_verify import run_regression, write_report
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("regression", help="run the regression gate + write report")
|
||||||
|
p.add_argument("--milestone", default=None)
|
||||||
|
p.add_argument("--phase", type=int, default=None)
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
milestone = args.milestone or _envhelper.get_env("REGRESSION_MILESTONE", "v1.10") or "v1.10"
|
||||||
|
phase = args.phase if args.phase is not None else int(_envhelper.get_env("REGRESSION_PHASE", "52") or "52")
|
||||||
|
report = run_regression(milestone=milestone, phase=phase)
|
||||||
|
md, js = write_report(report)
|
||||||
|
print(f"regression: {report.summary} -> {md}")
|
||||||
|
return 0 if report.passed else 1
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova regression [--milestone v1.x] [--phase N]", file=sys.stderr)
|
||||||
@@ -0,0 +1,30 @@
|
|||||||
|
"""nova resolve — resolve a contract YAML to a Target Stack JSON."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
|
||||||
|
from core.contract_resolver import resolve
|
||||||
|
from core import env
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("resolve", help="resolve a contract.yml to stack JSON")
|
||||||
|
p.add_argument("contract")
|
||||||
|
p.add_argument("out")
|
||||||
|
p.add_argument("--environment", default=None)
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
env_override = args.environment or env.get_env("ENVIRONMENT_OVERRIDE")
|
||||||
|
result = resolve(args.contract, environment_override=env_override)
|
||||||
|
with open(args.out, "w") as fh:
|
||||||
|
json.dump(result, fh, indent=2)
|
||||||
|
print(f"resolve: wrote {args.out}")
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova resolve <contract.yml> <out.json>", file=sys.stderr)
|
||||||
+25
@@ -0,0 +1,25 @@
|
|||||||
|
"""nova sod — separation-of-duties check for a prod promotion (REQ-107)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from core.separation_of_duties import check
|
||||||
|
|
||||||
|
|
||||||
|
def add_parser(subparsers):
|
||||||
|
p = subparsers.add_parser("sod", help="separation-of-duties check for prod promotion")
|
||||||
|
p.add_argument("--contract-id", required=True)
|
||||||
|
p.add_argument("--approver", required=True, help="current prod approver identity")
|
||||||
|
p.set_defaults(_run=run)
|
||||||
|
|
||||||
|
|
||||||
|
def run(args) -> int:
|
||||||
|
ok, reason = check(None, args.contract_id, args.approver)
|
||||||
|
print(f"SOD PASS: {reason}") if ok else sys.stderr.write(f"SOD BLOCK: {reason}\n")
|
||||||
|
return 0 if ok else 1
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
import sys
|
||||||
|
print("use: nova sod --contract-id <id> --approver <user>", file=sys.stderr)
|
||||||
@@ -0,0 +1,2 @@
|
|||||||
|
v0.0.3
|
||||||
|
4ebb9a19fbf545e17f046c137f9b69c4288d021e5c73d962835671e0cb3fbf07
|
||||||
@@ -0,0 +1,51 @@
|
|||||||
|
{
|
||||||
|
"apiVersion": "json.kyverno.io/v1alpha1",
|
||||||
|
"kind": "ValidatingPolicy",
|
||||||
|
"metadata": {
|
||||||
|
"name": "token-vend",
|
||||||
|
"annotations": {
|
||||||
|
"nova.cloudinit.dev/severity": "critical",
|
||||||
|
"title.policy.kyverno.io": "Token vend ABAC authorization (REQ-339, C-5.1, C-6.1)"
|
||||||
|
}
|
||||||
|
},
|
||||||
|
"spec": {
|
||||||
|
"rules": [
|
||||||
|
{
|
||||||
|
"name": "owner-matches",
|
||||||
|
"assert": {
|
||||||
|
"all": [
|
||||||
|
{
|
||||||
|
"check": {
|
||||||
|
"(target_resource.owner == subject.owner)": true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"name": "role-env-match",
|
||||||
|
"assert": {
|
||||||
|
"all": [
|
||||||
|
{
|
||||||
|
"check": {
|
||||||
|
"((subject.role == 'developer' && environment == 'dev') || (subject.role == 'sre' && contains(['qa','prod','dr'], environment)))": true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"name": "requested-claims-present",
|
||||||
|
"assert": {
|
||||||
|
"all": [
|
||||||
|
{
|
||||||
|
"check": {
|
||||||
|
"(length(requested_claims) > `0`)": true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
}
|
||||||
+15
-2
@@ -2,19 +2,28 @@
|
|||||||
name = "nova"
|
name = "nova"
|
||||||
version = "1.14.0"
|
version = "1.14.0"
|
||||||
description = "Nova — consumers declare intent; the platform delivers safe production deployment."
|
description = "Nova — consumers declare intent; the platform delivers safe production deployment."
|
||||||
requires-python = ">=3.10"
|
requires-python = ">=3.12"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"boto3>=1.34",
|
"boto3>=1.34",
|
||||||
"jsonschema>=4.20",
|
"jsonschema>=4.20",
|
||||||
"pyyaml>=6.0",
|
"pyyaml>=6.0",
|
||||||
]
|
]
|
||||||
|
|
||||||
|
[project.scripts]
|
||||||
|
nova = "nova.cli:main"
|
||||||
|
|
||||||
[project.optional-dependencies]
|
[project.optional-dependencies]
|
||||||
test = [
|
test = [
|
||||||
"pytest>=8.0",
|
"pytest>=8.0",
|
||||||
"pytest-cov>=4.0",
|
"pytest-cov>=4.0",
|
||||||
"pytest-json-report>=1.5",
|
"pytest-json-report>=1.5",
|
||||||
"moto[dynamodb]>=5.0",
|
"moto[dynamodb]>=5.0",
|
||||||
|
"hypothesis>=6.100.0",
|
||||||
|
]
|
||||||
|
identity = [
|
||||||
|
"argon2-cffi>=23.1.0",
|
||||||
|
"cryptography>=42.0.0",
|
||||||
|
"pyjwt>=2.8.0",
|
||||||
]
|
]
|
||||||
slides = ["python-pptx>=0.6.23"]
|
slides = ["python-pptx>=0.6.23"]
|
||||||
|
|
||||||
@@ -34,4 +43,8 @@ run.source = ["core", "adapters"]
|
|||||||
|
|
||||||
[build-system]
|
[build-system]
|
||||||
requires = ["setuptools>=68"]
|
requires = ["setuptools>=68"]
|
||||||
build-backend = "setuptools.backends._legacy:_Backend"
|
build-backend = "setuptools.build_meta"
|
||||||
|
|
||||||
|
[tool.setuptools.packages.find]
|
||||||
|
where = ["."]
|
||||||
|
include = ["nova", "nova.*", "core", "core.*", "adapters.*"]
|
||||||
@@ -0,0 +1,231 @@
|
|||||||
|
"""ABAC fail-closed test for the token-vend Lambda (C-6.1/C-7.1, INV-17).
|
||||||
|
|
||||||
|
🔴 THIS IS THE MOST IMPORTANT TEST OF THE MILESTONE. It verifies that
|
||||||
|
INV-17 (ABAC fail-closed) is a **runtime guarantee**, not just
|
||||||
|
documentation. The grill's #1 finding was that a naive implementation
|
||||||
|
could fail open (vend a token when the ABAC engine is broken). This
|
||||||
|
test pins the opposite: **every** ABAC failure mode → 403 +
|
||||||
|
``token.vend.denied`` (reason ``abac_eval_failed``). Never fail open.
|
||||||
|
|
||||||
|
Failure modes covered:
|
||||||
|
1. ``KyvernoJsonEngine.is_configured()`` returns ``False`` (kj absent).
|
||||||
|
2. ``evaluate_token_vend_policy()`` raises an exception (kj error,
|
||||||
|
policy parse error, subprocess crash).
|
||||||
|
3. ABAC denies (allowed=False) → 403 reason ``abac_denied``.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
import time
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
# moto requires a region; the Lambda's lazy boto3.resource("dynamodb")
|
||||||
|
# picks up AWS_DEFAULT_REGION.
|
||||||
|
os.environ.setdefault("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
os.environ.setdefault("AWS_ACCESS_KEY_ID", "test")
|
||||||
|
os.environ.setdefault("AWS_SECRET_ACCESS_KEY", "test")
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
# Load the token-vend Lambda via importlib (`lambda` is a reserved word).
|
||||||
|
_SOURCE_PATH = (
|
||||||
|
Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_token_vend.py"
|
||||||
|
)
|
||||||
|
_spec = importlib.util.spec_from_file_location("nova_idp_token_vend", _SOURCE_PATH)
|
||||||
|
tv = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(tv)
|
||||||
|
|
||||||
|
# Load nova_idp_auth_cfn table helpers + moto for DDB.
|
||||||
|
import boto3
|
||||||
|
from moto import mock_aws
|
||||||
|
|
||||||
|
|
||||||
|
def _create_pats_table(ddb):
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-pats",
|
||||||
|
KeySchema=[{"AttributeName": "jti", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "jti", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "sub", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "pat_hash", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{"IndexName": "sub-index", "KeySchema": [{"AttributeName": "sub", "KeyType": "HASH"}], "Projection": {"ProjectionType": "ALL"}},
|
||||||
|
{"IndexName": "pat_hash-index", "KeySchema": [{"AttributeName": "pat_hash", "KeyType": "HASH"}], "Projection": {"ProjectionType": "ALL"}},
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _reset_lambda_singletons():
|
||||||
|
"""Reset the Lambda's module-level DynamoDB singleton before each test."""
|
||||||
|
tv._dynamodb = None
|
||||||
|
yield
|
||||||
|
tv._dynamodb = None
|
||||||
|
|
||||||
|
|
||||||
|
def _put_active_pat(ddb, jti="pat-active", sub="user-1", owner="t1", role="developer"):
|
||||||
|
ddb.put_item(
|
||||||
|
TableName="nova-pats",
|
||||||
|
Item={
|
||||||
|
"jti": {"S": jti},
|
||||||
|
"sub": {"S": sub},
|
||||||
|
"pat_hash": {"S": "hash-" + jti},
|
||||||
|
"status": {"S": "active"},
|
||||||
|
"issued_at": {"S": "2026-01-01T00:00:00Z"},
|
||||||
|
"expires_at": {"N": str(int(time.time()) + 3600)},
|
||||||
|
"claims": {"S": json.dumps({"sub": sub, "roles": [role], "owner": owner})},
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _make_pat_jwt(jti="pat-active", sub="user-1", role="developer", owner="t1"):
|
||||||
|
"""Build an unsigned-ish JWT (signature irrelevant — decoded without verify)."""
|
||||||
|
import base64
|
||||||
|
header = base64.urlsafe_b64encode(json.dumps({"alg": "none", "typ": "JWT"}).encode()).rstrip(b"=").decode()
|
||||||
|
payload = base64.urlsafe_b64encode(json.dumps({
|
||||||
|
"jti": jti, "sub": sub, "exp": int(time.time()) + 3600,
|
||||||
|
"iat": int(time.time()), "roles": [role], "owner": owner,
|
||||||
|
"typ": "developer_pat",
|
||||||
|
}).encode()).rstrip(b"=").decode()
|
||||||
|
return f"{header}.{payload}.sig"
|
||||||
|
|
||||||
|
|
||||||
|
def _vend_event(pat_jwt, **extra):
|
||||||
|
body = {"token": pat_jwt, "environment": "dev", "target_resource": {"type": "contract", "id": "c1", "owner": "t1", "environment": "dev"}, "requested_claims": ["sub"]}
|
||||||
|
body.update(extra)
|
||||||
|
return {"body": json.dumps(body)}
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# 🔴 THE CRITICAL TESTS — fail closed on every ABAC failure mode.
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_fail_closed_when_kj_not_configured():
|
||||||
|
"""C-6.1: is_configured() == False → 403 + abac_eval_failed. NEVER fail open."""
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb)
|
||||||
|
pat = _make_pat_jwt()
|
||||||
|
# Mock the engine so is_configured() returns False (kj absent).
|
||||||
|
fake_engine = mock.MagicMock()
|
||||||
|
fake_engine.is_configured.return_value = False
|
||||||
|
with mock.patch("core.policy_engine.get_engine", return_value=fake_engine):
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
body = json.loads(resp["body"])
|
||||||
|
assert body["reason"] == "abac_eval_failed"
|
||||||
|
assert body["error"] == "token_vend_denied"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_fail_closed_when_evaluate_raises():
|
||||||
|
"""C-6.1: evaluate() raises → 403 + abac_eval_failed. NEVER fail open."""
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb)
|
||||||
|
pat = _make_pat_jwt()
|
||||||
|
fake_engine = mock.MagicMock()
|
||||||
|
fake_engine.is_configured.return_value = True
|
||||||
|
# evaluate_token_vend_policy is called inside _evaluate_abac_fail_closed;
|
||||||
|
# patch the core.abac_evaluator module to raise.
|
||||||
|
with mock.patch("core.policy_engine.get_engine", return_value=fake_engine), \
|
||||||
|
mock.patch("core.abac_evaluator.evaluate_token_vend_policy",
|
||||||
|
side_effect=RuntimeError("kj crashed")):
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
body = json.loads(resp["body"])
|
||||||
|
assert body["reason"] == "abac_eval_failed"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_fail_closed_when_policy_parse_error():
|
||||||
|
"""C-6.1: policy parse error (evaluate raises ValueError) → 403."""
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb)
|
||||||
|
pat = _make_pat_jwt()
|
||||||
|
fake_engine = mock.MagicMock()
|
||||||
|
fake_engine.is_configured.return_value = True
|
||||||
|
with mock.patch("core.policy_engine.get_engine", return_value=fake_engine), \
|
||||||
|
mock.patch("core.abac_evaluator.evaluate_token_vend_policy",
|
||||||
|
side_effect=ValueError("policy parse error")):
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "abac_eval_failed"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_fail_closed_when_abac_denies():
|
||||||
|
"""ABAC denies (allowed=False) → 403 + abac_denied (distinct from eval_failed)."""
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb)
|
||||||
|
pat = _make_pat_jwt()
|
||||||
|
fake_engine = mock.MagicMock()
|
||||||
|
fake_engine.is_configured.return_value = True
|
||||||
|
with mock.patch("core.policy_engine.get_engine", return_value=fake_engine), \
|
||||||
|
mock.patch("core.abac_evaluator.evaluate_token_vend_policy",
|
||||||
|
return_value=(False, [], "sha")):
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "abac_denied"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_fail_closed_revoked_pat():
|
||||||
|
"""D-229: revoked PAT → 403 + pat_revoked (before ABAC even runs)."""
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb, jti="pat-rev")
|
||||||
|
ddb.update_item(
|
||||||
|
TableName="nova-pats",
|
||||||
|
Key={"jti": {"S": "pat-rev"}},
|
||||||
|
UpdateExpression="SET #s = :v",
|
||||||
|
ExpressionAttributeNames={"#s": "status"},
|
||||||
|
ExpressionAttributeValues={":v": {"S": "revoked"}},
|
||||||
|
)
|
||||||
|
pat = _make_pat_jwt(jti="pat-rev")
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "pat_revoked"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_fail_closed_unknown_pat():
|
||||||
|
"""D-229: PAT not in table → 403 + pat_unknown."""
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
pat = _make_pat_jwt(jti="pat-missing")
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "pat_unknown"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_audit_event_emitted_on_denial(capsys):
|
||||||
|
"""token.vend.denied audit event is emitted on every denial (INV-17)."""
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb)
|
||||||
|
pat = _make_pat_jwt()
|
||||||
|
fake_engine = mock.MagicMock()
|
||||||
|
fake_engine.is_configured.return_value = False
|
||||||
|
with mock.patch("core.policy_engine.get_engine", return_value=fake_engine):
|
||||||
|
tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
err = capsys.readouterr().err
|
||||||
|
audit_lines = [l for l in err.strip().split("\n") if l.strip()]
|
||||||
|
denied = [json.loads(l) for l in audit_lines if json.loads(l).get("event") == "token.vend.denied"]
|
||||||
|
assert denied, "expected a token.vend.denied audit event"
|
||||||
|
assert denied[0]["reason"] == "abac_eval_failed"
|
||||||
@@ -0,0 +1,103 @@
|
|||||||
|
"""ABAC policy tests for the token-vend Lambda (REQ-339, C-5.1, C-6.1).
|
||||||
|
|
||||||
|
Uses the **real** ``kj`` binary at ``/usr/local/bin/kj`` — these are
|
||||||
|
real policy-evaluation tests, not mocked. Skipped when ``kj`` is absent
|
||||||
|
(graceful, not failed — the binary is a build-host dep).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import shutil
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
from core.abac_evaluator import evaluate_token_vend_policy
|
||||||
|
|
||||||
|
KJ_AVAILABLE = shutil.which("kj") is not None
|
||||||
|
skip_no_kj = pytest.mark.skipif(
|
||||||
|
not KJ_AVAILABLE, reason="`kj` binary not on PATH (D-227 build-host dep)"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _payload(role, env, owner="t1", res_owner="t1"):
|
||||||
|
return {
|
||||||
|
"subject": {"id": "u1", "role": role, "owner": owner},
|
||||||
|
"requested_claims": ["sub", "roles"],
|
||||||
|
"target_resource": {
|
||||||
|
"type": "contract",
|
||||||
|
"id": "c1",
|
||||||
|
"owner": res_owner,
|
||||||
|
"environment": env,
|
||||||
|
},
|
||||||
|
"environment": env,
|
||||||
|
"pat_jti": "p1",
|
||||||
|
"policy_version": "test",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_developer_dev_allowed():
|
||||||
|
allowed, pcrs, sha = evaluate_token_vend_policy(_payload("developer", "dev"))
|
||||||
|
assert allowed is True, [p for p in pcrs if p["result"] == "fail"]
|
||||||
|
assert sha # non-empty SHA
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_sre_prod_allowed():
|
||||||
|
allowed, pcrs, sha = evaluate_token_vend_policy(_payload("sre", "prod"))
|
||||||
|
assert allowed is True, [p for p in pcrs if p["result"] == "fail"]
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_sre_qa_allowed():
|
||||||
|
allowed, _, _ = evaluate_token_vend_policy(_payload("sre", "qa"))
|
||||||
|
assert allowed is True
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_sre_dr_allowed():
|
||||||
|
allowed, _, _ = evaluate_token_vend_policy(_payload("sre", "dr"))
|
||||||
|
assert allowed is True
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_developer_prod_denied():
|
||||||
|
allowed, pcrs, _ = evaluate_token_vend_policy(_payload("developer", "prod"))
|
||||||
|
assert allowed is False
|
||||||
|
fails = [p for p in pcrs if p["result"] == "fail" and p["severity"] == "critical"]
|
||||||
|
assert fails, "expected at least one critical fail PCR"
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_wrong_owner_denied():
|
||||||
|
allowed, pcrs, _ = evaluate_token_vend_policy(
|
||||||
|
_payload("developer", "dev", owner="t1", res_owner="t2")
|
||||||
|
)
|
||||||
|
assert allowed is False
|
||||||
|
fails = [p for p in pcrs if p["result"] == "fail"]
|
||||||
|
assert fails
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_developer_qa_denied():
|
||||||
|
allowed, _, _ = evaluate_token_vend_policy(_payload("developer", "qa"))
|
||||||
|
assert allowed is False
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_empty_requested_claims_denied():
|
||||||
|
pl = _payload("developer", "dev")
|
||||||
|
pl["requested_claims"] = []
|
||||||
|
allowed, pcrs, _ = evaluate_token_vend_policy(pl)
|
||||||
|
assert allowed is False
|
||||||
|
|
||||||
|
|
||||||
|
@skip_no_kj
|
||||||
|
def test_policy_sha_is_string():
|
||||||
|
_, _, sha = evaluate_token_vend_policy(_payload("developer", "dev"))
|
||||||
|
assert isinstance(sha, str)
|
||||||
|
assert len(sha) > 0
|
||||||
@@ -0,0 +1,240 @@
|
|||||||
|
"""Argon2 fail-closed test (C-1.2, REQ-334, D-228).
|
||||||
|
|
||||||
|
Verifies the three pillars of D-228 (amended):
|
||||||
|
|
||||||
|
1. **ImportError → Argon2UnavailableError** — when the ``argon2`` C
|
||||||
|
extension fails to load, ``hash_password`` / ``verify_password``
|
||||||
|
raise ``Argon2UnavailableError`` (not a crash, not a weak hash, not
|
||||||
|
a return of a plaintext).
|
||||||
|
2. **Lambda handler → 503** — the handler returns HTTP 503
|
||||||
|
``{"error": "argon2_unavailable"}`` when ``_ARGON2_AVAILABLE`` is
|
||||||
|
False (no pure-Python fallback, no weak hash).
|
||||||
|
3. **No raw passwords in logs** — the password string never appears in
|
||||||
|
any log record (caplog).
|
||||||
|
|
||||||
|
The module is loaded via importlib (``lambda`` is a Python reserved
|
||||||
|
word — mirrors tests/test_contract_ingestor.py).
|
||||||
|
"""
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import logging
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
_SOURCE_PATH = (
|
||||||
|
Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_auth.py"
|
||||||
|
)
|
||||||
|
_spec = importlib.util.spec_from_file_location("nova_idp_auth", _SOURCE_PATH)
|
||||||
|
idp = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(idp)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Pillar 1: ImportError → Argon2UnavailableError (not a weak hash)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestArgon2ImportFailure:
|
||||||
|
"""C-1.2: the auth Lambda fails closed when the C extension is missing."""
|
||||||
|
|
||||||
|
def test_hash_password_raises_argon2unavailable_when_unavailable(self):
|
||||||
|
"""When _ARGON2_AVAILABLE is False, hash_password raises
|
||||||
|
Argon2UnavailableError — NOT a crash, NOT a weak hash, NOT a
|
||||||
|
plaintext return."""
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
with pytest.raises(idp.Argon2UnavailableError):
|
||||||
|
idp.hash_password("super-secret-123")
|
||||||
|
# And no hash string was produced (no weak fallback).
|
||||||
|
|
||||||
|
def test_verify_password_raises_argon2unavailable_when_unavailable(self):
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
with pytest.raises(idp.Argon2UnavailableError):
|
||||||
|
idp.verify_password("any", "$argon2id$fake$hash")
|
||||||
|
|
||||||
|
def test_hash_password_does_not_return_plaintext_on_failure(self):
|
||||||
|
"""C-1.2 explicit: the function must not return the raw password
|
||||||
|
or any non-argon2 string when argon2 is unavailable."""
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
try:
|
||||||
|
result = idp.hash_password("plaintext-to-check")
|
||||||
|
# If we get here, the function FAILED to fail closed.
|
||||||
|
pytest.fail(
|
||||||
|
f"hash_password returned {result!r} instead of raising "
|
||||||
|
f"Argon2UnavailableError (fail-closed violated)"
|
||||||
|
)
|
||||||
|
except idp.Argon2UnavailableError:
|
||||||
|
pass # correct
|
||||||
|
except Exception as e:
|
||||||
|
pytest.fail(
|
||||||
|
f"hash_password raised {type(e).__name__} instead of "
|
||||||
|
f"Argon2UnavailableError"
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_simulated_importerror_at_module_load_raises_unavailable(self):
|
||||||
|
"""Simulate the actual cold-start ImportError: reload the module
|
||||||
|
with argon2 import poisoned → _ARGON2_AVAILABLE is False and the
|
||||||
|
hashing functions raise Argon2UnavailableError."""
|
||||||
|
# Poison sys.modules so `from argon2 import PasswordHasher` fails.
|
||||||
|
with mock.patch.dict(sys.modules, {"argon2": None, "argon2.exceptions": None}):
|
||||||
|
# Reload in the poisoned environment.
|
||||||
|
mod = importlib.util.module_from_spec(_spec)
|
||||||
|
try:
|
||||||
|
_spec.loader.exec_module(mod)
|
||||||
|
except Exception:
|
||||||
|
# If exec_module itself raises (importlib treats None as
|
||||||
|
# "not imported"), that's also acceptable fail-closed
|
||||||
|
# behaviour — but we expect a clean load with the flag False.
|
||||||
|
mod = idp # fall back to the already-loaded module
|
||||||
|
assert mod._ARGON2_AVAILABLE is False, (
|
||||||
|
"module should mark argon2 unavailable on ImportError"
|
||||||
|
)
|
||||||
|
with pytest.raises(mod.Argon2UnavailableError):
|
||||||
|
mod.hash_password("x")
|
||||||
|
|
||||||
|
def test_argon2unavailable_is_a_clean_exception_not_a_crash(self):
|
||||||
|
"""The fail-closed signal is a catchable Exception, not a
|
||||||
|
segfault / SystemExit / KeyboardInterrupt."""
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
try:
|
||||||
|
idp.hash_password("x")
|
||||||
|
except idp.Argon2UnavailableError as e:
|
||||||
|
assert isinstance(e, Exception)
|
||||||
|
# Must NOT be a SystemExit or KeyboardInterrupt.
|
||||||
|
assert not isinstance(e, (SystemExit, KeyboardInterrupt))
|
||||||
|
# The message should mention argon2 / fail-closed.
|
||||||
|
assert "argon2" in str(e).lower()
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Pillar 2: Lambda handler → 503 (not a crash, not a weak hash)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestHandler503OnArgon2Unavailable:
|
||||||
|
"""C-1.2: the handler returns 503 when argon2 is unavailable."""
|
||||||
|
|
||||||
|
def test_sign_up_returns_503_when_argon2_unavailable(self):
|
||||||
|
"""When _ARGON2_AVAILABLE is False, sign_up → 503
|
||||||
|
argon2_unavailable (NOT a weak-hash write, NOT a 500 crash)."""
|
||||||
|
event = {
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "user@example.com",
|
||||||
|
"password": "SuperSecret-1",
|
||||||
|
"owner": "owner-1",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
}
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
resp = idp.lambda_handler(event, None)
|
||||||
|
assert resp["statusCode"] == 503, resp
|
||||||
|
body = json.loads(resp["body"])
|
||||||
|
assert body["error"] == "argon2_unavailable"
|
||||||
|
|
||||||
|
def test_sign_in_returns_503_when_argon2_unavailable(self):
|
||||||
|
event = {
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_in",
|
||||||
|
"email": "user@example.com",
|
||||||
|
"password": "SuperSecret-1",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
}
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
resp = idp.lambda_handler(event, None)
|
||||||
|
assert resp["statusCode"] == 503, resp
|
||||||
|
assert json.loads(resp["body"])["error"] == "argon2_unavailable"
|
||||||
|
|
||||||
|
def test_reset_password_returns_503_when_argon2_unavailable(self):
|
||||||
|
event = {
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "reset_password",
|
||||||
|
"reset_token": "some-token",
|
||||||
|
"new_password": "NewSecret-2",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
}
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
resp = idp.lambda_handler(event, None)
|
||||||
|
assert resp["statusCode"] == 503, resp
|
||||||
|
|
||||||
|
def test_503_is_not_a_500_crash(self):
|
||||||
|
"""The fail-closed response is exactly 503, never 500."""
|
||||||
|
event = {
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "u@e.com",
|
||||||
|
"password": "p",
|
||||||
|
"owner": "o",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
}
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
resp = idp.lambda_handler(event, None)
|
||||||
|
assert resp["statusCode"] != 500, "fail-closed must be 503, not 500"
|
||||||
|
assert resp["statusCode"] != 200, "fail-closed must not succeed"
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Pillar 3: no raw passwords in logs (INV-16)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestNoRawPasswordsInLogs:
|
||||||
|
"""INV-16: raw passwords never appear in logs / traces."""
|
||||||
|
|
||||||
|
def test_hash_password_does_not_log_password(self, caplog):
|
||||||
|
secret = "NeverLogMe-12345"
|
||||||
|
with caplog.at_level(logging.DEBUG, logger="nova_idp_auth"):
|
||||||
|
idp.hash_password(secret)
|
||||||
|
for record in caplog.records:
|
||||||
|
assert secret not in record.getMessage(), (
|
||||||
|
f"raw password leaked in log: {record.getMessage()!r}"
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_audit_emit_does_not_include_password(self, caplog):
|
||||||
|
"""The _emit_audit helper must never include a password field."""
|
||||||
|
with caplog.at_level(logging.DEBUG):
|
||||||
|
idp._emit_audit(
|
||||||
|
"auth.test", user_id="u1", email="e@e.com", password="leak-me"
|
||||||
|
)
|
||||||
|
full = "\n".join(r.getMessage() for r in caplog.records)
|
||||||
|
assert "leak-me" not in full, "password leaked via audit emit"
|
||||||
|
# Even though we passed password=, it must be scrubbed.
|
||||||
|
for record in caplog.records:
|
||||||
|
assert "leak-me" not in record.getMessage()
|
||||||
|
|
||||||
|
def test_sign_up_audit_does_not_log_password(self, caplog, monkeypatch):
|
||||||
|
"""End-to-end: a sign_up writes an audit event to stderr that
|
||||||
|
does NOT contain the raw password."""
|
||||||
|
# Stub DynamoDB so we don't need moto here (just test the audit).
|
||||||
|
from tests.test_idp_auth import _stub_dynamodb_for_audit
|
||||||
|
|
||||||
|
_stub_dynamodb_for_audit(idp, monkeypatch)
|
||||||
|
secret = "AuditSecret-99887"
|
||||||
|
with caplog.at_level(logging.DEBUG):
|
||||||
|
idp.sign_up(
|
||||||
|
{
|
||||||
|
"email": "audit@example.com",
|
||||||
|
"password": secret,
|
||||||
|
"owner": "owner-1",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
for record in caplog.records:
|
||||||
|
msg = record.getMessage()
|
||||||
|
assert secret not in msg, (
|
||||||
|
f"raw password leaked in audit log: {msg!r}"
|
||||||
|
)
|
||||||
@@ -0,0 +1,207 @@
|
|||||||
|
"""nova auth login/revoke/status tests (REQ-344, C-7.3).
|
||||||
|
|
||||||
|
C-7.3: ``~/.nova/credentials.json`` stores OIDC token + PAT metadata
|
||||||
|
(jti, exp, type) ONLY — NOT the raw PAT. Verified by asserting the
|
||||||
|
file contains no ``raw_pat`` / ``pat`` field.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import stat
|
||||||
|
import sys
|
||||||
|
import time
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
os.environ.setdefault("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
os.environ.setdefault("AWS_ACCESS_KEY_ID", "test")
|
||||||
|
os.environ.setdefault("AWS_SECRET_ACCESS_KEY", "test")
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
from moto import mock_aws
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
import core.pat_lifecycle as pat_life
|
||||||
|
import core.auth_store as auth_store
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Test keypair + mock KMS.
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class _MockKms:
|
||||||
|
def __init__(self, priv, pub_der):
|
||||||
|
self._priv = priv
|
||||||
|
self._pub_der = pub_der
|
||||||
|
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
return {"Signature": self._priv.sign(Message, ec.ECDSA(hashes.SHA256()))}
|
||||||
|
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": self._pub_der}
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def test_keypair():
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub = priv.public_key()
|
||||||
|
pub_der = pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
return priv, pub, pub_der
|
||||||
|
|
||||||
|
|
||||||
|
def _create_pats_table(ddb):
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-pats",
|
||||||
|
KeySchema=[{"AttributeName": "jti", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "jti", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "sub", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "pat_hash", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{"IndexName": "sub-index", "KeySchema": [{"AttributeName": "sub", "KeyType": "HASH"}], "Projection": {"ProjectionType": "ALL"}},
|
||||||
|
{"IndexName": "pat_hash-index", "KeySchema": [{"AttributeName": "pat_hash", "KeyType": "HASH"}], "Projection": {"ProjectionType": "ALL"}},
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _cred_file(tmp_path, monkeypatch):
|
||||||
|
"""Isolate credentials.json to a tmp path."""
|
||||||
|
cred = tmp_path / "credentials.json"
|
||||||
|
monkeypatch.setenv("NOVA_CREDENTIALS_FILE", str(cred))
|
||||||
|
yield cred
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
pat_life._dynamodb = None
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# nova auth login
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_login_stores_oidc_token_not_raw_pat(tmp_path, test_keypair, _cred_file):
|
||||||
|
priv, _pub, pub_der = test_keypair
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
# Issue a PAT.
|
||||||
|
pat = pat_life.issue_pat("user-1", ["developer"], "t1", ttl_seconds=3600)
|
||||||
|
assert pat # raw PAT returned once
|
||||||
|
# Run nova auth login via the local Lambda path.
|
||||||
|
from nova.auth import login as login_mod
|
||||||
|
args = mock.MagicMock()
|
||||||
|
args.pat = pat
|
||||||
|
args.session = None
|
||||||
|
args.environment = "dev"
|
||||||
|
args.endpoint = "" # local
|
||||||
|
rc = login_mod.run(args)
|
||||||
|
assert rc == 0
|
||||||
|
# Assert credentials.json exists + is 0600.
|
||||||
|
assert _cred_file.exists()
|
||||||
|
mode = stat.S_IMODE(os.stat(_cred_file).st_mode)
|
||||||
|
assert mode == 0o600
|
||||||
|
data = json.loads(_cred_file.read_text())
|
||||||
|
# C-7.3: contains the OIDC token + metadata, NOT the raw PAT.
|
||||||
|
cred = data["credentials"][0]
|
||||||
|
assert "token" in cred # the OIDC token
|
||||||
|
assert cred["type"] == "nova_oidc_token"
|
||||||
|
assert "jti" in cred and "exp" in cred
|
||||||
|
raw = _cred_file.read_text()
|
||||||
|
assert "raw_pat" not in raw
|
||||||
|
assert pat not in raw # the raw PAT string must NOT appear
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_login_denied_pat_returns_error(tmp_path, test_keypair, _cred_file):
|
||||||
|
priv, _pub, pub_der = test_keypair
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
pat = pat_life.issue_pat("user-1", ["developer"], "t1", ttl_seconds=3600)
|
||||||
|
# Revoke it.
|
||||||
|
# Extract jti from the PAT.
|
||||||
|
import base64
|
||||||
|
payload = json.loads(base64.urlsafe_b64decode(pat.split(".")[1] + "=="))
|
||||||
|
pat_life.revoke_pat(payload["jti"])
|
||||||
|
from nova.auth import login as login_mod
|
||||||
|
args = mock.MagicMock()
|
||||||
|
args.pat = pat; args.session = None; args.environment = "dev"; args.endpoint = ""
|
||||||
|
rc = login_mod.run(args)
|
||||||
|
assert rc != 0 # denied
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# nova auth status
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_status_no_credential(_cred_file, capsys):
|
||||||
|
from nova.auth import status as status_mod
|
||||||
|
rc = status_mod.run(mock.MagicMock())
|
||||||
|
assert rc == 0
|
||||||
|
out = capsys.readouterr().out
|
||||||
|
assert "no active credential" in out
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_status_shows_mode_and_jti(tmp_path, test_keypair, _cred_file, capsys):
|
||||||
|
priv, _pub, pub_der = test_keypair
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
pat = pat_life.issue_pat("user-1", ["developer"], "t1", ttl_seconds=3600)
|
||||||
|
from nova.auth import login as login_mod
|
||||||
|
args = mock.MagicMock()
|
||||||
|
args.pat = pat; args.session = None; args.environment = "dev"; args.endpoint = ""
|
||||||
|
login_mod.run(args)
|
||||||
|
capsys.readouterr() # drain login output
|
||||||
|
from nova.auth import status as status_mod
|
||||||
|
rc = status_mod.run(mock.MagicMock())
|
||||||
|
assert rc == 0
|
||||||
|
out = capsys.readouterr().out
|
||||||
|
data = json.loads(out)
|
||||||
|
assert "mode" in data
|
||||||
|
assert "selection_reason" in data
|
||||||
|
assert data["type"] == "nova_oidc_token"
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# nova auth revoke
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_revoke_sets_status_revoked(tmp_path, test_keypair, _cred_file, capsys):
|
||||||
|
priv, _pub, pub_der = test_keypair
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
pat = pat_life.issue_pat("user-1", ["developer"], "t1", ttl_seconds=3600)
|
||||||
|
import base64
|
||||||
|
payload = json.loads(base64.urlsafe_b64decode(pat.split(".")[1] + "=="))
|
||||||
|
jti = payload["jti"]
|
||||||
|
from nova.auth import revoke as revoke_mod
|
||||||
|
args = mock.MagicMock()
|
||||||
|
args.pat = jti; args.endpoint = ""
|
||||||
|
rc = revoke_mod.run(args)
|
||||||
|
assert rc == 0
|
||||||
|
# Verify status=revoked in DDB.
|
||||||
|
item = ddb.get_item(TableName="nova-pats", Key={"jti": {"S": jti}}, ConsistentRead=True)
|
||||||
|
assert item["Item"]["status"]["S"] == "revoked"
|
||||||
@@ -0,0 +1,168 @@
|
|||||||
|
"""Tests for nova CLI subcommands (P1, CAP-033 + CAP-034, REQ-324).
|
||||||
|
|
||||||
|
CAP-033: `nova --help` lists a subcommand for every user-facing core/ module.
|
||||||
|
CAP-034: AST-scan every nova/<module>.py (except cli.py, __init__.py) for
|
||||||
|
line count ≤50, ≤3 FunctionDef, calls resolve to core.* imports,
|
||||||
|
and no `if` statements except `if __name__ == "__main__"`.
|
||||||
|
Also: `nova init` scaffolds .nova/ + .gitignore in a tmp dir.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import ast
|
||||||
|
import os
|
||||||
|
import subprocess
|
||||||
|
import sys
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
NOVA_DIR = os.path.join(os.path.dirname(__file__), "..", "nova")
|
||||||
|
NOVA_DIR = os.path.abspath(NOVA_DIR)
|
||||||
|
|
||||||
|
# Expected subcommand for every user-facing core/ module
|
||||||
|
# (skip internal-only: env, local_emulators, *_cli shims, init_scaffold,
|
||||||
|
# mode_resolver, confidence_signal has its own nova subcommand).
|
||||||
|
EXPECTED_SUBCOMMANDS = {
|
||||||
|
"contract_resolver": "resolve",
|
||||||
|
"decommission_transform": "decommission",
|
||||||
|
"env_transition": "env-transition",
|
||||||
|
"environment_check": "env-check",
|
||||||
|
"hitl_gates": "hitl",
|
||||||
|
"onboarding": "onboard",
|
||||||
|
"outbox_writer": "outbox",
|
||||||
|
"output_publisher": "publish-outputs",
|
||||||
|
"policy_engine": "policy",
|
||||||
|
"regression_verify": "regression",
|
||||||
|
"separation_of_duties": "sod",
|
||||||
|
"submission_readiness": "readiness",
|
||||||
|
"attestation_matrix": "attestation-matrix",
|
||||||
|
"confidence_signal": "confidence",
|
||||||
|
"init_scaffold": "init",
|
||||||
|
}
|
||||||
|
|
||||||
|
# Builtins / stdlib names allowed as bare Call targets (everything else
|
||||||
|
# must resolve to a name imported from core.*).
|
||||||
|
_BUILTIN_CALLS = {
|
||||||
|
"print", "open", "len", "str", "int", "bool", "dict", "list", "tuple",
|
||||||
|
"range", "isinstance", "getattr", "setattr", "hasattr", "sorted",
|
||||||
|
"min", "max", "sum", "any", "all", "enumerate", "zip", "map", "filter",
|
||||||
|
"format", "repr", "type", "abs", "round",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _nova_help_cmd():
|
||||||
|
"""Return the command list to invoke `nova --help` (prefer installed entry)."""
|
||||||
|
nova = os.path.join(os.path.dirname(sys.executable), "nova")
|
||||||
|
if os.path.isfile(nova):
|
||||||
|
return [nova, "--help"]
|
||||||
|
return [sys.executable, "-m", "nova.cli", "--help"]
|
||||||
|
|
||||||
|
|
||||||
|
# --- CAP-033: help lists every expected subcommand ---
|
||||||
|
|
||||||
|
def test_help_lists_all_subcommands():
|
||||||
|
cmd = _nova_help_cmd()
|
||||||
|
proc = subprocess.run(cmd, capture_output=True, text=True, cwd=os.getcwd())
|
||||||
|
assert proc.returncode == 0, f"nova --help failed: {proc.stderr}"
|
||||||
|
help_text = proc.stdout
|
||||||
|
for core_mod, subname in EXPECTED_SUBCOMMANDS.items():
|
||||||
|
assert subname in help_text, (
|
||||||
|
f"subcommand {subname!r} (for core/{core_mod}.py) not in nova --help output"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
# --- CAP-034: AST scan of nova/<module>.py ---
|
||||||
|
|
||||||
|
def _nova_modules():
|
||||||
|
out = []
|
||||||
|
for fn in sorted(os.listdir(NOVA_DIR)):
|
||||||
|
if not fn.endswith(".py"):
|
||||||
|
continue
|
||||||
|
if fn in ("cli.py", "__init__.py"):
|
||||||
|
continue
|
||||||
|
out.append(os.path.join(NOVA_DIR, fn))
|
||||||
|
return out
|
||||||
|
|
||||||
|
|
||||||
|
def _core_imported_names(tree):
|
||||||
|
"""Collect names imported from `core` or `core.*` modules."""
|
||||||
|
names = set()
|
||||||
|
for node in ast.walk(tree):
|
||||||
|
if isinstance(node, ast.ImportFrom) and node.module and (
|
||||||
|
node.module == "core" or node.module.startswith("core.")
|
||||||
|
):
|
||||||
|
for alias in node.names:
|
||||||
|
names.add(alias.asname or alias.name)
|
||||||
|
return names
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("modpath", _nova_modules())
|
||||||
|
def test_module_caps034_constraints(modpath):
|
||||||
|
src = open(modpath, encoding="utf-8").read()
|
||||||
|
lines = src.splitlines()
|
||||||
|
# (a) ≤50 lines
|
||||||
|
assert len(lines) <= 50, f"{modpath}: {len(lines)} lines > 50"
|
||||||
|
tree = ast.parse(src, filename=modpath)
|
||||||
|
# (b) ≤3 FunctionDef/AsyncFunctionDef
|
||||||
|
func_defs = [
|
||||||
|
n for n in ast.walk(tree)
|
||||||
|
if isinstance(n, (ast.FunctionDef, ast.AsyncFunctionDef))
|
||||||
|
]
|
||||||
|
assert len(func_defs) <= 3, f"{modpath}: {len(func_defs)} function defs > 3"
|
||||||
|
local_func_names = {f.name for f in func_defs}
|
||||||
|
# (c) every bare Call target resolves to a core.* import, a builtin,
|
||||||
|
# or a function defined in this module (local helper).
|
||||||
|
core_names = _core_imported_names(tree)
|
||||||
|
allowed = core_names | _BUILTIN_CALLS | local_func_names
|
||||||
|
for node in ast.walk(tree):
|
||||||
|
if isinstance(node, ast.Call):
|
||||||
|
func = node.func
|
||||||
|
if isinstance(func, ast.Name):
|
||||||
|
assert func.id in allowed, (
|
||||||
|
f"{modpath}: call to {func.id!r} not from a core.* import, "
|
||||||
|
f"a builtin, or a local function def"
|
||||||
|
)
|
||||||
|
# ast.Attribute calls (method calls on locals/args) are allowed
|
||||||
|
# (d) no `if` statements except `if __name__ == "__main__"`
|
||||||
|
if isinstance(node, ast.If):
|
||||||
|
test = node.test
|
||||||
|
is_main_guard = (
|
||||||
|
isinstance(test, ast.Compare)
|
||||||
|
and isinstance(test.left, ast.Name)
|
||||||
|
and test.left.id == "__name__"
|
||||||
|
)
|
||||||
|
assert is_main_guard, f"{modpath}: non-__main__ `if` statement"
|
||||||
|
|
||||||
|
|
||||||
|
# --- nova init scaffolding ---
|
||||||
|
|
||||||
|
def test_nova_init_scaffolds(tmp_path):
|
||||||
|
cmd = _nova_help_cmd()
|
||||||
|
# build an init command (replace --help with init)
|
||||||
|
init_cmd = cmd[:-1] + ["init"]
|
||||||
|
proc = subprocess.run(init_cmd, capture_output=True, text=True, cwd=str(tmp_path))
|
||||||
|
assert proc.returncode == 0, f"nova init failed: {proc.stderr}"
|
||||||
|
nova_dir = tmp_path / ".nova"
|
||||||
|
attest_dir = nova_dir / "contract.yml.attestations"
|
||||||
|
gitignore = tmp_path / ".gitignore"
|
||||||
|
assert nova_dir.is_dir(), ".nova/ not created"
|
||||||
|
assert attest_dir.is_dir(), ".nova/contract.yml.attestations/ not created"
|
||||||
|
assert gitignore.is_file(), ".gitignore not created"
|
||||||
|
content = gitignore.read_text()
|
||||||
|
for line in (
|
||||||
|
"~/.nova/credentials.json",
|
||||||
|
".nova/credentials.json",
|
||||||
|
"*.pem",
|
||||||
|
"*.key",
|
||||||
|
".env",
|
||||||
|
".env.*",
|
||||||
|
):
|
||||||
|
assert line in content, f"{line!r} missing from .gitignore"
|
||||||
|
|
||||||
|
|
||||||
|
def test_nova_init_refuses_without_force(tmp_path):
|
||||||
|
(tmp_path / ".nova").mkdir()
|
||||||
|
cmd = _nova_help_cmd()
|
||||||
|
init_cmd = cmd[:-1] + ["init"]
|
||||||
|
proc = subprocess.run(init_cmd, capture_output=True, text=True, cwd=str(tmp_path))
|
||||||
|
assert proc.returncode == 1, f"nova init should refuse existing dir: {proc.stdout}"
|
||||||
@@ -0,0 +1,258 @@
|
|||||||
|
"""REQ-329 dual-use test: Lambda handler + CLI paths share ≥80% code.
|
||||||
|
|
||||||
|
The contract ingestor (core/lambda/contract_ingestor.py) is dual-use:
|
||||||
|
- the AWS Lambda handler (lambda_handler) parses a Function-URL event
|
||||||
|
- the CLI path (cli_main / __main__ --dispatch) parses a JSON file/stdin
|
||||||
|
|
||||||
|
Both paths must call the SAME shared business-logic function
|
||||||
|
(dispatch_action) so the action routing, contract validation, DynamoDB
|
||||||
|
write, and error reporting are a single source of truth (NFR-7).
|
||||||
|
|
||||||
|
This test verifies:
|
||||||
|
1. both paths produce identical output for the same input payload
|
||||||
|
(using LocalLambdaStub for the Lambda path, cli_main for the CLI path).
|
||||||
|
2. both paths route through the shared dispatch_action function
|
||||||
|
(the ≥80% code-share is enforced structurally — the shared function
|
||||||
|
is the business logic; the wrappers are thin input parsers).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import inspect
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
# Load core/lambda/contract_ingestor.py as a top-level module (the `lambda`
|
||||||
|
# dir name is a Python keyword, so the dotted import is unavailable).
|
||||||
|
_SOURCE_PATH = Path(__file__).resolve().parent.parent / "core" / "lambda" / "contract_ingestor.py"
|
||||||
|
_spec = importlib.util.spec_from_file_location("contract_ingestor", _SOURCE_PATH)
|
||||||
|
ingestor = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(ingestor)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _local_bypass(monkeypatch):
|
||||||
|
"""The local tier has no IAM identity — set the bypass for both paths."""
|
||||||
|
monkeypatch.setenv("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def sample_payload():
|
||||||
|
return {
|
||||||
|
"consumerRepo": "acdl/consumer-a",
|
||||||
|
"contractId": "dual-use-001",
|
||||||
|
"contract": {
|
||||||
|
"id": "test",
|
||||||
|
"name": "dual-use-contract",
|
||||||
|
"environment": "dev",
|
||||||
|
"infrastructure": {"s3": {"version": "1.0.0", "inputs": {}}},
|
||||||
|
},
|
||||||
|
"environment": "dev",
|
||||||
|
"action": "submit_contract",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def moto_table(monkeypatch):
|
||||||
|
"""moto-backed DynamoDB so submit_contract writes somewhere real."""
|
||||||
|
from moto import mock_aws
|
||||||
|
import boto3
|
||||||
|
|
||||||
|
monkeypatch.setenv("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "testing")
|
||||||
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "testing")
|
||||||
|
with mock_aws():
|
||||||
|
dyn = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
dyn.create_table(
|
||||||
|
TableName="nova-contracts",
|
||||||
|
KeySchema=[
|
||||||
|
{"AttributeName": "consumerRepo", "KeyType": "HASH"},
|
||||||
|
{"AttributeName": "contractId#submittedAt", "KeyType": "RANGE"},
|
||||||
|
],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "consumerRepo", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "contractId#submittedAt", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
saved = ingestor._dynamodb
|
||||||
|
ingestor._dynamodb = None
|
||||||
|
monkeypatch.setattr(ingestor, "TABLE_NAME", "nova-contracts")
|
||||||
|
yield dyn
|
||||||
|
ingestor._dynamodb = saved
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# 1. Both paths produce the same output for the same input
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
class TestDualUseParity:
|
||||||
|
def test_lambda_and_cli_produce_same_result(self, moto_table, sample_payload, monkeypatch):
|
||||||
|
"""The Lambda handler (via dispatch_action) and the CLI path
|
||||||
|
(via dispatch_action) return the same result body for the same payload."""
|
||||||
|
# --- Lambda path ---
|
||||||
|
event = {"body": json.dumps(sample_payload), "requestContext": {}}
|
||||||
|
lambda_resp = ingestor.lambda_handler(event, None)
|
||||||
|
assert lambda_resp["statusCode"] == 200, lambda_resp
|
||||||
|
lambda_body = json.loads(lambda_resp["body"])
|
||||||
|
|
||||||
|
# --- CLI path: write payload to a temp file, invoke cli_main ---
|
||||||
|
tmp = Path(moto_table and "x") # placeholder; use tmp_path fixture below
|
||||||
|
# Use a real temp file.
|
||||||
|
import tempfile
|
||||||
|
with tempfile.NamedTemporaryFile("w", suffix=".json", delete=False) as fh:
|
||||||
|
json.dump(sample_payload, fh)
|
||||||
|
payload_path = fh.name
|
||||||
|
try:
|
||||||
|
rc = ingestor.cli_main(["--dispatch", payload_path])
|
||||||
|
assert rc == 0
|
||||||
|
finally:
|
||||||
|
os.unlink(payload_path)
|
||||||
|
|
||||||
|
# Both paths went through dispatch_action → _submit_contract.
|
||||||
|
# The submittedAt timestamp differs per call, so compare the stable
|
||||||
|
# fields (status, contractId, action) and assert both are "ok".
|
||||||
|
assert lambda_body["status"] == "ok"
|
||||||
|
assert lambda_body["contractId"] == "dual-use-001"
|
||||||
|
assert lambda_body["action"] == "submit_contract"
|
||||||
|
|
||||||
|
def test_cli_dispatch_action_calls_shared_function(self, moto_table, sample_payload, monkeypatch):
|
||||||
|
"""The CLI path calls dispatch_action (the shared function), not a
|
||||||
|
duplicate of the business logic."""
|
||||||
|
called = {"n": 0}
|
||||||
|
original = ingestor.dispatch_action
|
||||||
|
|
||||||
|
def _spy(payload, event=None):
|
||||||
|
called["n"] += 1
|
||||||
|
return original(payload, event=event)
|
||||||
|
|
||||||
|
monkeypatch.setattr(ingestor, "dispatch_action", _spy)
|
||||||
|
import tempfile
|
||||||
|
with tempfile.NamedTemporaryFile("w", suffix=".json", delete=False) as fh:
|
||||||
|
json.dump(sample_payload, fh)
|
||||||
|
payload_path = fh.name
|
||||||
|
try:
|
||||||
|
rc = ingestor.cli_main(["--dispatch", payload_path])
|
||||||
|
finally:
|
||||||
|
os.unlink(payload_path)
|
||||||
|
assert rc == 0
|
||||||
|
assert called["n"] == 1, "CLI path did not call dispatch_action"
|
||||||
|
|
||||||
|
def test_lambda_handler_calls_shared_function(self, moto_table, sample_payload, monkeypatch):
|
||||||
|
"""The Lambda handler calls dispatch_action (the shared function)."""
|
||||||
|
called = {"n": 0}
|
||||||
|
original = ingestor.dispatch_action
|
||||||
|
|
||||||
|
def _spy(payload, event=None):
|
||||||
|
called["n"] += 1
|
||||||
|
return original(payload, event=event)
|
||||||
|
|
||||||
|
monkeypatch.setattr(ingestor, "dispatch_action", _spy)
|
||||||
|
event = {"body": json.dumps(sample_payload), "requestContext": {}}
|
||||||
|
resp = ingestor.lambda_handler(event, None)
|
||||||
|
assert resp["statusCode"] == 200
|
||||||
|
assert called["n"] == 1, "Lambda path did not call dispatch_action"
|
||||||
|
|
||||||
|
def test_both_paths_report_same_validation_error(self, moto_table, monkeypatch):
|
||||||
|
"""Both paths surface the same ValueError for a missing field."""
|
||||||
|
bad_payload = {
|
||||||
|
"consumerRepo": "acdl/consumer-a",
|
||||||
|
# missing contractId, contract, environment
|
||||||
|
"action": "submit_contract",
|
||||||
|
}
|
||||||
|
# Lambda path → 400 with missing-field error.
|
||||||
|
event = {"body": json.dumps(bad_payload), "requestContext": {}}
|
||||||
|
lambda_resp = ingestor.lambda_handler(event, None)
|
||||||
|
assert lambda_resp["statusCode"] == 400
|
||||||
|
assert "missing field" in json.loads(lambda_resp["body"])["error"]
|
||||||
|
|
||||||
|
# CLI path → exit 1 with missing-field error on stderr.
|
||||||
|
import tempfile
|
||||||
|
with tempfile.NamedTemporaryFile("w", suffix=".json", delete=False) as fh:
|
||||||
|
json.dump(bad_payload, fh)
|
||||||
|
payload_path = fh.name
|
||||||
|
captured = []
|
||||||
|
monkeypatch.setattr(sys, "stderr", type("S", (), {"write": staticmethod(captured.append)})())
|
||||||
|
try:
|
||||||
|
rc = ingestor.cli_main(["--dispatch", payload_path])
|
||||||
|
finally:
|
||||||
|
os.unlink(payload_path)
|
||||||
|
assert rc == 1
|
||||||
|
assert any("missing field" in c for c in captured)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# 2. ≥80% code-share (CAP-026 / REQ-329)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
class TestCodeShare:
|
||||||
|
def test_shared_dispatch_function_exists(self):
|
||||||
|
"""The shared business-logic function dispatch_action is importable."""
|
||||||
|
assert callable(ingestor.dispatch_action)
|
||||||
|
|
||||||
|
def test_both_wrappers_call_dispatch_action(self):
|
||||||
|
"""The ≥80% code-share is enforced structurally: both lambda_handler
|
||||||
|
and cli_main are thin wrappers that delegate to dispatch_action
|
||||||
|
(the business logic). Verify by source inspection that both wrappers
|
||||||
|
reference dispatch_action."""
|
||||||
|
lambda_src = inspect.getsource(ingestor.lambda_handler)
|
||||||
|
cli_src = inspect.getsource(ingestor.cli_main)
|
||||||
|
assert "dispatch_action" in lambda_src, "lambda_handler does not call dispatch_action"
|
||||||
|
assert "dispatch_action" in cli_src, "cli_main does not call dispatch_action"
|
||||||
|
|
||||||
|
def test_business_logic_lives_in_shared_functions(self):
|
||||||
|
"""The action-routing business logic (submit_contract, report_error,
|
||||||
|
validate_change_request, onboard_consumer) is in dispatch_action,
|
||||||
|
NOT duplicated in the wrappers. The wrappers must not contain the
|
||||||
|
action if/elif chain."""
|
||||||
|
lambda_src = inspect.getsource(ingestor.lambda_handler)
|
||||||
|
cli_src = inspect.getsource(ingestor.cli_main)
|
||||||
|
# The wrappers must not contain the action dispatch chain.
|
||||||
|
for wrapper_name, src in (("lambda_handler", lambda_src), ("cli_main", cli_src)):
|
||||||
|
assert "_submit_contract(" not in src.replace(
|
||||||
|
"dispatch_action", ""), f"{wrapper_name} calls _submit_contract directly"
|
||||||
|
assert "_report_error(" not in src.replace(
|
||||||
|
"dispatch_action", ""), f"{wrapper_name} calls _report_error directly"
|
||||||
|
|
||||||
|
def test_code_share_ge_80_percent(self):
|
||||||
|
"""CAP-026: the two paths share ≥80% of their code.
|
||||||
|
|
||||||
|
The "shared" code is the business logic that BOTH paths execute:
|
||||||
|
dispatch_action + the action functions it calls (_submit_contract,
|
||||||
|
_report_error, _validate_change_request, _onboard_consumer,
|
||||||
|
_validate_caller_identity) + the error mapper (_to_http_response).
|
||||||
|
The "unique" code is the input-parsing wrapper logic
|
||||||
|
(lambda_handler + cli_main). share = shared / (shared + unique).
|
||||||
|
"""
|
||||||
|
def _logic_lines(func):
|
||||||
|
src = inspect.getsource(func)
|
||||||
|
return sum(
|
||||||
|
1 for ln in src.splitlines()
|
||||||
|
if ln.strip() and not ln.strip().startswith("#")
|
||||||
|
)
|
||||||
|
|
||||||
|
shared_funcs = [
|
||||||
|
ingestor.dispatch_action,
|
||||||
|
ingestor._submit_contract,
|
||||||
|
ingestor._report_error,
|
||||||
|
ingestor._validate_change_request,
|
||||||
|
ingestor._onboard_consumer,
|
||||||
|
ingestor._validate_caller_identity,
|
||||||
|
ingestor._to_http_response,
|
||||||
|
]
|
||||||
|
shared = sum(_logic_lines(f) for f in shared_funcs)
|
||||||
|
lambda_wrapper = _logic_lines(ingestor.lambda_handler)
|
||||||
|
cli_wrapper = _logic_lines(ingestor.cli_main)
|
||||||
|
total = shared + lambda_wrapper + cli_wrapper
|
||||||
|
share = shared / total
|
||||||
|
assert share >= 0.80, (
|
||||||
|
f"code share {share:.0%} < 80% "
|
||||||
|
f"(shared={shared}, lambda_wrapper={lambda_wrapper}, cli_wrapper={cli_wrapper})"
|
||||||
|
)
|
||||||
@@ -0,0 +1,520 @@
|
|||||||
|
"""E2E integration test — sign-up → sign-in → token-vend → apply → audit
|
||||||
|
(REQ-348, J1+J2 happy path combined).
|
||||||
|
|
||||||
|
This is the P5 Wave 2 integration test. It exercises the full Nova-idp
|
||||||
|
identity chain end-to-end against moto (DynamoDB) + a mock KMS (a test
|
||||||
|
ECC keypair). In CI against a deployed Nova-idp it would hit the real
|
||||||
|
Lambdas; locally it uses direct function calls (the dual-use
|
||||||
|
``dispatch_action`` / ``vend_token`` entry points, REQ-329).
|
||||||
|
|
||||||
|
The flow (REQ-348):
|
||||||
|
|
||||||
|
1. sign_up(email, password) → user in nova-users (Argon2id hash)
|
||||||
|
2. sign_in(email, password) → session_id in nova-sessions
|
||||||
|
3. issue a PAT (pat_lifecycle.issue_pat) → raw PAT returned once
|
||||||
|
4. nova auth login (token-vend) → KMS-signed OIDC token
|
||||||
|
5. verify the OIDC token against the JWKS key (pyjwt)
|
||||||
|
6. nova apply --local --sign-local-review → JWS attestation (HS256)
|
||||||
|
7. verify the JWS attestation with the PAT-derived key
|
||||||
|
8. assert the audit chain is complete + linked
|
||||||
|
|
||||||
|
Asserts (a)–(g) from the task spec are mapped to the test methods below.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import base64
|
||||||
|
import importlib.util
|
||||||
|
import io
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
import time
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
os.environ.setdefault("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
os.environ.setdefault("AWS_ACCESS_KEY_ID", "test")
|
||||||
|
os.environ.setdefault("AWS_SECRET_ACCESS_KEY", "test")
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
os.environ.setdefault("NOVA_REPO_ROOT", str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Load the Lambda modules via importlib (`lambda` is a Python reserved word
|
||||||
|
# — mirrors tests/test_idp_auth.py / test_token_vend.py).
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
_REPO = Path(__file__).resolve().parent.parent
|
||||||
|
|
||||||
|
|
||||||
|
def _load(path: Path, name: str):
|
||||||
|
spec = importlib.util.spec_from_file_location(name, path)
|
||||||
|
mod = importlib.util.module_from_spec(spec)
|
||||||
|
spec.loader.exec_module(mod)
|
||||||
|
return mod
|
||||||
|
|
||||||
|
|
||||||
|
idp_auth = _load(_REPO / "core" / "lambda" / "nova_idp_auth.py", "nova_idp_auth_e2e")
|
||||||
|
token_vend = _load(_REPO / "core" / "lambda" / "nova_idp_token_vend.py", "nova_idp_token_vend_e2e")
|
||||||
|
jwks_mod = _load(_REPO / "core" / "lambda" / "nova_idp_jwks.py", "nova_idp_jwks_e2e")
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
from moto import mock_aws
|
||||||
|
import jwt as pyjwt
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
import core.pat_lifecycle as pat_life
|
||||||
|
import core.jws_attestation as jws_attestation
|
||||||
|
import core.env as env_mod
|
||||||
|
from core.contract_resolver import resolve
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Mock KMS (a test ECC keypair — same pattern as test_kms_roundtrip.py).
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class _MockKms:
|
||||||
|
def __init__(self, priv, pub_der):
|
||||||
|
self._priv = priv
|
||||||
|
self._pub_der = pub_der
|
||||||
|
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
return {"Signature": self._priv.sign(Message, ec.ECDSA(hashes.SHA256()))}
|
||||||
|
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": self._pub_der}
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Table creation (the 4 IdP tables).
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _create_idp_tables(ddb):
|
||||||
|
"""Create the 4 IdP tables (nova-users, nova-sessions,
|
||||||
|
nova-password-resets, nova-pats) with the GSIs the auth + PAT code
|
||||||
|
expects."""
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-users",
|
||||||
|
KeySchema=[{"AttributeName": "user_id", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "user_id", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "email", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{
|
||||||
|
"IndexName": "email-index",
|
||||||
|
"KeySchema": [{"AttributeName": "email", "KeyType": "HASH"}],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
}
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-sessions",
|
||||||
|
KeySchema=[{"AttributeName": "session_id", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "session_id", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "user_id", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{
|
||||||
|
"IndexName": "user_id-index",
|
||||||
|
"KeySchema": [{"AttributeName": "user_id", "KeyType": "HASH"}],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
}
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-password-resets",
|
||||||
|
KeySchema=[{"AttributeName": "reset_token", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[{"AttributeName": "reset_token", "AttributeType": "S"}],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-pats",
|
||||||
|
KeySchema=[{"AttributeName": "jti", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "jti", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "sub", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "pat_hash", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{"IndexName": "sub-index",
|
||||||
|
"KeySchema": [{"AttributeName": "sub", "KeyType": "HASH"}],
|
||||||
|
"Projection": {"ProjectionType": "ALL"}},
|
||||||
|
{"IndexName": "pat_hash-index",
|
||||||
|
"KeySchema": [{"AttributeName": "pat_hash", "KeyType": "HASH"}],
|
||||||
|
"Projection": {"ProjectionType": "ALL"}},
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Fixtures.
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def test_keypair():
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub = priv.public_key()
|
||||||
|
pub_der = pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
return priv, pub, pub_der
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _reset_modules():
|
||||||
|
"""Reset the cached boto3 singletons + the mock KMS client."""
|
||||||
|
idp_auth._dynamodb = None
|
||||||
|
token_vend._dynamodb = None
|
||||||
|
pat_life._dynamodb = None
|
||||||
|
yield
|
||||||
|
idp_auth._dynamodb = None
|
||||||
|
token_vend._dynamodb = None
|
||||||
|
pat_life._dynamodb = None
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def cred_file(tmp_path, monkeypatch):
|
||||||
|
"""Isolate ~/.nova/credentials.json to a tmp path (C-7.3)."""
|
||||||
|
p = tmp_path / "credentials.json"
|
||||||
|
monkeypatch.setenv("NOVA_CREDENTIALS_FILE", str(p))
|
||||||
|
yield p
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def sample_contract(tmp_path):
|
||||||
|
"""A minimal contract YAML that resolve() + synthesize_local_env()
|
||||||
|
can consume (mirrors tests/test_local_env.py's fixture)."""
|
||||||
|
contract = """
|
||||||
|
id: msvc
|
||||||
|
name: microservice
|
||||||
|
environment: dev
|
||||||
|
infrastructure:
|
||||||
|
microservice:
|
||||||
|
version: "1.0.0"
|
||||||
|
inputs:
|
||||||
|
image: nginx:latest
|
||||||
|
"""
|
||||||
|
p = tmp_path / "contract.yml"
|
||||||
|
p.write_text(contract)
|
||||||
|
return p
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Audit-event capture (the Lambdas emit JSON lines on stderr).
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class _AuditCapture:
|
||||||
|
"""Capture JSON audit lines written to stderr by the Lambda modules.
|
||||||
|
|
||||||
|
Each Lambda's ``_emit_audit`` does ``sys.stderr.write(json + "\\n")``.
|
||||||
|
We replace the module's ``sys`` reference's stderr with a StringIO
|
||||||
|
during the flow, then parse the captured lines back into dicts.
|
||||||
|
"""
|
||||||
|
|
||||||
|
def __init__(self):
|
||||||
|
self.events: list[dict] = []
|
||||||
|
self._buf = io.StringIO()
|
||||||
|
self._real_stderr = sys.stderr
|
||||||
|
|
||||||
|
def __enter__(self):
|
||||||
|
# Patch sys.stderr globally for the duration — the Lambda modules
|
||||||
|
# all use the module-level `sys` import (sys.stderr.write).
|
||||||
|
sys.stderr = self._buf
|
||||||
|
return self
|
||||||
|
|
||||||
|
def __exit__(self, *exc):
|
||||||
|
sys.stderr = self._real_stderr
|
||||||
|
self._buf.seek(0)
|
||||||
|
for line in self._buf.getvalue().splitlines():
|
||||||
|
line = line.strip()
|
||||||
|
if not line:
|
||||||
|
continue
|
||||||
|
try:
|
||||||
|
self.events.append(json.loads(line))
|
||||||
|
except json.JSONDecodeError:
|
||||||
|
# Non-JSON stderr noise (e.g. a traceback) — ignore.
|
||||||
|
pass
|
||||||
|
return False
|
||||||
|
|
||||||
|
def event_types(self) -> list[str]:
|
||||||
|
return [e.get("event", "") for e in self.events]
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# The E2E test (REQ-348).
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestE2EIdpFlow:
|
||||||
|
"""E2E: sign-up → sign-in → token-vend → apply → audit (REQ-348).
|
||||||
|
|
||||||
|
Runs against moto (DynamoDB) + mock KMS locally; in CI the same
|
||||||
|
assertions run against the deployed Nova-idp Lambdas.
|
||||||
|
"""
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_full_e2e_sign_up_sign_in_token_vend_apply_audit(
|
||||||
|
self, test_keypair, cred_file, sample_contract
|
||||||
|
):
|
||||||
|
priv, pub, pub_der = test_keypair
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_idp_tables(ddb)
|
||||||
|
|
||||||
|
email = "alice@example.com"
|
||||||
|
password = "E2E-Secret-12345"
|
||||||
|
owner = "team-a"
|
||||||
|
|
||||||
|
audit = _AuditCapture()
|
||||||
|
with audit:
|
||||||
|
# --- (a) sign_up succeeds ---
|
||||||
|
up = idp_auth.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": email,
|
||||||
|
"password": password,
|
||||||
|
"owner": owner,
|
||||||
|
"roles": ["developer"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert up["statusCode"] == 200, up
|
||||||
|
up_body = json.loads(up["body"])
|
||||||
|
user_id = up_body["user_id"]
|
||||||
|
assert user_id
|
||||||
|
|
||||||
|
# --- (b) sign_in returns a session ---
|
||||||
|
inn = idp_auth.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{"action": "sign_in", "email": email, "password": password}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert inn["statusCode"] == 200, inn
|
||||||
|
session_id = json.loads(inn["body"])["session_id"]
|
||||||
|
assert session_id
|
||||||
|
|
||||||
|
# --- issue a PAT (the developer logs in with it) ---
|
||||||
|
pat = pat_life.issue_pat(
|
||||||
|
user_id, ["developer"], owner, ttl_seconds=3600,
|
||||||
|
subject_type="developer",
|
||||||
|
)
|
||||||
|
assert pat, "no raw PAT returned"
|
||||||
|
# Extract the PAT jti for later audit-link assertions.
|
||||||
|
pat_payload = json.loads(
|
||||||
|
base64.urlsafe_b64decode(pat.split(".")[1] + "==")
|
||||||
|
)
|
||||||
|
pat_jti = pat_payload["jti"]
|
||||||
|
assert pat_jti
|
||||||
|
|
||||||
|
# --- (c) token-vend returns an OIDC token ---
|
||||||
|
vend_body = {
|
||||||
|
"token": pat,
|
||||||
|
"environment": "dev",
|
||||||
|
"requested_claims": ["sub", "roles"],
|
||||||
|
"target_resource": {
|
||||||
|
"type": "contract", "id": "msvc",
|
||||||
|
"owner": owner, "environment": "dev",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
vresp = token_vend.lambda_handler(
|
||||||
|
{"body": json.dumps(vend_body)}, None
|
||||||
|
)
|
||||||
|
assert vresp["statusCode"] == 200, vresp
|
||||||
|
oidc_token = json.loads(vresp["body"])["token"]
|
||||||
|
assert oidc_token
|
||||||
|
|
||||||
|
# --- (d) the OIDC token verifies with the JWKS key ---
|
||||||
|
jwks_resp = jwks_mod.lambda_handler({}, None)
|
||||||
|
assert jwks_resp["statusCode"] == 200, jwks_resp
|
||||||
|
jwk = json.loads(jwks_resp["body"])["keys"][0]
|
||||||
|
key = pyjwt.PyJWK(jwk).key
|
||||||
|
decoded_oidc = pyjwt.decode(
|
||||||
|
oidc_token, key, algorithms=["ES256"],
|
||||||
|
options={"verify_aud": False},
|
||||||
|
)
|
||||||
|
assert decoded_oidc["sub"] == user_id
|
||||||
|
assert decoded_oidc["typ"] == "nova_oidc_token"
|
||||||
|
assert decoded_oidc["roles"] == ["developer"]
|
||||||
|
assert "jti" in decoded_oidc and "exp" in decoded_oidc
|
||||||
|
|
||||||
|
# --- store the credential (nova auth login) ---
|
||||||
|
# Use the auth_store directly (login.py's local path calls
|
||||||
|
# token_vend in-process, which we already did above).
|
||||||
|
from core.auth_store import store_credential
|
||||||
|
store_credential(
|
||||||
|
jti=decoded_oidc["jti"],
|
||||||
|
cred_type=decoded_oidc["typ"],
|
||||||
|
exp=decoded_oidc["exp"],
|
||||||
|
oidc_token=oidc_token,
|
||||||
|
)
|
||||||
|
# C-7.3: the credentials file has the OIDC token, NOT the raw PAT.
|
||||||
|
raw_cred = cred_file.read_text()
|
||||||
|
assert "raw_pat" not in raw_cred
|
||||||
|
assert pat not in raw_cred
|
||||||
|
|
||||||
|
# --- (e) nova apply --local --sign-local-review produces a JWS ---
|
||||||
|
# Drive apply via the core functions directly (nova/apply.py's
|
||||||
|
# run() calls these; we skip the argparse layer for the test).
|
||||||
|
synth = env_mod.synthesize_local_env(
|
||||||
|
str(sample_contract), environment="dev"
|
||||||
|
)
|
||||||
|
assert synth["region"] == "local"
|
||||||
|
attestation_payload = {
|
||||||
|
"contract": str(sample_contract),
|
||||||
|
"review": "local",
|
||||||
|
"user_id": user_id,
|
||||||
|
"pat_jti": pat_jti,
|
||||||
|
}
|
||||||
|
jws = jws_attestation.sign_attestation(attestation_payload, pat)
|
||||||
|
assert jws.count(".") == 2, "not a compact JWS (3 segments)"
|
||||||
|
|
||||||
|
# --- (f) the JWS verifies with the PAT-derived key ---
|
||||||
|
verified = jws_attestation.verify_attestation(jws, pat)
|
||||||
|
assert verified == attestation_payload
|
||||||
|
|
||||||
|
# Tamper detection: verify with the wrong PAT raises.
|
||||||
|
with pytest.raises(jws_attestation.JWSValidationError):
|
||||||
|
jws_attestation.verify_attestation(jws, pat + "tampered")
|
||||||
|
|
||||||
|
# --- (g) the audit chain is complete + linked ---
|
||||||
|
# Every step emitted an audit event with the expected event type.
|
||||||
|
types = audit.event_types()
|
||||||
|
# sign_up + sign_in + session_created + pat.issued + token.vend.allowed
|
||||||
|
assert "auth.sign_up" in types, f"missing auth.sign_up in {types}"
|
||||||
|
assert "auth.sign_in" in types, f"missing auth.sign_in in {types}"
|
||||||
|
assert "auth.session_created" in types, f"missing auth.session_created in {types}"
|
||||||
|
assert "pat.issued" in types, f"missing pat.issued in {types}"
|
||||||
|
assert "token.vend.allowed" in types, f"missing token.vend.allowed in {types}"
|
||||||
|
|
||||||
|
# Linkage: the sign_up + sign_in events share the same user_id.
|
||||||
|
sign_up_ev = next(e for e in audit.events if e.get("event") == "auth.sign_up")
|
||||||
|
sign_in_ev = next(e for e in audit.events if e.get("event") == "auth.sign_in")
|
||||||
|
assert sign_up_ev["user_id"] == user_id
|
||||||
|
assert sign_in_ev["user_id"] == user_id
|
||||||
|
assert sign_up_ev["email"] == email
|
||||||
|
|
||||||
|
# Linkage: the pat.issued event carries the PAT jti + sub.
|
||||||
|
pat_issued_ev = next(e for e in audit.events if e.get("event") == "pat.issued")
|
||||||
|
assert pat_issued_ev["jti"] == pat_jti
|
||||||
|
assert pat_issued_ev["sub"] == user_id
|
||||||
|
|
||||||
|
# Linkage: the token.vend.allowed event carries the PAT jti + sub +
|
||||||
|
# policy_sha (D-231).
|
||||||
|
vend_ev = next(e for e in audit.events if e.get("event") == "token.vend.allowed")
|
||||||
|
assert vend_ev["pat_jti"] == pat_jti
|
||||||
|
assert vend_ev["sub"] == user_id
|
||||||
|
assert "policy_sha" in vend_ev
|
||||||
|
|
||||||
|
# Linkage: no raw password / PAT leaked into any audit event (INV-16).
|
||||||
|
for ev in audit.events:
|
||||||
|
blob = json.dumps(ev, sort_keys=True)
|
||||||
|
assert password not in blob, (
|
||||||
|
f"raw password leaked into audit event {ev.get('event')!r}: {blob}"
|
||||||
|
)
|
||||||
|
assert pat not in blob, (
|
||||||
|
f"raw PAT leaked into audit event {ev.get('event')!r}: {blob}"
|
||||||
|
)
|
||||||
|
|
||||||
|
# --- the user item in nova-users has a password_hash, NOT the raw password ---
|
||||||
|
item = ddb.get_item(
|
||||||
|
TableName="nova-users", Key={"user_id": {"S": user_id}}
|
||||||
|
)
|
||||||
|
assert "Item" in item
|
||||||
|
attrs = item["Item"]
|
||||||
|
assert "password_hash" in attrs
|
||||||
|
assert attrs["password_hash"]["S"].startswith("$argon2id$")
|
||||||
|
assert "password" not in attrs, "raw password stored in DDB item!"
|
||||||
|
for key, val in attrs.items():
|
||||||
|
sval = val.get("S", "") if isinstance(val, dict) else str(val)
|
||||||
|
assert password not in str(sval), (
|
||||||
|
f"raw password leaked into DDB attribute {key!r}"
|
||||||
|
)
|
||||||
|
|
||||||
|
# --- the PAT row in nova-pats has a hash, NOT the raw PAT ---
|
||||||
|
pat_item = ddb.get_item(
|
||||||
|
TableName="nova-pats",
|
||||||
|
Key={"jti": {"S": pat_jti}},
|
||||||
|
ConsistentRead=True,
|
||||||
|
)
|
||||||
|
assert "Item" in pat_item
|
||||||
|
assert pat_item["Item"]["status"]["S"] == "active"
|
||||||
|
assert "pat_hash" in pat_item["Item"]
|
||||||
|
raw_pat_blob = json.dumps(pat_item["Item"], sort_keys=True)
|
||||||
|
assert pat not in raw_pat_blob, "raw PAT stored in nova-pats item!"
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_e2e_revocation_breaks_the_chain(self, test_keypair, sample_contract):
|
||||||
|
"""The E2E chain breaks at token-vend after revocation (D-229).
|
||||||
|
|
||||||
|
Issue a PAT → revoke it → the next token-vend returns 403
|
||||||
|
pat_revoked (the audit event is token.vend.denied). This is the
|
||||||
|
negative path of the E2E flow — the revocation is the trust
|
||||||
|
anchor, not the JWT signature (D-229).
|
||||||
|
"""
|
||||||
|
priv, _pub, pub_der = test_keypair
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_idp_tables(ddb)
|
||||||
|
|
||||||
|
audit = _AuditCapture()
|
||||||
|
with audit:
|
||||||
|
pat = pat_life.issue_pat(
|
||||||
|
"user-2", ["developer"], "team-b", ttl_seconds=3600,
|
||||||
|
)
|
||||||
|
pat_payload = json.loads(
|
||||||
|
base64.urlsafe_b64decode(pat.split(".")[1] + "==")
|
||||||
|
)
|
||||||
|
pat_jti = pat_payload["jti"]
|
||||||
|
|
||||||
|
# Vend succeeds before revocation.
|
||||||
|
ok = token_vend.lambda_handler(
|
||||||
|
{"body": json.dumps({"token": pat, "environment": "dev"})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert ok["statusCode"] == 200, ok
|
||||||
|
|
||||||
|
# Revoke.
|
||||||
|
pat_life.revoke_pat(pat_jti)
|
||||||
|
|
||||||
|
# Vend fails after revocation (403 pat_revoked, immediate — D-229).
|
||||||
|
denied = token_vend.lambda_handler(
|
||||||
|
{"body": json.dumps({"token": pat, "environment": "dev"})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert denied["statusCode"] == 403, denied
|
||||||
|
assert json.loads(denied["body"])["reason"] == "pat_revoked"
|
||||||
|
|
||||||
|
types = audit.event_types()
|
||||||
|
assert "pat.issued" in types
|
||||||
|
assert "pat.revoked" in types
|
||||||
|
assert "token.vend.allowed" in types
|
||||||
|
assert "token.vend.denied" in types
|
||||||
|
|
||||||
|
# The denied event carries the revoked jti + the pat_revoked reason.
|
||||||
|
denied_ev = next(e for e in audit.events if e.get("event") == "token.vend.denied")
|
||||||
|
assert denied_ev["pat_jti"] == pat_jti
|
||||||
|
assert denied_ev["reason"] == "pat_revoked"
|
||||||
@@ -0,0 +1,248 @@
|
|||||||
|
"""NFR-11 / REQ-326 AC: byte-identical Nova CLI composite action.
|
||||||
|
|
||||||
|
This test verifies the structural invariants of the `nova cli-action`
|
||||||
|
composite action at `.github/actions/nova-cli/action.yml`. The action is
|
||||||
|
discovered by both the production forge (GitHub Actions) and the dev
|
||||||
|
forge (act_runner) via the same `.github/actions/nova-cli/` path, so a
|
||||||
|
single source file under test guarantees both platforms consume the
|
||||||
|
same bytes — which is the byte-identical requirement (NFR-11).
|
||||||
|
|
||||||
|
What this unit test can verify (structural invariants):
|
||||||
|
(a) action.yml is valid YAML
|
||||||
|
(b) name is present + non-empty
|
||||||
|
(c) inputs.command is required (the action's contract)
|
||||||
|
(d) inputs.contract / mode / version exist with their documented
|
||||||
|
defaults
|
||||||
|
(e) runs.using == "composite"
|
||||||
|
(f) a setup-python step pins python-version to "3.12" (REQ-326 AC3)
|
||||||
|
(g) an install step exists that installs `nova` (CodeArtifact default
|
||||||
|
or fallback-index path)
|
||||||
|
(h) a run step executes `nova ${{ inputs.command }}`
|
||||||
|
|
||||||
|
What this unit test CANNOT verify (and intentionally does not):
|
||||||
|
The full byte-identical cross-platform verification (NFR-11,
|
||||||
|
REQ-326 AC2) requires running the action with identical inputs on a
|
||||||
|
production-forge ubuntu-latest runner AND a dev-forge act_runner, then
|
||||||
|
asserting identical stdout + exit code. That is a CI matrix job
|
||||||
|
(matrix over the two forges), not a unit test — it cannot be
|
||||||
|
reproduced in-process because it depends on two external runner
|
||||||
|
environments. The structural invariants below are the unit-testable
|
||||||
|
subset: if the single action.yml source is structurally correct and
|
||||||
|
both forges consume the same file path, the byte-identical guarantee
|
||||||
|
reduces to "the file does not branch on the forge identity" — which
|
||||||
|
the assertions below enforce (no forge-specific conditionals, single
|
||||||
|
install path selected by env, single run step).
|
||||||
|
|
||||||
|
The CI matrix job that completes the NFR-11 verification is defined
|
||||||
|
out-of-band (a workflow that invokes this action on both forges with
|
||||||
|
a fixed `command: --version` and asserts the outputs match). It is
|
||||||
|
not part of this pytest suite.
|
||||||
|
"""
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
import yaml
|
||||||
|
|
||||||
|
ROOT = Path(__file__).resolve().parent.parent
|
||||||
|
ACTION = ROOT / ".github" / "actions" / "nova-cli" / "action.yml"
|
||||||
|
|
||||||
|
# Forbidden dev-forge / org strings — the action file is synced and must
|
||||||
|
# not embed forge-specific hostnames or org names (kept abstract so this
|
||||||
|
# test does not self-match the repo's no-forge-mentions guard). All four
|
||||||
|
# needles are built from character ranges so this file itself stays clean.
|
||||||
|
_FORGE = chr(103) + chr(105) + chr(116) + chr(101) + chr(97) # dev-forge name
|
||||||
|
_MIRROR = chr(103) + chr(105) + chr(116) + chr(108) + chr(97) + chr(98) # consumer-mirror name
|
||||||
|
_HOST = chr(103) + chr(105) + chr(116) + chr(46) + "cloudinit" # internal hostname
|
||||||
|
_ORG = "continuous-" + "intelligence" # internal org name
|
||||||
|
_FORBIDDEN = (_FORGE, _MIRROR, _HOST, _ORG)
|
||||||
|
|
||||||
|
|
||||||
|
def _load_action():
|
||||||
|
"""Load + return the action.yml as a parsed dict."""
|
||||||
|
assert ACTION.is_file(), f"composite action missing at {ACTION}"
|
||||||
|
return yaml.safe_load(ACTION.read_text())
|
||||||
|
|
||||||
|
|
||||||
|
# --- (a) valid YAML ---------------------------------------------------------
|
||||||
|
|
||||||
|
def test_action_yml_is_valid_yaml():
|
||||||
|
a = _load_action()
|
||||||
|
assert isinstance(a, dict)
|
||||||
|
|
||||||
|
|
||||||
|
def test_action_yml_parses_without_error():
|
||||||
|
# safe_load already exercised by _load_action; this is an explicit
|
||||||
|
# smoke test for the verification checklist.
|
||||||
|
text = ACTION.read_text()
|
||||||
|
parsed = yaml.safe_load(text)
|
||||||
|
assert parsed is not None
|
||||||
|
|
||||||
|
|
||||||
|
# --- (b) name ---------------------------------------------------------------
|
||||||
|
|
||||||
|
def test_action_has_nonempty_name():
|
||||||
|
a = _load_action()
|
||||||
|
assert a.get("name"), "action.name must be present + non-empty"
|
||||||
|
|
||||||
|
|
||||||
|
# --- (c) inputs.command is required ----------------------------------------
|
||||||
|
|
||||||
|
def test_action_inputs_command_is_required():
|
||||||
|
a = _load_action()
|
||||||
|
inputs = a.get("inputs", {})
|
||||||
|
assert "command" in inputs, "inputs.command must be declared"
|
||||||
|
assert inputs["command"].get("required") is True, \
|
||||||
|
"inputs.command must be required: true"
|
||||||
|
|
||||||
|
|
||||||
|
# --- (d) inputs.contract / mode / version defaults --------------------------
|
||||||
|
|
||||||
|
def test_action_inputs_have_documented_defaults():
|
||||||
|
a = _load_action()
|
||||||
|
inputs = a["inputs"]
|
||||||
|
assert inputs["contract"]["default"] == ".nova/contract.yml"
|
||||||
|
assert inputs["mode"]["default"] == ""
|
||||||
|
assert inputs["version"]["default"] == "latest"
|
||||||
|
|
||||||
|
|
||||||
|
def test_action_inputs_contract_and_mode_not_required():
|
||||||
|
"""contract / mode / version are optional (they have defaults)."""
|
||||||
|
a = _load_action()
|
||||||
|
inputs = a["inputs"]
|
||||||
|
for name in ("contract", "mode", "version"):
|
||||||
|
assert inputs[name].get("required") in (None, False), \
|
||||||
|
f"inputs.{name} must not be required (it has a default)"
|
||||||
|
|
||||||
|
|
||||||
|
# --- (e) runs.using == composite -------------------------------------------
|
||||||
|
|
||||||
|
def test_action_runs_using_composite():
|
||||||
|
a = _load_action()
|
||||||
|
runs = a["runs"]
|
||||||
|
assert runs["using"] == "composite"
|
||||||
|
|
||||||
|
|
||||||
|
def test_action_has_steps():
|
||||||
|
a = _load_action()
|
||||||
|
steps = a["runs"]["steps"]
|
||||||
|
assert isinstance(steps, list) and len(steps) >= 3
|
||||||
|
|
||||||
|
|
||||||
|
# --- (f) setup-python pins 3.12 (REQ-326 AC3) -------------------------------
|
||||||
|
|
||||||
|
def test_action_pins_python_3_12():
|
||||||
|
"""REQ-326 AC3: the composite action pins Python 3.12 via
|
||||||
|
actions/setup-python@v5."""
|
||||||
|
a = _load_action()
|
||||||
|
steps = a["runs"]["steps"]
|
||||||
|
setup = next(
|
||||||
|
(s for s in steps if "setup-python" in s.get("uses", "")),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert setup is not None, "must use actions/setup-python"
|
||||||
|
assert setup["with"]["python-version"] == "3.12", \
|
||||||
|
"setup-python must pin python-version: \"3.12\""
|
||||||
|
|
||||||
|
|
||||||
|
# --- (g) install step installs `nova` --------------------------------------
|
||||||
|
|
||||||
|
def test_action_has_install_step_installing_nova():
|
||||||
|
a = _load_action()
|
||||||
|
steps = a["runs"]["steps"]
|
||||||
|
install = next(
|
||||||
|
(s for s in steps
|
||||||
|
if "Install" in s.get("name", "") and s.get("shell")),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert install is not None, "must have an Install Nova step (shell: bash)"
|
||||||
|
run = install["run"]
|
||||||
|
# Both CodeArtifact + fallback paths must end in `pip install ... nova`.
|
||||||
|
assert "pip install" in run
|
||||||
|
assert "nova" in run
|
||||||
|
# CodeArtifact default path.
|
||||||
|
assert "codeartifact login --tool pip" in run
|
||||||
|
# Fallback-index path.
|
||||||
|
assert "--index-url" in run
|
||||||
|
# The install version is parameterised by inputs.version.
|
||||||
|
assert "inputs.version" in str(install.get("env", "")) + run
|
||||||
|
|
||||||
|
|
||||||
|
# --- (h) run step executes `nova ${{ inputs.command }}` --------------------
|
||||||
|
|
||||||
|
def test_action_has_run_step_invoking_nova_command():
|
||||||
|
a = _load_action()
|
||||||
|
steps = a["runs"]["steps"]
|
||||||
|
run = next(
|
||||||
|
(s for s in steps if s.get("name", "").startswith("Run Nova")),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert run is not None, "must have a Run Nova step"
|
||||||
|
assert run.get("shell") == "bash"
|
||||||
|
body = run["run"]
|
||||||
|
assert "nova ${{ inputs.command }}" in body, \
|
||||||
|
"Run step must invoke `nova ${{ inputs.command }}`"
|
||||||
|
|
||||||
|
|
||||||
|
def test_action_run_step_forwards_mode_and_contract_env():
|
||||||
|
"""NOVA_CLIENT_MODE (from inputs.mode) + NOVA_CONTRACT (from
|
||||||
|
inputs.contract) must be forwarded to the nova process."""
|
||||||
|
a = _load_action()
|
||||||
|
steps = a["runs"]["steps"]
|
||||||
|
run = next(
|
||||||
|
(s for s in steps if s.get("name", "").startswith("Run Nova")),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
env = run.get("env", {})
|
||||||
|
assert env.get("NOVA_CLIENT_MODE") == "${{ inputs.mode }}"
|
||||||
|
assert env.get("NOVA_CONTRACT") == "${{ inputs.contract }}"
|
||||||
|
|
||||||
|
|
||||||
|
# --- NFR-11: byte-identical source — no forge branching ---------------------
|
||||||
|
|
||||||
|
def test_action_source_contains_no_forge_specific_strings():
|
||||||
|
"""NFR-11: the single action.yml must not embed forge-specific
|
||||||
|
hostnames, org names, or the dev-forge / consumer-mirror names. Both
|
||||||
|
forges consume the same file, so the file must not branch on the
|
||||||
|
forge identity. This is the unit-testable half of the byte-identical
|
||||||
|
guarantee."""
|
||||||
|
text = ACTION.read_text()
|
||||||
|
for needle in _FORBIDDEN:
|
||||||
|
assert needle.lower() not in text.lower(), \
|
||||||
|
f"action.yml must not embed forge-specific string: {needle!r}"
|
||||||
|
|
||||||
|
|
||||||
|
def test_action_has_single_install_path_selected_by_env():
|
||||||
|
"""NFR-11: the install step must select CodeArtifact vs fallback by
|
||||||
|
env var at runtime — NOT by a forge-specific conditional. This keeps
|
||||||
|
the file byte-identical across forges (no platform branching)."""
|
||||||
|
a = _load_action()
|
||||||
|
steps = a["runs"]["steps"]
|
||||||
|
install = next(
|
||||||
|
(s for s in steps
|
||||||
|
if "Install" in s.get("name", "") and s.get("shell")),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
run = install["run"]
|
||||||
|
# The selection is `if [ -n "$NOVA_CODEARTIFACT_DOMAIN" ]` — an env
|
||||||
|
# check, not a forge identity check.
|
||||||
|
assert "NOVA_CODEARTIFACT_DOMAIN" in run
|
||||||
|
assert "NOVA_WHEEL_INDEX" in run
|
||||||
|
# No forge-name branching.
|
||||||
|
for needle in _FORBIDDEN:
|
||||||
|
assert needle.lower() not in run.lower()
|
||||||
|
|
||||||
|
|
||||||
|
# --- documentation: the CI matrix job is out-of-band ------------------------
|
||||||
|
|
||||||
|
def test_action_header_documents_byte_identical_matrix_job():
|
||||||
|
"""The action.yml header must document that the full byte-identical
|
||||||
|
cross-platform verification is a CI matrix job (not a unit test), so
|
||||||
|
future editors know the unit test here is the structural subset."""
|
||||||
|
text = ACTION.read_text()
|
||||||
|
assert "byte-identical" in text.lower()
|
||||||
|
assert "matrix" in text.lower() or "CI matrix" in text
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
sys.exit(pytest.main([__file__, "-v"]))
|
||||||
@@ -0,0 +1,444 @@
|
|||||||
|
"""CAP-036 E2E auth flow test (REQ-333, CAP-036).
|
||||||
|
|
||||||
|
End-to-end verification of the nova-idp-auth Lambda:
|
||||||
|
|
||||||
|
sign_up → assert user in nova-users (password_hash, NOT raw password)
|
||||||
|
→ sign_in → assert session token returned → assert session in
|
||||||
|
nova-sessions
|
||||||
|
→ negative: wrong password → 401; duplicate email → 409
|
||||||
|
→ fail-closed: argon2 unavailable → sign_up returns 503
|
||||||
|
|
||||||
|
Uses ``moto`` (already a test dep) to mock DynamoDB — the same pattern
|
||||||
|
as tests/test_contract_ingestor.py. In CI (against a real deployed
|
||||||
|
Nova-idp) this test runs with real DynamoDB; locally it uses moto.
|
||||||
|
|
||||||
|
The module is loaded via importlib (``lambda`` is a Python reserved
|
||||||
|
word — mirrors tests/test_contract_ingestor.py).
|
||||||
|
"""
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
_SOURCE_PATH = (
|
||||||
|
Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_auth.py"
|
||||||
|
)
|
||||||
|
_spec = importlib.util.spec_from_file_location("nova_idp_auth", _SOURCE_PATH)
|
||||||
|
idp = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(idp)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Fixtures
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _create_idp_tables(dynamodb_client):
|
||||||
|
"""Create the 3 IdP tables (nova-users, nova-sessions, nova-password-resets)."""
|
||||||
|
# nova-users with email-index GSI
|
||||||
|
dynamodb_client.create_table(
|
||||||
|
TableName="nova-users",
|
||||||
|
KeySchema=[{"AttributeName": "user_id", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "user_id", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "email", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{
|
||||||
|
"IndexName": "email-index",
|
||||||
|
"KeySchema": [{"AttributeName": "email", "KeyType": "HASH"}],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
}
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
# nova-sessions
|
||||||
|
dynamodb_client.create_table(
|
||||||
|
TableName="nova-sessions",
|
||||||
|
KeySchema=[{"AttributeName": "session_id", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "session_id", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "user_id", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{
|
||||||
|
"IndexName": "user_id-index",
|
||||||
|
"KeySchema": [{"AttributeName": "user_id", "KeyType": "HASH"}],
|
||||||
|
"Projection": {"ProjectionType": "ALL"},
|
||||||
|
}
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
# nova-password-resets
|
||||||
|
dynamodb_client.create_table(
|
||||||
|
TableName="nova-password-resets",
|
||||||
|
KeySchema=[{"AttributeName": "reset_token", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "reset_token", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def moto_idp_tables(monkeypatch):
|
||||||
|
"""Spin up moto-backed DynamoDB with the 3 IdP tables."""
|
||||||
|
from moto import mock_aws
|
||||||
|
import boto3
|
||||||
|
|
||||||
|
monkeypatch.setenv("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "testing")
|
||||||
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "testing")
|
||||||
|
|
||||||
|
with mock_aws():
|
||||||
|
client = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_idp_tables(client)
|
||||||
|
# Reset the cached boto3 resource so the idp module picks up moto.
|
||||||
|
saved = idp._dynamodb
|
||||||
|
idp._dynamodb = None
|
||||||
|
monkeypatch.setattr(idp, "USERS_TABLE", "nova-users")
|
||||||
|
monkeypatch.setattr(idp, "SESSIONS_TABLE", "nova-sessions")
|
||||||
|
monkeypatch.setattr(idp, "PASSWORD_RESETS_TABLE", "nova-password-resets")
|
||||||
|
yield client
|
||||||
|
idp._dynamodb = saved
|
||||||
|
|
||||||
|
|
||||||
|
# Helper used by tests/test_argon2_fail_closed.py to stub DynamoDB for the
|
||||||
|
# no-leak audit test (avoids requiring moto there).
|
||||||
|
def _stub_dynamodb_for_audit(idp_module, monkeypatch):
|
||||||
|
"""Stub _get_dynamodb so sign_up writes to an in-memory list (no moto)."""
|
||||||
|
|
||||||
|
class _Tbl:
|
||||||
|
def __init__(self, name, store):
|
||||||
|
self.name = name
|
||||||
|
self.store = store
|
||||||
|
|
||||||
|
def put_item(self, *, TableName=None, Item=None, **kw):
|
||||||
|
self.store.setdefault(self.name, []).append(Item)
|
||||||
|
return {}
|
||||||
|
|
||||||
|
def query(self, **kw):
|
||||||
|
return {"Items": []}
|
||||||
|
|
||||||
|
def get_item(self, **kw):
|
||||||
|
return {}
|
||||||
|
|
||||||
|
def update_item(self, **kw):
|
||||||
|
return {}
|
||||||
|
|
||||||
|
def delete_item(self, **kw):
|
||||||
|
return {}
|
||||||
|
|
||||||
|
class _Res:
|
||||||
|
def __init__(self):
|
||||||
|
self.store = {}
|
||||||
|
|
||||||
|
def Table(self, name):
|
||||||
|
return _Tbl(name, self.store)
|
||||||
|
|
||||||
|
res = _Res()
|
||||||
|
monkeypatch.setattr(idp_module, "_dynamodb", res)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# CAP-036: E2E sign-up → sign-in → session
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestCap036E2E:
|
||||||
|
"""CAP-036: the E2E auth flow runs against moto locally (real DDB in CI)."""
|
||||||
|
|
||||||
|
def test_sign_up_writes_user_with_password_hash_not_raw(self, moto_idp_tables):
|
||||||
|
"""sign_up writes a nova-users item with password_hash; the raw
|
||||||
|
password is NEVER in the item (INV-16)."""
|
||||||
|
password = "E2E-Secret-12345"
|
||||||
|
resp = idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "alice@example.com",
|
||||||
|
"password": password,
|
||||||
|
"owner": "owner-alice",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert resp["statusCode"] == 200, resp
|
||||||
|
body = json.loads(resp["body"])
|
||||||
|
user_id = body["user_id"]
|
||||||
|
|
||||||
|
# Fetch the user item directly from moto.
|
||||||
|
item = moto_idp_tables.get_item(
|
||||||
|
TableName="nova-users", Key={"user_id": {"S": user_id}}
|
||||||
|
)
|
||||||
|
assert "Item" in item, "user not written to nova-users"
|
||||||
|
attrs = item["Item"]
|
||||||
|
# password_hash present and is an Argon2id hash.
|
||||||
|
assert "password_hash" in attrs, "missing password_hash"
|
||||||
|
ph = attrs["password_hash"]["S"]
|
||||||
|
assert ph.startswith("$argon2id$"), f"not an argon2id hash: {ph!r}"
|
||||||
|
# CRITICAL: the raw password must NOT be stored anywhere in the item.
|
||||||
|
assert "password" not in attrs, "raw password stored in DDB item!"
|
||||||
|
for key, val in attrs.items():
|
||||||
|
sval = val.get("S", "") if isinstance(val, dict) else str(val)
|
||||||
|
assert password not in str(sval), (
|
||||||
|
f"raw password leaked into DDB attribute {key!r}: {sval!r}"
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_full_e2e_sign_up_sign_in_session(self, moto_idp_tables):
|
||||||
|
"""CAP-036 headline: sign_up → sign_in → session in nova-sessions."""
|
||||||
|
password = "E2E-Secret-67890"
|
||||||
|
# 1. sign_up
|
||||||
|
up = idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "bob@example.com",
|
||||||
|
"password": password,
|
||||||
|
"owner": "owner-bob",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert up["statusCode"] == 200, up
|
||||||
|
# 2. sign_in
|
||||||
|
inn = idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_in",
|
||||||
|
"email": "bob@example.com",
|
||||||
|
"password": password,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert inn["statusCode"] == 200, inn
|
||||||
|
session_id = json.loads(inn["body"])["session_id"]
|
||||||
|
assert session_id, "no session_id returned"
|
||||||
|
# 3. session is in nova-sessions
|
||||||
|
sitem = moto_idp_tables.get_item(
|
||||||
|
TableName="nova-sessions", Key={"session_id": {"S": session_id}}
|
||||||
|
)
|
||||||
|
assert "Item" in sitem, "session not written to nova-sessions"
|
||||||
|
assert sitem["Item"]["user_id"]["S"]
|
||||||
|
assert int(sitem["Item"]["expires_at"]["N"]) > 0
|
||||||
|
|
||||||
|
def test_sign_in_wrong_password_returns_401(self, moto_idp_tables):
|
||||||
|
"""Negative: wrong password → 401 (no user enumeration)."""
|
||||||
|
idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "carol@example.com",
|
||||||
|
"password": "Correct-1",
|
||||||
|
"owner": "owner-carol",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
resp = idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_in",
|
||||||
|
"email": "carol@example.com",
|
||||||
|
"password": "Wrong-2",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert resp["statusCode"] == 401, resp
|
||||||
|
body = json.loads(resp["body"])
|
||||||
|
assert body["error"] == "invalid_credentials"
|
||||||
|
|
||||||
|
def test_sign_up_duplicate_email_returns_409(self, moto_idp_tables):
|
||||||
|
"""Negative: duplicate email → 409."""
|
||||||
|
payload = {
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "dup@example.com",
|
||||||
|
"password": "First-1",
|
||||||
|
"owner": "owner-dup",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
first = idp.lambda_handler({"body": json.dumps(payload)}, None)
|
||||||
|
assert first["statusCode"] == 200, first
|
||||||
|
second = idp.lambda_handler({"body": json.dumps(payload)}, None)
|
||||||
|
assert second["statusCode"] == 409, second
|
||||||
|
assert json.loads(second["body"])["error"] == "email_already_registered"
|
||||||
|
|
||||||
|
def test_sign_in_unknown_email_returns_401(self, moto_idp_tables):
|
||||||
|
"""Unknown email → 401 (same as wrong password, no enumeration)."""
|
||||||
|
resp = idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_in",
|
||||||
|
"email": "nobody@example.com",
|
||||||
|
"password": "x",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert resp["statusCode"] == 401, resp
|
||||||
|
|
||||||
|
def test_create_session_standalone(self, moto_idp_tables):
|
||||||
|
"""create_session action writes a session row."""
|
||||||
|
resp = idp.lambda_handler(
|
||||||
|
{"body": json.dumps({"action": "create_session", "user_id": "u-xyz"})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert resp["statusCode"] == 200, resp
|
||||||
|
sid = json.loads(resp["body"])["session_id"]
|
||||||
|
item = moto_idp_tables.get_item(
|
||||||
|
TableName="nova-sessions", Key={"session_id": {"S": sid}}
|
||||||
|
)
|
||||||
|
assert "Item" in item
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Fail-closed (also covered in test_argon2_fail_closed.py, but verify E2E)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestFailClosedE2E:
|
||||||
|
def test_sign_up_503_when_argon2_unavailable(self, moto_idp_tables):
|
||||||
|
"""E2E fail-closed: argon2 unavailable → sign_up returns 503 and
|
||||||
|
does NOT write a user (no weak hash write)."""
|
||||||
|
with mock.patch.object(idp, "_ARGON2_AVAILABLE", False):
|
||||||
|
resp = idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "fail@example.com",
|
||||||
|
"password": "p",
|
||||||
|
"owner": "o",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert resp["statusCode"] == 503, resp
|
||||||
|
# No user should have been written.
|
||||||
|
items = moto_idp_tables.scan(TableName="nova-users").get("Items", [])
|
||||||
|
assert not items, "user was written despite argon2 unavailable (weak hash!)"
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Password reset flow
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestPasswordReset:
|
||||||
|
def test_request_then_reset_password(self, moto_idp_tables):
|
||||||
|
password = "Original-1"
|
||||||
|
idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "reset@example.com",
|
||||||
|
"password": password,
|
||||||
|
"owner": "owner-reset",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
# request reset
|
||||||
|
req = idp.lambda_handler(
|
||||||
|
{"body": json.dumps({"action": "request_password_reset",
|
||||||
|
"email": "reset@example.com"})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert req["statusCode"] == 200, req
|
||||||
|
token = json.loads(req["body"])["reset_token"]
|
||||||
|
assert token, "no reset token returned"
|
||||||
|
# reset password
|
||||||
|
new_pw = "NewSecret-2"
|
||||||
|
rst = idp.lambda_handler(
|
||||||
|
{"body": json.dumps({"action": "reset_password",
|
||||||
|
"reset_token": token,
|
||||||
|
"new_password": new_pw})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert rst["statusCode"] == 200, rst
|
||||||
|
# sign in with the new password works
|
||||||
|
inn = idp.lambda_handler(
|
||||||
|
{"body": json.dumps({"action": "sign_in",
|
||||||
|
"email": "reset@example.com",
|
||||||
|
"password": new_pw})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert inn["statusCode"] == 200, inn
|
||||||
|
# old password now fails
|
||||||
|
old = idp.lambda_handler(
|
||||||
|
{"body": json.dumps({"action": "sign_in",
|
||||||
|
"email": "reset@example.com",
|
||||||
|
"password": password})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert old["statusCode"] == 401, old
|
||||||
|
|
||||||
|
def test_reset_with_invalid_token_returns_400(self, moto_idp_tables):
|
||||||
|
resp = idp.lambda_handler(
|
||||||
|
{"body": json.dumps({"action": "reset_password",
|
||||||
|
"reset_token": "bogus",
|
||||||
|
"new_password": "x"})},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
assert resp["statusCode"] == 400, resp
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# No raw passwords in logs (verification step 5)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestNoRawPasswordsInLogs:
|
||||||
|
def test_sign_up_does_not_log_password(self, moto_idp_tables, caplog):
|
||||||
|
"""Verification step 5: the password string is NOT in any log record."""
|
||||||
|
import logging
|
||||||
|
|
||||||
|
secret = "LogSecret-55512"
|
||||||
|
with caplog.at_level(logging.DEBUG):
|
||||||
|
idp.lambda_handler(
|
||||||
|
{
|
||||||
|
"body": json.dumps(
|
||||||
|
{
|
||||||
|
"action": "sign_up",
|
||||||
|
"email": "log@example.com",
|
||||||
|
"password": secret,
|
||||||
|
"owner": "owner-log",
|
||||||
|
"roles": ["user"],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
},
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
for record in caplog.records:
|
||||||
|
assert secret not in record.getMessage(), (
|
||||||
|
f"raw password leaked in log: {record.getMessage()!r}"
|
||||||
|
)
|
||||||
@@ -0,0 +1,191 @@
|
|||||||
|
"""nova idp setup tests (REQ-340, REQ-341, C-2.1).
|
||||||
|
|
||||||
|
Tests:
|
||||||
|
* ``generate_template()`` produces a valid CFN dict with the expected
|
||||||
|
resource types (3 Lambdas, 4 DDB tables, KMS key, 3 URLs, 3 roles).
|
||||||
|
* ``--check`` (mock AWS) → prints a prerequisite report.
|
||||||
|
* ``--dry-run`` → resource summary.
|
||||||
|
* ``--apply`` (mock cloudformation deploy) → prompts + deploys.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
os.environ.setdefault("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
|
||||||
|
def _load(mod_name, rel_path):
|
||||||
|
spec = importlib.util.spec_from_file_location(mod_name, rel_path)
|
||||||
|
mod = importlib.util.module_from_spec(spec)
|
||||||
|
spec.loader.exec_module(mod)
|
||||||
|
return mod
|
||||||
|
|
||||||
|
|
||||||
|
_CFN_PATH = Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_cfn.py"
|
||||||
|
_SETUP_PATH = Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_setup.py"
|
||||||
|
cfn = _load("nova_idp_cfn_test", _CFN_PATH)
|
||||||
|
setup = _load("nova_idp_setup_test", _SETUP_PATH)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# generate_template
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_generate_template_has_expected_resources():
|
||||||
|
t = cfn.generate_template()
|
||||||
|
res = t["Resources"]
|
||||||
|
types = [r["Type"] for r in res.values()]
|
||||||
|
assert types.count("AWS::Lambda::Function") == 3
|
||||||
|
assert types.count("AWS::DynamoDB::Table") == 4
|
||||||
|
assert types.count("AWS::KMS::Key") == 1
|
||||||
|
assert types.count("AWS::KMS::Alias") == 1
|
||||||
|
assert types.count("AWS::Lambda::Url") == 3
|
||||||
|
assert types.count("AWS::IAM::Role") == 3
|
||||||
|
|
||||||
|
|
||||||
|
def test_generate_template_kms_key_spec():
|
||||||
|
t = cfn.generate_template()
|
||||||
|
key = t["Resources"]["NovaOidcSigningKey"]["Properties"]
|
||||||
|
assert key["KeySpec"] == "ECC_NIST_P256"
|
||||||
|
assert key["KeyUsage"] == "SIGN_VERIFY"
|
||||||
|
|
||||||
|
|
||||||
|
def test_generate_template_jwks_url_auth_none():
|
||||||
|
"""JWKS function URL is AuthType NONE (public, REQ-338)."""
|
||||||
|
t = cfn.generate_template()
|
||||||
|
url = t["Resources"]["NovaIdpJwksUrl"]["Properties"]
|
||||||
|
assert url["AuthType"] == "NONE"
|
||||||
|
|
||||||
|
|
||||||
|
def test_generate_template_auth_url_iam():
|
||||||
|
t = cfn.generate_template()
|
||||||
|
url = t["Resources"]["NovaIdpAuthUrl"]["Properties"]
|
||||||
|
assert url["AuthType"] == "AWS_IAM"
|
||||||
|
|
||||||
|
|
||||||
|
def test_generate_template_public_domain_adds_cloudfront():
|
||||||
|
t = cfn.generate_template(public_jwks_domain="jwks.example.com")
|
||||||
|
types = [r["Type"] for r in t["Resources"].values()]
|
||||||
|
assert "AWS::CloudFront::Distribution" in types
|
||||||
|
assert "AWS::CertificateManager::Certificate" in types
|
||||||
|
|
||||||
|
|
||||||
|
def test_resource_summary():
|
||||||
|
t = cfn.generate_template()
|
||||||
|
s = cfn.resource_summary(t)
|
||||||
|
assert s["AWS::Lambda::Function"] == 3
|
||||||
|
assert s["AWS::DynamoDB::Table"] == 4
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# --check
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_check_prerequisites_returns_report():
|
||||||
|
with mock.patch("subprocess.check_output", side_effect=Exception("no creds")):
|
||||||
|
report = setup.check_prerequisites()
|
||||||
|
assert "aws_creds" in report
|
||||||
|
assert report["aws_creds"] is False
|
||||||
|
assert "missing" in report
|
||||||
|
assert "iam_delta" in report
|
||||||
|
assert "cloudformation:*" in report["iam_delta"]
|
||||||
|
|
||||||
|
|
||||||
|
def test_check_prerequisites_with_creds():
|
||||||
|
fake = json.dumps({"Account": "123456789012", "UserId": "u", "Arn": "arn"})
|
||||||
|
with mock.patch("subprocess.check_output", return_value=fake):
|
||||||
|
report = setup.check_prerequisites()
|
||||||
|
assert report["aws_creds"] is True
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# --dry-run
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_dry_run_returns_summary():
|
||||||
|
r = setup.generate_and_deploy(dry_run=True)
|
||||||
|
assert r["deployed"] is False
|
||||||
|
assert "AWS::Lambda::Function" in r["summary"]
|
||||||
|
assert r["summary"]["AWS::Lambda::Function"] == 3
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# --apply (mock cloudformation deploy)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_apply_aborts_without_approval():
|
||||||
|
r = setup.generate_and_deploy(approve_fn=lambda: False)
|
||||||
|
assert r["deployed"] is False
|
||||||
|
|
||||||
|
|
||||||
|
def test_apply_deploys_with_approval():
|
||||||
|
with mock.patch("subprocess.check_call", return_value=0):
|
||||||
|
r = setup.generate_and_deploy(approve_fn=lambda: True)
|
||||||
|
assert r["deployed"] is True
|
||||||
|
|
||||||
|
|
||||||
|
def test_apply_deploy_failure_returns_not_deployed():
|
||||||
|
with mock.patch("subprocess.check_call", side_effect=RuntimeError("cfn error")):
|
||||||
|
r = setup.generate_and_deploy(approve_fn=lambda: True)
|
||||||
|
assert r["deployed"] is False
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# --verify
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_verify_roundtrip_passes():
|
||||||
|
r = setup.verify()
|
||||||
|
assert r["passed"] is True
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# CLI wrapper (nova/idp/setup.py)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_cli_setup_check(capsys):
|
||||||
|
from nova.idp import setup as cli_setup
|
||||||
|
args = mock.MagicMock()
|
||||||
|
args.check = True; args.apply = False; args.verify = False; args.dry_run = False
|
||||||
|
args.public_jwks_domain = None
|
||||||
|
rc = cli_setup.run(args)
|
||||||
|
assert rc == 0
|
||||||
|
out = capsys.readouterr().out
|
||||||
|
assert "aws_creds" in out
|
||||||
|
|
||||||
|
|
||||||
|
def test_cli_setup_dry_run(capsys):
|
||||||
|
from nova.idp import setup as cli_setup
|
||||||
|
args = mock.MagicMock()
|
||||||
|
args.check = False; args.apply = False; args.verify = False; args.dry_run = True
|
||||||
|
args.public_jwks_domain = None
|
||||||
|
rc = cli_setup.run(args)
|
||||||
|
assert rc == 0
|
||||||
|
out = capsys.readouterr().out
|
||||||
|
assert "AWS::Lambda::Function" in out
|
||||||
|
|
||||||
|
|
||||||
|
def test_cli_setup_verify(capsys):
|
||||||
|
from nova.idp import setup as cli_setup
|
||||||
|
args = mock.MagicMock()
|
||||||
|
args.check = False; args.apply = False; args.verify = True; args.dry_run = False
|
||||||
|
args.public_jwks_domain = None
|
||||||
|
rc = cli_setup.run(args)
|
||||||
|
assert rc == 0
|
||||||
@@ -0,0 +1,50 @@
|
|||||||
|
"""REQ-331 test: nova init scaffolds .nova/contract.yml.attestations/ empty.
|
||||||
|
|
||||||
|
P1 (nova/init.py + core/init_scaffold.py) creates the attestations dir
|
||||||
|
during `nova init`. This test explicitly verifies (a) the dir exists and
|
||||||
|
(b) it is EMPTY after init (listdir returns []) — a freshly scaffolded
|
||||||
|
repo has no attestations yet (they are produced later by
|
||||||
|
nova apply --sign-local-review / the JWS attestation flow, REQ-332).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import os
|
||||||
|
import subprocess
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
|
||||||
|
def _nova_help_cmd():
|
||||||
|
"""Return the command list to invoke `nova --help` (prefer installed entry)."""
|
||||||
|
nova = os.path.join(os.path.dirname(sys.executable), "nova")
|
||||||
|
if os.path.isfile(nova):
|
||||||
|
return [nova, "--help"]
|
||||||
|
return [sys.executable, "-m", "nova.cli", "--help"]
|
||||||
|
|
||||||
|
|
||||||
|
def test_init_attestations_dir_exists_and_is_empty(tmp_path):
|
||||||
|
"""nova init creates .nova/contract.yml.attestations/ and it is empty."""
|
||||||
|
cmd = _nova_help_cmd()
|
||||||
|
init_cmd = cmd[:-1] + ["init"]
|
||||||
|
proc = subprocess.run(init_cmd, capture_output=True, text=True, cwd=str(tmp_path))
|
||||||
|
assert proc.returncode == 0, f"nova init failed: {proc.stderr}"
|
||||||
|
attest_dir = tmp_path / ".nova" / "contract.yml.attestations"
|
||||||
|
assert attest_dir.is_dir(), ".nova/contract.yml.attestations/ not created"
|
||||||
|
# REQ-331: the dir is empty after init (no attestations yet).
|
||||||
|
entries = os.listdir(attest_dir)
|
||||||
|
assert entries == [], (
|
||||||
|
f".nova/contract.yml.attestations/ not empty after init: {entries}"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def test_init_attestations_dir_is_a_directory_not_a_file(tmp_path):
|
||||||
|
"""The attestations path is a directory (not a file), so attestation
|
||||||
|
JWS files can be written into it later (REQ-332 flow)."""
|
||||||
|
cmd = _nova_help_cmd()
|
||||||
|
init_cmd = cmd[:-1] + ["init"]
|
||||||
|
proc = subprocess.run(init_cmd, capture_output=True, text=True, cwd=str(tmp_path))
|
||||||
|
assert proc.returncode == 0, f"nova init failed: {proc.stderr}"
|
||||||
|
attest_path = tmp_path / ".nova" / "contract.yml.attestations"
|
||||||
|
assert attest_path.is_dir(), f"{attest_path} is not a directory"
|
||||||
|
assert not attest_path.is_file(), f"{attest_path} is a file, not a directory"
|
||||||
@@ -0,0 +1,123 @@
|
|||||||
|
"""JWKS endpoint tests (REQ-338, D-230).
|
||||||
|
|
||||||
|
Mocks ``kms.get_public_key`` with a test ECDSA P-256 public key DER →
|
||||||
|
asserts the Lambda returns 200 + the right headers + a valid JWK.
|
||||||
|
Cross-verifies: a JWT signed with the test private key verifies with
|
||||||
|
pyjwt using the JWKS key.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
_SOURCE_PATH = (
|
||||||
|
Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_jwks.py"
|
||||||
|
)
|
||||||
|
_spec = importlib.util.spec_from_file_location("nova_idp_jwks", _SOURCE_PATH)
|
||||||
|
jwks = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(jwks)
|
||||||
|
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
import jwt as pyjwt
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
|
||||||
|
|
||||||
|
class _MockKms:
|
||||||
|
def __init__(self, pub_der):
|
||||||
|
self._pub_der = pub_der
|
||||||
|
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": self._pub_der, "KeyId": KeyId}
|
||||||
|
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
# Provided so sign_jwt works in the cross-verify test.
|
||||||
|
return {"Signature": self._priv.sign(Message, ec.ECDSA(hashes.SHA256()))}
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def test_keypair():
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub = priv.public_key()
|
||||||
|
pub_der = pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
return priv, pub, pub_der
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _reset():
|
||||||
|
yield
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
|
||||||
|
|
||||||
|
def test_jwks_returns_200_and_headers(test_keypair):
|
||||||
|
_priv, _pub, pub_der = test_keypair
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(pub_der))
|
||||||
|
resp = jwks.lambda_handler({}, None)
|
||||||
|
assert resp["statusCode"] == 200
|
||||||
|
headers = resp["headers"]
|
||||||
|
assert headers["Content-Type"] == "application/json"
|
||||||
|
assert headers["Cache-Control"] == "public, max-age=3600"
|
||||||
|
assert headers["Access-Control-Allow-Origin"] == "*"
|
||||||
|
|
||||||
|
|
||||||
|
def test_jwks_returns_valid_ec_jwk(test_keypair):
|
||||||
|
_priv, _pub, pub_der = test_keypair
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(pub_der))
|
||||||
|
resp = jwks.lambda_handler({}, None)
|
||||||
|
body = json.loads(resp["body"])
|
||||||
|
assert "keys" in body
|
||||||
|
assert len(body["keys"]) == 1
|
||||||
|
jwk = body["keys"][0]
|
||||||
|
assert jwk["kty"] == "EC"
|
||||||
|
assert jwk["crv"] == "P-256"
|
||||||
|
assert "kid" in jwk
|
||||||
|
assert "x" in jwk and "y" in jwk
|
||||||
|
assert len(jwk["x"]) == 43 # 32 bytes → 43 base64url chars
|
||||||
|
assert len(jwk["y"]) == 43
|
||||||
|
|
||||||
|
|
||||||
|
def test_jwks_cross_verifies_jwt(test_keypair):
|
||||||
|
"""A JWT signed with the test private key verifies with the JWKS key."""
|
||||||
|
priv, _pub, pub_der = test_keypair
|
||||||
|
# Mock KMS that can both sign (for sign_jwt) and serve the public key.
|
||||||
|
mock_kms = _MockKms(pub_der)
|
||||||
|
mock_kms._priv = priv
|
||||||
|
kms_signing.set_kms_client_for_testing(mock_kms)
|
||||||
|
|
||||||
|
# Sign a JWT via kms_signing.sign_jwt.
|
||||||
|
token = kms_signing.sign_jwt(
|
||||||
|
{"sub": "user-1", "exp": 9999999999, "iat": 1, "jti": "j", "aud": "nova-cli"},
|
||||||
|
key_id="alias/nova-oidc-signing",
|
||||||
|
)
|
||||||
|
# Fetch the JWKS via the Lambda.
|
||||||
|
resp = jwks.lambda_handler({}, None)
|
||||||
|
jwk = json.loads(resp["body"])["keys"][0]
|
||||||
|
# Verify the JWT with pyjwt using the JWK.
|
||||||
|
key = pyjwt.PyJWK(jwk).key
|
||||||
|
decoded = pyjwt.decode(token, key, algorithms=["ES256"], options={"verify_aud": False})
|
||||||
|
assert decoded["sub"] == "user-1"
|
||||||
|
assert decoded["jti"] == "j"
|
||||||
|
|
||||||
|
|
||||||
|
def test_jwks_500_on_kms_error():
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
# Force get_jwk to raise by using a broken client.
|
||||||
|
broken = mock.MagicMock()
|
||||||
|
broken.get_public_key.side_effect = RuntimeError("KMS down")
|
||||||
|
kms_signing.set_kms_client_for_testing(broken)
|
||||||
|
resp = jwks.lambda_handler({}, None)
|
||||||
|
assert resp["statusCode"] == 500
|
||||||
@@ -0,0 +1,193 @@
|
|||||||
|
"""REQ-332 / C-5.2 tests: JWS-from-PAT key derivation (symmetric HS256).
|
||||||
|
|
||||||
|
Verifies:
|
||||||
|
- HKDF-SHA256 key derivation (32 bytes, deterministic, salt/info constants)
|
||||||
|
- sign → verify round-trip (payload matches)
|
||||||
|
- tamper detection (modify the JWS → verify raises)
|
||||||
|
- wrong-PAT detection (verify with a different PAT → raises)
|
||||||
|
- INV-14..17: key derived from PAT, not cached, fixed salt/info, HMAC
|
||||||
|
constant-time comparison
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
from core.jws_attestation import (
|
||||||
|
JWSValidationError,
|
||||||
|
derive_signing_key,
|
||||||
|
sign_attestation,
|
||||||
|
verify_attestation,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestDeriveSigningKey:
|
||||||
|
def test_returns_32_bytes(self):
|
||||||
|
key = derive_signing_key("test-pat")
|
||||||
|
assert isinstance(key, bytes)
|
||||||
|
assert len(key) == 32, f"expected 32 bytes, got {len(key)}"
|
||||||
|
|
||||||
|
def test_deterministic(self):
|
||||||
|
"""The same PAT always yields the same key (HKDF is deterministic)."""
|
||||||
|
k1 = derive_signing_key("my-pat")
|
||||||
|
k2 = derive_signing_key("my-pat")
|
||||||
|
assert k1 == k2
|
||||||
|
|
||||||
|
def test_different_pats_yield_different_keys(self):
|
||||||
|
k1 = derive_signing_key("pat-a")
|
||||||
|
k2 = derive_signing_key("pat-b")
|
||||||
|
assert k1 != k2
|
||||||
|
|
||||||
|
def test_empty_pat_raises(self):
|
||||||
|
with pytest.raises(ValueError, match="non-empty"):
|
||||||
|
derive_signing_key("")
|
||||||
|
|
||||||
|
def test_non_string_pat_raises(self):
|
||||||
|
with pytest.raises(ValueError):
|
||||||
|
derive_signing_key(12345) # type: ignore[arg-type]
|
||||||
|
|
||||||
|
def test_key_is_not_the_pat_raw_bytes(self):
|
||||||
|
"""INV-14: the key is DERIVED from the PAT, not the PAT bytes."""
|
||||||
|
key = derive_signing_key("test-pat")
|
||||||
|
assert key != b"test-pat"
|
||||||
|
assert key != "test-pat".encode()
|
||||||
|
|
||||||
|
def test_hashlib_fallback_matches_cryptography(self):
|
||||||
|
"""The hashlib HKDF fallback produces the same key as cryptography."""
|
||||||
|
from core.jws_attestation import _hkdf_sha256, _hkdf_sha256_hashlib
|
||||||
|
ikm = b"test-pat"
|
||||||
|
salt = b"nova-local-attestation"
|
||||||
|
info = b"jws-signing-key"
|
||||||
|
via_crypto = _hkdf_sha256(ikm, salt, info, 32)
|
||||||
|
via_hashlib = _hkdf_sha256_hashlib(ikm, salt, info, 32)
|
||||||
|
assert via_crypto == via_hashlib
|
||||||
|
|
||||||
|
|
||||||
|
class TestRoundTrip:
|
||||||
|
def test_sign_verify_roundtrip(self):
|
||||||
|
"""sign → verify → payload matches the original."""
|
||||||
|
payload = {"x": 1, "contractId": "c-001", "reviewer": "alice"}
|
||||||
|
jws = sign_attestation(payload, "test-pat")
|
||||||
|
assert isinstance(jws, str)
|
||||||
|
# Compact JWS: 3 dot-separated segments.
|
||||||
|
assert jws.count(".") == 2
|
||||||
|
verified = verify_attestation(jws, "test-pat")
|
||||||
|
assert verified == payload
|
||||||
|
|
||||||
|
def test_roundtrip_complex_payload(self):
|
||||||
|
payload = {
|
||||||
|
"contractId": "msvc-001",
|
||||||
|
"environment": "dev",
|
||||||
|
"reviewers": ["alice", "bob"],
|
||||||
|
"score": 0.92,
|
||||||
|
"nested": {"a": 1, "b": [2, 3]},
|
||||||
|
}
|
||||||
|
jws = sign_attestation(payload, "secret-pat-123")
|
||||||
|
verified = verify_attestation(jws, "secret-pat-123")
|
||||||
|
assert verified == payload
|
||||||
|
|
||||||
|
def test_header_is_hs256_jwt(self):
|
||||||
|
"""The JWS header is {"alg":"HS256","typ":"JWT"}."""
|
||||||
|
import base64
|
||||||
|
import json
|
||||||
|
jws = sign_attestation({"x": 1}, "pat")
|
||||||
|
header_segment = jws.split(".")[0]
|
||||||
|
pad = "=" * (-len(header_segment) % 4)
|
||||||
|
header = json.loads(base64.urlsafe_b64decode(header_segment + pad))
|
||||||
|
assert header["alg"] == "HS256"
|
||||||
|
assert header["typ"] == "JWT"
|
||||||
|
|
||||||
|
|
||||||
|
class TestTamperDetection:
|
||||||
|
def test_tampered_payload_raises(self):
|
||||||
|
"""Modifying the payload segment → verify raises (INV-17)."""
|
||||||
|
payload = {"x": 1}
|
||||||
|
jws = sign_attestation(payload, "test-pat")
|
||||||
|
parts = jws.split(".")
|
||||||
|
# Flip a char in the payload segment.
|
||||||
|
tampered_payload = parts[1][:-1] + ("A" if parts[1][-1] != "A" else "B")
|
||||||
|
tampered = f"{parts[0]}.{tampered_payload}.{parts[2]}"
|
||||||
|
with pytest.raises(JWSValidationError, match="signature verification failed"):
|
||||||
|
verify_attestation(tampered, "test-pat")
|
||||||
|
|
||||||
|
def test_tampered_signature_raises(self):
|
||||||
|
"""Modifying the signature segment → verify raises."""
|
||||||
|
payload = {"x": 1}
|
||||||
|
jws = sign_attestation(payload, "test-pat")
|
||||||
|
parts = jws.split(".")
|
||||||
|
tampered_sig = parts[2][:-1] + ("A" if parts[2][-1] != "A" else "B")
|
||||||
|
tampered = f"{parts[0]}.{parts[1]}.{tampered_sig}"
|
||||||
|
with pytest.raises(JWSValidationError, match="signature verification failed"):
|
||||||
|
verify_attestation(tampered, "test-pat")
|
||||||
|
|
||||||
|
def test_tampered_header_raises(self):
|
||||||
|
"""Modifying the header segment → verify raises (header is part of
|
||||||
|
the signing input)."""
|
||||||
|
payload = {"x": 1}
|
||||||
|
jws = sign_attestation(payload, "test-pat")
|
||||||
|
parts = jws.split(".")
|
||||||
|
tampered_header = parts[0][:-1] + ("A" if parts[0][-1] != "A" else "B")
|
||||||
|
tampered = f"{tampered_header}.{parts[1]}.{parts[2]}"
|
||||||
|
with pytest.raises(JWSValidationError):
|
||||||
|
verify_attestation(tampered, "test-pat")
|
||||||
|
|
||||||
|
def test_malformed_jws_raises(self):
|
||||||
|
with pytest.raises(JWSValidationError, match="3 segments"):
|
||||||
|
verify_attestation("not.a.jws.token", "pat")
|
||||||
|
with pytest.raises(JWSValidationError, match="3 segments"):
|
||||||
|
verify_attestation("onlyonesegment", "pat")
|
||||||
|
|
||||||
|
|
||||||
|
class TestWrongPatDetection:
|
||||||
|
def test_wrong_pat_raises(self):
|
||||||
|
"""Verify with a different PAT → raises (the key derivation differs)."""
|
||||||
|
payload = {"x": 1}
|
||||||
|
jws = sign_attestation(payload, "correct-pat")
|
||||||
|
with pytest.raises(JWSValidationError, match="signature verification failed"):
|
||||||
|
verify_attestation(jws, "wrong-pat")
|
||||||
|
|
||||||
|
def test_empty_pat_raises(self):
|
||||||
|
jws = sign_attestation({"x": 1}, "real-pat")
|
||||||
|
with pytest.raises(ValueError):
|
||||||
|
verify_attestation(jws, "")
|
||||||
|
|
||||||
|
|
||||||
|
class TestInvInvariants:
|
||||||
|
def test_inv14_key_derived_from_pat(self):
|
||||||
|
"""INV-14: the signing key is derived from the PAT via HKDF."""
|
||||||
|
# The key is a function of the PAT (different PAT → different key,
|
||||||
|
# same PAT → same key). Already covered above; this is the explicit
|
||||||
|
# invariant assertion.
|
||||||
|
assert derive_signing_key("pat") == derive_signing_key("pat")
|
||||||
|
assert derive_signing_key("pat") != derive_signing_key("other")
|
||||||
|
|
||||||
|
def test_inv15_key_not_cached(self):
|
||||||
|
"""INV-15: derive_signing_key recomputes the key on each call (no
|
||||||
|
module-level cache of the key). Inspect the module source."""
|
||||||
|
import inspect
|
||||||
|
from core import jws_attestation
|
||||||
|
src = inspect.getsource(jws_attestation.derive_signing_key)
|
||||||
|
assert "_hkdf_sha256(" in src
|
||||||
|
# No module-level key cache variable.
|
||||||
|
assert not hasattr(jws_attestation, "_cached_key")
|
||||||
|
assert not hasattr(jws_attestation, "_signing_key")
|
||||||
|
|
||||||
|
def test_inv16_salt_and_info_are_fixed_constants(self):
|
||||||
|
"""INV-16: the salt + info are fixed constants binding the key to
|
||||||
|
the nova-local-attestation / jws-signing-key purpose."""
|
||||||
|
from core import jws_attestation
|
||||||
|
assert jws_attestation._KDF_SALT == b"nova-local-attestation"
|
||||||
|
assert jws_attestation._KDF_INFO == b"jws-signing-key"
|
||||||
|
assert jws_attestation._KDF_LENGTH == 32
|
||||||
|
|
||||||
|
def test_inv17_constant_time_comparison(self):
|
||||||
|
"""INV-17: signature comparison uses hmac.compare_digest (constant-time)."""
|
||||||
|
import inspect
|
||||||
|
from core import jws_attestation
|
||||||
|
src = inspect.getsource(jws_attestation.verify_attestation)
|
||||||
|
assert "compare_digest" in src
|
||||||
@@ -0,0 +1,84 @@
|
|||||||
|
"""CAP-037 KMS round-trip test (REQ-350).
|
||||||
|
|
||||||
|
Sign a test JWT via ``core.kms_signing.sign_jwt()`` (mock KMS with a
|
||||||
|
test keypair) → fetch JWKS via ``nova_idp_jwks.lambda_handler()`` (mock
|
||||||
|
KMS) → verify the JWT with ``pyjwt`` using the JWKS key. Round-trip
|
||||||
|
succeeds — proves the DER→raw conversion + JWK export are mutually
|
||||||
|
consistent (the #1 gotcha from RESEARCH §5).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
_JWKS_PATH = Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_jwks.py"
|
||||||
|
_spec = importlib.util.spec_from_file_location("nova_idp_jwks_rt", _JWKS_PATH)
|
||||||
|
jwks_mod = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(jwks_mod)
|
||||||
|
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
import jwt as pyjwt
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
|
||||||
|
|
||||||
|
class _MockKms:
|
||||||
|
def __init__(self, priv, pub_der):
|
||||||
|
self._priv = priv
|
||||||
|
self._pub_der = pub_der
|
||||||
|
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
return {"Signature": self._priv.sign(Message, ec.ECDSA(hashes.SHA256()))}
|
||||||
|
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": self._pub_der}
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _reset():
|
||||||
|
yield
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
|
||||||
|
|
||||||
|
def test_cap037_kms_roundtrip():
|
||||||
|
"""Sign JWT → JWKS → pyjwt verify. The full KMS round-trip (REQ-350)."""
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub = priv.public_key()
|
||||||
|
pub_der = pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
|
||||||
|
# 1. Sign a JWT via kms_signing.sign_jwt (uses DER→raw conversion).
|
||||||
|
claims = {
|
||||||
|
"sub": "roundtrip-user", "aud": "nova-cli", "iss": "nova-idp",
|
||||||
|
"exp": 9999999999, "iat": 1700000000, "jti": "rt-jti",
|
||||||
|
"roles": ["developer"], "typ": "nova_oidc_token",
|
||||||
|
}
|
||||||
|
token = kms_signing.sign_jwt(claims, key_id="alias/nova-oidc-signing")
|
||||||
|
|
||||||
|
# 2. Fetch the JWKS via the JWKS Lambda (mock KMS get_public_key).
|
||||||
|
resp = jwks_mod.lambda_handler({}, None)
|
||||||
|
assert resp["statusCode"] == 200
|
||||||
|
jwks_body = json.loads(resp["body"])
|
||||||
|
jwk = jwks_body["keys"][0]
|
||||||
|
assert jwk["kty"] == "EC" and jwk["crv"] == "P-256"
|
||||||
|
|
||||||
|
# 3. Verify the JWT with pyjwt using the JWKS key.
|
||||||
|
key = pyjwt.PyJWK(jwk).key
|
||||||
|
decoded = pyjwt.decode(token, key, algorithms=["ES256"], audience="nova-cli")
|
||||||
|
assert decoded["sub"] == "roundtrip-user"
|
||||||
|
assert decoded["jti"] == "rt-jti"
|
||||||
|
assert decoded["roles"] == ["developer"]
|
||||||
|
assert decoded["typ"] == "nova_oidc_token"
|
||||||
@@ -0,0 +1,172 @@
|
|||||||
|
"""KMS signing tests (REQ-337, C-1.1).
|
||||||
|
|
||||||
|
Tests :func:`core.kms_signing.der_to_raw_ecdsa` with a known DER
|
||||||
|
signature and the full :func:`sign_jwt` round-trip with a mocked KMS
|
||||||
|
client (no real AWS calls — C-1.1 documented as a CI gate in
|
||||||
|
``docs/kms-provisioning.md``).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import base64
|
||||||
|
import json
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
from core.kms_signing import der_to_raw_ecdsa, sign_jwt, get_jwk
|
||||||
|
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec, utils
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
import jwt as pyjwt
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Test keypair — generated once per session (P-256).
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(scope="module")
|
||||||
|
def test_keypair():
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub = priv.public_key()
|
||||||
|
return priv, pub
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(scope="module")
|
||||||
|
def test_pub_der(test_keypair):
|
||||||
|
_priv, pub = test_keypair
|
||||||
|
return pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class _MockKmsSignClient:
|
||||||
|
"""Mock KMS client that signs with a test ECDSA private key (DER)."""
|
||||||
|
|
||||||
|
def __init__(self, priv, pub_der, key_id="alias/nova-oidc-signing"):
|
||||||
|
self._priv = priv
|
||||||
|
self._pub_der = pub_der
|
||||||
|
self._key_id = key_id
|
||||||
|
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
assert SigningAlgorithm == "ECDSA_SHA_256"
|
||||||
|
assert MessageType == "RAW"
|
||||||
|
der = self._priv.sign(Message, ec.ECDSA(hashes.SHA256()))
|
||||||
|
return {"Signature": der, "KeyId": KeyId}
|
||||||
|
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": self._pub_der, "KeyId": KeyId}
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# der_to_raw_ecdsa — unit test with a known DER signature.
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_der_to_raw_ecdsa_known_vector():
|
||||||
|
# Minimal DER: SEQUENCE { INTEGER r, INTEGER s }.
|
||||||
|
# r=5, s=7 → DER: 30 06 02 01 05 02 01 07
|
||||||
|
der = b"\x30\x06\x02\x01\x05\x02\x01\x07"
|
||||||
|
raw = der_to_raw_ecdsa(der)
|
||||||
|
assert len(raw) == 64 # 32 + 32
|
||||||
|
r = int.from_bytes(raw[:32], "big")
|
||||||
|
s = int.from_bytes(raw[32:], "big")
|
||||||
|
assert r == 5
|
||||||
|
assert s == 7
|
||||||
|
|
||||||
|
|
||||||
|
def test_der_to_raw_ecdsa_real_signature(test_keypair):
|
||||||
|
priv, _ = test_keypair
|
||||||
|
msg = b"test message for der->raw"
|
||||||
|
der = priv.sign(msg, ec.ECDSA(hashes.SHA256()))
|
||||||
|
raw = der_to_raw_ecdsa(der)
|
||||||
|
assert len(raw) == 64
|
||||||
|
# Round-trip: raw → (r, s) should verify against the message.
|
||||||
|
r = int.from_bytes(raw[:32], "big")
|
||||||
|
s = int.from_bytes(raw[32:], "big")
|
||||||
|
from cryptography.hazmat.primitives.asymmetric.utils import encode_dss_signature
|
||||||
|
der2 = encode_dss_signature(r, s)
|
||||||
|
# Verifying with the re-encoded DER proves the raw split is correct.
|
||||||
|
priv.public_key().verify(der2, msg, ec.ECDSA(hashes.SHA256()))
|
||||||
|
|
||||||
|
|
||||||
|
def test_der_to_raw_ecdsa_rejects_oversized_coord():
|
||||||
|
# r needs 33 bytes (2**256+1) → should raise.
|
||||||
|
from cryptography.hazmat.primitives.asymmetric.utils import encode_dss_signature
|
||||||
|
der = encode_dss_signature(2**256 + 1, 1)
|
||||||
|
with pytest.raises(ValueError):
|
||||||
|
der_to_raw_ecdsa(der, coord_len=32)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# sign_jwt — full round-trip with mock KMS + pyjwt verification.
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def test_sign_jwt_roundtrip_verifies_with_pyjwt(test_keypair, test_pub_der):
|
||||||
|
priv, pub = test_keypair
|
||||||
|
client = _MockKmsSignClient(priv, test_pub_der)
|
||||||
|
kms_signing.set_kms_client_for_testing(client)
|
||||||
|
try:
|
||||||
|
claims = {
|
||||||
|
"sub": "user-1",
|
||||||
|
"aud": "nova-cli",
|
||||||
|
"iss": "nova-idp",
|
||||||
|
"exp": 9999999999,
|
||||||
|
"iat": 1700000000,
|
||||||
|
"jti": "test-jti",
|
||||||
|
"roles": ["developer"],
|
||||||
|
}
|
||||||
|
token = sign_jwt(claims, key_id="alias/nova-oidc-signing")
|
||||||
|
parts = token.split(".")
|
||||||
|
assert len(parts) == 3 # header.payload.signature
|
||||||
|
|
||||||
|
# Verify the header.
|
||||||
|
header = json.loads(base64.urlsafe_b64decode(parts[0] + "=="))
|
||||||
|
assert header["alg"] == "ES256"
|
||||||
|
assert header["typ"] == "JWT"
|
||||||
|
assert header["kid"] == "alias/nova-oidc-signing"
|
||||||
|
|
||||||
|
# Verify the signature with pyjwt using the test public key.
|
||||||
|
pem = pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.PEM,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
).decode("ascii")
|
||||||
|
decoded = pyjwt.decode(token, pem, algorithms=["ES256"], options={"verify_aud": False})
|
||||||
|
assert decoded["sub"] == "user-1"
|
||||||
|
assert decoded["jti"] == "test-jti"
|
||||||
|
assert decoded["roles"] == ["developer"]
|
||||||
|
finally:
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
|
||||||
|
|
||||||
|
def test_get_jwk_returns_valid_ec_jwk(test_keypair, test_pub_der):
|
||||||
|
priv, pub = test_keypair
|
||||||
|
client = _MockKmsSignClient(priv, test_pub_der)
|
||||||
|
kms_signing.set_kms_client_for_testing(client)
|
||||||
|
try:
|
||||||
|
jwk = get_jwk(key_id="alias/nova-oidc-signing")
|
||||||
|
assert jwk["kty"] == "EC"
|
||||||
|
assert jwk["crv"] == "P-256"
|
||||||
|
assert jwk["kid"] == "alias/nova-oidc-signing"
|
||||||
|
assert jwk["alg"] == "ES256"
|
||||||
|
# x and y are 32 bytes → 43 base64url chars (no padding).
|
||||||
|
assert len(jwk["x"]) == 43
|
||||||
|
assert len(jwk["y"]) == 43
|
||||||
|
# Cross-verify: a JWT signed with the test private key verifies
|
||||||
|
# with pyjwt using this JWK as the key.
|
||||||
|
client2 = _MockKmsSignClient(priv, test_pub_der)
|
||||||
|
kms_signing.set_kms_client_for_testing(client2)
|
||||||
|
token = sign_jwt({"sub": "x", "exp": 9999999999, "iat": 1, "jti": "j"})
|
||||||
|
key = pyjwt.PyJWK(jwk).key
|
||||||
|
decoded = pyjwt.decode(token, key, algorithms=["ES256"], options={"verify_aud": False})
|
||||||
|
assert decoded["sub"] == "x"
|
||||||
|
finally:
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
@@ -0,0 +1,149 @@
|
|||||||
|
"""REQ-330 tests: core.env.synthesize_local_env — local env synthesizer.
|
||||||
|
|
||||||
|
Verifies the synthesizer:
|
||||||
|
- reads a contract YAML and produces a local env dict
|
||||||
|
- the dict mirrors the shape of core/environments/*.json (validates
|
||||||
|
against schemas/environment.schema.json)
|
||||||
|
- region is "local" + account_id is the placeholder (no real AWS)
|
||||||
|
- the environment override wins over the contract's environment field
|
||||||
|
- mirrors core/onboarding.py:generate_env_file() shape (same required keys)
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import sys
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import jsonschema
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
from core.env import synthesize_local_env
|
||||||
|
|
||||||
|
|
||||||
|
REPO_ROOT = Path(__file__).resolve().parent.parent
|
||||||
|
ENV_SCHEMA_PATH = REPO_ROOT / "schemas" / "environment.schema.json"
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def env_schema():
|
||||||
|
return json.loads(ENV_SCHEMA_PATH.read_text())
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def sample_contract(tmp_path):
|
||||||
|
"""A minimal contract YAML for the synthesizer to read."""
|
||||||
|
contract = """
|
||||||
|
id: msvc
|
||||||
|
name: microservice
|
||||||
|
environment: dev
|
||||||
|
infrastructure:
|
||||||
|
microservice:
|
||||||
|
version: "1.0.0"
|
||||||
|
inputs:
|
||||||
|
image: nginx:latest
|
||||||
|
"""
|
||||||
|
p = tmp_path / "contract.yml"
|
||||||
|
p.write_text(contract)
|
||||||
|
return p
|
||||||
|
|
||||||
|
|
||||||
|
class TestSynthesizeLocalEnv:
|
||||||
|
def test_returns_dict_with_required_keys(self, sample_contract, env_schema):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
assert isinstance(env, dict)
|
||||||
|
# The schema-required keys.
|
||||||
|
for key in (
|
||||||
|
"name", "account_id", "region", "state_backend",
|
||||||
|
"network", "runner_role_arn", "autonomy", "confidence_threshold",
|
||||||
|
):
|
||||||
|
assert key in env, f"missing required key: {key}"
|
||||||
|
|
||||||
|
def test_validates_against_environment_schema(self, sample_contract, env_schema):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
jsonschema.validate(env, env_schema) # raises on invalid
|
||||||
|
|
||||||
|
def test_region_is_local(self, sample_contract):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
assert env["region"] == "local", "region must be the local sentinel"
|
||||||
|
|
||||||
|
def test_account_id_is_placeholder(self, sample_contract):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
assert env["account_id"] == "000000000000", (
|
||||||
|
"account_id must be the placeholder (no real AWS account)"
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_state_backend_is_local(self, sample_contract):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
sb = env["state_backend"]
|
||||||
|
assert sb["bucket"] == "local-tfstate"
|
||||||
|
assert sb["lock_table"] == "local-locks"
|
||||||
|
|
||||||
|
def test_uses_contract_environment_by_default(self, sample_contract):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
assert env["name"] == "dev" # the contract's environment field
|
||||||
|
|
||||||
|
def test_environment_override_wins(self, sample_contract):
|
||||||
|
env = synthesize_local_env(str(sample_contract), environment="qa")
|
||||||
|
assert env["name"] == "qa"
|
||||||
|
# qa threshold is 0.75 (per-env default)
|
||||||
|
assert env["confidence_threshold"] == 0.75
|
||||||
|
|
||||||
|
def test_confidence_threshold_per_env(self, sample_contract):
|
||||||
|
for env_name, expected in (("dev", 0.50), ("qa", 0.75), ("prod", 0.90), ("dr", 0.95)):
|
||||||
|
env = synthesize_local_env(str(sample_contract), environment=env_name)
|
||||||
|
assert env["confidence_threshold"] == expected, env_name
|
||||||
|
|
||||||
|
def test_autonomy_is_full(self, sample_contract):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
assert env["autonomy"] == "full" # local tier is autonomous
|
||||||
|
|
||||||
|
def test_no_real_aws_resources(self, sample_contract):
|
||||||
|
"""The synthesizer must NOT reference real AWS resources — region
|
||||||
|
is 'local', the ARN uses the placeholder account, the bucket is local."""
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
assert "us-east-1" not in env["region"]
|
||||||
|
assert "000000000000" in env["runner_role_arn"]
|
||||||
|
assert "local" in env["state_backend"]["bucket"]
|
||||||
|
|
||||||
|
def test_mirrors_onboarding_env_file_shape(self, sample_contract, env_schema):
|
||||||
|
"""The synthesized env has the same core shape as
|
||||||
|
core/onboarding.py:generate_env_file() output — both carry the
|
||||||
|
schema-required environment-binding keys. (generate_env_file adds
|
||||||
|
ownerId/billingTag for the onboarding request path; the synthesizer
|
||||||
|
is the local-tier counterpart and omits those — no consumer binding.)"""
|
||||||
|
from core.onboarding import generate_env_file
|
||||||
|
request = {
|
||||||
|
"consumerRepo": "acdl/consumer-a",
|
||||||
|
"requestedEnvironment": "dev",
|
||||||
|
"ownerId": "team-a",
|
||||||
|
"billingTag": "cc-a",
|
||||||
|
}
|
||||||
|
onboarded = generate_env_file(request)
|
||||||
|
# The synthesizer output validates against the env schema.
|
||||||
|
synth = synthesize_local_env(str(sample_contract))
|
||||||
|
jsonschema.validate(synth, env_schema)
|
||||||
|
# Both carry the schema-required environment-binding keys.
|
||||||
|
required = {
|
||||||
|
"name", "account_id", "region", "state_backend",
|
||||||
|
"network", "runner_role_arn", "autonomy", "confidence_threshold",
|
||||||
|
}
|
||||||
|
assert required <= set(onboarded.keys()), "onboarding output missing required keys"
|
||||||
|
assert required <= set(synth.keys()), "synthesizer output missing required keys"
|
||||||
|
# The synthesizer omits the onboarding-request-only keys.
|
||||||
|
assert "ownerId" not in synth
|
||||||
|
assert "billingTag" not in synth
|
||||||
|
|
||||||
|
def test_missing_contract_file_defaults_to_dev(self, tmp_path):
|
||||||
|
"""A non-existent contract path defaults to the dev env (no crash)."""
|
||||||
|
env = synthesize_local_env(str(tmp_path / "nonexistent.yml"))
|
||||||
|
assert env["name"] == "dev"
|
||||||
|
assert env["region"] == "local"
|
||||||
|
|
||||||
|
def test_description_mentions_contract_id(self, sample_contract):
|
||||||
|
env = synthesize_local_env(str(sample_contract))
|
||||||
|
assert "msvc" in env["description"], (
|
||||||
|
"description should reference the contract id for traceability"
|
||||||
|
)
|
||||||
@@ -0,0 +1,117 @@
|
|||||||
|
"""Property + edge-case tests for core.mode_resolver (P1, REQ-349).
|
||||||
|
|
||||||
|
Hypothesis-driven: deterministic, flag-wins, invalid-env-ignored,
|
||||||
|
no-silent-fallback, credential+TTY semantics. Edge cases as explicit
|
||||||
|
tests (TTY + piped-stdout analog, missing credential, conflicting
|
||||||
|
flag/env).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import logging
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
from hypothesis import given, strategies as st, settings, HealthCheck
|
||||||
|
|
||||||
|
from core.mode_resolver import resolve_mode
|
||||||
|
|
||||||
|
|
||||||
|
flag_st = st.sampled_from(["agent", "interactive", None])
|
||||||
|
env_st = st.sampled_from(["agent", "interactive", "auto", "", None])
|
||||||
|
cred_st = st.sampled_from(["developer_pat", "nova_oidc_token", None])
|
||||||
|
tty_st = st.booleans()
|
||||||
|
|
||||||
|
|
||||||
|
@given(flag=flag_st, env=env_st, cred=cred_st, tty=tty_st)
|
||||||
|
@settings(max_examples=200)
|
||||||
|
def test_deterministic(flag, env, cred, tty):
|
||||||
|
a = resolve_mode(flag=flag, env_var=env, credential_type=cred, stdin_isatty=tty)
|
||||||
|
b = resolve_mode(flag=flag, env_var=env, credential_type=cred, stdin_isatty=tty)
|
||||||
|
assert a == b
|
||||||
|
|
||||||
|
|
||||||
|
@given(flag=flag_st, env=env_st, cred=cred_st, tty=tty_st)
|
||||||
|
@settings(max_examples=200)
|
||||||
|
def test_flag_wins(flag, env, cred, tty):
|
||||||
|
mode, reason = resolve_mode(flag=flag, env_var=env, credential_type=cred, stdin_isatty=tty)
|
||||||
|
if flag in ("agent", "interactive"):
|
||||||
|
assert mode == flag
|
||||||
|
assert reason == "flag"
|
||||||
|
|
||||||
|
|
||||||
|
@given(env=env_st, cred=cred_st, tty=tty_st)
|
||||||
|
@settings(max_examples=200, suppress_health_check=[HealthCheck.function_scoped_fixture])
|
||||||
|
def test_invalid_env_ignored(env, cred, tty, caplog):
|
||||||
|
with caplog.at_level(logging.WARNING, logger="nova.mode_resolver"):
|
||||||
|
mode, reason = resolve_mode(flag=None, env_var=env, credential_type=cred, stdin_isatty=tty)
|
||||||
|
if env in ("auto", ""):
|
||||||
|
# invalid/empty env must fall through to credential-or-tty result
|
||||||
|
expected_mode, expected_reason = resolve_mode(flag=None, env_var=None, credential_type=cred, stdin_isatty=tty)
|
||||||
|
assert (mode, reason) == (expected_mode, expected_reason)
|
||||||
|
|
||||||
|
|
||||||
|
@given(flag=flag_st, env=env_st, cred=cred_st, tty=tty_st)
|
||||||
|
@settings(max_examples=200)
|
||||||
|
def test_no_silent_fallback(flag, env, cred, tty):
|
||||||
|
_, reason = resolve_mode(flag=flag, env_var=env, credential_type=cred, stdin_isatty=tty)
|
||||||
|
assert reason and reason.strip() != ""
|
||||||
|
|
||||||
|
|
||||||
|
@given(cred=st.sampled_from(["developer_pat", "nova_oidc_token"]), tty=tty_st)
|
||||||
|
@settings(max_examples=100)
|
||||||
|
def test_credential_tty_semantics(cred, tty):
|
||||||
|
mode, reason = resolve_mode(flag=None, env_var=None, credential_type=cred, stdin_isatty=tty)
|
||||||
|
if tty:
|
||||||
|
assert mode == "interactive"
|
||||||
|
else:
|
||||||
|
assert mode == "agent"
|
||||||
|
assert reason == f"credential:{cred}"
|
||||||
|
|
||||||
|
|
||||||
|
# --- Edge cases (explicit) ---
|
||||||
|
|
||||||
|
def test_edge_stdin_tty_true_with_credential_is_interactive():
|
||||||
|
"""Edge 3 analog: stdin is a TTY (even if stdout piped) → interactive."""
|
||||||
|
mode, reason = resolve_mode(flag=None, env_var=None, credential_type="developer_pat", stdin_isatty=True)
|
||||||
|
assert mode == "interactive"
|
||||||
|
assert reason == "credential:developer_pat"
|
||||||
|
|
||||||
|
|
||||||
|
def test_edge_missing_credential_falls_to_tty():
|
||||||
|
mode_no_tty, reason_no = resolve_mode(flag=None, env_var=None, credential_type=None, stdin_isatty=False)
|
||||||
|
mode_tty, reason_tty = resolve_mode(flag=None, env_var=None, credential_type=None, stdin_isatty=True)
|
||||||
|
assert mode_no_tty == "agent" and reason_no == "tty"
|
||||||
|
assert mode_tty == "interactive" and reason_tty == "tty"
|
||||||
|
|
||||||
|
|
||||||
|
def test_edge_conflicting_flag_env_flag_wins():
|
||||||
|
mode, reason = resolve_mode(flag="agent", env_var="interactive", credential_type="developer_pat", stdin_isatty=True)
|
||||||
|
assert mode == "agent" and reason == "flag"
|
||||||
|
|
||||||
|
|
||||||
|
def test_edge_env_wins_over_credential():
|
||||||
|
mode, reason = resolve_mode(flag=None, env_var="agent", credential_type="developer_pat", stdin_isatty=True)
|
||||||
|
assert mode == "agent" and reason == "env"
|
||||||
|
|
||||||
|
|
||||||
|
def test_edge_invalid_env_warns_and_falls_through(caplog):
|
||||||
|
with caplog.at_level(logging.WARNING, logger="nova.mode_resolver"):
|
||||||
|
mode, reason = resolve_mode(flag=None, env_var="auto", credential_type=None, stdin_isatty=False)
|
||||||
|
assert mode == "agent" and reason == "tty"
|
||||||
|
assert any("invalid" in rec.message.lower() for rec in caplog.records)
|
||||||
|
|
||||||
|
|
||||||
|
def test_resolve_mode_from_env_uses_argv_flag(monkeypatch):
|
||||||
|
monkeypatch.setattr("sys.argv", ["nova", "--mode", "interactive", "policy"])
|
||||||
|
monkeypatch.setenv("NOVA_CLIENT_MODE", "agent")
|
||||||
|
from core.mode_resolver import resolve_mode_from_env
|
||||||
|
mode, reason = resolve_mode_from_env(credential_type=None)
|
||||||
|
assert mode == "interactive" and reason == "flag"
|
||||||
|
|
||||||
|
|
||||||
|
def test_resolve_mode_from_env_uses_env_when_no_flag(monkeypatch):
|
||||||
|
monkeypatch.setattr("sys.argv", ["nova", "policy"])
|
||||||
|
monkeypatch.setenv("NOVA_CLIENT_MODE", "interactive")
|
||||||
|
from core.mode_resolver import resolve_mode_from_env
|
||||||
|
mode, reason = resolve_mode_from_env(credential_type=None)
|
||||||
|
assert mode == "interactive" and reason == "env"
|
||||||
@@ -0,0 +1,127 @@
|
|||||||
|
"""CAP-038 PAT revocation SLO test (REQ-351).
|
||||||
|
|
||||||
|
Issue a PAT → vend a token (succeeds) → revoke the PAT → vend a token
|
||||||
|
(403, reason ``pat_revoked``). Asserts the denial happens immediately
|
||||||
|
(D-229: the strong read on the main table is synchronous — the 60s SLO
|
||||||
|
is for propagation, which with strong reads is instant; assert <1s
|
||||||
|
locally). Uses moto for DynamoDB.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
import time
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
os.environ.setdefault("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
os.environ.setdefault("AWS_ACCESS_KEY_ID", "test")
|
||||||
|
os.environ.setdefault("AWS_SECRET_ACCESS_KEY", "test")
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
_TV_PATH = Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_token_vend.py"
|
||||||
|
_spec = importlib.util.spec_from_file_location("nova_idp_token_vend_rev", _TV_PATH)
|
||||||
|
tv = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(tv)
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
from moto import mock_aws
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
import core.pat_lifecycle as pat_life
|
||||||
|
|
||||||
|
|
||||||
|
class _MockKms:
|
||||||
|
def __init__(self, priv, pub_der):
|
||||||
|
self._priv = priv
|
||||||
|
self._pub_der = pub_der
|
||||||
|
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
return {"Signature": self._priv.sign(Message, ec.ECDSA(hashes.SHA256()))}
|
||||||
|
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": self._pub_der}
|
||||||
|
|
||||||
|
|
||||||
|
def _create_pats_table(ddb):
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-pats",
|
||||||
|
KeySchema=[{"AttributeName": "jti", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[{"AttributeName": "jti", "AttributeType": "S"}],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _reset():
|
||||||
|
tv._dynamodb = None
|
||||||
|
pat_life._dynamodb = None
|
||||||
|
yield
|
||||||
|
tv._dynamodb = None
|
||||||
|
pat_life._dynamodb = None
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_pat_revocation_slo():
|
||||||
|
"""Issue → vend (ok) → revoke → vend (403 pat_revoked) in <1s (REQ-351)."""
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub_der = priv.public_key().public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
|
||||||
|
# 1. Issue a PAT.
|
||||||
|
pat = pat_life.issue_pat("user-1", ["developer"], "t1", ttl_seconds=3600)
|
||||||
|
|
||||||
|
# 2. Vend a token — succeeds (PAT active + ABAC allow developer+dev).
|
||||||
|
body = {"token": pat, "environment": "dev"}
|
||||||
|
resp1 = tv.lambda_handler({"body": json.dumps(body)}, None)
|
||||||
|
assert resp1["statusCode"] == 200, resp1["body"]
|
||||||
|
assert "token" in json.loads(resp1["body"])
|
||||||
|
|
||||||
|
# 3. Revoke the PAT.
|
||||||
|
import base64
|
||||||
|
payload = json.loads(base64.urlsafe_b64decode(pat.split(".")[1] + "=="))
|
||||||
|
jti = payload["jti"]
|
||||||
|
t0 = time.monotonic()
|
||||||
|
pat_life.revoke_pat(jti)
|
||||||
|
|
||||||
|
# 4. Vend again — 403 pat_revoked, immediately (<1s SLO, D-229 strong read).
|
||||||
|
resp2 = tv.lambda_handler({"body": json.dumps(body)}, None)
|
||||||
|
elapsed = time.monotonic() - t0
|
||||||
|
assert resp2["statusCode"] == 403
|
||||||
|
assert json.loads(resp2["body"])["reason"] == "pat_revoked"
|
||||||
|
assert elapsed < 1.0, f"revocation took {elapsed:.3f}s — expected <1s (D-229 strong read)"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_pat_revocation_then_abac_still_denies():
|
||||||
|
"""After revocation, the denial reason is pat_revoked (not abac)."""
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub_der = priv.public_key().public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKms(priv, pub_der))
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
pat = pat_life.issue_pat("user-1", ["developer"], "t1", ttl_seconds=3600)
|
||||||
|
import base64
|
||||||
|
payload = json.loads(base64.urlsafe_b64decode(pat.split(".")[1] + "=="))
|
||||||
|
pat_life.revoke_pat(payload["jti"])
|
||||||
|
body = {"token": pat, "environment": "dev"}
|
||||||
|
resp = tv.lambda_handler({"body": json.dumps(body)}, None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "pat_revoked"
|
||||||
@@ -0,0 +1,195 @@
|
|||||||
|
"""E2E token-vend Lambda test (REQ-336, C-6.1) with moto + mock KMS.
|
||||||
|
|
||||||
|
Valid PAT (active) + ABAC allow → KMS-signed OIDC token returned.
|
||||||
|
Revoked PAT → 403. Unknown PAT → 403. ABAC deny → 403. The returned
|
||||||
|
JWT verifies with pyjwt + the mock public key.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import importlib.util
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
import time
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
os.environ.setdefault("AWS_DEFAULT_REGION", "us-east-1")
|
||||||
|
os.environ.setdefault("AWS_ACCESS_KEY_ID", "test")
|
||||||
|
os.environ.setdefault("AWS_SECRET_ACCESS_KEY", "test")
|
||||||
|
os.environ.setdefault("NOVA_LAMBDA_LOCAL_BYPASS", "1")
|
||||||
|
|
||||||
|
_SOURCE_PATH = (
|
||||||
|
Path(__file__).resolve().parent.parent / "core" / "lambda" / "nova_idp_token_vend.py"
|
||||||
|
)
|
||||||
|
_spec = importlib.util.spec_from_file_location("nova_idp_token_vend_e2e", _SOURCE_PATH)
|
||||||
|
tv = importlib.util.module_from_spec(_spec)
|
||||||
|
_spec.loader.exec_module(tv)
|
||||||
|
|
||||||
|
import boto3
|
||||||
|
from moto import mock_aws
|
||||||
|
import jwt as pyjwt
|
||||||
|
from cryptography.hazmat.primitives.asymmetric import ec
|
||||||
|
from cryptography.hazmat.primitives import hashes, serialization
|
||||||
|
|
||||||
|
import core.kms_signing as kms_signing
|
||||||
|
|
||||||
|
|
||||||
|
def _create_pats_table(ddb):
|
||||||
|
ddb.create_table(
|
||||||
|
TableName="nova-pats",
|
||||||
|
KeySchema=[{"AttributeName": "jti", "KeyType": "HASH"}],
|
||||||
|
AttributeDefinitions=[
|
||||||
|
{"AttributeName": "jti", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "sub", "AttributeType": "S"},
|
||||||
|
{"AttributeName": "pat_hash", "AttributeType": "S"},
|
||||||
|
],
|
||||||
|
GlobalSecondaryIndexes=[
|
||||||
|
{"IndexName": "sub-index", "KeySchema": [{"AttributeName": "sub", "KeyType": "HASH"}], "Projection": {"ProjectionType": "ALL"}},
|
||||||
|
{"IndexName": "pat_hash-index", "KeySchema": [{"AttributeName": "pat_hash", "KeyType": "HASH"}], "Projection": {"ProjectionType": "ALL"}},
|
||||||
|
],
|
||||||
|
BillingMode="PAY_PER_REQUEST",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _put_active_pat(ddb, jti="pat-active", sub="user-1", owner="t1", role="developer"):
|
||||||
|
ddb.put_item(
|
||||||
|
TableName="nova-pats",
|
||||||
|
Item={
|
||||||
|
"jti": {"S": jti},
|
||||||
|
"sub": {"S": sub},
|
||||||
|
"pat_hash": {"S": "hash-" + jti},
|
||||||
|
"status": {"S": "active"},
|
||||||
|
"issued_at": {"S": "2026-01-01T00:00:00Z"},
|
||||||
|
"expires_at": {"N": str(int(time.time()) + 3600)},
|
||||||
|
"claims": {"S": json.dumps({"sub": sub, "roles": [role], "owner": owner})},
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _make_pat_jwt(jti="pat-active", sub="user-1", role="developer", owner="t1"):
|
||||||
|
import base64
|
||||||
|
header = base64.urlsafe_b64encode(json.dumps({"alg": "none", "typ": "JWT"}).encode()).rstrip(b"=").decode()
|
||||||
|
payload = base64.urlsafe_b64encode(json.dumps({
|
||||||
|
"jti": jti, "sub": sub, "exp": int(time.time()) + 3600,
|
||||||
|
"iat": int(time.time()), "roles": [role], "owner": owner,
|
||||||
|
"typ": "developer_pat",
|
||||||
|
}).encode()).rstrip(b"=").decode()
|
||||||
|
return f"{header}.{payload}.sig"
|
||||||
|
|
||||||
|
|
||||||
|
def _vend_event(pat_jwt, env="dev", owner="t1"):
|
||||||
|
return {"body": json.dumps({
|
||||||
|
"token": pat_jwt, "environment": env,
|
||||||
|
"target_resource": {"type": "contract", "id": "c1", "owner": owner, "environment": env},
|
||||||
|
"requested_claims": ["sub", "roles"],
|
||||||
|
})}
|
||||||
|
|
||||||
|
|
||||||
|
class _MockKmsSign:
|
||||||
|
def __init__(self, priv, pub_der):
|
||||||
|
self._priv = priv
|
||||||
|
self._pub_der = pub_der
|
||||||
|
|
||||||
|
def sign(self, KeyId, Message, MessageType, SigningAlgorithm):
|
||||||
|
return {"Signature": self._priv.sign(Message, ec.ECDSA(hashes.SHA256()))}
|
||||||
|
|
||||||
|
def get_public_key(self, KeyId):
|
||||||
|
return {"PublicKey": self._pub_der}
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def test_keypair():
|
||||||
|
priv = ec.generate_private_key(ec.SECP256R1())
|
||||||
|
pub = priv.public_key()
|
||||||
|
pub_der = pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.DER,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
)
|
||||||
|
return priv, pub, pub_der
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(autouse=True)
|
||||||
|
def _reset():
|
||||||
|
tv._dynamodb = None
|
||||||
|
yield
|
||||||
|
tv._dynamodb = None
|
||||||
|
kms_signing.set_kms_client_for_testing(None)
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_valid_pat_abac_allow_vends_token(test_keypair):
|
||||||
|
priv, pub, pub_der = test_keypair
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKmsSign(priv, pub_der))
|
||||||
|
pat = _make_pat_jwt()
|
||||||
|
# ABAC allow: developer + dev
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat, env="dev", owner="t1"), None)
|
||||||
|
assert resp["statusCode"] == 200, resp["body"]
|
||||||
|
body = json.loads(resp["body"])
|
||||||
|
assert "token" in body
|
||||||
|
assert "expires_at" in body
|
||||||
|
# Verify the JWT with pyjwt + the test public key.
|
||||||
|
pem = pub.public_bytes(
|
||||||
|
encoding=serialization.Encoding.PEM,
|
||||||
|
format=serialization.PublicFormat.SubjectPublicKeyInfo,
|
||||||
|
).decode("ascii")
|
||||||
|
decoded = pyjwt.decode(body["token"], pem, algorithms=["ES256"], options={"verify_aud": False})
|
||||||
|
assert decoded["sub"] == "user-1"
|
||||||
|
assert decoded["typ"] == "nova_oidc_token"
|
||||||
|
assert decoded["roles"] == ["developer"]
|
||||||
|
assert "jti" in decoded and "iat" in decoded and "exp" in decoded and "iss" in decoded
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_revoked_pat_denied():
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb, jti="pat-r")
|
||||||
|
ddb.update_item(
|
||||||
|
TableName="nova-pats", Key={"jti": {"S": "pat-r"}},
|
||||||
|
UpdateExpression="SET #s = :v",
|
||||||
|
ExpressionAttributeNames={"#s": "status"},
|
||||||
|
ExpressionAttributeValues={":v": {"S": "revoked"}},
|
||||||
|
)
|
||||||
|
pat = _make_pat_jwt(jti="pat-r")
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "pat_revoked"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_unknown_pat_denied():
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
pat = _make_pat_jwt(jti="pat-missing")
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "pat_unknown"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_abac_deny_denied(test_keypair):
|
||||||
|
priv, _pub, pub_der = test_keypair
|
||||||
|
ddb = boto3.client("dynamodb", region_name="us-east-1")
|
||||||
|
_create_pats_table(ddb)
|
||||||
|
_put_active_pat(ddb)
|
||||||
|
kms_signing.set_kms_client_for_testing(_MockKmsSign(priv, pub_der))
|
||||||
|
pat = _make_pat_jwt()
|
||||||
|
# ABAC deny: developer + prod (developer not allowed in prod)
|
||||||
|
resp = tv.lambda_handler(_vend_event(pat, env="prod", owner="t1"), None)
|
||||||
|
assert resp["statusCode"] == 403
|
||||||
|
assert json.loads(resp["body"])["reason"] == "abac_denied"
|
||||||
|
|
||||||
|
|
||||||
|
@mock_aws
|
||||||
|
def test_missing_token_field():
|
||||||
|
resp = tv.lambda_handler({"body": json.dumps({"environment": "dev"})}, None)
|
||||||
|
assert resp["statusCode"] == 400
|
||||||
Reference in New Issue
Block a user