31 Commits

Author	SHA1	Message	Date
Jon Chery	f844feab7f	chore(bootstrap): migrate ACDL_* env vars to NOVA_* (complete the v1.15 P5 rename)	2026-08-12 21:09:11 +00:00
Jon Chery	e7866fda84	docs(P1): strategic docs — thesis rename + NORTH_STAR objectives + RACI restructure ... AUTONOMY_THESIS.md (git mv from NO_HUMANS_THESIS.md): reframe from 'removing humans' to 'autonomy in operations, human at stage gates'. Drop D-### citations + internal file paths; keep anti-claims, reworded. Anti-claim #1 now: 'decisions are NOT made by an LLM — deterministic scripts calculate a score; the platform functions without AI'. NORTH_STAR.md: - Vision: 'invisible' → 'visible' (operations become visible — recurring theme); polish for technical audience (security, remediation velocity, reliability, lead time). - Objective #2: 'provable trust in AI decisions' → 'provable trust in automated decisions' (deterministic scripts calculate a score; platform functions without AI). - Objective #3: four CTO-grade metrics (Lead Time PR→Prod, Infra Vuln Count trend, MTTR, Cloud Spend Reduction) → all flow into PowerBI. - Objective #4: 'default substrate for agentic consumption' → integrate with externally owned PDLC/SDLC/Agentic/Citizen Developer platforms regardless of source; Nova provides skills + MCP endpoints; all prod intents go through the same controls + quality gates. - Anti-goals: drop #1 (hyperscaler competitor), #4 (legacy untagged), #5 (sold to operators). Add: 'not an upstream development platform', 'not a replacement for the PDLC'. Reword #3 (no 'removes humans'). docs/raci.md: 3 roles → 4 roles. Add Quality Engineering column. Rename Release Management → SRE. Split release attestation into Quality attestation (QA) + Production readiness (SRE). Platform no longer holds A for attestation — reassigned to QE/SRE. docs/scope.md: add integration framing (skills + MCP endpoints, all sources go through same controls). Render scripts: default deck name → nova-autonomous-cloud-delivery. ONBOARDING + terraform/onboarding: 'no-humans' → 'autonomous'. ---ci--- project: acdl phase: 1 milestone: v1.21 status: execute phase_role: execution ---/ci---	2026-08-11 13:55:53 +00:00
Jon Chery	f83b974c0e	Merge milestone/v1.16-nova-simplification — v1.16 complete (Nova Simplification: 20-phase NFR sweep + final; tag v1.15.26)	2026-08-01 13:37:18 +00:00
Jon Chery	0e6ecae26d	feat(P4): Nova rebrand — AWS resource migration (REQ-163) ... Rename all acdl-* AWS resources → nova-* across terraform (DynamoDB, Secrets Manager, Lambda, SNS, SG, KMS alias, ECS, ECR, IAM user/policy, state bucket, ALB, VPC/subnet names). Lambda default table names → nova-* (D-111). State bucket backend → nova-tfstate (-migrate-state documented). New docs/NOVA_AWS_MIGRATION.md runbook (staged migration + rollback). New scripts/migrate_dynamodb_data.py (scan+copy, dry-run default). acdl-deploy- → nova-deploy- role ARN in deploy workflows. Test fixtures updated; terraform validate + pytest + run_ci.sh PASS. ---ci--- project: acdl phase: 4 milestone: v1.15 status: execute ---/ci---	2026-07-30 01:54:26 +00:00
Jon Chery	51c3edf458	feat(P3): Nova rebrand — SSM path + tag keys (REQ-161/162) ... SSM path /acdl/{env}/{contractId}/{output} → /nova/... across core/output_publisher + contract resolver + consumer docs. New scripts/migrate_ssm_paths.py (copy/verify/delete, dry-run default). AWS tag keys acdl:owner|environment|contract|cost-center|ref → nova:* across terraform tagging + ABAC session policies (iam:ResourceTag/acdl:* → iam:ResourceTag/nova:*). nova_tagging.py hard mode (D-109 warn→hard). tagging-standard.json tag-key values → nova:*. New scripts/untag_acdl_keys.py (remove old acdl:* tags, dry-run default). Test fixtures updated; pytest + run_ci.sh PASS. ---ci--- project: acdl phase: 3 milestone: v1.15 status: execute ---/ci---	2026-07-30 01:38:30 +00:00
Jon Chery	3b1181f39b	Merge milestone/v1.14-refinement — v1.14 complete (NFR Refinement: bug fixes, security, stubs, tests, docs; 20 phases + final; tag v1.13.24) ... v1.14 NFR Refinement milestone complete. 20 execution phases (P1-P20) + 1 final (P21). All P1/P2 backlog from v1.11 review resolved. Security posture hardened (swallowed errors, account ID externalized, IAM scoped, schema validation, credential hygiene). Stubs resolved (kyverno --kube- version removed). 7 untested scripts gained coverage. Documentation synced (ARCHITECTURE v1.11-v1.14 addenda, stale @v1.6-1.9 -> @v1.13, GRILL G-005/G-008 resolved, COST.md window extended, D-083 deferral recorded). Platform VPC parameterized. 561 tests pass (was 528 at v1.13.2; +33). 22/22 capabilities Verified. 6 grill binding decisions (G-101..G-106) applied. 1 escalation (E-001) auto-resolved at full autonomy (D-101). ---ci--- project: acdl phase: 21 milestone: v1.14 status: complete ---/ci---	2026-07-29 21:36:37 +00:00
Jon Chery	3e11b0fafd	Merge milestone/v1.11-restart — v1.11 complete (stateless adapter + pipeline-driven module lifecycle testing, P56a-P65) ... v1.11 closes G-005 (CAP-017..022 deploy-unverified → Verified via lifecycle pipeline) and G-008 (no cost docs → COST.md). Phases: - P56a: stateless adapter rewrite (918-line monolith → 196-line assembler) - P56b: 12 L1 module terraform subdirs authored - P57: shell orchestrator --apply/--destroy lifecycle modes - P58: single platform VPC + deterministic env-aware state keys - P59: L1 module lifecycle pipeline authored - P60: L1 lifecycle live run (retrofit — module fixes for live AWS) - P61: L2 lifecycle pipeline authored - P62: L2 lifecycle live run - P63: CAP-017..022 regression registry + COST.md - P64: pre-mortem + teardown (zero live resources) - P65: rewrite caps + decks 485 offline tests pass. All 12 requirements complete. Zero live ACDL resources remain (D-096 enforced). # Conflicts: # .ciagent/PERSONAS.md # .ciagent/REQUIREMENTS.md # .ciagent/ROADMAP.md # .ciagent/config.json	2026-07-29 12:32:50 +00:00
Jon Chery	ad3cc5f129	fix(ci): separate short-lived CI VPC + fix 8 module lifecycle failures ... Two architectural changes: 1. Created terraform/ci-vpc/ — a short-lived VPC for L1 module lifecycle testing, separate from the long-lived platform VPC. Created before VPC-dependent modules (alb, ecs-service, rds, uptime) are tested, destroyed after. Outputs (vpc_id, subnet_ids, sg_id, cluster_arn) are passed to those modules via scripts/run_lifecycle_test.sh + run_lifecycle_destroy.sh wrappers that inject the CI VPC outputs into the example contracts. 2. Updated the workflow to use ci-vpc-apply → lifecycle (with artifact passing) → ci-vpc-destroy (always runs). 8 module-specific fixes: - s3: unique bucket names (acdl-ci-s3a-simple/complex) instead of globally-taken 'my-simple-bucket' - kms-key: alias name with no spaces (locals.tf → alias/acdl-ci-kms) - iam-role: example contract uses role_name (not name, which the interface doesn't declare) - ecs-service: example contract uses family (not name); VPC inputs (cluster_arn, subnets, security_group) injected by CI VPC wrapper - uptime: added subnets, security_group, cluster_arn to interface + module; network_configuration is dynamic (only when subnets provided) - rds: added subnet_ids input + db_subnet_group resource (conditional on subnet_ids being non-empty) - alb: removed hardcoded placeholder sg/subnet values from examples; vpc_id + subnets + security_group injected by CI VPC wrapper - cloudfront: removed invalid placeholder WAF ARN from complex example Regression: 479 passed, 0 skipped, 5 deselected. All 24 example contracts pass --check-only. ---ci--- project: acdl phase: P59 milestone: v1.11 status: execute ---/ci---	2026-07-28 17:52:58 +00:00
Jon Chery	c4e94cf171	fix(terraform/platform): make Lambda conditional on zip existing ... The Lambda function's filename attribute (contract_ingestor.zip) fails during terraform apply when the zip doesn't exist (the lifecycle pipeline only needs the VPC, not the Lambda). Made the Lambda + Function URL conditional with count = fileexists('contract_ingestor.zip') ? 1 : 0. The source_code_hash also uses the fileexists guard. This lets the lifecycle pipeline apply only the VPC resources without requiring the Lambda zip build artifact. ---ci--- project: acdl phase: P59 milestone: v1.11 status: execute ---/ci---	2026-07-28 16:55:15 +00:00
Jon Chery	2f8c0203be	fix(terraform/platform): quote acdl: tags + fix Lambda + replace interpolation ... 3 fixes in terraform/platform/main.tf that prevented terraform validate from passing in CI: 1. All 40 acdl:owner/contract/environment/cost-center tag keys were unquoted (acdl:owner = ...). HCL requires quoting keys with colons. Fixed to "acdl:owner" = ... 2. filebase64sha256("contract_ingestor.zip") failed when the zip didn't exist (it's a build artifact). Wrapped with fileexists() guard. 3. ${account_id} and ${region} in the replace() call were interpreted as Terraform interpolation, not literal strings. Escaped as $${account_id} and $${region}. Platform terraform now passes terraform validate. ---ci--- project: acdl phase: P59 milestone: v1.11 status: execute ---/ci---	2026-07-28 16:42:17 +00:00
Jon Chery	fda4564a7f	feat(P58): single platform VPC + deterministic env-aware state keys ... EXECUTE stage. Fixes the 4-VPC bug: adds a single shared VPC to terraform/platform, drops the vpc child from the microservice composition (references the platform VPC via data source), and makes state keys env-aware (spike/{id}/{env}/terraform.tfstate — stable across lifecycle). Platform VPC (terraform/platform/main.tf): - aws_vpc.acdl_shared (10.0.0.0/16) + 2 subnets + IGW + route table + SG - Outputs: vpc_id, subnet_ids, ecs_security_group_id Microservice composition (modules/l2/microservice/composition.json): - Dropped the vpc child (no per-contract VPC ever again). - Added data_sources block: platform_vpc → terraform_remote_state (platform). - Wires: vpc.outputs.subnet_ids → platform_vpc.outputs.subnet_ids. - Wires: platform_vpc.outputs.vpc_id → alb.inputs.vpc_id. - Wires: platform_vpc.outputs.ecs_security_group_id → service.inputs.security_group. Contract resolver (core/contract_resolver.py): - Added environment to the stack instance (stack.environment). - Added data_sources handling: pseudo-children with outputs but no resources. - data_sources propagated through fragment merge to the final stack instance. Adapter (adapters/terraform/adapter.py): - State key: spike/{stack_name}/{environment}/terraform.tfstate (env-aware). - Emits data "terraform_remote_state" "platform" block when data_sources present. - ref:platform_vpc.<output> → data.terraform_remote_state.platform.outputs.<output>. Tests (tests/test_adapter.py): - test_adapt_env_aware_state_key: spike/msvc/prod/terraform.tfstate. - test_adapt_emits_data_source_block: data.terraform_remote_state.platform. - test_adapt_no_vpc_for_microservice: no resource "aws_vpc" in microservice output. - Updated existing state key assertion (spike/s3/dev/terraform.tfstate). Regression: 467 passed, 0 skipped, 5 deselected. run_platform.sh --check-only passes for both microservice (9 resources, no VPC) and static-assets (5 resources). ---ci--- project: acdl phase: P58 milestone: v1.11 status: execute ---/ci---	2026-07-28 16:07:57 +00:00
Jon Chery	e5d8dadbd4	feat(P56): IAM re-bootstrap live step — managed policy + OIDC role ... D-095 RESOLVED. User provided fresh root credentials in .env.secrets; the run resumed and applied the IAM baseline against account 581513795199. Live actions (2026-07-28): 1. Converted spike_runner_policy.json from an inline user policy to a customer-managed policy acdl-spike-runner-policy (ARN arn:aws:iam::581513795199:policy/acdl-spike-runner-policy). The extended policy (5917 bytes) exceeded the 2048-byte inline limit; the managed-policy path supports 6144 bytes per version + 5 versions. Inline policy deleted; managed policy attached. 2. Re-created the acdl-act-runner-role OIDC role (CAP-022 — was gone since Phase 08). Trust policy permits root assume until go-gitea/gitea#36988 merges real OIDC federation. Same managed policy attached so the runner inherits spike-runner-equivalent permissions, no long-lived key needed. Grant verification (all OK): - cloudfront:ListDistributions — OK (0 items, stacks not yet deployed) - wafv2:ListWebAcls(CLOUDFRONT) — OK - lambda:ListFunctions — OK - dynamodb:DescribeTable(acdl-contracts) — ResourceNotFound (table not yet created — Phase 57 applies it; grant works, no AccessDenied) - ce:GetCostAndUsage (7-day window) — OK (7 results — Phase 59 queries the full window) - secretsmanager:ListSecrets — OK - sns:ListTopics — OK - iam:GetRole(acdl-act-runner-role) — OK terraform/bootstrap/apply_iam_baseline.py — new idempotent script that records the live step (create/version managed policy, attach to user + role, delete leftover inline, ensure runner role). Re-ran to confirm idempotency (created v2, deleted v1). .ciagent/IAM_POLICY.md — updated with the managed-policy note, the OIDC role ARN + trust policy, the grant verification table, and the D-095 resolution note. terraform/bootstrap/README.md — added the v1.11 Phase 56 section documenting apply_iam_baseline.py. Baseline test: 15/15 pass. ---ci--- project: acdl phase: 56 milestone: v1.11 status: execute escalation: type: deploy id: D-095 status: resolved resolved_at: 2026-07-28 resolution: user provided fresh root credentials in .env.secrets; managed policy applied + OIDC role re-created ---/ci---	2026-07-28 13:01:28 +00:00
Jon Chery	7eec07fc15	feat(P56): IAM re-bootstrap — policy extension + IAM_POLICY.md + baseline test ... Vertical slice 1 of Phase 56 (REQ-116). Offline-testable deliverables landed; the live IAM apply step is escalated (D-095) below. terraform/bootstrap/spike_runner_policy.json — extended with the minimum permissions to terraform apply + probe CAP-017..022: - cloudfront:* (CAP-020 static-assets stack) - wafv2:* (CAP-020 WAF ACL) - lambda:* on function:acdl-* (CAP-018 contract-ingestor) - dynamodb:* on acdl-contracts + acdl-change-requests (CAP-017) - secretsmanager:GetSecretValue on secret:acdl/* (CAP-018 github-token) - sns:* on acdl-* (CAP-017 acdl-sod-halt) - ce:Get* (REQ-119 Cost Explorer read-only) - kms:* (CAP-017 platform + per-stack CMKs) - iam:CreateOpenIDConnectProvider + iam:CreateRole (CAP-022 OIDC re-create) .ciagent/IAM_POLICY.md — new baseline document. Original grants (v1.1–v1.10) + v1.11 grants table + least-privilege scoping notes + OIDC act_runner role plan + D-095 escalation note. tests/test_iam_policy_baseline.py — 15 tests. Asserts the required actions are present per service group, Lambda scoped to acdl-*, CE read-only, no iam:PassRole to Resource:*, DynamoDB acdl-contracts in resource. Regression-testable: any future permission drift surfaces as a test failure at milestone COMPLETE (D-091 gate). Test results: 15/15 pass. Full offline suite 509/509 pass (pre-existing test_seeded_registry_runs_and_reports_honest_status in test_verify_regression_mode.py hangs without AWS creds — environmental, not introduced here). ---ci--- project: acdl phase: 56 milestone: v1.11 status: execute escalation: type: deploy id: D-095 reason: ACDL_BOOTSTRAP_AWS_* not set in the execution environment blocking: live IAM policy apply (aws iam put-user-policy) + OIDC role re-creation (CAP-022) — requires an admin AWS principal action_required: provide fresh ACDL_BOOTSTRAP_AWS_ACCESS_KEY_ID + ACDL_BOOTSTRAP_AWS_SECRET_ACCESS_KEY to the run environment, then re-invoke ciagent-run to resume Phase 56 live step fallback: none (D-095 confirmed: escalate to human, no silent fallback to the deck-marking path) ---/ci---	2026-07-28 12:44:31 +00:00
Jon Chery	7585c828f0	docs(P48): vision gaps + badge system + substrate→engine + CR format + agentic tags ... 9 requirements implemented across presentation decks and project docs: 1. DX closing slide: added 'Infrastructure as a utility, not a craft' bullet to convey the full vision (infrastructure consumed, not maintained; platform compounds value over time). 2. PW Problem slide: 'moving a merged change' → 'promoting a change'. 3. PW Problem slide: added 'Red tape' and 'Scalability without increasing headcount' bullets (4 frictions, not 2). 4. PW Roadmap slide: redesigned with side-by-side HTML table layout (Testing | Planned), 16px font, no overflow. 5. PW deck: added new slide 'What This Platform Is — and Isn't' after North Star (sovereign boundary, infrastructure as utility, 4 anti-goals). PW deck now 16 slides (was 15). 6. Maturity nomenclature: 'Available today'/'shipped' → 'Testing' across both decks + source markdown. New .testing badge (blue/teal #DBEAFE). Roadmap title: 'Testing vs. Planned'. The platform has 0 consumer adoption — 'shipped' was inaccurate. 7. Global: 'substrate' → 'engine' across entire project (88 matches, 30+ files including .ciagent/, docs/, modules/, adapters/, schemas/, code). 8. Presentation files only: 'forge' → 'VCS' / 'version control system' (6 occurrences in 4 files). 'forge' retained in all technical docs and code as the industry-standard term. 9. New .agentic badge (purple/violet #EDE9FE) appended to agentic features in both decks: confidence signal, autonomous dev, pattern recognition, dynamic module creation, citizen developer surface, auto-promotion. Also: Change Request ID format changed from 'CR-2026-001' to 'CHG0678912' across presentation files, consumer guide, and test fixtures. HTML re-rendered. PPTX rendered for release upload. ---ci--- phase: 48 milestone: v1.9 status: complete requirements: covered: [] partial: [] ---/ci---	2026-07-23 14:58:29 +00:00
Jon Chery	e74a8c2f5d	feat(P42): stub implementation — SoD, HITL gates, attestation matrix, Wiz, Kyverno ... ---ci--- project: acdl phase: 42 milestone: v1.9 status: execute ---/ci--- Phase 42 — stub-implementation (REQ-107..111, D-084): route_halt_artifact (REQ-107): - core/separation_of_duties.py: real SNS publish (ACDL_SOD_HALT_TOPIC_ARN) + outbox fallback (SEPARATION_OF_DUTIES_VIOLATION event via outbox_writer) + stderr emission. No silent print-only stub. - terraform/platform/main.tf: aws_sns_topic.acdl-sod-halt + output. HITL attestation gates (REQ-108): - core/hitl_gates.py: attest(contract_id, env, approver, evidence, outbox_client) records approver_qa/approver_prod/approver_dr to outbox, runs SoD check on prod, invokes attestation matrix, returns (ok, reason). Dev skips (autonomous). approver_from_env() reads GITHUB_ACTOR/GITEA_ACTOR. - scripts/run_platform.sh: Step 7b HITL gate before apply for qa/prod/dr. 8-concern attestation matrix (REQ-109, D-084): - core/attestation_matrix.py: check(env, evidence) runs the 8 concerns from hitl_matrix_design.md §10.4. Offline-testable (contract_nfrs, schema_validity, policy_pass) run for real. Operator-supplied accept signed artifacts validated for freshness (FRESHNESS_DAYS table) + schema. Signature skip when ACDL_ATTESTATION_SIGNING_KEY_ID unset (D-089). Fail loud if missing/expired for prod/dr. Wiz real client (REQ-110): - adapters/wiz/wiz_adapter.py: WizClient (GraphQL API, Bearer auth, pagination via pageInfo.hasNextPage + endCursor). fetch_and_adapt translates issues → PolicyCheckResult; graceful degrade when WIZ_API_TOKEN/WIZ_API_URL unset. Kyverno fleshed out (REQ-111): - adapters/kyverno/kyverno_adapter.py: full PolicyReport → PolicyCheckResult mapping (pass/fail/skip/warn + severity + skip-with- reason + resource ref construction from kind/name/namespace). adapt_inactive() emits KYVERNO_INACTIVE_TF_STACK guard. --kube-version stub parsed for future GitOps. Tests: +47 (test_route_halt_artifact.py, test_hitl_gates.py, test_attestation_matrix.py, test_wiz_adapter_real_client.py, expanded test_kyverno_adapter.py). Existing wiz_adapter tests updated for the real client's control.name ruleId. 493 passed; run_ci.sh green; run_platform.sh --check-only green.	2026-07-23 04:40:44 +00:00
Jon Chery	134f85d2df	feat(P34): decommission alias + CMDB validation (REQ-92, REQ-93, REQ-94) ... ---ci--- project: acdl phase: 34 milestone: v1.8 status: execute ---/ci--- - DynamoDB acdl-change-requests table added to terraform/platform/main.tf (PK changeRequestId, SK submittedAt, SSE via CMK, PITR). - validate_change_request Lambda action added to contract_ingestor.py: queries CMDB, asserts status=approved + consumerRepo match. - decommission_transform() added to contract_resolver.py: zeroes all counts (desired_count, min/max_capacity) + sets deletion_protection=false. - Decommission mode added to deploy pipeline + both deploy workflows (mode: decommission + changeRequestId input). Byte-identical. - run_platform.sh --decommission flag: validates CR, resolves with deletion_protection=false (step 1), then decommission_transform (step 2). HITL SRE gates documented. - docs/consumer-guide.md: new "Decommissioning a stack" section with CR request, trigger, 2-step HITL SRE gates, CMK deletion window, uptime. Tests: +14 (318 -> 332). All pass.	2026-07-22 22:18:28 +00:00
Jon Chery	1e4133e11a	fix(P30): temp dir isolation + forge-agnostic APIs + static-key override (P1-8, P1-9, S1) ... ---ci--- project: acdl phase: 30 milestone: v1.8 status: execute ---/ci--- P1-8: run_platform.sh now emits adapter output to $WORK/tf (per-run temp dir), not the committed terraform/spike/ directory. The committed terraform/spike/*.tf files are removed — they were scratch artifacts. Deploy workflow artifact upload path updated to /tmp/acdl_platform_run_v18/tf/. P1-9: contract_ingestor.py now reads GITHUB_API_BASE env for forge-agnostic API URLs. _forge_type() detects GitHub vs Gitea. Search URL is branched (GitHub uses /search/issues, Gitea uses /repos/{owner}/{repo}/issues). S1: Deploy workflow configure-aws-credentials step restructured as a single conditional step. OIDC when no static key (role-to-assume), static-key when ACDL_AWS_ACCESS_KEY_ID present (access-key-id/secret-access-key inputs). Both deploy workflows remain byte-identical. Tests: +8 (292 -> 300). All pass. run_platform.sh --check-only green.	2026-07-22 22:08:23 +00:00
Jon Chery	843cd17b97	fix(P29): SSM fail-loud without CMK + Terraform-rendered invoke policy (P1-3, P1-6) ... ---ci--- project: acdl phase: 29 milestone: v1.8 status: execute ---/ci--- P1-3: SSM publisher now raises RuntimeError when ACDL_KMS_KEY_ID is unset. ACDL_ALLOW_DEFAULT_KMS=1 escape hatch for local testing. P1-6: consumer_invoke_policy.json now uses ${account_id} and ${region} placeholders. Terraform renders them via data.aws_caller_identity + data.aws_region + replace() at apply time. No more hardcoded 000000000000. Tests: +7 (285 -> 292). All pass.	2026-07-22 22:05:40 +00:00
Jon Chery	0eb578c606	fix(P28): WAF nested rules + default_action + resolver outputs (P1-4, P1-5, P1-7) ... ---ci--- project: acdl phase: 28 milestone: v1.8 status: execute ---/ci--- P1-4: WAF custom rules now emit nested `rules { ... }` blocks per rule instead of `rules = [...]` attribute syntax (invalid HCL). P1-5: WAF default_action input is honored (allow/block) instead of hardcoding `allow {}`. Default is `allow` when absent (backward compat). P1-7: L2 composition outputs[] array is now processed by resolve_l2(). The resolver builds stack.outputs from the composition outputs wires. The adapter emits `output` blocks from stack.outputs. Tests: +10 (275 -> 285). All pass. run_platform.sh --check-only green.	2026-07-22 22:03:54 +00:00
Jon Chery	07c0349131	feat(P24): platform Lambda + DynamoDB contract ingestion + cross-account IAM ... Phase 24 — platform-lambda-and-contract-ingestion. - core/lambda/contract_ingestor.py: AWS Lambda handler invoked via Function URL (IAM auth). Parses JSON body, validates required fields, writes the contract to DynamoDB table acdl-contracts (PK consumerRepo, SK contractId#submittedAt, status submitted, ISO-8601 submittedAt). report_error action is a stub returning "error_report_prepared"; GitHub issue creation is wired in Phase 25. Returns 400 on missing fields / unknown action, 500 on error. Table name + GitHub-token secret ID come from env (set by Terraform). - core/lambda/__init__.py: empty package marker. - terraform/platform/main.tf: DynamoDB acdl-contracts (PITR, SSE via CMK), KMS customer-managed key with alias/acdl-platform, Secrets Manager secret acdl/github-token, IAM execution role (DynamoDB write + Secrets Manager read + KMS decrypt + CloudWatch logs), Lambda acdl-contract-ingestor (Python 3.12, handler contract_ingestor.lambda_handler), Function URL with AWS_IAM auth. State key platform/terraform.tfstate (distinct from spike/microservice). - terraform/platform/README.md: documents what it deploys, the state key, how to apply, and the cross-account invocation model. - terraform/platform/consumer_invoke_policy.json: ABAC-scoped policy template applied to consumer deploy roles during onboarding; grants lambda:InvokeFunctionUrl conditioned on aws:PrincipalTag/acdl:owner == consumerRepo. - tests/test_contract_ingestor.py: 11 tests (moto-backed DynamoDB mock) covering submit_contract put_item shape, report_error stub, missing-field 400, unknown action 400, the lambda_handler wrapper with a Function-URL-style event, dict body, default action, and internal-error 500. - docs/environments/index.md: new section documenting the cross-account contract-ingestion grant (one-way consumer→platform, D-051) and that onboarding now also grants the consumer deploy role InvokeFunctionUrl. - scripts/run_ci.sh, pipelines/ci.yaml, .gitea/workflows/ci.yml, .github/workflows/ci.yml: add core/lambda/contract_ingestor.py to the lint py_compile list. The two workflow YAMLs remain byte-identical. Verification: scripts/run_ci.sh passes all 3 stages (lint/test/check-only); python3 -m pytest tests/ -v passes all 213 tests (11 new + 202 existing). ---ci--- project: acdl phase: 24 milestone: v1.7 status: execute ---/ci---	2026-07-22 20:04:10 +00:00
Jon Chery	dca35c78ec	feat(P22): rename static-asset→static-assets + cloudfront/waf primitives + production stack + @v1.6 bump ... ---ci--- phase: 22 title: rename-and-production-static-assets-stack status: complete verification: - scripts/run_ci.sh: PASS (CI PIPELINE OK) - python3 -m pytest tests/ -v: 175 passed - scripts/run_platform.sh --check-only: PASS (PLATFORM CHECK OK) - grep -R "static-asset[^s]" . (excl .git/): 0 hits - grep -R "static-asset$" . (excl .git/): 0 hits - floating git tags v1.6 + v1 point at v1.6.0 (a90a756) changed_files: - Task 1 (rename): contracts/static-asset.yaml→static-assets.yaml (git mv); modules/l2/static-asset→static-assets (git mv); sed replaceAll static-asset→static-assets in 22 files (README, docs, scripts/run_platform.sh, pipelines/deploy.yaml, modules/registry.json, tests/*, .ciagent/* historical narrative) - Task 2 (cloudfront primitive): modules/l1/cloudfront/interface.json + README.md - Task 3 (waf primitive): modules/l1/waf/interface.json + README.md - Task 4 (registry): modules/registry.json (+cloudfront, +waf, static-assets renamed) - Task 5 (augment static-assets): modules/l2/static-assets/composition.json (s3+cloudfront+waf, depth 1); modules/l1/s3/interface.json +instance.json (+bucket_regional_domain_name output); modules/l2/static-assets/README.md (production stack docs) - Task 6 (adapter): adapters/terraform/adapter.py (+TYPE_MAP/INPUT_MAP/OUTPUT_MAP for cloudfront distribution+OAC+wafv2 webacl; special handling in _emit_resource for OAC defaults, distribution origin/cache_behavior/restrictions/viewer_certificate/web_acl_id, waf scope/default_action/visibility_config/managed rules) - Task 7 (contract schema): no change needed (generic inputs object; new module names match ^[a-z][a-z0-9-]*$) - Task 8 (@v1.6 bump): contracts/static-assets.yaml, .gitea/.github/workflows/deploy.yml (ref: v1.6 + header comments), docs/consumer-guide.md, docs/contracts/index.md, docs/pipeline/versioning.md, docs/pipeline/index.md, docs/architecture.md, README.md, modules/l2/microservice/README.md, tests/test_environment_check.py, tests/test_pipeline_contract.py - Task 9 (floating tags): git tag -f v1.6 v1.6.0; git tag -f v1 v1.6.0 - Task 10 (tests): tests/test_adapter.py (registry 11 entries/9 L1/2 L2; cloudfront+waf type map tests; TestS3Output bucket_regional_domain_name; TestStaticAssetsStack 4 tests); tests/test_contract_resolver.py (+s3/cloudfront/waf resource assertions) generated: - terraform/spike/main.tf + terraform.tf (regenerated by run_platform.sh --check-only; reflect static-assets production stack + backend key spike/static-assets/) notes: - D-048 full rewrite of .ciagent/ historical narrative (verbatim phase descriptions, REQ-25/27/50, D-036) — produces intentional tautologies (e.g. "Rename static-assets → static-assets") per the decision to override the v1.6 preservation precedent. - cloudfront interface.json resources array ordered distribution-first so the resolver (first-match wire resolution) routes bucket_regional_domain_name/waf_web_acl_arn/region to the distribution; the OAC gets adapter-provided defaults (name=acdl-oac, origin_type=s3, signing_behavior=always). - .ciagent/ @v1.4 references left as historical record (D-048 scope was static-asset rename only; @v1.4 is historical narrative of Phase 20). - s3 OUTPUT_MAP bucket_regional_domain_name not added (identity fallback in adapt() already handles it; OUTPUT_MAP documents non-identity mappings only). ---ci---	2026-07-22 19:56:52 +00:00
Jon Chery	f68f85c9fd	review(v1.5): READY TO SHIP — multi-persona code review ... ---ci--- project: acdl phase: 20 milestone: v1.5 status: review verdict: READY TO SHIP p0: 1 (fixed — contract path resolution in deploy workflow) p1: 6 (flagged post-hoc) ---/ci--- Multi-persona review of v1.5 phase 20 (docs + reusable deploy workflow). P0 (blocking) — AUTO-FIXED: - C1: scripts/run_platform.sh contract path resolution broken in deploy workflow. The reusable workflow invokes run_platform.sh from the consumer workspace root with a relative contract path (.acdl/contract.yaml), but run_platform.sh does `cd "$ROOT"` (platform repo) early, so the relative path resolved against the platform repo and the pipeline could never run. Fix (commit 75c2274): capture CALLER_CWD before cd "$ROOT"; resolve caller-supplied relative paths against CALLER_CWD; default no-arg contract stays relative to ROOT (preserves platform-local CI). Reproduced pre-fix; verified post-fix. P1 (important) — FLAGGED FOR POST-HOC REVIEW (do not block ship): - C2: ref: v1.4 in the deploy workflow platform checkout — no v1.4 tag exists (only v1.4.0 / v1.4.1). Operator must create a floating v1.4 tag or change the ref to v1.4.1. - C3: modules/l2/{static-asset,microservice}/README.md still use @v1 in their Usage examples; missed by the v1.4 bump. - S1: static-key override is not wired. ACDL_AWS_* env vars on the OIDC step are not read by aws-actions/configure-aws-credentials@v4 (it reads AWS_* or its own access-key/secret-key inputs). The README/CONSUMER_GUIDE claim a working override that doesn't function as written. Needs a conditional step or renamed env vars + input wiring. - S2: README overstates ABAC repo:org/repo:ref:... scoping. The workflow constructs a numeric role name (github.repository_id); the actual claim enforcement lives in the IAM trust policy, not in this workflow. - T1: no deploy-workflow triggers conformance test (CI workflow has one; deploy doesn't). Minor — reusable workflows use workflow_call, not push triggers, but the contract's triggers field is then unenforced. - A1: terraform/spike/terraform.tf uploaded as artifact leaks the AWS account ID via the state-backend bucket name. Recommend excluding terraform.tf or gating artifact upload to non-public repos. P2 (nits) — listed for awareness: floating-tag terminology imprecision (M1), header comment "Gitea Actions" in the GitHub copy (M2, intentional byte- identical), pip install split (P1-perf), comment drift in pipelines/deploy.yaml header (C4), module README internal inconsistency (C5). Verdict: READY TO SHIP. The one P0 is fixed. The 6 P1s are post-hoc items — the deploy workflow is a scaffold whose first real consumer run requires operator setup (tag, IAM role, secrets) that gates go-live. The P1s should be addressed before any consumer invokes uses: acdl/.gitea/workflows/ deploy.yml@v1.4 in earnest. Tests: 154 pass (19 new). run_ci.sh green.	2026-07-22 17:24:28 +00:00
Jon Chery	1598c54a8b	feat(P18): testing + CI/CD pipelines - pytest suite, check-only mode, Gitea + GitHub workflows (v1.3.2) ... 90 offline tests covering adapter, confidence_signal, checkov_adapter, outbox_writer, and pipeline integration. Identical CI/CD workflows for Gitea Actions (dev) and GitHub Actions (production). New --check-only mode for run_platform.sh (offline, no AWS). ---ci--- project: acdl phase: 18 milestone: v1.3 status: verify ---/ci---	2026-07-22 14:26:11 +00:00
Jon Chery	f874879973	fix: compress spike_runner_policy.json to fit AWS 2048-char inline limit ... ---ci--- project: acdl phase: 0 milestone: v1.2 status: fix ---/ci--- The expanded policy (4727 chars pretty / 3464 compact) exceeded the AWS 2048-char inline policy limit (total across all inline policies on a user). Compressed to 1667 chars by: (1) removing DenyEverythingElse (redundant — IAM is default-deny; the user has no other inline policies), (2) using action-prefix wildcards (ecs:Create*, ecr:Get*, etc.) instead of listing every action, (3) removing SIDs. The compressed policy grants the same effective permissions. The repo file now matches what should be applied in the AWS Console.	2026-07-22 13:42:44 +00:00
Jon Chery	699aa542df	docs(P15): plan-as-execute + verify (v1.2.5, PARTIAL — terraform apply blocked by IAM) ... ---ci--- project: acdl phase: 15 milestone: v1.2 status: verify verdict: PARTIAL requirements: covered: [REQ-34] partial: [REQ-33] blocker: - id: P0-IAM description: terraform apply fails with AccessDenied on ECS/ECR/IAM/EC2 — live spike_runner_policy.json not pushed (root key deactivated per D-034) unblock: operator runs create_iam_user.py with root/admin creds to push the expanded policy, then terraform apply succeeds (plan valid, 13 to add) ---/ci--- Phase 15 plan-as-execute + verify. PARTIAL: terraform apply blocked by IAM. - Consumer microservice content authored (app.py + Dockerfile + README.md). - Docker image acdl-microservice:latest built. - Adapter fixed: ref emission (bare), JSON-string jsonencode, ECS service network_configuration/load_balancer/desired_count/launch_type/task_definition, listener default_action/load_balancer_arn, target group target_type/vpc_id/protocol, VPC tags (not name), IGW + route table association, managed_policy_arns list. - L1 fixes: l1-ecs-service (removed port from service sub-resource), l1-vpc (added intra_refs, removed igw_id output). - Resolver: intra_refs resolution (refs between sub-resources of same L1). - terraform validate + plan succeed (13 to add). - terraform apply BLOCKED (AccessDenied — live IAM policy not updated). - Evidence event TERRAFORM_APPLY_BLOCKED written to DynamoDB outbox. - v1.1 S3 regression: byte-identical. Ready to ship v1.2.5 (partial).	2026-07-21 22:21:36 +00:00
Jon Chery	0fea29cdbb	docs(P12): plan-as-execute + verify (v1.2.2) ... ---ci--- project: acdl phase: 12 milestone: v1.2 status: verify verdict: VERIFIED requirements: covered: [REQ-30] ---/ci--- Phase 12 plan-as-execute + verify. scripts/verify_phase12.sh green (22 assertions). All Wave 1 + Wave 2 tasks complete: - T-12.1: run_spike_*.sh -> run_platform.sh (D-048, --plan-only flag) - T-12.2: spike_runner_policy.json expanded (ECS + ECR + ELB + IAM + EC2) - T-12.3: idempotency documented in bootstrap scripts - T-12.4: P1-1 redacted (no live AWS key IDs in .ciagent/) - T-12.5: P1-B fixed (PERSONAS.md platform/registry -> modules-ir/registry.json) Subagent confirmed run_platform.sh --plan-only runs against real AWS, exit 0. Ready to ship v1.2.2.	2026-07-21 21:01:51 +00:00
Jon Chery	622abe015b	phase: 10, status: plan-as-execute, persona: backend-engineer, task: T-10.4+T-10.5+T-10.7 ... ---ci--- project: acdl phase: 10 milestone: v1.1 status: plan-as-execute persona: backend-engineer task: [T-10.4, T-10.5, T-10.7] requirements.covered: [REQ-27] ---/ci--- Wave 2: contract + resolver + outbox writer. - T-10.4: contracts/spike.yaml - the spike contract (stack: l2-static-asset, environment: dev, inputs bucket_name + region). D-P10-2: YAML consumer surface; the resolver parses YAML -> validates against the JSON contract schema. - T-10.5: acdl_platform/contract_resolver.py - resolve(contract_path) -> IR instance. 7 steps: load YAML, validate contract schema, look up L2 in registry, load composition.json, map inputs through wires, emit IR instance, validate IR against ir.schema.json. Verified end-to-end: spike.yaml -> IR instance with kind=l2, one l1-s3 resource, validates against ir.schema.json. - T-10.7: acdl_platform/outbox_writer.py - write_event(event) -> DynamoDB put_item. SHA-256 over canonical JSON, prev_event_hash=GENESIS for the first event (D-P10-3), PK contractId, SK eventType#eventTs, TTL expire_at = now + 365d (D-044). stdlib + boto3. Also regenerated terraform/spike/{main.tf,terraform.tf} by running the adapter against the resolved L2 IR (the backend key is now spike/l2-static-asset/terraform.tfstate, derived from the stack name per D-P10-1).	2026-07-21 19:35:10 +00:00
Jon Chery	3070a68e1d	phase: 9, status: plan-as-execute, persona: platform-engineer, task: T-9.5..T-9.7+T-9.9 ... ---ci--- project: acdl phase: 9 milestone: v1.1 status: plan-as-execute persona: platform-engineer task: [T-9.5, T-9.6, T-9.7, T-9.9] requirements.covered: [REQ-26] ---/ci--- Waves 2+3: Terraform adapter + generated spike TF + run script. - T-9.5: adapters/terraform/adapter.py - compiles an IR instance to a Terraform root module. TYPE_MAP {aws:s3:bucket -> aws_s3_bucket}. Thin layer; does not own L1 content. Emits main.tf (resource + outputs) + terraform.tf (required_version/providers + S3 backend, NO dynamodb_table per D-P09-1) + providers.tf (aws provider region from the IR). CLI: adapter.py <ir_instance.json> <out_dir>. - T-9.6: terraform/spike/{main.tf,terraform.tf,providers.tf} - generated by running the adapter against modules-ir/l1/l1-s3/spike_instance.json. Committed so verify_phase09.sh can validate/plan without regenerating (D-P09-4); the verify script will regenerate + diff to prove reproducibility. - T-9.7: scripts/run_spike_plan.sh - loads rotated spike key from gitignored .env.secrets, exports AWS env vars, cd terraform/spike, terraform init -lock=false, terraform validate, terraform plan -lock=false -out=tfplan. Plan-only; no apply. - T-9.9: .gitignore - add terraform/spike/.terraform/ + tfplan + *.tfstate*. EXECUTE: ran scripts/run_spike_plan.sh against real AWS via the rotated spike key (D-039). terraform plan succeeded: 1 to add (the S3 bucket), outputs computed. One non-blocking deprecation warning (aws_s3_bucket versioning block -> use aws_s3_bucket_versioning in v1.2). No long-lived credential in the workflow (key loaded from .env.secrets at runtime).	2026-07-21 19:15:10 +00:00
Jon Chery	1d5c4d2ae7	phase: 8, status: plan-as-execute, persona: platform-engineer+lead-developer, task: T-8.5..T-8.7 ... ---ci--- project: acdl phase: 8 milestone: v1.1 status: plan-as-execute persona: platform-engineer+lead-developer task: [T-8.5, T-8.6, T-8.7] requirements.covered: [REQ-23] ---/ci--- Waves 3+4: rotation script + verify script + README + .gitignore. - T-8.5 (platform): scripts/rotate_spike_key.sh - boto3 with bootstrap root key from env (ACDL_BOOTSTRAP_AWS_*); creates new key for acdl-spike-runner, deactivates+deletes old, writes new to gitignored .env.secrets (chmod 600); idempotent (re-run ends with exactly 1 active key); optional Gitea secret upload if ACDL_GITEA_TOKEN set; does NOT rotate the root key (D-034 closure = manual user step). - T-8.6 (lead): scripts/verify_phase08.sh - loads rotated key from .env.secrets, asserts caller identity is acdl-spike-runner (not root), S3 bucket + DynamoDB table + IAM user + scoped policy with DenyEverythingElse all present, .env.secrets + .bootstrap_state.json gitignored. Uses heredoc python to avoid bash quoting issues. - T-8.7 (lead): terraform/bootstrap/README.md runbook (6 steps incl. manual D-034 root-key rotation) + .gitignore (.env.secrets + .bootstrap_state.json). Spike vs v1.2 boundary table. bash -n + gitignore checks pass.	2026-07-21 19:00:08 +00:00
Jon Chery	f8ddd8b182	phase: 8, status: plan-as-execute, persona: security-engineer+platform-engineer, task: T-8.1..T-8.4 ... ---ci--- project: acdl phase: 8 milestone: v1.1 status: plan-as-execute persona: security-engineer+platform-engineer task: [T-8.1, T-8.2, T-8.3, T-8.4] requirements.covered: [REQ-23] ---/ci--- Waves 1+2: IAM policy + state backend + IAM user creation scripts. - T-8.1 (security): terraform/bootstrap/spike_runner_policy.json — least-privilege IAM policy: Allow S3 r/w on the state bucket, DynamoDB r/w on the outbox table, sts:GetCallerIdentity; final Deny statement (Action *, NotResource = the above ARNs) enforcing least privilege. No terraform apply permission (plan-only spike). - T-8.2/T-8.3 (platform): terraform/bootstrap/create_state_backend.py — boto3, idempotent: creates S3 bucket acdl-tfstate-581513795199-us-east-1 (versioning enabled) + DynamoDB table acdl-outbox (PAY_PER_REQUEST, PK contractId, SK eventType#eventTs per D-P08-1 one table for both lock + outbox). Writes .bootstrap_state.json marker. - T-8.4 (platform + security review): terraform/bootstrap/create_iam_user.py — boto3, idempotent: creates IAM user acdl-spike-runner, attaches the inline policy from spike_runner_policy.json, creates an initial access key if none active exists (prints to stdout for the orchestrator to capture; NEVER committed). py_compile + policy JSON valid.	2026-07-21 18:58:29 +00:00
Jon Chery	e044a2de0d	phase: 6, status: plan-as-execute, persona: lead-developer, task: T-6.1..T-6.4 ... ---ci--- project: acdl phase: 6 milestone: v1.1 status: plan-as-execute persona: lead-developer tasks: [T-6.1, T-6.2, T-6.3, T-6.4] ---/ci--- Archive the v1.0 demo under demo/ (D-037) and reorient the repo to the real platform. Wave 1 of the Phase 06 plan. - T-6.1: git mv modules/, scripts/, evidence-ui/, contracts/, contracts-repo/, .gitea/ -> demo/; mv ACDL_DEMO.md + runner-data/ -> demo/ - T-6.2: scaffold new v1.1 top-level dirs (platform/, schemas/, adapters/, terraform/, modules-ir/) with .gitkeep - T-6.3: create top-level scripts/verify_phase06.sh (v1.1 verify scripts live at top-level, NOT demo/scripts/ which holds the v1.0 demo verify scripts) - T-6.4: rewrite README.md to reflect the real platform (vision + architecture links, new layout, status v1.1 active); add runner-data/ to .gitignore All moves via git mv (history preserved). Repo root now contains only README.md, demo/, docs/, .ciagent/, and the new empty v1.1 dirs.	2026-07-21 18:27:21 +00:00