Jon Chery
6795acc9eb
fix(alb): create_before_destroy on target group + depends_on on listener
...
acdl-ci / Lint (pull_request) Successful in 8s
acdl-ci / Test (pull_request) Successful in 4m3s
acdl-ci / Platform check-only (offline) (pull_request) Successful in 20s
acdl-modules-lifecycle / CI VPC apply (pull_request) Successful in 37s
acdl-modules-lifecycle / L1 lifecycle (cloudfront) (pull_request) Successful in 19m12s
acdl-modules-lifecycle / L1 lifecycle (alb) (pull_request) Failing after 1m14s
acdl-modules-lifecycle / L1 lifecycle (ecr) (pull_request) Successful in 2m42s
acdl-modules-lifecycle / L1 lifecycle (iam-role) (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (kms-key) (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (rds) (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (s3) (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (uptime) (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (vpc) (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (waf) (pull_request) Has been cancelled
acdl-modules-lifecycle / CI VPC destroy (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (ecs-cluster) (pull_request) Has been cancelled
acdl-modules-lifecycle / L1 lifecycle (ecs-service) (pull_request) Has been cancelled
When the ALB port changes (simple 80 → complex 443), terraform tries to
replace the target group while the listener still references it, causing
ResourceInUse. Added lifecycle { create_before_destroy = true } to the
target group and depends_on = [aws_lb_target_group.this] to the listener
so the new target group is created before the old one is destroyed.
---ci---
project: acdl
phase: P59
milestone: v1.11
status: execute
---/ci---
2026-07-28 18:27:10 +00:00
Jon Chery
c80060878a
feat(P56b): author 11 L1 module terraform subdirs + fix adapter output format
...
EXECUTE stage. Authors the remaining 11 L1 module terraform subdirs with
the full versions/variables/locals/main/outputs split. Defaults previously
hardcoded in the adapter move into locals.tf.
Simple single-resource modules (7):
- kms-key: aws_kms_key + alias (enable_key_rotation, deletion_window defaults)
- ecr: aws_ecr_repository (encryption_configuration from kms_key_arn, image_scanning)
- ecs-cluster: aws_ecs_cluster (name default)
- iam-role: aws_iam_role + inline_policy (assume_role_policy fallback, ECR/logs policy in locals.tf)
- rds: aws_db_instance (storage_encrypted, multi_az, kms_key_arn defaults)
- waf: aws_wafv2_web_acl (default_action, visibility_config, dynamic rules)
- uptime: aws_ecs_task_definition + aws_ecs_service (Fargate compat, container_definitions in locals.tf)
Multi-resource modules with intra-refs (4):
- vpc: aws_vpc + aws_subnet + aws_internet_gateway + aws_route_table (CIDR derivation in locals.tf)
- ecs-service: aws_ecs_task_definition + aws_ecs_service (Fargate compat, container_definitions, network_config in locals.tf)
- alb: aws_lb + aws_lb_target_group + aws_lb_listener (subnet/security_group list derivation in locals.tf)
- cloudfront: aws_cloudfront_distribution + aws_cloudfront_origin_access_control (OAC defaults in locals.tf)
Registry: terraform_dir added to all 11 remaining entries.
Adapter fix: stack output format uses separate 'from' + 'output' fields
(not 'from': 'rid.output'). Fixed _emit_root_output to read both fields.
6 previously-skipped tests unblocked (run_platform.sh --check-only now
resolves static-assets.yml through the new module-assembled adapter).
Removed skip markers. Fixed test assertion (aws_s3_bucket → module).
Regression: 461 passed, 0 skipped, 5 deselected (slow). All 12 modules
pass run_primitive_plan.sh --check-only. All 12 terraform/ subdirs pass
terraform init + validate standalone.
---ci---
project: acdl
phase: P56b
milestone: v1.11
status: execute
---/ci---
2026-07-28 16:07:57 +00:00