14 Commits

Author	SHA1	Message	Date
Jon Chery	93ae9e4a39	verify(P7): contract-resolver-envloader-and-kind — 4-layer verify PASS + ship ... VERIFY: structural — envloader dedup + kind field; behavioral — 49 tests + CI PASS; quality — fragile is_l2 heuristic replaced. ---ci--- project: acdl phase: 7 milestone: v1.16 status: complete phase_role: execution requirements: covered: [REQ-171] partial: [] ---/ci---	2026-08-01 12:38:56 +00:00
Jon Chery	9421442afd	verify(P2): user-facing ACDL→Nova sweep — 4-layer verify PASS + ship ... VERIFY: structural — all user-facing strings Nova; behavioral — 79 tests + CI PASS; security — no creds; quality — new onboarding Nova-header test. REQ-166 complete. Internal ship_phase.sh helper added. ---ci--- project: acdl phase: 2 milestone: v1.16 status: complete phase_role: execution requirements: covered: [REQ-166] partial: [] ---/ci---	2026-08-01 12:12:45 +00:00
Jon Chery	d5bae868a4	feat(P2): Nova rebrand — code/env-vars/consumer-path (REQ-158/159/160) ... core/env.py dual-read helper (D-108); 21 ACDL_*→NOVA_* env vars migrated across core/scripts/adapters/tests/workflows + .env/.env.secrets (key rename, values stay). G-106 binding: run_platform.sh:288-289 + regression_verify.py:309-312 dual-read (NOVA first, ACDL fallback). G-108 binding: Gitea NOVA_* secrets created via API + workflow secrets: refs updated (deploy.yml + modules-lifecycle.yml, .gitea + .github). acdl_tagging.py→nova_tagging.py (D-109 warn mode, nova:* enforced). .acdl/→.nova/ consumer path (resolver + deploy workflow + schema + tests + docs). Test fixtures updated; pytest + run_ci.sh PASS. ---ci--- project: acdl phase: 2 milestone: v1.15 status: execute ---/ci---	2026-07-30 01:25:24 +00:00
Jon Chery	60f767d125	fix(P59): 3 pipeline-readiness fixes — resolver id, schema inputs, CI creds ... 3 fixes found during the pipeline-readiness audit (all 24 example contracts now resolve + adapt + pass --check-only): 1. core/contract_resolver.py: L1 resolver resource id now replaces underscores with hyphens (task_definition → task-definition), matching the L2 resolver pattern. The stack schema requires ^[a-z][a-z0-9-]*$ (no underscores). 2. schemas/stack.schema.json: relaxed input type constraint to allow array + object (was string/number/boolean only). Real-world inputs include lists (monitored_endpoints, static_checks, rules) and dicts (alert_channels). 3. scripts/run_platform.sh: AWS creds loading is now conditional — if AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY are already set (by the CI configure-aws-credentials action), skip loading .env.secrets. This makes the --apply/--destroy modes work in CI without the gitignored secrets file. Regression: 479 passed, 0 skipped, 5 deselected. ---ci--- project: acdl phase: P59 milestone: v1.11 status: execute ---/ci---	2026-07-28 16:07:57 +00:00
Jon Chery	fda4564a7f	feat(P58): single platform VPC + deterministic env-aware state keys ... EXECUTE stage. Fixes the 4-VPC bug: adds a single shared VPC to terraform/platform, drops the vpc child from the microservice composition (references the platform VPC via data source), and makes state keys env-aware (spike/{id}/{env}/terraform.tfstate — stable across lifecycle). Platform VPC (terraform/platform/main.tf): - aws_vpc.acdl_shared (10.0.0.0/16) + 2 subnets + IGW + route table + SG - Outputs: vpc_id, subnet_ids, ecs_security_group_id Microservice composition (modules/l2/microservice/composition.json): - Dropped the vpc child (no per-contract VPC ever again). - Added data_sources block: platform_vpc → terraform_remote_state (platform). - Wires: vpc.outputs.subnet_ids → platform_vpc.outputs.subnet_ids. - Wires: platform_vpc.outputs.vpc_id → alb.inputs.vpc_id. - Wires: platform_vpc.outputs.ecs_security_group_id → service.inputs.security_group. Contract resolver (core/contract_resolver.py): - Added environment to the stack instance (stack.environment). - Added data_sources handling: pseudo-children with outputs but no resources. - data_sources propagated through fragment merge to the final stack instance. Adapter (adapters/terraform/adapter.py): - State key: spike/{stack_name}/{environment}/terraform.tfstate (env-aware). - Emits data "terraform_remote_state" "platform" block when data_sources present. - ref:platform_vpc.<output> → data.terraform_remote_state.platform.outputs.<output>. Tests (tests/test_adapter.py): - test_adapt_env_aware_state_key: spike/msvc/prod/terraform.tfstate. - test_adapt_emits_data_source_block: data.terraform_remote_state.platform. - test_adapt_no_vpc_for_microservice: no resource "aws_vpc" in microservice output. - Updated existing state key assertion (spike/s3/dev/terraform.tfstate). Regression: 467 passed, 0 skipped, 5 deselected. run_platform.sh --check-only passes for both microservice (9 resources, no VPC) and static-assets (5 resources). ---ci--- project: acdl phase: P58 milestone: v1.11 status: execute ---/ci---	2026-07-28 16:07:57 +00:00
Jon Chery	031887ec56	refactor(P57): contract surface redesign + rename + .yml repo-wide ... Contract surface redesign: - New top-level fields: id (3-6 char acronym → stack.name), name (full → stack.title), infrastructure (map keyed by module name, replaces module:) - Drop uses: field (dead reference; version pin lives in CI workflow uses: line) - Drop top-level module/inputs (now nested under infrastructure map) - Per-module optional version (defaults to latest published from registry) - Multi-module contracts: one file deploys N modules in one pipeline run, resource IDs namespaced with module name to avoid collisions - stack.schema.json: add optional title field for display name Rename: - pipelines/deploy.yaml → pipelines/contract.yml (declarative spec, not a pipeline) - pipelines/ci.yaml → pipelines/ci.yml - All 44 .yaml files → .yml repo-wide (contracts, module examples, kyverno policies) - .acdl/contract.yaml → .acdl/contract.yml Resolver (core/contract_resolver.py): - Rewrite resolve() to loop infrastructure map, default version to latest, merge module fragments into one stack with namespaced resource IDs - _latest_version() picks highest non-deprecated from registry - _namespace_resources() prefixes IDs + rewrites ref: expressions for multi-module - Single-module path: unprefixed IDs (backward compatible) Verification: - 494 tests pass (0 contract-shape failures) - Local E2E passes (contract → resolver → adapter → local ECS HTTP 200 → outbox) ---ci--- project: acdl phase: 57 milestone: v1.10.2 status: execute ---/ci---	2026-07-27 21:37:40 +00:00
Jon Chery	cd637808f5	feat(P41): per-environment CI jobs + environment workflow input ... ---ci--- project: acdl phase: 41 milestone: v1.9 status: execute ---/ci--- Phase 41 — per-environment-ci-jobs (REQ-105, REQ-106, D-082): Per-env contracts (REQ-105): - contracts/static-assets.{dev,qa,prod,dr}.yaml + microservice.{dev,qa,prod,dr}.yaml (8 files, each sets environment: to its own name, uses interpolation). - Default contracts/static-assets.yaml + microservice.yaml preserved (backwards compat). Deploy workflow environment input (REQ-106): - .github/workflows/deploy.yml + .gitea/workflows/deploy.yml (byte-identical): new 'environment' workflow_call input (default empty, override). - scripts/run_platform.sh: --environment <name> flag; exports ACDL_ENVIRONMENT_OVERRIDE; re-runs env check against the override. - core/contract_resolver.py: resolve(environment_override=...) (D-088); CLI honors --environment flag + ACDL_ENVIRONMENT_OVERRIDE env var. Consumer guide (REQ-106): - docs/consumer-guide.md: 'Per-environment deployment' section with 4 caller-workflow examples (dev/qa/prod/dr), HITL gate structure (approve_qa/approve_prod/approve_dr, D-042), interpolation reference table. - Documents promotion-without-editing + hybrid model (per-env contracts OR single contract + env input). Tests: +40 (test_per_env_contracts.py, test_deploy_workflow_env_input.py, test_consumer_guide_per_env_section.py). 446 passed; run_ci.sh green; deploy workflows byte-identical.	2026-07-23 04:34:10 +00:00
Jon Chery	bee9d02f01	feat(P40): contract interpolation + environment JSON schema ... ---ci--- project: acdl phase: 40 milestone: v1.9 status: execute ---/ci--- Phase 40 — contract-interpolation (REQ-103, REQ-104, D-081): Interpolation: - core/contract_resolver.py: _expand_vars(value, context) recursively expands ${env.<field>} + ${contract.<field>} tokens (dotted paths supported, e.g. ${env.state_backend.bucket}). Unknown tokens raise ValueError (fail loud). Expansion is post-schema-validation, pre-IR-resolution. - resolve() accepts environment_override (D-088) — overrides the contract's environment field BEFORE schema validation so interpolation context is consistent. - env context loaded via _load_env (self-contained, works as script + package import); 'environment' alias for env 'name' so ${env.environment} resolves. Environment schema + bindings: - schemas/environment.schema.json (draft 2020-12): name, account_id, region, state_backend, network, runner_role_arn, autonomy, confidence_threshold. - core/environments/qa.json, prod.json, dr.json placeholder bindings (attested, thresholds 0.75/0.90/0.95, placeholder account_id with stderr warning at load). - core/environment_check.py: load(env_name) helper + placeholder warning. Sample contracts: - contracts/static-assets.yaml + microservice.yaml use acdl-${env.environment}-${contract.module}-${env.account_id}-${env.region} naming pattern (region + account id + environment). Tests: +35 (test_environment_schema.py, test_interpolation.py, test_sample_contracts_interpolate.py). 406 passed; run_ci.sh green; run_platform.sh --check-only green. Existing fixture-based tests preserved (instance.json static fixtures unaffected).	2026-07-23 04:30:30 +00:00
Jon Chery	e1be05287b	feat(P39): refresh design docs + parameterize adapter (P1-1) ... ---ci--- project: acdl phase: 39 milestone: v1.9 status: execute ---/ci--- Phase 39 — design-doc-refresh-and-p1-1-parameterization: Design docs (REQ-100, REQ-101): - hitl_matrix_design.md: 'dev-only spike'/'v1.2 wires the gates' framing replaced with v1.9 wired-gates reality; 8-concern matrix marked implemented (offline-testable subset + signed evidence artifacts, D-084); v1.9 wiring section cross-references hitl_gates.py + attestation_matrix.py; approver_dr noted. - audit_ledger_design.md: outbox marked shipped+production since v1.8; S3 Object Lock + JWS + async worker + DLQ + daily checkpoints clearly labeled 'Deferred to a future milestone (D-083)'; RPO/RTO table updated; approver fields note v1.9 hitl_gates.attest. P1-1 adapter parameterization (REQ-102, D-085): - ecs-service interface.json: desired_count (default 1), launch_type (FARGATE), family (app) inputs added. - alb interface.json: load_balancer_type (application), target_type (ip). - adapter.py: hardcoded defaults replaced with inputs.get(<name>, <default>); hardcoded 'acdl-microservice-rt'/'acdl-microservice-igw' Name tags derive from the VPC name input. - contract_resolver.py: child_input_map routes wires to the sub-resource that declares the input (desired_count → aws:ecs:service, family → aws:ecs:task_definition, target_type → targetgroup, etc.). - microservice composition.json: wires added for the new inputs. Tests: +21 (test_p1_1_adapter_parameterization.py, test_design_docs_current.py). 371 passed; run_ci.sh green; run_platform.sh --check-only green; v1.1 S3 regression preserved.	2026-07-23 04:24:25 +00:00
Jon Chery	134f85d2df	feat(P34): decommission alias + CMDB validation (REQ-92, REQ-93, REQ-94) ... ---ci--- project: acdl phase: 34 milestone: v1.8 status: execute ---/ci--- - DynamoDB acdl-change-requests table added to terraform/platform/main.tf (PK changeRequestId, SK submittedAt, SSE via CMK, PITR). - validate_change_request Lambda action added to contract_ingestor.py: queries CMDB, asserts status=approved + consumerRepo match. - decommission_transform() added to contract_resolver.py: zeroes all counts (desired_count, min/max_capacity) + sets deletion_protection=false. - Decommission mode added to deploy pipeline + both deploy workflows (mode: decommission + changeRequestId input). Byte-identical. - run_platform.sh --decommission flag: validates CR, resolves with deletion_protection=false (step 1), then decommission_transform (step 2). HITL SRE gates documented. - docs/consumer-guide.md: new "Decommissioning a stack" section with CR request, trigger, 2-step HITL SRE gates, CMK deletion window, uptime. Tests: +14 (318 -> 332). All pass.	2026-07-22 22:18:28 +00:00
Jon Chery	8145eee8fc	feat(P32): deletion-protection-by-default + L2 feature flag (REQ-86, REQ-87) ... ---ci--- project: acdl phase: 32 milestone: v1.8 status: execute ---/ci--- - All 11 L1 primitives now have deletion_protection NFR (boolean, default true). - Adapter emits `lifecycle { prevent_destroy = true }` when NFR is true; omits it when false. Default is true when NFR is absent. - L2 composition resolver propagates inputs.deletion_protection to all children NFRs. When false, all resources get deletion_protection=false. - Stack schema updated with optional features object (deletion_protection, uptime_enabled). - Contract schema description updated to document deletion_protection and uptime_enabled inputs. Tests: +5 (307 -> 312). All pass.	2026-07-22 22:12:42 +00:00
Jon Chery	0eb578c606	fix(P28): WAF nested rules + default_action + resolver outputs (P1-4, P1-5, P1-7) ... ---ci--- project: acdl phase: 28 milestone: v1.8 status: execute ---/ci--- P1-4: WAF custom rules now emit nested `rules { ... }` blocks per rule instead of `rules = [...]` attribute syntax (invalid HCL). P1-5: WAF default_action input is honored (allow/block) instead of hardcoding `allow {}`. Default is `allow` when absent (backward compat). P1-7: L2 composition outputs[] array is now processed by resolve_l2(). The resolver builds stack.outputs from the composition outputs wires. The adapter emits `output` blocks from stack.outputs. Tests: +10 (275 -> 285). All pass. run_platform.sh --check-only green.	2026-07-22 22:03:54 +00:00
Jon Chery	a4b17d0f26	fix(P26): resolve multi-resource L1 ref ids in contract resolver ... ---ci--- project: acdl phase: 26 milestone: v1.7 status: execute ---/ci--- The microservice pattern (and any L2 referencing multi-resource L1s like vpc) failed at the adapter stage because the resolver emitted refs using the child id (e.g. 'vpc') instead of the expanded sub-resource id (e.g. 'vpc-subnet'). The adapter's type_by_id table only knows the sub-resource ids, so ref:vpc.subnet_ids was an unknown resource id. Fix: - contract_resolver.py: child_outputs now maps {outputName -> resourceId} instead of just the interface outputs dict. For multi-resource L1s, the ref uses the sub-resource id that produces the output. For single-resource L1s, the resourceId == childId (unchanged behavior). - vpc interface.json: the subnet sub-resource output is 'subnet_ids' (matching the interface-level output name) instead of 'subnet_id'. - adapter.py OUTPUT_MAP: aws:ec2:subnet now maps both 'subnet_ids' and 'subnet_id' to 'id'. Verification: - microservice pattern check-only: PASS (11 resources) - static-assets pattern check-only: PASS (4 resources) - platform check-only: PASS - full test suite: 266 passed	2026-07-22 20:15:59 +00:00
Jon Chery	b758a7c242	refactor(P21): rename acdl_platform/ -> core/ (REQ-53) ... ---ci--- project: acdl phase: 21 milestone: v1.6 status: execute ---/ci--- Rename the acdl_platform/ package to core/ across the directory, all imports in tests/scripts/pipelines/workflows, and doc references. The package is imported as core.confidence_signal / core.contract_resolver / core.outbox_writer. The deploy workflow's platform-repo checkout dir is renamed acdl-platform/ -> platform/ (workspace path, not the python package). Both .gitea + .github workflows stay byte-identical. Note: the original target name 'platform/' shadows Python's stdlib platform module (pytest's import uuid -> platform.system() fails when the repo root is on sys.path, which every test does). 'core/' avoids the clash while honoring the intent (drop the verbose acdl_platform). Tests: 154 pass. run_ci.sh green.	2026-07-22 18:21:12 +00:00