5 Commits

Author	SHA1	Message	Date
Jon Chery	69d8496107	docs(P06): complete alb-name-prefix-fix phase (v1.13.9) ... ---ci--- project: acdl phase: 6 milestone: v1.14 status: complete requirements: covered: [REQ-140] partial: [] ---/ci---	2026-07-29 20:38:14 +00:00
Jon Chery	a03c01932f	fix(P60/P62): ALB name_prefix + adapter dedup + L2 composition wiring ... Three fixes from CI run 3027 (06f4fc7): 1. ALB name_prefix too long: AWS limits target group name_prefix to 6 chars. Changed from "acdl-ci-alb-" (12) to "tg-ci-" (6). 2. Adapter deduplication: multi-resource L1s (cloudfront with distribution + OAC) expand to multiple stack resources sharing the same terraform dir. The adapter was emitting TWO module blocks for the same dir, the second missing required inputs. Now deduplicates by terraform dir, merging inputs from all resources that point to it. Adapter stays under 200 lines (194). 3. L2 microservice composition: ECR module requires "name" input but the composition didn't wire it. Added wires for ecr.inputs.name (default "app-repo") and roles.inputs.role_name (default "app-role"). Note: the ecs-service/uptime/rds failures in run 3027 were caused by the P64 teardown destroying the CI VPC while the pipeline was still running (timing issue). The next CI run after this push will have a fresh CI VPC. Regression: 485 passed, 5 deselected. ---ci--- project: acdl phase: P60 milestone: v1.11 status: execute ---/ci---	2026-07-29 12:22:00 +00:00
Jon Chery	4dad967910	fix(P60): ALB target group name_prefix — avoid orphaned resource conflicts ... The ALB lifecycle test was failing with "ELBv2 Target Group (acdl-ci-alb) already exists" because a prior failed run left an orphaned target group in AWS. The deterministic state key means terraform reuses the same state, but create_before_destroy tries to create a new target group with the same name before destroying the old one → conflict. Fix: use name_prefix instead of name for the target group. AWS auto-generates a unique name (e.g. acdl-ci-alb-2026072812001234567), so create_before_destroy can create the new target group without conflicting with the orphaned one. The old orphaned target group is eventually garbage-collected by AWS (or cleaned up by a future run's destroy step). This is the standard terraform pattern for create_before_destroy resources with name uniqueness constraints. ---ci--- project: acdl phase: P60 milestone: v1.11 status: execute ---/ci---	2026-07-28 20:22:41 +00:00
Jon Chery	6795acc9eb	fix(alb): create_before_destroy on target group + depends_on on listener ... When the ALB port changes (simple 80 → complex 443), terraform tries to replace the target group while the listener still references it, causing ResourceInUse. Added lifecycle { create_before_destroy = true } to the target group and depends_on = [aws_lb_target_group.this] to the listener so the new target group is created before the old one is destroyed. ---ci--- project: acdl phase: P59 milestone: v1.11 status: execute ---/ci---	2026-07-28 18:27:10 +00:00
Jon Chery	c80060878a	feat(P56b): author 11 L1 module terraform subdirs + fix adapter output format ... EXECUTE stage. Authors the remaining 11 L1 module terraform subdirs with the full versions/variables/locals/main/outputs split. Defaults previously hardcoded in the adapter move into locals.tf. Simple single-resource modules (7): - kms-key: aws_kms_key + alias (enable_key_rotation, deletion_window defaults) - ecr: aws_ecr_repository (encryption_configuration from kms_key_arn, image_scanning) - ecs-cluster: aws_ecs_cluster (name default) - iam-role: aws_iam_role + inline_policy (assume_role_policy fallback, ECR/logs policy in locals.tf) - rds: aws_db_instance (storage_encrypted, multi_az, kms_key_arn defaults) - waf: aws_wafv2_web_acl (default_action, visibility_config, dynamic rules) - uptime: aws_ecs_task_definition + aws_ecs_service (Fargate compat, container_definitions in locals.tf) Multi-resource modules with intra-refs (4): - vpc: aws_vpc + aws_subnet + aws_internet_gateway + aws_route_table (CIDR derivation in locals.tf) - ecs-service: aws_ecs_task_definition + aws_ecs_service (Fargate compat, container_definitions, network_config in locals.tf) - alb: aws_lb + aws_lb_target_group + aws_lb_listener (subnet/security_group list derivation in locals.tf) - cloudfront: aws_cloudfront_distribution + aws_cloudfront_origin_access_control (OAC defaults in locals.tf) Registry: terraform_dir added to all 11 remaining entries. Adapter fix: stack output format uses separate 'from' + 'output' fields (not 'from': 'rid.output'). Fixed _emit_root_output to read both fields. 6 previously-skipped tests unblocked (run_platform.sh --check-only now resolves static-assets.yml through the new module-assembled adapter). Removed skip markers. Fixed test assertion (aws_s3_bucket → module). Regression: 461 passed, 0 skipped, 5 deselected (slow). All 12 modules pass run_primitive_plan.sh --check-only. All 12 terraform/ subdirs pass terraform init + validate standalone. ---ci--- project: acdl phase: P56b milestone: v1.11 status: execute ---/ci---	2026-07-28 16:07:57 +00:00