verify(P19): onboarding-envfile-autogen — 4-layer verify PASS + ship

VERIFY: structural — onboarding.py + rebranded message; behavioral — 18 tests + CI PASS; quality — self-service request path (no human handoff).

---ci---
project: acdl
phase: 19
milestone: v1.16
status: complete
phase_role: execution
requirements:
  covered: [REQ-183]
  partial: []
---/ci---

tests/test_environment_check.py

@@ -21,7 +21,10 @@ class TestEnvironmentCheck:
         assert ok is False
         assert "nonexistent-env" in msg
         assert "onboarding" in msg.lower() or "Environment Onboarding" in msg
-        assert "platform team" in msg.lower()
+        # P19 (REQ-183): the message now routes to the self-service
+        # request path (onboard_consumer), not "contact the platform team".
+        assert "platform team" not in msg.lower()
+        assert "onboard_consumer" in msg or "self-service" in msg.lower()
 
     def test_onboarding_message_lists_platform_provisions(self):
         msg = _onboarding_message("qa")
@@ -102,4 +105,16 @@ class TestRunPlatformWireIn:
         )
         assert result.returncode == 0, f"stdout: {result.stdout}\nstderr: {result.stderr}"
         assert "PLATFORM CHECK OK" in result.stdout
-        assert "environment" in result.stdout.lower() or "Step 0" in result.stdout
+        assert "environment" in result.stdout.lower() or "Step 0" in result.stdout
+
+class TestOnboardingMessageSelfService:
+    """P19 (REQ-183): the onboarding message is self-service, not 'contact
+    the platform team'."""
+
+    def test_no_contact_platform_team(self):
+        msg = _onboarding_message("qa")
+        assert "contact the platform team" not in msg.lower()
+
+    def test_mentions_self_service_request(self):
+        msg = _onboarding_message("qa")
+        assert "self-service" in msg.lower() or "onboard_consumer" in msg

tests/test_onboarding.py

@@ -0,0 +1,50 @@
+"""Unit tests for core/onboarding.py (P19, REQ-183)."""
+
+import json
+import sys
+from pathlib import Path
+
+import pytest
+
+sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
+
+from core.onboarding import generate_env_file, _onboarding_request_message
+
+
+class TestGenerateEnvFile:
+    """P19 (REQ-183): generate_env_file produces a valid env JSON."""
+
+    def test_generates_env_with_request_fields(self):
+        request = {
+            "consumerRepo": "acdl/consumer-b",
+            "requestedEnvironment": "qa",
+            "ownerId": "team-b",
+            "billingTag": "cost-center-b",
+        }
+        env = generate_env_file(request, template_env="dev")
+        assert env["name"] == "qa"
+        assert env["ownerId"] == "team-b"
+        assert env["billingTag"] == "cost-center-b"
+        assert env["account_id"] == "000000000000"  # placeholder
+        assert "consumer-b" in env["description"]
+
+    def test_preserves_template_network_and_state(self):
+        request = {
+            "consumerRepo": "acdl/c",
+            "requestedEnvironment": "prod",
+            "ownerId": "team-a",
+            "billingTag": "cc-a",
+        }
+        env = generate_env_file(request, template_env="dev")
+        assert "vpc_cidr" in env["network"]
+        assert "bucket" in env["state_backend"]
+        assert env["region"] == "us-east-1"
+
+
+class TestOnboardingRequestMessage:
+    """P19 (REQ-183): the request message is self-service."""
+
+    def test_message_mentions_onboard_consumer(self):
+        msg = _onboarding_request_message("dev")
+        assert "onboard_consumer" in msg
+        assert "Nova" in msg