verify(P28-38): code review — 1 P0 auto-fixed, 3 P1 fixes, 2 P1 flagged
---ci--- project: acdl phase: 28-38 milestone: v1.8 status: verify lessons: - P0 fix: pipelines/deploy.yaml stale terraform/spike paths updated to run_platform.sh - P1 fix: removed import sys from inside _emit_resource function body - P1 fix: removed unused cpu/memory vars in uptime emission - P1 fix: decommission consumerRepo now uses GITHUB_REPOSITORY env ---/ci--- P0: deploy.yaml 3 stage commands referenced removed terraform/spike dir. P1 fixes: import sys, unused vars, consumerRepo env. P1 flagged: uptime hardcoded subnet/sg, uses ref not bumped to v1.8. P2 flagged: deploy-uptime flag standalone, pre-v1.8 READMEs missing NFRs. Tests: 350 passed.
This commit is contained in:
@@ -129,7 +129,7 @@ if [ "$DECOMMISSION" = "1" ]; then
|
||||
echo ""
|
||||
echo "=== Decommission Step 1: validate change request against CMDB ==="
|
||||
[ -n "$CHANGE_REQUEST_ID" ] || fail "change request ID required for decommission mode"
|
||||
CONSUMER_REPO=$(python3 -c "import yaml; c=yaml.safe_load(open('$CONTRACT')); print(c.get('module','unknown'))" 2>/dev/null || echo "unknown")
|
||||
CONSUMER_REPO="${GITHUB_REPOSITORY:-$(python3 -c "import yaml; c=yaml.safe_load(open('$CONTRACT')); print(c.get('module','unknown'))" 2>/dev/null || echo 'unknown')}"
|
||||
python3 -c "
|
||||
import json, sys
|
||||
sys.path.insert(0, '$ROOT')
|
||||
|
||||
Reference in New Issue
Block a user