From 79e7a4a304410d96c8dd0f84effb70d754956b43 Mon Sep 17 00:00:00 2001 From: Jon Chery Date: Wed, 29 Jul 2026 20:24:13 +0000 Subject: [PATCH] docs(P03): complete lifecycle-script-arg-cleanup phase (v1.13.6) ---ci--- project: acdl phase: 3 milestone: v1.14 status: complete requirements: covered: [REQ-137] partial: [] ---/ci--- --- scripts/run_l2_lifecycle_destroy.sh | 9 ++++++++- scripts/run_l2_lifecycle_test.sh | 10 +++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/scripts/run_l2_lifecycle_destroy.sh b/scripts/run_l2_lifecycle_destroy.sh index fee8604..246d9d2 100755 --- a/scripts/run_l2_lifecycle_destroy.sh +++ b/scripts/run_l2_lifecycle_destroy.sh @@ -1,11 +1,18 @@ #!/usr/bin/env bash # scripts/run_l2_lifecycle_destroy.sh — run a single L2 module lifecycle destroy. # -# Usage: run_l2_lifecycle_destroy.sh [ci-vpc-outputs.json] +# Usage: run_l2_lifecycle_destroy.sh # # Wraps run_platform.sh for L2 composition modules in the modules-lifecycle # pipeline. Sets ACDL_REMOTE_STATE_KEY to point to the CI VPC state. # +# NOTE: unlike the L1 scripts (run_lifecycle_destroy.sh), the L2 path does +# NOT take a ci-vpc-outputs.json argument. L2 compositions reference the +# platform VPC via terraform_remote_state (a data source), not by injecting +# VPC outputs into the contract. The workflow passes 2 positional args for +# parity with the L1 matrix, but $2 is accepted-but-ignored here (documented, +# not a bug). +# # Lifecycle mode (REQ-134): ACDL_LIFECYCLE_MODE default "plan" = no-op # (plan mode never applies resources, so there is nothing to destroy). # Set to "full" for the real `--destroy` against live AWS. diff --git a/scripts/run_l2_lifecycle_test.sh b/scripts/run_l2_lifecycle_test.sh index a46214a..01420be 100755 --- a/scripts/run_l2_lifecycle_test.sh +++ b/scripts/run_l2_lifecycle_test.sh @@ -1,13 +1,21 @@ #!/usr/bin/env bash # scripts/run_l2_lifecycle_test.sh — run a single L2 module lifecycle apply/modify. # -# Usage: run_l2_lifecycle_test.sh [ci-vpc-outputs.json] +# Usage: run_l2_lifecycle_test.sh # # Wraps run_platform.sh for L2 composition modules in the modules-lifecycle # pipeline. Sets ACDL_REMOTE_STATE_KEY to point to the CI VPC state so the # microservice composition's terraform_remote_state data source reads from # the short-lived CI VPC (not the long-lived platform VPC). # +# NOTE: unlike the L1 scripts (run_lifecycle_test.sh), the L2 path does NOT +# take a ci-vpc-outputs.json argument. L2 compositions reference the platform +# VPC via terraform_remote_state (a data source), not by injecting VPC +# outputs into the contract. The ACDL_REMOTE_STATE_KEY env var points the +# data source at the correct CI VPC state key. The workflow passes 3 +# positional args for parity with the L1 matrix, but $3 is accepted-but- +# ignored here (documented, not a bug). +# # Lifecycle mode (REQ-134): ACDL_LIFECYCLE_MODE default "plan" runs # `run_platform.sh --plan-only` (fast, no AWS mutation). Set to "full" for # the real `--apply` against live AWS.