fix(P60): ALB target group name_prefix — avoid orphaned resource conflicts
acdl-ci / Lint (pull_request) Successful in 7s
acdl-ci / Platform check-only (offline) (pull_request) Successful in 21s
acdl-modules-lifecycle / CI VPC apply (pull_request) Successful in 39s
acdl-ci / Test (pull_request) Successful in 4m18s
acdl-modules-lifecycle / L1 lifecycle (alb) (pull_request) Failing after 1m4s
acdl-modules-lifecycle / L1 lifecycle (cloudfront) (pull_request) Successful in 8m51s
acdl-modules-lifecycle / L1 lifecycle (ecr) (pull_request) Successful in 2m37s
acdl-modules-lifecycle / L1 lifecycle (ecs-cluster) (pull_request) Successful in 3m0s
acdl-modules-lifecycle / L1 lifecycle (iam-role) (pull_request) Successful in 2m43s
acdl-modules-lifecycle / L1 lifecycle (ecs-service) (pull_request) Successful in 4m4s
acdl-modules-lifecycle / L1 lifecycle (kms-key) (pull_request) Successful in 2m53s
acdl-modules-lifecycle / L1 lifecycle (s3) (pull_request) Successful in 2m48s
acdl-modules-lifecycle / L1 lifecycle (uptime) (pull_request) Successful in 3m45s
acdl-modules-lifecycle / L1 lifecycle (vpc) (pull_request) Successful in 2m46s
acdl-modules-lifecycle / L1 lifecycle (waf) (pull_request) Successful in 3m8s
acdl-modules-lifecycle / L2 lifecycle (microservice) (pull_request) Failing after 54s
acdl-modules-lifecycle / L2 lifecycle (static-assets) (pull_request) Failing after 55s
acdl-modules-lifecycle / L1 lifecycle (rds) (pull_request) Successful in 32m32s
acdl-modules-lifecycle / CI VPC destroy (pull_request) Failing after 20m33s

The ALB lifecycle test was failing with "ELBv2 Target Group (acdl-ci-alb)
already exists" because a prior failed run left an orphaned target group
in AWS. The deterministic state key means terraform reuses the same state,
but create_before_destroy tries to create a new target group with the same
name before destroying the old one → conflict.

Fix: use name_prefix instead of name for the target group. AWS auto-generates
a unique name (e.g. acdl-ci-alb-2026072812001234567), so create_before_destroy
can create the new target group without conflicting with the orphaned one.
The old orphaned target group is eventually garbage-collected by AWS (or
cleaned up by a future run's destroy step).

This is the standard terraform pattern for create_before_destroy resources
with name uniqueness constraints.

---ci---
project: acdl
phase: P60
milestone: v1.11
status: execute
---/ci---
This commit is contained in:
Jon Chery
2026-07-28 20:22:41 +00:00
parent 6441633568
commit 4dad967910
+1 -1
View File
@@ -6,7 +6,7 @@ resource "aws_lb" "this" {
}
resource "aws_lb_target_group" "this" {
name = var.name
name_prefix = "${var.name}-"
port = var.port
protocol = var.protocol
vpc_id = var.vpc_id