continuous-intelligence/acdl
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 128 Wiki Activity

feat(P67b): lifecycle tests default to plan-only; ACDL_LIFECYCLE_MODE flag overrides to full (REQ-134)

Browse Source 
---
ci---
project: acdl
phase: 67b
milestone: v1.12
status: execute
---
/ci---

The modules-lifecycle pipeline now defaults to plan-only (fast, no AWS
mutation, no credentials, no cost) so it runs on every PR. A CI variable
ACDL_LIFECYCLE_MODE (workflow_dispatch input 'lifecycle_mode', default
'plan') overrides to 'full' for the real apply->modify->destroy against
live AWS.

Scripts: run_lifecycle_test.sh / run_lifecycle_destroy.sh /
run_l2_lifecycle_test.sh / run_l2_lifecycle_destroy.sh read the flag and
dispatch to --plan-only (plan mode) or --apply/--destroy (full mode).
Destroy is a no-op exit 0 in plan mode (nothing was applied). VPC-output
injection is gated on full mode.

Workflows: both .github + .gitea (byte-identical) expose lifecycle_mode
as a workflow_dispatch input (choice: plan/full), pass it via env:
ACDL_LIFECYCLE_MODE to every lifecycle step, skip ci-vpc-apply +
ci-vpc-destroy + Read-CI-VPC-outputs in plan mode, and run the lifecycle
+ l2-lifecycle jobs with if: always() so they execute (plan-only) even
when ci-vpc-apply is skipped.

Contract + schema: pipelines/modules-lifecycle.yml gains default_mode:
plan; the schema accepts default_mode (enum plan|full) and a richer
workflow_dispatch inputs shape.

Tests: 14 new tests in test_lifecycle_mode_flag.py (script dispatch) +
10 new tests in TestModulesLifecyclePipeline (workflow flag wiring,
byte-identity, plan-mode skips). Updated test_platform_vpc_destroy to
reflect the plan-mode skip. 516 tests pass; smoke-tested plan mode on
the s3 module (--plan-only green, no AWS apply).
This commit is contained in:
Jon Chery
2026-07-29 13:16:03 +00:00
parent 76364c33c2
commit 41c3377b96
11 changed files with 347 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.ciagent/REQUIREMENTS.md
+16
View File
@@ -576,6 +576,21 @@ two probe fixes required to make the deck claims true.
Marp structure (including the A6 Operating Model & Cost section that
was missing from the talking points). PPTX exported to the v1.12.0
release. (Phase 69, Phase 70)
- **REQ-134** — The `modules-lifecycle` pipeline defaults to **plan-only**
(fast, no AWS mutation) so it runs on every PR without cost or AWS
credentials. A CI variable `ACDL_LIFECYCLE_MODE` (workflow input
`lifecycle_mode`, default `plan`) overrides to `full` for the real
apply→modify→destroy against live AWS. The four lifecycle scripts
(`run_lifecycle_test.sh`, `run_lifecycle_destroy.sh`,
`run_l2_lifecycle_test.sh`, `run_l2_lifecycle_destroy.sh`) read the
flag and dispatch to `--plan-only` (plan mode) or `--apply`/`--destroy`
(full mode). Both forge workflows (`.github` + `.gitea`, byte-identical)
expose `lifecycle_mode` as a `workflow_dispatch` input and pass it via
`env:` to every lifecycle step; the CI VPC apply/destroy jobs are
skipped in plan mode. `pipelines/modules-lifecycle.yml` + the schema
document the `default_mode: plan` field. Tests assert the plan-only
default, the override path, the byte-identity of both workflows, and
the CI VPC skip in plan mode. (Phase 67b)
### v1.12 Traceability
@@ -583,6 +598,7 @@ two probe fixes required to make the deck claims true.
|-------------|-------|--------|
| REQ-129 | P67 | planned |
| REQ-130 | P67 | planned |
| REQ-134 | P67b | planned |
| REQ-131 | P68, P70 | planned |
| REQ-132 | P68 | planned |
| REQ-133 | P69, P70 | planned |