verify(P57): code review — 3 P0 auto-fixed, 2 P1+ flagged

Multi-persona review of the contract surface redesign (031887e + 10b87a6).

P0-1 (auto-fixed): scripts/run_platform.sh:437 read the uptime_enabled
feature flag from the OLD top-level contract.inputs.uptime_enabled path,
which P57 removed. With the new contract shape c.get('inputs',{}) returns
{} so the flag silently always defaulted to True — a consumer setting
uptime_enabled:false under infrastructure.<module>.inputs could NOT
disable uptime monitoring. Fixed to scan
infrastructure.<module>.inputs.uptime_enabled (any module false wins).

P0-2 (auto-fixed): docs/consumer-guide.md:417,472 documented the
${contract.module} interpolation token, but P57 dropped the `module`
field. _expand_vars fails loud (D-081) on unknown tokens, so a consumer
following the documented bucket_name example
(acdl-${env.environment}-${contract.module}-...) hit a hard ValueError
at resolve time. Replaced with ${contract.id} (the surviving short
acronym field) in both the example and the interpolation reference table.

P0-3 (auto-fixed): core/regression_verify.py CAP-006 and
tests/test_consumer_guide_per_env_section.py both asserted the dropped
${contract.module} token. Updated CAP-006 to use ${contract.id} and the
doc test to assert ${contract.id} present / ${contract.module} absent.

P1+ flags (post-hoc):
- P1: _namespace_resources does not rewrite ref: targets in
  stack.outputs[].from for cross-module refs (within-module is handled;
  multi-module refs across fragments are not wired today, but no
  contract uses them yet).
- P1: _latest_version raises ValueError (not a clear message) on a
  malformed semver string in the registry; the schema pins version to
  ^\d+\.\d+\.\d+$ so this is unreachable from a contract, but registry
  authors have no guardrail.
- P2: docs/consumer-guide.md:407 example path uses .yaml extension while
  the repo-wide rename standardized on .yml (consumer-repo paths, not
  platform, so non-blocking).

---ci---
project: acdl
phase: 57
milestone: v1.10.2
status: verify
lessons:
  - P0 fix applied: uptime_enabled read path migrated to infrastructure.<module>.inputs (was stale top-level contract.inputs)
  - P0 fix applied: docs + tests migrated off dropped ${contract.module} interpolation token to ${contract.id}
---/ci---

docs/consumer-guide.md

@@ -404,8 +404,8 @@ input). Promotion = running the matching job.
 ### Two shapes (both supported)
 
 **Shape 1 — per-environment contract files:** a consumer repo has one
-contract per environment (e.g. `.acdl/static-assets.dev.yaml`,
-`.acdl/static-assets.qa.yaml`, …). Each sets `environment:` to its own
+contract per environment (e.g. `.acdl/static-assets.dev.yml`,
+`.acdl/static-assets.qa.yml`, …). Each sets `environment:` to its own
 name and uses interpolation so env-specific values differ automatically:
 
 ```yaml
@@ -414,7 +414,7 @@ id: assets
 infrastructure:
   static-assets:
     inputs:
-      bucket_name: acdl-${env.environment}-${contract.module}-${env.account_id}-${env.region}
+      bucket_name: acdl-${env.environment}-${contract.id}-${env.account_id}-${env.region}
       region: ${env.region}
     version: 1.0.0
 name: static-assets
@@ -469,7 +469,7 @@ duties check blocks a prod promotion when `approver_qa == approver_prod`
 | `${env.account_id}` | the environment's AWS account id | `123456789012` |
 | `${env.state_backend.bucket}` | the environment's state bucket | `acdl-qa-state` |
 | `${env.network.vpc_cidr}` | the environment's VPC CIDR | `10.1.0.0/16` |
-| `${contract.module}` | the contract's module name | `static-assets` |
+| `${contract.id}` | the contract's operational acronym | `assets` |
 | `${contract.environment}` | the contract's environment field | `qa` |
 | `${contract.inputs.<name>}` | a contract input value | (as declared) |